SharpSource v1.32.0 — Evaluation Report

Automated analysis across 560 open-source C# repositories Â· March 2026

560

Repos Analyzed

178

With Findings

219

Clean

126980

Total Diagnostics

Unique Rules

Repository Overview (Repos with Findings)

Repository	Diagnostics	Unique Rules	Top Rules
FreeSql	16246	20	SS019(8454), SS002(2040), SS018(1458)
Facepunch.Steamworks	6570	12	SS017(5382), SS008(900), SS019(56)
UnityCsReference	4864	21	SS017(2324), SS008(1190), SS019(300)
ServiceStack	4340	28	SS066(718), SS008(620), SS019(428)
SqlSugar	3788	22	SS002(2062), SS049(456), SS034(230)
FastReport	3606	17	SS003(882), SS058(816), SS019(594)
smtp4dev	3332	18	SS023(1656), SS066(466), SS051(336)
Masuit.Tools	3000	15	SS003(1022), SS002(676), SS019(280)
better-genshin-impact	2852	22	SS003(1834), SS002(484), SS066(124)
TensorFlow.NET	2662	14	SS013(1816), SS004(464), SS066(104)
ant-design-blazor	2544	18	SS066(988), SS002(344), SS004(180)
ILRuntime	2420	18	SS019(596), SS018(564), SS004(364)
OpenRA	2320	16	SS003(1242), SS066(306), SS004(296)
Lean	2106	19	SS066(1662), SS019(114), SS018(82)
xdm	2068	13	SS066(950), SS002(214), SS048(196)
StockSharp	2048	18	SS066(572), SS017(450), SS019(220)
R3	2014	13	SS066(1406), SS001(208), SS017(104)
LibreHardwareMonitor	1974	10	SS017(904), SS019(588), SS003(254)
FASTER	1924	12	SS017(712), SS066(480), SS003(448)
NanUI	1914	10	SS017(560), SS066(550), SS003(280)
roslynator	1720	12	SS019(892), SS018(486), SS017(198)
server	1624	22	SS059(564), SS004(232), SS001(140)
mathnet-numerics	1602	12	SS003(1064), SS019(170), SS023(96)
WTM	1594	20	SS033(382), SS034(312), SS058(242)
ModernWpf	1576	15	SS019(586), SS018(292), SS017(240)
FluentFTP	1576	14	SS002(280), SS033(262), SS019(252)
opencvsharp	1358	14	SS008(588), SS066(570), SS017(102)
Eto	1344	12	SS066(424), SS008(408), SS003(216)
Polly	1322	10	SS017(422), SS033(318), SS004(136)
AngleSharp	1318	14	SS019(370), SS008(230), SS018(200)
PicView	1296	10	SS066(1074), SS003(68), SS019(56)
WPF-Samples	1222	12	SS049(252), SS019(248), SS011(242)
subtitleedit	1112	15	SS058(550), SS003(240), SS019(104)
DotNetty	1080	12	SS003(522), SS034(300), SS035(108)
Power-Fx	1014	22	SS004(596), SS008(86), SS019(80)
Ocelot	978	16	SS033(450), SS066(168), SS003(60)
octokit.net	954	18	SS034(586), SS002(256), SS032(24)
MessagePack-CSharp	938	15	SS003(284), SS046(240), SS017(212)
NLog	910	12	SS017(316), SS066(170), SS019(126)
quartznet	892	13	SS059(532), SS008(148), SS003(64)
ClosedXML	858	15	SS008(208), SS003(168), SS017(122)
opentk	836	13	SS008(486), SS017(132), SS003(84)
NAudio	736	13	SS003(302), SS017(244), SS066(68)
cairoshell	724	12	SS019(256), SS066(144), SS011(112)
Blog.Core	708	17	SS002(316), SS033(58), SS034(58)
CsvHelper	674	9	SS017(310), SS002(76), SS059(62)
btcpayserver	662	17	SS033(290), SS034(166), SS037(78)
LiteDB	646	12	SS019(206), SS066(186), SS002(78)
QRCoder	602	4	SS003(420), SS017(154), SS002(14)
Akka.NET	590	16	SS017(116), SS008(112), SS019(80)
FastEndpoints	588	17	SS019(130), SS033(106), SS017(94)
lively	586	11	SS019(182), SS066(128), SS003(110)
netmq	582	14	SS004(144), SS008(96), SS019(90)
MassTransit	548	12	SS017(162), SS048(140), SS003(70)
SharpZipLib	544	12	SS003(150), SS023(84), SS033(74)
LiteMonitor	542	11	SS066(256), SS003(102), SS002(98)
libgit2sharp	540	10	SS017(278), SS008(72), SS041(60)
Jackett	540	20	SS002(188), SS058(80), SS003(72)
MelonLoader	528	14	SS003(112), SS017(76), SS019(72)
Ombi	520	19	SS002(224), SS004(72), SS059(44)
P	492	15	SS004(248), SS058(58), SS019(50)
puppeteer-sharp	484	8	SS066(200), SS008(172), SS034(52)
Inveigh	472	7	SS051(144), SS019(120), SS002(78)
OpenUtau	470	17	SS003(192), SS017(88), SS051(50)
Bulk-Crap-Uninstaller	464	13	SS003(142), SS066(92), SS017(74)
UniTask	458	10	SS017(236), SS051(88), SS066(72)
MQTTnet	456	12	SS066(228), SS034(64), SS017(40)
SignalR	406	11	SS034(236), SS066(44), SS003(36)
Dapper	400	8	SS019(112), SS059(72), SS018(64)
ExcelDataReader	400	6	SS019(144), SS003(144), SS066(64)
g-helper	400	9	SS017(132), SS003(92), SS019(62)
git-credential-manager	396	10	SS033(150), SS066(108), SS017(80)
Util	384	19	SS033(122), SS019(54), SS049(46)
Il2CppDumper	380	7	SS004(128), SS003(96), SS019(96)
SwarmUI	378	21	SS051(150), SS003(50), SS058(44)
cecil	376	7	SS019(104), SS017(80), SS018(64)
RestSharp	340	9	SS002(88), SS066(82), SS037(48)
Vue.NetCore	334	17	SS002(140), SS049(82), SS044(16)
MemoryPack	328	12	SS017(242), SS066(24), SS003(18)
YamlDotNet	326	9	SS004(100), SS008(60), SS017(60)
Windows-Auto-Night-Mode	284	14	SS002(148), SS001(26), SS003(20)
LiteNetLib	280	10	SS003(108), SS017(60), SS019(36)
TwitchDownloader	276	14	SS034(68), SS003(64), SS048(50)
commandline	276	9	SS004(112), SS019(48), SS002(24)
Autofac	256	10	SS066(104), SS017(52), SS060(32)
LLamaSharp	244	12	SS017(100), SS066(58), SS003(30)
StableSwarmUI	236	19	SS051(92), SS033(28), SS058(26)
winsw	230	10	SS017(108), SS033(30), SS023(24)
XUnity.AutoTranslator	224	15	SS019(32), SS018(30), SS017(26)
WeiXinMPSDK	224	10	SS056(112), SS033(54), SS059(16)
VPet	222	13	SS004(114), SS002(46), SS066(16)
slskd	206	11	SS033(54), SS059(42), SS004(30)
pythonnet	182	18	SS017(56), SS003(26), SS023(18)
VFSForGit	180	10	SS066(40), SS002(34), SS017(28)
Papercut-SMTP	174	10	SS002(76), SS066(56), SS059(12)
BruteShark	172	11	SS008(52), SS066(32), SS058(30)
FlaUI	170	8	SS003(72), SS066(30), SS023(30)
DotnetSpider	156	15	SS002(52), SS008(18), SS019(12)
openai	154	11	SS023(54), SS019(36), SS066(18)
luban	152	12	SS004(62), SS048(22), SS034(16)
netch	146	10	SS004(40), SS019(40), SS066(28)
NetCoreServer	138	4	SS003(64), SS034(60), SS066(12)
Serilog	134	3	SS017(64), SS066(56), SS003(14)
OneOf	130	3	SS017(120), SS033(8), SS004(2)
Flow.Launcher	126	11	SS002(26), SS019(24), SS008(22)
Respawn	124	3	SS058(84), SS066(24), SS059(16)
Translumo	122	10	SS066(48), SS034(26), SS017(12)
modular-monolith-with-ddd	116	7	SS059(64), SS002(20), SS017(16)
imewlconverter	108	8	SS058(28), SS003(26), SS017(20)
C-Sharp-Algorithms	108	6	SS003(66), SS023(18), SS020(14)
videoduplicatefinder	102	12	SS001(26), SS059(10), SS033(10)
CAP	94	6	SS002(52), SS033(24), SS059(8)
ink	94	11	SS017(26), SS008(20), SS019(12)
AutoMapper	90	4	SS017(40), SS004(30), SS058(10)
hashids.net	90	3	SS020(48), SS003(24), SS046(18)
Hearthstone-Deck-Tracker	88	6	SS001(42), SS011(24), SS002(12)
XboxDownload	86	11	SS019(38), SS002(12), SS058(8)
FluentAssertions	86	9	SS005(38), SS004(18), SS003(8)
BepInEx	84	9	SS017(24), SS002(18), SS066(12)
optick	84	7	SS008(24), SS051(20), SS002(16)
fluentmigrator	78	9	SS066(20), SS019(20), SS004(12)
BBDown	76	4	SS003(34), SS008(30), SS002(10)
RyTuneX	76	10	SS017(14), SS033(12), SS002(12)
OpenTabletDriver	74	6	SS017(58), SS044(6), SS019(4)
CSharpRepl	72	11	SS017(28), SS033(8), SS066(8)
orleans	64	6	SS019(34), SS008(12), SS017(10)
VsVim	64	5	SS019(26), SS018(18), SS017(12)
Emby.Plugins.JavScraper	64	7	SS002(32), SS033(8), SS003(8)
FluentTerminal	62	1	SS008(62)
YoutubePlaylistDownloader	56	4	SS059(24), SS066(16), SS003(12)
parsec-vdd	54	6	SS017(30), SS066(10), SS003(6)
Seq.Api	52	5	SS017(24), SS033(12), SS034(6)
qmk_toolbox	50	6	SS019(22), SS066(12), SS001(10)
blazor-starter-kit	50	7	SS002(24), SS019(10), SS004(6)
GuardClauses	44	3	SS002(38), SS017(4), SS049(2)
DotNetGuide	44	6	SS003(20), SS002(10), SS009(4)
Telegram.Bot	42	6	SS019(12), SS059(10), SS033(8)
opentrace	40	4	SS066(28), SS034(8), SS001(2)
SymSpell	36	5	SS003(14), SS017(8), SS008(6)
dotnet-script	36	5	SS059(12), SS008(10), SS033(8)
RunCat365	36	3	SS017(16), SS066(14), SS034(6)
Steam-auto-crack	34	3	SS017(28), SS003(4), SS066(2)
NSubstitute	32	3	SS017(20), SS004(8), SS015(4)
app	32	4	SS003(12), SS019(10), SS059(6)
Scrutor	32	2	SS017(24), SS004(8)
ApiEndpoints	30	6	SS034(18), SS017(4), SS004(2)
N_m3u8DL-RE	30	4	SS008(20), SS003(4), SS002(4)
coravel	28	6	SS066(8), SS059(6), SS033(4)
Entitas	28	3	SS008(14), SS017(12), SS019(2)
ScreenToGif	26	3	SS002(12), SS059(8), SS017(6)
AspNetCoreDiagnosticScenarios	26	4	SS034(12), SS033(8), SS037(4)
maui-samples	24	2	SS033(12), SS001(12)
SimplCommerce	24	3	SS002(18), SS059(4), SS033(2)
SteamAchievementManager	24	1	SS017(24)
querybuilder	22	5	SS044(6), SS058(4), SS033(4)
keepass2android	22	4	SS008(12), SS019(6), SS041(2)
eShop	20	5	SS008(8), SS066(6), SS059(2)
EquinoxProject	20	5	SS034(6), SS066(6), SS033(4)
repkg	20	5	SS003(10), SS021(4), SS018(2)
basic-computer-games	18	3	SS017(14), SS019(2), SS003(2)
PKHeX	16	1	SS003(16)
MediatR	16	4	SS051(8), SS034(4), SS044(2)
carter	12	2	SS033(8), SS059(4)
Flurl	12	2	SS058(6), SS017(6)
mongo-csharp-driver	12	1	SS017(12)
sample-dotnet-core-cqrs-api	10	4	SS002(4), SS017(2), SS033(2)
Stateless	10	1	SS034(10)
samples	8	2	SS002(4), SS017(4)
Discord.Net	8	2	SS059(6), SS034(2)
SteamKit	8	1	SS004(8)
AspNetCoreRateLimit	8	3	SS003(4), SS017(2), SS004(2)
jellyfin-plugin-metatube	8	2	SS019(6), SS037(2)
GoogleTranslateIpCheck	6	1	SS033(6)
Jellyfin	6	3	SS017(2), SS003(2), SS019(2)
BenchmarkDotNet	4	1	SS044(4)
practical-aspnetcore	2	1	SS033(2)
OFGB	2	1	SS019(2)
playwright-dotnet	2	1	SS033(2)

Rule Frequency Across All Repos

Rule	Description	Total Hits	Repos Affected
SS001	Async method with void return type	816	44
SS002	Use DateTime.UtcNow instead of DateTime.Now	10264	102
SS003	Integer divided by integer causing implicit rounding	14324	125
SS004	Elementary methods of type in collection not overridden	5450	94
SS005	Equals() and GetHashCode() not implemented together	252	22
SS006	Throwing null will always result in a runtime exception	24	1
SS007	[Flags] enum values are not powers of two	32	3
SS008	GetHashCode() refers to mutable or static member	7284	76
SS009	Random instantiated in a loop	32	5
SS011	OnPropertyChanged without nameof operator	450	5
SS013	Rethrow exception without losing stacktrace	3108	12
SS015	String placeholders in wrong order	402	13
SS017	Struct without Equals/GetHashCode/ToString overridden	17864	130
SS018	Switch does not handle all enum options	5226	85
SS019	Switch is missing default label	18710	126
SS020	Test method without public modifier	128	6
SS021	Test method without test attribute	178	15
SS022	Exception thrown from implicit operator	86	6
SS023	Exception thrown from property getter	2908	64
SS024	Exception thrown from static constructor	56	9
SS025	Exception thrown from finally block	2	1
SS026	Exception thrown from equality operator	4	1
SS027	Exception thrown from Dispose	80	10
SS028	Exception thrown from finalizer	2	1
SS029	Exception thrown from GetHashCode	2	1
SS030	Exception thrown from Equals	14	4
SS032	Thread.Sleep used in async method	104	15
SS033	Async overload is available	4218	87
SS034	Accessing Task.Result without await	3436	72
SS035	Synchronous task wait instead of await	294	13
SS037	HttpClient instantiated directly	326	18
SS038	HttpContext stored in a field	60	5
SS040	Unused result on immutable object	32	6
SS041	Unnecessary enumerable materialization	246	27
SS044	Attribute must specify [AttributeUsage]	974	44
SS046	Unbounded stackalloc	318	11
SS047	LINQ traversal before filter	130	14
SS048	Locking on discouraged object (string, Type, this)	910	26
SS049	Comparing strings without StringComparison	2320	41
SS050	Parameter assigned in constructor	32	7
SS051	Locking on mutable reference	2426	43
SS052	[ThreadStatic] field with initializer	8	1
SS053	Pointless collection ToString()	26	4
SS054	Newtonsoft.Json mixed with System.Text.Json	90	3
SS055	Multiple OrderBy() calls instead of ThenBy()	30	2
SS056	HttpRequest.Form read synchronously	242	9
SS057	Collection manipulated during traversal	442	35
SS058	String concatenated in a loop	4210	76
SS059	IAsyncDisposable not disposed asynchronously	2680	77
SS060	ConcurrentDictionary emptiness check without IsEmpty	74	9
SS063	ValueTask awaited multiple times	2	1
SS064	Unnecessary ToString() on Span	14	3
SS066	Disposable field is not disposed	15638	119

Detailed Findings by Repository

FreeSql

16246 total diagnostics across 20 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2040 hits

📄 FreeSql\Internal\ObjectPool\Object.cs (line 54)

         /// <summary>
         /// 创建时间
         /// </summary>
▶        public DateTime CreateTime { get; internal set; } = DateTime.Now;
 
         /// <summary>
         /// 最后获取时的线程id

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 FreeSql\FreeUtil.cs (line 31)

     /// <returns></returns>
     public static Guid NewMongodbId()
     {
▶        var now = DateTime.Now;
         var uninxtime = (int)now.Subtract(dt1970).TotalSeconds;
         int increment = Interlocked.Increment(ref __staticIncrement) & 0x00ffffff;
         var rand = rnd.Value.Next(0, int.MaxValue);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 236 hits

📄 FreeSql\Internal\CommonProvider\UpdateProvider.cs (line 342)

             {
                 var colSum = _table.Columns.Count - _ignore.Count;
                 if (colSum <= 0) colSum = 1;
▶                takeMax = parameterLimit / colSum;
                 if (takeMax > valuesLimit) takeMax = valuesLimit;
             }
             if (_source.Count <= takeMax) return new[] { _source };

💬 The operands in the divisive expression parameterLimit / colSum are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 FreeSql\Internal\CommonProvider\InsertProvider.cs (line 251)

             {
                 var colSum = _table.Columns.Count - _ignore.Count;
                 if (colSum <= 0) colSum = 1;
▶                takeMax = parameterLimit / colSum;
                 if (takeMax > valuesLimit) takeMax = valuesLimit;
             }
             if (_source.Count <= takeMax) return new[] { _source };

SS004 Elementary methods of type in collection not overridden 238 hits

📄 FreeSql\Internal\CommonProvider\SelectProvider\SelectGroupingProvider.cs (line 77)

                             curtables = _select._tables;
                             LocalValueInitData();
                         }
▶                        if (tempQueryParser._outsideTable.Contains(curtable))
                         {
                             var replaceMember = firstMember.Type == curtable.Parameter.Type ? firstMember : members[0];
                             var replaceVistor = new CommonExpression.ReplaceVisitor();

💬 Type SelectTableInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 FreeSql\Internal\CommonProvider\SelectProvider\SelectGroupingProvider.cs (line 77)

                             curtables = _select._tables;
                             LocalValueInitData();
                         }
▶                        if (tempQueryParser._outsideTable.Contains(curtable))
                         {
                             var replaceMember = firstMember.Type == curtable.Parameter.Type ? firstMember : members[0];
                             var replaceVistor = new CommonExpression.ReplaceVisitor();

SS008 GetHashCode() refers to mutable or static member 380 hits

📄 Providers\FreeSql.Provider.MySql\MySqlAdo\MygisTypes.cs (line 155)

     public override int GetHashCode()
     {
         var ret = 266370105;//seed with something other than zero to make paths of all zeros hash differently.
▶        foreach (var t in _points) ret ^= RotateShift(t.GetHashCode(), ret % sizeof(int));
         return ret;
     }
 }

💬 GetHashCode() refers to mutable field _points (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Providers\FreeSql.Provider.MySql\MySqlAdo\MygisTypes.cs (line 198)

     public override int GetHashCode()
     {
         var ret = 266370105;//seed with something other than zero to make paths of all zeros hash differently.
▶        for (var i = 0; i < _rings.Length; i++)
             for (var j = 0; j < _rings[i].Length; j++)
                 ret ^= RotateShift(_rings[i][j].GetHashCode(), ret % sizeof(int));
         return ret;

💬 GetHashCode() refers to mutable field _rings (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 1008 hits

📄 Providers\FreeSql.Provider.Odbc\MySql\Curd\OdbcMySqlInsert.cs (line 73)

             catch (Exception ex)
             {
                 exception = ex;
▶                throw ex;
             }
             finally
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 Providers\FreeSql.Provider.Odbc\PostgreSQL\Curd\OdbcPostgreSQLDelete.cs (line 53)

                 catch (Exception ex)
                 {
                     exception = ex;
▶                    throw ex;
                 }
                 finally
                 {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 38 hits

📄 Providers\FreeSql.Provider.MySql\MySqlAdo\MygisTypes.cs (line 8)

 using System.Text.RegularExpressions;
 using FreeSql;
 
▶public struct MygisCoordinate2D : IEquatable<MygisCoordinate2D>
 {
     public double X { get; }
     public double Y { get; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MygisCoordinate2D. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Providers\FreeSql.Provider.MySql\MySqlAdo\MygisTypes.cs (line 8)

 using System.Text.RegularExpressions;
 using FreeSql;
 
▶public struct MygisCoordinate2D : IEquatable<MygisCoordinate2D>
 {
     public double X { get; }
     public double Y { get; }

SS018 Switch does not handle all enum options 1458 hits

📄 FreeSql\Extensions\LambadaExpressionExtensions.cs (line 318)

                 break;
             }
             object firstValue = null;
▶            switch (expStack.First().NodeType)
             {
                 case ExpressionType.Constant:
                     var expStackFirst = expStack.Pop() as ConstantExpression;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 FreeSql\Extensions\LambadaExpressionExtensions.cs (line 335)

             while (expStack.Any())
             {
                 var expStackItem = expStack.Pop();
▶                switch (expStackItem.NodeType)
                 {
                     case ExpressionType.MemberAccess:
                         var memExp = expStackItem as MemberExpression;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 8454 hits

📄 FreeSql\Extensions\LambadaExpressionExtensions.cs (line 291)

             var exp2 = exp;
             while (true)
             {
▶                switch (exp2?.NodeType)
                 {
                     case ExpressionType.Constant:
                         expStack.Push(exp2);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 FreeSql\Extensions\LambadaExpressionExtensions.cs (line 318)

                 break;
             }
             object firstValue = null;
▶            switch (expStack.First().NodeType)
             {
                 case ExpressionType.Constant:
                     var expStackFirst = expStack.Pop() as ConstantExpression;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS020 Test method without public modifier 18 hits

📄 FreeSql.Tests\FreeSql.Tests.Provider.TDengine\TDengine\TDengineCrud\TDengineCrudTest.cs (line 12)

         IFreeSql fsql => g.tdengine;
 
         [Fact]
▶        void CodeFirstTest()
         {
             fsql.CodeFirst.SyncStructure<D1001>();
             fsql.CodeFirst.SyncStructure<D1002>();

💬 Test method "CodeFirstTest" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 FreeSql.Tests\FreeSql.Tests.Provider.TDengine\TDengine\TDengineIssue\TDengineIssueTest.cs (line 24)

         }
 
         [Fact]
▶        void CodeFirst1977()
         {
             _fsql.CodeFirst.SyncStructure(typeof(TDengineProcessMetrics1977));
         }

💬 Test method "CodeFirst1977" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS027 Exception thrown from Dispose 10 hits

📄 FreeSql.DbContext\UnitOfWork\UnitOfWorkManager.cs (line 74)

                         if (exception == null) exception = ex;
                     }
                 }
▶                if (exception != null) throw exception;
             }
             finally
             {

💬 An exception is thrown from the Dispose() method in type UnitOfWorkManager (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 FreeSql.DbContext\UnitOfWork\UnitOfWorkManager.cs (line 74)

                         if (exception == null) exception = ex;
                     }
                 }
▶                if (exception != null) throw exception;
             }
             finally
             {

💬 An exception is thrown from the Dispose() method in type UnitOfWorkManager (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS033 Async overload is available 284 hits

📄 FreeSql\Extensions\FreeSqlGlobalExtensions.cs (line 768)

             imsel.SetList(list);
 #else
             if (isAsync) await imsel.SetListAsync(list);
▶            else imsel.SetList(list);
 #endif
             return list;
         }

💬 Async overload available for Select1Provider.SetList (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 FreeSql\Extensions\FreeSqlGlobalExtensions.cs (line 799)

 #if net40
         var reflist = refsel.ToList();
 #else
▶        var reflist = isAsync ? await refsel.ToListAsync() : refsel.ToList();
 #endif
 
         reflist.ForEach(refitem =>

💬 Async overload available for Select0Provider.ToList (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 10 hits

📄 FreeSql\Extensions\FreeSqlGlobalExtensions.cs (line 727)

 #else
         var task = IncludeByPropertyNameSyncOrAsync<T1>(false, list, orm, property, where, take, select, then);
         if (task.Exception != null) throw task.Exception.InnerException ?? task.Exception;
▶        return task.Result;
 #endif
     }
 #if net40

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 FreeSql\Extensions\FreeSqlGlobalExtensions.cs (line 727)

 #else
         var task = IncludeByPropertyNameSyncOrAsync<T1>(false, list, orm, property, where, take, select, then);
         if (task.Exception != null) throw task.Exception.InnerException ?? task.Exception;
▶        return task.Result;
 #endif
     }
 #if net40

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 30 hits

📄 FreeSql\Internal\CommonProvider\UpdateProvider.cs (line 637)

             if (tempPrimarys != null)
             {
                 var cols = _commonExpression.ExpressionSelectColumns_MemberAccess_New_NewArrayInit(null, null, tempPrimarys?.Body, false, null).Distinct().ToDictionary(a => a);
▶                _tempPrimarys = cols.Keys.Select(a => _table.Columns.TryGetValue(a, out var col) ? col : null).ToArray().Where(a => a != null).ToArray();
             }
             _ignoreVersion = ignoreVersion;
             _versionColumn = _ignoreVersion ? null : _table?.VersionColumn;

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 FreeSql\Internal\CommonProvider\InsertOrUpdateProvider.cs (line 193)

             if (tempPrimarys != null)
             {
                 var cols = _commonExpression.ExpressionSelectColumns_MemberAccess_New_NewArrayInit(null, null, tempPrimarys?.Body, false, null).Distinct().ToDictionary(a => a);
▶                _tempPrimarys = cols.Keys.Select(a => _table.Columns.TryGetValue(a, out var col) ? col : null).ToArray().Where(a => a != null).ToArray();
             }
             return this;
         }

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 16 hits

📄 FreeSql\DataAnnotations\NavigateAttribute.cs (line 14)

     /// OneToMany：Category.cs 文件 (缺省)Category.Id &lt;-&gt; [Navigate(nameof(Topic.CategoryId))]<para></para>
     /// _________________public List&lt;Topic&gt; Topics { get; set; }<para></para>
     /// </summary>
▶    public class NavigateAttribute : Attribute
     {
 
         /// <summary>

💬 NavigateAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 FreeSql\DataAnnotations\NavigateAttribute.cs (line 14)

     /// OneToMany：Category.cs 文件 (缺省)Category.Id &lt;-&gt; [Navigate(nameof(Topic.CategoryId))]<para></para>
     /// _________________public List&lt;Topic&gt; Topics { get; set; }<para></para>
     /// </summary>
▶    public class NavigateAttribute : Attribute
     {
 
         /// <summary>

💬 NavigateAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 40 hits

📄 FreeSql.Tests\FreeSql.Tests.Provider.OracleOledb\OracleOledb\Curd\OracleOledbSelectTest.cs (line 1263)

                 .ToList();
 
             var t00 = g.oracle.Select<TiOtmModel2>()
▶                .IncludeMany(a => a.childs.Take(1).Where(m3 => m3.model2111Idaaa == a.model2id))
                 .Where(a => a.model2id <= model1.id)
                 .ToList();
 

💬 Unexpected collection traversal before Where() clause. Could the traversal be more efficient if filtering is performed first? (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS047-LinqTraversalBeforeFilter.md)

📄 FreeSql.Tests\FreeSql.Tests.Provider.OracleOledb\OracleOledb\Curd\OracleOledbSelectTest.cs (line 1268)

                 .ToList();
 
             var t11 = g.oracle.Select<TiOtmModel1>()
▶                .IncludeMany(a => a.model2.childs.Take(1).Where(m3 => m3.model2111Idaaa == a.model2.model2id))
                 .Where(a => a.id <= model1.id)
                 .ToList();
 

SS049 Comparing strings without StringComparison 352 hits

📄 FreeSql\Extensions\FreeSqlGlobalExpressionCallExtensions.cs (line 397)

                 case DataType.CustomPostgreSQL:
                 case DataType.KingbaseES:
                 case DataType.ShenTong:
▶                    if (part.ToLower() == "day" || part.ToLower() == "d")
                         up.Result = $"(DATE_PART('day', {dt2} - {dt1}))";
                     else if (part.ToLower() == "second" || part.ToLower() == "s")
                         up.Result = $"(EXTRACT(EPOCH FROM ({dt2} - {dt1})))";

💬 A string is being compared through allocating a new string. Use a case-insensitive comparison instead. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS049-ComparingStringsWithoutStringComparison.md)

📄 FreeSql\Extensions\FreeSqlGlobalExpressionCallExtensions.cs (line 397)

                 case DataType.CustomPostgreSQL:
                 case DataType.KingbaseES:
                 case DataType.ShenTong:
▶                    if (part.ToLower() == "day" || part.ToLower() == "d")
                         up.Result = $"(DATE_PART('day', {dt2} - {dt1}))";
                     else if (part.ToLower() == "second" || part.ToLower() == "s")
                         up.Result = $"(EXTRACT(EPOCH FROM ({dt2} - {dt1})))";

SS051 Locking on mutable reference 464 hits

📄 FreeSql\Extensions\AdoNetExtensions.cs (line 72)

                 default:
                     throw new Exception(CoreErrorStrings.Not_Implemented);
             }
▶            lock (_dicCurdLock)
             {
                 if (_dicCurd.TryGetValue(dbconn.ConnectionString, out fsql)) return fsql;
                 lock (_dicCurdLock)

💬 A lock was obtained on _dicCurdLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 FreeSql\Extensions\AdoNetExtensions.cs (line 75)

             lock (_dicCurdLock)
             {
                 if (_dicCurd.TryGetValue(dbconn.ConnectionString, out fsql)) return fsql;
▶                lock (_dicCurdLock)
                     _dicCurd.Add(dbconn.ConnectionString, fsql = Activator.CreateInstance(providerType, new object[] { null, null, null }) as IFreeSql);
             }
             return fsql;

SS058 String concatenated in a loop 810 hits

📄 FreeSql\Internal\CommonExpression.cs (line 261)

                             var memExp = exp as MemberExpression;
                             while (memExp != null)
                             {
▶                                includeKey = $"{memExp.Member.Name}.{includeKey}";
                                 if (memExp.Expression.NodeType == ExpressionType.Parameter) break;
                                 memExp = memExp.Expression as MemberExpression;
                             }

💬 A string was concatenated in a loop which introduces intermediate allocations. Consider using a StringBuilder or pre-allocated string instead. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS058-StringConcatenatedInLoop.md)

📄 FreeSql\Internal\CommonUtils.cs (line 497)

                 foreach (var col in cols)
                 {
                     var colval = Utils.GetDataReaderValue(col.Attribute.MapType, objs[colidx]);
▶                    filter += $"{(colidx > 0 ? " AND " : "")}{aliasAndDot}{this.QuoteSqlName(col.Attribute.Name)} = ";
                     if (CodeFirst.IsGenerateCommandParameterWithLambda && dbParams != null) //v3.5.100 单条支持参数化
                     {
                         var paramName = $"exp_{dbParams.Count}";

SS059 IAsyncDisposable not disposed asynchronously 16 hits

📄 FreeSql\Internal\CommonProvider\AdoProvider\AdoProviderAsync.cs (line 644)

                     };
                 }
 #endif
▶                using (var dr = await pc.cmd.ExecuteReaderAsync(cancellationToken))
                 {
                     int resultIndex = 0;
                     var fetch = new FetchCallbackArgs<DbDataReader> { Object = dr };

💬 DbDataReader can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Providers\FreeSql.Provider.PostgreSQL\PostgreSQLExtensions.cs (line 311)

                 copyFromCommand.Append(insert.InternalCommonUtils.QuoteSqlName(col.ColumnName));
             }
             copyFromCommand.Append(") FROM STDIN BINARY");
▶            using (var writer = conn.BeginBinaryImport(copyFromCommand.ToString()))
             {
                 foreach (DataRow item in dt.Rows)
                 {

💬 NpgsqlBinaryImporter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 344 hits

📄 FreeSql\Internal\CommonProvider\SelectProvider\Select0Provider.cs (line 33)

         public Func<Type, string, string> _aliasRule;
         public string _tosqlAppendContent;
         public StringBuilder _join = new StringBuilder();
▶        public IFreeSql _orm;
         public CommonUtils _commonUtils;
         public CommonExpression _commonExpression;
         public DbTransaction _transaction;

💬 Disposable field _orm in type Select0Provider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 FreeSql\Internal\CommonProvider\SelectProvider\Select0Provider.cs (line 36)

         public IFreeSql _orm;
         public CommonUtils _commonUtils;
         public CommonExpression _commonExpression;
▶        public DbTransaction _transaction;
         public DbConnection _connection;
         public int _commandTimeout = 0;
         public Action<object> _trackToList;

💬 Disposable field _transaction in type Select0Provider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Facepunch.Steamworks

6570 total diagnostics across 12 rules

SS001 Async method with void return type 36 hits

📄 Facepunch.Steamworks\Classes\Dispatch.cs (line 236)

 		/// have to think about it. This has the advantage that
 		/// you can call .Wait() on async shit and it still works.
 		/// </summary>
▶		internal static async void LoopClientAsync()
 		{
 			while ( ClientPipe != 0 )
 			{

💬 Method LoopClientAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Facepunch.Steamworks\Classes\Dispatch.cs (line 250)

 		/// have to think about it. This has the advantage that
 		/// you can call .Wait() on async shit and it still works.
 		/// </summary>
▶		internal static async void LoopServerAsync()
 		{
 			while ( ServerPipe != 0 )
 			{

💬 Method LoopServerAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS003 Integer divided by integer causing implicit rounding 36 hits

📄 Facepunch.Steamworks\SteamUtils.cs (line 132)

 		/// <summary>
 		/// Returns battery power [0-1].
 		/// </summary>
▶		public static float CurrentBatteryPower => Math.Min( Internal.GetCurrentBatteryPower() / 100, 1.0f );
 
 		static NotificationPosition overlayNotificationPosition = NotificationPosition.BottomRight;
 

💬 The operands in the divisive expression Internal.GetCurrentBatteryPower() / 100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Facepunch.Steamworks\Structs\UgcEditor.cs (line 293)

 						}
 					}
 
▶					await Task.Delay( 1000 / 60 );
 				}
 
 				progress?.Report( 1 );

💬 The operands in the divisive expression 1000 / 60 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 900 hits

📄 Facepunch.Steamworks\Structs\InventoryRecipe.cs (line 99)

 		public override bool Equals( object p ) => this.Equals( (InventoryRecipe)p );
 		public override int GetHashCode()
 		{
▶			return Source.GetHashCode();
 		}
 
 		public bool Equals( InventoryRecipe p ) => p.GetHashCode() == GetHashCode();

💬 GetHashCode() refers to mutable field Source (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Facepunch.Steamworks\Structs\Controller.cs (line 57)

 		public static bool operator ==( Controller a, Controller b ) => a.Equals( b );
 		public static bool operator !=( Controller a, Controller b ) => !(a == b);
 		public override bool Equals( object p ) => this.Equals( (Controller)p );
▶		public override int GetHashCode() => Handle.GetHashCode();
 		public bool Equals( Controller p ) => p.Handle == Handle;
 	}
 

💬 GetHashCode() refers to mutable field Handle (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 5382 hits

📄 Facepunch.Steamworks\Callbacks\CallResult.cs (line 14)

 	/// <summary>
 	/// An awaitable version of a SteamAPICall_t
 	/// </summary>
▶	internal struct CallResult<T> : INotifyCompletion where T : struct, ICallbackData
 	{
 		SteamAPICall_t call;
 		ISteamUtils utils;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CallResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Facepunch.Steamworks\Structs\ServerInit.cs (line 14)

     /// Used to set up the server. 
     /// The variables in here are all required to be set, and can't be changed once the server is created.
     /// </summary>
▶    public struct SteamServerInit
     {
         public IPAddress IpAddress;
         public ushort GamePort;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SteamServerInit. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 54 hits

📄 Facepunch.Steamworks\Structs\UgcEditor.cs (line 261)

 
 						var r = SteamUGC.Internal.GetItemUpdateProgress( handle, ref processed, ref total );
 
▶						switch ( r )
 						{
 							case ItemUpdateStatus.PreparingConfig:
 								{

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Facepunch.Steamworks\Networking\ConnectionManager.cs (line 54)

 			// - Update state before the callbacks, in case an exception is thrown
 			// - ConnectionState.None happens when a connection is destroyed, even if it was already disconnected (ClosedByPeer / ProblemDetectedLocally)
 			//
▶			switch ( info.State )
 			{
 				case ConnectionState.Connecting:
 					if ( !Connecting && !Connected )

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 56 hits

📄 Generator\CodeWriter\Utility.cs (line 55)

 
 			type = Cleanup.ConvertType( type );
 
▶			switch ( type )
             {
                 case "uint64": return "ulong";
                 case "uint32": return "uint";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Facepunch.Steamworks\Structs\UgcEditor.cs (line 261)

 
 						var r = SteamUGC.Internal.GetItemUpdateProgress( handle, ref processed, ref total );
 
▶						switch ( r )
 						{
 							case ItemUpdateStatus.PreparingConfig:
 								{

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 8 hits

📄 Facepunch.Steamworks.Test\FriendsTest.cs (line 130)

 		}
 
▶		public static void DrawImage( Image img )
 		{
 			var grad = " -:+#";

💬 Method DrawImage might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 Facepunch.Steamworks.Test\UserStatsTest.cs (line 42)

 			Console.WriteLine( $"players:	{players}" );
 		}
 		
▶		public async Task StoreStats()
 		{
 			var result = Result.NotSettled;
 

💬 Method StoreStats might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS022 Exception thrown from implicit operator 18 hits

📄 Facepunch.Steamworks\Structs\SteamIpAddress.cs (line 23)

 			if ( value.Type == SteamIPType.Type4 )
 				return Utility.Int32ToIp( value.Ip4Address );
 
▶			throw new System.Exception( $"Oops - can't convert SteamIPAddress to System.Net.IPAddress because no-one coded support for {value.Type} yet" );
 		}
 	}
 }

💬 An exception is thrown from implicit operator System.Net.IPAddress in type SteamIPAddress (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

📄 Facepunch.Steamworks\Structs\SteamIpAddress.cs (line 23)

 			if ( value.Type == SteamIPType.Type4 )
 				return Utility.Int32ToIp( value.Ip4Address );
 
▶			throw new System.Exception( $"Oops - can't convert SteamIPAddress to System.Net.IPAddress because no-one coded support for {value.Type} yet" );
 		}
 	}
 }

💬 An exception is thrown from implicit operator System.Net.IPAddress in type SteamIPAddress (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

SS033 Async overload is available 4 hits

📄 Facepunch.Steamworks.Test\UgcEditor.cs (line 108)

 			var rand = new Random();
 			var testFile = new byte[1024 * 1024 * 32];
 			rand.NextBytes( testFile );
▶			System.IO.File.WriteAllBytes( testFolder.FullName + "/testfile1.bin", testFile );
 
 			Console.WriteLine( testFolder.FullName );
 

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Facepunch.Steamworks.Test\UgcEditor.cs (line 108)

 			var rand = new Random();
 			var testFile = new byte[1024 * 1024 * 32];
 			rand.NextBytes( testFile );
▶			System.IO.File.WriteAllBytes( testFolder.FullName + "/testfile1.bin", testFile );
 
 			Console.WriteLine( testFolder.FullName );
 

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 36 hits

📄 Facepunch.Steamworks\Utility\Helpers.cs (line 125)

 	/// Prevent unity from stripping shit we depend on
 	/// https://docs.unity3d.com/Manual/ManagedCodeStripping.html
 	/// </summary>
▶	internal class PreserveAttribute : System.Attribute { }
 }

💬 PreserveAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Facepunch.Steamworks\Utility\Helpers.cs (line 116)

 		}
 	}
 
▶	internal class MonoPInvokeCallbackAttribute : Attribute
 	{
 		public MonoPInvokeCallbackAttribute() { }
 	}

💬 MonoPInvokeCallbackAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 18 hits

📄 Facepunch.Steamworks\Utility\Helpers.cs (line 68)

 		/// </summary>
 		public static byte[] TakeBuffer( int minSize )
 		{
▶			lock ( BufferPool  )
 			{
 				BufferPoolIndex++;
 

💬 A lock was obtained on BufferPool but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Facepunch.Steamworks\Utility\Helpers.cs (line 68)

 		/// </summary>
 		public static byte[] TakeBuffer( int minSize )
 		{
▶			lock ( BufferPool  )
 			{
 				BufferPoolIndex++;
 

SS058 String concatenated in a loop 22 hits

📄 Facepunch.Steamworks\Classes\Dispatch.cs (line 192)

 				var spaces = (columnSize - field.Name.Length);
 				if ( spaces < 0 ) spaces = 0;
 
▶				str += $"{new String( ' ', spaces )}{field.Name}: {field.GetValue( strct )}\n";
 			}
 
 			return str.Trim( '\n' );

📄 Facepunch.Steamworks\Classes\Dispatch.cs (line 192)

 				var spaces = (columnSize - field.Name.Length);
 				if ( spaces < 0 ) spaces = 0;
 
▶				str += $"{new String( ' ', spaces )}{field.Name}: {field.GetValue( strct )}\n";
 			}
 
 			return str.Trim( '\n' );

UnityCsReference

4864 total diagnostics across 21 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 34 hits

📄 Modules\XR\ScriptBindings\XRInput.bindings.cs (line 640)

 
         public static DateTime now
         {
▶            get { return DateTime.Now; }
         }
 
         public static long LocalDateTimeToUnixTimeMilliseconds(DateTime date)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Modules\GameCenter\Managed\LocalService.cs (line 518)

                     if (progress >= 100.0)
                         achoo.SetCompleted(true);
                     achoo.SetHidden(false);
▶                    achoo.SetLastReportedDate(DateTime.Now);
                     achoo.percentCompleted = progress;
                     if (callback != null)
                         callback(true);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 180 hits

📄 Runtime\Export\Time\DiscreteTime.cs (line 70)

 
         public const uint TicksPerSecond =  Pow2Tps * NonPow2Tps;
         public const double Tick = 1.0 / TicksPerSecond;
▶        public const long MaxValueSeconds = long.MaxValue / TicksPerSecond;
         public const long MinValueSeconds = long.MinValue / TicksPerSecond;
 
         // Constants for supported frame rates

💬 The operands in the divisive expression long.MaxValue / TicksPerSecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Runtime\Export\Time\DiscreteTime.cs (line 71)

         public const uint TicksPerSecond =  Pow2Tps * NonPow2Tps;
         public const double Tick = 1.0 / TicksPerSecond;
         public const long MaxValueSeconds = long.MaxValue / TicksPerSecond;
▶        public const long MinValueSeconds = long.MinValue / TicksPerSecond;
 
         // Constants for supported frame rates
         public const uint Tick5Fps = TicksPerSecond / 5;

💬 The operands in the divisive expression long.MinValue / TicksPerSecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 182 hits

📄 Modules\Accessibility\Managed\Hierarchy\AccessibilityHierarchy.cs (line 249)

                 m_Nodes.Remove(node.id);
             }
 
▶            if (m_RootNodes.Contains(node))
             {
                 m_RootNodes.Remove(node);
 

💬 Type AccessibilityNode is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Runtime\Export\StaticShim\ShimManager.cs (line 61)

 
         internal static void RemoveShim(ScreenShimBase shim)
         {
▶            if (s_ActiveScreenShim.Contains(shim))
             {
                 s_ActiveScreenShim.Remove(shim);
                 ActiveShimChanged?.Invoke();

💬 Type ScreenShimBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS005 Equals() and GetHashCode() not implemented together 2 hits

📄 Modules\Accessibility\Managed\Hierarchy\AccessibilityNode.cs (line 16)

     /// An instance of a node in the <see cref="AccessibilityHierarchy"/>, representing an element in the UI that the screen reader
     /// can read, focus, and execute actions on.
     /// </summary>
▶    public class AccessibilityNode
     {
         private class ObservableList<T> : IList<T>, IReadOnlyList<T>, IList
         {

💬 Equals() and GetHashcode() must be implemented together on AccessibilityNode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 Modules\Accessibility\Managed\Hierarchy\AccessibilityNode.cs (line 16)

     /// An instance of a node in the <see cref="AccessibilityHierarchy"/>, representing an element in the UI that the screen reader
     /// can read, focus, and execute actions on.
     /// </summary>
▶    public class AccessibilityNode
     {
         private class ObservableList<T> : IList<T>, IReadOnlyList<T>, IList
         {

💬 Equals() and GetHashcode() must be implemented together on AccessibilityNode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 1190 hits

📄 Runtime\Jobs\ScriptBindings\JobHandle.bindings.cs (line 128)

 
         public override int GetHashCode()
         {
▶            return jobGroup.GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable field jobGroup (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Modules\DSPGraph\Public\ScriptBindings\AudioHandle.bindings.cs (line 81)

         {
             unchecked
             {
▶                return ((int)m_Node * 397) ^ Version;
             }
         }
 

💬 GetHashCode() refers to mutable field m_Node (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 4 hits

📄 Modules\AndroidJNI\AndroidJava.cs (line 1763)

                 IntPtr memberID = AndroidJNISafe.GetMethodID(jclass, "<init>", signature);
                 if (memberID != IntPtr.Zero)
                     return memberID;
▶                throw e;
             }
             finally
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 Modules\AndroidJNI\AndroidJava.cs (line 1785)

                 IntPtr memberID = GetMethodIDFallback(jclass, methodName, signature, isStatic);
                 if (memberID != IntPtr.Zero)
                     return memberID;
▶                throw e;
             }
             finally
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS015 String placeholders in wrong order 4 hits

📄 Modules\IMGUI\LayoutEntry.cs (line 113)

             string space = "";
             for (int i = 0; i < indent; i++)
                 space += " ";
▶            return space + string.Format("{1}-{0} (x:{2}-{3}, y:{4}-{5})", style != null ? style.name : "NULL", GetType(), rect.x, rect.xMax, rect.y, rect.yMax) +
                 "   -   W: " + minWidth + "-" + maxWidth + (stretchWidth != 0 ? "+" : "") + ", H: " + minHeight + "-" + maxHeight + (stretchHeight  != 0 ? "+" : "");
         }
     }

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 Runtime\Export\Assertions\Assert\AssertionMessageUtil.cs (line 30)

         public static string GetEqualityMessage(object actual, object expected, bool expectEqual)
         {
             return GetMessage(string.Format("Values are {0}equal.", expectEqual ? "not " : ""),
▶                string.Format("{0} {2} {1}", actual, expected, expectEqual ? "==" : "!="));
         }
 
         public static string NullFailureMessage(object value, bool expectNull)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2324 hits

📄 Modules\ContentLoad\Public\ContentLoad.bindings.cs (line 30)

     }
 
     [StructLayout(LayoutKind.Sequential)]
▶    public struct ContentFileUnloadHandle
     {
         internal ContentFile Id;
         public bool IsCompleted { get { return ContentLoadInterface.ContentFile_IsUnloadComplete(Id); } }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ContentFileUnloadHandle. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Modules\Input\Private\Input.cs (line 32)

 
     // We pass this as a struct to make it less painful to change the OnUpdate() API if need be.
     [StructLayout(LayoutKind.Explicit, Size = structSize, Pack = 1)]
▶    internal unsafe struct NativeInputEventBuffer
     {
         public const int structSize = 20;
         // NOTE: Keep this as the first field in the struct. This avoids alignment/packing issues

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NativeInputEventBuffer. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 116 hits

📄 Modules\Accessibility\Bindings\AccessibilityManager.bindings.cs (line 128)

 
             foreach (var context in contexts)
             {
▶                switch (context.notification)
                 {
                     case AccessibilityNotification.ScreenReaderStatusChanged:
                     {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Runtime\Export\Jobs\AtomicSafetyHandle.bindings.cs (line 280)

             safety = (allocator == Allocator.Temp) ? GetTempMemoryHandle() : Create();
             if(!Unity.Jobs.LowLevel.Unsafe.JobsUtility.IsExecutingJob)
                 return;
▶            switch(allocator)
             {
                 case Allocator.TempJob:
                 case Allocator.Persistent:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 300 hits

📄 Modules\Accessibility\Bindings\AccessibilityManager.bindings.cs (line 128)

 
             foreach (var context in contexts)
             {
▶                switch (context.notification)
                 {
                     case AccessibilityNotification.ScreenReaderStatusChanged:
                     {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Modules\XR\ScriptBindings\XRInput.bindings.cs (line 956)

         [RequiredByNativeCode]
         private static void InvokeConnectionEvent(UInt64 deviceId, ConnectionChangeType change)
         {
▶            switch (change)
             {
                 case ConnectionChangeType.Connected:
                 {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS022 Exception thrown from implicit operator 2 hits

📄 Modules\UIElements\Core\Renderer\SafeHandleAccess.cs (line 26)

         public static implicit operator IntPtr(SafeHandleAccess a)
         {
             if (a.m_Handle == IntPtr.Zero)
▶                throw new ArgumentNullException();
             return a.m_Handle;
         }
     }

💬 An exception is thrown from implicit operator IntPtr in type SafeHandleAccess (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

📄 Modules\UIElements\Core\Renderer\SafeHandleAccess.cs (line 26)

         public static implicit operator IntPtr(SafeHandleAccess a)
         {
             if (a.m_Handle == IntPtr.Zero)
▶                throw new ArgumentNullException();
             return a.m_Handle;
         }
     }

💬 An exception is thrown from implicit operator IntPtr in type SafeHandleAccess (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

SS023 Exception thrown from property getter 58 hits

📄 Modules\HierarchyCore\ScriptBindings\HierarchyViewModel.bindings.cs (line 751)

                 get
                 {
                     if (m_Version != m_ViewModel.m_Version)
▶                        throw new InvalidOperationException("HierarchyViewModel was modified.");
 
                     return ref HierarchyFlattenedNode.GetNodeByRef(in m_HierarchyFlattened[m_NodesPtr[m_Index]]);
                 }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Modules\HierarchyCore\ScriptBindings\HierarchyFlattened.bindings.cs (line 281)

                 get
                 {
                     if (m_Version != m_HierarchyFlattened.m_Version)
▶                        throw new InvalidOperationException("HierarchyFlattened was modified.");
 
                     return ref m_NodesPtr[m_Index];
                 }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 6 hits

📄 Modules\Properties\Runtime\Utility\TypeUtility.cs (line 294)

             }
 
             if (null == s_CreateTypeConstructor)
▶                throw new InvalidProgramException();
         }
 
         /// <summary>

💬 An exception is thrown from TypeUtility its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 Modules\Properties\Runtime\PropertyBags\ContainerPropertyBag.cs (line 27)

         {
             if (!TypeTraits.IsContainer(typeof(TContainer)))
             {
▶                throw new InvalidOperationException($"Failed to create a property bag for Type=[{typeof(TContainer)}]. The type is not a valid container type.");
             }
         }
 

💬 An exception is thrown from ContainerPropertyBag its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS027 Exception thrown from Dispose 26 hits

📄 Runtime\Export\NativeArray\NativeArray.cs (line 215)

 
             if (m_AllocatorLabel == Allocator.Invalid)
             {
▶                throw new InvalidOperationException("The NativeArray can not be Disposed because it was not allocated with a valid allocator.");
             }
 
             if (m_AllocatorLabel >= Allocator.FirstUserIndex)

💬 An exception is thrown from the Dispose() method in type NativeArray (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 Runtime\Export\NativeArray\NativeArray.cs (line 220)

 
             if (m_AllocatorLabel >= Allocator.FirstUserIndex)
             {
▶                throw new InvalidOperationException("The NativeArray can not be Disposed because it was allocated with a custom allocator, use CollectionHelper.Dispose in com.unity.collections package.");
             }
 
             if (m_AllocatorLabel > Allocator.None)

💬 An exception is thrown from the Dispose() method in type NativeArray (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS044 Attribute must specify [AttributeUsage] 28 hits

📄 Runtime\Scripting\Internal\LifecycleManagement\LifecycleAttributeBase.cs (line 7)

 
 namespace Unity.Scripting.LifecycleManagement
 {
▶    internal abstract class LifecycleAttributeBase : RequiredMemberAttribute
     {
     }
 }

💬 LifecycleAttributeBase should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Runtime\Scripting\Internal\LifecycleManagement\RequiredMemberAttribute.cs (line 9)

 
 namespace Unity.Scripting
 {
▶    internal abstract class RequiredMemberAttribute : Attribute
     {
     }
 }

💬 RequiredMemberAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS046 Unbounded stackalloc 14 hits

📄 Modules\TextCoreTextEngine\Managed\TextGenerator\RichTextTagParser.cs (line 419)

                 Debug.Assert(tag.end <= startingPos, "Tag end pass the point where we should start parsing");
                 Debug.Assert(allTags.Contains(tag));
             }
▶            Span<int?> parents = stackalloc int?[allTags.Count];
             Span<int?> lastTagOfType = stackalloc int?[TagsInfo.Length];
 
             int i = -1;

💬 An array is stack allocated without checking the length. Explicitly check the length against a constant value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS046-UnboundedStackalloc.md)

📄 Modules\TextCoreTextEngine\Managed\TextGenerator\RichTextTagParser.cs (line 420)

                 Debug.Assert(allTags.Contains(tag));
             }
             Span<int?> parents = stackalloc int?[allTags.Count];
▶            Span<int?> lastTagOfType = stackalloc int?[TagsInfo.Length];
 
             int i = -1;
             foreach (var tag in allTags)

SS050 Parameter assigned in constructor 8 hits

📄 Modules\IMGUI\GUIStyle.cs (line 89)

             if (other == null)
             {
                 Debug.LogError("Copied style is null. Using StyleNotFound instead.");
▶                other = GUISkin.error;
             }
             m_Ptr = Internal_Copy(this, other);
         }

💬 Suspicious assignment of parameter other in constructor of GUIStyle (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 Modules\IMGUI\LayoutEntry.cs (line 55)

             minHeight = _minHeight;
             maxHeight = _maxHeight;
             if (_style == null)
▶                _style = GUIStyle.none;
             style = _style;
         }
 

💬 Suspicious assignment of parameter _style in constructor of GUILayoutEntry (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS051 Locking on mutable reference 42 hits

📄 Modules\Accessibility\Bindings\AccessibilityManager.bindings.cs (line 115)

 
             NotificationContext[] contexts;
 
▶            lock (asyncNotificationContexts)
             {
                 if (asyncNotificationContexts.Count == 0)
                     return;

💬 A lock was obtained on asyncNotificationContexts but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Modules\Accessibility\Bindings\AccessibilityManager.bindings.cs (line 226)

 
         internal static void QueueNotification(NotificationContext notification)
         {
▶            lock (asyncNotificationContexts)
             {
                 asyncNotificationContexts.Enqueue(notification);
             }

SS057 Collection manipulated during traversal 30 hits

📄 Modules\InputForUI\Sanitizer\EventSanitizer.cs (line 124)

                                 Debug.LogWarning(
                                     $"ButtonReleased for not the last pressed button should have click count == 1, but got '{releaseEvent}'");
                             }
▶                            _activeButtons.RemoveAt(i);
                             return;
                         }
 

💬 Attempted to manipulate a collection while traversing. Ensure modifications don't affect the original collection. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS057-CollectionManipulatedDuringTraversal.md)

📄 Runtime\Export\RenderPipeline\RenderPipelineGlobalSettings.cs (line 86)

             {
                 if (settingsList[i] == null)
                 {
▶                    settingsList.RemoveAt(i);
                     --i;
                 }
             }

SS058 String concatenated in a loop 26 hits

📄 Runtime\Export\Unsafe\UnsafeUtility.cs (line 32)

             foreach (FieldInfo f in t.GetFields(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic))
             {
                 if (!IsBlittableValueType(f.FieldType))
▶                    ret += GetReasonForTypeNonBlittableImpl(f.FieldType, String.Format("{0}.{1}", name, f.Name));
             }
             return ret;
         }

📄 Modules\IMGUI\LayoutEntry.cs (line 112)

         {
             string space = "";
             for (int i = 0; i < indent; i++)
▶                space += " ";
             return space + string.Format("{1}-{0} (x:{2}-{3}, y:{4}-{5})", style != null ? style.name : "NULL", GetType(), rect.x, rect.xMax, rect.y, rect.yMax) +
                 "   -   W: " + minWidth + "-" + maxWidth + (stretchWidth != 0 ? "+" : "") + ", H: " + minHeight + "-" + maxHeight + (stretchHeight  != 0 ? "+" : "");
         }

SS066 Disposable field is not disposed 288 hits

📄 Modules\UIElements\Core\VisualElementHierarchy.cs (line 90)

 
         // each element has a ref to the root panel for internal bookkeeping
         // this will be null until a visual tree is added to a panel
▶        internal BaseVisualElementPanel elementPanel
         {
             [VisibleToOtherModules("UnityEditor.UIBuilderModule")]
             get;

💬 Disposable field elementPanel in type VisualElement is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Modules\UIElements\Core\Events\MouseEvents.cs (line 1061)

         /// <summary>
         /// The event that triggered the ContextualMenuPopulateEvent.
         /// </summary>
▶        public EventBase triggerEvent { get; private set; }
 
         ContextualMenuManager m_ContextualMenuManager;
 

💬 Disposable field triggerEvent in type ContextualMenuPopulateEvent is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

ServiceStack

4340 total diagnostics across 28 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 192 hits

📄 ServiceStack\src\ServiceStack.Common\Script\Methods\DefaultScripts.cs (line 68)

     }
 
     // methods without arguments can be used in bindings, e.g. {{ now |> dateFormat }}
▶    public DateTime now() => DateTime.Now;
     public DateTime utcNow() => DateTime.UtcNow;
 
     public DateTimeOffset nowOffset() => DateTimeOffset.Now;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 ServiceStack\src\ServiceStack.Common\Script\Methods\DefaultScripts.cs (line 68)

     }
 
     // methods without arguments can be used in bindings, e.g. {{ now |> dateFormat }}
▶    public DateTime now() => DateTime.Now;
     public DateTime utcNow() => DateTime.UtcNow;
 
     public DateTimeOffset nowOffset() => DateTimeOffset.Now;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 268 hits

📄 ServiceStack\src\ServiceStack.Client\CryptUtils.cs (line 220)

         public const int KeySize = 256;
         public const int KeySizeBytes = 256 / 8;
         public const int BlockSize = 128;
▶        public const int BlockSizeBytes = 128 / 8;
 
         public static SymmetricAlgorithm CreateSymmetricAlgorithm()
         {

💬 The operands in the divisive expression 128 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 ServiceStack\src\ServiceStack.Client\CryptUtils.cs (line 218)

     public static class AesUtils
     {
         public const int KeySize = 256;
▶        public const int KeySizeBytes = 256 / 8;
         public const int BlockSize = 128;
         public const int BlockSizeBytes = 128 / 8;
 

💬 The operands in the divisive expression 256 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 302 hits

📄 ServiceStack\src\ServiceStack.Common\Script\ScriptLanguage.Lisp.cs (line 3005)

 
     // Mapping from a quote symbol to its string representation
     static readonly Dictionary<Sym, string> Quotes = new Dictionary<Sym, string> {
▶        [QUOTE] = "'",
         [QUASIQUOTE] = "`",
         [UNQUOTE] = ",",
         [UNQUOTE_SPLICING] = ",@"

💬 Type Sym is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 ServiceStack\src\ServiceStack.Common\Script\ScriptLanguage.Lisp.cs (line 3006)

     // Mapping from a quote symbol to its string representation
     static readonly Dictionary<Sym, string> Quotes = new Dictionary<Sym, string> {
         [QUOTE] = "'",
▶        [QUASIQUOTE] = "`",
         [UNQUOTE] = ",",
         [UNQUOTE_SPLICING] = ",@"
     };

SS005 Equals() and GetHashCode() not implemented together 16 hits

📄 ServiceStack\src\ServiceStack.Common\Script\ScriptLanguage.Lisp.cs (line 532)

     }
 
     /// <summary>Lisp symbol</summary>
▶    public class Sym {
         /// <summary>The symbol's name</summary>
         public string Name { get; }
             

💬 Equals() and GetHashcode() must be implemented together on Sym (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 ServiceStack\src\ServiceStack.Common\Script\ScriptLanguage.Lisp.cs (line 532)

     }
 
     /// <summary>Lisp symbol</summary>
▶    public class Sym {
         /// <summary>The symbol's name</summary>
         public string Name { get; }
             

💬 Equals() and GetHashcode() must be implemented together on Sym (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 620 hits

📄 ServiceStack\src\ServiceStack.Interfaces\ValidationRule.cs (line 96)

     {
         unchecked
         {
▶            var hashCode = Id;
             hashCode = (hashCode * 397) ^ (Type != null ? Type.GetHashCode() : 0);
             hashCode = (hashCode * 397) ^ (Field != null ? Field.GetHashCode() : 0);
             hashCode = (hashCode * 397) ^ (CreatedBy != null ? CreatedBy.GetHashCode() : 0);

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 ServiceStack\src\ServiceStack.Interfaces\ValidationRule.cs (line 97)

         unchecked
         {
             var hashCode = Id;
▶            hashCode = (hashCode * 397) ^ (Type != null ? Type.GetHashCode() : 0);
             hashCode = (hashCode * 397) ^ (Field != null ? Field.GetHashCode() : 0);
             hashCode = (hashCode * 397) ^ (CreatedBy != null ? CreatedBy.GetHashCode() : 0);
             hashCode = (hashCode * 397) ^ CreatedDate.GetHashCode();

💬 GetHashCode() refers to mutable property Type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 4 hits

📄 ServiceStack\src\ServiceStack\Host\HttpListener\HttpListenerBase.cs (line 144)

                 }
             }
 
▶            throw ex;
         }
 
         ThreadPool.QueueUserWorkItem(listenCallback);

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 ServiceStack\src\ServiceStack.Razor\Support\Markdown\TextBlock.cs (line 188)

 			}
 			catch (Exception ex)
 			{
▶				throw ex;
 			}
 		}
 

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS015 String placeholders in wrong order 6 hits

📄 ServiceStack\src\ServiceStack.Razor\Support\Markdown\Markdown.cs (line 1174)

             return _horizontalRules.Replace(text, "<hr" + _emptyElementSuffix + "\n");
         }
 
▶        private static string _wholeList = string.Format(@"
             (                               # $1 = whole list
               (                             # $2
                 [ ]{{0,{1}}}

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 ServiceStack\src\ServiceStack.Razor\Support\Markdown\Markdown.cs (line 1138)

         {
             string header = match.Groups[1].Value;
             int level = match.Groups[2].Value.StartsWith("=") ? 1 : 2;
▶            return string.Format("<h{1}>{0}</h{1}>\n\n", RunSpanGamut(header), level);
         }
 
         private string AtxHeaderEvaluator(Match match)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 128 hits

📄 ServiceStack\src\ServiceStack.Interfaces\Jobs\IBackgroundJobs.cs (line 158)

 /// <summary>
 /// Status Update of a Job
 /// </summary>
▶public struct BackgroundJobStatusUpdate(BackgroundJob job, double? progress=null, string? status=null, string? log=null)
 {
     public BackgroundJob Job { get; } = job;
     public double? Progress { get; } = progress;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BackgroundJobStatusUpdate. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ServiceStack\src\ServiceStack.Interfaces\ScriptValue.cs (line 32)

     bool NoCache { get; set; }
 }
 
▶public struct ScriptValue : IScriptValue
 {
     public object? Value { get; set; }
     public string? Expression { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ScriptValue. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 108 hits

📄 ServiceStack\src\ServiceStack.Common\ExpressionUtils.cs (line 105)

 
     public static object GetValue(this MemberBinding binding)
     {
▶        switch (binding.BindingType)
         {
             case MemberBindingType.Assignment:
                 var assign = (MemberAssignment)binding;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 ServiceStack\src\ServiceStack.Common\ViewUtils.cs (line 668)

     public static string StyleText(string text, TextStyle textStyle)
     {
         if (text == null) return null;
▶        switch (textStyle)
         {
             case TextStyle.SplitCase:
                 return DefaultScripts.splitCase(text);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 428 hits

📄 ServiceStack\src\ServiceStack.Client\WebRequestUtils.cs (line 99)

                     value = value.Substring(1);
                 if (value.EndsWith("\""))
                     value = value.Substring(0, value.Length - 1);
▶                switch (name)
                 {
                     case "qop":
                         qop = value;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 ServiceStack\src\ServiceStack.Client\CachedServiceClient.cs (line 161)

                     var kvp = part.Split('=');
                     var key = kvp[0].Trim().ToLowerInvariant();
 
▶                    switch (key)
                     {
                         case "max-age":
                             if (kvp.Length == 2 && long.TryParse(kvp[1], out secs))

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 38 hits

📄 ServiceStack\src\ServiceStack.Common\Script\PageResult.cs (line 1186)

             catch (AggregateException e)
             {
                 var ex = e.UnwrapIfSingleException();
▶                throw ex;
             }
         }
     }

💬 An exception is thrown from the getter of property Result (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 ServiceStack\src\ServiceStack.Common\Script\PageResult.cs (line 1186)

             catch (AggregateException e)
             {
                 var ex = e.UnwrapIfSingleException();
▶                throw ex;
             }
         }
     }

💬 An exception is thrown from the getter of property Result (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 156 hits

📄 ServiceStack\src\ServiceStack.Client\AsyncServiceClient.cs (line 319)

                                 if (isBinary)
                                 {
                                     HttpLog.Append("(base64) ");
▶                                    HttpLog.AppendLine(Convert.ToBase64String(ms.ReadFully()));
                                 }
                                 else
                                 {

💬 Async overload available for StreamExtensions.ReadFully (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 ServiceStack\src\ServiceStack.Client\AsyncServiceClient.cs (line 323)

                                 }
                                 else
                                 {
▶                                    HttpLog.AppendLine(ms.ReadToEnd());
                                 }
                                 HttpLog.AppendLine().AppendLine();
                                 ms.Position = 0;

💬 Async overload available for StreamExtensions.ReadToEnd (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 170 hits

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 1195)

     public static Task<List<ServerEventUser>> GetChannelSubscribersAsync(this ServerEventsClient client)
     {
         var responseTask = client.ServiceClient.GetAsync(new GetEventSubscribers { Channels = client.Channels });
▶        return responseTask.ContinueWith(task => task.Result.Select(x => x.ToServerEventUser()).ToList());
     }
 
     internal static ServerEventUser ToServerEventUser(this Dictionary<string, string> map)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 712)

 
             Interlocked.Exchange(ref noOfContinuousErrors, 0);
 
▶            int len = task.Result;
             if (len > 0)
             {
                 var text = overflowText + encoding.GetString(buffer, 0, len);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 8 hits

📄 ServiceStack\src\ServiceStack\Host\Handlers\SoapHandler.cs (line 127)

 
             if (hasRequestFilters)
             {
▶                HostContext.ApplyRequestFiltersAsync(httpReq, httpRes, request).Wait();
                 if (httpRes.IsClosed)
                     return EmptyResponse(requestMsg, requestType);
             }

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 ServiceStack\src\ServiceStack\Host\Handlers\SoapHandler.cs (line 137)

 
             response = appHost.ApplyResponseConvertersAsync(httpReq, response).Result;
 
▶            appHost.ApplyResponseFiltersAsync(httpReq, httpRes, response).Wait();
             if (httpRes.IsClosed)
                 return EmptyResponse(requestMsg, requestType);

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS037 HttpClient instantiated directly 48 hits

📄 ServiceStack\src\ServiceStack.Client\ServiceClientBase.cs (line 84)

         {
             var cookies = new CookieContainer();
 #if NET6_0_OR_GREATER
▶            this.HttpClient = new System.Net.Http.HttpClient(new System.Net.Http.HttpClientHandler {
                 CookieContainer = cookies,
             }, disposeHandler: true);
 #endif

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 236)

         {
             Interlocked.Increment(ref timesStarted);
 
▶            httpClient = new HttpClient(HttpClientHandlerFactory(ServiceClient), disposeHandler:true);
             httpClient.Timeout = Timeout.InfiniteTimeSpan;
             
             var httpReq = new HttpRequestMessage(HttpMethod.Get, EventStreamUri)

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS038 HttpContext stored in a field 18 hits

📄 ServiceStack\src\ServiceStack\HttpContextFactory.cs (line 38)

             Scheme = baseUrl.LeftPart("://");
             IsHttps = Scheme == "https";
         }
▶        public HttpContext httpContext;
         public override HttpContext HttpContext => httpContext;
         public override string Method { get; set; } = "GET";
         public override string Scheme { get; set; }

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

📄 ServiceStack\src\ServiceStack\HttpContextFactory.cs (line 61)

 
     public class TestResponse : HttpResponse
     {
▶        public HttpContext httpContext;
         public override HttpContext HttpContext => httpContext;
 
         public override int StatusCode { get; set; } = 200;

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

SS041 Unnecessary enumerable materialization 14 hits

📄 ServiceStack\src\ServiceStack\FilesUploadFeature.cs (line 172)

             var ext = vfsPath.LastRightPart('.');
             if (!location.AllowExtensions.Contains(ext))
                 throw new ArgumentException(Errors.InvalidFileExtensionFmt.LocalizeFmt(req, string.Join(", ",
▶                    location.AllowExtensions.Select(x => '.' + x).ToList().OrderBy(x => x))), param);
         }
 
         if (location.MinFileBytes != null && file.ContentLength < location.MinFileBytes)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 ServiceStack\src\ServiceStack\FilesUploadFeature.cs (line 172)

             var ext = vfsPath.LastRightPart('.');
             if (!location.AllowExtensions.Contains(ext))
                 throw new ArgumentException(Errors.InvalidFileExtensionFmt.LocalizeFmt(req, string.Join(", ",
▶                    location.AllowExtensions.Select(x => '.' + x).ToList().OrderBy(x => x))), param);
         }
 
         if (location.MinFileBytes != null && file.ContentLength < location.MinFileBytes)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 214 hits

📄 ServiceStack\src\ServiceStack.Interfaces\AttributeBase.cs (line 8)

 
 namespace ServiceStack;
 
▶public class AttributeBase : Attribute
 {
     protected readonly Guid typeId = Guid.NewGuid(); //Hack required to give Attributes unique identity
 }

💬 AttributeBase should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 ServiceStack\src\ServiceStack.Interfaces\AttributeBase.cs (line 13)

     protected readonly Guid typeId = Guid.NewGuid(); //Hack required to give Attributes unique identity
 }
 
▶public class MetadataAttributeBase : AttributeBase, IReflectAttributeFilter
 {
     /// <summary>
     /// Don't include default bool or nullable int default values

💬 MetadataAttributeBase should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 76 hits

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 1098)

 
     public virtual string GetStatsDescription()
     {
▶        lock (this)
         {
             var sb = StringBuilderCache.Allocate().Append(GetType().Name + " SERVER STATS:\n");
             sb.AppendLine("===============");

💬 A lock was used referencing 'this' which can lead to deadlocks. It is recommended to create a dedicated lock instance of type System.Object instead. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS048-LockingOnDiscouragedObject.md)

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 1098)

 
     public virtual string GetStatsDescription()
     {
▶        lock (this)
         {
             var sb = StringBuilderCache.Allocate().Append(GetType().Name + " SERVER STATS:\n");
             sb.AppendLine("===============");

SS049 Comparing strings without StringComparison 32 hits

📄 ServiceStack\src\ServiceStack.Server\Auth\OrmLiteAuthRepository.cs (line 338)

         if (ForceCaseInsensitiveUserNameSearch)
         {
             userAuth = isEmail
▶                ? db.Select<TUserAuth>(q => q.Email.ToLower() == lowerUserName).FirstOrDefault()
                 : db.Select<TUserAuth>(q => q.UserName.ToLower() == lowerUserName).FirstOrDefault();
         }
             

📄 ServiceStack\src\ServiceStack.Server\Auth\OrmLiteAuthRepository.cs (line 339)

         {
             userAuth = isEmail
                 ? db.Select<TUserAuth>(q => q.Email.ToLower() == lowerUserName).FirstOrDefault()
▶                : db.Select<TUserAuth>(q => q.UserName.ToLower() == lowerUserName).FirstOrDefault();
         }
             
         return userAuth;

SS050 Parameter assigned in constructor 8 hits

📄 ServiceStack\src\ServiceStack.Common\MiniProfiler\Data\ProfiledConnection.cs (line 45)

         public ProfiledConnection(IDbConnection connection, IDbProfiler profiler, bool autoDisposeConnection = true)
         {
     		var hasConn = connection as IHasDbConnection;
▶			if (hasConn != null) connection = hasConn.DbConnection;
     		var dbConn = connection as DbConnection;
 
 			if (dbConn == null)

💬 Suspicious assignment of parameter connection in constructor of ProfiledConnection (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 ServiceStack\src\ServiceStack.Common\MiniProfiler\Data\ProfiledConnection.cs (line 45)

         public ProfiledConnection(IDbConnection connection, IDbProfiler profiler, bool autoDisposeConnection = true)
         {
     		var hasConn = connection as IHasDbConnection;
▶			if (hasConn != null) connection = hasConn.DbConnection;
     		var dbConn = connection as DbConnection;
 
 			if (dbConn == null)

💬 Suspicious assignment of parameter connection in constructor of ProfiledConnection (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS051 Locking on mutable reference 200 hits

📄 ServiceStack\src\ServiceStack\Funq\Container.cs (line 22)

 
     public int DisposablesCount
     {
▶        get { lock (disposables) return disposables.Count; }
     }
 
     // Disposable components include factory-scoped instances that we don't keep 

💬 A lock was obtained on disposables but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 ServiceStack\src\ServiceStack\Funq\Container.cs (line 55)

     public Container CreateChildContainer()
     {
         var child = InstantiateChildContainer();
▶        lock (childContainers) childContainers.Push(child);
         return child;
     }
 

💬 A lock was obtained on childContainers but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS056 HttpRequest.Form read synchronously 24 hits

📄 ServiceStack\src\ServiceStack\Host\NetCore\NetCoreRequest.cs (line 170)

             var nvc = new NameValueCollection();
             if (request.HasFormContentType)                    
             {
▶                foreach (var form in request.Form)
                 {
                     nvc.Add(form.Key, form.Value);
                 }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 ServiceStack\src\ServiceStack\Host\NetCore\NetCoreRequest.cs (line 242)

             if (!request.HasFormContentType)                    
                 return Array.Empty<IHttpFile>();
 
▶            var filesCount = request.Form.Files.Count;
             files = new IHttpFile[filesCount];
             for (var i=0; i<filesCount; i++)
             {

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS057 Collection manipulated during traversal 64 hits

📄 ServiceStack\src\ServiceStack\Html\MarkdownDeep\BlockProcessor.cs (line 1269)

 				{
 					lines[i - 1].contentEnd = lines[i].contentEnd;
 					FreeBlock(lines[i]);
▶					lines.RemoveAt(i);
 					i--;
 					continue;
 				}

📄 ServiceStack\src\ServiceStack\Html\MarkdownDeep\BlockProcessor.cs (line 1378)

 				{
 					lines[i - 1].contentEnd = lines[i].contentEnd;
 					FreeBlock(lines[i]);
▶					lines.RemoveAt(i);
 					i--;
 					continue;
 				}

SS058 String concatenated in a loop 148 hits

📄 ServiceStack\src\ServiceStack.Client\WebRequestUtils.cs (line 191)

             var pad = "";
             for (var i = 0; i < (8 - ("" + num).Length); i++)
             {
▶                pad += "0";
             }
             var ret = pad + num;
             return ret;

📄 ServiceStack\src\ServiceStack.Client\WebRequestUtils.cs (line 191)

             var pad = "";
             for (var i = 0; i < (8 - ("" + num).Length); i++)
             {
▶                pad += "0";
             }
             var ret = pad + num;
             return ret;

SS059 IAsyncDisposable not disposed asynchronously 318 hits

📄 ServiceStack\src\ServiceStack.Client\ServiceClientBase.cs (line 1104)

             var webRequest = SendRequest(httpMethod, requestUri, request);
             using var response = await webRequest.GetResponseAsync();
             ApplyWebResponseFilters(response);
▶            using var stream = response.ResponseStream();
             return await stream.ReadFullyAsync();
         }
 

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 ServiceStack\src\ServiceStack.Client\ServiceClientBase.cs (line 1743)

 
             if (requestBody != null)
             {
▶                using var reqStream = PclExport.Instance.GetRequestStream(webReq);
                 using var writer = new StreamWriter(reqStream, HttpUtils.UseEncoding);
                 await writer.WriteAsync(requestBody).ConfigAwait();
             }

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 14 hits

📄 ServiceStack\src\ServiceStack\ServerEventsFeature.cs (line 1474)

             return;
 
         var subs = map.TryGet(key);
▶        if (subs == null || subs.Count == 0)
             return;
 
         var now = DateTime.UtcNow;

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 ServiceStack\src\ServiceStack\ServerEventsFeature.cs (line 1474)

             return;
 
         var subs = map.TryGet(key);
▶        if (subs == null || subs.Count == 0)
             return;
 
         var now = DateTime.UtcNow;

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

SS066 Disposable field is not disposed 718 hits

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 93)

     byte[] buffer;
     readonly Encoding encoding = Encoding.UTF8;
 
▶    CancellationTokenSource cancel;
     private ITimer heartbeatTimer;
 
     public ServerEventConnect ConnectionInfo { get; private set; }

💬 Disposable field cancel in type ServerEventsClient is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 ServiceStack\src\ServiceStack.Client\ServerEventsClient.cs (line 94)

     readonly Encoding encoding = Encoding.UTF8;
 
     CancellationTokenSource cancel;
▶    private ITimer heartbeatTimer;
 
     public ServerEventConnect ConnectionInfo { get; private set; }

💬 Disposable field heartbeatTimer in type ServerEventsClient is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

SqlSugar

3788 total diagnostics across 22 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2062 hits

📄 Src\Asp.NetCore2\NugetTest\Demo\Demo0_SqlSugarClient.cs (line 44)

                 Console.WriteLine(db.Ado.Connection.ConnectionString);
             };
             Console.WriteLine("Master:");
▶            db.Insertable(new Order() { Name = "abc", CustomId = 1, CreateTime = DateTime.Now }).ExecuteCommand();
             Console.WriteLine("Slave:");
             db.Queryable<Order>().First();
             Console.WriteLine("#### MasterSlave End ####");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Src\Asp.NetCore2\NugetTest\Demo\Demo0_SqlSugarClient.cs (line 78)

 
             //Create tables
             db.CodeFirst.InitTables(typeof(OrderItem),typeof(Order));
▶            var id = db.Insertable(new Order() { Name = "order1", CustomId = 1, Price = 0, CreateTime = DateTime.Now }).ExecuteReturnIdentity();
 
             //Insert data
             db.Insertable(new OrderItem() { OrderId = id, Price = 0, CreateTime=DateTime.Now }).ExecuteCommand();

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 90 hits

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\Helper.cs (line 50)

         public static DateTime Long16ToDateTime(long timestampInMicroseconds)
         {
             // 计算秒和微秒部分
▶            long seconds = timestampInMicroseconds / 1000000;
             long microseconds = timestampInMicroseconds % 1000000;
 
             // 创建 DateTimeOffset 对象，设置秒和微秒部分

💬 The operands in the divisive expression timestampInMicroseconds / 1000000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\Helper.cs (line 70)

         public static DateTime Long19ToDateTime(long timestampInNanoseconds)
         {
             // 计算秒和纳秒部分
▶            long seconds = timestampInNanoseconds / 1000000000;
             long nanoseconds = timestampInNanoseconds % 1000000000;
 
             // 创建 DateTimeOffset 对象，设置秒和纳秒部分

💬 The operands in the divisive expression timestampInNanoseconds / 1000000000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 72 hits

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\TdengineParameterCollection.cs (line 49)

 
         public override bool Contains(object value)
         {
▶            return parameters.Contains((TDengineParameter)value);
         }
 
         public override void CopyTo(Array array, int index)

💬 Type TDengineParameter is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Src\Asp.NetCore2\SqlSugar\Utilities\UtilMethods.cs (line 136)

                 DataRow newRow = finalTable.NewRow();
                 foreach (DataColumn column in table.Columns)
                 {
▶                    var value = row[column];
                     if (value is DateTimeOffset dto)
                         newRow[column.ColumnName] = dto.DateTime;
                     else

💬 Type DataColumn is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 Src\Asp.NetCore2\SqlSeverTest\UserTestCases\UnitTest\Unitasf1\ProductProcessUnit.cs (line 99)

         /// </summary>
         public override int GetHashCode()
         {
▶            return (Id == null) ? 0 : Id.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Src\Asp.NetCore2\SqlSeverTest\UserTestCases\UnitTest\Unitasf1\ProductProcessUnit.cs (line 99)

         /// </summary>
         public override int GetHashCode()
         {
▶            return (Id == null) ? 0 : Id.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS009 Random instantiated in a loop 4 hits

📄 Src\Asp.NetCore2\QuestDbTest\Demo\DemoZ_Thread.cs (line 44)

                 {
                     var sw = new Stopwatch();
                     sw.Start();
▶                    Random random = new Random();
                     while (sw.Elapsed < TimeSpan.FromSeconds(20))
                     {
                         var param = new { userid = random.Next(0, 10000000) };

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

📄 Src\Asp.NetCore2\QuestDbTest\Demo\DemoZ_Thread.cs (line 88)

                 {
                     var sw = new Stopwatch();
                     sw.Start();
▶                    Random random = new Random();
                     while (sw.Elapsed < TimeSpan.FromSeconds(10))
                     {
                         try

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

SS013 Rethrow exception without losing stacktrace 174 hits

📄 Src\Asp.NetCore2\SqlSugar\Abstract\CodeFirstProvider\CodeFirstProvider.cs (line 249)

             }
             catch (Exception ex)
             {
▶                throw ex;
             }
             finally
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 Src\Asp.NetCore2\SqlSugar\Abstract\AdoProvider\AdoProvider.cs (line 507)

                 CommandType = CommandType.Text;
                 if (ErrorEvent != null)
                     ExecuteErrorEvent(sql, parameters, ex);
▶                throw ex;
             }
             finally
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS015 String placeholders in wrong order 118 hits

📄 Src\Asp.NetCore2\SqlSugar\ExpressionsToSql\DbMethods\DefaultDbMethod.cs (line 277)

             var parameter = model.Args[0];
             var parameter2 = model.Args[1];
             var parameter3 = model.Args[2];
▶            return string.Format(" (DATEDIFF({2},{0},{1})=0) ", parameter.MemberName, parameter2.MemberName, parameter3.MemberValue);
         }
 
         public virtual string DateAddByType(MethodCallExpressionModel model)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 Src\Asp.NetCore2\SqlSugar\ExpressionsToSql\DbMethods\DefaultDbMethod.cs (line 285)

             var parameter = model.Args[0];
             var parameter2 = model.Args[1];
             var parameter3 = model.Args[2];
▶            return string.Format(" (DATEADD({2},{1},{0})) ", parameter.MemberName, parameter2.MemberName, parameter3.MemberValue);
         }
 
         public virtual string DateAddDay(MethodCallExpressionModel model)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 Src\Asp.NetCore2\SqlSugar\Interface\IStorageable.cs (line 103)

         Other=4,
         Ignore=5,
     }
▶    internal struct KeyValuePair<TKey, TValue,TValue2>
     {
         public TKey key;
         public TValue value1;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct KeyValuePair. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Src\Asp.NetCore2\SqlSugar\Entities\DiscriminatorObject .cs (line 9)

 
 namespace SqlSugar 
 {
▶    public struct DiscriminatorObject
     {
         public string FieldName { get; set; }
         public string FieldValue { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DiscriminatorObject. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 10 hits

📄 Src\Asp.NetCore2\SqlSugar\ExpressionsToSql\ResolveItems\MemberConstExpressionResolve.cs (line 19)

             object value = ExpressionTool.GetMemberValue(expression.Member, expression);
             var baseParameter = parameter.BaseParameter;
             var isSetTempData = baseParameter.CommonTempData.HasValue() && baseParameter.CommonTempData.Equals(CommonTempDataType.Result);
▶            switch (parameter.Context.ResolveType)
             {
                 case ResolveExpressType.Update:
                 case ResolveExpressType.SelectSingle:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Src\Asp.NetCore2\SqlSugar\Realization\Sqlite\SqlBuilder\SqliteExpressionContext.cs (line 277)

             var parameter3 = model.Args[2].MemberValue;
             var type = (DateType)Enum.Parse(typeof(DateType), parameter3.ObjToString(), false);
             int time = 1;
▶            switch (type)
             {
                 case DateType.Year:
                     time = time * 1 / 365;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 26 hits

📄 Src\Asp.NetCore2\SqlSugar\ExpressionsToSql\ResolveItems\MemberConstExpressionResolve.cs (line 19)

             object value = ExpressionTool.GetMemberValue(expression.Member, expression);
             var baseParameter = parameter.BaseParameter;
             var isSetTempData = baseParameter.CommonTempData.HasValue() && baseParameter.CommonTempData.Equals(CommonTempDataType.Result);
▶            switch (parameter.Context.ResolveType)
             {
                 case ResolveExpressType.Update:
                 case ResolveExpressType.SelectSingle:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Src\Asp.NetCore2\SqlSugar\Realization\Sqlite\SqlBuilder\SqliteExpressionContext.cs (line 277)

             var parameter3 = model.Args[2].MemberValue;
             var type = (DateType)Enum.Parse(typeof(DateType), parameter3.ObjToString(), false);
             int time = 1;
▶            switch (type)
             {
                 case DateType.Year:
                     time = time * 1 / 365;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 26 hits

📄 Src\Asp.NetCore2\SqlSugar\Realization\MySql\MySqlProvider.cs (line 40)

                     {
                         if (ex is SqlSugarException)
                         {
▶                            throw ex;
                         }
                         else
                         {

💬 An exception is thrown from the getter of property Connection (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Src\Asp.NetCore2\SqlSugar.TDSQLForPGODBC\TDSQLForPG\TDSQLForPGODBCProvider.cs (line 33)

                     }
                     catch (Exception ex)
                     {
▶                        throw ex;
                     }
                 }
                 return base._DbConnection;

💬 An exception is thrown from the getter of property Connection (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 2 hits

📄 Src\Asp.NetCore2\SqlSeverTest\UserTestCases\UnitTest\UValidateExtensions.cs (line 40)

             
             if (_validateExtensionsType == null)
             {
▶                throw new Exception("Could not find SqlSugar.ValidateExtensions type");
             }
         }
         

💬 An exception is thrown from UValidateExtensions its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 Src\Asp.NetCore2\SqlSeverTest\UserTestCases\UnitTest\UValidateExtensions.cs (line 40)

             
             if (_validateExtensionsType == null)
             {
▶                throw new Exception("Could not find SqlSugar.ValidateExtensions type");
             }
         }
         

💬 An exception is thrown from UValidateExtensions its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS033 Async overload is available 216 hits

📄 Src\Asp.NetCore2\MongoDb.Ado.data\ExecuteNonQueryItemsAsync\NonFindHandlerAsync.cs (line 21)

         {
             using (var dr = await new DbDataReaderFactoryAsync().HandleAsync(operation, collection, json,token,context))
             {
▶                if (dr.Read())
                 {
 
                 }

💬 Async overload available for DbDataReader.Read (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Src\Asp.NetCore2\MongoDb.Ado.data\ExecuteScalarItemsAsync\ExecuteScalarHandlerAsync.cs (line 18)

         {
             using (var dbReader = await new DbDataReaderFactoryAsync().HandleAsync(operation, collection, json,cancellationToken,context))
             {
▶                if (dbReader.Read())
                 {
                    return dbReader.GetValue(0);
                 } 

💬 Async overload available for DbDataReader.Read (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 230 hits

📄 Src\Asp.NetCore2\NugetTest\Demo\Demo0_SqlSugarClient.cs (line 334)

 
             });
             result2.Wait();
▶            if (result2.Result.IsSuccess == false)
             {
                 Console.WriteLine("---Roll back");
                 db.ChangeDatabase("1");//use sqlserver

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Src\Asp.NetCore2\OracleTest\UserTestCases\UnitTest\UAdo.cs (line 16)

 
             var task1 = Db.Ado.GetScalarAsync("select 1");
             task1.Wait();
▶            UValidate.Check(1, task1.Result, "ado");
 
             var task2 = Db.Ado.GetIntAsync("select 2");
             task2.Wait();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 Src\Asp.NetCore2\SqlSugar\Entities\MapperCache.cs (line 151)

             }
             else
             {
▶                var ids = _list.Select(action).ToList().Distinct().ToList();
                 var result = _context.Queryable<Result>().In(ids).ToList();
                 caches.Add(key, result);
                 return result;

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Src\Asp.NetCore2\SqlSugar\Entities\MapperCache.cs (line 151)

             }
             else
             {
▶                var ids = _list.Select(action).ToList().Distinct().ToList();
                 var result = _context.Queryable<Result>().In(ids).ToList();
                 caches.Add(key, result);
                 return result;

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 Src\Asp.NetCore2\SqlSugar.TDengineCore\STableAttribute.cs (line 7)

 
 namespace SqlSugar.TDengine
 {
▶    public class STableAttribute:Attribute
     {
         public string Tags { get; set; }
         public string Tag1 { get; set; }

💬 STableAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Src\Asp.NetCore2\SqlSugar.TDengineCore\STableAttribute.cs (line 7)

 
 namespace SqlSugar.TDengine
 {
▶    public class STableAttribute:Attribute
     {
         public string Tags { get; set; }
         public string Tag1 { get; set; }

💬 STableAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 14 hits

📄 Src\Asp.NetCore2\SqlSugar\Abstract\CodeFirstProvider\CodeFirstProvider.cs (line 405)

             List<DbColumnInfo> columns = new List<DbColumnInfo>();
             if (entityInfo.Columns.HasValue())
             {
▶                foreach (var item in entityInfo.Columns.OrderBy(it => it.IsPrimarykey ? 0 : 1).Where(it => it.IsIgnore == false))
                 {
                     DbColumnInfo dbColumnInfo = EntityColumnToDbColumn(entityInfo, tableName, item);
                     columns.Add(dbColumnInfo);

📄 Src\Asp.NetCore2\SqlSugar\ExpressionsToSql\ResolveItems\MapperExpressionResolve.cs (line 242)

 
         private MapperExpression GetMapper(MemberExpression exp)
         {
▶            var mapper = mappers.Where(it => it.Type == MapperExpressionType.oneToOne)
                 .Reverse()
                 .Where(it => (it.FillExpression as LambdaExpression).Body.ToString() == exp.Expression.ToString()).FirstOrDefault();
             ThrowTrue(mapper == null);

SS049 Comparing strings without StringComparison 456 hits

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\TdengineType.cs (line 11)

          
         public static object GetObjectByType(object dataValue, byte typeValue)
         {
▶            if (dataValue is string &&dataValue?.ToString().ToUpper() == "NULL") 
             {
                 return null;
             }

📄 Src\Asp.NetCore2\SqlSugar\Abstract\DbBindProvider\DbBindProvider.cs (line 24)

         {
             if (csharpTypeName == UtilConstants.ByteArrayType.Name)
                 return "varbinary";
▶            if (csharpTypeName.ToLower() == "int32")
                 csharpTypeName = "int";
             if (csharpTypeName.ToLower() == "int16")
                 csharpTypeName = "short";

SS051 Locking on mutable reference 12 hits

📄 Src\Asp.NetCore2\SqlSugar\Abstract\CodeFirstProvider\CodeFirstProvider.cs (line 83)

                 }
             }
             //Prevent concurrent requests if used in your program
▶            lock (CodeFirstProvider.LockObject)
             {
                 MappingTableList oldTableList = CopyMappingTalbe();
                 //this.Context.Utilities.RemoveCacheAll();

💬 A lock was obtained on LockObject but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Src\Asp.NetCore2\SqlSugar\DistributedSystem\Snowflake\SnowFlakeSingle.cs (line 26)

 			{
 				if (worker == null) 
 				{
▶					lock (LockObject)
 					{
 						if (worker == null)
 						{

SS058 String concatenated in a loop 212 hits

📄 Src\Asp.NetCore2\SqlSugar\Utilities\UtilMethods.cs (line 1348)

 
             for (int i = 0; i < targetData.Length; i++)
             {
▶                byte2String += targetData[i].ToString("x");
             }
 
             return byte2String;

📄 Src\Asp.NetCore2\SqlSugar\Abstract\SqlBuilderProvider\DeleteBuilder.cs (line 109)

                 foreach (var item in _WhereInfos)
                 {
                     var isFirst = i == 0;
▶                    whereString += isFirst ? "WHERE " : "AND ";
                     whereString += (item + UtilConstants.Space);
                     ++i;
                 }

SS059 IAsyncDisposable not disposed asynchronously 28 hits

📄 Src\Asp.NetCore2\MongoDb.Ado.data\ExecuteNonQueryItemsAsync\NonFindHandlerAsync.cs (line 19)

 
         public async Task<int> HandleAsync(IMongoCollection<BsonDocument> collection, string json)
         {
▶            using (var dr = await new DbDataReaderFactoryAsync().HandleAsync(operation, collection, json,token,context))
             {
                 if (dr.Read())
                 {

💬 DbDataReader can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Src\Asp.NetCore2\MongoDb.Ado.data\ExecuteScalarItemsAsync\ExecuteScalarHandlerAsync.cs (line 16)

     {
         public async Task<object> HandleAsync(string operation, IMongoCollection<BsonDocument> collection, string json,CancellationToken cancellationToken, HandlerContext context)
         {
▶            using (var dbReader = await new DbDataReaderFactoryAsync().HandleAsync(operation, collection, json,cancellationToken,context))
             {
                 if (dbReader.Read())
                 {

💬 DbDataReader can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 24 hits

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\TdengineCommand.cs (line 18)

     public class TDengineCommand : DbCommand
     {
         private string commandText;
▶        private TDengineConnection connection;
         private IntPtr currentRes;
         public TDengineCommand()
         {

💬 Disposable field connection in type TDengineCommand is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Src\Asp.NetCore2\TDengine.Ado.Data\SqlSugar.TDengine\TdengineCommand.cs (line 63)

             }
         }
 
▶        protected override DbTransaction DbTransaction { get; set; }
 
         public override void Cancel()
         {

💬 Disposable field DbTransaction in type TDengineCommand is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

FastReport

3606 total diagnostics across 17 rules

SS001 Async method with void return type 6 hits

📄 FastReport.Base\Utils\Config.cs (line 272)

         /// <remarks>
         /// Call this method at an application start to warm up the Roslyn compiler (used in NetCore).
         /// </remarks>
▶        public static async void CompilerWarmup()
         {
             Report.EnsureInit();
             await Task.Run(() =>

💬 Method CompilerWarmup is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 FastReport.Base\Utils\Config.cs (line 272)

         /// <remarks>
         /// Call this method at an application start to warm up the Roslyn compiler (used in NetCore).
         /// </remarks>
▶        public static async void CompilerWarmup()
         {
             Report.EnsureInit();
             await Task.Run(() =>

💬 Method CompilerWarmup is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 6 hits

📄 FastReport.Base\Fakes.cs (line 19)

             get
             {
 #if !USE_FAKES
▶                return System.DateTime.Now;
 #else
                 return new System.DateTime(0, System.DateTimeKind.Utc);
 #endif

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 FastReport.Base\Fakes.cs (line 19)

             get
             {
 #if !USE_FAKES
▶                return System.DateTime.Now;
 #else
                 return new System.DateTime(0, System.DateTimeKind.Utc);
 #endif

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 882 hits

📄 FastReport.Base\CellularTextObject.cs (line 220)

             if (HorzAlign == HorzAlign.Right)
                 offset = table.ColumnCount - text.Length;
             else if (HorzAlign == HorzAlign.Center)
▶                offset = (table.ColumnCount - text.Length) / 2;
 
             for (int i = 0; i < text.Length; i++)
             {

💬 The operands in the divisive expression (table.ColumnCount - text.Length) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 FastReport.Base\Export\Image\ImageExport.cs (line 579)

             if (image == bigImage)
             {
                 if (ImageFormat != ImageExportFormat.Metafile)
▶                    g.TranslateTransform(image.Width / 2 - width / 2 + page.LeftMargin * Units.Millimeters * zoomX,
                     curOriginY + paddingNonSeparatePages + page.TopMargin * Units.Millimeters * zoomY);
                 else
                     g.TranslateTransform(widthK / 2 - width / 2 + page.LeftMargin * Units.Millimeters * zoomX,

💬 The operands in the divisive expression image.Width / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 54 hits

📄 FastReport.Base\Data\Column.cs (line 256)

                 {
                     DataSourceBase dataSource = ParentDataSource;
                     if (dataSource != null)
▶                        return dataSource[this];
                 }
                 return null;
             }

💬 Type Column is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 FastReport.Base\Data\JsonConnection\JsonTableDataSource.cs (line 374)

 
             for (int i = 0; i < table.Columns.Count; i++)
             {
▶                if (!(table.Columns[i].Calculated || saveColumns.Contains(table.Columns[i])))
                 {
                     table.Columns.RemoveAt(i);
                     i--;

SS008 GetHashCode() refers to mutable or static member 264 hits

📄 FastReport.Base\TextObject.cs (line 195)

             unchecked
             {
                 int hashCode = -1051315095;
▶                hashCode = hashCode * -1521134295 + firstLineIndent.GetHashCode();
                 hashCode = hashCode * -1521134295 + lineSpacing.GetHashCode();
                 hashCode = hashCode * -1521134295 + lineSpacingType.GetHashCode();
                 hashCode = hashCode * -1521134295 + skipFirstLineIndent.GetHashCode();

💬 GetHashCode() refers to mutable field firstLineIndent (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 FastReport.Base\TextObject.cs (line 196)

             {
                 int hashCode = -1051315095;
                 hashCode = hashCode * -1521134295 + firstLineIndent.GetHashCode();
▶                hashCode = hashCode * -1521134295 + lineSpacing.GetHashCode();
                 hashCode = hashCode * -1521134295 + lineSpacingType.GetHashCode();
                 hashCode = hashCode * -1521134295 + skipFirstLineIndent.GetHashCode();
                 return hashCode;

💬 GetHashCode() refers to mutable field lineSpacing (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 42 hits

📄 FastReport.Base\Data\XmlDataConnection.cs (line 226)

             }
             catch (Exception e)
             {
▶                throw e;
             }
         }
 

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 FastReport.Base\Data\XmlDataConnection.cs (line 265)

             }
             catch (Exception e)
             {
▶                throw e;
             }
         }
         

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 120 hits

📄 FastReport.Base\Fakes.cs (line 44)

     }
 
 
▶    internal struct Guid
     {
 #if NETSTANDARD || NETCOREAPP
         [MethodImpl(MethodImplOptions.AggressiveInlining)]

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Guid. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 FastReport.Base\Fakes.cs (line 9)

 
 namespace SystemFake
 {
▶    internal struct DateTime
     {
         internal static System.DateTime Now
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DateTime. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 138 hits

📄 FastReport.Base\Export\Image\ImageExport.cs (line 456)

                 else
                 {
                     ImageFormat format = System.Drawing.Imaging.ImageFormat.Bmp;
▶                    switch (ImageFormat)
                     {
                         case ImageExportFormat.Gif:
                             format = System.Drawing.Imaging.ImageFormat.Gif;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 FastReport.Base\BandBase.cs (line 471)

                     {
                         c.Top += dy / 2;
                     }
▶                    switch (c.Dock)
                     {
                         case DockStyle.Left:
                             c.Bounds = new RectangleF(remainingBounds.Left, remainingBounds.Top, c.Width, remainingBounds.Height);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 594 hits

📄 FastReport.Base\Code\VbCodeHelper.cs (line 23)

 
         private string GetEquivalentKeyword1(string s)
         {
▶            switch (s)
             {
                 case "DateTime":
                     return "Date";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 FastReport.Base\Code\CsCodeHelper.cs (line 34)

 
         private string GetEquivalentKeyword1(string s)
         {
▶            switch (s)
             {
                 case "Object":
                     return "object";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 12 hits

📄 FastReport.Base\Barcode\LinearBarcodeBase.cs (line 107)

                 if (pattern == null)
                 {
                     MyRes res = new MyRes("Messages");
▶                    throw new FormatException(res.Get("BarcodeManyError"));
                 }
                 return pattern;
             }

💬 An exception is thrown from the getter of property Code (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 FastReport.Base\Barcode\Aztec\BitMatrix.cs (line 72)

             {
                 if (width != height)
                 {
▶                    throw new System.ArgumentException("Can't call getDimension() on a non-square matrix");
                 }
                 return width;
             }

💬 An exception is thrown from the getter of property Dimension (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 6 hits

📄 FastReport.Base\Data\JsonConnection\JsonDataSourceConnection.cs (line 159)

                     jsonDataSource.Name = fixedTableName;
 
                 jsonDataSource.Parent = this;
▶                jsonDataSource.InitSchema();
                 jsonDataSource.Enabled = true;
             }
 

💬 Async overload available for JsonTableDataSource.InitSchema (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 FastReport.Base\Data\JsonConnection\JsonDataSourceConnection.cs (line 159)

                     jsonDataSource.Name = fixedTableName;
 
                 jsonDataSource.Parent = this;
▶                jsonDataSource.InitSchema();
                 jsonDataSource.Enabled = true;
             }
 

💬 Async overload available for JsonTableDataSource.InitSchema (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS048 Locking on discouraged object (string, Type, this) 6 hits

📄 FastReport.Base\Report.cs (line 1163)

         {
             if (disposing)
             {
▶                lock (this)
                 {
                     _site?.Container?.Remove(this);
                 }

📄 FastReport.Base\Report.cs (line 1163)

         {
             if (disposing)
             {
▶                lock (this)
                 {
                     _site?.Container?.Remove(this);
                 }

SS049 Comparing strings without StringComparison 162 hits

📄 FastReport.Base\ComponentBase.cs (line 511)

             if (!String.IsNullOrEmpty(VisibleExpression))
             {
                 string expression = Code.CodeUtils.FixExpressionWithBrackets(VisibleExpression);
▶                if (expression.ToLower() == "true" || expression.ToLower() == "false")
                 {
                     expression = expression.ToLower();
                 }

📄 FastReport.Base\ComponentBase.cs (line 511)

             if (!String.IsNullOrEmpty(VisibleExpression))
             {
                 string expression = Code.CodeUtils.FixExpressionWithBrackets(VisibleExpression);
▶                if (expression.ToLower() == "true" || expression.ToLower() == "false")
                 {
                     expression = expression.ToLower();
                 }

SS057 Collection manipulated during traversal 70 hits

📄 FastReport.OpenSource\Data\DataConnectionBase.Core.cs (line 20)

                 Config.OnFilterConnectionTables(this, e);
                 if (e.Skip)
                 {
▶                    tableNames.RemoveAt(i);
                     i--;
                 }
             }

📄 FastReport.Base\Export\ExportBase.cs (line 278)

             {
                 if (pages[i] < 0 || pages[i] >= total)
                 {
▶                    pages.RemoveAt(i);
                     i--;
                 }
             }

SS058 String concatenated in a loop 816 hits

📄 FastReport.Base\Code\VbCodeHelper.cs (line 55)

 
                 foreach (Type elementType in type.GetGenericArguments())
                 {
▶                    result += GetTypeDeclaration(elementType) + ",";
                 }
 
                 result = result.Substring(0, result.Length - 1) + ")";

📄 FastReport.OpenSource\Utils\NetRepository.Core.cs (line 35)

                 if (node.Attributes != null)
                 {
                     foreach (XmlAttribute attr in node.Attributes)
▶                        result = result + GetInnerText(attr);
                 }
 
                 // TZ: param name and description was displayed in one word

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 FastReport.Base\Data\XmlDataConnection.cs (line 402)

             {
                 var encoding = response.CharacterSet.Equals(String.Empty) ? Encoding.UTF8 : Encoding.GetEncoding(response.CharacterSet);
 
▶                using (var responseStream = response.GetResponseStream())
                 using (var reader = new System.IO.StreamReader(responseStream, encoding))
                     dataset.ReadXmlSchema(reader);
             }

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 FastReport.Base\Data\XmlDataConnection.cs (line 402)

             {
                 var encoding = response.CharacterSet.Equals(String.Empty) ? Encoding.UTF8 : Encoding.GetEncoding(response.CharacterSet);
 
▶                using (var responseStream = response.GetResponseStream())
                 using (var reader = new System.IO.StreamReader(responseStream, encoding))
                     dataset.ReadXmlSchema(reader);
             }

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 424 hits

📄 FastReport.Base\ReportComponentBase.cs (line 133)

         private string savedBookmark;
         private Border savedBorder;
         private FillBase savedFill;
▶        private Cursor cursor;
         private string mouseMoveEvent;
         private string mouseUpEvent;
         private string mouseDownEvent;

💬 Disposable field cursor in type ReportComponentBase is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 FastReport.Base\Preview\PreparedPages.cs (line 54)

     public partial class PreparedPages : IDisposable
     {
         #region Fields
▶        private SourcePages sourcePages;
         private List<PreparedPage> preparedPages;
         private Dictionary dictionary;
         private Bookmarks bookmarks;

💬 Disposable field sourcePages in type PreparedPages is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

smtp4dev

3332 total diagnostics across 18 rules

SS001 Async method with void return type 4 hits

📄 Rnwood.Smtp4dev\Server\ImapServer.cs (line 62)

             }
         }
 
▶        public async void TryStart()
         {
             this.lastStartOptions = serverOptions.CurrentValue with { };
 

💬 Method TryStart is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Rnwood.Smtp4dev\Server\ImapServer.cs (line 62)

             }
         }
 
▶        public async void TryStart()
         {
             this.lastStartOptions = serverOptions.CurrentValue with { };
 

💬 Method TryStart is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 312 hits

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest_NonceManager.cs (line 174)

             lock(m_pNonces){
                 for(int i=0;i<m_pNonces.Count;i++){
                     // Nonce expired, remove it.
▶                    if(m_pNonces[i].CreateTime.AddSeconds(m_ExpireTime) > DateTime.Now){
                         m_pNonces.RemoveAt(i);
                         i--;
                     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 imapserver\New.LumiSoft.Net\IO\SmartStream.cs (line 1051)

             m_pReadBuffer = new byte[m_BufferSize];
             m_pReadBufferOP = new BufferReadAsyncOP(this);
 
▶            m_LastActivity = DateTime.Now;
         }
 
         #region method Dispose

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 22 hits

📄 imapserver\New.LumiSoft.Net\Net_Utils.cs (line 513)

 				throw new Exception("Illegal hex data, hex data must be in two bytes pairs, for example: 0F,FF,A3,... .");
 			}
 
▶			MemoryStream retVal = new MemoryStream(hexData.Length / 2);
 			// Loop hex value pairs
 			for(int i=0;i<hexData.Length;i+=2){
 				byte[] hexPairInDecimal = new byte[2];

💬 The operands in the divisive expression hexData.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 imapserver\New.LumiSoft.Net\Net_Utils.cs (line 824)

 			}
 			//---------------------------------------------//
 
▶			byte[] decodedDataBuffer  = new byte[((base64Data.Length * 6) / 8) + 4];
 			int    decodedBytesCount  = 0;
 			int    nByteInBase64Block = 0;
 			byte[] decodedBlock       = new byte[3];

💬 The operands in the divisive expression (base64Data.Length * 6) / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 imapserver\New.LumiSoft.Net\MIME\MIME_h_Collection.cs (line 197)

                 throw new ArgumentNullException("field");
             }
 
▶            return m_pFields.Contains(field);
         }
 
         #endregion

💬 Type MIME_h is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 imapserver\New.LumiSoft.Net\MIME\MIME_EntityCollection.cs (line 122)

                 throw new ArgumentNullException("entity");
             }
 
▶            return m_pCollection.Contains(entity);
         }
 
         #endregion

💬 Type MIME_Entity is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS013 Rethrow exception without losing stacktrace 18 hits

📄 imapserver\New.LumiSoft.Net\IO\SmartStream.cs (line 3211)

                     }
                     catch(LineSizeExceededException lx){
                         if(m_SizeExceededAction == SizeExceededAction.ThrowException){
▶                            throw lx;
                         }
                         m_pException = new LineSizeExceededException();
                         storedCount = 32000 - 2;

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 imapserver\New.LumiSoft.Net\TCP\TCP_Client.cs (line 113)

                 }
                 catch(Exception x){
                     if(this.IsConnected){
▶                        throw x;
                     }
                     // Connect failed for specified IP address, if there are some more IPs left, try next, otherwise forward exception.
                     else if(i == (ips.Length - 1)){

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 Rnwood.Smtp4dev\WindowsServiceManager.cs (line 72)

         private const int SERVICE_CONFIG_DESCRIPTION = 1;
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
▶        private struct ServiceDescription
         {
             public string lpDescription;
         }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ServiceDescription. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Rnwood.Smtp4dev\WindowsServiceManager.cs (line 72)

         private const int SERVICE_CONFIG_DESCRIPTION = 1;
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
▶        private struct ServiceDescription
         {
             public string lpDescription;
         }

SS019 Switch is missing default label 4 hits

📄 Rnwood.Smtp4dev\Server\Imap\ImapSearchTranslator.cs (line 19)

 
         public Expression<Func<DbModel.Message, bool>> Translate(IMAP_Search_Key criteria)
         {
▶            return criteria switch
             {
                 IMAP_Search_Key_Group group => HandleGroup(group),
                 IMAP_Search_Key_Unseen unseen => HandleUnseen(unseen),

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Rnwood.Smtp4dev\Server\Imap\ImapSearchTranslator.cs (line 19)

 
         public Expression<Func<DbModel.Message, bool>> Translate(IMAP_Search_Key criteria)
         {
▶            return criteria switch
             {
                 IMAP_Search_Key_Group group => HandleGroup(group),
                 IMAP_Search_Key_Unseen unseen => HandleUnseen(unseen),

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 1656 hits

📄 imapserver\New.LumiSoft.Net\IO\Base64Stream.cs (line 410)

         { 
             get{
                 if(m_IsDisposed){
▶                    throw new ObjectDisposedException("SmartStream");
                 }
 
                 return true;

💬 An exception is thrown from the getter of property CanRead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 imapserver\New.LumiSoft.Net\IO\Base64Stream.cs (line 425)

         { 
             get{
                 if(m_IsDisposed){
▶                    throw new ObjectDisposedException("SmartStream");
                 }
 
                 return false;

💬 An exception is thrown from the getter of property CanSeek (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 68 hits

📄 smtpserver\Rnwood.SmtpServer\Verbs\DataVerb.cs (line 63)

                     if (!firstLine)
                     {
                         messageSize += CRLF_BYTES.Length;
▶                        messageStream.Write(CRLF_BYTES, 0, CRLF_BYTES.Length);
                     }
 
                     messageSize += data.Length;

💬 Async overload available for Stream.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 smtpserver\Rnwood.SmtpServer\Verbs\DataVerb.cs (line 67)

                     }
 
                     messageSize += data.Length;
▶                    messageStream.Write(data, 0, data.Length);
                 }
                 else
                 {

💬 Async overload available for Stream.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 16 hits

📄 Rnwood.Smtp4dev\Server\Smtp4devServer.cs (line 220)

 
             using var scope = serviceScopeFactory.CreateScope();
             var mimeProcessingService = scope.ServiceProvider.GetService<MimeProcessingService>();
▶            Message message = new MessageConverter(mimeProcessingService).ConvertAsync(await e.Connection.CurrentMessage.ToMessage(), e.Connection.CurrentMessage.Recipients.ToArray()).Result;
 
             var apiMessage = new ApiModel.Message(message);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Rnwood.Smtp4dev\Server\ImapServer.cs (line 147)

 
             if (index == 1)
             {
▶                log.Error(errorTask.Result.Exception, "IMAP server failed to start. Port: {port}, BindAddress: {bindAddress}, ExceptionType: {exceptionType}",
                     serverOptions.CurrentValue.ImapPort, serverOptions.CurrentValue.BindAddress ?? "Any", 
                     errorTask.Result.Exception.GetType().Name);
             }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 Rnwood.Smtp4dev\Controllers\UseEtagFilterAttribute.cs (line 14)

 
 namespace Rnwood.Smtp4dev.Controllers
 {
▶    public class UseEtagFilterAttribute : Attribute, IActionFilter
     {
         public UseEtagFilterAttribute()
         {

💬 UseEtagFilterAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Rnwood.Smtp4dev\Controllers\UseEtagFilterAttribute.cs (line 14)

 
 namespace Rnwood.Smtp4dev.Controllers
 {
▶    public class UseEtagFilterAttribute : Attribute, IActionFilter
     {
         public UseEtagFilterAttribute()
         {

💬 UseEtagFilterAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 12 hits

📄 imapserver\New.LumiSoft.Net\MIME\MIME_Entity.cs (line 38)

         /// </summary>
         public void Dispose()
         {
▶            lock(this){
                 if(m_IsDisposed){
                     return;
                 }

📄 imapserver\New.LumiSoft.Net\TCP\TCP_Client.cs (line 48)

         /// </summary>
         public override void Dispose()
         {
▶            lock(this){
                 if(m_IsDisposed){
                     return;
                 }

SS049 Comparing strings without StringComparison 330 hits

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest.cs (line 111)

                 string   name       = name_value[0].Trim();
 
                 if(name_value.Length == 2){
▶                    if(name.ToLower() == "realm"){
                         m_Realm = TextUtils.UnQuoteString(name_value[1]);
                     }
                     else if(name.ToLower() == "nonce"){

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest.cs (line 114)

                     if(name.ToLower() == "realm"){
                         m_Realm = TextUtils.UnQuoteString(name_value[1]);
                     }
▶                    else if(name.ToLower() == "nonce"){
                         m_Nonce = TextUtils.UnQuoteString(name_value[1]);
                     }
                     // RFC bug ?: RFC 2831. digest-uri = "digest-uri" "=" <"> digest-uri-value <">

SS051 Locking on mutable reference 336 hits

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest_NonceManager.cs (line 130)

         /// <returns>Returns true if nonce exists in active nonces collection, otherwise returns false.</returns>
         public bool NonceExists(string nonce)
         {
▶            lock(m_pNonces){
                 foreach(NonceEntry e in m_pNonces){
                     if(e.Nonce == nonce){
                         return true;

💬 A lock was obtained on m_pNonces but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest_NonceManager.cs (line 151)

         /// <param name="nonce">Nonce to remove.</param>
         public void RemoveNonce(string nonce)
         {
▶            lock(m_pNonces){
                 for(int i=0;i<m_pNonces.Count;i++){
                     if(m_pNonces[i].Nonce == nonce){
                         m_pNonces.RemoveAt(i);

SS057 Collection manipulated during traversal 24 hits

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest_NonceManager.cs (line 154)

             lock(m_pNonces){
                 for(int i=0;i<m_pNonces.Count;i++){
                     if(m_pNonces[i].Nonce == nonce){
▶                        m_pNonces.RemoveAt(i);
                         i--;
                     }
                 }

📄 imapserver\New.LumiSoft.Net\AUTH\Auth_HttpDigest_NonceManager.cs (line 175)

                 for(int i=0;i<m_pNonces.Count;i++){
                     // Nonce expired, remove it.
                     if(m_pNonces[i].CreateTime.AddSeconds(m_ExpireTime) > DateTime.Now){
▶                        m_pNonces.RemoveAt(i);
                         i--;
                     }
                 }

SS058 String concatenated in a loop 6 hits

📄 imapserver\New.LumiSoft.Net\MIME\MIME_Utils.cs (line 540)

 						// see if multi line value. See commnt above.
 						line = r.ReadLine();
 						while(line != null && (line.StartsWith("\t") || line.StartsWith(" "))){
▶							fieldValue += line;
 							line = r.ReadLine();
 						}
 

📄 imapserver\New.LumiSoft.Net\MIME\MIME_Utils.cs (line 540)

 						// see if multi line value. See commnt above.
 						line = r.ReadLine();
 						while(line != null && (line.StartsWith("\t") || line.StartsWith(" "))){
▶							fieldValue += line;
 							line = r.ReadLine();
 						}
 

SS059 IAsyncDisposable not disposed asynchronously 38 hits

📄 smtpserver\Rnwood.SmtpServer\FileSession.cs (line 40)

     /// <inheritdoc />
     public override async Task AppendLineToSessionLog(string text)
     {
▶        using (StreamWriter writer = file.AppendText())
         {
             await writer.WriteLineAsync(text).ConfigureAwait(false);
         }

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 smtpserver\Rnwood.SmtpServer\Verbs\DataVerb.cs (line 41)

 
         long messageSize = 0;
 
▶        using (Stream messageStream = await connection.CurrentMessage.WriteData().ConfigureAwait(false))
         {
             bool firstLine = true;

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 466 hits

📄 smtpserver\Rnwood.SmtpServer\SmtpStreamReader.cs (line 22)

     private readonly Encoding fallbackEncoding;
     private readonly bool leaveOpen;
     private readonly List<byte> lineBytes = new(32 * 1024);
▶    private readonly Stream stream;
     private readonly UTF8Encoding utf8Encoding = new(false, true);
     private int bufferLen;
     private int bufferPos;

💬 Disposable field stream in type SmtpStreamReader is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 smtpserver\Rnwood.SmtpServer\MemoryMessage.cs (line 71)

     /// <summary>
     ///     Gets the Session message was received on.
     /// </summary>
▶    public ISession Session { get; internal set; }
 
     /// <summary>
     ///     Gets a value indicating whether the current message contains bare line feeds.

💬 Disposable field Session in type MemoryMessage is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Masuit.Tools

3000 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 676 hits

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StringExtensions.cs (line 68)

         public static string CreateShortToken(this string str, byte chars = 36)
         {
             var nf = new NumberFormater(chars);
▶            return nf.ToString((DateTime.Now.Ticks - 630822816000000000) * 100 + Stopwatch.GetTimestamp() % 100);
         }
 
         /// <summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Masuit.Tools\Mvc\ActionResults\ResumeFileResult.cs (line 68)

         {
             response.AppendHeader(HttpHeaders.Etag, _etag);
             response.AppendHeader(HttpHeaders.LastModified, _lastModified);
▶            response.AppendHeader(HttpHeaders.Expires, DateTime.Now.ToString("R"));
             response.AppendHeader(HttpHeaders.AccessControlExposeHeaders, HttpHeaders.ContentDisposition);
 
             if (IsNotModified())

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 1022 hits

📄 Masuit.Tools.DigtalWatermarker\DigitalWatermarker.cs (line 42)

         Mat y = planes[0];
 
         // 保障处理区域为8的倍数
▶        int w = (y.Cols / BlockSize) * BlockSize;
         int h = (y.Rows / BlockSize) * BlockSize;
         var roi = new Rect(0, 0, w, h);
         Mat yRoi = new(y, roi);

💬 The operands in the divisive expression y.Cols / BlockSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Masuit.Tools.DigtalWatermarker\DigitalWatermarker.cs (line 43)

 
         // 保障处理区域为8的倍数
         int w = (y.Cols / BlockSize) * BlockSize;
▶        int h = (y.Rows / BlockSize) * BlockSize;
         var roi = new Rect(0, 0, w, h);
         Mat yRoi = new(y, roi);
 

💬 The operands in the divisive expression y.Rows / BlockSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 88 hits

📄 Masuit.Tools.Abstractions\Linq\LinqExtension.cs (line 109)

 
     protected override Expression VisitParameter(ParameterExpression node)
     {
▶        return Sub.TryGetValue(node, out var newValue) ? newValue : node;
     }
 }

💬 Type Expression is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Masuit.Tools.Abstractions\Linq\LinqExtension.cs (line 94)

         {
             Sub =
             {
▶                [right.Parameters[0]] = left.Parameters[0]
             }
         };
 

SS005 Equals() and GetHashCode() not implemented together 46 hits

📄 Masuit.Tools.Abstractions\DateTimeExt\ChineseCalendar.cs (line 13)

     /// <remarks>
     /// 本程序使用数据来源于网上的万年历查询，并综合了一些其它数据
     /// </remarks>
▶    public class ChineseCalendar
     {
         private class ChineseCalendarException(string msg) : Exception(msg);
 

💬 Equals() and GetHashcode() must be implemented together on ChineseCalendar (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 Masuit.Tools.Abstractions\Models\DateTimeRange.cs (line 11)

 /// <summary>
 /// 时间段
 /// </summary>
▶public class DateTimeRange : ITimePeriod
 {
     public DateTimeRange(DateTime? start, DateTime? end)
     {

💬 Equals() and GetHashcode() must be implemented together on DateTimeRange (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 116 hits

📄 Masuit.Tools\Mvc\Internal\ByteRange.cs (line 24)

         {
             unchecked
             {
▶                return (Start.GetHashCode() * 397) ^ End.GetHashCode();
             }
         }
     }

💬 GetHashCode() refers to mutable property Start (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Masuit.Tools\Mvc\Internal\ByteRange.cs (line 24)

         {
             unchecked
             {
▶                return (Start.GetHashCode() * 397) ^ End.GetHashCode();
             }
         }
     }

💬 GetHashCode() refers to mutable property End (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 112 hits

📄 Masuit.Tools.Abstractions\Media\BorderDetectionResult.cs (line 8)

 /// <summary>
 /// 边框检测结果（包含多层边框信息）
 /// </summary>
▶public struct BorderDetectionResult
 {
     private int CroppedBorderCount { get; set; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BorderDetectionResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Masuit.Tools.Abstractions\Media\CMYColor.cs (line 3)

 namespace Masuit.Tools.Media;
 
▶public struct CMYColor
 {
     public double C { get; }
     public double M { get; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CMYColor. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 30 hits

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StringExtensions.cs (line 684)

         public static bool IsExternalAddress(this string url)
         {
             var uri = new Uri(url);
▶            switch (uri.HostNameType)
             {
                 case UriHostNameType.Dns:
                     var ipHostEntry = Dns.GetHostEntry(uri.DnsSafeHost);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StringExtensions.cs (line 684)

         public static bool IsExternalAddress(this string url)
         {
             var uri = new Uri(url);
▶            switch (uri.HostNameType)
             {
                 case UriHostNameType.Dns:
                     var ipHostEntry = Dns.GetHostEntry(uri.DnsSafeHost);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 280 hits

📄 Masuit.Tools.Net45\Media\ImageUtilities.cs (line 754)

             int ow = originalImage.Width;
             int oh = originalImage.Height;
 
▶            switch (mode)
             {
                 case ThumbnailCutMode.Fixed: //指定高宽缩放（可能变形）
                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Masuit.Tools.Abstractions\Extensions\BaseType\ObjectExtensions.cs (line 437)

     public static T Merge<T>(this IEnumerable<T> objects) where T : class
     {
         var list = objects as List<T> ?? objects.ToList();
▶        switch (list.Count)
         {
             case 0:
                 return null;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 12 hits

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StreamExtensions.cs (line 251)

 #if NET5_0_OR_GREATER
                 await stream.DisposeAsync().ConfigureAwait(false);
 #else
▶            stream.Dispose();
 #endif
         }
 

💬 Async overload available for Stream.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StreamExtensions.cs (line 277)

 #if NET5_0_OR_GREATER
                 await stream.DisposeAsync().ConfigureAwait(false);
 #else
▶            stream.Dispose();
 #endif
         }
 

💬 Async overload available for Stream.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 236 hits

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StringExtensions.cs (line 350)

                         };
                     }
 
▶                    return t.Result;
                 }));
                 isMatch = task.Result.SelectMany(a => a).Any(ip => !ip.IsPrivateIP());
             }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Masuit.Tools.Abstractions\Extensions\BaseType\StringExtensions.cs (line 352)

 
                     return t.Result;
                 }));
▶                isMatch = task.Result.SelectMany(a => a).Any(ip => !ip.IsPrivateIP());
             }
 
             return (isMatch, match);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 184 hits

📄 Masuit.Tools.Abstractions\Files\IniFile\IniPropertyAttribute.cs (line 5)

 
 namespace Masuit.Tools.Files;
 
▶public class IniPropertyAttribute : Attribute
 {
     public string Name { get; set; }

💬 IniPropertyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Masuit.Tools.Abstractions\Validator\IsIPAddressAttribute.cs (line 8)

 /// <summary>
 /// 验证IPv4地址是否合法
 /// </summary>
▶public class IsIPAddressAttribute : ValidationAttribute
 {
     /// <summary>
     /// 验证IPv4地址是否合法

💬 IsIPAddressAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 96 hits

📄 Masuit.Tools.Abstractions\Net\MultiThreadDownloader.cs (line 73)

         {
             try
             {
▶                lock (this)
                 {
                     return PartialDownloaderList.Where(t => t != null).Sum(t => t.TotalBytesRead);
                 }

📄 Masuit.Tools.Abstractions\Net\MultiThreadDownloader.cs (line 226)

         var temp = new PartialDownloader(_url, TempFileDirectory, Guid.NewGuid().ToString(), from, to, true);
         temp.DownloadPartCompleted += temp_DownloadPartCompleted;
         temp.DownloadPartProgressChanged += temp_DownloadPartProgressChanged;
▶        lock (this)
         {
             PartialDownloaderList.Add(temp);
         }

SS058 String concatenated in a loop 48 hits

📄 Masuit.Tools.Abstractions\Strings\NumberFormater.cs (line 298)

             {
                 if (x[i] == '0')
                 {
▶                    ret = ToNum(x[i]) + ret;
                 }
                 else
                 {

📄 Masuit.Tools.Abstractions\Strings\NumberFormater.cs (line 302)

                 }
                 else
                 {
▶                    ret = ToNum(x[i]) + strArrayLevelNames[x.Length - 1 - i] + ret;
                 }
             }
 

SS059 IAsyncDisposable not disposed asynchronously 20 hits

📄 Masuit.Tools.Abstractions\Files\FileExt.cs (line 73)

             {
                 Directory.CreateDirectory(dir);
             }
▶            using var fs = new FileStream(filename, FileMode.Create, FileAccess.Write);
             var stream = new BufferedStream(ms, 1048576);
             await stream.CopyToAsync(fs);
             ms.Seek(0, SeekOrigin.Begin);

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Masuit.Tools.Abstractions\Files\IniFile\IniFile.cs (line 159)

     /// <returns></returns>
     public async Task SaveAsync()
     {
▶        using StreamWriter writer = new(_path, false, Encoding.UTF8);
         var firstLine = true;
         foreach (var section in _sections.Values.Where(section => section.Count > 0))
         {

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 34 hits

📄 Masuit.Tools.Abstractions\Models\Email.cs (line 60)

     /// </summary>
     public List<Attachment> Attachments { get; set; } = new List<Attachment>();
 
▶    private MailMessage _mailMessage;
 
     private MailMessage MailMessage => _mailMessage ?? GetClient();

💬 Disposable field _mailMessage in type Email is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Masuit.Tools.Abstractions\Files\FileDetector\AbstractCompoundFileDetailDetector.cs (line 893)

         private readonly int _sectorSize;
         private long _position;
         private readonly List<Sector> _sectorChain;
▶        private readonly Stream _stream;
         private readonly bool _isFatStream;
 
         public StreamView(List<Sector> sectorChain, int sectorSize, Stream stream)

💬 Disposable field _stream in type StreamView is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

better-genshin-impact

2852 total diagnostics across 22 rules

SS001 Async method with void return type 32 hits

📄 BetterGenshinImpact\Core\Script\WebView\RepoWebBridge.cs (line 55)

         }
     }
 
▶    public async void ImportUri(string url)
     {
         try
         {

💬 Method ImportUri is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 BetterGenshinImpact\ViewModel\Pages\MapPathingViewModel.cs (line 170)

     }
 
     [RelayCommand]
▶    public async void OnOpenSettings()
     {
         // var uiMessageBox = new Wpf.Ui.Controls.MessageBox
         // {

💬 Method OnOpenSettings is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 484 hits

📄 BetterGenshinImpact\Service\Notification\Model\BaseNotificationData.cs (line 30)

     /// 事件触发时间
     /// </summary>
     [JsonConverter(typeof(DateTimeJsonConverter))]
▶    public DateTime Timestamp { get; set; } = DateTime.Now;
 
     /// <summary>
     /// 事件触发时的截图

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 BetterGenshinImpact\GameTask\AutoFight\AutoFightTask.cs (line 43)

 
     private readonly BgiYoloPredictor _predictor;
 
▶    private DateTime _lastFightFlagTime = DateTime.Now; // 战斗标志最近一次出现的时间
 
     private readonly double _dpi = TaskContext.Instance().DpiScale;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 1834 hits

📄 BetterGenshinImpact\GameTask\Common\Map\Camera\CameraOrientationFromLimint.cs (line 20)

     private float[] alphaParams1 = { 18.632f, 20.157f, 24.093f, 34.617f, 38.566f, 41.94f, 47.654f, 51.087f, 58.561f, 63.925f, 67.759f, 71.77f, 75.214f };
     private int rLength = 60;
     private static int thetaLength = 360;
▶    private int peakWidth = thetaLength / 4;
     private int width = tplSize;
     private int height = tplSize;
     private Mat rotationRemapDataX;

💬 The operands in the divisive expression thetaLength / 4 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 BetterGenshinImpact\GameTask\Common\Map\MiniMap\CameraOrientationCalculator.cs (line 17)

     private const int ThetaLength = 360;
     private const int FLength = 256;
     private const int Scale = 2;
▶    private const int PeakWidth = ThetaLength / 4 * Scale + 1;
     private readonly Mat _rotationRemapDataX = new Mat();
     private readonly Mat _rotationRemapDataY = new Mat();
     private readonly Mat _alphaMask1Remap;

💬 The operands in the divisive expression ThetaLength / 4 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 44 hits

📄 BetterGenshinImpact\View\Behavior\AutoTranslateInterceptor.cs (line 533)

                     }
 
                     var map = GetOriginalValuesMap(obj);
▶                    if (map == null || !map.TryGetValue(property, out var original))
                     {
                         if (ContainsHan(value))
                         {

💬 Type DependencyProperty is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 BetterGenshinImpact\View\Behavior\AutoTranslateInterceptor.cs (line 538)

                         if (ContainsHan(value))
                         {
                             map = GetOrCreateOriginalValuesMap(obj);
▶                            map[property] = value;
                             original = value;
                         }
                         else

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 BetterGenshinImpact\View\Drawable\TextDrawable.cs (line 31)

 
     public override int GetHashCode()
     {
▶        return Point.GetHashCode();
     }
 
     public bool IsEmpty => Point is { X: 0, Y: 0 };

💬 GetHashCode() refers to mutable property Point (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 BetterGenshinImpact\View\Drawable\LineDrawable.cs (line 53)

 
     public override int GetHashCode()
     {
▶        return P1.GetHashCode() + P2.GetHashCode();
     }
 }

💬 GetHashCode() refers to mutable property P1 (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 30 hits

📄 Fischless.GameCapture\Graphics\Helpers\WinRT.cs (line 21)

 }
 
 [Guid("00000035-0000-0000-C000-000000000046")]
▶internal unsafe struct IActivationFactoryVftbl
 {
     public readonly IInspectable.Vftbl IInspectableVftbl;
     private readonly void* _ActivateInstance;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct IActivationFactoryVftbl. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 BetterGenshinImpact\Helpers\DpiHelper.cs (line 60)

 }
 
 [DebuggerDisplay("{ToString()}")]
▶public readonly struct DpiScaleF(float x = 1f, float y = 1f)
 {
     private readonly float x = x;
     public float X => x;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DpiScaleF. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 6 hits

📄 BetterGenshinImpact\Service\ApplicationHostService.cs (line 68)

                         Task.Run(() => ScriptRepoUpdater.Instance.AutoUpdateSubscribedScripts());
                 }
 
▶                switch (cmdOptions.Action)
                 {
                     case CommandLineAction.StartOneDragon:
                         // 通过命令行参数启动「一条龙」 => 跳转到一条龙配置页。

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 BetterGenshinImpact\Service\ApplicationHostService.cs (line 68)

                         Task.Run(() => ScriptRepoUpdater.Instance.AutoUpdateSubscribedScripts());
                 }
 
▶                switch (cmdOptions.Action)
                 {
                     case CommandLineAction.StartOneDragon:
                         // 通过命令行参数启动「一条龙」 => 跳转到一条龙配置页。

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 94 hits

📄 BetterGenshinImpact\Core\Recognition\OCR\Paddle\PaddleOcrService.cs (line 73)

                         var result = new List<string>();
                         while (parser.MoveNext())
                         {
▶                            switch (parser.Current)
                             {
                                 case SequenceEnd:
                                     return result;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 BetterGenshinImpact\View\Windows\ThemedMessageBox.xaml.cs (line 236)

 
     private static void SetButtons(ThemedMessageBox messageBox, MessageBoxButton button)
     {
▶        switch (button)
         {
             case MessageBoxButton.OK:
                 messageBox.PrimaryButton.Content = "确定";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 8 hits

📄 BetterGenshinImpact\GameTask\TaskTriggerDispatcher.cs (line 87)

 
                 if (_instance.GameCapture == null)
                 {
▶                    throw new Exception("截图器未初始化!");
                 }
 
                 return _instance.GameCapture;

💬 An exception is thrown from the getter of property GlobalGameCapture (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 BetterGenshinImpact\GameTask\TaskContext.cs (line 65)

             {
                 if (ConfigService.Config == null)
                 {
▶                    throw new Exception("Config未初始化");
                 }
 
                 return ConfigService.Config;

💬 An exception is thrown from the getter of property Config (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 24 hits

📄 BetterGenshinImpact\GameTask\AutoDomain\AutoDomainTask.cs (line 290)

                 else if ("无妄引咎密宫".Equals(_taskParam.DomainName))
                 {
                     Simulation.SendInput.SimulateAction(GIActions.MoveForward, KeyType.KeyDown);
▶                    Thread.Sleep(500);
                     Simulation.SendInput.SimulateAction(GIActions.MoveForward, KeyType.KeyUp);
 
                     menuFound = await NewRetry.WaitForElementAppear(

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 BetterGenshinImpact\ViewModel\Pages\HotKeyPageViewModel.cs (line 512)

 
                 if (GlobalKeyMouseRecord.Instance.Status == KeyMouseRecorderStatus.Stop)
                 {
▶                    Thread.Sleep(300); // 防止录进快捷键进去
                     await vm.OnStartRecord();
                 }
                 else

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 48 hits

📄 BetterGenshinImpact\Service\UpdateService.cs (line 314)

                 string md = $"# {name}{new string('\n', 2)}{body}";
 
                 md = WebUtility.HtmlEncode(md);
▶                string md2html = File.ReadAllText(Global.Absolute(@"Assets\Strings\md2html.html"), Encoding.UTF8);
                 var html = md2html.Replace("{{content}}", md);
 
                 return html;

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 BetterGenshinImpact\GameTask\AutoLeyLineOutcrop\AutoLeyLineOutcropTask.cs (line 746)

             throw new FileNotFoundException("LeyLineOutcropData.json 未找到", nodePath);
         }
 
▶        var raw = JsonSerializer.Deserialize<RawNodeData>(File.ReadAllText(nodePath))
                   ?? throw new Exception("节点数据解析失败");
         _nodeData = AdaptNodeData(raw);
         return _nodeData;

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 8 hits

📄 BetterGenshinImpact\GameTask\GetGridIcons\GridIconsAccuracyTestTask.cs (line 130)

                 }, ct);
 
                 await Task.WhenAll(task1, task2);
▶                (string?, int) result = task2.Result;
                 string? predName = result.Item1;
                 int predStarNum = result.Item2;
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 BetterGenshinImpact\GameTask\AutoFight\AutoFightSeek.cs (line 563)

                             Simulation.SendInput.SimulateAction(GIActions.NormalAttack);
                             using (var imageAfterBurst = CaptureToRectArea())
                             {
▶                                if (AvatarSkillAsync(Logger, guardianAvatar, true, 1, ct).Result 
                                     || !Bv.IsInMainUi(imageAfterBurst)) //Q技能CD（冷却检测）或者不在主界面（大招动画播放中）
                                 {
                                     guardianAvatar.IsBurstReady = false;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 4 hits

📄 BetterGenshinImpact\GameTask\AutoFishing\AutoFishingTask.cs (line 189)

                              ? [7]
                              : (param.FishingTimePolicy == FishingTimePolicy.Nighttime ? [19] : new int[] { 7, 19 }))
                 {
▶                    setTimeTask.Start(hour, 0, ct).Wait(ct);
                     tickARound();
                 }
             }

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 BetterGenshinImpact\GameTask\AutoFishing\AutoFishingTask.cs (line 189)

                              ? [7]
                              : (param.FishingTimePolicy == FishingTimePolicy.Nighttime ? [19] : new int[] { 7, 19 }))
                 {
▶                    setTimeTask.Start(hour, 0, ct).Wait(ct);
                     tickARound();
                 }
             }

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS041 Unnecessary enumerable materialization 8 hits

📄 BetterGenshinImpact\ViewModel\Pages\ScriptControlViewModel.cs (line 1094)

             // 如果启用排除已选择过的目录，先过滤掉这些目录
             if (excludeSelectedFolder ?? false)
             {
▶                List<string> skipFolderNames = SelectedScriptGroup?.Projects.ToList().Select(item => item.FolderName).Distinct().ToList() ?? [];
                 string jsonString = JsonSerializer.Serialize(nodes);
                 var copiedNodes = JsonSerializer.Deserialize<ObservableCollection<FileTreeNode<PathingTask>>>(jsonString);
                 if (copiedNodes != null)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 BetterGenshinImpact\ViewModel\Pages\ScriptControlViewModel.cs (line 2219)

         {
             //await StartGroups(selectedGroups);
             //taskProgress.Next
▶            var sg = ScriptGroups.ToList().Where(sg => taskProgress.ScriptGroupNames.Contains(sg.Name)).ToList();
             TaskProgressManager.GenerNextProjectInfo(taskProgress, sg);
             if (taskProgress.Next == null)
             {

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS046 Unbounded stackalloc 4 hits

📄 BetterGenshinImpact\GameTask\AutoPick\AutoPickTrigger.cs (line 486)

             return text;
 
         // 0. 首先替换相似的括号字符并删除换行符、空格，使用Span<char>进行原地替换以获得最佳性能
▶        Span<char> chars = stackalloc char[text.Length];
         text.AsSpan().CopyTo(chars);
 
         int writeIndex = 0;

📄 BetterGenshinImpact\GameTask\AutoPick\AutoPickTrigger.cs (line 486)

             return text;
 
         // 0. 首先替换相似的括号字符并删除换行符、空格，使用Span<char>进行原地替换以获得最佳性能
▶        Span<char> chars = stackalloc char[text.Length];
         text.AsSpan().CopyTo(chars);
 
         int writeIndex = 0;

SS048 Locking on discouraged object (string, Type, this) 16 hits

📄 BetterGenshinImpact\Model\MouseHook.cs (line 57)

     /// <param name="e"></param>
     private void RunAction(MouseEventExtArgs e)
     {
▶        lock (this)
         {
             while (IsPressed)
             {

📄 BetterGenshinImpact\Model\KeyboardHook.cs (line 64)

     /// <param name="e"></param>
     private void RunAction(KeyEventArgs e)
     {
▶        lock (this)
         {
             while (IsPressed && KeyPressedEvent != null)
             {

SS049 Comparing strings without StringComparison 4 hits

📄 BetterGenshinImpact\Helpers\MarkdownToFlowDocumentConverter.cs (line 282)

             indentLevel = indentString.Length / 2;
 
             // 判断任务是否已完成
▶            isCompleted = checkMark.ToLower() == "x";
 
             return true;
         }

📄 BetterGenshinImpact\Helpers\MarkdownToFlowDocumentConverter.cs (line 282)

             indentLevel = indentString.Length / 2;
 
             // 判断任务是否已完成
▶            isCompleted = checkMark.ToLower() == "x";
 
             return true;
         }

SS054 Newtonsoft.Json mixed with System.Text.Json 12 hits

📄 BetterGenshinImpact\Service\UpdateService.cs (line 210)

             {
                 // 即使是403、400也尝试读取响应体
                 var content = await response.Content.ReadAsStringAsync();
▶                result = JsonConvert.DeserializeObject<LatestResponse>(content);
             }
 
             if (result != null)

💬 Attempting to deserialize an object annotated with System.Text.Json.Serialization through Newtonsoft.Json (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS054-NewtonsoftMixedWithSystemTextJson.md)

📄 BetterGenshinImpact\Service\UpdateService.cs (line 210)

             {
                 // 即使是403、400也尝试读取响应体
                 var content = await response.Content.ReadAsStringAsync();
▶                result = JsonConvert.DeserializeObject<LatestResponse>(content);
             }
 
             if (result != null)

SS057 Collection manipulated during traversal 4 hits

📄 BetterGenshinImpact\ViewModel\Pages\ScriptControlViewModel.cs (line 2103)

                 {
                     if (item.Item1 == group.Name)
                     {
▶                        nextScheduledTask.Remove(item);
                         break;
                     }
                 }

📄 BetterGenshinImpact\ViewModel\Pages\ScriptControlViewModel.cs (line 2103)

                 {
                     if (item.Item1 == group.Name)
                     {
▶                        nextScheduledTask.Remove(item);
                         break;
                     }
                 }

SS058 String concatenated in a loop 36 hits

📄 BetterGenshinImpact\Helpers\StringUtils.cs (line 66)

         {
             if (str[i] >= 0x4E00 && str[i] <= 0x9FA5) //汉字
             {
▶                chineseString += str[i];
             }
         }
 

📄 BetterGenshinImpact\GameTask\AutoFight\Script\CombatScriptParser.cs (line 216)

                 // 括号被逗号分隔，需要合并
                 while (j < commandArray.Length)
                 {
▶                    command += "," + commandArray[j];
                     if (command.Count("(".Contains) > 1)
                     {
                         Logger.LogError("战斗脚本格式错误，指令 {Cmd} 括号无法配对", command);

SS059 IAsyncDisposable not disposed asynchronously 16 hits

📄 BetterGenshinImpact\Service\Notifier\TelegramNotifier.cs (line 145)

     private async Task SendImageMessageAsync(Image<Rgb24> image, string? caption)
     {
         var endpoint = $"{TelegramApiBaseUrl}{TelegramBotToken}/sendPhoto";
▶        using var memoryStream = new MemoryStream();
         await image.SaveAsPngAsync(memoryStream);
         memoryStream.Position = 0;
 

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 BetterGenshinImpact\Service\Notifier\EmailNotifier.cs (line 68)

             // 添加图片附件（如果存在）
             if (content.Screenshot != null)
             {
▶                using var memoryStream = new MemoryStream();
                 // 将图片保存到内存流
                 await content.Screenshot.SaveAsJpegAsync(memoryStream);
                 memoryStream.Position = 0; // 重置流位置

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 124 hits

📄 Fischless.HotkeyCapture\HotkeyHook.cs (line 10)

 {
     public event EventHandler<KeyPressedEventArgs>? KeyPressed = null;
 
▶    private readonly Window window = new();
     private int currentId;
 
     private class Window : NativeWindow, IDisposable

💬 Disposable field window in type HotkeyHook is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Fischless.GameCapture\Graphics\GraphicsCapture.cs (line 19)

 {
     private nint _hWnd;
 
▶    private Direct3D11CaptureFramePool? _captureFramePool;
     private GraphicsCaptureItem? _captureItem;
 
     private GraphicsCaptureSession? _captureSession;

💬 Disposable field _captureFramePool in type GraphicsCapture is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

TensorFlow.NET

2662 total diagnostics across 14 rules

SS003 Integer divided by integer causing implicit rounding 58 hits

📄 tools\Tensorflow.Redist.NativeLibrarySplitter\Program.cs (line 18)

     using (FileStream input = new FileStream(filename, FileMode.Open, FileAccess.Read))
     {
         long filesize = new FileInfo(filename).Length; // 获取文件大小
▶        long fragmentSize = (long)(filesize / count + 1); // 计算每个分片的大小
 
         byte[] buffer = new byte[fragmentSize]; // 设置缓冲区大小
         int bytesRead; // 存储读取长度

💬 The operands in the divisive expression filesize / count are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\TensorFlowNET.Core\Gradients\math_grad.cs (line 464)

             {
                 var input_size = np.prod(input_shape);
                 var output_size = np.prod(output_shape);
▶                var factor = (int)input_size / Math.Max((int)output_size, 1);
                 factor_tensor = constant_op.constant(factor, dtype: sum_grad.dtype);
             }
             else

💬 The operands in the divisive expression (int)input_size / Math.Max((int)output_size, 1) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 464 hits

📄 src\TensorFlowNET.Core\Checkpoint\TrackableView.cs (line 61)

         Queue<Trackable> to_visit = new();
         to_visit.Enqueue(Root);
         Dictionary<Trackable, IEnumerable<TrackableReference>> node_paths = new();
▶        node_paths[this.Root] = new List<TrackableReference>();
         while (!to_visit.empty())
         {
             var current_trackable = to_visit.Dequeue();

💬 Type Trackable is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\TensorFlowNET.Core\Checkpoint\TrackableView.cs (line 70)

             foreach (var name in children_dict.Keys)
             {
                 var dependency = children_dict[name];
▶                if (!node_paths.ContainsKey(dependency))
                 {
                     var list = new List<TrackableReference>(node_paths[current_trackable]);
                     list.Add(new TrackableReference(name, dependency));

SS005 Equals() and GetHashCode() not implemented together 12 hits

📄 src\TensorFlowNET.Core\NumPy\NDArray.Creation.cs (line 9)

 
 namespace Tensorflow.NumPy
 {
▶    public partial class NDArray
     {
         protected NDArray() { }
         public NDArray(bool value) : base(value) => NewEagerTensorHandle(); 

💬 Equals() and GetHashcode() must be implemented together on NDArray (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\TensorFlowNET.Core\NumPy\Shape.cs (line 29)

 namespace Tensorflow
 {
     [JsonConverter(typeof(CustomizedShapeJsonConverter))]
▶    public class Shape : INestStructure<long>
     {
         public int ndim => _dims == null ? -1 : _dims.Length;
         long[] _dims;

💬 Equals() and GetHashcode() must be implemented together on Shape (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS013 Rethrow exception without losing stacktrace 1816 hits

📄 src\TensorFlowNET.Core\Operations\gen_resource_variable_ops.cs (line 36)

             }
             catch (NotOkStatusException ex)
             {
▶                throw ex;
             }
             catch (Exception)
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 src\TensorFlowNET.Core\Operations\gen_list_ops.cs (line 41)

             }
             catch (NotOkStatusException ex)
             {
▶                throw ex;
             }
             catch (Exception)
             {

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 52 hits

📄 src\TensorFlowNET.Core\Operations\TF_AttrMetadata.cs (line 3)

 namespace Tensorflow
 {
▶    public struct TF_AttrMetadata
     {
         public byte is_list;
         public long list_size;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TF_AttrMetadata. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\TensorFlowNET.Core\Operations\TF_Input.cs (line 7)

 namespace Tensorflow
 {
     [StructLayout(LayoutKind.Sequential)]
▶    public struct TF_Input
     {
         public TF_Input(IntPtr oper, int index)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TF_Input. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 src\TensorFlowNET.Core\Util\ProtoUtils.cs (line 11)

     {
         public static object GetSingleAttrValue(AttrValue value, AttrValue.ValueOneofCase valueCase)
         {
▶            return valueCase switch
             {
                 AttrValue.ValueOneofCase.S => value.S.ToStringUtf8(),
                 AttrValue.ValueOneofCase.I => value.I,

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\TensorFlowNET.Core\Operations\ControlFlows\ControlFlowContext.cs (line 296)

         /// <returns>A ControlFlowContext subclass</returns>
         protected ControlFlowContext from_control_flow_context_def(ControlFlowContextDef context_def, string import_scope = "")
         {
▶            switch (context_def.CtxtCase)
             {
                 case CtxtOneofCase.CondCtxt:
                     return new CondContext().from_proto(context_def.CondCtxt, import_scope: import_scope);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 40 hits

📄 src\TensorFlowNET.Core\Binding.Util.cs (line 144)

 
         public static int len(object a)
         {
▶            switch (a)
             {
                 case Tensor tensor:
                     return (int)tensor.shape[0];

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\TensorFlowNET.Core\Variables\RefVariable.cs (line 271)

         private Operation _safe_initial_value_from_op(string name, Operation op, Dictionary<string, Operation> op_cache)
         {
             var op_type = op.node_def.Op;
▶            switch (op_type)
             {
                 case "IsVariableInitialized":
                 case "VarIsInitializedOp":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 36 hits

📄 src\TensorFlowNET.Core\Checkpoint\TrackableView.cs (line 45)

             }
             else
             {
▶                throw new InvalidDataException(
                     "Cannot get the object from the weak reference. Please consider if a null reference is passed to the constructor.");
             }
         }

💬 An exception is thrown from the getter of property Root (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\TensorFlowNET.Core\Contexts\Context.Device.cs (line 52)

             {
                 if(_context_devices is null)
                 {
▶                    throw new AssertionError("Context must be initialized first.");
                 }
                 return _context_devices;
             }

💬 An exception is thrown from the getter of property Devices (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 32 hits

📄 src\TensorFlowNET.Core\Data\Utils.cs (line 30)

 
             if (showProgressInConsole)
             {
▶                Binding.tf_output_redirect.WriteLine($"Downloading {fileName}");
             }
 
             if (File.Exists(fileSaveTo))

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\TensorFlowNET.Core\Data\Utils.cs (line 37)

             {
                 if (showProgressInConsole)
                 {
▶                    Binding.tf_output_redirect.WriteLine($"The file {fileName} already exists");
                 }
 
                 return;

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 24 hits

📄 src\TensorFlowNET.Core\Tensors\c_api.tensor.cs (line 239)

         /// internal static void MyFreeFunc (IntPtr data, IntPtr length){..}
         /// </code>
         /// </remarks>
▶        public sealed class MonoPInvokeCallbackAttribute : Attribute
         {
             /// <summary>
             /// Use this constructor to annotate the type of the callback function that 

💬 MonoPInvokeCallbackAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\TensorFlowNET.Core\NumPy\AutoNumPyAttribute.cs (line 11)

 namespace Tensorflow.NumPy
 {
     [DebuggerStepThrough]
▶    public sealed class AutoNumPyAttribute : OnMethodBoundaryAspect
     {
         bool _changedMode = false;
         bool _locked = false;

💬 AutoNumPyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 4 hits

📄 src\TensorFlowNET.Core\Functions\monomorphic_function.cs (line 241)

 
         private (EagerDefinedFunction, ConcreteFunction) _construct_forward_backward(int num_doutputs)
         {
▶            var trainable_outputs = _func_graph.Outputs.Take(num_doutputs).Where(x => backprop_util.IsTrainable(x));
 
             List<TensorSpec> signature = new();
             foreach(var t in trainable_outputs)

📄 src\TensorFlowNET.Core\Functions\monomorphic_function.cs (line 241)

 
         private (EagerDefinedFunction, ConcreteFunction) _construct_forward_backward(int num_doutputs)
         {
▶            var trainable_outputs = _func_graph.Outputs.Take(num_doutputs).Where(x => backprop_util.IsTrainable(x));
 
             List<TensorSpec> signature = new();
             foreach(var t in trainable_outputs)

SS051 Locking on mutable reference 8 hits

📄 src\TensorFlowNET.Core\Framework\c_api_util.cs (line 60)

                 return;
             }
 
▶            lock (locker)
             {
                 if (!File.Exists(file))
                 {

💬 A lock was obtained on locker but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\TensorFlowNET.Core\Framework\op_def_registry.py.cs (line 30)

         {
             if (_registered_ops.Count == 0)
             {
▶                lock (_registered_ops)
                 {
                     // double validation to avoid multi-thread executing
                     if (_registered_ops.Count > 0)

💬 A lock was obtained on _registered_ops but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\TensorFlowNET.Core\Data\Utils.cs (line 75)

                     Binding.tf_output_redirect.WriteLine($"The file {destFileName} already exists");
             }
 
▶            using (GZipStream unzipStream = new GZipStream(File.OpenRead(zipFile), CompressionMode.Decompress))
             {
                 using (var destStream = File.Create(destFilePath))
                 {

💬 GZipStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\TensorFlowNET.Core\Data\Utils.cs (line 77)

 
             using (GZipStream unzipStream = new GZipStream(File.OpenRead(zipFile), CompressionMode.Decompress))
             {
▶                using (var destStream = File.Create(destFilePath))
                 {
                     await unzipStream.CopyToAsync(destStream).ConfigureAwait(false);
                     await destStream.FlushAsync().ConfigureAwait(false);

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 104 hits

📄 src\TensorFlowNET.Core\Graphs\FuncGraph.cs (line 23)

 /// </summary>
 public class FuncGraph : Graph, IDisposable
 {
▶    internal SafeFuncGraphHandle _func_graph_handle;
     internal HashSet<Tensor> _resource_tensor_inputs;
     internal HashSet<WeakReference<IVariableV1>> _watched_variables;
     internal IEnumerable<WeakReference<IVariableV1>> _weak_variables;

💬 Disposable field _func_graph_handle in type FuncGraph is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\TensorFlowNET.Core\Graphs\FuncGraph.cs (line 31)

     internal Dictionary<long, string> _output_names;
     public string FuncName => _graph_key;
 
▶    public Tensors Inputs { get; set; } = new Tensors();
     public Tensors Outputs { get; set; } = new Tensors();
     public Tensors FlatStructuredOutputs
     {

💬 Disposable field Inputs in type FuncGraph is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

ant-design-blazor

2544 total diagnostics across 18 rules

SS001 Async method with void return type 48 hits

📄 components\carousel\Carousel.razor.cs (line 284)

             InvokeStateHasChanged();
         }
 
▶        private async void AutoplaySlick(object state)
         {
             var index = IndexOfSlick(ActiveSlick) + 1;
             if (index == _slicks.Count)

💬 Method AutoplaySlick is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 components\core\JsInterop\DomEventListener.cs (line 257)

         {
             AddShared<JsonElement>("window", "resize", AsyncCallback, false);
 
▶            async void AsyncCallback(JsonElement _) => await callback.Invoke([new ResizeObserverEntry()]);
         }
         else
         {

💬 Method AsyncCallback is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 344 hits

📄 components\calendar\Calendar.razor.cs (line 24)

     [Documentation(DocumentationCategory.Components, DocumentationType.DataDisplay, "https://gw.alipayobjects.com/zos/antfincdn/dPQmLq08DI/Calendar.svg", Columns = 1, Title = "Calendar", SubTitle = "日历")]
     public partial class Calendar : AntDomComponentBase, IDatePicker
     {
▶        DateTime IDatePicker.CurrentDate { get; set; } = DateTime.Now;
         DateTime? IDatePicker.HoverDateTime { get; set; }
 
         /// <summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 components\calendar\Calendar.razor.cs (line 32)

         /// </summary>
         /// <default value="DateTime.Now"/>
         [Parameter]
▶        public DateTime Value { get; set; } = DateTime.Now;
 
         private DateTime _defaultValue;
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 112 hits

📄 components\statistic\CountDown.razor.cs (line 53)

         [Parameter]
         public int RefreshInterval { get; set; } = REFRESH_INTERVAL;
 
▶        private const int REFRESH_INTERVAL = 1000 / 10;
 
         private TimeSpan _countDown = TimeSpan.Zero;
         private CancellationTokenSource _cts = new();

💬 The operands in the divisive expression 1000 / 10 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 components\carousel\Carousel.razor.cs (line 303)

 
             if (index == 0 && Effect == CarouselEffect.ScrollX)
             {
▶                await Task.Delay((int)Autoplay.TotalMilliseconds / 2);
             }
 
             await InvokeAsync(() => StateHasChanged());

💬 The operands in the divisive expression (int)Autoplay.TotalMilliseconds / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 180 hits

📄 components\auto-complete\AutoComplete.razor.cs (line 360)

 
         void IAutoCompleteRef.RemoveOption(AutoCompleteOption option)
         {
▶            if (AutoCompleteOptions?.Contains(option) == true)
                 AutoCompleteOptions?.Remove(option);
         }
 

💬 Type AutoCompleteOption is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 components\breadcrumb\Breadcrumb.razor.cs (line 78)

 
         internal void AddOption(BreadcrumbOption option)
         {
▶            if (!_existingOptions.Contains(option))
             {
                 _existingOptions.Add(option);
             }

💬 Type BreadcrumbOption is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 94 hits

📄 components\core\Helpers\MemberPath\PathHelper.cs (line 670)

 
             public override int GetHashCode()
             {
▶                return HashCode.Combine(Path, ItemType, ParamType, ValueType);
             }
 
             public static bool operator ==(PathSetConfig x, PathSetConfig y)

💬 GetHashCode() refers to mutable field ItemType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 components\core\Helpers\MemberPath\PathHelper.cs (line 670)

 
             public override int GetHashCode()
             {
▶                return HashCode.Combine(Path, ItemType, ParamType, ValueType);
             }
 
             public static bool operator ==(PathSetConfig x, PathSetConfig y)

💬 GetHashCode() refers to mutable field ParamType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 126 hits

📄 components\core\Helpers\MemberPath\PathHelper.cs (line 586)

 
         #endregion
 
▶        private readonly struct PathGetConfig
         {
             public readonly string Path;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PathGetConfig. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 components\core\Helpers\MemberPath\PathHelper.cs (line 695)

             public int GetHashCode(PathSetConfig obj) => obj.GetHashCode();
         }
 
▶        public readonly struct PathGetExpression
         {
             public readonly Expression Body;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PathGetExpression. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 84 hits

📄 components\core\CssSizeLength.cs (line 121)

 
             _value = ResolveBySuffix(value, out unit);
 
▶            switch (unit)
             {
                 case CssSizeLengthUnit.NoUnit:
                     _parsed = false;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 components\core\Helpers\DateHelper.cs (line 186)

 
         public static DateTime FormatDateByPicker(DateTime dateTime, DatePickerType picker)
         {
▶            switch (picker)
             {
                 case DatePickerType.Date: return dateTime.Date;
                 case DatePickerType.Year: return new DateTime(dateTime.Year, 1, 1);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 160 hits

📄 components\carousel\Carousel.razor.cs (line 121)

         [JSInvokable]
         public void HandleSwipe(string direction)
         {
▶            switch (direction)
             {
                 case "left":
                     if (IsHorizontal) Next();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 components\core\CssSizeLength.cs (line 121)

 
             _value = ResolveBySuffix(value, out unit);
 
▶            switch (unit)
             {
                 case CssSizeLengthUnit.NoUnit:
                     _parsed = false;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 14 hits

📄 components\slider\Slider.razor.cs (line 217)

                     }
                     else
                     {
▶                        throw new ArgumentOutOfRangeException($"Type argument of Slider should be one of {doubleType}, {tupleDoubleType}");
                     }
                 }
                 return _range.Value;

💬 An exception is thrown from the getter of property Range (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 components\slider\Slider.razor.cs (line 217)

                     }
                     else
                     {
▶                        throw new ArgumentOutOfRangeException($"Type argument of Slider should be one of {doubleType}, {tupleDoubleType}");
                     }
                 }
                 return _range.Value;

💬 An exception is thrown from the getter of property Range (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 108 hits

📄 site\AntDesign.Docs.MCP\Cli\DemoCommand.cs (line 66)

             }
             catch (Exception ex)
             {
▶                Console.Error.WriteLine($"Failed to load demos: {ex.Message}");
                 return 1;
             }
         }

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 site\AntDesign.Docs.MCP\Services\DemoService.cs (line 39)

             }
             catch (Exception ex)
             {
▶                Console.Error.WriteLine($"Warning: failed to download demos from {RemoteUrl}: {ex.Message}");
             }
         }
 

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 24 hits

📄 components\modal\confirmDialog\ModalServiceForConfirm.cs (line 123)

             }
 
             return await confirmRef.TaskCompletionSource.Task
▶                .ContinueWith(t => t.Result == ConfirmResult.OK, TaskScheduler.Default);
         }
 
         /// <summary>

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 components\modal\confirmDialog\ModalServiceForConfirm.cs (line 123)

             }
 
             return await confirmRef.TaskCompletionSource.Task
▶                .ContinueWith(t => t.Result == ConfirmResult.OK, TaskScheduler.Default);
         }
 
         /// <summary>

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 8 hits

📄 site\AntDesign.Docs.Server\Program.cs (line 28)

         var host = request.Host.ToUriComponent();
         var scheme = request.Scheme;
         var baseAddress = $"{scheme}://{host}";
▶        return new HttpClient(customHandler) { BaseAddress = new Uri(baseAddress) };
     }
     else
     {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 site\AntDesign.Docs.Server\Program.cs (line 32)

     }
     else
     {
▶        return new HttpClient(customHandler) { BaseAddress = new Uri("http://0.0.0.0:8181") };
     }
 });
 

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS044 Attribute must specify [AttributeUsage] 164 hits

📄 components\tabs\Reuse\ReuseTabsPageAttribute.cs (line 12)

     /// <summary>
     /// Attribute for ReuseTabsPage, used to set the page title and other properties.
     /// </summary>
▶    public class ReuseTabsPageAttribute : Attribute
     {
         /// <summary>
         /// Specifies the title of the tab.

💬 ReuseTabsPageAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 components\tabs\Reuse\ReuseTabsPageTitleAttribute.cs (line 9)

 
 namespace AntDesign
 {
▶    public class ReuseTabsPageTitleAttribute : Attribute
     {
         public string Title { get; set; }
 

💬 ReuseTabsPageTitleAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 22 hits

📄 site\AntDesign.Docs\Pages\Components.razor.cs (line 124)

                 if (!onInitialize)
                 {
                     var menus = await DemoService.GetMenuAsync();
▶                    var current = menus.FirstOrDefault(x => x.Url == fullPageName.ToLowerInvariant());
                     var subPath = current.Children[0].Type == "menuItem" ? current.Children[0].Url : current.Children[0].Children[0].Url;
                     if (current != null)
                     {

📄 site\AntDesign.Docs\Services\DemoService.cs (line 93)

         {
             var items = Array.Empty<DemoMenuItem>();
 
▶            if (type.ToLowerInvariant() == "docs")
             {
                 items = (await _cache.GetDocMenuAsync(CurrentLanguage)).OrderBy(x => x.Order).ToArray();
                 currentTitle = $"docs/{currentTitle}";

SS055 Multiple OrderBy() calls instead of ThenBy() 28 hits

📄 components\select\SelectBase.razor.cs (line 444)

 
                 if (SortByGroup == SortDirection.Ascending && SortByLabel == SortDirection.Descending)
                 {
▶                    return selectOption.OrderBy(g => g.GroupName).OrderByDescending(l => l.Label);
                 }
 
                 if (SortByGroup == SortDirection.Descending && SortByLabel == SortDirection.Ascending)

💬 Successive OrderBy() calls will maintain only the last specified sort order (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS055-MultipleOrderByCalls.md)

📄 components\select\SelectBase.razor.cs (line 454)

 
                 if (SortByGroup == SortDirection.Descending && SortByLabel == SortDirection.Descending)
                 {
▶                    return selectOption.OrderByDescending(g => g.GroupName).OrderByDescending(l => l.Label);
                 }
 
                 return selectOption;

💬 Successive OrderBy() calls will maintain only the last specified sort order (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS055-MultipleOrderByCalls.md)

SS058 String concatenated in a loop 26 hits

📄 components\date-picker\locale\FormatAnalyzer.cs (line 99)

                     }
                     else
                     {
▶                        _separators[^1] += format[i];
                     }
                     isLastSeparator = true;
                 }

📄 components\date-picker\locale\FormatAnalyzer.cs (line 99)

                     }
                     else
                     {
▶                        _separators[^1] += format[i];
                     }
                     isLastSeparator = true;
                 }

SS059 IAsyncDisposable not disposed asynchronously 14 hits

📄 site\AntDesign.Docs\Services\CompilerService.cs (line 196)

                 throw new ApplicationException(string.Join(Environment.NewLine, errors.Select(e => e.GetMessage())));
             }
 
▶            using var stream = new MemoryStream();
 
             var emitResult = _compilation.Emit(stream);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 site\AntDesign.Docs\Services\CompilerService.cs (line 196)

                 throw new ApplicationException(string.Join(Environment.NewLine, errors.Select(e => e.GetMessage())));
             }
 
▶            using var stream = new MemoryStream();
 
             var emitResult = _compilation.Emit(stream);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 988 hits

📄 components\select\internal\SelectContent.razor.cs (line 90)

         private int _currentItemCount;
         private Guid _internalId = Guid.NewGuid();
         private bool _refocus;
▶        private Timer _debounceTimer;
         private string _inputString;
         private bool _firstRender;
 

💬 Disposable field _debounceTimer in type SelectContent is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 components\calendar\internal\CalendarPanelChooser.razor.cs (line 13)

     public partial class CalendarPanelChooser : AntDomComponentBase
     {
         [Parameter]
▶        public Calendar Calendar { get; set; }
 
         [Parameter]
         public Action<DateTime, int> OnSelect { get; set; }

💬 Disposable field Calendar in type CalendarPanelChooser is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

ILRuntime

2420 total diagnostics across 18 rules

SS001 Async method with void return type 12 hits

📄 TestCases\CLRBindingTest.cs (line 135)

             }
 
 
▶            public async void Test4()
             {
                 await Test.Instance.Test3<Test2>();
             }

💬 Method Test4 is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 TestCases\AsyncAwaitTest.cs (line 140)

             return lines;
         }*/
 
▶        public async static void TestRun5()
         {
             Console.WriteLine("TestConditionAwait Start ");
             await DoConditionAwait();

💬 Method TestRun5 is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 Debugging\SharedDebuggerCommon\DebuggedProcess.cs (line 83)

         {
             socket.Send(DebugMessageType.CSAttach, new byte[0], 0);
             waitingAttach = true;
▶            DateTime now = DateTime.Now;
             while (waitingAttach)
             {
                 System.Threading.Thread.Sleep(1);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Debugging\SharedDebuggerCommon\DebuggedProcess.cs (line 87)

             while (waitingAttach)
             {
                 System.Threading.Thread.Sleep(1);
▶                if ((DateTime.Now - now).TotalSeconds >= 30 || !Connected)
                 {
                     return false;
                 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 102 hits

📄 ILRuntime\Runtime\Intepreter\RegisterVM\JITCompiler.cs (line 1063)

                         }
                         else
                         {
▶                            bool codeSizeOK = ilm.IsRegisterBodyReady ? ilm.BodyRegister.Length <= Optimizer.MaximalInlineInstructionCount / 2 : def.Body.Instructions.Count <= Optimizer.MaximalInlineInstructionCount;
                             if(codeSizeOK)
                             {
                                 canInline = true;

💬 The operands in the divisive expression Optimizer.MaximalInlineInstructionCount / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 ILRuntime\Runtime\Intepreter\RegisterVM\JITCompiler.cs (line 575)

                         bool needInline = canInline && !hasConstrained;
                         if (needInline)
                         {
▶                            if (toInline.BodyRegister.Length > Optimizer.MaximalInlineInstructionCount / 2)
                                 needInline = false;
                         }
                         if (!needInline)

SS004 Elementary methods of type in collection not overridden 364 hits

📄 ILRuntime\HybridPatch\AssemblyInjector.cs (line 88)

                 InjectPatchType();
                 foreach (var i in asmInfo.Types)
                 {
▶                    patchingSet.Add(i.Definition);
                 }
                 foreach (var i in asmInfo.Types)
                 {

💬 Type TypeReference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 ILRuntime\HybridPatch\ReflectionReferences.cs (line 259)

 
         public MethodReference GetReadObjectMethod(TypeReference type)
         {
▶            if (readObjCache.TryGetValue(type, out var res))
                 return res;
             res = readObjInfo.MakeGenericInstanceMethod(type);
             readObjCache[type] = res;

SS005 Equals() and GetHashCode() not implemented together 18 hits

📄 ILRuntime\CLR\Method\CLRMethod.cs (line 17)

 #endif
 namespace ILRuntime.CLR.Method
 {
▶    public sealed class CLRMethod : IMethod
     {
         MethodInfo def;
         ConstructorInfo cDef;

💬 Equals() and GetHashcode() must be implemented together on CLRMethod (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 ILRuntime\CLR\Method\ILMethod.cs (line 19)

 using System.Diagnostics;
 namespace ILRuntime.CLR.Method
 {
▶    public sealed class ILMethod : IMethod
     {
         OpCode[] body;
         OpCodeR[] bodyRegister;

💬 Equals() and GetHashcode() must be implemented together on ILMethod (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 98 hits

📄 ILRuntime\Reflection\ILRuntimeWrapperType.cs (line 172)

 
         public override int GetHashCode()
         {
▶            return type.GetHashCode();
         }
 
         public override string ToString()

💬 GetHashCode() refers to mutable field type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 ILRuntime\CLR\Method\CLRMethod.cs (line 461)

 
         public override int GetHashCode()
         {
▶            if (hashCode == -1)
                 hashCode = System.Threading.Interlocked.Add(ref instance_id, 1);
             return hashCode;
         }

💬 GetHashCode() refers to mutable field hashCode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 16 hits

📄 ILRuntime\Runtime\Debugger\DebugSocket.cs (line 93)

             catch (Exception ex)
             {
                 Close();
▶                throw ex;
             }
         }
 

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 ILRuntime\Runtime\Intepreter\ILIntepreter.cs (line 4746)

                         }
                         if (unhandledException)
                         {
▶                            throw ex;
                         }
 
                         unhandledException = true;

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS015 String placeholders in wrong order 168 hits

📄 ILRuntime\Runtime\CLRBinding\MethodBindingGenerator.cs (line 152)

                     {
                         if (i.DeclaringType != type)
                         {
▶                            sb.AppendLine(string.Format("            method = typeof({1}).GetMethod(\"{0}\", flag, null, args, null);", i.Name, i.DeclaringType.FullName));
                         }
                         else
                             sb.AppendLine(string.Format("            method = type.GetMethod(\"{0}\", flag, null, args, null);", i.Name));

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 ILRuntime\Runtime\CLRBinding\FieldBindingGenerator.cs (line 26)

                     continue;
                 if (i.DeclaringType != type)
                 {
▶                    sb.AppendLine(string.Format("            field = typeof({1}).GetField(\"{0}\", flag);", i.Name, i.DeclaringType.FullName));
                 }
                 else
                     sb.AppendLine(string.Format("            field = type.GetField(\"{0}\", flag);", i.Name));

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 218 hits

📄 ILRuntime\HybridPatch\InjectionContext.cs (line 8)

 
 namespace ILRuntime.Hybrid
 {
▶    internal struct TypeInjectionContext
     {
         public bool IsGenericType;
         public FieldDefinition ExtraFieldILType;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TypeInjectionContext. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ILRuntime\HybridPatch\InjectionContext.cs (line 26)

         public List<MethodRedirectionInjectionContext> MethodRedirections;
     }
 
▶    internal struct MethodRedirectionInjectionContext
     {
         public FieldDefinition ILMethod;
         public FieldReference ILMethodGenericInstance;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MethodRedirectionInjectionContext. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 564 hits

📄 ILRuntime\CLR\Method\CLRMethod.cs (line 362)

             {
                 var p = Minus(esp, i);
                 var val = i <= paramCount ? param[paramCount - i] : instance;
▶                switch (p->ObjectType)
                 {
                     case ObjectTypes.StackObjectReference:
                         {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 ILRuntime\CLR\Method\ILMethod.cs (line 506)

 
             foreach (var ins in body)
             {
▶                switch (ins.Code)
                 {
                     case OpCodeEnum.Call:
                     case OpCodeEnum.Newobj:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 596 hits

📄 ILRuntime\CLR\Method\CLRMethod.cs (line 362)

             {
                 var p = Minus(esp, i);
                 var val = i <= paramCount ? param[paramCount - i] : instance;
▶                switch (p->ObjectType)
                 {
                     case ObjectTypes.StackObjectReference:
                         {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 ILRuntime\CLR\Method\ILMethod.cs (line 506)

 
             foreach (var ins in body)
             {
▶                switch (ins.Code)
                 {
                     case OpCodeEnum.Call:
                     case OpCodeEnum.Newobj:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS044 Attribute must specify [AttributeUsage] 42 hits

📄 ILRuntime\Other\NeedAdaptorAttribute.cs (line 6)

     /// <summary>
     /// A Class Custom Attr, It tells the CodeGenerationTools :there is a class need to generate an adaptor for ILScript
     /// </summary>
▶    public class NeedAdaptorAttribute : System.Attribute
     {
 
     }

💬 NeedAdaptorAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 ILRuntime\HybridPatch\AssemblyPatch.cs (line 492)

         }
     }
 
▶    public class PatchableAssemblyAttribute : Attribute
     {
         public string Name { get; set; }
         public string AssemblyHash { get; set; }

💬 PatchableAssemblyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 ILRuntime\CLR\TypeSystem\CLRType.cs (line 957)

 
         public IType MakeGenericInstance(KeyValuePair<string, IType>[] genericArguments)
         {
▶            lock (this)
             {
                 if (genericInstances == null)
                     genericInstances = new List<CLRType>();

📄 ILRuntime\CLR\TypeSystem\CLRType.cs (line 957)

 
         public IType MakeGenericInstance(KeyValuePair<string, IType>[] genericArguments)
         {
▶            lock (this)
             {
                 if (genericInstances == null)
                     genericInstances = new List<CLRType>();

SS051 Locking on mutable reference 156 hits

📄 ILRuntime\Other\ThreadSafeDictionary.cs (line 39)

         {
             get
             {
▶                lock(dic)
                     return dic.Count;
             }
         }

💬 A lock was obtained on dic but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 ILRuntime\Other\ThreadSafeDictionary.cs (line 30)

 
             set
             {
▶               lock(dic)
                     dic[key] = value;
             }
         }

SS053 Pointless collection ToString() 2 hits

📄 TestCases\Test01.cs (line 458)

         public static void UnitTest_Generics3()
         {
             Console.WriteLine("UnitTest_Generics3");
▶            Console.WriteLine(new List<NestedTest>().ToString());
         }
 
         public static void UnitTest_Generics4()

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

📄 TestCases\Test01.cs (line 458)

         public static void UnitTest_Generics3()
         {
             Console.WriteLine("UnitTest_Generics3");
▶            Console.WriteLine(new List<NestedTest>().ToString());
         }
 
         public static void UnitTest_Generics4()

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

SS057 Collection manipulated during traversal 4 hits

📄 LitJson\JsonData.cs (line 502)

 
             for (int i = 0; i < object_list.Count; i++) {
                 if (object_list[i].Key == (string) key) {
▶                    object_list.RemoveAt (i);
                     break;
                 }
             }

📄 LitJson\JsonData.cs (line 502)

 
             for (int i = 0; i < object_list.Count; i++) {
                 if (object_list[i].Key == (string) key) {
▶                    object_list.RemoveAt (i);
                     break;
                 }
             }

SS058 String concatenated in a loop 32 hits

📄 ILRuntime\CLR\Method\CLRMethod.cs (line 439)

                 string argString = "";
                 for (int i = 0; i < genericArguments.Length; i++)
                 {
▶                    argString += genericArguments[i].TypeForCLR.FullName + ", ";
                 }
 
                 argString = argString.Substring(0, argString.Length - 2);

📄 ILRuntime\CLR\TypeSystem\CLRType.cs (line 994)

                     string argString = "";
                     for (int i = 0; i < args.Length; i++)
                     {
▶                        argString += args[i].FullName + ", ";
                     }
 
                     argString = argString.Substring(0, argString.Length - 2);

SS066 Disposable field is not disposed 16 hits

📄 ILRuntime\Runtime\Intepreter\RegisterVM\AsyncJITCompileWorker.cs (line 12)

 {
     class AsyncJITCompileWorker
     {
▶        AutoResetEvent evt = new AutoResetEvent(false);
         Queue<ILMethod> jobs = new Queue<ILMethod>();
         bool exit;
         Thread thread;

💬 Disposable field evt in type AsyncJITCompileWorker is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 ILRuntime\Runtime\Intepreter\RegisterVM\AsyncJITCompileWorker.cs (line 12)

 {
     class AsyncJITCompileWorker
     {
▶        AutoResetEvent evt = new AutoResetEvent(false);
         Queue<ILMethod> jobs = new Queue<ILMethod>();
         bool exit;
         Thread thread;

💬 Disposable field evt in type AsyncJITCompileWorker is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

OpenRA

2320 total diagnostics across 16 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 32 hits

📄 OpenRA.Game\Map\MapPreview.cs (line 458)

 				using (var dataStream = p.GetStream("map.png"))
 					newData.Preview = new Png(dataStream);
 
▶			newData.ModifiedDate = p.Name != null ? File.GetLastWriteTime(p.Name) : DateTime.Now;
 
 			// Assign the new data atomically
 			// Local maps have higher precedence than remote/generated maps,

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 OpenRA.Game\Server\Server.cs (line 306)

 
 			playerDatabase = modData.GetOrCreate<PlayerDatabase>();
 
▶			randomSeed = (int)DateTime.Now.ToBinary();
 
 			if (IsMultiplayer && settings.EnableGeoIP)
 				GeoIP.Initialize();

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 1242 hits

📄 OpenRA.Game\CVec.cs (line 33)

 		public static CVec operator -(CVec a, CVec b) { return new CVec(a.X - b.X, a.Y - b.Y); }
 		public static CVec operator *(int a, CVec b) { return new CVec(a * b.X, a * b.Y); }
 		public static CVec operator *(CVec b, int a) { return new CVec(a * b.X, a * b.Y); }
▶		public static CVec operator /(CVec a, int b) { return new CVec(a.X / b, a.Y / b); }
 
 		public static CVec operator -(CVec a) { return new CVec(-a.X, -a.Y); }
 

💬 The operands in the divisive expression a.X / b are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 OpenRA.Game\CVec.cs (line 33)

 		public static CVec operator -(CVec a, CVec b) { return new CVec(a.X - b.X, a.Y - b.Y); }
 		public static CVec operator *(int a, CVec b) { return new CVec(a * b.X, a * b.Y); }
 		public static CVec operator *(CVec b, int a) { return new CVec(a * b.X, a * b.Y); }
▶		public static CVec operator /(CVec a, int b) { return new CVec(a.X / b, a.Y / b); }
 
 		public static CVec operator -(CVec a) { return new CVec(-a.X, -a.Y); }
 

💬 The operands in the divisive expression a.Y / b are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 296 hits

📄 OpenRA.Game\GameInformation.cs (line 166)

 		/// <summary>Gets the player information for the specified runtime player instance.</summary>
 		public Player GetPlayer(OpenRA.Player runtimePlayer)
 		{
▶			playersByRuntime.TryGetValue(runtimePlayer, out var player);
 
 			return player;
 		}

💬 Type Player is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 OpenRA.Game\GameInformation.cs (line 159)

 				Fingerprint = client.Fingerprint
 			};
 
▶			playersByRuntime.Add(runtimePlayer, player);
 			Players.Add(player);
 		}
 

SS008 GetHashCode() refers to mutable or static member 8 hits

📄 OpenRA.Game\World.cs (line 643)

 		public static bool operator ==(TraitPair<T> me, TraitPair<T> other) { return me.Actor == other.Actor && Equals(me.Trait, other.Trait); }
 		public static bool operator !=(TraitPair<T> me, TraitPair<T> other) { return !(me == other); }
 
▶		public override int GetHashCode() { return Actor.GetHashCode() ^ Trait.GetHashCode(); }
 
 		public bool Equals(TraitPair<T> other) { return this == other; }
 		public override bool Equals(object obj) { return obj is TraitPair<T> pair && Equals(pair); }

💬 GetHashCode() refers to mutable field Actor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 OpenRA.Game\World.cs (line 643)

 		public static bool operator ==(TraitPair<T> me, TraitPair<T> other) { return me.Actor == other.Actor && Equals(me.Trait, other.Trait); }
 		public static bool operator !=(TraitPair<T> me, TraitPair<T> other) { return !(me == other); }
 
▶		public override int GetHashCode() { return Actor.GetHashCode() ^ Trait.GetHashCode(); }
 
 		public bool Equals(TraitPair<T> other) { return this == other; }
 		public override bool Equals(object obj) { return obj is TraitPair<T> pair && Equals(pair); }

💬 GetHashCode() refers to mutable field Trait (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 134 hits

📄 OpenRA.Game\Map\CellCoordsRegion.cs (line 18)

 
 namespace OpenRA
 {
▶	public readonly struct CellCoordsRegion : IEnumerable<CPos>
 	{
 		public struct CellCoordsEnumerator : IEnumerator<CPos>
 		{

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CellCoordsRegion. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 OpenRA.Game\Map\CellCoordsRegion.cs (line 20)

 {
 	public readonly struct CellCoordsRegion : IEnumerable<CPos>
 	{
▶		public struct CellCoordsEnumerator : IEnumerator<CPos>
 		{
 			readonly CellCoordsRegion r;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CellCoordsEnumerator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 30 hits

📄 OpenRA.Game\Network\Order.cs (line 118)

 						var target = Target.Invalid;
 						if (flags.HasField(OrderFields.Target))
 						{
▶							switch ((TargetType)r.ReadByte())
 							{
 								case TargetType.Actor:
 								{

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 OpenRA.Game\Network\Order.cs (line 395)

 					if (fields.HasField(OrderFields.Target))
 					{
 						w.Write((byte)targetState.Type);
▶						switch (targetState.Type)
 						{
 							case TargetType.Actor:
 								w.Write(UIntFromActor(targetState.Actor));

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 96 hits

📄 OpenRA.Game\GameInformation.cs (line 82)

 				{
 					var keyParts = node.Key.Split('@');
 
▶					switch (keyParts[0])
 					{
 						case "Root":
 							FieldLoader.Load(info, node.Value);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 OpenRA.Game\Network\Order.cs (line 118)

 						var target = Target.Invalid;
 						if (flags.HasField(OrderFields.Target))
 						{
▶							switch ((TargetType)r.ReadByte())
 							{
 								case TargetType.Actor:
 								{

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 2 hits

📄 OpenRA.Game\Traits\Target.cs (line 169)

 						return terrainCenterPosition;
 					case TargetType.Invalid:
 					default:
▶						throw new InvalidOperationException("Attempting to query the position of an invalid Target");
 				}
 			}
 		}

💬 An exception is thrown from the getter of property CenterPosition (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 OpenRA.Game\Traits\Target.cs (line 169)

 						return terrainCenterPosition;
 					case TargetType.Invalid:
 					default:
▶						throw new InvalidOperationException("Attempting to query the position of an invalid Target");
 				}
 			}
 		}

💬 An exception is thrown from the getter of property CenterPosition (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS025 Exception thrown from finally block 2 hits

📄 OpenRA.Game\Sync.cs (line 202)

 				// When the world is disposing all actors and effects have been removed
 				// So do not check the hash for a disposing world since it definitively has changed
 				if (unsyncCount == 0 && checkSyncHash && world != null && !world.Disposing && sync != world.SyncHash())
▶					throw new InvalidOperationException("RunUnsynced: sync-changing code may not run here");
 			}
 		}
 

💬 An exception is thrown from a finally block (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS025-ExceptionThrownFromFinallyBlock.md)

📄 OpenRA.Game\Sync.cs (line 202)

 				// When the world is disposing all actors and effects have been removed
 				// So do not check the hash for a disposing world since it definitively has changed
 				if (unsyncCount == 0 && checkSyncHash && world != null && !world.Disposing && sync != world.SyncHash())
▶					throw new InvalidOperationException("RunUnsynced: sync-changing code may not run here");
 			}
 		}
 

💬 An exception is thrown from a finally block (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS025-ExceptionThrownFromFinallyBlock.md)

SS041 Unnecessary enumerable materialization 36 hits

📄 OpenRA.Mods.Common\Traits\RevealsShroud.cs (line 47)

 		{
 			base.Created(self);
 
▶			rangeModifiers = self.TraitsImplementing<IRevealsShroudModifier>().ToArray().Select(x => x.GetRevealsShroudModifier());
 		}
 
 		protected override void AddCellsToPlayerShroud(Actor self, Player p, PPos[] uv)

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 OpenRA.Mods.Common\Activities\Attack.cs (line 56)

 			this.forceAttack = forceAttack;
 			ChildHasPriority = false;
 
▶			attackTraits = self.TraitsImplementing<AttackFrontal>().ToArray().Where(t => !t.IsTraitDisabled);
 			revealsShroud = self.TraitsImplementing<RevealsShroud>().ToArray();
 			facing = self.Trait<IFacing>();
 			positionable = self.Trait<IPositionable>();

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS046 Unbounded stackalloc 6 hits

📄 OpenRA.Game\CryptoUtil.cs (line 272)

 				return string.Empty;
 
 			// excessively avoid stack overflow if source is too large (considering that we're allocating a new string)
▶			var buffer = source.Length <= 256 ? stackalloc char[source.Length * 2] : new char[source.Length * 2];
 			return ToHexInternal(source, buffer, lowerCase);
 		}
 

📄 OpenRA.Mods.Common\FileFormats\WavReader.cs (line 145)

 				Span<int> predictor = stackalloc int[channels];
 				Span<int> index = stackalloc int[channels];
 
▶				Span<byte> channelData = stackalloc byte[channels * 4];
 				baseStream.ReadBytes(channelData);
 				var cd = 0;
 				for (var c = 0; c < channels; c++)

SS051 Locking on mutable reference 86 hits

📄 OpenRA.Game\Server\Server.cs (line 229)

 
 		void MapStatusChanged(string uid, Session.MapStatus status)
 		{
▶			lock (LobbyInfo)
 			{
 				if (LobbyInfo.GlobalSettings.Map == uid)
 					LobbyInfo.GlobalSettings.MapStatus = status;

💬 A lock was obtained on LobbyInfo but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 OpenRA.Game\Server\Server.cs (line 1277)

 
 		public void SyncLobbyInfo()
 		{
▶			lock (LobbyInfo)
 			{
 				if (State == ServerState.WaitingPlayers) // Don't do this while the game is running, it breaks things!
 					DispatchServerOrdersToClients(Order.FromTargetString("SyncInfo", LobbyInfo.Serialize(), true));

SS055 Multiple OrderBy() calls instead of ThenBy() 2 hits

📄 OpenRA.Mods.Common\Traits\Player\BulkProductionQueue.cs (line 145)

 			// Some units may request a specific production type, which is ignored if the AllTech cheat is enabled
 			var type = developerMode.AllTech ? Info.Type : (bi.BuildAtProductionType ?? Info.Type);
 
▶			var producers = self.World.ActorsWithTrait<Production>()
 				.Where(x => x.Actor.Owner == self.Owner
 					&& !x.Trait.IsTraitDisabled
 					&& x.Trait.Info.Produces.Contains(type))

💬 Successive OrderBy() calls will maintain only the last specified sort order (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS055-MultipleOrderByCalls.md)

📄 OpenRA.Mods.Common\Traits\Player\BulkProductionQueue.cs (line 145)

 			// Some units may request a specific production type, which is ignored if the AllTech cheat is enabled
 			var type = developerMode.AllTech ? Info.Type : (bi.BuildAtProductionType ?? Info.Type);
 
▶			var producers = self.World.ActorsWithTrait<Production>()
 				.Where(x => x.Actor.Owner == self.Owner
 					&& !x.Trait.IsTraitDisabled
 					&& x.Trait.Info.Produces.Contains(type))

💬 Successive OrderBy() calls will maintain only the last specified sort order (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS055-MultipleOrderByCalls.md)

SS057 Collection manipulated during traversal 10 hits

📄 OpenRA.Game\Scripting\ScriptObjectWrapper.cs (line 69)

 			// NOTE: In newer versions of .NET modifying the collection by calling Remove while iterating over it is valid
 			foreach (var m in members)
 				if (targetType == m.Value.Target.GetType())
▶					members.Remove(m.Key);
 		}
 
 		public bool ContainsKey(string key) { return members.ContainsKey(key); }

📄 OpenRA.Game\Server\Server.cs (line 1097)

 						foreach (var c in LobbyInfo.Clients)
 						{
 							if (c.Bot != null)
▶								LobbyInfo.Clients.Remove(c);
 							else
 								c.Slot = null;
 						}

SS058 String concatenated in a loop 32 hits

📄 OpenRA.Game\GameRules\ActorInfo.cs (line 151)

 
 				exceptionString += "Missing:\n";
 				foreach (var m in missing)
▶					exceptionString += m + " \n";
 
 				exceptionString += "Unresolved:\n";
 				foreach (var u in unresolved)

📄 OpenRA.Game\GameRules\ActorInfo.cs (line 159)

 					var deps = u.Dependencies.Where(d => !resolved.Exists(r => r.Type == d));
 					var optDeps = u.OptionalDependencies.Where(d => !resolved.Exists(r => r.Type == d));
 					var allDeps = string.Join(", ", deps.Select(o => o.ToString()).Concat(optDeps.Select(o => $"[{o}]")));
▶					exceptionString += $"{u.Type}: {{ {allDeps} }}\n";
 				}
 
 				throw new YamlException(exceptionString);

SS066 Disposable field is not disposed 306 hits

📄 OpenRA.Game\World.cs (line 37)

 		readonly List<IEffect> effects = [];
 		readonly List<IEffect> unpartitionedEffects = [];
 		readonly List<ISync> syncedEffects = [];
▶		readonly ModData modData;
 		readonly GameSettings gameSettings;
 
 		readonly Queue<Action<World>> frameEndActions = [];

💬 Disposable field modData in type World is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 OpenRA.Game\World.cs (line 137)

 			renderPlayer = LocalPlayer;
 		}
 
▶		public readonly Actor WorldActor;
 
 		public readonly Map Map;

💬 Disposable field WorldActor in type World is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Lean

2106 total diagnostics across 19 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 22 hits

📄 Logging\QueueLogHandler.cs (line 72)

             OnLogEvent(log);
 
             Console.ForegroundColor = ConsoleColor.Red;
▶            _error.WriteLine(DateTime.Now.ToString(DateFormat, CultureInfo.InvariantCulture) + " Error:: " + text);
             Console.ResetColor();
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Logging\FunctionalLogHandler.cs (line 61)

         {
             if (_error != null)
             {
▶                _error(DateTime.Now.ToString(DateFormat, CultureInfo.InvariantCulture) + " ERROR " + text);
             }
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 52 hits

📄 Common\Algorithm\Framework\Alphas\Insight.cs (line 556)

             barSize = barSize == Resolution.Tick ? Resolution.Second : barSize;
             // remap hours to minutes to avoid complications w/ stepping through, for example 9->10 is an hour step but market opens at 9:30
             barSize = barSize == Resolution.Hour ? Resolution.Minute : barSize;
▶            var barCount = (int)(period.Ticks / barSize.ToTimeSpan().Ticks);
             var closeTimeUtc = ComputeCloseTime(exchangeHours, generatedTimeUtc, barSize, barCount);
             if (closeTimeUtc == generatedTimeUtc)
             {

💬 The operands in the divisive expression period.Ticks / barSize.ToTimeSpan().Ticks are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Common\Algorithm\Framework\Alphas\Insight.cs (line 578)

                 if (delta != TimeSpan.Zero)
                 {
                     // continue stepping forward using minute resolution for the remainder
▶                    barCount = (int) (delta.Ticks / Time.OneMinute.Ticks);
                     if (barCount > 0)
                     {
                         closeTimeUtc = ComputeCloseTime(exchangeHours, closeTimeUtc, Resolution.Minute, barCount);

💬 The operands in the divisive expression delta.Ticks / Time.OneMinute.Ticks are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 28 hits

📄 Common\Algorithm\Framework\Alphas\InsightCollection.cs (line 103)

             lock(_insights)
             {
                 return _insights.TryGetValue(item.Symbol, out var symbolInsights)
▶                    && symbolInsights.Contains(item);
             }
         }
 

💬 Type Insight is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Common\CapacityEstimate.cs (line 106)

             }
 
             symbolCapacity.OnOrderEvent(orderEvent);
▶            if (_monitoredSymbolCapacitySet.Contains(symbolCapacity))
             {
                 return;
             }

💬 Type SymbolCapacity is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 22 hits

📄 Common\Data\Channel.cs (line 100)

             unchecked
             {
                 int hash = (int)2166136261;
▶                hash = (hash * 16777619) ^ Name.GetHashCode();
                 hash = (hash * 16777619) ^ Symbol.GetHashCode();
                 return hash;
             }

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Common\Data\Channel.cs (line 101)

             {
                 int hash = (int)2166136261;
                 hash = (hash * 16777619) ^ Name.GetHashCode();
▶                hash = (hash * 16777619) ^ Symbol.GetHashCode();
                 return hash;
             }
         }

💬 GetHashCode() refers to mutable property Symbol (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 Common\Data\Auxiliary\SymbolDateRange.cs (line 24)

     /// Represents security identifier within a date range.
     /// </summary>
 #pragma warning disable CA1815 // Override equals and operator equals on value types
▶    public readonly struct SymbolDateRange
     {
         /// <summary>
         /// Represents a unique security identifier.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SymbolDateRange. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Common\Data\Auxiliary\TickerDateRange.cs (line 25)

     /// Represents stock data for a specific ticker within a date range.
     /// </summary>
 #pragma warning disable CA1815 // Override equals and operator equals on value types
▶    public readonly struct TickerDateRange
     {
         /// <summary>
         /// Ticker simple name of stock

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TickerDateRange. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 82 hits

📄 Common\Brokerages\FTXBrokerageModel.cs (line 138)

                     stopPrice = (order as StopLimitOrder)?.StopPrice;
                 }
 
▶                switch (order.Direction)
                 {
                     case OrderDirection.Sell:
                         if (stopPrice > security.BidPrice)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Common\Brokerages\DefaultBrokerageModel.cs (line 295)

         {
             if (AccountType == AccountType.Cash)
             {
▶                switch (security.Type)
                 {
                     case SecurityType.Equity:
                         return new DelayedSettlementModel(Equity.DefaultSettlementDays, Equity.DefaultSettlementTime);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 114 hits

📄 Common\Api\Nodes.cs (line 214)

         {
             string result = "";
 
▶            switch (Target)
             {
                 case NodeType.Backtest:
                     result += "B";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Common\Algorithm\Framework\Portfolio\SignalExports\Collective2SignalExport.cs (line 486)

         {
             if (symbol.SecurityType.IsOption())
             {
▶                switch (symbol.ID.OptionRight)
                 {
                     case OptionRight.Put:
                         return 0;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 24 hits

📄 Common\Indicators\RollingWindow.cs (line 150)

 
                     if (_samples <= _size)
                     {
▶                        throw new InvalidOperationException(Messages.RollingWindow.NoItemsRemovedYet);
                     }
                     return _mostRecentlyRemoved;
                 }

💬 An exception is thrown from the getter of property MostRecentlyRemoved (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Common\SecurityIdentifier.cs (line 145)

             {
                 if (_underlying == null)
                 {
▶                    throw new InvalidOperationException(Messages.SecurityIdentifier.NoUnderlyingForIdentifier);
                 }
                 return _underlying;
             }

💬 An exception is thrown from the getter of property Underlying (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 4 hits

📄 Compression\Compression.cs (line 335)

             foreach (var kvp in data)
             {
                 var entry = archive.CreateEntry(kvp.Value, compressionLevel.Value);
▶                using var entryStream = entry.Open();
                 await entryStream.WriteAsync(kvp.Key).ConfigureAwait(false);
             }
         }

💬 Async overload available for ZipArchiveEntry.Open (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Compression\Compression.cs (line 379)

                     existingEntry?.Delete();
                 }
                 var entry = archive.CreateEntry(kvp.Key, compressionLevel.Value);
▶                using var entryStream = entry.Open();
                 await kvp.Value.CopyToAsync(entryStream).ConfigureAwait(false);
             }
         }

💬 Async overload available for ZipArchiveEntry.Open (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 40 hits

📄 Common\Algorithm\Framework\Portfolio\SignalExports\VBaseSignalExport.cs (line 159)

                 };
                 request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", _apiKey);
 
▶                using var response = HttpClient.SendAsync(request).Result;
                 var body = response.Content.ReadAsStringAsync().Result;
                 if (!response.IsSuccessStatusCode)
                 {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Common\Algorithm\Framework\Portfolio\SignalExports\VBaseSignalExport.cs (line 160)

                 request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", _apiKey);
 
                 using var response = HttpClient.SendAsync(request).Result;
▶                var body = response.Content.ReadAsStringAsync().Result;
                 if (!response.IsSuccessStatusCode)
                 {
                     algorithm.Error($"vBase API returned {response.StatusCode}. Body: {body}");

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 Common\Scheduling\CompositeTimeRule.cs (line 72)

             {
                 // make unqiue times and order the events before yielding
                 var enumerable = new[] {date};
▶                var times = Rules.SelectMany(time => time.CreateUtcEventTimes(enumerable)).ToHashSet().OrderBy(x => x);
                 foreach (var time in times)
                 {
                     yield return time;

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Common\Scheduling\CompositeTimeRule.cs (line 72)

             {
                 // make unqiue times and order the events before yielding
                 var enumerable = new[] {date};
▶                var times = Rules.SelectMany(time => time.CreateUtcEventTimes(enumerable)).ToHashSet().OrderBy(x => x);
                 foreach (var time in times)
                 {
                     yield return time;

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS047 LINQ traversal before filter 2 hits

📄 Common\Securities\Future\FuturesExpiryUtilityFunctions.cs (line 268)

         {
 
             var daysInMonth = DateTime.DaysInMonth(time.Year, time.Month);
▶            return (from day in Enumerable.Range(1, daysInMonth).Reverse()
                     where new DateTime(time.Year, time.Month, day).DayOfWeek == dayOfWeek
                     select new DateTime(time.Year, time.Month, day)).First();
         }

📄 Common\Securities\Future\FuturesExpiryUtilityFunctions.cs (line 268)

         {
 
             var daysInMonth = DateTime.DaysInMonth(time.Year, time.Month);
▶            return (from day in Enumerable.Range(1, daysInMonth).Reverse()
                     where new DateTime(time.Year, time.Month, day).DayOfWeek == dayOfWeek
                     select new DateTime(time.Year, time.Month, day)).First();
         }

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 Common\Util\KeyStringSynchronizer.cs (line 58)

 
         private void ExecuteImplementation(string key, bool singleExecution, Action action)
         {
▶            lock (key)
             {
                 while (true)
                 {

💬 A lock was used on an object of type string which can lead to deadlocks. It is recommended to create a dedicated lock instance of type System.Object instead. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS048-LockingOnDiscouragedObject.md)

📄 Common\Util\KeyStringSynchronizer.cs (line 102)

                         }
                     }
 
▶                    lock (existingKey)
                     {
                         // if we are here the thread that had the lock finished
                         if (!singleExecution)

SS049 Comparing strings without StringComparison 2 hits

📄 Common\SymbolRepresentation.cs (line 441)

 
             optionTicker = match.Groups[1].Value;
             expiry = DateTime.ParseExact(match.Groups[2].Value, DateFormat.SixCharacter, null);
▶            right = match.Groups[3].Value.ToUpperInvariant() == "C" ? OptionRight.Call : OptionRight.Put;
             strike = Parse.Decimal(match.Groups[4].Value) / 1000m;
 
             return true;

📄 Common\SymbolRepresentation.cs (line 441)

 
             optionTicker = match.Groups[1].Value;
             expiry = DateTime.ParseExact(match.Groups[2].Value, DateFormat.SixCharacter, null);
▶            right = match.Groups[3].Value.ToUpperInvariant() == "C" ? OptionRight.Call : OptionRight.Put;
             strike = Parse.Decimal(match.Groups[4].Value) / 1000m;
 
             return true;

SS050 Parameter assigned in constructor 4 hits

📄 Common\Algorithm\Framework\Alphas\Insight.cs (line 629)

             {
                 if (period == TimeSpan.Zero)
                 {
▶                    period = Time.OneSecond;
                 }
 
                 Period = period;

💬 Suspicious assignment of parameter period in constructor of TimeSpanPeriodSpecification (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 Common\Securities\Option\StrategyMatcher\OptionStrategyMatcherOptions.cs (line 85)

         {
             if (maximumDuration == default(TimeSpan))
             {
▶                maximumDuration = Time.OneMinute;
             }
 
             if (definitionEnumerator == null)

💬 Suspicious assignment of parameter maximumDuration in constructor of OptionStrategyMatcherOptions (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS051 Locking on mutable reference 10 hits

📄 Common\Util\MemoizingEnumerable.cs (line 83)

                 while (i <= _buffer.Count)
                 {
                     // sync for multiple threads access to _enumerator and _buffer
▶                    lock (_buffer)
                     {
                         // check to see if we need to move next
                         if (_enumerator != null && i >= _buffer.Count)

💬 A lock was obtained on _buffer but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Common\Data\Auxiliary\LocalZipMapFileProvider.cs (line 86)

             MapFileResolver result;
             // we use a lock so that only 1 thread loads the map file resolver while the rest wait
             // else we could have multiple threads loading the map file resolver at the same time!
▶            lock (_lock)
             {
                 if (!_cache.TryGetValue(auxiliaryDataKey, out result))
                 {

💬 A lock was obtained on _lock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS058 String concatenated in a loop 12 hits

📄 Common\Algorithm\Framework\Portfolio\SignalExports\VBaseSignalExport.cs (line 132)

 
             foreach (var target in parameters.Targets)
             {
▶                csv += $"{target.Symbol.Value},{target.Quantity.ToStringInvariant()}\n";
             }
             return csv;
         }

📄 Common\Algorithm\Framework\Portfolio\SignalExports\NumeraiSignalExport.cs (line 156)

                     return false;
                 }
 
▶                positions += $"{parameters.Algorithm.Ticker(holding.Symbol)} {_numeraiMarketFormat[holding.Symbol.ID.Market]},{holding.Quantity.ToStringInvariant()}\n";
             }
 
             return true;

SS059 IAsyncDisposable not disposed asynchronously 12 hits

📄 Compression\Compression.cs (line 351)

         public static async Task ZipStreamsAsync(string target, IEnumerable<KeyValuePair<string, Stream>> data, ZipArchiveMode? mode = null,
             CompressionLevel? compressionLevel = null)
         {
▶            using var fileStream = mode == ZipArchiveMode.Update
                 ? new FileStream(target, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.None)
                 : new FileStream(target, FileMode.Create, FileAccess.Write, FileShare.None);
             await ZipStreamsAsync(fileStream, data, mode, compressionLevel).ConfigureAwait(false);

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Compression\Compression.cs (line 259)

             try
             {
                 //Read out the zipped data into a string, save in array:
▶                using (var zipStream = new ZipInputStream(stream))
                 {
                     while (true)
                     {

💬 ZipInputStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 1662 hits

📄 Logging\QueueLogHandler.cs (line 30)

     {
         private readonly ConcurrentQueue<LogEntry> _logs;
         private const string DateFormat = "yyyyMMdd HH:mm:ss";
▶        private readonly TextWriter _trace;
         private readonly TextWriter _error;
 
         /// <summary>

💬 Disposable field _trace in type QueueLogHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Logging\QueueLogHandler.cs (line 31)

         private readonly ConcurrentQueue<LogEntry> _logs;
         private const string DateFormat = "yyyyMMdd HH:mm:ss";
         private readonly TextWriter _trace;
▶        private readonly TextWriter _error;
 
         /// <summary>
         /// Public access to the queue for log processing.

💬 Disposable field _error in type QueueLogHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

xdm

2068 total diagnostics across 13 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 214 hits

📄 app\XDM\XDM.Core\Clients\Http\WinHttpSession.cs (line 27)

         private string? transferEncoding;
         private string? contentEncoding;
         private string? contentDispositionFileName;
▶        private DateTime lastModified = DateTime.Now;
         private long rangeStart = -1, rangeEnd = -1;
         private Dictionary<string, List<string>>? headers = null;
         private string? cookies = null;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 app\XDM\XDM.Core\TraceLog\Log.cs (line 26)

 
         public static void Debug(object obj, string message)
         {
▶            Trace.WriteLine($"[xdm-{DateTime.Now.ToLongTimeString()}] {message} : {obj}");
             //Trace.Flush();
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 122 hits

📄 app\XDM\XDM.Core\Util\FormattingHelper.cs (line 14)

         public static string ToHMS(long sec)
         {
             long hrs = 0, min = 0;
▶            hrs = sec / 3600;
             min = (sec % 3600) / 60;
             sec = sec % 60;
             var str = hrs.ToString().PadLeft(2, '0') + ":" + min.ToString().PadLeft(2, '0') + ":" + sec.ToString().PadLeft(2, '0');

💬 The operands in the divisive expression sec / 3600 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 app\XDM\XDM.Core\Util\FormattingHelper.cs (line 15)

         {
             long hrs = 0, min = 0;
             hrs = sec / 3600;
▶            min = (sec % 3600) / 60;
             sec = sec % 60;
             var str = hrs.ToString().PadLeft(2, '0') + ":" + min.ToString().PadLeft(2, '0') + ":" + sec.ToString().PadLeft(2, '0');
             return str;

💬 The operands in the divisive expression (sec % 3600) / 60 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 app\XDM\XDM.Core\Clients\Http\NetFxHttpClient.cs (line 48)

             {
                 if (sp != null)
                 {
▶                    servicePoints.Add(sp);
                 }
             }
             return http;

💬 Type ServicePoint is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 app\XDM\XDM.Core\Clients\Http\NetFxHttpClient.cs (line 148)

             var servicePoint = r.ServicePoint;
             if (servicePoint != null)
             {
▶                servicePoints.Add(servicePoint);
             }
             session.Response = response;
             return new HttpResponse { Session = session };

SS011 OnPropertyChanged without nameof operator 68 hits

📄 app\XDM\XDM.Wpf.UI\MainWindow\FinishedDownloadEntryWrapper.cs (line 25)

             set
             {
                 entry.Name = value;
▶                OnPropertyChanged("Name");
             }
         }
 

💬 OnPropertyChanged(Name) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

📄 app\XDM\XDM.Wpf.UI\MainWindow\FinishedDownloadEntryWrapper.cs (line 35)

             set
             {
                 entry.Size = value;
▶                OnPropertyChanged("Size");
             }
         }
 

💬 OnPropertyChanged(Size) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 172 hits

📄 app\XDM\XDM.Core\YDLWrapper\YtBinary.cs (line 7)

 
 namespace YDLWrapper
 {
▶    public struct YtBinary
     {
         public YtBinaryType BinaryType { get; set; }
         public string Path { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct YtBinary. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 app\XDM\XDM.Core\YDLWrapper\Structs.cs (line 75)

         }
     }
 
▶    public struct YDLPlaylist
     {
         public YDLFormatList[] Entries { get; set; }
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct YDLPlaylist. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 54 hits

📄 app\XDM\XDM.Core\Util\BrowserLauncher.cs (line 46)

 
         public static bool LaunchBrowser(Browser browser, string args, string? executableLocation)
         {
▶            switch (browser)
             {
                 case Browser.Chrome:
                     return LaunchGoogleChrome(args, executableLocation);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 app\XDM\XDM.Core\Util\PlatformHelper.cs (line 90)

         public static void OpenBrowser(string url)
         {
             var os = Environment.OSVersion.Platform;
▶            switch (os)
             {
                 case PlatformID.Win32NT:
                     var psiShellEx = new ProcessStartInfo

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 90 hits

📄 app\XDM\XDM.Core\Util\BrowserLauncher.cs (line 46)

 
         public static bool LaunchBrowser(Browser browser, string args, string? executableLocation)
         {
▶            switch (browser)
             {
                 case Browser.Chrome:
                     return LaunchGoogleChrome(args, executableLocation);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 app\XDM\XDM.Core\ApplicationCore.cs (line 656)

         public string? GetPrimaryUrl(DownloadItemBase entry)
         {
             if (entry == null) return null;
▶            switch (entry.DownloadType)
             {
                 case "Http":
                     var h1 = RequestDataIO.LoadSingleSourceHTTPDownloadInfo(entry.Id);// LoadInfo<SingleSourceHTTPDownloadInfo>(entry.Id);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 42 hits

📄 app\XDM\XDM.Core\ApplicationContext.cs (line 31)

             {
                 if (!s_Init)
                 {
▶                    throw new Exception("ApplicationContext is not initialized...");
                 }
                 return s_ApplicationCore!;
             }

💬 An exception is thrown from the getter of property CoreService (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 app\XDM\XDM.Core\ApplicationContext.cs (line 43)

             {
                 if (!s_Init)
                 {
▶                    throw new Exception("ApplicationContext is not initialized...");
                 }
                 return s_IApplication!;
             }

💬 An exception is thrown from the getter of property Application (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS034 Accessing Task.Result without await 4 hits

📄 app\XDM\XDM.Core\Clients\Http\DotNetHttpSession.cs (line 68)

 
         public Stream GetResponseStream()
         {
▶            return Response!.Content.ReadAsStreamAsync(this.CancellationToken).Result;
         }
 
         public string? ReadAsString(CancelFlag cancellationToken)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 app\XDM\XDM.Core\Clients\Http\DotNetHttpSession.cs (line 73)

 
         public string? ReadAsString(CancelFlag cancellationToken)
         {
▶            return Response?.Content.ReadAsStringAsync(this.CancellationToken).Result;
         }
 
         public void EnsureSuccessStatusCode()

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS048 Locking on discouraged object (string, Type, this) 196 hits

📄 app\XDM\XDM.Core\Clients\Http\WinHttpSession.cs (line 130)

 
         public void Close()
         {
▶            lock (this)
             {
                 this.RequestHandle.Close();
                 this.ConnectHandle.Close();

📄 app\XDM\XDM.Core\BrowserMonitoring\VideoTracker.cs (line 132)

 
         public List<MediaInfo> GetVideoList()
         {
▶            lock (this)
             {
                 var list = new List<MediaInfo>();
                 foreach (var e in ytVideoList)

SS049 Comparing strings without StringComparison 12 hits

📄 app\XDM\XDM.Core\UI\LinkRefreshDialogUIController.cs (line 79)

         private static string GetReferer(Dictionary<string, List<string>> headers)
         {
             return headers?.Where(
▶                header => header.Key.ToLowerInvariant() == "referer")
                 .FirstOrDefault().Value?.FirstOrDefault();
         }
 

📄 app\XDM\XDM.Core\BrowserMonitoring\VideoUrlHelper.cs (line 838)

                 foreach (var header in message.RequestHeaders)
                 {
                     headers[header.Key] = header.Value;
▶                    if (header.Key.ToLowerInvariant() == "accept")
                     {
                         acceptHeaderAdded = true;
                     }

SS051 Locking on mutable reference 132 hits

📄 app\XDM\XDM.Core\Clients\Http\NetFxHttpClient.cs (line 44)

 
             http.ConnectionGroupName = this.connectionGroupName;
             var sp = http.ServicePoint;
▶            lock (servicePoints)
             {
                 if (sp != null)
                 {

💬 A lock was obtained on servicePoints but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 app\XDM\XDM.Core\Clients\Http\WinHttpResponseStream.cs (line 37)

 
         public override int Read(byte[] buffer, int offset, int count)
         {
▶            lock (hRequest)
             {
                 var pData = Marshal.AllocHGlobal(count);
                 try

💬 A lock was obtained on hRequest but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS066 Disposable field is not disposed 950 hits

📄 app\XDM\XDM.WinForms.IntegrationUI\Form1.cs (line 17)

 {
     public partial class Form1 : Form
     {
▶        private PrivateFontCollection fc;
         private string folderPath;
         private int index;
         private string browser;

💬 Disposable field fc in type Form1 is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 app\XDM\XDM.Core\Scheduler.cs (line 12)

 {
     public class Scheduler : IDisposable
     {
▶        private Timer? timer;
         private HashSet<string> activeSchedules;
         //private Action callback;
 

💬 Disposable field timer in type Scheduler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

StockSharp

2048 total diagnostics across 18 rules

SS001 Async method with void return type 2 hits

📄 Connectors\Bittrex\Native\PusherClient.cs (line 83)

 			await handler(true, cancellationToken);
 	}
 
▶	private async void Invoke(Channels channel, string tzip)
 	{
 		try
 		{

💬 Method Invoke is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Connectors\Bittrex\Native\PusherClient.cs (line 83)

 			await handler(true, cancellationToken);
 	}
 
▶	private async void Invoke(Channels channel, string tzip)
 	{
 		try
 		{

💬 Method Invoke is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 52 hits

📄 Reporting\ExcelReportGenerator.cs (line 345)

 		worker
 			.SetCell(0, 4, LocalizedStrings.StartTime)
 			.SetCellColor(0, 4, labelBg, null)
▶			.SetCell(1, 4, DateTime.Now)
 			.SetCellFormat(1, 4, "yyyy-MM-dd HH:mm:ss");
 
 		// Row 5: Net PnL

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Reporting\ExcelReportGenerator.cs (line 207)

 		worker
 			.SetCell(0, 2, LocalizedStrings.StartTime)
 			.SetCellColor(0, 2, labelBg, null)
▶			.SetCell(1, 2, DateTime.Now)
 			.SetCellFormat(1, 2, "yyyy-MM-dd HH:mm:ss");
 
 		// Row 3: Symbol

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 74 hits

📄 Messages\Extensions.cs (line 4400)

 
 		if (period == null || period.Times.IsEmpty())
 		{
▶			return (to - from).Ticks / timeFrame.Ticks;
 		}
 
 		if (days == 0)

💬 The operands in the divisive expression (to - from).Ticks / timeFrame.Ticks are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Messages\Extensions.cs (line 4415)

 			return totalCount;
 
 		var fullDayLength = period.Times.Sum(r => r.Length.Ticks);
▶		totalCount += TimeSpan.FromTicks((days - 1) * fullDayLength).Ticks / timeFrame.Ticks;
 
 		return totalCount;
 	}

💬 The operands in the divisive expression TimeSpan.FromTicks((days - 1) * fullDayLength).Ticks / timeFrame.Ticks are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 114 hits

📄 BusinessEntities\EntitiesExtensions.cs (line 2123)

 			return [.. securities.TryLimitByCount(criteria)];
 
 		var dict = securities.ToDictionary(s => s.ToMessage(), s => s);
▶		return [.. dict.Keys.Filter(criteria).TryLimitByCount(criteria).Select(m => dict[m])];
 	}
 
 	/// <summary>

💬 Type SecurityMessage is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Algo\CollectionSecurityProvider.cs (line 117)

 				continue;
 
 			added ??= [];
▶			added.Add(security);
 		}
 
 		if (added is { Count: > 0 })

💬 Type Security is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS005 Equals() and GetHashCode() not implemented together 14 hits

📄 Messages\MessageTypes.cs (line 452)

 /// <summary>
 /// Extended info for <see cref="MessageTypes"/>.
 /// </summary>
▶public class MessageTypeInfo : Equatable<MessageTypeInfo>
 {
 	/// <summary>
 	/// Message type.

💬 Equals() and GetHashcode() must be implemented together on MessageTypeInfo (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 Messages\DataType.cs (line 8)

 /// </summary>
 [DataContract]
 [Serializable]
▶public class DataType : Equatable<DataType>, IPersistable
 {
 	/// <summary>
 	/// Initializes a new instance of the <see cref="DataType"/>.

💬 Equals() and GetHashcode() must be implemented together on DataType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 24 hits

📄 Messages\CandleMessage.cs (line 584)

 	/// <returns>A hash code.</returns>
 	public override int GetHashCode()
 	{
▶		return BoxSize.GetHashCode() ^ ReversalAmount.GetHashCode();
 	}
 }
 

💬 GetHashCode() refers to mutable property BoxSize (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Messages\CandleMessage.cs (line 584)

 	/// <returns>A hash code.</returns>
 	public override int GetHashCode()
 	{
▶		return BoxSize.GetHashCode() ^ ReversalAmount.GetHashCode();
 	}
 }
 

💬 GetHashCode() refers to mutable property ReversalAmount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 450 hits

📄 Messages\QuoteChange.cs (line 63)

 /// <param name="condition">Quote condition.</param>
 [DataContract]
 [Serializable]
▶public struct QuoteChange(decimal price, decimal volume, int? ordersCount = null, QuoteConditions condition = default)
 {
 
 	/// <summary>

💬 Implement Equals(), GetHashCode() and ToString() methods on struct QuoteChange. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Messages\CandlePriceLevel.cs (line 8)

 /// </summary>
 [DataContract]
 [Serializable]
▶public struct CandlePriceLevel// : ICloneable<CandlePriceLevel>
 {
 	/// <summary>
 	/// Price.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CandlePriceLevel. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 130 hits

📄 Messages\MessageAdapter.cs (line 394)

 
 			if (IsAutoReplyOnTransactonalUnsubscription)
 			{
▶				switch (message.Type)
 				{
 					case MessageTypes.PortfolioLookup:
 					case MessageTypes.OrderStatus:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 BusinessEntities\EntitiesExtensions.cs (line 1374)

 		{
 			try
 			{
▶				switch (change.Key)
 				{
 					case PositionChangeTypes.BeginValue:
 						position.BeginValue = (decimal)change.Value;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 220 hits

📄 Messages\SubscriptionBase.cs (line 125)

 		if (security == null)
 			return;
 
▶		switch (subscriptionMessage)
 		{
 			case MarketDataMessage mdMsg:
 				security.CopyTo(mdMsg, false);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Messages\OrderBookIncrementBuilder.cs (line 70)

 
 		bool CheckSwitch()
 		{
▶			switch (currState)
 			{
 				case _none:
 				case QuoteChangeStates.SnapshotStarted:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 10 hits

📄 Algo\Derivatives\BasketBlackScholes.cs (line 102)

 				var model = _innerModels.SyncGet(c => c.FirstOrDefault());
 
 				if (model == null)
▶					throw new InvalidOperationException(LocalizedStrings.ModelNoOptions);
 
 				base.UnderlyingAsset = model.UnderlyingAsset;
 			}

💬 An exception is thrown from the getter of property UnderlyingAsset (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Algo.Testing\Generation\MarketDataGenerator.cs (line 172)

 		get
 		{
 			if (_volumes == null)
▶				throw new InvalidOperationException(LocalizedStrings.GeneratorNotInitialized);
 
 			return _volumes;
 		}

💬 An exception is thrown from the getter of property Volumes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 180 hits

📄 Messages\AsyncMessageChannel.cs (line 316)

 							if (_subscriptionItems.TryGetAndRemove(subMsg.OriginalTransactionId, out var subItem))
 							{
 								subItem.UnsubscribeRequest = subMsg.TransactionId;
▶								subItem.Cts.Cancel();
 
 								done();
 								return;

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Messages\AsyncMessageChannel.cs (line 517)

 		{
 			var item = kv.Value;
 
▶			item.Cts.Cancel();
 			item.Cts.Dispose();
 		}
 

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 Tests\CompilationTests.cs (line 90)

 				{
 					var context = compiler.CreateContext();
 
▶					var res = compiler.Compile(
 						scriptName,
 						sources,
 						refs,

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Tests\CompilationTests.cs (line 90)

 				{
 					var context = compiler.CreateContext();
 
▶					var res = compiler.Compile(
 						scriptName,
 						sources,
 						refs,

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 2 hits

📄 Tests\CompilationTests.cs (line 109)

 					script.AssertNotNull();
 
 					// Test script execution with mock data
▶					RunAnalyticsScript(script, securities, from, to, storageRegistry, storageRegistry.DefaultDrive, format, timeFrame, token).Wait();
 				}
 			}
 			catch (Exception ex)

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 Tests\CompilationTests.cs (line 109)

 					script.AssertNotNull();
 
 					// Test script execution with mock data
▶					RunAnalyticsScript(script, securities, from, to, storageRegistry, storageRegistry.DefaultDrive, format, timeFrame, token).Wait();
 				}
 			}
 			catch (Exception ex)

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS041 Unnecessary enumerable materialization 4 hits

📄 Algo\Candles\BiggerTimeFrameCandleCompressor.cs (line 98)

 	{
 		TimeFrameCandleMessage lastCandle = null;
 
▶		foreach (var candle in _processParts.SelectMany(p => ProcessCandlePart(p, message)).ToArray().Cast<TimeFrameCandleMessage>())
 		{
 			if (candle != lastCandle)
 			{

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Diagram.Core\Elements\LogicalConditionDiagramElement.cs (line 138)

 		minSockets = minSockets.Max(_loadedSockets.Count);
 
 		if (_loadedSockets.Count > 0)
▶			InputSockets.ToArray().Where(s => !_loadedSockets.Contains(s.Id) && GetNumConnections(s) == 0).ForEach(RemoveSocket);
 
 		while (InputSockets.Count > maxSockets)
 		{

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 8 hits

📄 Localization\MediaIconAttribute.cs (line 8)

 /// <summary>
 /// Specify icon, located in S#.Media library.
 /// </summary>
▶public class MediaIconAttribute : IconAttribute
 {
 	/// <summary>
 	/// Create <see cref="MediaIconAttribute"/>.

💬 MediaIconAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Messages\XamlIconAttribute.cs (line 10)

 /// Initializes a new instance of the <see cref="XamlIconAttribute"/>.
 /// </remarks>
 /// <param name="icon">Icon.</param>
▶public class XamlIconAttribute(string icon) : IconAttribute($"/StockSharp.Xaml;component/IconsSvg/{icon}.svg", true)
 {
 }

💬 XamlIconAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 2 hits

📄 Samples\10_CrossPlatform\01_ConsoleApp\Program.cs (line 102)

 		Console.Write("Do you want to buy 1? (Y/N)");
 
 		var str = Console.ReadLine();
▶		if (str != null && str.ToUpper() != "Y") return;
 
 		var bestBidPrice = lastDepth?.GetBestBid()?.Price;

📄 Samples\10_CrossPlatform\01_ConsoleApp\Program.cs (line 102)

 		Console.Write("Do you want to buy 1? (Y/N)");
 
 		var str = Console.ReadLine();
▶		if (str != null && str.ToUpper() != "Y") return;
 
 		var bestBidPrice = lastDepth?.GetBestBid()?.Price;

SS059 IAsyncDisposable not disposed asynchronously 188 hits

📄 Messages\IMessageAdapterAsyncExtensions.cs (line 24)

 			throw new ArgumentNullException(nameof(adapter));
 
 		var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
▶		using var ctr = cancellationToken.Register(() => tcs.TrySetCanceled(cancellationToken));
 
 		ValueTask OnOut(Message msg, CancellationToken ct)
 		{

💬 CancellationTokenRegistration can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Messages\IMessageAdapterAsyncExtensions.cs (line 64)

 			throw new ArgumentNullException(nameof(adapter));
 
 		var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
▶		using var ctr = cancellationToken.Register(() => tcs.TrySetCanceled(cancellationToken));
 
 		ValueTask OnOut(Message msg, CancellationToken ct)
 		{

💬 CancellationTokenRegistration can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 572 hits

📄 Messages\InMemoryMessageChannel.cs (line 11)

 	private readonly IMessageQueue _queue;
 	private readonly Action<Exception> _errorHandler;
 
▶	private CancellationTokenSource _cancellationTokenSource;
 	private Task _processingTask;
 
 	/// <summary>

💬 Disposable field _cancellationTokenSource in type InMemoryMessageChannel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Messages\InMemoryMessageChannel.cs (line 12)

 	private readonly Action<Exception> _errorHandler;
 
 	private CancellationTokenSource _cancellationTokenSource;
▶	private Task _processingTask;
 
 	/// <summary>
 	/// Initializes a new instance of the <see cref="InMemoryMessageChannel"/>.

💬 Disposable field _processingTask in type InMemoryMessageChannel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

R3

2014 total diagnostics across 13 rules

SS001 Async method with void return type 208 hits

📄 src\R3\AwaitOperation.cs (line 71)

     protected abstract ValueTask OnNextAsync(T value, CancellationToken cancellationToken, bool configureAwait);
     protected abstract void PublishOnCompleted(Result result);
 
▶    async void RunQueueWorker() // don't(can't) wait so use async void
     {
         var reader = channel.Reader;
         var token = cancellationTokenSource.Token;

💬 Method RunQueueWorker is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\R3\AwaitOperation.cs (line 161)

     protected abstract ValueTask OnNextAsync(T value, CancellationToken cancellationToken, bool configureAwait);
     protected abstract void PublishOnCompleted(Result result);
 
▶    async void StartAsync(T value)
     {
         try
         {

💬 Method StartAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 src\R3\ObservableTracker.cs (line 62)

 
         var id = Interlocked.Increment(ref trackingIdCounter);
         trackableDisposable = new TrackableDisposable(subscription, id);
▶        tracking.TryAdd(trackableDisposable, new TrackingState(id, typeName, DateTime.Now, stackTrace)); // use local now.
 
         return true;
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\R3\ObservableTracker.cs (line 62)

 
         var id = Interlocked.Increment(ref trackingIdCounter);
         trackableDisposable = new TrackableDisposable(subscription, id);
▶        tracking.TryAdd(trackableDisposable, new TrackingState(id, typeName, DateTime.Now, stackTrace)); // use local now.
 
         return true;
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 26 hits

📄 src\R3\CompositeDisposable.cs (line 90)

             current[index] = null;
 
             // Do shrink
▶            if (current.Capacity > ShrinkThreshold && count < current.Capacity / 2)
             {
                 var fresh = new List<IDisposable?>(current.Capacity / 2);
 

💬 The operands in the divisive expression current.Capacity / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\R3\CompositeDisposable.cs (line 92)

             // Do shrink
             if (current.Capacity > ShrinkThreshold && count < current.Capacity / 2)
             {
▶                var fresh = new List<IDisposable?>(current.Capacity / 2);
 
                 foreach (var d in current)
                 {

SS017 Struct without Equals/GetHashCode/ToString overridden 104 hits

📄 src\R3\Disposable.cs (line 418)

     }
 }
 
▶public ref struct DisposableBuilder()
 {
     IDisposable? disposable1;
     IDisposable? disposable2;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DisposableBuilder. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\R3\DisposableBag.cs (line 3)

 namespace R3;
 
▶public struct DisposableBag : IDisposable
 {
     IDisposable[]? items;
     bool isDisposed;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DisposableBag. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 40 hits

📄 src\R3\Subject.cs (line 36)

             Volatile.Write(ref error, result.Exception);      // set failure immmediately(but not locked).
         }
 
▶        switch (field)
         {
             case NotCompleted:
                 return ResultStatus.Done;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\R3\Subject.cs (line 55)

     public bool TrySetDisposed(out bool alreadyCompleted)
     {
         var field = Interlocked.Exchange(ref completeState, Disposed);
▶        switch (field)
         {
             case NotCompleted:
                 alreadyCompleted = false;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS020 Test method without public modifier 4 hits

📄 tests\R3.Tests\OperatorTests\ToAsyncEnumerableTest.cs (line 6)

 public class ToAsyncEnumerableTest
 {
     [Fact]
▶    async Task Test()
     {
         var publisher = new Subject<int>();
         var cts = new CancellationTokenSource();

💬 Test method "Test" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 tests\R3.Tests\OperatorTests\ToAsyncEnumerableTest.cs (line 27)

     }
 
     [Fact]
▶    async Task Cancel()
     {
         var publisher = new Subject<int>();
         var cts = new CancellationTokenSource();

💬 Test method "Cancel" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS023 Exception thrown from property getter 8 hits

📄 src\R3\Collections\LiveList.cs (line 39)

             {
                 lock (list)
                 {
▶                    if (!isCompleted) throw new InvalidOperationException("LiveList is not completed, you should check IsCompleted.");
                     return completedValue;
                 }
             }

💬 An exception is thrown from the getter of property Result (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\R3\Collections\LiveList.cs (line 39)

             {
                 lock (list)
                 {
▶                    if (!isCompleted) throw new InvalidOperationException("LiveList is not completed, you should check IsCompleted.");
                     return completedValue;
                 }
             }

💬 An exception is thrown from the getter of property Result (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 4 hits

📄 tests\R3.Tests\OperatorTests\SelectAwaitTest.cs (line 174)

         liveList.AssertEqual([]);
 
         timeProvider.Advance(1);
▶        Thread.Sleep(100);
         liveList.AssertEqual([100]);
 
         timeProvider.Advance(2);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 tests\R3.Tests\OperatorTests\SelectAwaitTest.cs (line 178)

         liveList.AssertEqual([100]);
 
         timeProvider.Advance(2);
▶        Thread.Sleep(100);
         liveList.AssertEqual([100]);
 
         subject.OnNext(3);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 18 hits

📄 sandbox\ReferenceBuilder\Program.cs (line 10)

 // Get absolute path of bin/Debug/TargetFramework/ReferenceBuilder.dll
 // Location = /Foo/Bar/R3/sandbox/ReferenceBuilder/bin/Debug/net8.0/ReferenceBuilder.dll
 var basePath = Assembly.GetAssembly(typeof(Program))!.Location;
▶File.WriteAllText(Path.Combine(basePath, "../../../../../../docs/reference_factory.md"), f);
 File.WriteAllText(Path.Combine(basePath, "../../../../../../docs/reference_operator.md"), o);
 
 // replace readme

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 sandbox\ReferenceBuilder\Program.cs (line 11)

 // Location = /Foo/Bar/R3/sandbox/ReferenceBuilder/bin/Debug/net8.0/ReferenceBuilder.dll
 var basePath = Assembly.GetAssembly(typeof(Program))!.Location;
 File.WriteAllText(Path.Combine(basePath, "../../../../../../docs/reference_factory.md"), f);
▶File.WriteAllText(Path.Combine(basePath, "../../../../../../docs/reference_operator.md"), o);
 
 // replace readme
 var text = File.ReadAllLines(Path.Combine(basePath, "../../../../../../README.md"));

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 4 hits

📄 src\R3\Internal\Shims\TaskExtensions.cs (line 25)

             }
             else
             {
▶                tcs.TrySetResult(t.Result);
             }
         }, TaskScheduler.Default);
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\R3\Internal\Shims\TaskExtensions.cs (line 25)

             }
             else
             {
▶                tcs.TrySetResult(t.Result);
             }
         }, TaskScheduler.Default);
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS048 Locking on discouraged object (string, Type, this) 104 hits

📄 src\R3\SynchronizedReactiveProperty.cs (line 24)

     {
         get
         {
▶            lock (this)
             {
                 return base.Value;
             }

📄 src\R3\SynchronizedReactiveProperty.cs (line 31)

         }
         set
         {
▶            lock (this)
             {
                 base.Value = value;
             }

SS051 Locking on mutable reference 80 hits

📄 src\R3\Operators\TakeLast.cs (line 50)

 
         protected override void OnNextCore(T value)
         {
▶            lock (queue)
             {
                 if (takeCompleted) return;
 

💬 A lock was obtained on queue but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\R3\Operators\TakeLast.cs (line 75)

                 return;
             }
 
▶            lock (queue)
             {
                 takeCompleted = true;
 

SS066 Disposable field is not disposed 1406 hits

📄 src\R3\Operators\ZipLatest.cs (line 366)

 
     sealed class _ZipLatest : IDisposable
     {
▶        readonly Observer<TResult> observer;
         readonly Observable<T1> source1;
         readonly Observable<T2> source2;
         readonly Observable<T3> source3;

💬 Disposable field observer in type _ZipLatest is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\R3\Operators\ZipLatest.cs (line 236)

 
     sealed class _ZipLatest : IDisposable
     {
▶        readonly Observer<TResult> observer;
         readonly Observable<T1> source1;
         readonly Observable<T2> source2;
         readonly Func<T1, T2, TResult> resultSelector;

💬 Disposable field observer in type _ZipLatest is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

LibreHardwareMonitor

1974 total diagnostics across 10 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 44 hits

📄 Aga.Controls\Tree\IncrementalSearch.cs (line 18)

 		private TreeViewAdv _tree;
 		private TreeNodeAdv _currentNode;
 		private string _searchString = "";
▶		private DateTime _lastKeyPressed = DateTime.Now;
 
 		public IncrementalSearch(TreeViewAdv tree)
 		{

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Aga.Controls\Tree\IncrementalSearch.cs (line 30)

 			if (!Char.IsControl(value))
 			{
 				Char ch = Char.ToLowerInvariant(value);
▶				DateTime dt = DateTime.Now;
 				TimeSpan ts = dt - _lastKeyPressed;
 				_lastKeyPressed = dt;
 				if (ts.TotalMilliseconds < SearchTimeout)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 254 hits

📄 Aga.Controls\Tree\FixedRowHeightLayout.cs (line 34)

 		{
 			get
 			{
▶				return Math.Max((_treeView.DisplayRectangle.Height - _treeView.ColumnHeaderHeight) / _rowHeight, 0);
 			}
 		}
 

💬 The operands in the divisive expression (_treeView.DisplayRectangle.Height - _treeView.ColumnHeaderHeight) / _rowHeight are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Aga.Controls\Tree\FixedRowHeightLayout.cs (line 49)

 		public int GetRowAt(Point point)
 		{
 			point = new Point(point.X, point.Y + (_treeView.FirstVisibleRow * _rowHeight) - _treeView.ColumnHeaderHeight);
▶			return point.Y / _rowHeight;
 		}
 
 		public int GetFirstRow(int lastPageRow)

💬 The operands in the divisive expression point.Y / _rowHeight are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 8 hits

📄 Aga.Controls\Threading\AbortableThreadPool.cs (line 48)

 					}
 					if (item == null)
 						return;
▶					_threads.Add(item, Thread.CurrentThread);
 
 				}
 				ExecutionContext.Run(item.Context,

💬 Type WorkItem is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Aga.Controls\Threading\AbortableThreadPool.cs (line 89)

 					_callbacks.Remove(node);
 					return WorkItemStatus.Queued;
 				}
▶				else if (_threads.ContainsKey(item))
 				{
 					if (allowAbort)
 					{

SS017 Struct without Equals/GetHashCode/ToString overridden 904 hits

📄 Aga.Controls\BitmapHelper.cs (line 13)

 	public static class BitmapHelper
 	{
 		[StructLayout(LayoutKind.Sequential)]
▶		private struct PixelData
 		{
 			public byte B;
 			public byte G;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PixelData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Aga.Controls\Tree\DropPosition.cs (line 7)

 
 namespace Aga.Controls.Tree
 {
▶	public struct DropPosition
 	{
 		private TreeNodeAdv _node;
 		public TreeNodeAdv Node

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DropPosition. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 94 hits

📄 Aga.Controls\Tree\Input\NormalInputState.cs (line 23)

 
 			if (Tree.CurrentNode != null)
 			{
▶				switch (args.KeyCode)
 				{
 					case Keys.Right:
 						if (!Tree.CurrentNode.IsExpanded)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Aga.Controls\Tree\TreeViewAdv.cs (line 562)

 			get
 			{
 				CreateParams res = base.CreateParams;
▶				switch (BorderStyle)
 				{
 					case BorderStyle.FixedSingle:
 						res.Style |= 0x800000;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 588 hits

📄 Aga.Controls\NumericTextBox.cs (line 100)

 		protected override void WndProc(ref Message m)
 		{
 			// Switch to handle message...
▶			switch (m.Msg)
 			{
 				case WM_PASTE:
 					{

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Aga.Controls\GifDecoder.cs (line 265)

 					if (iline >= ih) 
 					{
 						pass++;
▶						switch (pass) 
 						{
 							case 2 :
 								iline = 4;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 10 hits

📄 LibreHardwareMonitorLib\Hardware\Computer.cs (line 321)

         get
         {
             if (!_open)
▶                throw new InvalidOperationException("SMBIOS cannot be accessed before opening.");
 
             return _smbios;
         }

💬 An exception is thrown from the getter of property SMBios (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 LibreHardwareMonitorLib\Hardware\Computer.cs (line 321)

         get
         {
             if (!_open)
▶                throw new InvalidOperationException("SMBIOS cannot be accessed before opening.");
 
             return _smbios;
         }

💬 An exception is thrown from the getter of property SMBios (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS051 Locking on mutable reference 20 hits

📄 Aga.Controls\PerformanceAnalyzer.cs (line 80)

 		[Conditional("DEBUG")]
 		public static void Finish(string pieceOfCode)
 		{
▶			lock (_performances)
 			{
 				if (_performances.ContainsKey(pieceOfCode))
 				{

💬 A lock was obtained on _performances but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Aga.Controls\PerformanceAnalyzer.cs (line 62)

 		public static void Start(string pieceOfCode)
 		{
 			PerformanceInfo info = null;
▶			lock(_performances)
 			{
 				if (_performances.ContainsKey(pieceOfCode))
 					info = _performances[pieceOfCode];

SS058 String concatenated in a loop 14 hits

📄 Aga.Controls\GifDecoder.cs (line 652)

 							String app = "";
 							for (int i = 0; i < 11; i++) 
 							{
▶								app += (char) block[i];
 							}
 							if (app.Equals("NETSCAPE2.0")) 
 							{

📄 Aga.Controls\GifDecoder.cs (line 708)

 			String id = "";
 			for (int i = 0; i < 6; i++) 
 			{
▶				id += (char) Read();
 			}
 			if (!id.StartsWith("GIF")) 
 			{

SS066 Disposable field is not disposed 38 hits

📄 Aga.Controls\Tree\TreeViewAdv.cs (line 45)

 		private bool _suspendUpdate;
 		private bool _needFullUpdate;
 		private bool _fireSelectionEvent;
▶		private NodePlusMinus _plusMinus;
 		private ToolTip _toolTip;
 		private DrawContext _measureContext;
 		private TreeColumn _hotColumn;

💬 Disposable field _plusMinus in type TreeViewAdv is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Aga.Controls\Tree\TreeViewAdv.cs (line 46)

 		private bool _needFullUpdate;
 		private bool _fireSelectionEvent;
 		private NodePlusMinus _plusMinus;
▶		private ToolTip _toolTip;
 		private DrawContext _measureContext;
 		private TreeColumn _hotColumn;
 		private IncrementalSearch _search;

💬 Disposable field _toolTip in type TreeViewAdv is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

FASTER

1924 total diagnostics across 12 rules

SS003 Integer divided by integer causing implicit rounding 448 hits

📄 cs\src\core\Index\Common\AddressInfo.cs (line 19)

     {
         private const int kMultiplierBits = 1;
         private static readonly int kTotalBits = sizeof(IntPtr) * 8;
▶        private static readonly int kAddressBits = 42*kTotalBits/64;
         private static readonly int kSizeBits = kTotalBits - kAddressBits - kMultiplierBits;
         private static readonly long kSizeMaskInWord = ((1L << kSizeBits) - 1) << kAddressBits;
         private static readonly long kSizeMaskInInteger = (1L << kSizeBits) - 1;

💬 The operands in the divisive expression 42*kTotalBits/64 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 cs\src\core\Allocator\GenericFrame.cs (line 29)

         {
             Record<Key, Value>[] tmp;
             if (pageSize % recordSize == 0)
▶                tmp = new Record<Key, Value>[pageSize / recordSize];
             else
                 tmp = new Record<Key, Value>[1 + (pageSize / recordSize)];
             Array.Clear(tmp, 0, tmp.Length);

💬 The operands in the divisive expression pageSize / recordSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 16 hits

📄 cs\src\core\Epochs\EpochProtectedVersionScheme.cs (line 125)

         /// <inheritdoc/>
         public override int GetHashCode()
         {
▶            return Word.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field Word (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 cs\src\core\Index\Synchronization\StateTransitions.cs (line 184)

         /// <inheritdoc/>
         public override int GetHashCode()
         {
▶            return Word.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field Word (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 712 hits

📄 cs\src\core\Compaction\ICompactionFunctions.cs (line 28)

         bool IsDeleted(ref Key key, ref Value value);
     }
 
▶    internal struct DefaultCompactionFunctions<Key, Value> : ICompactionFunctions<Key, Value>
     {
         public bool IsDeleted(ref Key key, ref Value value) => false;
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DefaultCompactionFunctions. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 cs\src\core\Allocator\AllocatorBase.cs (line 21)

     internal enum PMMCloseStatus : int { Closed, Open };
 
     [StructLayout(LayoutKind.Explicit)]
▶    internal struct FullPageStatus
     {
         [FieldOffset(0)]
         public long LastFlushedUntilAddress;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FullPageStatus. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 48 hits

📄 cs\src\core\Index\Synchronization\VersionChangeStateMachine.cs (line 41)

             CancellationToken token = default)
             where FasterSession : IFasterSession
         {
▶            switch (current.Phase)
             {
                 case Phase.PREPARE:
                     if (ctx is not null)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 cs\src\core\Index\Synchronization\IndexSnapshotStateMachine.cs (line 21)

             SystemState next,
             FasterKV<Key, Value> faster)
         {
▶            switch (next.Phase)
             {
                 case Phase.PREP_INDEX_CHECKPOINT:
                     if (faster._indexCheckpoint.IsDefault())

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 48 hits

📄 cs\src\core\Index\Synchronization\VersionChangeStateMachine.cs (line 41)

             CancellationToken token = default)
             where FasterSession : IFasterSession
         {
▶            switch (current.Phase)
             {
                 case Phase.PREPARE:
                     if (ctx is not null)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 cs\src\core\Index\Synchronization\IndexSnapshotStateMachine.cs (line 21)

             SystemState next,
             FasterKV<Key, Value> faster)
         {
▶            switch (next.Phase)
             {
                 case Phase.PREP_INDEX_CHECKPOINT:
                     if (faster._indexCheckpoint.IsDefault())

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 16 hits

📄 cs\src\core\ClientSession\ClientSession.cs (line 257)

             get
             {
                 if (!this.fht.LockTable.IsEnabled)
▶                    throw new FasterException($"LockableContext requires {nameof(ConcurrencyControlMode.LockTable)}");
                 return lContext;
             }
         }

💬 An exception is thrown from the getter of property LockableContext (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 cs\src\core\ClientSession\ClientSession.cs (line 244)

             get
             {
                 if (!this.fht.LockTable.IsEnabled)
▶                    throw new FasterException($"LockableUnsafeContext requires {nameof(ConcurrencyControlMode.LockTable)}");
                 return luContext;
             }
         }

💬 An exception is thrown from the getter of property LockableUnsafeContext (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS048 Locking on discouraged object (string, Type, this) 40 hits

📄 cs\src\core\Allocator\AllocatorBase.cs (line 1221)

                 if (value < 0) return;
 
                 int oldEPC;
▶                lock (this) // linearize all setters of EmptyPageCount
                 {
                     oldEPC = emptyPageCount;
                     emptyPageCount = value;

📄 cs\src\core\Device\ManagedLocalStorageDevice.cs (line 163)

                     }
 
                     // FileStream.ReadAsync is not thread-safe hence need a lock here
▶                    lock (this)
                     {
                         readTask = logReadHandle.ReadAsync(umm.Memory).AsTask();
                     }

SS051 Locking on mutable reference 72 hits

📄 cs\src\core\Allocator\ErrorList.cs (line 18)

 
         public void Add(CommitInfo info)
         {
▶            lock (errorList)
                 errorList.Add(info);
         }
 

💬 A lock was obtained on errorList but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 cs\src\core\Allocator\ErrorList.cs (line 24)

 
         public CommitInfo GetEarliestError()
         {
▶            lock (errorList)
             {
                 var result = new CommitInfo {FromAddress = long.MaxValue};
                 var index = -1;

SS058 String concatenated in a loop 24 hits

📄 cs\src\core\Index\FASTER\FASTER.cs (line 911)

 
             foreach (var kvp in histogram.OrderBy(e => e.Key))
             {
▶                distribution += $"  {kvp.Key} : {kvp.Value}\n";
             }
 
             return distribution;

📄 cs\src\core\Index\Recovery\DirectoryConfiguration.cs (line 129)

             {
                 if (i == paths.Length - 1 && paths[i].Contains("."))
                 {
▶                    fullPath += paths[i];
                 }
                 else
                 {

SS059 IAsyncDisposable not disposed asynchronously 12 hits

📄 cs\src\core\Allocator\MallocFixedPageSize.cs (line 42)

         internal void Wait() => this.syncEvent.Wait();
         internal async ValueTask WaitAsync(CancellationToken cancellationToken)
         {
▶            using var reg = cancellationToken.Register(() => this.asyncTcs.TrySetCanceled());
             await this.asyncTcs.Task.ConfigureAwait(false);
         }
 

💬 CancellationTokenRegistration can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 cs\src\core\Utilities\AsyncCountDown.cs (line 66)

             if (counter == 0 || !GetOrCreateTaskCompletionSource(out var tcsOut))
                 return;
 
▶            using var reg = cancellationToken.Register(() => tcsOut.TrySetCanceled());
             await tcsOut.Task.WithCancellationAsync(cancellationToken).ConfigureAwait(false);
         }
 

💬 CancellationTokenRegistration can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 8 hits

📄 cs\src\core\FasterLog\FasterLogRecoveryInfo.cs (line 228)

         {
             Iterators = new Dictionary<string, long>();
 
▶            if (persistedIterators.Count > 0)
             {
                 foreach (var kvp in persistedIterators)
                 {

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 cs\src\core\FasterLog\FasterLogRecoveryInfo.cs (line 228)

         {
             Iterators = new Dictionary<string, long>();
 
▶            if (persistedIterators.Count > 0)
             {
                 foreach (var kvp in persistedIterators)
                 {

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

SS066 Disposable field is not disposed 480 hits

📄 cs\src\core\FasterLog\FasterLogIterator.cs (line 22)

     public sealed class FasterLogScanIterator : ScanIteratorBase, IDisposable
     {
         private readonly string name;
▶        private readonly FasterLog fasterLog;
         private readonly BlittableAllocator<Empty, byte> allocator;
         private readonly BlittableFrame frame;
         private readonly GetMemory getMemory;

💬 Disposable field fasterLog in type FasterLogScanIterator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 cs\src\core\FasterLog\FasterLogIterator.cs (line 23)

     {
         private readonly string name;
         private readonly FasterLog fasterLog;
▶        private readonly BlittableAllocator<Empty, byte> allocator;
         private readonly BlittableFrame frame;
         private readonly GetMemory getMemory;
         private readonly int headerSize;

💬 Disposable field allocator in type FasterLogScanIterator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

NanUI

1914 total diagnostics across 10 rules

SS001 Async method with void return type 20 hits

📄 src\Sources\Browser\WebView\Components\ContextMenu\AnimatedContextMenuStrip.cs (line 51)

     }
 
 
▶    async void FadeOut()
     {
         if (InvokeRequired)
         {

💬 Method FadeOut is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Sources\Formium\Formium.Members.cs (line 521)

         OnClosed();
     }
 
▶    private async void CreateBrowserMessageInterceptor()
     {
         var retval = await BrowserRenderWidgetHostMessageInterceptor.Setup(_browserRenderWidgetMessageInterceptor, this, BrowserWndProcCore);
 

💬 Method CreateBrowserMessageInterceptor is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 70 hits

📄 src\Sources\Logging\NanUILogger.cs (line 139)

                     Directory.CreateDirectory(backupPath);
                 }
 
▶                string? backupFile = $"{_backupFilename}_{DateTime.Now:yyyyMMdd}_{i}.backup";
                 var possibleFilePath = Path.Combine(backupPath, backupFile);
                 if (!File.Exists(possibleFilePath))
                 {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Sources\Logging\LogEntry.cs (line 81)

             _ => "[UNKNOWN LEVEL]",
         };
         string datetimeFormat = "yyyy-MM-dd HH:mm:ss.fff";
▶        return $"{DateTime.Now.ToString(datetimeFormat)} {levelText} {formattedMessage}";
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 280 hits

📄 src\Sources\Logging\NanUILogger.cs (line 116)

         }
 
         var fileInfo = new FileInfo(_filename);
▶        if (fileInfo.Exists && ((fileInfo.Length / 1024) >= _maxSizeInKiloBytes))
         {
             CreateCopyOfCurrentLogFile(_filename);
         }

💬 The operands in the divisive expression fileInfo.Length / 1024 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Sources\Formium\OffscreenImeHandler.cs (line 241)

     {
         var clauseSize = ImeNative.ImmGetCompositionString(imc, ImeNative.GCS_COMPCLAUSE, null, 0);
 
▶        var clauseLength = (int)clauseSize / sizeof(int);
 
         var result = new List<CefCompositionUnderline>();

💬 The operands in the divisive expression (int)clauseSize / sizeof(int) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 40 hits

📄 src\Sources\JavaScript\JavaScriptEngine\JavaScriptValue.cs (line 169)

                 break;
             case JavaScriptValueType.Function:
                 ValueType = JavaScriptValueType.Function;
▶                JAVASCRIPT_VALUE_COLLECTION.Add(this);
                 break;
             case JavaScriptValueType.Property:
                 ValueType = JavaScriptValueType.Property;

💬 Type JavaScriptValue is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Sources\JavaScript\JavaScriptEngine\JavaScriptValue.cs (line 173)

                 break;
             case JavaScriptValueType.Property:
                 ValueType = JavaScriptValueType.Property;
▶                JAVASCRIPT_VALUE_COLLECTION.Add(this);
                 break;
         }
 

SS017 Struct without Equals/GetHashCode/ToString overridden 560 hits

📄 src\Sources\Formium\OffscreenImeHandler.cs (line 49)

         internal const uint IACE_IGNORENOCONTEXT = 0x0020;
 
         [StructLayout(LayoutKind.Sequential)]
▶        public struct POINT
         {
             public int X;
             public int Y;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct POINT. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Sources\Formium\Forms\base\Forms\WindowBase\FramelessWindowBase.cs (line 14)

 
 namespace NetDimension.NanUI.Forms;
 [StructLayout(LayoutKind.Sequential)]
▶internal struct NCCALCSIZE_PARAMS
 {
     public RECT rgrc0, rgrc1, rgrc2;
     public WINDOWPOS lppos;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NCCALCSIZE_PARAMS. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 140 hits

📄 src\Sources\WebResource\base\ResourceHandler.cs (line 176)

 
                     //var size = (int)item.BytesCount;
 
▶                    switch (item.ElementType)
                     {
                         case CefPostDataElementType.Bytes:
                             postData.AddRange(buffer);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Sources\Formium\Forms\TransparencyForm\LayeredWindow.cs (line 99)

         {
             var msg = (WindowMessage)m.Msg;
 
▶            switch (msg)
             {
                 case WindowMessage.WM_MOUSEMOVE:
                     return BrowserWmMouseMove(ref m);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 230 hits

📄 src\Sources\WebResource\base\ResourceHandler.cs (line 176)

 
                     //var size = (int)item.BytesCount;
 
▶                    switch (item.ElementType)
                     {
                         case CefPostDataElementType.Bytes:
                             postData.AddRange(buffer);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Sources\Formium\Forms\TransparencyForm\LayeredWindow.cs (line 99)

         {
             var msg = (WindowMessage)m.Msg;
 
▶            switch (msg)
             {
                 case WindowMessage.WM_MOUSEMOVE:
                     return BrowserWmMouseMove(ref m);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 4 hits

📄 src\Sources\Browser\WebView\Components\ContextMenu\AnimatedContextMenuStrip.cs (line 55)

     {
         if (InvokeRequired)
         {
▶            Invoke(new Action(FadeOut));
             return;
         }
 

💬 Async overload available for Control.Invoke (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Sources\Browser\WebView\Components\ContextMenu\AnimatedContextMenuStrip.cs (line 55)

     {
         if (InvokeRequired)
         {
▶            Invoke(new Action(FadeOut));
             return;
         }
 

💬 Async overload available for Control.Invoke (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS059 IAsyncDisposable not disposed asynchronously 20 hits

📄 src\Sources\Browser\WebView\BrowserProcess\WindowBindingObjectServiceServer.cs (line 32)

                 {
                     try
                     {
▶                        using var server = new NamedPipeServerStream(pipeName, PipeDirection.InOut, NamedPipeServerStream.MaxAllowedServerInstances, PipeTransmissionMode.Byte, PipeOptions.Asynchronous);
 
                         await server.WaitForConnectionAsync(_cancellationTokenSource.Token);
                         AcceptClient(server);

💬 NamedPipeServerStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Sources\Browser\WebView\BrowserProcess\WindowBindingObjectServiceServer.cs (line 32)

                 {
                     try
                     {
▶                        using var server = new NamedPipeServerStream(pipeName, PipeDirection.InOut, NamedPipeServerStream.MaxAllowedServerInstances, PipeTransmissionMode.Byte, PipeOptions.Asynchronous);
 
                         await server.WaitForConnectionAsync(_cancellationTokenSource.Token);
                         AcceptClient(server);

💬 NamedPipeServerStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 550 hits

📄 src\Sources\Browser\WebView\Components\DevTools\DevToolsWindow.cs (line 11)

 namespace NetDimension.NanUI.Browser.DevTools;
 internal class DevToolsWindow : StandardWindowForm
 {
▶    public WebView WebView { get; }
     [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
     public IntPtr? BrowserWindowHandle { get; internal set; }
 

💬 Disposable field WebView in type DevToolsWindow is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Sources\Browser\WebView\Components\PopupBrowser\EmbeddedBrowserWindow.cs (line 16)

     [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
     public nint? BrowserWindowHandle { get; internal set; }
     [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
▶    public CefBrowser? Browser { get; internal set; }
 
     public EmbeddedBrowserWindow()
         : base(false, false)

💬 Disposable field Browser in type EmbeddedBrowserWindow is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

roslynator

1720 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 16 hits

📄 src\Common\RuleSetLoader.cs (line 62)

         {
             //sw = File.CreateText(path + ".log");
 
▶            sw?.WriteLine($"{DateTime.Now.ToString()} loading rule set from {path}");
             sw?.WriteLine($"{DateTime.Now.ToString()} base directory {AppContext.BaseDirectory}");
             sw?.WriteLine($"{DateTime.Now.ToString()} current directory {Environment.CurrentDirectory}");
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Common\RuleSetLoader.cs (line 63)

             //sw = File.CreateText(path + ".log");
 
             sw?.WriteLine($"{DateTime.Now.ToString()} loading rule set from {path}");
▶            sw?.WriteLine($"{DateTime.Now.ToString()} base directory {AppContext.BaseDirectory}");
             sw?.WriteLine($"{DateTime.Now.ToString()} current directory {Environment.CurrentDirectory}");
 
             if (File.Exists(path))

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 src\Core\EnumUtility.cs (line 133)

 
         while (start <= end)
         {
▶            int i = (end + start) / 2;
 
             long order = unchecked((long)value - (long)fields[i].Value);

💬 The operands in the divisive expression (end + start) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Workspaces.Core\Spelling\Core\Spellchecker.cs (line 330)

                 && value.Length % i == 0)
             {
                 int length = i;
▶                int count = value.Length / i;
 
                 for (int j = 0; j < count - 1; j++)
                 {

💬 The operands in the divisive expression value.Length / i are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 58 hits

📄 src\Workspaces.Core\AnalyzerAssembly.cs (line 57)

 
     internal IEnumerable<CodeFixProvider> GetFixers()
     {
▶        return FixersByLanguage
             .SelectMany(f => f.Value)
             .Distinct();
     }

💬 Type CodeFixProvider is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Workspaces.Core\AnalyzerLoader.cs (line 103)

 
         if (!Options.IgnoreAnalyzerReferences)
         {
▶            foreach (Assembly assembly in project.AnalyzerReferences
                 .Distinct()
                 .OfType<AnalyzerFileReference>()
                 .Select(f => f.GetAssembly())

💬 Type AnalyzerReference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 16 hits

📄 src\Core\ExtensionMethodSymbolInfo.cs (line 71)

 
     public override int GetHashCode()
     {
▶        return SymbolEqualityComparer.Default.GetHashCode(Symbol);
     }
 
     public static bool operator ==(in ExtensionMethodSymbolInfo info1, in ExtensionMethodSymbolInfo info2)

💬 GetHashCode() refers to mutable field Default (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Core\TypeAnalysis.cs (line 49)

 
     public override int GetHashCode()
     {
▶        return SymbolEqualityComparer.Default.GetHashCode(Symbol);
     }
 
     public static bool operator ==(in TypeAnalysis analysis1, in TypeAnalysis analysis2)

💬 GetHashCode() refers to mutable field Default (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 198 hits

📄 src\Core\EnumFieldSymbolInfo.cs (line 9)

 
 namespace Roslynator;
 
▶internal readonly struct EnumFieldSymbolInfo
 {
     public EnumFieldSymbolInfo(IFieldSymbol symbol, ulong value)
     {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EnumFieldSymbolInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Core\EnumSymbolInfo.cs (line 11)

 
 namespace Roslynator;
 
▶internal readonly struct EnumSymbolInfo
 {
     private EnumSymbolInfo(ImmutableArray<EnumFieldSymbolInfo> fields)
     {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EnumSymbolInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 486 hits

📄 src\Core\CreateNameFromTypeSymbolHelper.cs (line 79)

 
     private static ITypeSymbol ExtractFromArrayOrGenericCollection(ITypeSymbol typeSymbol)
     {
▶        switch (typeSymbol.Kind)
         {
             case SymbolKind.ArrayType:
             {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Core\CreateNameFromTypeSymbolHelper.cs (line 163)

             return null;
         }
 
▶        switch (typeSymbol.SpecialType)
         {
             case SpecialType.System_Object:
             case SpecialType.System_Boolean:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 892 hits

📄 src\Core\CreateNameFromTypeSymbolHelper.cs (line 79)

 
     private static ITypeSymbol ExtractFromArrayOrGenericCollection(ITypeSymbol typeSymbol)
     {
▶        switch (typeSymbol.Kind)
         {
             case SymbolKind.ArrayType:
             {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Core\CreateNameFromTypeSymbolHelper.cs (line 163)

             return null;
         }
 
▶        switch (typeSymbol.SpecialType)
         {
             case SpecialType.System_Object:
             case SpecialType.System_Boolean:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 12 hits

📄 src\Tests\CodeFixes.Tests\CS0177OutParameterMustBeAssignedToBeforeControlLeavesCurrentMethodTests.cs (line 168)

     // Flow analysis APIs do not work with local functions: https://github.com/dotnet/roslyn/issues/14214
 #pragma warning disable xUnit1013
     //[Fact, Trait(Traits.CodeFix, CompilerDiagnosticIdentifiers.OutParameterMustBeAssignedToBeforeControlLeavesCurrentMethod)]
▶    public async Task Test_VoidLocalFunctionWithTwoOutParameters()
     {
         await VerifyFixAsync(@"
 class C

💬 Method Test_VoidLocalFunctionWithTwoOutParameters might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 src\Tests\CodeFixes.Tests\CS0177OutParameterMustBeAssignedToBeforeControlLeavesCurrentMethodTests.cs (line 196)

     }
 
     //[Fact, Trait(Traits.CodeFix, CompilerDiagnosticIdentifiers.OutParameterMustBeAssignedToBeforeControlLeavesCurrentMethod)]
▶    public async Task Test_VoidLocalFunctionWithStatement()
     {
         await VerifyFixAsync(@"
 class C

💬 Method Test_VoidLocalFunctionWithStatement might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 6 hits

📄 src\Core\Collections\Enumerator.cs (line 18)

 
     public object Current
     {
▶        get { throw new InvalidOperationException(); }
     }
 
     public bool MoveNext()

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Core\Collections\Enumerator`1.cs (line 18)

 
     new public T Current
     {
▶        get { throw new InvalidOperationException(); }
     }
 
     public void Dispose()

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS030 Exception thrown from Equals 2 hits

📄 src\Core\OneOrMany`1.cs (line 120)

             }
         }
 
▶        throw new InvalidOperationException();
     }
 
     public override int GetHashCode()

💬 An exception is thrown from the Equals(OneOrMany<T>) method in type OneOrMany (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

📄 src\Core\OneOrMany`1.cs (line 120)

             }
         }
 
▶        throw new InvalidOperationException();
     }
 
     public override int GetHashCode()

💬 An exception is thrown from the Equals(OneOrMany<T>) method in type OneOrMany (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

SS033 Async overload is available 10 hits

📄 src\Workspaces.Common\CSharp\Refactorings\ChangeAccessibilityRefactoring.cs (line 104)

                 ISymbol symbol = semanticModel.GetDeclaredSymbol(member, cancellationToken);
 
                 foreach (SyntaxReference reference in symbol.DeclaringSyntaxReferences)
▶                    members.Add((MemberDeclarationSyntax)reference.GetSyntax(cancellationToken));
             }
             else if (filter.HasAnyFlag(ModifierFilter.AbstractVirtualOverride))
             {

💬 Async overload available for SyntaxReference.GetSyntax (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\CodeFixes\CSharp\CodeFixes\ArgumentCodeFixProvider.cs (line 124)

                     if (fieldSymbol.DeclaredAccessibility != Accessibility.Private)
                         return;
 
▶                    if (fieldSymbol.GetSyntax().Parent.Parent is not FieldDeclarationSyntax fieldDeclaration)
                         return;
 
                     TypeDeclarationSyntax containingTypeDeclaration = fieldDeclaration.FirstAncestor<TypeDeclarationSyntax>();

💬 Async overload available for SymbolExtensions.GetSyntax (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS058 String concatenated in a loop 14 hits

📄 src\Core\UnderscoreSuffixNameGenerator.cs (line 19)

 
         while (!IsUniqueName(name, reservedNames, isCaseSensitive))
         {
▶            suffix += "_";
             name = baseName + suffix;
         }
 

📄 src\Core\UnderscoreSuffixNameGenerator.cs (line 34)

 
         while (!IsUniqueName(name, symbols, isCaseSensitive))
         {
▶            suffix += "_";
             name = baseName + suffix;
         }
 

server

1624 total diagnostics across 22 rules

SS001 Async method with void return type 140 hits

📄 test\Core.Test\Auth\Services\DuoUniversalTokenServiceTests.cs (line 16)

     [BitAutoData("", "ClientId", "ClientSecret")]
     [BitAutoData("api-valid.duosecurity.com", "", "ClientSecret")]
     [BitAutoData("api-valid.duosecurity.com", "ClientId", "")]
▶    public async void ValidateDuoConfiguration_InvalidConfig_ReturnsFalse(
         string host, string clientId, string clientSecret, SutProvider<DuoUniversalTokenService> sutProvider)
     {
         // Arrange

💬 Method ValidateDuoConfiguration_InvalidConfig_ReturnsFalse is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 test\Core.Test\Platform\Push\NotificationHub\NotificationHubProxyTests.cs (line 28)

 
     [Theory]
     [MemberData(nameof(ClientMethods))]
▶    public async void CallsAllClients(Func<NotificationHubClientProxy, Task> proxyMethod, Func<INotificationHubClient, Task> clientMethod)
     {
         var clients = _clients.ToArray();
         var proxy = new NotificationHubClientProxy(clients);

💬 Method CallsAllClients is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 52 hits

📄 src\Core\Auth\UserFeatures\TwoFactorAuth\Implementations\CompleteTwoFactorWebAuthnRegistrationCommand.cs (line 74)

             UserHandle = success.Result.User.Id,
             SignatureCounter = success.Result.Counter,
             CredType = success.Result.CredType,
▶            RegDate = DateTime.Now,
             AaGuid = success.Result.Aaguid
         };
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 test\Core.Test\AdminConsole\Models\Data\SelfHostedOrganizationDetailsTests.cs (line 379)

         license.UsersGetPremium = true;
         license.UseCustomPermissions = true;
         license.Version = 11;
▶        license.Issued = DateTime.Now;
         license.Expires = DateTime.Now.AddYears(1);
 
         return (organization, license);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 18 hits

📄 src\Core\Repositories\TableStorage\InstallationDeviceRepository.cs (line 52)

             }
 
             // A batch insert can only contain 100 entities at a time
▶            var iterations = groupEntities.Count / 100;
             for (var i = 0; i <= iterations; i++)
             {
                 var batch = new List<TableTransactionAction>();

💬 The operands in the divisive expression groupEntities.Count / 100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Core\Dirt\Repositories\TableStorage\EventRepository.cs (line 129)

             }
 
             // A batch insert can only contain 100 entities at a time
▶            var iterations = groupEntities.Count / 100;
             for (var i = 0; i <= iterations; i++)
             {
                 var batch = new List<TableTransactionAction>();

SS004 Elementary methods of type in collection not overridden 232 hits

📄 src\Infrastructure.Dapper\AdminConsole\Helpers\BulkResourceCreationService.cs (line 102)

         {
             var row = table.NewRow();
 
▶            row[collectionIdColumn] = collectionUserRecord.CollectionId;
             row[orgUserIdColumn] = collectionUserRecord.OrganizationUserId;
             row[readOnlyColumn] = collectionUserRecord.ReadOnly;
             row[hidePasswordsColumn] = collectionUserRecord.HidePasswords;

📄 src\Infrastructure.Dapper\AdminConsole\Helpers\BulkResourceCreationService.cs (line 103)

             var row = table.NewRow();
 
             row[collectionIdColumn] = collectionUserRecord.CollectionId;
▶            row[orgUserIdColumn] = collectionUserRecord.OrganizationUserId;
             row[readOnlyColumn] = collectionUserRecord.ReadOnly;
             row[hidePasswordsColumn] = collectionUserRecord.HidePasswords;
             row[manageColumn] = collectionUserRecord.Manage;

SS009 Random instantiated in a loop 2 hits

📄 src\Core\Jobs\BaseJobsHostedService.cs (line 110)

                         }
 
                         _logger.LogWarning(e, "Exception while trying to schedule job: {JobName}", job.FullName);
▶                        var random = new Random();
                         await Task.Delay(random.Next(50, 250));
                     }
                 }

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

📄 src\Core\Jobs\BaseJobsHostedService.cs (line 110)

                         }
 
                         _logger.LogWarning(e, "Exception while trying to schedule job: {JobName}", job.FullName);
▶                        var random = new Random();
                         await Task.Delay(random.Next(50, 250));
                     }
                 }

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 util\Seeder\Scenes\SingleUserScene.cs (line 10)

 
 namespace Bit.Seeder.Scenes;
 
▶public struct SingleUserSceneResult
 {
     public Guid UserId { get; init; }
     public string Kdf { get; init; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SingleUserSceneResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 util\Seeder\Scenes\SingleUserScene.cs (line 10)

 
 namespace Bit.Seeder.Scenes;
 
▶public struct SingleUserSceneResult
 {
     public Guid UserId { get; init; }
     public string Kdf { get; init; }

SS018 Switch does not handle all enum options 24 hits

📄 src\Core\AdminConsole\Utilities\PolicyDataValidator.cs (line 31)

         {
             var json = JsonSerializer.Serialize(data);
 
▶            switch (policyType)
             {
                 case PolicyType.MasterPassword:
                     var masterPasswordData = CoreHelpers.LoadClassFromJsonData<MasterPasswordPolicyData>(json);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Core\Services\Implementations\UserService.cs (line 598)

 
         // Calling User must be of higher/equal user type to reset user's password
         var canAdjustPassword = false;
▶        switch (callingUserType)
         {
             case OrganizationUserType.Owner:
                 canAdjustPassword = true;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 108 hits

📄 src\Core\AdminConsole\Enums\PolicyType.cs (line 35)

     /// </summary>
     public static string GetName(this PolicyType type)
     {
▶        return type switch
         {
             PolicyType.TwoFactorAuthentication => "Require two-step login",
             PolicyType.MasterPassword => "Master password requirements",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Core\AdminConsole\Utilities\PolicyDataValidator.cs (line 31)

         {
             var json = JsonSerializer.Serialize(data);
 
▶            switch (policyType)
             {
                 case PolicyType.MasterPassword:
                     var masterPasswordData = CoreHelpers.LoadClassFromJsonData<MasterPasswordPolicyData>(json);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS020 Test method without public modifier 38 hits

📄 test\Core.Test\KeyManagement\SendPasswordHasherTests.cs (line 16)

     [Theory]
     [BitAutoData(PasswordVerificationResult.Success)]
     [BitAutoData(PasswordVerificationResult.SuccessRehashNeeded)]
▶    void VerifyPasswordHash_WithValidMatching_ReturnsTrue(
         PasswordVerificationResult passwordVerificationResult,
         SutProvider<SendPasswordHasher> sutProvider,
         string sendPasswordHash,

💬 Test method "VerifyPasswordHash_WithValidMatching_ReturnsTrue" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 test\Core.Test\KeyManagement\SendPasswordHasherTests.cs (line 38)

     }
 
     [Theory, BitAutoData]
▶    void VerifyPasswordHash_WithNonMatchingPasswords_ReturnsFalse(
         SutProvider<SendPasswordHasher> sutProvider,
         string sendPasswordHash,
         string inputPasswordHash)

💬 Test method "VerifyPasswordHash_WithNonMatchingPasswords_ReturnsFalse" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS023 Exception thrown from property getter 6 hits

📄 src\Core\Platform\Push\NotificationHub\NotificationHubConnection.cs (line 36)

             {
                 if (!IsValid)
                 {
▶                    throw new Exception("Invalid notification hub settings");
                 }
                 Init();
             }

💬 An exception is thrown from the getter of property HubClient (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Api\Billing\Models\Requests\PreviewInvoice\PreviewPremiumUpgradeProrationRequest.cs (line 24)

         {
             if (TargetProductTierType is not (ProductTierType.Families or ProductTierType.Teams or ProductTierType.Enterprise))
             {
▶                throw new InvalidOperationException($"Cannot upgrade Premium subscription to {TargetProductTierType} plan.");
             }
 
             return TargetProductTierType switch

💬 An exception is thrown from the getter of property PlanType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 114 hits

📄 src\Core\HostedServices\ApplicationCacheHostedService.cs (line 72)

     public virtual async Task StopAsync(CancellationToken cancellationToken)
     {
         // Step 1: Signal ExecuteAsync to stop gracefully
▶        _cts?.Cancel();
 
         // Step 2: Wait for ExecuteAsync to finish cleanly
         if (_executingTask != null)

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Core\Billing\Services\Implementations\StripePaymentService.cs (line 313)

         {
             var transactionRequest = new Braintree.TransactionSearchRequest()
                 .CustomerId.Is(customer.Metadata["btCustomerId"]);
▶            var transactions = _btGateway.Transaction.Search(transactionRequest);
 
             if ((transactions?.MaximumCount ?? 0) > 0)
             {

💬 Async overload available for ITransactionGateway.Search (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 18 hits

📄 src\Core\AdminConsole\OrganizationFeatures\OrganizationUsers\OrganizationUserUserDetailsQuery.cs (line 70)

 
         await Task.WhenAll(twoFactorTask, claimedStatusTask);
 
▶        var organizationUsersTwoFactorEnabled = twoFactorTask.Result.ToDictionary(u => u.user.Id, u => u.twoFactorIsEnabled);
         var organizationUsersClaimedStatus = claimedStatusTask.Result;
         var responses = organizationUsers.Select(organizationUserDetails =>
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Core\AdminConsole\OrganizationFeatures\OrganizationUsers\OrganizationUserUserDetailsQuery.cs (line 71)

         await Task.WhenAll(twoFactorTask, claimedStatusTask);
 
         var organizationUsersTwoFactorEnabled = twoFactorTask.Result.ToDictionary(u => u.user.Id, u => u.twoFactorIsEnabled);
▶        var organizationUsersClaimedStatus = claimedStatusTask.Result;
         var responses = organizationUsers.Select(organizationUserDetails =>
         {
             // Only set permissions for Custom user types for performance optimization

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 48 hits

📄 util\Setup\Program.cs (line 290)

                 url = $"{installationUrl}/installations/";
             }
 
▶            var response = new HttpClient().GetAsync(url + _context.Install.InstallationId).GetAwaiter().GetResult();
 
             if (!response.IsSuccessStatusCode)
             {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 test\Common\MockedHttpClient\MockedHttpMessageHandler.cs (line 114)

     /// <returns></returns>
     public HttpClient ToHttpClient()
     {
▶        return new HttpClient(this);
     }
 }

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 8 hits

📄 src\Core\KeyManagement\UserKey\Implementations\RotateUserAccountKeysCommand.cs (line 182)

 
         if (model.Ciphers.Any())
         {
▶            var ciphersWithUpdatedDate = model.Ciphers.ToList().Select(c => { c.RevisionDate = now; return c; });
             saveEncryptedDataActions.Add(_cipherRepository.UpdateForKeyRotation(user.Id, ciphersWithUpdatedDate));
         }
 

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Core\KeyManagement\UserKey\Implementations\RotateUserAccountKeysCommand.cs (line 188)

 
         if (model.Folders.Any())
         {
▶            var foldersWithUpdatedDate = model.Folders.ToList().Select(f => { f.RevisionDate = now; return f; });
             saveEncryptedDataActions.Add(_folderRepository.UpdateForKeyRotation(user.Id, foldersWithUpdatedDate));
         }
 

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 18 hits

📄 src\Core\Auth\Attributes\MarketingInitiativeValidationAttribute.cs (line 6)

 
 namespace Bit.Core.Auth.Attributes;
 
▶public class MarketingInitiativeValidationAttribute : ValidationAttribute
 {
     private static readonly string[] _acceptedValues = [MarketingInitiativeConstants.Premium];

💬 MarketingInitiativeValidationAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Core\Utilities\DomainNameAttribute.cs (line 12)

 /// Domain names can contain letters, numbers, dots, and hyphens.
 /// Domain names maybe internationalized (IDN) and contain unicode characters.
 /// </summary>
▶public class DomainNameValidatorAttribute : ValidationAttribute
 {
     // RFC 1123 compliant domain name regex
     // - Allows alphanumeric characters and hyphens

💬 DomainNameValidatorAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 22 hits

📄 util\Setup\Program.cs (line 76)

         if (_context.Parameters.TryGetValue("letsencrypt", out var sslManagedLetsEncrypt))
         {
             _context.Config.SslManagedLetsEncrypt =
▶                sslManagedLetsEncrypt.ToLowerInvariant() == "y";
         }
         if (_context.Parameters.TryGetValue("domain", out var domain))
         {

📄 bitwarden_license\src\Scim\Users\GetUsersListQuery.cs (line 52)

         var totalResults = 0;
         if (!string.IsNullOrWhiteSpace(emailFilter))
         {
▶            var orgUser = orgUsers.FirstOrDefault(ou => ou.Email.ToLowerInvariant() == emailFilter);
             if (orgUser != null)
             {
                 userList.Add(orgUser);

SS051 Locking on mutable reference 4 hits

📄 src\Icons\Models\DomainName.cs (line 265)

             {
                 if (_uniqueInstance == null)
                 {
▶                    lock (_syncObj)
                     {
                         if (_uniqueInstance == null)
                         {

💬 A lock was obtained on _syncObj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\Icons\Models\DomainName.cs (line 281)

 
         public static void Reset()
         {
▶            lock (_syncObj)
             {
                 _uniqueInstance = null;
             }

SS054 Newtonsoft.Json mixed with System.Text.Json 60 hits

📄 src\Billing\Jobs\ReconcileAdditionalStorageJob.cs (line 149)

                         "{NewLine2}And would have updated database record tier: {Tier} to new MaxStorageGb: {MaxStorageGb}",
                         subscription.Id,
                         Environment.NewLine,
▶                        JsonSerializer.Serialize(updateOptions),
                         Environment.NewLine,
                         subscriptionPlanTier,
                         newMaxStorageGb);

💬 Attempting to serialize an object annotated with Newtonsoft.Json through System.Text.Json (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS054-NewtonsoftMixedWithSystemTextJson.md)

📄 src\Billing\Jobs\ReconcileAdditionalStorageJob.cs (line 149)

                         "{NewLine2}And would have updated database record tier: {Tier} to new MaxStorageGb: {MaxStorageGb}",
                         subscription.Id,
                         Environment.NewLine,
▶                        JsonSerializer.Serialize(updateOptions),
                         Environment.NewLine,
                         subscriptionPlanTier,
                         newMaxStorageGb);

💬 Attempting to serialize an object annotated with Newtonsoft.Json through System.Text.Json (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS054-NewtonsoftMixedWithSystemTextJson.md)

SS056 HttpRequest.Form read synchronously 8 hits

📄 bitwarden_license\src\Sso\Utilities\SsoAuthenticationMiddleware.cs (line 23)

     public async Task Invoke(HttpContext context)
     {
         if ((context.Request.Method == "GET" && context.Request.Query.ContainsKey("SAMLart"))
▶            || (context.Request.Method == "POST" && context.Request.Form.ContainsKey("SAMLart")))
         {
             throw new Exception("SAMLart parameter detected. SAML Artifact binding is not allowed.");
         }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 bitwarden_license\src\Sso\Utilities\Saml2OptionsExtensions.cs (line 41)

                 context.Request.HasFormContentType)
             {
                 string encodedMessage;
▶                if (context.Request.Form.TryGetValue("SAMLResponse", out var response))
                 {
                     encodedMessage = response.FirstOrDefault();
                 }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS058 String concatenated in a loop 8 hits

📄 test\Core.Test\AdminConsole\Entities\OrganizationTests.cs (line 212)

             errorMessage += "\n\nPlease add the following lines to Organization.UpdateFromLicense():\n";
             foreach (var prop in missingApplications)
             {
▶                errorMessage += $"  {prop} = license.{prop};\n";
             }
             errorMessage += "\nNote: If the property maps to a different name on Organization (like Expires → ExpirationDate), adjust accordingly.";
         }

📄 test\Core.Test\Billing\Licenses\Services\Implementations\OrganizationLicenseClaimsFactoryTests.cs (line 82)

             errorMessage += "\n\nPlease add the following claims to OrganizationLicenseClaimsFactory.GenerateClaims():\n";
             foreach (var constant in constantsWithoutClaims)
             {
▶                errorMessage += $"  new(nameof(OrganizationLicenseConstants.{constant}), entity.{constant}.ToString()),\n";
             }
             errorMessage += "\nNote: If the property is nullable, you may need to add it conditionally.";
         }

SS059 IAsyncDisposable not disposed asynchronously 564 hits

📄 test\Server.IntegrationTest\ServerTests.cs (line 15)

 
         await tempDir.WriteAsync("my-file.txt", "Hello!");
 
▶        using var server = new Server
         {
             ContentRoot = tempDir.Info.FullName,
             WebRoot = ".",

💬 Server can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 test\Server.IntegrationTest\ServerTests.cs (line 43)

         await tempDir.WriteAsync(Path.Join("images", "file.avif"), "ImagesStuff");
         await tempDir.WriteAsync(Path.Join("test", "file.json"), "{}");
 
▶        using var server = new Server
         {
             ContentRoot = tempDir.Info.FullName,
             WebRoot = ".",

💬 Server can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 130 hits

📄 src\Core\Dirt\Services\Implementations\AzureServiceBusIntegrationListenerService.cs (line 12)

     where TConfiguration : IIntegrationListenerConfiguration
 {
     private readonly int _maxRetries;
▶    private readonly IAzureServiceBusService _serviceBusService;
     private readonly IIntegrationHandler _handler;
     private readonly ServiceBusProcessor _processor;
     private readonly ILogger _logger;

💬 Disposable field _serviceBusService in type AzureServiceBusIntegrationListenerService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Core\Dirt\Services\Implementations\AzureServiceBusIntegrationListenerService.cs (line 14)

     private readonly int _maxRetries;
     private readonly IAzureServiceBusService _serviceBusService;
     private readonly IIntegrationHandler _handler;
▶    private readonly ServiceBusProcessor _processor;
     private readonly ILogger _logger;
 
     public AzureServiceBusIntegrationListenerService(

💬 Disposable field _processor in type AzureServiceBusIntegrationListenerService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

mathnet-numerics

1602 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 src\Numerics.Tests\InterpolationTests\CubicSplineTest.cs (line 257)

             var data = GenerateSplineData(amplitude, period, decay, minX, maxX, ofset, points);
             CubicSpline it = CubicSpline.InterpolateBoundaries(data.Item1, data.Item2, SplineBoundaryCondition.Natural, 0, SplineBoundaryCondition.Natural, 0);
             //start the time and calculate the min max values
▶            var t = DateTime.Now;
             var minMax = it.Extrema();
             Assert.IsTrue(minMax.Item2.AlmostEqual(ofset, 0.3), "Expexted max value near ofset.");
             Assert.IsTrue(minMax.Item1.AlmostEqual(ofset+period/2, 0.3) || minMax.Item1.AlmostEqual(ofset - period / 2, 0.3), "Expexted min value near ofset +- period/2.");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Numerics.Tests\InterpolationTests\CubicSplineTest.cs (line 262)

             Assert.IsTrue(minMax.Item2.AlmostEqual(ofset, 0.3), "Expexted max value near ofset.");
             Assert.IsTrue(minMax.Item1.AlmostEqual(ofset+period/2, 0.3) || minMax.Item1.AlmostEqual(ofset - period / 2, 0.3), "Expexted min value near ofset +- period/2.");
             //spit out the time it took to calculate
▶            Console.WriteLine("Extrema took: " + (DateTime.Now - t).TotalMilliseconds.ToString("000.00")+" ms for "+points.ToString()+" points.");
             //determine if the values are correct
             var sp = it.StationaryPoints();
             foreach (var x in sp)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 1064 hits

📄 src\Numerics\Differentiate.cs (line 54)

         public static NumericalDerivative Order(int order)
         {
             var points = order + (order.IsEven() ? 1 : 2);
▶            return new NumericalDerivative(points, points/2);
         }
 
         /// <summary>

💬 The operands in the divisive expression points/2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Numerics\Euclid.cs (line 479)

                 return 0;
             }
 
▶            return Math.Abs((a/GreatestCommonDivisor(a, b))*b);
         }
 
         /// <summary>

💬 The operands in the divisive expression a/GreatestCommonDivisor(a, b) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS005 Equals() and GetHashCode() not implemented together 24 hits

📄 src\Numerics\LinearAlgebra\Storage\SparseVectorStorage.cs (line 41)

 {
     [Serializable]
     [DataContract(Namespace = "urn:MathNet/Numerics/LinearAlgebra")]
▶    public class SparseVectorStorage<T> : VectorStorage<T>
         where T : struct, IEquatable<T>, IFormattable
     {
         // [ruegg] public fields are OK here

💬 Equals() and GetHashcode() must be implemented together on SparseVectorStorage (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\Numerics\LinearAlgebra\Storage\DiagonalMatrixStorage.cs (line 40)

 {
     [Serializable]
     [DataContract(Namespace = "urn:MathNet/Numerics/LinearAlgebra")]
▶    public class DiagonalMatrixStorage<T> : MatrixStorage<T>
         where T : struct, IEquatable<T>, IFormattable
     {
         // [ruegg] public fields are OK here

💬 Equals() and GetHashcode() must be implemented together on DiagonalMatrixStorage (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 88 hits

📄 src\Numerics\LinearAlgebra\Vector.BCL.cs (line 75)

         /// </returns>
         public sealed override int GetHashCode()
         {
▶            return Storage.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable property Storage (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Numerics\LinearAlgebra\Storage\SparseVectorStorage.cs (line 251)

         /// </returns>
         public override int GetHashCode()
         {
▶            var values = Values;
             var hashNum = Math.Min(ValueCount, 25);
             int hash = 17;
             unchecked

💬 GetHashCode() refers to mutable field Values (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

📄 src\Numerics\Precision.cs (line 986)

         }
 
         [StructLayout(LayoutKind.Explicit)]
▶        struct SingleIntUnion
         {
             [FieldOffset(0)]
             public float Single;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SingleIntUnion. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Numerics\Optimization\QuadraticGradientProjectionSearch.cs (line 115)

             }
         }
 
▶        public readonly struct GradientProjectionResult
         {
             public GradientProjectionResult(Vector<double> cauchyPoint, int fixedCount, List<bool> isFixed)
             {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GradientProjectionResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 32 hits

📄 src\Numerics\Providers\FourierTransform\ManagedFourierTransformProvider.cs (line 118)

                 BluesteinForward(samples);
             }
 
▶            switch (scaling)
             {
                 case FourierTransformScaling.SymmetricScaling:
                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Numerics\Providers\FourierTransform\ManagedFourierTransformProvider.cs (line 85)

                 BluesteinForward(samples);
             }
 
▶            switch (scaling)
             {
                 case FourierTransformScaling.SymmetricScaling:
                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 170 hits

📄 src\Numerics\Distributions\SkewedGeneralizedT.cs (line 414)

             // InverseCumulativeDistribution is not a part of the interface, so resort to type-checking.
             if (d != null)
             {
▶                switch (d)
                 {
                     case SkewedGeneralizedError sge:
                         return sge.InverseCumulativeDistribution(pr);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Numerics\Distributions\SkewedGeneralizedT.cs (line 462)

             // InverseCumulativeDistribution is not a part of the interface, so resort to type-checking.
             if (_d != null)
             {
▶                switch (_d)
                 {
                     case SkewedGeneralizedError sge:
                         return sge.InverseCumulativeDistribution(p);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 16 hits

📄 src\Numerics.Tests\DistributionTests\CommonDistributionTests.cs (line 173)

         /// <param name="delta">The error probability we are willing to tolerate.</param>
         /// <param name="s">The samples to use for testing.</param>
         /// <param name="dist">The distribution we are testing.</param>
▶        public static void ContinuousVapnikChervonenkisTest(double epsilon, double delta, double[] s, IContinuousDistribution dist)
         {
             // Using VC-dimension, we can bound the probability of making an error when estimating empirical probability
             // distributions. We are using Theorem 2.41 in "All Of Nonparametric Statistics".

💬 Method ContinuousVapnikChervonenkisTest might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 src\Numerics.Tests\DistributionTests\CommonDistributionTests.cs (line 197)

         /// <param name="delta">The error probability we are willing to tolerate.</param>
         /// <param name="s">The samples to use for testing.</param>
         /// <param name="dist">The distribution we are testing.</param>
▶        public static void DiscreteVapnikChervonenkisTest(double epsilon, double delta, int[] s, IDiscreteDistribution dist)
         {
             // Using VC-dimension, we can bound the probability of making an error when estimating empirical probability
             // distributions. We are using Theorem 2.41 in "All Of Nonparametric Statistics".

💬 Method DiscreteVapnikChervonenkisTest might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS022 Exception thrown from implicit operator 32 hits

📄 src\Numerics\LinearAlgebra\Single\DenseVector.cs (line 206)

         {
             if (array == null)
             {
▶                throw new ArgumentNullException(nameof(array));
             }
 
             return new DenseVector(array);

💬 An exception is thrown from implicit operator DenseVector in type DenseVector (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

📄 src\Numerics\LinearAlgebra\Complex\DenseVector.cs (line 206)

         {
             if (array == null)
             {
▶                throw new ArgumentNullException(nameof(array));
             }
 
             return new DenseVector(array);

💬 An exception is thrown from implicit operator DenseVector in type DenseVector (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

SS023 Exception thrown from property getter 96 hits

📄 src\Numerics\LinearAlgebra\Double\Factorization\QR.cs (line 63)

             {
                 if (FullR.RowCount != FullR.ColumnCount)
                 {
▶                    throw new ArgumentException("Matrix must be square.");
                 }
 
                 var det = 1.0;

💬 An exception is thrown from the getter of property Determinant (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Numerics\LinearAlgebra\Double\Factorization\GramSchmidt.cs (line 58)

             {
                 if (FullR.RowCount != FullR.ColumnCount)
                 {
▶                    throw new ArgumentException("Matrix must be square.");
                 }
 
                 var det = 1.0;

💬 An exception is thrown from the getter of property Determinant (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS047 LINQ traversal before filter 16 hits

📄 src\Numerics\LinearAlgebra\Storage\SparseVectorStorage.cs (line 678)

 
         public override IEnumerable<T> EnumerateNonZero()
         {
▶            return Values.Take(ValueCount).Where(x => !Zero.Equals(x));
         }
 
         public override IEnumerable<(int, T)> EnumerateNonZeroIndexed()

📄 src\Numerics\LinearAlgebra\Storage\SparseCompressedRowMatrixStorage.cs (line 1703)

 
         public override IEnumerable<T> EnumerateNonZero()
         {
▶            return Values.Take(ValueCount).Where(x => !Zero.Equals(x));
         }
 
         public override IEnumerable<(int, int, T)> EnumerateNonZeroIndexed()

SS058 String concatenated in a loop 32 hits

📄 src\Numerics\LinearAlgebra\Complex\SparseVector.cs (line 878)

                 string current = string.Empty;
                 for (int i = 0; i < weakTokens.Length; i++)
                 {
▶                    current += weakTokens[i];
                     if (current.EndsWith("+") || current.EndsWith("-") || current.StartsWith("(") && !current.EndsWith(")"))
                     {
                         continue;

📄 src\Numerics\LinearAlgebra\Complex\DenseVector.cs (line 720)

                 string current = string.Empty;
                 for (int i = 0; i < weakTokens.Length; i++)
                 {
▶                    current += weakTokens[i];
                     if (current.EndsWith("+") || current.EndsWith("-") || current.StartsWith("(") && !current.EndsWith(")"))
                     {
                         continue;

WTM

1594 total diagnostics across 20 rules

SS001 Async method with void return type 2 hits

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.Shared\WtmBlazorUtils\BasePage.cs (line 187)

         }
 
 
▶        public async void SetError(ValidateForm form, ErrorObj errors)
         {
             if (errors != null)
             {

💬 Method SetError is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.Shared\WtmBlazorUtils\BasePage.cs (line 187)

         }
 
 
▶        public async void SetError(ValidateForm form, ErrorObj errors)
         {
             if (errors != null)
             {

💬 Method SetError is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 176 hits

📄 src\WalkingTec.Mvvm.Core\LoginUserInfo.cs (line 54)

         /// 用户的数据权限列表
         /// </summary>
         public List<SimpleDataPri> DataPrivileges { get; set; }
▶        public long TimeTick { get; set; } = DateTime.Now.Ticks;
         public async System.Threading.Tasks.Task LoadBasicInfoAsync(WTMContext context)
         {
             if (string.IsNullOrEmpty(this.ITCode) || context?.DC == null || context.BaseUserQuery == null)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\WalkingTec.Mvvm.Core\BasePagedListVM.cs (line 167)

             else
             {
                 Guid g = Guid.NewGuid();
▶                var FileName = typeof(TModel).Name + "_" + DateTime.Now.ToString("yyyyMMddHHmmssffff");
                 //文件根目录            
                 string RootPath = $"{Wtm.ConfigInfo.HostRoot}\\export{g}";
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 14 hits

📄 src\WalkingTec.Mvvm.Core\BasePagedListVM.cs (line 156)

 
             //获取分成Excel的个数
             ExportMaxCount = ExportMaxCount == 0 ? 1000000 : (ExportMaxCount > 1000000 ? 1000000 : ExportMaxCount);
▶            ExportExcelCount = listcount < ExportMaxCount ? 1 : ((listcount % ExportMaxCount) == 0 ? (listcount / ExportMaxCount) : (listcount / ExportMaxCount + 1));
 
             //如果是1，直接下载Excel，如果是多个，下载ZIP包
             if (ExportExcelCount == 1)

💬 The operands in the divisive expression listcount / ExportMaxCount are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\WalkingTec.Mvvm.Core\BasePagedListVM.cs (line 156)

 
             //获取分成Excel的个数
             ExportMaxCount = ExportMaxCount == 0 ? 1000000 : (ExportMaxCount > 1000000 ? 1000000 : ExportMaxCount);
▶            ExportExcelCount = listcount < ExportMaxCount ? 1 : ((listcount % ExportMaxCount) == 0 ? (listcount / ExportMaxCount) : (listcount / ExportMaxCount + 1));
 
             //如果是1，直接下载Excel，如果是多个，下载ZIP包
             if (ExportExcelCount == 1)

SS004 Elementary methods of type in collection not overridden 8 hits

📄 src\WalkingTec.Mvvm.Core\Helper\EntityHelper.cs (line 33)

                     T entity = (T)Activator.CreateInstance(typeof(T));
                     foreach (DataColumn col in table.Columns)
                     {
▶                        (entity as DynamicData).Add(col.ColumnName, row[col] == DBNull.Value ? null : row[col]);
                     }
                     entityList.Add(entity);
                 }

📄 src\WalkingTec.Mvvm.Core\Helper\EntityHelper.cs (line 33)

                     T entity = (T)Activator.CreateInstance(typeof(T));
                     foreach (DataColumn col in table.Columns)
                     {
▶                        (entity as DynamicData).Add(col.ColumnName, row[col] == DBNull.Value ? null : row[col]);
                     }
                     entityList.Add(entity);
                 }

SS009 Random instantiated in a loop 20 hits

📄 src\WalkingTec.Mvvm.Core\Extensions\SystemExtensions\TypeExtension.cs (line 225)

                             }
                             catch { }
                         }
▶                        Random r = new Random();
                         val = r.Next(start, end).ToString();
                     }
                     else if (pro.PropertyType.IsBoolOrNullableBool())

💬 Variable r of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

📄 src\WalkingTec.Mvvm.Core\Extensions\SystemExtensions\TypeExtension.cs (line 235)

                         {
                             boolvalues.Add("null");
                         }
▶                        Random r = new Random();
                         var index = r.Next(0, boolvalues.Count);
                         val = boolvalues[index];
                     }

💬 Variable r of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\WalkingTec.Mvvm.Core\Extensions\ConfigExtension.cs (line 106)

 
         [System.Runtime.InteropServices.StructLayout(System.Runtime.InteropServices.LayoutKind.Sequential)]
 
▶        private struct IISConfigurationData
 
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct IISConfigurationData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\WalkingTec.Mvvm.Core\Extensions\ConfigExtension.cs (line 106)

 
         [System.Runtime.InteropServices.StructLayout(System.Runtime.InteropServices.LayoutKind.Sequential)]
 
▶        private struct IISConfigurationData
 
         {

SS018 Switch does not handle all enum options 16 hits

📄 src\WalkingTec.Mvvm.Core\DataContext.cs (line 786)

         public object CreateCommandParameter(string name, object value, ParameterDirection dir)
         {
             object rv = null;
▶            switch (this.DBType)
             {
                 case DBTypeEnum.SqlServer:
                     rv = new SqlParameter(name, value) { Direction = dir };

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\WalkingTec.Mvvm.Core\Support\DateRange.cs (line 187)

             switch (Epoch.Kind)
             {
                 case DateTimeKind.Local:
▶                    switch (time.Kind)
                     {
                         case DateTimeKind.Unspecified:
                             return new DateTime(time.Year, time.Month, time.Day, time.Hour, time.Minute, time.Second, time.Millisecond, DateTimeKind.Local);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 28 hits

📄 src\WalkingTec.Mvvm.Core\DataContext.cs (line 786)

         public object CreateCommandParameter(string name, object value, ParameterDirection dir)
         {
             object rv = null;
▶            switch (this.DBType)
             {
                 case DBTypeEnum.SqlServer:
                     rv = new SqlParameter(name, value) { Direction = dir };

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\WalkingTec.Mvvm.Core\WorkFlow\ApproveTimeLine.cs (line 23)

             get
             {
                 string rv = "";
▶                switch (Action)
                 {
                     case "等待审批":
                         rv = "等待" + this.Approvers + "审批";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 2 hits

📄 test\WalkingTec.Mvvm.Core.Test\VM\BaseBatchVMTest.cs (line 67)

             }
         }
 
▶        public void InitData()
         {
             using (var context = new DataContext(_seed, DBTypeEnum.Memory))
             {

💬 Method InitData might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 test\WalkingTec.Mvvm.Core.Test\VM\BaseBatchVMTest.cs (line 67)

             }
         }
 
▶        public void InitData()
         {
             using (var context = new DataContext(_seed, DBTypeEnum.Memory))
             {

💬 Method InitData might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS033 Async overload is available 382 hits

📄 src\WalkingTec.Mvvm.Core\BaseCRUDVM.cs (line 981)

             //如果是普通的TopBasePoco，则进行物理删除
             else if (typeof(TModel).GetTypeInfo().IsSubclassOf(typeof(TopBasePoco)))
             {
▶                DoRealDelete();
             }
         }
 

💬 Async overload available for BaseCRUDVM.DoRealDelete (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\WalkingTec.Mvvm.Core\DataContext.cs (line 177)

                                 systemManagement.Children.Add(item);
                             }
                         }
▶                        Set<FrameworkMenu>().Add(systemManagement);
                         Set<FunctionPrivilege>().AddRange(systemManagement.FlatTree().Select(x => new FunctionPrivilege { RoleCode = "001", MenuItemId = x.ID, Allowed = true }));
 
                         if (IsSpa == false)

💬 Async overload available for DbSet.Add (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 312 hits

📄 src\WalkingTec.Mvvm.Core\WTMContext.cs (line 390)

                 {
                     Dictionary<string, string> headers = new Dictionary<string, string>();
                     headers.Add("Authorization", "Bearer " + remoteToken);
▶                    var user = CallAPI<LoginUserInfo>("mainhost", "/api/_account/checkuserinfo?IsApi=false", HttpMethodEnum.GET, new { }, 10, headers: headers).Result;
                     rv = user.Data;
                     if (rv != null)
                     {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\WalkingTec.Mvvm.Core\WTMContext.cs (line 399)

                 }
                 else if(string.IsNullOrEmpty(password)==false)
                 {
▶                    var loginjwt = CallAPI<Token>("mainhost", "/api/_account/loginjwt", HttpMethodEnum.POST, new { Account = username, Password = password }, 10).Result;
                     if (string.IsNullOrEmpty(loginjwt?.Data?.AccessToken) == false)
                     {
                         remoteToken = loginjwt?.Data?.AccessToken;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 12 hits

📄 demo\WalkingTec.Mvvm.ReactDemo\Areas\_Admin\Controllers\FrameworkGroupController.cs (line 131)

                 DC.Set<FrameworkUserGroup>().RemoveRange(gr);
                 DC.SaveChanges();
                 await Wtm.RemoveUserCacheByGroup(GroupCode.ToArray());
▶                Wtm.RemoveGroupCache(Wtm.LoginUserInfo.CurrentTenant).Wait();
                 return Ok(ids.Count());
             }
         }

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 demo\WalkingTec.Mvvm.VueDemo\Areas\_Admin\Controllers\FrameworkGroupController.cs (line 131)

                 DC.Set<FrameworkUserGroup>().RemoveRange(gr);
                 DC.SaveChanges();
                 await Wtm.RemoveUserCacheByGroup(GroupCode.ToArray());
▶                Wtm.RemoveGroupCache(Wtm.LoginUserInfo.CurrentTenant).Wait();
                 return Ok(ids.Count());
             }
         }

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS038 HttpContext stored in a field 2 hits

📄 src\WalkingTec.Mvvm.Core\WTMContext.cs (line 30)

 {
     public class WTMContext : IDisposable
     {
▶        private HttpContext _httpContext;
         public HttpContext HttpContext { get => _httpContext; }
 
         private IServiceProvider _serviceProvider;

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

📄 src\WalkingTec.Mvvm.Core\WTMContext.cs (line 30)

 {
     public class WTMContext : IDisposable
     {
▶        private HttpContext _httpContext;
         public HttpContext HttpContext { get => _httpContext; }
 
         private IServiceProvider _serviceProvider;

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

SS041 Unnecessary enumerable materialization 6 hits

📄 src\WalkingTec.Mvvm.Core\Extensions\DCExtension.cs (line 266)

             //根据Text对下拉菜单数据排序
             if (SortByName == true)
             {
▶                rv = query.Select(lambda).ToList().OrderBy(x => x.Text).ToList();
             }
             else
             {

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\WalkingTec.Mvvm.Core\Extensions\DCExtension.cs (line 159)

             //根据Text对下拉菜单数据排序
             if (SortByName == true)
             {
▶                rv = query.Select(lambda).ToList().OrderBy(x => x.Text).ToList();
             }
             else
             {

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS049 Comparing strings without StringComparison 216 hits

📄 src\WalkingTec.Mvvm.Core\ConfigOptions\Configs.cs (line 81)

             {
                 if (_hasMainHost == null)
                 {
▶                    _mainHost = Domains?.Where(x => x.Key.ToLower() == "mainhost").Select(x => x.Value.Address).FirstOrDefault();
                     _hasMainHost = !string.IsNullOrEmpty(_mainHost);
                 }
                 return _hasMainHost == true;

📄 src\WalkingTec.Mvvm.Core\ConfigOptions\Configs.cs (line 93)

         {
             get
             {
▶                _mainHost = Domains?.Where(x => x.Key.ToLower() == "mainhost").Select(x => x.Value.Address).FirstOrDefault();
                 if(_mainHost != null)
                 {
                     _mainHost = _mainHost.Trim();

SS056 HttpRequest.Form read synchronously 52 hits

📄 src\WalkingTec.Mvvm.Core\WTMContext.cs (line 931)

                     }
                     if (HttpContext.Request.HasFormContentType)
                     {
▶                        var f = HttpContext.Request.Form;
                         foreach (var key in f.Keys)
                         {
                             if (rv.FC.Keys.Contains(key) == false)

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 src\WalkingTec.Mvvm.Mvc\Helper\RequestExtension.cs (line 34)

                 if(request.HasFormContentType == true)
                 {
                     Dictionary<string, string> data = new Dictionary<string, string>();
▶                    foreach (var item in request.Form)
                     {
                         data.Add(item.Key, item.Value);
                     }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS057 Collection manipulated during traversal 28 hits

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.ViewModel\FrameworkRoleVMs\FrameworkRoleMDVM2.cs (line 54)

                 {
                     if (topdata[i].TenantAllowed == false || (topdata[i].Url != null && ct.EnableSub == false && topdata[i].Url.ToLower().Contains("frameworktenant")))
                     {
▶                        topdata.RemoveAt(i);
                         i--;
                         continue;
                     }

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.ViewModel\FrameworkRoleVMs\FrameworkRoleMDVM2.cs (line 63)

                     {
                         if (topdata[i].Url != null && new Regex("^" + au + "[/\\?]?", RegexOptions.IgnoreCase).IsMatch(topdata[i].Url))
                         {
▶                            topdata.RemoveAt(i);
                             i--;
                             break;
                         }

SS058 String concatenated in a loop 242 hits

📄 src\WalkingTec.Mvvm.Core\BaseVM.cs (line 323)

             var p = this;
             while (p != null && string.IsNullOrEmpty(p.PropertyNameInParent)==false)
             {
▶                rv = p.PropertyNameInParent + "." + rv;
                 p = p.ParentVM;
             }
             return rv;

📄 src\WalkingTec.Mvvm.Core\BaseImportVM.cs (line 430)

                         {
                             //保存子表字段信息稍后处理
                             ParentEntity.Add(ep.FieldName, ep);
▶                            ParentEntityValues += ep.Value;
                         }
                     }
                 }

SS059 IAsyncDisposable not disposed asynchronously 62 hits

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.ViewModel\FrameworkUserVms\FrameworkUserVM.cs (line 40)

 
         public override async Task DoAddAsync()
         {
▶            using (var trans = DC.BeginTransaction())
             {
                 if (SelectedRolesCodes != null)
                 {

💬 IDbContextTransaction can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 demo\WalkingTec.Mvvm.BlazorDemo\WalkingTec.Mvvm.BlazorDemo.ViewModel\FrameworkGroupVMs\FrameworkGroupVM.cs (line 48)

 
         public override async Task DoDeleteAsync()
         {
▶            using (var tran = DC.BeginTransaction())
             {
                 try
                 {

💬 IDbContextTransaction can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 12 hits

📄 src\WalkingTec.Mvvm.Core\Support\Quartz\WtmJob.cs (line 13)

 {
     public class WtmJob : IJob, IDisposable
     {
▶        private IServiceScope _ss;
         private WTMContext _wtm;
         protected WTMContext Wtm
         {

💬 Disposable field _ss in type WtmJob is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\WalkingTec.Mvvm.Core\Support\Quartz\WtmJob.cs (line 14)

     public class WtmJob : IJob, IDisposable
     {
         private IServiceScope _ss;
▶        private WTMContext _wtm;
         protected WTMContext Wtm
         {
             get

💬 Disposable field _wtm in type WtmJob is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

ModernWpf

1576 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 samples\MahAppsSample\ControlPages\SimpleTimePickerPage.xaml.cs (line 22)

 
         private void SetValueToNow_Click(object sender, RoutedEventArgs e)
         {
▶            TimePicker.SelectedDateTime = DateTime.Now;
         }
 
         private void ClearValue_Click(object sender, RoutedEventArgs e)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 samples\MahAppsSample\ControlPages\SimpleTimePickerPage.xaml.cs (line 22)

 
         private void SetValueToNow_Click(object sender, RoutedEventArgs e)
         {
▶            TimePicker.SelectedDateTime = DateTime.Now;
         }
 
         private void ClearValue_Click(object sender, RoutedEventArgs e)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 168 hits

📄 ModernWpf.Controls\Repeater\Layouts\UniformGridLayout\UniformGridLayoutState.cs (line 104)

 
                 var usedSpace = (numItemsPerColumn * (itemSizeMinor + minorItemSpacing)) - minorItemSpacing;
                 var remainingSpace = (int)(availableSizeMinor - usedSpace);
▶                extraMinorPixelsForEachItem = remainingSpace / ((int)numItemsPerColumn);
             }
 
             if (stretch == UniformGridLayoutItemsStretch.Fill)

💬 The operands in the divisive expression remainingSpace / ((int)numItemsPerColumn) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 ModernWpf.Controls\Repeater\Layouts\UniformGridLayout\UniformGridLayout.cs (line 284)

                 int itemsPerLine = (int)Math.Min( // note use of unsigned ints
                     Math.Max(1u, (uint)OM.Minor(availableSize) / GetMinorSizeWithSpacing(context)),
                     Math.Max(1u, m_maximumRowsOrColumns));
▶                int indexOfFirstInLine = (targetIndex / itemsPerLine) * itemsPerLine;
                 index = indexOfFirstInLine;
                 var state = GetAsGridState(context.LayoutState);
                 offset = OM.MajorStart(GetLayoutRectForDataIndex(availableSize, indexOfFirstInLine, state.FlowAlgorithm.LastExtent, context));

💬 The operands in the divisive expression targetIndex / itemsPerLine are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 16 hits

📄 ModernWpf.SampleApp\ControlPages\ListView2Page.xaml.cs (line 96)

             {
                 var item = contacts3Filtered[i];
                 // If contact is not in the filtered argument list, remove it from the ListView's source.
▶                if (!filteredData.Contains(item))
                 {
                     contacts3Filtered.Remove(item);
                 }

💬 Type Contact is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 ModernWpf.SampleApp\ControlPages\ListView2Page.xaml.cs (line 96)

             {
                 var item = contacts3Filtered[i];
                 // If contact is not in the filtered argument list, remove it from the ListView's source.
▶                if (!filteredData.Contains(item))
                 {
                     contacts3Filtered.Remove(item);
                 }

SS008 GetHashCode() refers to mutable or static member 48 hits

📄 ModernWpf\Standard\NativeMethods.cs (line 184)

 
         public override int GetHashCode()
         {
▶            return (_left << 16 | Utility.LOWORD(_right)) ^ (_top << 16 | Utility.LOWORD(_bottom));
         }
     }
 

💬 GetHashCode() refers to mutable field _left (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 ModernWpf\Standard\NativeMethods.cs (line 184)

 
         public override int GetHashCode()
         {
▶            return (_left << 16 | Utility.LOWORD(_right)) ^ (_top << 16 | Utility.LOWORD(_bottom));
         }
     }
 

💬 GetHashCode() refers to mutable field _right (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS011 OnPropertyChanged without nameof operator 4 hits

📄 test\ModernWpfTestApp\ApiTests\RepeaterTests\SelectionModelTests.cs (line 1530)

             set
             {
                 _intProperty = value;
▶                OnPropertyChanged("IntProperty");
             }
         }
 

💬 OnPropertyChanged(IntProperty) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

📄 test\ModernWpfTestApp\ApiTests\RepeaterTests\SelectionModelTests.cs (line 1530)

             set
             {
                 _intProperty = value;
▶                OnPropertyChanged("IntProperty");
             }
         }
 

💬 OnPropertyChanged(IntProperty) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 240 hits

📄 ModernWpf\MS\Win32\NativeMethodsCLR.cs (line 40)

 
         // NOTE:  this replaces the RECT struct in NativeMethodsCLR.cs because it adds an extra method IsEmpty
         [StructLayout(LayoutKind.Sequential)]
▶        public struct RECT
         {
             public int left;
             public int top;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RECT. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ModernWpf\Standard\NativeMethods.cs (line 189)

     }
 
     [StructLayout(LayoutKind.Sequential)]
▶    internal struct SIZE
     {
         public int cx;
         public int cy;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SIZE. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 292 hits

📄 ModernWpf\Controls\Primitives\CornerRadiusFilterConverter.cs (line 18)

         {
             CornerRadius result = radius;
 
▶            switch (filterKind)
             {
                 case CornerRadiusFilterKind.Top:
                     result.BottomLeft = 0;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 ModernWpf\Controls\Primitives\CornerRadiusFilterConverter.cs (line 71)

 
         private double GetDoubleValue(CornerRadius radius, CornerRadiusFilterKind filterKind)
         {
▶            switch (filterKind)
             {
                 case CornerRadiusFilterKind.TopLeftValue:
                     return radius.TopLeft;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 586 hits

📄 ModernWpf\ThemeResources.cs (line 153)

             else
             {
                 var appTheme = RequestedTheme ?? ApplicationTheme.Light;
▶                switch (appTheme)
                 {
                     case ApplicationTheme.Light:
                         EnsureLightResources();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 ModernWpf\TitleBar\TitleBarButton.cs (line 292)

 
         private IntPtr TitleBarButtonFilterMessage(IntPtr hwnd, int msg, IntPtr wParam, IntPtr lParam, ref bool handled)
         {
▶            switch ((uint)msg)
             {
                 case WM_NCHITTEST:
                     if (IsMousePositionWithin(lParam))

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 48 hits

📄 test\ModernWpfTestApp\ApiTests\CommonStylesTests.cs (line 169)

             }
         }
 
▶        public void DumpThemeResources()
         {
             RunOnUIThread.Execute(() =>
             {

💬 Method DumpThemeResources might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 test\ModernWpfTestApp\ApiTests\RepeaterTests\ViewportTests.cs (line 100)

         }
 
         // [TestMethod] Temporarily disabled for bug 18866003
▶        public void ValidateItemsRepeaterScrollHostScenario()
         {
             var realizationRects = new List<Rect>();
             var scrollViewer = (ScrollViewer)null;

💬 Method ValidateItemsRepeaterScrollHostScenario might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 90 hits

📄 ModernWpf.Controls\Common\EmptyEnumerator.cs (line 62)

             {
 #pragma warning disable 6503 // "Property get methods should not throw exceptions."
 
▶                throw new InvalidOperationException();
 
 #pragma warning restore 6503
             }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 ModernWpf.Controls\Repeater\Layouts\VirtualLayoutContextAdapter.cs (line 96)

                         }
                         else
                         {
▶                            throw new InvalidOperationException();
                         }
                     }
                 }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 12 hits

📄 ModernWpf.SampleApp\Data\DataGridDataSource.cs (line 31)

             {
                 while (!sr.EndOfStream)
                 {
▶                    string line = sr.ReadLine();
                     string[] values = line.Split(',');
 
                     _items.Add(

💬 Async overload available for StreamReader.ReadLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 ModernWpf.SampleApp\Data\DataGridDataSource.cs (line 31)

             {
                 while (!sr.EndOfStream)
                 {
▶                    string line = sr.ReadLine();
                     string[] values = line.Split(',');
 
                     _items.Add(

💬 Async overload available for StreamReader.ReadLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 test\ModernWpfTestApp\Utilities\TopLevelTestPageAttribute.cs (line 7)

 using System;
 namespace MUXControlsTestApp
 {
▶    public class TopLevelTestPageAttribute : Attribute
     {
         public string Name { get; set; } = "NoName";
 

💬 TopLevelTestPageAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 test\ModernWpfTestApp\Utilities\TopLevelTestPageAttribute.cs (line 7)

 using System;
 namespace MUXControlsTestApp
 {
▶    public class TopLevelTestPageAttribute : Attribute
     {
         public string Name { get; set; } = "NoName";
 

💬 TopLevelTestPageAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 8 hits

📄 test\ModernWpfTestApp\App.xaml.cs (line 72)

         public static void RunAfterSplashScreenDismissed(Action action)
         {
             var app = Application.Current as App;
▶            lock (app._actionsToRunAfterSplashScreenDismissedAndRootIsCreated)
             {
                 if (app._isSplashScreenDismissed && app._isRootCreated)
                 {

💬 A lock was obtained on _actionsToRunAfterSplashScreenDismissedAndRootIsCreated but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 test\ModernWpfTestApp\App.xaml.cs (line 87)

 
         private void SplashScreenDismissedAndRootCreated()
         {
▶            lock (_actionsToRunAfterSplashScreenDismissedAndRootIsCreated)
             {
                 foreach (var action in _actionsToRunAfterSplashScreenDismissedAndRootIsCreated)
                 {

SS057 Collection manipulated during traversal 24 hits

📄 ModernWpf.Controls\Repeater\ItemsRepeater\ViewManager.cs (line 193)

 
                 if (!virtInfo.IsPinned)
                 {
▶                    m_pinnedPool.RemoveAt(i);
                     --i;
 
                     // Pinning was the only thing keeping this element alive.

📄 ModernWpf.Controls\Repeater\ItemsRepeater\ViewManager.cs (line 518)

 
                 if (virtInfo.Index == index)
                 {
▶                    m_pinnedPool.RemoveAt(i);
                     element = elementInfo.PinnedElement;
                     elementInfo.VirtualizationInfo.MoveOwnershipToLayoutFromPinnedPool();
 

SS058 String concatenated in a loop 28 hits

📄 ModernWpf.Controls\Repeater\Common\IndexPath.cs (line 104)

             string result = "R";
             foreach (int index in m_path)
             {
▶                result += ".";
                 result += index;
             }
 

📄 ModernWpf.Controls\Repeater\Common\IndexPath.cs (line 105)

             foreach (int index in m_path)
             {
                 result += ".";
▶                result += index;
             }
 
             return result;

FluentFTP

1576 total diagnostics across 14 rules

SS001 Async method with void return type 14 hits

📄 FluentFTP\Monitors\AsyncFtpMonitor.cs (line 60)

 		/// <summary>
 		/// Polls the FTP folder for changes
 		/// </summary>
▶		protected virtual async void PollFolder(object state) {
 			try {
 
 				// exit if not connected

💬 Method PollFolder is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 FluentFTP\Monitors\AsyncFtpMonitor.cs (line 60)

 		/// <summary>
 		/// Polls the FTP folder for changes
 		/// </summary>
▶		protected virtual async void PollFolder(object state) {
 			try {
 
 				// exit if not connected

💬 Method PollFolder is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 280 hits

📄 FluentFTP\Streams\FtpSocketStream.cs (line 1209)

 				throw new InvalidOperationException("The base network stream is null.");
 			}
 
▶			var authStart = DateTime.Now;
 			string authType, cipherSuite;
 
 			if (Client.Config.CustomStream != null) {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 FluentFTP\Streams\FtpSocketStream.cs (line 1297)

 			}
 
 			if (Client.Config.LogDurations) {
▶				var authDuration = DateTime.Now.Subtract(authStart);
 				((IInternalFtpClient)Client).LogStatus(FtpTraceLevel.Info, "FTPS authentication successful, lib = " + authType + ", cipher suite = " + cipherSuite + " [" + authDuration.ToShortString() + "]");
 			}
 			else {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 196 hits

📄 FluentFTP\Client\Modules\FileTransferModule.cs (line 43)

 				// reduce chunk size to optimize rate control
 				const int chunkSizeMin = 64;
 				while (chunkSize > chunkSizeMin) {
▶					var chunkLenInMs = 1000L * chunkSize / rateLimitBytes;
 					if (chunkLenInMs <= rateControlResolution) {
 						break;
 					}

💬 The operands in the divisive expression 1000L * chunkSize / rateLimitBytes are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 FluentFTP\Client\BaseClient\GetReply.cs (line 148)

 						else {
 							if (elapsedTime > (previousElapsedTime + 1000)) {
 								previousElapsedTime = elapsedTime;
▶								LogWithPrefix(FtpTraceLevel.Verbose, "Waiting - " + ((timeOut - elapsedTime) / 1000).ToString() + " seconds left");
 								// if we have more then 5 seconds left, tickle the server some more
 								if (timeOut - elapsedTime >= 5000) {
 									LogWithPrefix(FtpTraceLevel.Verbose, "Sending NOOP (<-GetReply)");

💬 The operands in the divisive expression (timeOut - elapsedTime) / 1000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 56 hits

📄 FluentFTP\Model\FtpReply.cs (line 9)

 	/// <summary>
 	/// Represents a reply to an event on the server
 	/// </summary>
▶	public struct FtpReply {
 		/// <summary>
 		/// The type of response received from the last command executed
 		/// </summary>

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FtpReply. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 FluentFTP\Model\FtpLogEntry.cs (line 7)

 	/// <summary>
 	/// Metadata of a single log message.
 	/// </summary>
▶	public readonly struct FtpLogEntry {
 		public FtpTraceLevel Severity { get; }
 		public string Message { get; }
 		public Exception Exception { get; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FtpLogEntry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 168 hits

📄 FluentFTP\Client\AsyncClient\MoveDirectory.cs (line 41)

 				if (existsMode != FtpRemoteExists.NoCheck) {
 					bool destExists = await DirectoryExists(dest, token);
 					if (destExists) {
▶						switch (existsMode) {
 							case FtpRemoteExists.Overwrite:
 							case FtpRemoteExists.OverwriteInPlace:
 								await DeleteDirectory(dest, token);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 FluentFTP\Client\SyncClient\MoveDirectory.cs (line 40)

 				if (existsMode != FtpRemoteExists.NoCheck) {
 					var destExists = DirectoryExists(dest);
 					if (destExists) {
▶						switch (existsMode) {
 							case FtpRemoteExists.Overwrite:
 							case FtpRemoteExists.OverwriteInPlace:
 								DeleteDirectory(dest);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 252 hits

📄 FluentFTP\Client\Modules\ServerFeatureModule.cs (line 127)

 
 					if ((m = Regex.Match(featName, @"^HASH\s+(?<types>.*)$")).Success) {
 						foreach (var type in m.Groups["types"].Value.Split(';')) {
▶							switch (type.ToUpper().Trim()) {
 								case "SHA-1":
 								case "SHA-1*":
 									hashAlgorithms |= FtpHashAlgorithm.SHA1;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 FluentFTP\Client\AsyncClient\MoveDirectory.cs (line 41)

 				if (existsMode != FtpRemoteExists.NoCheck) {
 					bool destExists = await DirectoryExists(dest, token);
 					if (destExists) {
▶						switch (existsMode) {
 							case FtpRemoteExists.Overwrite:
 							case FtpRemoteExists.OverwriteInPlace:
 								await DeleteDirectory(dest, token);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 28 hits

📄 FluentFTP\Client\BaseClient\Properties.cs (line 286)

 				if (m_stream == null || !m_stream.IsConnected) {
 					if (Config.SelfConnectMode == FtpSelfConnectMode.Never ||
 						((Status.ConnectCount == 0) && Config.SelfConnectMode == FtpSelfConnectMode.OnConnectionLost)) {
▶						throw new FtpException("A call to Connect(...) is needed prior to calling this API!");
 					}
 
 					if (ClientType is "AsyncFtpClient") {

💬 An exception is thrown from the getter of property Capabilities (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 FluentFTP\Client\BaseClient\Properties.cs (line 324)

 				if (m_stream == null || !m_stream.IsConnected) {
 					if (Config.SelfConnectMode == FtpSelfConnectMode.Never ||
 						((Status.ConnectCount == 0) && Config.SelfConnectMode == FtpSelfConnectMode.OnConnectionLost)) {
▶						throw new FtpException("A call to Connect(...) is needed prior to calling this API!");
 					}
 
 					if (ClientType is "AsyncFtpClient") {

💬 An exception is thrown from the getter of property HashAlgorithms (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 262 hits

📄 FluentFTP\Client\Modules\ConnectModule.cs (line 256)

 						var permaEx = IsPermanentConnectionFailure(ex, config.AbortOnTimeout);
 						if (permaEx != null) {
 							if (config.CloneConnection) {
▶								conn.Dispose();
 							}
 
 							// rethrow permanent failures so caller can be made aware of it

💬 Async overload available for AsyncFtpClient.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 FluentFTP\Client\Modules\ConnectModule.cs (line 288)

 
 		Exit:
 			if (config.CloneConnection) {
▶				conn.Dispose();
 			}
 
 			return results;

💬 Async overload available for AsyncFtpClient.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 10 hits

📄 FluentFTP\Streams\FtpSocketStream.cs (line 904)

 
 			if (!Client.Status.CachedHostIpads.TryGetValue(host, out IPAddress[] ipads)) {
 #if NETSTANDARD || NET5_0_OR_GREATER
▶				ipads = Dns.GetHostAddressesAsync(host).Result;
 #else
 				ipads = Dns.GetHostAddresses(host);
 #endif

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 FluentFTP\Streams\FtpSocketStream.cs (line 904)

 
 			if (!Client.Status.CachedHostIpads.TryGetValue(host, out IPAddress[] ipads)) {
 #if NETSTANDARD || NET5_0_OR_GREATER
▶				ipads = Dns.GetHostAddressesAsync(host).Result;
 #else
 				ipads = Dns.GetHostAddresses(host);
 #endif

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS040 Unused result on immutable object 14 hits

📄 FluentFTP\Helpers\Parsers\NonStopParser.cs (line 59)

 			var owner = values[5] + values[6];
 			var permissions = "";
 			if (values.Length > 7) {
▶				values[7].Trim(TrimValues);
 			}
 
 			// create a new list item object with the parsed metadata

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 FluentFTP\Helpers\Parsers\NonStopParser.cs (line 59)

 			var owner = values[5] + values[6];
 			var permissions = "";
 			if (values.Length > 7) {
▶				values[7].Trim(TrimValues);
 			}
 
 			// create a new list item object with the parsed metadata

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS049 Comparing strings without StringComparison 14 hits

📄 FluentFTP\Helpers\Parsers\WindowsParser.cs (line 44)

 					timeColon = true;
 				}
 
▶				if (values[2].ToUpper() == DirectoryMarker || char.IsDigit(values[2][0])) {
 					dirOrFile = true;
 				}
 			}

📄 FluentFTP\Helpers\Parsers\WindowsParser.cs (line 44)

 					timeColon = true;
 				}
 
▶				if (values[2].ToUpper() == DirectoryMarker || char.IsDigit(values[2][0])) {
 					dirOrFile = true;
 				}
 			}

SS058 String concatenated in a loop 182 hits

📄 FluentFTP\Client\BaseClient\GetReply.cs (line 193)

 						continue;
 					}
 
▶					sequence += "," + response.Split(' ')[0];
 
 					if (exhaustNoop &&
 						((response.StartsWith("200") && (response.IndexOf("NOOP", StringComparison.OrdinalIgnoreCase) >= 0)) ||

📄 FluentFTP\Client\BaseClient\GetReply.cs (line 215)

 						}
 					}
 
▶					reply.InfoMessages += response + "\n";
 					lines++;
 
 					if (linesExpected > 0 && lines >= linesExpected) {

SS059 IAsyncDisposable not disposed asynchronously 24 hits

📄 FluentFTP\Client\AsyncClient\DownloadBytes.cs (line 38)

 			LogFunction(nameof(DownloadBytes), new object[] { remotePath });
 
 			// download the file from the server
▶			using (var outStream = new MemoryStream()) {
 				var ok = await DownloadFileInternalAsync(null, remotePath, outStream, restartPosition, progress, token, new FtpProgress(1, 0), 0, false, stopPosition);
 				return ok ? outStream.ToArray() : null;
 			}

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 FluentFTP\Client\AsyncClient\UploadBytes.cs (line 43)

 			LogFunction(nameof(UploadBytes), new object[] { remotePath, existsMode, createRemoteDir });
 
 			// write the file onto the server
▶			using (var ms = new MemoryStream(fileData)) {
 				ms.Position = 0;
 				return await UploadFileInternalAsync(ms, null, remotePath, createRemoteDir, existsMode, false, false, progress, token, new FtpProgress(1, 0));
 			}

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 76 hits

📄 FluentFTP\Streams\FtpSocketStream.cs (line 33)

 		/// <summary>
 		/// The client this stream is associated with
 		/// </summary>
▶		public readonly BaseFtpClient Client;
 
 		/// <summary>
 		/// This stream connection to be associated with this client

💬 Disposable field Client in type FtpSocketStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 FluentFTP\Streams\FtpDataStream.cs (line 22)

 			set => m_commandStatus = value;
 		}
 
▶		private BaseFtpClient m_control = null;
 
 		/// <summary>
 		/// Gets or sets the control connection for this data stream. Setting

💬 Disposable field m_control in type FtpDataStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

opencvsharp

1358 total diagnostics across 14 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\tools\OpenCvSharp.ReleaseMaker\Packer.cs (line 198)

 
     private static string GetBinaryDstDirName(string version)
     {
▶        var date = DateTime.Now.ToString("yyyyMMdd");
         return $"OpenCvSharp-{version}-{date}";
     }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\tools\OpenCvSharp.ReleaseMaker\Packer.cs (line 198)

 
     private static string GetBinaryDstDirName(string version)
     {
▶        var date = DateTime.Now.ToString("yyyyMMdd");
         return $"OpenCvSharp-{version}-{date}";
     }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 12 hits

📄 src\OpenCvSharp\Cv2\Cv2_core.cs (line 1006)

         NativeMethods.HandleException(
             NativeMethods.core_mixChannels(
                 srcPtr, (uint)src.Length, dstPtr, (uint)dst.Length,
▶                fromTo, (uint)(fromTo.Length / 2)));
 
         GC.KeepAlive(src);
         GC.KeepAlive(dst);

💬 The operands in the divisive expression fromTo.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\OpenCvSharp\Modules\core\Mat\Mat.cs (line 4148)

     /// <typeparam name="T"></typeparam>
     /// <returns></returns>
     public unsafe Span<T> AsSpan<T>() where T : unmanaged  
▶        => IsContinuous() ? new Span<T>(DataPointer, (int)Total() * ElemSize() / sizeof(T)) : [];
 
     #endregion
 }

💬 The operands in the divisive expression (int)Total() * ElemSize() / sizeof(T) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 6 hits

📄 src\OpenCvSharp\Fundamentals\ResourcesTracker.cs (line 25)

 
         lock (asyncLock)
         {
▶            trackedObjects.Add(obj);
         }
         return obj;
     }

💬 Type DisposableObject is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\OpenCvSharp\Fundamentals\ResourcesTracker.cs (line 25)

 
         lock (asyncLock)
         {
▶            trackedObjects.Add(obj);
         }
         return obj;
     }

SS008 GetHashCode() refers to mutable or static member 588 hits

📄 src\OpenCvSharp\Modules\imgproc\Model\CircleSegment.cs (line 98)

     /// <returns>An integer value that specifies a hash value for this object.</returns>
     public override int GetHashCode()
     {
▶        return Center.GetHashCode() + Radius.GetHashCode();
     }
 
     /// <summary>

💬 GetHashCode() refers to mutable field Center (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\OpenCvSharp\Modules\imgproc\Model\CircleSegment.cs (line 98)

     /// <returns>An integer value that specifies a hash value for this object.</returns>
     public override int GetHashCode()
     {
▶        return Center.GetHashCode() + Radius.GetHashCode();
     }
 
     /// <summary>

💬 GetHashCode() refers to mutable field Radius (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 102 hits

📄 src\OpenCvSharp\Modules\calib3d\UsacParams.cs (line 39)

 
 #pragma warning disable CA1815
 [StructLayout(LayoutKind.Sequential)]
▶public struct WUsacParams
 {
     public double Confidence;
     public int IsParallel;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct WUsacParams. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\OpenCvSharp\Modules\core\RNG.cs (line 12)

 /// </summary>
 /// <remarks>operations.hpp</remarks>
 [StructLayout(LayoutKind.Sequential)]
▶public struct RNG : IEquatable<RNG>
 {
     private ulong state;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RNG. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 6 hits

📄 src\OpenCvSharp\Modules\core\InputArray.cs (line 515)

                 return MatType.CV_64FC1;
 #else
         var code = System.Type.GetTypeCode(t);
▶        switch (code)
         {
             case TypeCode.Byte:
                 return MatType.CV_8UC1;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\OpenCvSharp\Modules\core\InputArray.cs (line 515)

                 return MatType.CV_64FC1;
 #else
         var code = System.Type.GetTypeCode(t);
▶        switch (code)
         {
             case TypeCode.Byte:
                 return MatType.CV_8UC1;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 6 hits

📄 src\OpenCvSharp\Modules\core\InputArray.cs (line 515)

                 return MatType.CV_64FC1;
 #else
         var code = System.Type.GetTypeCode(t);
▶        switch (code)
         {
             case TypeCode.Byte:
                 return MatType.CV_8UC1;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\OpenCvSharp\Modules\core\InputArray.cs (line 515)

                 return MatType.CV_64FC1;
 #else
         var code = System.Type.GetTypeCode(t);
▶        switch (code)
         {
             case TypeCode.Byte:
                 return MatType.CV_8UC1;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS022 Exception thrown from implicit operator 6 hits

📄 src\OpenCvSharp\Modules\core\MatExpr.cs (line 57)

     {
 #pragma warning disable CA1065 // TODO
         if (self is null)
▶            throw new ArgumentNullException(nameof(self));
 #pragma warning restore CA1065 
         return self.ToMat();
     }

💬 An exception is thrown from implicit operator Mat in type MatExpr (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

📄 src\OpenCvSharp\Modules\core\MatExpr.cs (line 57)

     {
 #pragma warning disable CA1065 // TODO
         if (self is null)
▶            throw new ArgumentNullException(nameof(self));
 #pragma warning restore CA1065 
         return self.ToMat();
     }

💬 An exception is thrown from implicit operator Mat in type MatExpr (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

SS023 Exception thrown from property getter 36 hits

📄 src\OpenCvSharp\Modules\core\Algorithm.cs (line 53)

         get
         {
             if (ptr == IntPtr.Zero)
▶                throw new ObjectDisposedException(GetType().Name);
 
             NativeMethods.HandleException(
                 NativeMethods.core_Algorithm_empty(ptr, out var ret));

💬 An exception is thrown from the getter of property Empty (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\OpenCvSharp\Modules\imgproc\GeneralizedHough.cs (line 19)

         get
         {
             if (ptr == IntPtr.Zero)
▶                throw new ObjectDisposedException(GetType().Name);
             NativeMethods.HandleException(
                 NativeMethods.imgproc_GeneralizedHough_getCannyLowThresh(ptr, out var ret));
             GC.KeepAlive(this);

💬 An exception is thrown from the getter of property CannyLowThresh (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS030 Exception thrown from Equals 6 hits

📄 src\OpenCvSharp\Modules\core\Mat\Mat.cs (line 1116)

     public MatExpr Equals(Mat m)
     {
         if (m is null)
▶            throw new ArgumentNullException(nameof(m));
 
         NativeMethods.HandleException(
             NativeMethods.core_Mat_operatorEQ_MatMat(ptr, m.CvPtr, out var ret));

💬 An exception is thrown from the Equals(Mat) method in type Mat (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

📄 src\OpenCvSharp\Modules\core\Mat\Mat.cs (line 1116)

     public MatExpr Equals(Mat m)
     {
         if (m is null)
▶            throw new ArgumentNullException(nameof(m));
 
         NativeMethods.HandleException(
             NativeMethods.core_Mat_operatorEQ_MatMat(ptr, m.CvPtr, out var ret));

💬 An exception is thrown from the Equals(Mat) method in type Mat (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

SS033 Async overload is available 4 hits

📄 src\tools\OpenCvSharp.NupkgBetaRemover\Program.cs (line 34)

         using (var nuspecContentStream = nuspecEntry.Open())
         using (var nuspecContentStreamReader = new StreamReader(nuspecContentStream, Encoding.UTF8))
         {
▶            nuspecContent = nuspecContentStreamReader.ReadToEnd();
         }
 
         nuspecContent = Regex.Replace(nuspecContent, @"-beta-?\d*</version>", "</version>");

💬 Async overload available for StreamReader.ReadToEnd (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\tools\OpenCvSharp.NupkgBetaRemover\Program.cs (line 48)

         using (var nuspecContentStream = nuspecEntry.Open())
         using (var nuspecContentStreamWriter = new StreamWriter(nuspecContentStream, Encoding.UTF8))
         {
▶            nuspecContentStreamWriter.Write(nuspecContent);
         }
     }
 

💬 Async overload available for StreamWriter.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS058 String concatenated in a loop 8 hits

📄 src\tools\OpenCvSharp.NupkgBetaRemover\Program.cs (line 43)

             nuspecContent = Regex.Replace(nuspecContent, @"(?<=<dependency.*version="")(?<version>\d{1,2}\.\d{1,2}\.\d{1,2}\.\d{8})(?<betaVersion>-beta-?\d*)",
                 match => match.Groups["version"].Value);
         }
▶        nuspecContent += new string(' ', 1000);
 
         using (var nuspecContentStream = nuspecEntry.Open())
         using (var nuspecContentStreamWriter = new StreamWriter(nuspecContentStream, Encoding.UTF8))

📄 src\OpenCvSharp\Modules\videoio\FourCC.cs (line 116)

         // padding
         while (code.Length < 4)
         {
▶            code += " ";
         }
 
         var value = VideoWriter.FourCC(code[0], code[1], code[2], code[3]);

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 src\tools\OpenCvSharp.NupkgBetaRemover\Program.cs (line 31)

             continue;
 
         string nuspecContent;
▶        using (var nuspecContentStream = nuspecEntry.Open())
         using (var nuspecContentStreamReader = new StreamReader(nuspecContentStream, Encoding.UTF8))
         {
             nuspecContent = nuspecContentStreamReader.ReadToEnd();

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\tools\OpenCvSharp.NupkgBetaRemover\Program.cs (line 45)

         }
         nuspecContent += new string(' ', 1000);
 
▶        using (var nuspecContentStream = nuspecEntry.Open())
         using (var nuspecContentStreamWriter = new StreamWriter(nuspecContentStream, Encoding.UTF8))
         {
             nuspecContentStreamWriter.Write(nuspecContent);

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 570 hits

📄 src\OpenCvSharp\Modules\barcode\BarcodeDetector.cs (line 12)

 /// </summary>
 public class BarcodeDetector : DisposableCvObject
 {
▶    private Ptr? objectPtr;
 
     internal BarcodeDetector(IntPtr ptr)
     {

💬 Disposable field objectPtr in type BarcodeDetector is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\OpenCvSharp\Modules\ml\NormalBayesClassifier.cs (line 10)

 /// </summary>
 public class NormalBayesClassifier : StatModel
 {
▶    private Ptr? ptrObj;
 
     /// <summary>
     /// Creates instance by raw pointer cv::ml::NormalBayesClassifier*

💬 Disposable field ptrObj in type NormalBayesClassifier is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Eto

1344 total diagnostics across 12 rules

SS003 Integer divided by integer causing implicit rounding 216 hits

📄 src\Eto\Drawing\BitmapData.cs (line 69)

 		_scanWidth = scanWidth;
 		_bitsPerPixel = bitsPerPixel;
 		_controlObject = controlObject;
▶		_bytesPerPixel = (bitsPerPixel + 7) / 8;
 		_premultipliedAlpha = premultipliedAlpha;
 	}
 

💬 The operands in the divisive expression (bitsPerPixel + 7) / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Eto\Drawing\Size.cs (line 260)

 	/// <returns>A new instance of a Size struct with the width and height of <paramref name="size"/> divided by <paramref name="factor"/></returns>
 	public static Size operator / (Size size, int factor)
 	{
▶		return new Size (size.Width / factor, size.Height / factor);
 	}
 		
 	/// <summary>

💬 The operands in the divisive expression size.Width / factor are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 8 hits

📄 src\Eto\Forms\Application.cs (line 260)

 	{
 		var window = (Window)sender;
 		window.Closed -= HandleClosed;
▶		if (windows.Contains(window))
 			windows.Remove(window);
 	}
 

💬 Type Window is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Eto\Forms\Application.cs (line 260)

 	{
 		var window = (Window)sender;
 		window.Closed -= HandleClosed;
▶		if (windows.Contains(window))
 			windows.Remove(window);
 	}
 

SS005 Equals() and GetHashCode() not implemented together 8 hits

📄 src\Eto\Forms\FileFilter.cs (line 9)

 /// <remarks>
 /// Each filter defines an option for the user to limit the selection of files in the dialog.
 /// </remarks>
▶public class FileFilter
 {
 	/// <summary>
 	/// Initializes a new instance of the <see cref="FileFilter"/> class.

💬 Equals() and GetHashcode() must be implemented together on FileFilter (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\Eto\Forms\FileFilter.cs (line 9)

 /// <remarks>
 /// Each filter defines an option for the user to limit the selection of files in the dialog.
 /// </remarks>
▶public class FileFilter
 {
 	/// <summary>
 	/// Initializes a new instance of the <see cref="FileFilter"/> class.

💬 Equals() and GetHashcode() must be implemented together on FileFilter (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 408 hits

📄 src\Eto\Drawing\ColorCMYK.cs (line 171)

 	/// </summary>
 	public override int GetHashCode ()
 	{
▶		return C.GetHashCode () ^ M.GetHashCode () ^ Y.GetHashCode () ^ K.GetHashCode () ^ A.GetHashCode ();
 	}
 
 	/// <summary>

💬 GetHashCode() refers to mutable property C (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Eto\Drawing\ColorCMYK.cs (line 171)

 	/// </summary>
 	public override int GetHashCode ()
 	{
▶		return C.GetHashCode () ^ M.GetHashCode () ^ Y.GetHashCode () ^ K.GetHashCode () ^ A.GetHashCode ();
 	}
 
 	/// <summary>

💬 GetHashCode() refers to mutable property M (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 80 hits

📄 src\Eto\EventLookup.cs (line 9)

 	static readonly Assembly etoAssembly = typeof(EventLookup).Assembly;
 	static readonly Dictionary<Type, string[]> externalEvents = new Dictionary<Type, string[]>();
 
▶	struct EventDeclaration
 	{
 		public readonly string Identifier;
 		public readonly MethodInfo Method;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EventDeclaration. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Eto\Drawing\ColorCMYK.cs (line 13)

 /// </remarks>
 /// <copyright>(c) 2014 by Curtis Wensley</copyright>
 /// <license type="BSD-3">See LICENSE for full terms</license>
▶public struct ColorCMYK : IEquatable<ColorCMYK>
 {
 	/// <summary>
 	/// Cyan component

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ColorCMYK. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 48 hits

📄 src\Eto\Forms\ThemedControls\ThemedSegmentedButtonHandler.cs (line 228)

 		{
 			selectionMode = value;
 
▶			switch (value)
 			{
 				case SegmentedSelectionMode.None:
 					ClearSelection();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Eto\Forms\Controls\TreeItem.cs (line 50)

 				return children;
 			children = new TreeItemCollection();
 			children.CollectionChanged += (sender, e) => {
▶				switch (e.Action)
 				{
 					case NotifyCollectionChangedAction.Reset:
 						foreach (var item in children)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 96 hits

📄 src\Eto\CollectionChangedHandler.cs (line 280)

 	private protected virtual void CollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
 	{
 		BeginUpdates();
▶		switch (e.Action)
 		{
 			case NotifyCollectionChangedAction.Add:
 				if (e.NewStartingIndex != -1)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Eto\Drawing\DashStyle.cs (line 60)

 			return true;
 		}
 
▶		switch (value.ToUpperInvariant())
 		{
 			case "SOLID":
 				style = DashStyles.Solid;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS022 Exception thrown from implicit operator 8 hits

📄 src\Eto\Forms\FileFilter.cs (line 73)

 	{
 		var parts = filter.Split('|');
 		if (parts.Length != 2)
▶			throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, "Filter must be in the form of '<name>|<ext>;<ext>;<ext>;'"), nameof(filter));
 
 		return new FileFilter
 		{

💬 An exception is thrown from implicit operator FileFilter in type FileFilter (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

📄 src\Eto\Forms\FileFilter.cs (line 73)

 	{
 		var parts = filter.Split('|');
 		if (parts.Length != 2)
▶			throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, "Filter must be in the form of '<name>|<ext>;<ext>;<ext>;'"), nameof(filter));
 
 		return new FileFilter
 		{

💬 An exception is thrown from implicit operator FileFilter in type FileFilter (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS022-ExceptionThrownFromImplicitOperator.md)

SS023 Exception thrown from property getter 32 hits

📄 src\Eto\Widget.cs (line 88)

 		get
 		{
 			if (IsDisposed)
▶				throw new ObjectDisposedException(GetType().FullName);
 			return _handler;
 		}
 		internal set => _handler = value;

💬 An exception is thrown from the getter of property Handler (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Eto\Platform.cs (line 422)

 			{
 				var message = "Could not detect platform. Are you missing a platform assembly?";
 				if (errors.Count > 1)
▶					throw new AggregateException(message, errors);
 				if (errors.Count == 1)
 					throw new InvalidOperationException(message, errors[0]);
 				throw new InvalidOperationException(message);

💬 An exception is thrown from the getter of property Detect (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS044 Attribute must specify [AttributeUsage] 8 hits

📄 src\Eto\PclTypes.cs (line 18)

 	/// Type converter attribute, for type converter compatibility in portable class libraries.
 	/// </summary>
 	[Obsolete("Since 2.5, Use System.ComponentModel.TypeConverterAttribute instead")]
▶	public class TypeConverterAttribute : Attribute
 	{
 		/// <summary>
 		/// Gets the name of the type for the type converter of the associated type.

💬 TypeConverterAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Eto\PclTypes.cs (line 18)

 	/// Type converter attribute, for type converter compatibility in portable class libraries.
 	/// </summary>
 	[Obsolete("Since 2.5, Use System.ComponentModel.TypeConverterAttribute instead")]
▶	public class TypeConverterAttribute : Attribute
 	{
 		/// <summary>
 		/// Gets the name of the type for the type converter of the associated type.

💬 TypeConverterAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS058 String concatenated in a loop 8 hits

📄 src\Eto\Drawing\FontConverter.cs (line 90)

 					}
 
 					if (typefaceName != null)
▶						familyName += "," + typefaceName;
 
 					typefaceName = cur;
 				}

📄 src\Eto\Drawing\FontConverter.cs (line 90)

 					}
 
 					if (typefaceName != null)
▶						familyName += "," + typefaceName;
 
 					typefaceName = cur;
 				}

SS066 Disposable field is not disposed 424 hits

📄 src\Eto\Forms\ThemedControls\ThemedFontPickerHandler.cs (line 8)

 /// </summary>
 public class ThemedFontPickerHandler : ThemedControlHandler<Button, FontPicker, FontPicker.ICallback>, FontPicker.IHandler
 {
▶	private Font font;
 	private FontDialog dialog;
 
 	/// <summary>

💬 Disposable field font in type ThemedFontPickerHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Eto\Forms\ThemedControls\ThemedFontPickerHandler.cs (line 9)

 public class ThemedFontPickerHandler : ThemedControlHandler<Button, FontPicker, FontPicker.ICallback>, FontPicker.IHandler
 {
 	private Font font;
▶	private FontDialog dialog;
 
 	/// <summary>
 	/// Initializes a new instance of the <see cref="T:Eto.Forms.ThemedControls.ThemedFontPickerHandler"/> class.

💬 Disposable field dialog in type ThemedFontPickerHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Polly

1322 total diagnostics across 10 rules

SS003 Integer divided by integer causing implicit rounding 90 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 136 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 422 hits

No source samples extracted

SS019 Switch is missing default label 24 hits

No source samples extracted

SS033 Async overload is available 318 hits

No source samples extracted

SS034 Accessing Task.Result without await 60 hits

No source samples extracted

SS035 Synchronous task wait instead of await 96 hits

No source samples extracted

SS037 HttpClient instantiated directly 10 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 56 hits

No source samples extracted

SS066 Disposable field is not disposed 110 hits

No source samples extracted

AngleSharp

1318 total diagnostics across 14 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 src\AngleSharp\Dom\Events\Event.cs (line 39)

         {
             _flags = EventFlags.None;
             _phase = EventPhase.None;
▶            _time = DateTime.Now;
             _composed = false;
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\AngleSharp\Dom\Events\Event.cs (line 39)

         {
             _flags = EventFlags.None;
             _phase = EventPhase.None;
▶            _time = DateTime.Now;
             _composed = false;
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 60 hits

📄 src\AngleSharp\Text\Punycode.cs (line 346)

 
             var k = 0u;
 
▶            delta = firstTime ? delta / Damp : delta / 2;
             delta += delta / numPoints;
 
             for (k = 0; delta > ((PunycodeBase - Tmin) * Tmax) / 2; k += PunycodeBase)

💬 The operands in the divisive expression delta / Damp are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\AngleSharp\Text\Punycode.cs (line 346)

 
             var k = 0u;
 
▶            delta = firstTime ? delta / Damp : delta / 2;
             delta += delta / numPoints;
 
             for (k = 0; delta > ((PunycodeBase - Tmin) * Tmax) / 2; k += PunycodeBase)

💬 The operands in the divisive expression delta / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 30 hits

📄 src\AngleSharp\Dom\Internal\NodeList.cs (line 74)

 
         internal void RemoveAt(Int32 index) => _entries.RemoveAt(index);
 
▶        internal Boolean Contains(Node node) => _entries.Contains(node);
 
         #endregion

💬 Type Node is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\AngleSharp\Dom\Internal\MutationHost.cs (line 41)

 
         public void Register(MutationObserver observer)
         {
▶            if (!_observers.Contains(observer))
             {
                 _observers.Add(observer);
             }

💬 Type MutationObserver is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS005 Equals() and GetHashCode() not implemented together 10 hits

📄 src\AngleSharp\Dom\Internal\Attr.cs (line 13)

     /// <summary>
     /// Represents a generic node attribute.
     /// </summary>
▶    public sealed class Attr : IAttr, IConstructableAttr
     {
         #region Fields
 

💬 Equals() and GetHashcode() must be implemented together on Attr (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\AngleSharp\Dom\Internal\Attr.cs (line 13)

     /// <summary>
     /// Represents a generic node attribute.
     /// </summary>
▶    public sealed class Attr : IAttr, IConstructableAttr
     {
         #region Fields
 

💬 Equals() and GetHashcode() must be implemented together on Attr (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 230 hits

📄 src\AngleSharp\Dom\Url.cs (line 444)

         {
             unchecked
             {
▶                var hashCode =  _fragment != null ? StringComparer.Ordinal.GetHashCode(_fragment) : 0;
                 hashCode = (hashCode * 397) ^ (_query != null ? StringComparer.Ordinal.GetHashCode(_query) : 0);
                 hashCode = (hashCode * 397) ^ (_path != null ? StringComparer.Ordinal.GetHashCode(_path) : 0);
                 hashCode = (hashCode * 397) ^ (_scheme != null ? StringComparer.OrdinalIgnoreCase.GetHashCode(_scheme) : 0);

💬 GetHashCode() refers to mutable field _fragment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\AngleSharp\Dom\Url.cs (line 444)

         {
             unchecked
             {
▶                var hashCode =  _fragment != null ? StringComparer.Ordinal.GetHashCode(_fragment) : 0;
                 hashCode = (hashCode * 397) ^ (_query != null ? StringComparer.Ordinal.GetHashCode(_query) : 0);
                 hashCode = (hashCode * 397) ^ (_path != null ? StringComparer.Ordinal.GetHashCode(_path) : 0);
                 hashCode = (hashCode * 397) ^ (_scheme != null ? StringComparer.OrdinalIgnoreCase.GetHashCode(_scheme) : 0);

💬 GetHashCode() refers to mutable field _fragment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 180 hits

📄 src\AngleSharp\Common\ArrayPoolExtensions.cs (line 14)

         return new Lease<T>(ArrayPool<T>.Shared, arr, length);
     }
 
▶    internal readonly struct Lease<T> : IDisposable
     {
         private readonly ArrayPool<T> _owner;
         private readonly T[] _data;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Lease. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\AngleSharp\Css\Parser\CssSelectorToken.cs (line 8)

     /// <summary>
     /// The CSS selector token.
     /// </summary>
▶    readonly struct CssSelectorToken
     {
         #region Fields
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CssSelectorToken. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 200 hits

📄 src\AngleSharp\Dom\NodeExtensions.cs (line 429)

             {
                 var forbidden = false;
 
▶                switch (node.NodeType)
                 {
                     case NodeType.Element:
                         forbidden = document.DocumentElement is not null || child is IDocumentType || child.IsFollowedByDoctype();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\AngleSharp\Html\Parser\HtmlTokenizer.cs (line 2956)

             var attributes = tag.Attributes;
             State = HtmlParseMode.PCData;
 
▶            switch (tag.Type)
             {
                 case HtmlTokenType.StartTag:
                     for (var i = attributes.Count - 1; i > 0; i--)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 370 hits

📄 src\AngleSharp\Html\Parser\Tokens\Struct\StructAttributes.cs (line 25)

     /// <param name="item">Attribute to add.</param>
     public void Add(MemoryHtmlAttributeToken item)
     {
▶        switch (_count)
         {
             case 0:
                 _t0 = item;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\AngleSharp\Dom\Url.cs (line 722)

 
             if (index != length)
             {
▶                switch (input[index])
                 {
                     case Symbols.QuestionMark:
                         return ParseQuery(input, index + 1, length);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 20 hits

📄 src\AngleSharp\Io\RequesterExtensions.cs (line 169)

 
         private static IDownload CheckIntegrity(this CorsRequest cors, IDownload download)
         {
▶            var response = download.Task.Result;
             var value = cors.Request.Source?.GetAttribute(AttributeNames.Integrity);
             var integrity = cors.Integrity;
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\AngleSharp\Io\RequesterExtensions.cs (line 169)

 
         private static IDownload CheckIntegrity(this CorsRequest cors, IDownload download)
         {
▶            var response = download.Task.Result;
             var value = cors.Request.Source?.GetAttribute(AttributeNames.Integrity);
             var integrity = cors.Integrity;
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS048 Locking on discouraged object (string, Type, this) 30 hits

📄 src\AngleSharp\Io\BaseLoader.cs (line 64)

         /// <param name="download">The download to add.</param>
         protected virtual void Add(IDownload download)
         {
▶            lock (this)
             {
                 _downloads.Add(download);
             }

📄 src\AngleSharp\Io\BaseLoader.cs (line 76)

         /// <param name="download">The download to remove.</param>
         protected virtual void Remove(IDownload download)
         {
▶            lock (this)
             {
                 _downloads.Remove(download);
             }

SS057 Collection manipulated during traversal 20 hits

📄 src\AngleSharp\Dom\Internal\NamedNodeMap.cs (line 72)

                 if (name.Is(_items[i].Name))
                 {
                     var attr = _items[i];
▶                    _items.RemoveAt(i);
                     attr.Container = null;
 
                     if (!suppressMutationObservers)

📄 src\AngleSharp\Dom\Internal\NamedNodeMap.cs (line 96)

                 if (localName.Is(_items[i].LocalName) && namespaceUri.Is(_items[i].NamespaceUri))
                 {
                     var attr = _items[i];
▶                    _items.RemoveAt(i);
                     attr.Container = null;
 
                     if (!suppressMutationObservers)

SS058 String concatenated in a loop 10 hits

📄 src\AngleSharp\Dom\ElementExtensions.cs (line 1593)

                 // Recreate selector path
                 if (!String.IsNullOrEmpty(path))
                 {
▶                    path = $"{name}>{path}";
                 }
                 else
                 {

📄 src\AngleSharp\Dom\ElementExtensions.cs (line 1593)

                 // Recreate selector path
                 if (!String.IsNullOrEmpty(path))
                 {
▶                    path = $"{name}>{path}";
                 }
                 else
                 {

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 src\AngleSharp\FormatExtensions.cs (line 65)

         /// <param name="stream">The output stream to use.</param>
         public static async Task ToCssAsync(this IStyleFormattable style, Stream stream)
         {
▶            using var writer = new StreamWriter(stream);
             await style.ToCssAsync(writer).ConfigureAwait(false);
         }
 

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\AngleSharp\FormatExtensions.cs (line 137)

         /// <param name="stream">The output stream to use.</param>
         public static async Task ToHtmlAsync(this IMarkupFormattable markup, Stream stream)
         {
▶            using var writer = new StreamWriter(stream);
             await markup.ToHtmlAsync(writer).ConfigureAwait(false);
         }
     }

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 140 hits

📄 src\AngleSharp\Dom\Internal\Window.cs (line 20)

     {
         #region Fields
 
▶        private readonly Document _document;
 
         private String? _name;
         private Int32 _outerHeight;

💬 Disposable field _document in type Window is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\AngleSharp\Text\TextSource.cs (line 17)

     /// </summary>
     public sealed class TextSource : ITextSource
     {
▶        private readonly WritableTextSource _writableSource;
         private readonly IReadOnlyTextSource _readOnlyTextSource;
 
         /// <summary>

💬 Disposable field _writableSource in type TextSource is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

PicView

1296 total diagnostics across 10 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 18 hits

📄 src\PicView.Core\DebugTools\DebugHelper.cs (line 35)

     public static void LogDebug(string className, string methodName, Exception exception)
     {
         Debug.WriteLine(
▶            $"\n[{DateTime.Now.ToString("T", CultureInfo.CurrentCulture)}] {className}.{methodName} exception: {exception.Message}");
         Debug.WriteLine(exception.StackTrace + Environment.NewLine);
     }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\PicView.Core\DebugTools\DebugHelper.cs (line 44)

     public static void LogDebug(string className, string methodName, string exceptionMessage)
     {
         Debug.WriteLine(
▶            $"\n[{DateTime.Now.ToString("T", CultureInfo.CurrentCulture)}] {className}.{methodName} exception: {exceptionMessage}");
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 68 hits

📄 src\PicView.Core\Extensions\FileExtensions.cs (line 23)

             return "0 B";
         }
 
▶        var magnitude = BitOperations.Log2((ulong)fileSize) / 10;
 
         return magnitude is 0 ? FormatBytes(fileSize) : FormatWithSuffix(fileSize, magnitude);
     }

💬 The operands in the divisive expression BitOperations.Log2((ulong)fileSize) / 10 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\PicView.Core\Exif\GpsHelper.cs (line 55)

                 return 0;
             }
 
▶            double degrees = rationals[0].Numerator / rationals[0].Denominator;
             double minutes = rationals[1].Numerator / rationals[1].Denominator;
             double seconds = rationals[2].Numerator / rationals[2].Denominator;
 

💬 The operands in the divisive expression rationals

SS017 Struct without Equals/GetHashCode/ToString overridden 38 hits

📄 src\PicView.Core\Gallery\GalleryThumbInfo.cs (line 12)

     /// <summary>
     /// Represents the data for a gallery thumbnail.
     /// </summary>
▶    public readonly struct GalleryThumbHolder : IEquatable<GalleryThumbHolder>
     {
         public string FileLocation { get; }
         public string FileName { get; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GalleryThumbHolder. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\PicView.Core\Navigation\FileTypeResolver.cs (line 17)

     /// </summary>
     /// <param name="type">The type of the loadable file.</param>
     /// <param name="data">The data associated with the loadable file.</param>
▶    public readonly struct FileTypeStruct(LoadAbleFileType type, string data)
     {
         /// <summary>
         /// Gets the type of the loadable file.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FileTypeStruct. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 22 hits

📄 src\PicView.Avalonia\Crop\CropResizer.cs (line 78)

             var size = Math.Max(newWidth, newHeight);
 
             // Adjust position based on resize mode to maintain the correct anchor point
▶            switch (mode)
             {
                 case CropResizeMode.TopLeft:
                     newX = originalRect.X + originalRect.Width - size;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\PicView.Avalonia\Crop\CropKeyboardManager.cs (line 20)

             return;
         }
 
▶        switch (e.Key)
         {
             case Key.Enter:
                 await vm.Crop.SaveCroppedImageAsync();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 56 hits

📄 src\PicView.Core\ViewModels\ImageInfoWindowViewModel.cs (line 55)

         TextBoxMaxWidth.Value = width < thirdBreakPoint ? 0 : TextMaxWidth;
         ExtraTextBoxMaxWidth.Value = width < fourthBreakPoint ? 0 : TextMaxWidth;
 
▶        switch (width)
         {
             case <= firstBreakPoint:
                 TextBoxWidth.Value = TextBoxXlWidth.Value = width - (textWidth + scrollBarThickness + smallPadding);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\PicView.Core.WindowsNT\FileHandling\ArchiveExtractionHelper.cs (line 102)

                 var installDir = subKey.GetValue("InstallLocation")?.ToString();
                 if (installDir == null) continue;
 
▶                switch (subKeyName)
                 {
                     case "7-Zip":
                         return Path.Combine(installDir, SevenZip);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 src\PicView.Benchmarks\StartupBenchmarks\LanguageBenchmark.cs (line 123)

 
             if (dir == null)
             {
▶                throw new DirectoryNotFoundException(
                     "Could not locate 'src' directory starting from the application base directory.");
             }
 

💬 An exception is thrown from the getter of property GetLanguagesDirectory (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\PicView.Benchmarks\StartupBenchmarks\LanguageBenchmark.cs (line 133)

 
             if (!Directory.Exists(fullPath))
             {
▶                throw new DirectoryNotFoundException($"Languages directory not found at '{fullPath}'.");
             }
 
             return fullPath;

💬 An exception is thrown from the getter of property GetLanguagesDirectory (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 10 hits

📄 src\PicView.Core\ImageEffects\ImageEffectsHelper.cs (line 40)

         if (fileInfo.Length >= 2147483648)
         {
             // ReSharper disable once MethodHasAsyncOverloadWithCancellation
▶            magick.Read(filestream);
         }
         else
         {

💬 Async overload available for MagickImage.Read (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\PicView.Core\ImageReading\MagickPerformanceReader.cs (line 55)

         // Fixes "The file is too long. This operation is currently limited to supporting files less than 2 gigabytes in size."
         await using var fileStream = FileStreamUtils.GetOptimizedFileStream(fileInfo);
         // ReSharper disable once MethodHasAsyncOverload
▶        image.Read(fileStream);
         return image;
     }
 }

💬 Async overload available for MagickImage.Read (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 src\PicView.Avalonia\Printing\PrintCore.cs (line 79)

         {
             DebugHelper.LogDebug(nameof(PrintCore), nameof(ToGrayScale), e);
             var mainVm = Dispatcher.UIThread.Invoke(() => UIHelper.GetMainView.DataContext as MainViewModel);
▶            var cached = NavigationManager.GetPreLoadValueAsync(mainVm.PicViewer.FileInfo.Value).Result;
             src = cached.ImageModel.Image as Bitmap ?? throw new NullReferenceException();
             width = src.PixelSize.Width;
             height = src.PixelSize.Height;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\PicView.Avalonia\Printing\PrintCore.cs (line 79)

         {
             DebugHelper.LogDebug(nameof(PrintCore), nameof(ToGrayScale), e);
             var mainVm = Dispatcher.UIThread.Invoke(() => UIHelper.GetMainView.DataContext as MainViewModel);
▶            var cached = NavigationManager.GetPreLoadValueAsync(mainVm.PicViewer.FileInfo.Value).Result;
             src = cached.ImageModel.Image as Bitmap ?? throw new NullReferenceException();
             width = src.PixelSize.Width;
             height = src.PixelSize.Height;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\PicView.Avalonia\Clipboard\ClipboardImageOperations.cs (line 101)

                     return string.Empty;
                 }
 
▶                using (var stream = new MemoryStream())
                 {
                     bitmap.Save(stream, 100);
                     return Convert.ToBase64String(stream.ToArray());

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\PicView.Avalonia\FileSystem\PdfExport.cs (line 44)

         
         var localPath = chosenFile.Path.LocalPath;
 
▶        using var pngStream = new MemoryStream();
         // Avalonia's Bitmap.Save writes PNG by default (no format parameter).
         bitmap.Save(pngStream);
         pngStream.Position = 0;

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 1074 hits

📄 src\PicView.Core\ViewModels\PicViewerModel.cs (line 23)

     
     public BindableReactiveProperty<FileInfo?> FileInfo { get; } = new();
 
▶    public BindableReactiveProperty<ObservableCollection<FileSearchResult>> FilteredFileInfos { get; } = new();
 
     /// <summary>
     /// The image's pixel width

💬 Disposable field FilteredFileInfos in type PicViewerModel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\PicView.Core\ViewModels\PicViewerModel.cs (line 41)

 
     public BindableReactiveProperty<ImageType> ImageType { get; } = new();
     
▶    public BindableReactiveProperty<MagickFormat?> Format { get; } = new();
 
     public BindableReactiveProperty<double> RotationAngle { get; } = new(0);

💬 Disposable field Format in type PicViewerModel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

WPF-Samples

1222 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 126 hits

📄 Sample Applications\DataBindingDemo\AddProductWindow.cs (line 26)

         private void OnInit(object sender, RoutedEventArgs e)
         {
             DataContext = new AuctionItem(null,
▶                ProductCategory.DvDs, 1, DateTime.Now, ((App) Application.Current).CurrentUser,
                 SpecialFeatures.None);
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Sample Applications\DataBindingDemo\FutureDateRule.cs (line 23)

             {
                 return new ValidationResult(false, "Value is not a valid date. Please enter a valid date");
             }
▶            if (DateTime.Now.Date > date)
             {
                 return new ValidationResult(false, "Value is not a future date. Please enter a date in the future.");
             }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 66 hits

📄 Sample Applications\FontDialog\FontChooser.cs (line 1818)

 
             while (first < limit)
             {
▶                var i = first + (limit - first)/2;
                 var item = (IComparable) (itemList[i]);
                 var comparison = item.CompareTo(value);
                 if (comparison < 0)

💬 The operands in the divisive expression (limit - first)/2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Sample Applications\LayoutTransitionsDemo\MainWindow.cs (line 151)

             {
                 var target = Targets[i] as LayoutToLayoutTarget;
                 (Hosts[i] as LayoutToLayoutHost)?.BeginAnimating(false);
▶                Grid.SetRow(target, i/5);
                 Grid.SetColumn(target, i%5);
                 LTLGrid.Children.Add(target);
             }

💬 The operands in the divisive expression i/5 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS011 OnPropertyChanged without nameof operator 242 hits

📄 Sample Applications\DataBindingDemo\AuctionItem.cs (line 41)

         public void AddBid(Bid bid)
         {
             _bids.Add(bid);
▶            OnPropertyChanged("CurrentPrice");
         }
 
         protected void OnPropertyChanged(string name)

💬 OnPropertyChanged(CurrentPrice) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

📄 Sample Applications\DataBindingDemo\AuctionItem.cs (line 62)

                     throw new ArgumentException("Item Description Should be added");
                 }
                 _description = value;
▶                OnPropertyChanged("Description");
 
             }
         }

💬 OnPropertyChanged(Description) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 56 hits

📄 Sample Applications\FontDialog\FontChooser.cs (line 357)

                 }
             }
 
▶            public struct Item
             {
                 public readonly string Tag;
                 public readonly object Value;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Item. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Sample Applications\FontDialog\FontChooser.cs (line 357)

                 }
             }
 
▶            public struct Item
             {
                 public readonly string Tag;
                 public readonly object Value;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Item. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 36 hits

📄 Sample Applications\FontDialog\FontChooser.cs (line 1856)

         // Behavior is similar to a Win32 combo box.
         private void OnComboBoxPreviewKeyDown(TextBox textBox, ListBox listBox, KeyEventArgs e)
         {
▶            switch (e.Key)
             {
                 case Key.Up:
                     // Move up from the current position.

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Sample Applications\FontDialog\FontChooser.cs (line 1856)

         // Behavior is similar to a Win32 combo box.
         private void OnComboBoxPreviewKeyDown(TextBox textBox, ListBox listBox, KeyEventArgs e)
         {
▶            switch (e.Key)
             {
                 case Key.Up:
                     // Move up from the current position.

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 248 hits

📄 Sample Applications\EditingExaminerDemo\CommandLine.cs (line 263)

             {
                 try
                 {
▶                    switch (i)
                     {
                         case 0:
                             returnValue = ReflectionUtils.GetField(objectInstance, propertyName);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Sample Applications\EditingExaminerDemo\ReflectionUtils.cs (line 717)

             newargs = null;
             instance = null;
 
▶            switch (invokeType)
             {
                 case InvokeType.StaticMethod:
                     defaultFlags |= BindingFlags.InvokeMethod;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 Sample Applications\GraphingCalculatorDemo\Parser\VariableExpression.cs (line 38)

                 {
                     return (double) Environment[_identifier];
                 }
▶                throw new UndefinedVariableException(_identifier + " is not defined");
             }
         }
 

💬 An exception is thrown from the getter of property Value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Sample Applications\GraphingCalculatorDemo\Parser\VariableExpression.cs (line 38)

                 {
                     return (double) Environment[_identifier];
                 }
▶                throw new UndefinedVariableException(_identifier + " is not defined");
             }
         }
 

💬 An exception is thrown from the getter of property Value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS049 Comparing strings without StringComparison 252 hits

📄 Sample Applications\HtmlToXamlDemo\CssStylesheet.cs (line 28)

         // for further cascading style application
         public void DiscoverStyleDefinitions(XmlElement htmlElement)
         {
▶            if (htmlElement.LocalName.ToLower() == "link")
             {
                 return;
                 //  Add LINK elements processing for included stylesheets

📄 Sample Applications\HtmlToXamlDemo\CssStylesheet.cs (line 35)

                 // <LINK href="http://sc.msn.com/global/css/ptnr/orange.css" type=text/css \r\nrel=stylesheet>
             }
 
▶            if (htmlElement.LocalName.ToLower() != "style")
             {
                 // This is not a STYLE element. Recurse into it
                 for (var htmlChildNode = htmlElement.FirstChild;

SS050 Parameter assigned in constructor 4 hits

📄 Sample Applications\GraphingCalculatorDemo\Parser\Tokenizer.cs (line 22)

         {
             if (function == null)
             {
▶                function = string.Empty;
             }
             _function = function;
             _index = 0;

💬 Suspicious assignment of parameter function in constructor of Tokenizer (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 Sample Applications\GraphingCalculatorDemo\Parser\Tokenizer.cs (line 22)

         {
             if (function == null)
             {
▶                function = string.Empty;
             }
             _function = function;
             _index = 0;

💬 Suspicious assignment of parameter function in constructor of Tokenizer (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS057 Collection manipulated during traversal 4 hits

📄 Animation\Per-FrameAnimation\ParticleEffects\FireworkEffect.cs (line 110)

 
                 //only increment counter for live particles
                 if (_timeTracker.ElapsedTime > p.DeathTime)
▶                    _particles.RemoveAt(i);
                 else
                     i++;
             }

📄 Animation\Per-FrameAnimation\ParticleEffects\FireworkEffect.cs (line 110)

 
                 //only increment counter for live particles
                 if (_timeTracker.ElapsedTime > p.DeathTime)
▶                    _particles.RemoveAt(i);
                 else
                     i++;
             }

SS058 String concatenated in a loop 140 hits

📄 Sample Applications\EditingExaminerDemo\XamlHelper.cs (line 138)

             strs = xaml.Split('<');
             for (var i = 1; i < strs.Length; i++)
             {
▶                value += ProcessEachTag(strs[i]);
             }
             return s1 + value + s2;
         }

📄 Sample Applications\EditingExaminerDemo\XamlHelper.cs (line 196)

             //Take care of properties:
             while (str.Length > 0)
             {
▶                returnValue += propertynameStart + str.Substring(0, str.IndexOf("=", StringComparison.Ordinal)) + endRun +
                                "=";
                 str = str.Substring(str.IndexOf("\"", StringComparison.Ordinal) + 1).Trim();
                 returnValue += propertyValueStart + str.Substring(0, str.IndexOf("\"", StringComparison.Ordinal)) +

SS066 Disposable field is not disposed 44 hits

📄 Documents\Fixed Documents\DocumentSerialization\HtmlXmlConverter\htmllexicalanalyzer.cs (line 746)

         #region Private Fields
 
         // string reader which will move over input text
▶        private StringReader _inputStringReader;
         // next character code read from input that is not yet part of any token
         // and the character it represents
         private int _nextCharacterCode;

💬 Disposable field _inputStringReader in type HtmlLexicalAnalyzer is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Documents\Fixed Documents\DocumentSerialization\ThumbViewer.xaml.cs (line 675)

 
         // Bookmarks and comments
         AnnotationService _annServ = null;
▶        AnnotationStore _annStore = null;
         MemoryStream _annotationBuffer = null;
 
         // filename open

💬 Disposable field _annStore in type ThumbViewer is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

subtitleedit

1112 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 54 hits

📄 src\libse\Settings\SubtitleSettings.cs (line 215)

                 CurrentDCinemaFontUri = DCinemaFontFile;
                 CurrentDCinemaFontId = "Arial";
             }
▶            CurrentDCinemaIssueDate = DateTime.Now.ToString("s");
             CurrentDCinemaMovieTitle = "title";
             CurrentDCinemaReelNumber = "1";
             CurrentDCinemaFontColor = SKColors.White;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\libse\ContainerFormats\Mp4\Mp4Parser.cs (line 109)

                     return new DateTime(1904, 1, 1, 0, 0, 0, DateTimeKind.Utc).Add(TimeSpan.FromSeconds(Moov.Mvhd.CreationTime));
                 }
 
▶                return DateTime.Now;
             }
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 240 hits

📄 src\libse\VobSub\VobSubWriter.cs (line 79)

 
         public static void WriteEndianWord(int i, Stream stream)
         {
▶            stream.WriteByte((byte)(i / 256));
             stream.WriteByte((byte)(i % 256));
         }
 

💬 The operands in the divisive expression i / 256 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\libse\VobSub\VobSubWriter.cs (line 228)

                     // write whole image in one 0x800 part
 
                     long j = (headerSize - 20) + toWrite;
▶                    subHeader[18] = (byte)(j / 0x100);
                     subHeader[19] = (byte)(j % 0x100);
 
                     // First Write header

💬 The operands in the divisive expression j / 0x100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 10 hits

📄 src\libse\GermanNouns.cs (line 26)

 
             _regularExpressionList = new Dictionary<Regex, string>
             {
▶                { new Regex(@"\bDas essen\b", RegexOptions.Compiled), "Das Essen" },
                 { new Regex(@"\bdas essen\b", RegexOptions.Compiled), "das Essen" }
             };
         }

💬 Type Regex is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\libse\GermanNouns.cs (line 27)

             _regularExpressionList = new Dictionary<Regex, string>
             {
                 { new Regex(@"\bDas essen\b", RegexOptions.Compiled), "Das Essen" },
▶                { new Regex(@"\bdas essen\b", RegexOptions.Compiled), "das Essen" }
             };
         }
 

SS005 Equals() and GetHashCode() not implemented together 2 hits

📄 src\libse\Translate\TranslationPair.cs (line 6)

 
 namespace Nikse.SubtitleEdit.Core.Translate
 {
▶    public class TranslationPair : IEquatable<TranslationPair>
     {
         public string Name { get; }
 

💬 Equals() and GetHashcode() must be implemented together on TranslationPair (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\libse\Translate\TranslationPair.cs (line 6)

 
 namespace Nikse.SubtitleEdit.Core.Translate
 {
▶    public class TranslationPair : IEquatable<TranslationPair>
     {
         public string Name { get; }
 

💬 Equals() and GetHashcode() must be implemented together on TranslationPair (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 src\libse\Common\Dimension.cs (line 36)

         {
             unchecked
             {
▶                return (Height * 397) ^ Width;
             }
         }
     }

💬 GetHashCode() refers to mutable property Height (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\libse\Common\Dimension.cs (line 36)

         {
             unchecked
             {
▶                return (Height * 397) ^ Width;
             }
         }
     }

💬 GetHashCode() refers to mutable property Width (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS015 String placeholders in wrong order 4 hits

📄 src\libse\BluRaySup\BluRaySupParser.cs (line 910)

                                     var y = BigEndianInt16(buffer, 4 + offset);
                                     var width = BigEndianInt16(buffer, 6 + offset);
                                     var height = BigEndianInt16(buffer, 8 + offset);
▶                                    log.AppendLine(string.Format("WinId: {4}, X: {0}, Y: {1}, Width: {2}, Height: {3}", x, y, width, height, windowId));
                                     offset += 9;
                                 }
                             }

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 src\libse\SubtitleFormats\UnknownSubtitle38.cs (line 26)

                 //1 00:50:34:22 00:50:39:13
                 //Ich muss dafür sorgen,
                 //dass die Epsteins weiterleben
▶                sb.AppendLine(string.Format("{4} {0} {1}{2}{3}{2}", EncodeTimeCode(p.StartTime), EncodeTimeCode(p.EndTime), Environment.NewLine, HtmlUtil.RemoveHtmlTags(p.Text), index));
                 index++;
             }
             return sb.ToString();

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 src\libse\Common\FastBitmap.cs (line 9)

 {
     public unsafe class FastBitmap
     {
▶        public struct PixelData
         {
             public byte Blue;
             public byte Green;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PixelData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\libse\Common\ZipExtractor.cs (line 34)

         /// <summary>
         /// Represents an entry in Zip file directory
         /// </summary>
▶        public struct ZipFileEntry
         {
             /// <summary>Compression method</summary>
             public Compression Method;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ZipFileEntry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 src\libse\ContainerFormats\Matroska\MatroskaFile.cs (line 95)

                    clusterNo < maxClustersToSeek &&
                    (element = ReadElement()) != null)
             {
▶                switch (element.Id)
                 {
                     case ElementId.Info:
                         ReadInfoElement(element);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\libse\ContainerFormats\Matroska\MatroskaFile.cs (line 143)

             Element element;
             while (_stream.Position < cluster.EndPosition && (element = ReadElement()) != null && !done)
             {
▶                switch (element.Id)
                 {
                     case ElementId.None:
                         done = true;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 104 hits

📄 src\libse\AutoTranslate\PapagoTranslate.cs (line 121)

                 else
                 {
                     // Handle codes that might not have a culture match
▶                    switch (code)
                     {
                         case "th":
                             result.Add(new TranslationPair("Thai", code, code));

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\libse\SubtitleFormats\YouTubeSbv.cs (line 92)

 
         private void ReadLine(Subtitle subtitle, string line, string next)
         {
▶            switch (_expecting)
             {
                 case ExpectingLine.TimeCodes:
                     if (TryReadTimeCodesLine(line, _paragraph))

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 36 hits

📄 src\libse\AutoTranslate\SeamlessM4TTranslate.cs (line 68)

             var input = "{ \"input\": { \"task_name\":\"T2TT (Text to Text translation)\", \"input_text\": \"" + Json.EncodeJsonText(text.Trim()) + "\", \"input_text_language\": \"" + sourceLanguageCode + "\", \"target_language_text_only\": \"" + targetLanguageCode + "\" }}";
             var content = new StringContent(input, Encoding.UTF8);
             content.Headers.ContentType = MediaTypeHeaderValue.Parse("application/json");
▶            var result = _httpClient.PostAsync("predictions", content).Result;
             result.EnsureSuccessStatusCode();
             var bytes = await result.Content.ReadAsByteArrayAsync();
             var json = Encoding.UTF8.GetString(bytes).Trim();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\libse\AutoTranslate\NoLanguageLeftBehindServe.cs (line 58)

             var content = new StringContent(input, Encoding.UTF8);
             content.Headers.ContentType = MediaTypeHeaderValue.Parse("application/json");
 
▶            var result = _httpClient.PostAsync("translate", content).Result;
             result.EnsureSuccessStatusCode();
             var bytes = await result.Content.ReadAsByteArrayAsync();
             var json = Encoding.UTF8.GetString(bytes).Trim();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 30 hits

📄 src\libse\SubtitleFormats\DCinemaSmpte2007.cs (line 897)

                     }
 
                     string text;
▶                    if (textLines.All(p => p.VerticalAlignment.ToLowerInvariant() == "bottom"))
                     {
                         text = string.Join(Environment.NewLine, textLines.OrderByDescending(p => p.GetVerticalPositionAsNumber()).Select(p => p.Text));
                     }

📄 src\libse\SubtitleFormats\DCinemaSmpte2014.cs (line 911)

                     }
 
                     string text;
▶                    if (textLines.All(p => p.VerticalAlignment.ToLowerInvariant() == "bottom"))
                     {
                         text = string.Join(Environment.NewLine, textLines.OrderByDescending(p => p.GetVerticalPositionAsNumber()).Select(p => p.Text));
                     }

SS057 Collection manipulated during traversal 2 hits

📄 src\libse\Common\Subtitle.cs (line 913)

                 var p = Paragraphs[i];
                 if (newParagraph.StartTime.TotalMilliseconds < p.StartTime.TotalMilliseconds)
                 {
▶                    Paragraphs.Insert(i, newParagraph);
                     return i;
                 }
             }

📄 src\libse\Common\Subtitle.cs (line 913)

                 var p = Paragraphs[i];
                 if (newParagraph.StartTime.TotalMilliseconds < p.StartTime.TotalMilliseconds)
                 {
▶                    Paragraphs.Insert(i, newParagraph);
                     return i;
                 }
             }

SS058 String concatenated in a loop 550 hits

📄 src\libse\Common\WebVttHelper.cs (line 524)

             {
                 foreach (var style in styles)
                 {
▶                    text = "<c." + style.Name.TrimStart('.') + ">" + text + "</c>";
                 }
 
                 return text;

📄 src\libse\SubtitleFormats\YouTubeTranscript.cs (line 78)

                     }
                     else
                     {
▶                        p.Text = p.Text + Environment.NewLine + s;
                     }
 
                     if (p.Text.Length > 800)

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 src\libse\Http\HttpClientDownloader.cs (line 45)

                 using (var response = await _httpClient.GetAsync(requestUri, HttpCompletionOption.ResponseHeadersRead, cancellationToken))
                 {
                     var contentLength = response.Content.Headers.ContentLength;
▶                    using (var downloadStream = await response.Content.ReadAsStreamAsync())
                     {
                         if (progress == null || !contentLength.HasValue)
                         {

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\libse\Http\HttpClientDownloader.cs (line 45)

                 using (var response = await _httpClient.GetAsync(requestUri, HttpCompletionOption.ResponseHeadersRead, cancellationToken))
                 {
                     var contentLength = response.Content.Headers.ContentLength;
▶                    using (var downloadStream = await response.Content.ReadAsStreamAsync())
                     {
                         if (progress == null || !contentLength.HasValue)
                         {

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 58 hits

📄 src\libse\AutoTranslate\SeamlessM4TTranslate.cs (line 17)

 {
     public class SeamlessM4TTranslate : IAutoTranslator, IDisposable
     {
▶        private HttpClient _httpClient;
 
         public static string StaticName { get; set; } = "SeamlessM4T";
         public override string ToString() => StaticName;

💬 Disposable field _httpClient in type SeamlessM4TTranslate is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\libse\Http\HttpClientDownloader.cs (line 14)

 {
     public class HttpClientDownloader : IDownloader
     {
▶        private readonly HttpClient _httpClient;
 
         public HttpClientDownloader(HttpClient httpClient) => _httpClient = httpClient;
 

💬 Disposable field _httpClient in type HttpClientDownloader is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

DotNetty

1080 total diagnostics across 12 rules

SS001 Async method with void return type 6 hits

📄 examples\Discard.Client\DiscardClientHandler.cs (line 36)

             this.ctx.CloseAsync();
         }
 
▶        async void GenerateTraffic()
         {
             try
             {

💬 Method GenerateTraffic is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 examples\Discard.Client\DiscardClientHandler.cs (line 36)

             this.ctx.CloseAsync();
         }
 
▶        async void GenerateTraffic()
         {
             try
             {

💬 Method GenerateTraffic is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 24 hits

📄 test\DotNetty.Tests.Common\XUnitOutputLogger.cs (line 28)

             {
                 try
                 {
▶                    this.output.WriteLine($"{DateTime.Now}\t[{logLevel.ToString()}]\t{eventId.Name}\t{this.categoryName}\t{formatter(state, exception)}\t{exception}");
                 }
                 catch (Exception ex)
                 {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 test\DotNetty.Tests.Common\XUnitOutputLogger.cs (line 28)

             {
                 try
                 {
▶                    this.output.WriteLine($"{DateTime.Now}\t[{logLevel.ToString()}]\t{eventId.Name}\t{this.categoryName}\t{formatter(state, exception)}\t{exception}");
                 }
                 catch (Exception ex)
                 {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 522 hits

📄 test\DotNetty.Common.Tests\ThreadLocalPoolTest.cs (line 277)

             }
 
             // The implementation uses maxCapacity / 2 as limit per WeakOrderQueue
▶            Assert.True(array.Length - maxCapacity / 2 <= Volatile.Read(ref instancesCount),
                 "The instances count (" + Volatile.Read(ref instancesCount) + ") must be <= array.length (" + array.Length
                 + ") - maxCapacity (" + maxCapacity + ") / 2 as we not pool all new handles" +
                 " internally");

💬 The operands in the divisive expression maxCapacity / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 test\DotNetty.Buffers.Tests\ByteBufferUtilTests.cs (line 19)

             var rand = new Random();
             rand.NextBytes(b1);
             rand.NextBytes(b2);
▶            int iB1 = b1.Length / 2;
             int iB2 = iB1 + b1.Length;
             int length = b1.Length - iB1;
             Array.Copy(b1, iB1, b2, iB2, length);

💬 The operands in the divisive expression b1.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 72 hits

📄 test\DotNetty.Codecs.Protobuf.Tests\Addressbook.cs (line 558)

         public override int GetHashCode()
         {
             int hash = 1;
▶            hash ^= people_.GetHashCode();
             return hash;
         }
 

💬 GetHashCode() refers to mutable field people_ (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 test\DotNetty.Codecs.Protobuf.Tests\Addressbook.cs (line 174)

         public override int GetHashCode()
         {
             int hash = 1;
▶            if (Name.Length != 0) hash ^= Name.GetHashCode();
             if (Id != 0) hash ^= Id.GetHashCode();
             if (Email.Length != 0) hash ^= Email.GetHashCode();
             hash ^= phones_.GetHashCode();

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS032 Thread.Sleep used in async method 6 hits

📄 test\DotNetty.Common.Tests\Concurrency\SingleThreadEventExecutorTests.cs (line 135)

             var scheduler = new SingleThreadEventExecutor("test", TimeSpan.FromMilliseconds(10));
             if (delayInMs > 0)
             {
▶                Thread.Sleep(delayInMs);
             }
             Task shutdownTask = scheduler.ShutdownGracefullyAsync(TimeSpan.FromMilliseconds(50), TimeSpan.FromSeconds(1));
             await Task.WhenAny(shutdownTask, Task.Delay(TimeSpan.FromSeconds(5)));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 test\DotNetty.Common.Tests\Concurrency\SingleThreadEventExecutorTests.cs (line 135)

             var scheduler = new SingleThreadEventExecutor("test", TimeSpan.FromMilliseconds(10));
             if (delayInMs > 0)
             {
▶                Thread.Sleep(delayInMs);
             }
             Task shutdownTask = scheduler.ShutdownGracefullyAsync(TimeSpan.FromMilliseconds(50), TimeSpan.FromSeconds(1));
             await Task.WhenAny(shutdownTask, Task.Delay(TimeSpan.FromSeconds(5)));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 20 hits

📄 test\DotNetty.Tests.Common\TaskExtensions.cs (line 38)

             {
                 if (task == await Task.WhenAny(task, Task.Delay(timeout, cts.Token)))
                 {
▶                    cts.Cancel();
                     return await task;
                 }
             }

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 test\DotNetty.Tests.Common\TaskExtensions.cs (line 52)

             {
                 if (task == await Task.WhenAny(task, Task.Delay(timeout, cts.Token)))
                 {
▶                    cts.Cancel();
                     await task;
                     return;
                 }

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 300 hits

📄 test\DotNetty.Tests.Common\ReadListeningHandler.cs (line 96)

                     throw new TimeoutException("ReceiveAsync timed out");
                 }
 
▶                return promise.Task.Result;
             }
 
             return await promise.Task;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 test\DotNetty.Tests.Common\ReadListeningHandler.cs (line 96)

                     throw new TimeoutException("ReceiveAsync timed out");
                 }
 
▶                return promise.Task.Result;
             }
 
             return await promise.Task;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 108 hits

📄 examples\Discard.Client\Program.cs (line 62)

             }
             finally
             {
▶                group.ShutdownGracefullyAsync().Wait(1000);
             }
         }
 

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 test\DotNetty.Tests.End2End\End2EndTests.cs (line 106)

             finally
             {
                 Task serverCloseTask = closeServerFunc();
▶                clientChannel?.CloseAsync().Wait(TimeSpan.FromSeconds(5));
                 group.ShutdownGracefullyAsync().Wait(TimeSpan.FromSeconds(5));
                 if (!serverCloseTask.Wait(ShutdownTimeout))
                 {

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS048 Locking on discouraged object (string, Type, this) 6 hits

📄 examples\SecureChat.Server\SecureChatServerHandler.cs (line 20)

             IChannelGroup g = group;
             if (g == null)
             {
▶                lock (this)
                 {
                     if (group == null)
                     {

📄 examples\SecureChat.Server\SecureChatServerHandler.cs (line 20)

             IChannelGroup g = group;
             if (g == null)
             {
▶                lock (this)
                 {
                     if (group == null)
                     {

SS058 String concatenated in a loop 6 hits

📄 test\DotNetty.Codecs.Http.Tests\Multipart\HttpPostRequestDecoderTest.cs (line 123)

                 strings[i] = Extradata;
                 for (int j = 0; j < i; j++)
                 {
▶                    strings[i] += '\r';
                 }
             }
 

📄 test\DotNetty.Codecs.Http.Tests\Multipart\HttpPostRequestDecoderTest.cs (line 123)

                 strings[i] = Extradata;
                 for (int j = 0; j < i; j++)
                 {
▶                    strings[i] += '\r';
                 }
             }
 

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 test\DotNetty.Buffers.Tests\UnpooledWriteStreamTests.cs (line 27)

 
             IByteBuffer buffer = Unpooled.Buffer(BufferCapacity);
             int initialWriterIndex = buffer.WriterIndex;
▶            using (var stream = new PortionedMemoryStream(bytes, Enumerable.Repeat(1, int.MaxValue).Select(_ => random.Next(1, 10240))))
             {
                 await buffer.WriteBytesAsync(stream, CopyLength);
             }

💬 PortionedMemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 test\DotNetty.Buffers.Tests\UnpooledWriteStreamTests.cs (line 27)

 
             IByteBuffer buffer = Unpooled.Buffer(BufferCapacity);
             int initialWriterIndex = buffer.WriterIndex;
▶            using (var stream = new PortionedMemoryStream(bytes, Enumerable.Repeat(1, int.MaxValue).Select(_ => random.Next(1, 10240))))
             {
                 await buffer.WriteBytesAsync(stream, CopyLength);
             }

💬 PortionedMemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 6 hits

📄 test\DotNetty.Buffers.Tests\PortionedMemoryStream.cs (line 15)

         readonly byte[] data;
         int position;
         readonly IEnumerable<ArraySegment<byte>> dataFeedSource;
▶        IEnumerator<ArraySegment<byte>> currentDataFeed;
 
         public PortionedMemoryStream(byte[] data, IEnumerable<int> readCounts)
         {

💬 Disposable field currentDataFeed in type PortionedMemoryStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 test\DotNetty.Buffers.Tests\PortionedMemoryStream.cs (line 15)

         readonly byte[] data;
         int position;
         readonly IEnumerable<ArraySegment<byte>> dataFeedSource;
▶        IEnumerator<ArraySegment<byte>> currentDataFeed;
 
         public PortionedMemoryStream(byte[] data, IEnumerable<int> readCounts)
         {

💬 Disposable field currentDataFeed in type PortionedMemoryStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Power-Fx

1014 total diagnostics across 22 rules

SS001 Async method with void return type 2 hits

📄 src\libraries\Microsoft.PowerFx.Repl\Repl.cs (line 565)

             return replResult;
         }
 
▶        public virtual async void OnFormulaUpdate(string name, FormulaValue newValue)
         {
             if (PrintResult)
             {

💬 Method OnFormulaUpdate is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\libraries\Microsoft.PowerFx.Repl\Repl.cs (line 565)

             return replResult;
         }
 
▶        public virtual async void OnFormulaUpdate(string name, FormulaValue newValue)
         {
             if (PrintResult)
             {

💬 Method OnFormulaUpdate is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 14 hits

📄 src\libraries\Microsoft.PowerFx.Interpreter\Functions\LibraryDate.cs (line 754)

 
             if (args.Length == 0)
             {
▶                var tzOffsetDays = tzInfo.GetUtcOffset(DateTime.Now).TotalDays;
                 return new NumberValue(irContext, tzOffsetDays * -1440);
             }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\IRTests\IRTests.cs (line 80)

 
             var stringVar = FormulaValue.New("lichess.org");
             var integerVar = FormulaValue.New(1);
▶            var datetimeVar = FormulaValue.New(DateTime.Now);
 
             engine.Config.SymbolTable.EnableMutationFunctions();
             engine.Config.SymbolTable.AddConstant("stringVar", stringVar);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 18 hits

📄 src\libraries\Microsoft.PowerFx.Core\Utils\RedBlackTree.cs (line 557)

                 default:
                     if ((nodeCount & 1) == 1)
                     {
▶                        half = nodeCount / 2;
                     }
                     else
                     {

💬 The operands in the divisive expression nodeCount / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\libraries\Microsoft.PowerFx.Core\Utils\RedBlackTree.cs (line 561)

                     }
                     else
                     {
▶                        half = (nodeCount + 1) / 2;
                         if (((nodeCount + 2) & (nodeCount + 1)) == 0)
                         {
                             leftColor = Color.Red;

💬 The operands in the divisive expression (nodeCount + 1) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 596 hits

📄 src\libraries\Microsoft.PowerFx.Core\Entities\QueryOptions\ExpandQueryOptions.cs (line 176)

 
         private bool AddExpand(ExpandQueryOptions expand)
         {
▶            _expands.Add(expand);
             return true;
         }
 

💬 Type ExpandQueryOptions is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\libraries\Microsoft.PowerFx.Core\Parser\TexlParser.cs (line 127)

                     if (varIdent != null)
                     {
                         // Add incomplete UDFArgs (colon & type are missing) as well, these are needed for intellisense.
▶                        args.Add(new UDFArg(varIdent.As<IdentToken>(), typeIdent: null, colonToken: null, argIndex));
                     }
 
                     // If the result was an error, keep moving cursor until end of expression

💬 Type UDFArg is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS005 Equals() and GetHashCode() not implemented together 2 hits

📄 src\libraries\Microsoft.PowerFx.Core\Utils\DPath.cs (line 20)

     [ThreadSafeImmutable]
     public struct DPath : IEquatable<DPath>, ICheckable
     {
▶        private class Node : ICheckable
         {
             public const int HashNull = 0x340CA819;
 

💬 Equals() and GetHashcode() must be implemented together on Node (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\libraries\Microsoft.PowerFx.Core\Utils\DPath.cs (line 20)

     [ThreadSafeImmutable]
     public struct DPath : IEquatable<DPath>, ICheckable
     {
▶        private class Node : ICheckable
         {
             public const int HashNull = 0x340CA819;
 

💬 Equals() and GetHashcode() must be implemented together on Node (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 86 hits

📄 src\libraries\Microsoft.PowerFx.Core\Texl\Intellisense\SignatureHelp\SignatureInformation.cs (line 80)

         /// <returns>A hash code for the current object.</returns>
         public override int GetHashCode()
         {
▶            return (Label, Documentation).GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable property Label (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\libraries\Microsoft.PowerFx.Core\Texl\Intellisense\SignatureHelp\SignatureInformation.cs (line 80)

         /// <returns>A hash code for the current object.</returns>
         public override int GetHashCode()
         {
▶            return (Label, Documentation).GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable property Documentation (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS009 Random instantiated in a loop 2 hits

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\LanguageServiceProtocol\SemanticTokensEncoderTests.cs (line 124)

             
             for (var i = 0; i < MaxOverlappingToks; i++)
             {
▶                var rand = new Random();
                 var idx = rand.Next(tokens.Count);
                 var chosenToken = tokens[idx];
                 for (var j = chosenToken.StartIndex; j < chosenToken.EndIndex; j++)

💬 Variable rand of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\LanguageServiceProtocol\SemanticTokensEncoderTests.cs (line 124)

             
             for (var i = 0; i < MaxOverlappingToks; i++)
             {
▶                var rand = new Random();
                 var idx = rand.Next(tokens.Count);
                 var chosenToken = tokens[idx];
                 for (var j = chosenToken.StartIndex; j < chosenToken.EndIndex; j++)

💬 Variable rand of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 36 hits

📄 src\libraries\Microsoft.PowerFx.Core\Entities\ColumnMetadata.cs (line 27)

         ServerGenerated = 1,
     }
 
▶    internal struct ColumnLookupMetadata
     {
         public readonly bool IsSearchable;
         public readonly bool IsSearchRequired;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ColumnLookupMetadata. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\libraries\Microsoft.PowerFx.Core\Entities\ColumnMetadata.cs (line 39)

         }
     }
 
▶    internal struct ColumnAttachmentMetadata
     {
         public readonly string ListFunctionName;
         public readonly string GetFunctionName;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ColumnAttachmentMetadata. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 32 hits

📄 src\libraries\Microsoft.PowerFx.Core\Binding\BinderUtils.cs (line 1509)

         {
             Contracts.AssertValue(node);
             nodeValue = null;
▶            switch (node.Kind)
             {
                 case NodeKind.StrLit:
                     nodeValue = node.AsStrLit().Value;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\libraries\Microsoft.PowerFx.Core\IR\CoercionMatrix.cs (line 56)

                 case DKind.Currency:
                     if (usePowerFxV1CompatibilityRules)
                     {
▶                        switch (fromType.Kind)
                         {
                             case DKind.Number:
                                 return CoercionKind.NumberToCurrency;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 80 hits

📄 src\libraries\Microsoft.PowerFx.Core\Utils\RedBlackTree.cs (line 28)

 
             var rgkvp = items.ToArray();
             var count = rgkvp.Length;
▶            switch (count)
             {
                 case 0:
                     return null;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\libraries\Microsoft.PowerFx.Core\Binding\BinderUtils.cs (line 1509)

         {
             Contracts.AssertValue(node);
             nodeValue = null;
▶            switch (node.Kind)
             {
                 case NodeKind.StrLit:
                     nodeValue = node.AsStrLit().Value;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS020 Test method without public modifier 6 hits

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\ConfigTests.cs (line 450)

         // - runtime evaluation 
         // These ignore the Threads's / Config / Engine's current culture.
         [Fact]
▶        private void MultiCulture1()
         {
             RunOnIsolatedThread(_doNotUseCulture, MultiCulture1ThreadProc);
         }

💬 Test method "MultiCulture1" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\ConfigTests.cs (line 456)

         }
 
         [Fact]
▶        private void MultiCultureWithCurrentUICulture()
         {
             // $$$ Don't use CurrentUICulture
             CultureInfo.CurrentUICulture = CultureInfo.InvariantCulture;

💬 Test method "MultiCultureWithCurrentUICulture" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS021 Test method without test attribute 4 hits

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\LanguageServiceProtocol\RedesignedLanguageServerTests\LanguageServerTestBase.cs (line 29)

 
         private TestHandlerFactory HandlerFactory { get; set; }
 
▶        public TestLogger Logger { get; set; }
 
         public TestHostTaskExecutor HostTaskExecutor { get; set; }

💬 Method set_Logger might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\LanguageServiceProtocol\RedesignedLanguageServerTests\LanguageServerTestBase.cs (line 31)

 
         public TestLogger Logger { get; set; }
 
▶        public TestHostTaskExecutor HostTaskExecutor { get; set; }
 
         public LanguageServerTestBase()
             : base()

💬 Method set_HostTaskExecutor might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 16 hits

📄 src\libraries\Microsoft.PowerFx.Core\Public\Config\ComposedReadOnlySymbolTable.cs (line 91)

                     var newHash = this.VersionHash;
                     if (newHash != current)
                     {
▶                        throw new InvalidOperationException($"Symbol Table was mutated during read.");
                     }
                 }
 

💬 An exception is thrown from the getter of property Functions (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\libraries\Microsoft.PowerFx.Core\Public\CheckResult.cs (line 249)

             {
                 if (_topLevelIdentifiers == null)
                 {
▶                    throw new InvalidOperationException($"Call {nameof(ApplyDependencyAnalysis)} first.");
                 }
 
                 return _topLevelIdentifiers;

💬 An exception is thrown from the getter of property TopLevelIdentifiers (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS027 Exception thrown from Dispose 4 hits

📄 src\libraries\Microsoft.PowerFx.Core\Annotations\GuardSingleThreaded.cs (line 44)

                 if (thisId != _currentId)
                 {
                     // Should never be possible if we use 'using' and keep Dispose() on same thread.
▶                    throw new InvalidOperationException($"Operation switched thread. Started {_currentId}. Now {thisId}.");
                 }
 
                 var oldId = Interlocked.Exchange(ref _parent._id, 0);

💬 An exception is thrown from the Dispose() method in type GuardInstance (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 src\libraries\Microsoft.PowerFx.Core\Annotations\GuardSingleThreaded.cs (line 50)

                 var oldId = Interlocked.Exchange(ref _parent._id, 0);
                 if (oldId != _currentId)
                 {
▶                    throw new InvalidOperationException($"Operation mismatched. Started {oldId}. Current {_currentId}.");
                 }
             }
         }

💬 An exception is thrown from the Dispose() method in type GuardInstance (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS032 Thread.Sleep used in async method 2 hits

📄 src\tests\Microsoft.PowerFx.Connectors.Tests.Shared\PowerAppsForMakersTests.cs (line 132)

                         {
                             double duration = double.Parse(m.Groups["d"].Value);
                             long ticks = (long)(((duration * 1.05) + 2.0) * 10000000.0);
▶                            Thread.Sleep(new TimeSpan(ticks));
 
                             tryAgain = true;
                             retryCount++;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\tests\Microsoft.PowerFx.Connectors.Tests.Shared\PowerAppsForMakersTests.cs (line 132)

                         {
                             double duration = double.Parse(m.Groups["d"].Value);
                             long ticks = (long)(((duration * 1.05) + 2.0) * 10000000.0);
▶                            Thread.Sleep(new TimeSpan(ticks));
 
                             tryAgain = true;
                             retryCount++;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 10 hits

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\MutationFunctionsTests.cs (line 567)

 
                 foreach (var row in _inner.Rows)
                 {
▶                    var value1 = row.Value.GetField(keyFieldName);
                     var value2 = recordValue.GetField(keyFieldName);
 
                     if (value1.TryGetPrimitiveValue(out object primaryKeyValue1) && value2.TryGetPrimitiveValue(out object primaryKeyValue2) && primaryKeyValue1.ToString() == primaryKeyValue2.ToString())

💬 Async overload available for RecordValue.GetField (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\MutationFunctionsTests.cs (line 568)

                 foreach (var row in _inner.Rows)
                 {
                     var value1 = row.Value.GetField(keyFieldName);
▶                    var value2 = recordValue.GetField(keyFieldName);
 
                     if (value1.TryGetPrimitiveValue(out object primaryKeyValue1) && value2.TryGetPrimitiveValue(out object primaryKeyValue2) && primaryKeyValue1.ToString() == primaryKeyValue2.ToString())
                     {

💬 Async overload available for RecordValue.GetField (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 48 hits

📄 src\libraries\Microsoft.PowerFx.Core\Public\Values\RecordValue.cs (line 165)

 
         public FormulaValue GetField(string fieldName)
         {
▶            return GetFieldAsync(fieldName, CancellationToken.None).Result;
         }
 
         /// <summary>

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\libraries\Microsoft.PowerFx.Core\Public\Values\RecordValue.cs (line 198)

         // Internal, for already verified values.
         internal FormulaValue GetField(FormulaType fieldType, string fieldName)
         {
▶            return GetFieldAsync(fieldType, fieldName, CancellationToken.None).Result;
         }
 
         internal async Task<FormulaValue> GetFieldAsync(FormulaType fieldType, string fieldName, CancellationToken cancellationToken)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 8 hits

📄 src\libraries\Microsoft.PowerFx.Interpreter\Functions\Mutation\RemoveFunction.cs (line 215)

             {
                 var lastArgValue = (string)lastArg.ToObject();
 
▶                if (lastArgValue.ToUpperInvariant() == "ALL")
                 {
                     all = true;
                     toExclude = 2;

📄 src\libraries\Microsoft.PowerFx.Interpreter\Functions\Mutation\RemoveFunction.cs (line 144)

                     {
                         var strNode = (StrLitNode)args[i];
 
▶                        if (strNode.Value.ToUpperInvariant() != "ALL")
                         {
                             fValid = false;
                             errors.EnsureError(args[i], ErrRemoveAllArg, args[i]);

SS057 Collection manipulated during traversal 2 hits

📄 src\libraries\Microsoft.PowerFx.Core\Texl\Intellisense\IntellisenseSuggestion.cs (line 290)

                 {
                     if (a._argCount < argCount)
                     {
▶                        _overloads.Remove(a);
                     }
                 }
             }

📄 src\libraries\Microsoft.PowerFx.Core\Texl\Intellisense\IntellisenseSuggestion.cs (line 290)

                 {
                     if (a._argCount < argCount)
                     {
▶                        _overloads.Remove(a);
                     }
                 }
             }

SS058 String concatenated in a loop 10 hits

📄 src\libraries\Microsoft.PowerFx.Core\Functions\TexlFunction.cs (line 528)

 
             for (var i = 0; i < args.Length; i++)
             {
▶                argHash += args[i].ToString();
             }
 
             return Hashing.HashString(argHash);

📄 src\libraries\Microsoft.PowerFx.Core\Texl\Builtins\Match.cs (line 374)

                     if (captureName == ColumnName_FullMatch.Value)
                     {
                         fullMatchHidden = true;
▶                        errorParam += ColumnName_FullMatch.Value + " ";
                     }
                     else if (captureName == ColumnName_SubMatches.Value && alteredOptions.Contains(MatchOptionChar.NumberedSubMatches))
                     {

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\tests\Microsoft.PowerFx.Connectors.Tests.Shared\Helpers\LoggingTestServer.cs (line 187)

                 using HttpRequestMessage clone = new HttpRequestMessage(request.Method, request.RequestUri);
 
                 // Copy the request's content (via a MemoryStream) into the cloned object
▶                using var ms = new MemoryStream();
                 if (request.Content != null)
                 {
                     await request.Content.CopyToAsync(ms, cancellationToken);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\tests\Microsoft.PowerFx.Connectors.Tests.Shared\LivePublicSwaggerTests.cs (line 241)

         private static async Task<OpenApiDocument> ReadSwaggerFromUrl(string url, ITestOutputHelper output)
         {
             using HttpClient http = new HttpClient();
▶            using Stream stream = await http.GetStreamAsync(new Uri(url));         
             OpenApiReaderSettings oars = new OpenApiReaderSettings() { RuleSet = ConnectorFunction.DefaultValidationRuleSet };
             ReadResult rr = await new OpenApiStreamReader(oars).ReadAsync(stream, CancellationToken.None);
             OpenApiDiagnostic diag = rr.OpenApiDiagnostic;

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 32 hits

📄 src\tools\Repl\Program.cs (line 809)

     // Implementation of ICopilotService using OpenAI Responses API
     internal class ChatGptCopilotService : ICopilotService
     {
▶        private readonly HttpClient _httpClient;
         private readonly ChatGptCredentials _credentials;
         private bool _disposed;
 

💬 Disposable field _httpClient in type ChatGptCopilotService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\tools\Repl\Program.cs (line 187)

         private class MyRepl : PowerFxREPL, IDisposable
         {
             public int _promptNumber = 1;
▶            private readonly ICopilotService _copilotService;
             private bool _disposed;
 
             public override string Prompt => _numberedPrompts ? $"\n{_promptNumber++}>> " : "\n>> ";

💬 Disposable field _copilotService in type MyRepl is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Ocelot

978 total diagnostics across 16 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 54 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 60 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 12 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 24 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 12 hits

No source samples extracted

SS019 Switch is missing default label 6 hits

No source samples extracted

SS021 Test method without test attribute 6 hits

No source samples extracted

SS033 Async overload is available 450 hits

No source samples extracted

SS034 Accessing Task.Result without await 48 hits

No source samples extracted

SS037 HttpClient instantiated directly 24 hits

No source samples extracted

SS038 HttpContext stored in a field 36 hits

No source samples extracted

SS049 Comparing strings without StringComparison 6 hits

No source samples extracted

SS054 Newtonsoft.Json mixed with System.Text.Json 18 hits

No source samples extracted

SS056 HttpRequest.Form read synchronously 6 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 48 hits

No source samples extracted

SS066 Disposable field is not disposed 168 hits

No source samples extracted

octokit.net

954 total diagnostics across 18 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 256 hits

📄 Octokit.Tests.Integration\Clients\MilestonesClientTests.cs (line 26)

     [IntegrationTest]
     public async Task CanRetrieveOneMilestone()
     {
▶        var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
         var created = await _milestonesClient.Create(_context.RepositoryOwner, _context.RepositoryName, newMilestone);
 
         var result = await _milestonesClient.Get(_context.RepositoryOwner, _context.RepositoryName, created.Number);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Octokit.Tests.Integration\Clients\MilestonesClientTests.cs (line 37)

     [IntegrationTest]
     public async Task CanRetrieveOneMilestoneWithRepositoryId()
     {
▶        var newMilestone = new NewMilestone("a milestone") { DueOn = DateTime.Now };
         var created = await _milestonesClient.Create(_context.Repository.Id, newMilestone);
 
         var result = await _milestonesClient.Get(_context.Repository.Id, created.Number);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 Octokit.AsyncPaginationExtension\PaginatedList.cs (line 25)

 
         private async Task<T?> Get(int index)
         {
▶            var page = await _pages[index / _pageSize].ConfigureAwait(false);
             index %= _pageSize;
             return page.Count > index ? page[index] : default;
         }

💬 The operands in the divisive expression index / _pageSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Octokit.AsyncPaginationExtension\PaginatedList.cs (line 25)

 
         private async Task<T?> Get(int index)
         {
▶            var page = await _pages[index / _pageSize].ConfigureAwait(false);
             index %= _pageSize;
             return page.Count > index ? page[index] : default;
         }

SS004 Elementary methods of type in collection not overridden 16 hits

📄 Octokit.Tests.Integration\Clients\ReferencesClientTests.cs (line 114)

         var firstRefsPage = await _fixture.GetAll("octokit", "octokit.net", startOptions);
         var secondRefsPage = await _fixture.GetAll("octokit", "octokit.net", skipStartOptions);
 
▶        Assert.DoesNotContain(firstRefsPage, x => secondRefsPage.Contains(x));
     }
 
     [IntegrationTest(Skip = "This is paging for a long long time")]

💬 Type Reference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Octokit.Tests.Integration\Clients\ReferencesClientTests.cs (line 172)

         var firstRefsPage = await _fixture.GetAll(7528679, startOptions);
         var secondRefsPage = await _fixture.GetAll(7528679, skipStartOptions);
 
▶        Assert.DoesNotContain(firstRefsPage, x => secondRefsPage.Contains(x));
     }
 
     [IntegrationTest]

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 Octokit\Http\ProductHeaderValue.cs (line 81)

 
         public override int GetHashCode()
         {
▶            return _productHeaderValue.GetHashCode();
         }
 
         public override string ToString()

💬 GetHashCode() refers to mutable field _productHeaderValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Octokit\Http\ProductHeaderValue.cs (line 81)

 
         public override int GetHashCode()
         {
▶            return _productHeaderValue.GetHashCode();
         }
 
         public override string ToString()

💬 GetHashCode() refers to mutable field _productHeaderValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 Octokit.Tests.Conventions\TypeExtensions.cs (line 127)

 
     public enum TypeCategory { Other, Task, GenericTask, ReadOnlyList, ClientInterface }
 
▶    public struct CustomTypeInfo
     {
         public Type Type { get; set; }
         public TypeCategory TypeCategory { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CustomTypeInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Octokit.Tests.Conventions\TypeExtensions.cs (line 127)

 
     public enum TypeCategory { Other, Task, GenericTask, ReadOnlyList, ClientInterface }
 
▶    public struct CustomTypeInfo
     {
         public Type Type { get; set; }
         public TypeCategory TypeCategory { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CustomTypeInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 Octokit\Http\ApiConnection.cs (line 672)

 
                 var response = await Connection.GetResponse<IReadOnlyList<T>>(uri, cancellationToken).ConfigureAwait(false);
 
▶                switch (response.HttpResponse.StatusCode)
                 {
                     case HttpStatusCode.Accepted:
                         continue;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Octokit\Http\ApiConnection.cs (line 672)

 
                 var response = await Connection.GetResponse<IReadOnlyList<T>>(uri, cancellationToken).ConfigureAwait(false);
 
▶                switch (response.HttpResponse.StatusCode)
                 {
                     case HttpStatusCode.Accepted:
                         continue;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 14 hits

📄 Octokit\Http\SimpleJsonSerializer.cs (line 219)

 
             private static Type GetPayloadType(string activityType)
             {
▶                switch (activityType)
                 {
                     case "CheckRunEvent":
                         return typeof(CheckRunEventPayload);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Octokit\Models\Request\ProjectCardMove.cs (line 12)

         public ProjectCardMove(ProjectCardPosition position, int columnId, long? cardId)
         {
             ColumnId = columnId;
▶            switch (position)
             {
                 case ProjectCardPosition.Top:
                     Position = "top";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 6 hits

📄 Octokit\Helpers\PropertyOrField.cs (line 104)

 
                 if (getDelegate == null)
                 {
▶                    throw new InvalidOperationException("Property and Field cannot both be null");
                 }
 
                 if (Base64Encoded)

💬 An exception is thrown from the getter of property GetDelegate (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Octokit\Helpers\PropertyOrField.cs (line 135)

                 }
                 if (setDelegate == null)
                 {
▶                    throw new InvalidOperationException("Property and Field cannot both be null");
                 }
                 if (Base64Encoded)
                 {

💬 An exception is thrown from the getter of property SetDelegate (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 24 hits

📄 Octokit.Tests.Integration\Clients\MigrationsClientTests.cs (line 138)

     {
         while (!isExported)
         {
▶            Thread.Sleep(2000);
         }
 
         var contents = await _gitHub.Migration.Migrations.GetArchive(_orgName, _migrationContext.Id);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 Octokit.Tests.Integration\Clients\MigrationsClientTests.cs (line 151)

     {
         while (!isExported)
         {
▶            Thread.Sleep(2000);
         }
 
         await _gitHub.Migration.Migrations.DeleteArchive(_orgName, _migrationContext.Id);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 6 hits

📄 Octokit.Generators\AsyncPaginationExtensionsGenerator.cs (line 70)

       {
         var type = Path.GetFileNameWithoutExtension(file);
 
▶        foreach (var line in File.ReadAllLines(file))
         {
           var match = paginatedCallRegex.Match(line);
 

💬 Async overload available for File.ReadAllLines (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Octokit.Tests.Integration\Clients\ActionsWorkflowRunsClientTests.cs (line 176)

 
             try
             {
▶                File.WriteAllBytes(tempFile, logs);
 
                 using (var archive = ZipFile.OpenRead(tempFile))
                 {

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 586 hits

📄 Octokit\Http\Connection.cs (line 713)

             {
                 var credentialTask = CredentialStore.GetCredentials();
                 if (credentialTask == null) return Credentials.Anonymous;
▶                return credentialTask.Result ?? Credentials.Anonymous;
             }
             // Note this is for convenience. We probably shouldn't allow this to be mutable.
             set

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Octokit.Tests.Integration\Clients\AssigneesClientTests.cs (line 19)

         _github = Helper.GetAuthenticatedClient();
         var repoName = Helper.MakeNameWithTimestamp("public-repo");
 
▶        _context = _github.CreateRepositoryContext(new NewRepository(repoName)).Result;
     }
 
     [IntegrationTest]

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 8 hits

📄 Octokit.Tests.Integration\Clients\RepositoriesClientTests.cs (line 722)

             using (var repoContext = await _github.CreateUserRepositoryContext())
             {
                 var reference = _github.Git.Reference.GetAll(repoContext.RepositoryOwner, repoContext.RepositoryName).Result.First();
▶                _github.Git.Reference.Create(repoContext.RepositoryId, new NewReference("refs/heads/primary", reference.Object.Sha)).Wait();
                 var update = new RepositoryUpdate() { DefaultBranch = "primary" };
 
                 var updatedRepository = await _github.Repository.Edit(repoContext.RepositoryOwner, repoContext.RepositoryName, update);

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 Octokit.Tests.Integration\Clients\RepositoriesClientTests.cs (line 737)

             using (var repoContext = await _github.CreateUserRepositoryContext())
             {
                 var reference = _github.Git.Reference.GetAll(repoContext.RepositoryOwner, repoContext.RepositoryName).Result.First();
▶                _github.Git.Reference.Create(repoContext.RepositoryId, new NewReference("refs/heads/primary", reference.Object.Sha)).Wait();
                 var update = new RepositoryUpdate() { DefaultBranch = "primary" };
 
                 var updatedRepository = await _github.Repository.Edit(repoContext.RepositoryId, update);

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS041 Unnecessary enumerable materialization 4 hits

📄 Octokit.Tests.Conventions\PreviewsTests.cs (line 79)

 
             var validHeaders = defaultHeaders.Concat(previewAcceptHeaders);
 
▶            var notAllowedHeaders = values.Values.ToList().Except(validHeaders).OrderBy(k => k);
             if (notAllowedHeaders.Any())
             {
                 throw new InvalidAcceptHeadersFound(notAllowedHeaders);

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Octokit.Tests.Conventions\PreviewsTests.cs (line 79)

 
             var validHeaders = defaultHeaders.Concat(previewAcceptHeaders);
 
▶            var notAllowedHeaders = values.Values.ToList().Except(validHeaders).OrderBy(k => k);
             if (notAllowedHeaders.Any())
             {
                 throw new InvalidAcceptHeadersFound(notAllowedHeaders);

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 Octokit.Tests.Integration\PotentiallyFlakyTestAttribute.cs (line 10)

     /// * Calls for details of repositories which already exist and was not created by the test itself (so could disappear over time)
     /// * Calls for details of users which already exist (so could disappear over time)
     /// </summary>
▶    public class PotentiallyFlakyTestAttribute : Attribute
     {
     }
 }

💬 PotentiallyFlakyTestAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 Octokit.Tests.Integration\PotentiallyFlakyTestAttribute.cs (line 10)

     /// * Calls for details of repositories which already exist and was not created by the test itself (so could disappear over time)
     /// * Calls for details of users which already exist (so could disappear over time)
     /// </summary>
▶    public class PotentiallyFlakyTestAttribute : Attribute
     {
     }
 }

💬 PotentiallyFlakyTestAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 4 hits

📄 Octokit.Tests.Conventions\TypeExtensions.cs (line 30)

             // the same effect as cancelling the token, so we should
             // think about how we want to ensure these conventions are
             // validated
▶            return type.GetMethods().OrderBy(m => m.Name)
                 .Where(m => m.GetParameters().All(p => p.ParameterType != typeof(CancellationToken)))
                 .ToArray();
         }

📄 Octokit.Tests.Conventions\TypeExtensions.cs (line 30)

             // the same effect as cancelling the token, so we should
             // think about how we want to ensure these conventions are
             // validated
▶            return type.GetMethods().OrderBy(m => m.Name)
                 .Where(m => m.GetParameters().All(p => p.ParameterType != typeof(CancellationToken)))
                 .ToArray();
         }

SS058 String concatenated in a loop 4 hits

📄 Octokit\Helpers\StringExtensions.cs (line 61)

                     var parameterProperty = values.GetType().GetProperty(parameter);
                     if (parameterProperty != null)
                     {
▶                        expansion += string.IsNullOrWhiteSpace(expansion) ? "?" : "&";
                         expansion += parameter + "=" +
                             Uri.EscapeDataString("" + parameterProperty.GetValue(values, new object[0]));
                     }

📄 Octokit\Helpers\StringExtensions.cs (line 62)

                     if (parameterProperty != null)
                     {
                         expansion += string.IsNullOrWhiteSpace(expansion) ? "?" : "&";
▶                        expansion += parameter + "=" +
                             Uri.EscapeDataString("" + parameterProperty.GetValue(values, new object[0]));
                     }
                 }

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 Octokit.Tests.Integration\Clients\ReleasesClientTests.cs (line 667)

 
             string textContent;
 
▶            using (var zipstream = new MemoryStream((byte[])response.Body))
             using (var archive = new ZipArchive(zipstream))
             {
                 var entry = archive.Entries[0];

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Octokit.Tests.Integration\Clients\ReleasesClientTests.cs (line 667)

 
             string textContent;
 
▶            using (var zipstream = new MemoryStream((byte[])response.Body))
             using (var archive = new ZipArchive(zipstream))
             {
                 var entry = archive.Entries[0];

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 8 hits

📄 Octokit.Tests\Http\RedirectHandlerTests.cs (line 181)

 
     public class MockRedirectHandler : HttpMessageHandler
     {
▶        readonly HttpResponseMessage _response1;
         readonly HttpResponseMessage _response2;
         private bool _Response1Sent;
 

💬 Disposable field _response1 in type MockRedirectHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Octokit.Tests\Http\RedirectHandlerTests.cs (line 182)

     public class MockRedirectHandler : HttpMessageHandler
     {
         readonly HttpResponseMessage _response1;
▶        readonly HttpResponseMessage _response2;
         private bool _Response1Sent;
 
         public MockRedirectHandler(HttpResponseMessage response1, HttpResponseMessage response2 = null)

💬 Disposable field _response2 in type MockRedirectHandler is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

MessagePack-CSharp

938 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 284 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 48 hits

No source samples extracted

SS006 Throwing null will always result in a runtime exception 24 hits

No source samples extracted

SS007 [Flags] enum values are not powers of two 6 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 4 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 212 hits

No source samples extracted

SS018 Switch does not handle all enum options 2 hits

No source samples extracted

SS019 Switch is missing default label 44 hits

No source samples extracted

SS033 Async overload is available 2 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 10 hits

No source samples extracted

SS046 Unbounded stackalloc 240 hits

No source samples extracted

SS047 LINQ traversal before filter 24 hits

No source samples extracted

SS048 Locking on discouraged object (string, Type, this) 24 hits

No source samples extracted

SS066 Disposable field is not disposed 12 hits

No source samples extracted

NLog

910 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 16 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 102 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 64 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 8 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 316 hits

No source samples extracted

SS018 Switch does not handle all enum options 8 hits

No source samples extracted

SS019 Switch is missing default label 126 hits

No source samples extracted

SS023 Exception thrown from property getter 24 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 8 hits

No source samples extracted

SS057 Collection manipulated during traversal 16 hits

No source samples extracted

SS058 String concatenated in a loop 52 hits

No source samples extracted

SS066 Disposable field is not disposed 170 hits

No source samples extracted

quartznet

892 total diagnostics across 13 rules

SS003 Integer divided by integer causing implicit rounding 64 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 148 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 56 hits

No source samples extracted

SS018 Switch does not handle all enum options 4 hits

No source samples extracted

SS019 Switch is missing default label 28 hits

No source samples extracted

SS033 Async overload is available 12 hits

No source samples extracted

SS034 Accessing Task.Result without await 4 hits

No source samples extracted

SS048 Locking on discouraged object (string, Type, this) 4 hits

No source samples extracted

SS051 Locking on mutable reference 12 hits

No source samples extracted

SS058 String concatenated in a loop 4 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 532 hits

No source samples extracted

SS064 Unnecessary ToString() on Span 4 hits

No source samples extracted

SS066 Disposable field is not disposed 20 hits

No source samples extracted

ClosedXML

858 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 64 hits

📄 ClosedXML\Excel\CalcEngine\ScalarValue.cs (line 311)

             // Format 17 'mmm-yy'
             if (DateTime.TryParseExact(text, new[] { "MMM-y", "MMMM-y" }, culture, dateStyle, out var dateFormat17))
             {
▶                if (dateFormat17.Year != DateTime.Now.Year && dateFormat17.Year >= 2030)
                     dateFormat17 = dateFormat17.AddYears(-100);
 
                 return ToSerialDate(dateFormat17, out serialDateTime);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 ClosedXML\Excel\CalcEngine\Functions\DateAndTime.cs (line 381)

 
         private static ScalarValue Now()
         {
▶            return DateTime.Now.ToSerialDateTime();
         }
 
         private static ScalarValue Second(CalcContext ctx, double serialDate)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 168 hits

📄 ClosedXML\Excel\Coordinates\Emu.cs (line 15)

     private const int PerInch = 914400;
     private const int PerCm = 360000;
     private const int PerMm = PerCm / 10;
▶    private const int PerPt = PerInch / 72;
     private const int PerPc = PerInch / 6;
 
     private readonly AbsLengthUnit _preferredUnit;

💬 The operands in the divisive expression PerInch / 72 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 ClosedXML\Excel\Coordinates\Emu.cs (line 16)

     private const int PerCm = 360000;
     private const int PerMm = PerCm / 10;
     private const int PerPt = PerInch / 72;
▶    private const int PerPc = PerInch / 6;
 
     private readonly AbsLengthUnit _preferredUnit;
 

💬 The operands in the divisive expression PerInch / 6 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 74 hits

📄 ClosedXML\Excel\CalcEngine\Reference.cs (line 90)

         {
             var lhsWorksheets = lhs.Areas.Count == 1
                 ? lhs.Areas.Select(a => a.Worksheet).Where(ws => ws is not null).ToList()!
▶                : lhs.Areas.Select(a => a.Worksheet ?? contextWorksheet).Where(ws => ws is not null).Distinct().ToList();
             if (lhsWorksheets.Count() > 1)
                 return XLError.IncompatibleValue;
 

💬 Type XLWorksheet is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 ClosedXML\Excel\CalcEngine\Reference.cs (line 98)

 
             var rhsWorksheets = rhs.Areas.Count == 1
                 ? rhs.Areas.Select(a => a.Worksheet).Where(ws => ws is not null).ToList()!
▶                : rhs.Areas.Select(a => a.Worksheet ?? contextWorksheet).Where(ws => ws is not null).Distinct().ToList();
             if (rhsWorksheets.Count() > 1)
                 return XLError.IncompatibleValue;
 

SS008 GetHashCode() refers to mutable or static member 208 hits

📄 ClosedXML\Excel\Cells\SharedStringTable.cs (line 179)

             {
                 unchecked
                 {
▶                    return ((Value is not null ? Value.GetHashCode() : 0) * 397) ^ Inline.GetHashCode();
                 }
             }
         }

💬 GetHashCode() refers to mutable field Value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 ClosedXML\Excel\Cells\SharedStringTable.cs (line 179)

             {
                 unchecked
                 {
▶                    return ((Value is not null ? Value.GetHashCode() : 0) * 397) ^ Inline.GetHashCode();
                 }
             }
         }

💬 GetHashCode() refers to mutable field Value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 122 hits

📄 ClosedXML.IO.CodeGen\Unit.cs (line 6)

 /// <summary>
 /// A type to use in generics instead of <c>void</c>.
 /// </summary>
▶internal struct Unit
 {
     public static readonly Unit Value = new();
 };

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Unit. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ClosedXML\Graphics\Dpi.cs (line 8)

     /// <summary>
     /// A DPI resolution.
     /// </summary>
▶    public readonly struct Dpi
     {
         /// <summary>
         /// Horizontal DPI resolution.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Dpi. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 28 hits

📄 ClosedXML.IO\XmlTreeReader.cs (line 251)

         {
             // All unspecified nodes should be skipped. It is either comments, processing
             // instructions or something that shouldn't ever happen (e.g. attribute).
▶            switch (nodeType)
             {
                 case XmlNodeType.Text:
                 case XmlNodeType.Whitespace:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 ClosedXML.IO\XmlTreeReader.cs (line 251)

         {
             // All unspecified nodes should be skipped. It is either comments, processing
             // instructions or something that shouldn't ever happen (e.g. attribute).
▶            switch (nodeType)
             {
                 case XmlNodeType.Text:
                 case XmlNodeType.Whitespace:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 100 hits

📄 ClosedXML.IO\XmlTreeReader.cs (line 251)

         {
             // All unspecified nodes should be skipped. It is either comments, processing
             // instructions or something that shouldn't ever happen (e.g. attribute).
▶            switch (nodeType)
             {
                 case XmlNodeType.Text:
                 case XmlNodeType.Whitespace:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 ClosedXML.IO\XmlTreeReader.cs (line 251)

         {
             // All unspecified nodes should be skipped. It is either comments, processing
             // instructions or something that shouldn't ever happen (e.g. attribute).
▶            switch (nodeType)
             {
                 case XmlNodeType.Text:
                 case XmlNodeType.Whitespace:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 8 hits

📄 ClosedXML.Tests\Examples\ColumnsTests.cs (line 35)

         }
 
         //[Test] // Not working yet
▶        public void InsertColumns()
         {
             TestHelper.RunTestExample<InsertColumns>(@"Columns\InsertColumns.xlsx");
         }

💬 Method InsertColumns might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 ClosedXML.Tests\Examples\RowsTests.cs (line 29)

         }
 
         //[Test] // Not working yet
▶        public void InsertRows()
         {
             TestHelper.RunTestExample<InsertRows>(@"Rows\InsertRows.xlsx");
         }

💬 Method InsertRows might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 44 hits

📄 ClosedXML\Excel\Hyperlinks\XLHyperlink_public.cs (line 103)

                 }
 
                 if (Container is null)
▶                    throw new InvalidOperationException("Hyperlink is not attached to a worksheet.");
 
                 var sheetName = Container.WorksheetName;
                 return String.Concat(

💬 An exception is thrown from the getter of property InternalAddress (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 ClosedXML\Excel\Style\Colors\XLColor_Public.cs (line 45)

             get
             {
                 if (ColorType == XLColorType.Theme)
▶                    throw new InvalidOperationException("Cannot convert theme color to Color.");
 
                 if (ColorType == XLColorType.Indexed)
                     return IndexedColors[Indexed].Color;

💬 An exception is thrown from the getter of property Color (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS046 Unbounded stackalloc 8 hits

📄 ClosedXML\Excel\Cells\XLCell.cs (line 2057)

                 // If we have more than 1 code unit per grapheme, the code units can
                 // be distributed through multiple grapheme. In the worst case, all extra
                 // code units are in exactly one grapheme -> allocate buffer of that size.
▶                Span<int> codePointsBuffer = stackalloc int[1 + text.Length - graphemeStarts.Length];
                 for (var i = 0; i < graphemeStarts.Length; ++i)
                 {
                     var startIdx = graphemeStarts[i];

📄 ClosedXML\Excel\CalcEngine\Functions\Text.cs (line 678)

                 return XLError.IncompatibleValue;
 
             // Process by ODF specification. Add one character for optional 0 before decimal.
▶            Span<char> textSpan = stackalloc char[text.Length + 1];
             var newLength = 0;
             var decimalSeen = false;
             foreach (var c in text)

SS049 Comparing strings without StringComparison 16 hits

📄 ClosedXML\Excel\XLWorkbook_Load.cs (line 839)

         {
             var moveWithCellsElement = clientData.Elements().FirstOrDefault(e => e.Name.LocalName == "MoveWithCells");
             var sizeWithCellsElement = clientData.Elements().FirstOrDefault(e => e.Name.LocalName == "SizeWithCells");
▶            Boolean moveWithCells = !(moveWithCellsElement != null && moveWithCellsElement.Value.ToLower() == "true");
             Boolean sizeWithCells = !(sizeWithCellsElement != null && sizeWithCellsElement.Value.ToLower() == "true");
             if (moveWithCells && !sizeWithCells)
                 drawing.Style.Properties.Positioning = XLDrawingAnchor.MoveWithCells;

📄 ClosedXML\Excel\XLWorkbook_Load.cs (line 840)

             var moveWithCellsElement = clientData.Elements().FirstOrDefault(e => e.Name.LocalName == "MoveWithCells");
             var sizeWithCellsElement = clientData.Elements().FirstOrDefault(e => e.Name.LocalName == "SizeWithCells");
             Boolean moveWithCells = !(moveWithCellsElement != null && moveWithCellsElement.Value.ToLower() == "true");
▶            Boolean sizeWithCells = !(sizeWithCellsElement != null && sizeWithCellsElement.Value.ToLower() == "true");
             if (moveWithCells && !sizeWithCells)
                 drawing.Style.Properties.Positioning = XLDrawingAnchor.MoveWithCells;
             else if (moveWithCells && sizeWithCells)

SS057 Collection manipulated during traversal 4 hits

📄 ClosedXML\Excel\CalcEngine\DependencyTree.cs (line 257)

                     _dependents[i] = _dependents[_dependents.Count - 1];
 
                     // Remove last item, capacity is unchanged, only list size is updated.
▶                    _dependents.RemoveAt(_dependents.Count - 1);
                 }
             }
 

📄 ClosedXML\Excel\CalcEngine\DependencyTree.cs (line 257)

                     _dependents[i] = _dependents[_dependents.Count - 1];
 
                     // Remove last item, capacity is unchanged, only list size is updated.
▶                    _dependents.RemoveAt(_dependents.Count - 1);
                 }
             }
 

SS058 String concatenated in a loop 8 hits

📄 ClosedXML.IO\XmlTreeReader.cs (line 260)

                     if (value.Length == 0)
                         value = _reader.Value;
                     else
▶                        value += _reader.Value;
                     break;
                 case XmlNodeType.EntityReference:
                     value += _reader.Name; // Does it even work? I have no idea how to get this node.

📄 ClosedXML.IO\XmlTreeReader.cs (line 260)

                     if (value.Length == 0)
                         value = _reader.Value;
                     else
▶                        value += _reader.Value;
                     break;
                 case XmlNodeType.EntityReference:
                     value += _reader.Name; // Does it even work? I have no idea how to get this node.

SS064 Unnecessary ToString() on Span 2 hits

📄 ClosedXML\Excel\CalcEngine\Functions\Text.cs (line 717)

                 percentCount++;
             }
 
▶            if (!double.TryParse(textSpan.ToString(), NumberStyles.Float | NumberStyles.AllowParentheses, CultureInfo.InvariantCulture, out var number))
                 return XLError.IncompatibleValue;
 
             // Too large exponent can return infinity

💬 Unnecessary ToString() call, an overload that accepts Span<char> is available (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS064-UnnecessaryToStringOnSpan.md)

📄 ClosedXML\Excel\CalcEngine\Functions\Text.cs (line 717)

                 percentCount++;
             }
 
▶            if (!double.TryParse(textSpan.ToString(), NumberStyles.Float | NumberStyles.AllowParentheses, CultureInfo.InvariantCulture, out var number))
                 return XLError.IncompatibleValue;
 
             // Too large exponent can return infinity

💬 Unnecessary ToString() call, an overload that accepts Span<char> is available (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS064-UnnecessaryToStringOnSpan.md)

SS066 Disposable field is not disposed 4 hits

📄 ClosedXML\Excel\XLWorkbook.cs (line 728)

 
         private XLLoadSource _loadSource = XLLoadSource.New;
         private String _originalFile;
▶        private Stream _originalStream;
         private XLWorkbookProtection _workbookProtection;
 
         #endregion Fields

💬 Disposable field _originalStream in type XLWorkbook is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 ClosedXML\Excel\XLWorkbook.cs (line 728)

 
         private XLLoadSource _loadSource = XLLoadSource.New;
         private String _originalFile;
▶        private Stream _originalStream;
         private XLWorkbookProtection _workbookProtection;
 
         #endregion Fields

💬 Disposable field _originalStream in type XLWorkbook is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

opentk

836 total diagnostics across 13 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\Generator.Bind\Main.cs (line 207)

 
                 foreach (var generator in Generators)
                 {
▶                    long ticks = DateTime.Now.Ticks;
 
                     generator.Process();

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Generator.Bind\Main.cs (line 214)

                     var writer = new CSharpSpecWriter();
                     writer.WriteBindings(generator);
 
▶                    ticks = DateTime.Now.Ticks - ticks;
 
                     Console.WriteLine();
                     Console.WriteLine("Bindings generated in {0} seconds.", ticks / (double)10000000.0);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 84 hits

📄 src\OpenTK.Mathematics\Vector\Vector4i.cs (line 364)

         /// <param name="result">Result of the operation.</param>
         public static void Divide(in Vector4i vector, int scale, out Vector4i result)
         {
▶            result.X = vector.X / scale;
             result.Y = vector.Y / scale;
             result.Z = vector.Z / scale;
             result.W = vector.W / scale;

💬 The operands in the divisive expression vector.X / scale are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\OpenTK.Mathematics\Vector\Vector4i.cs (line 365)

         public static void Divide(in Vector4i vector, int scale, out Vector4i result)
         {
             result.X = vector.X / scale;
▶            result.Y = vector.Y / scale;
             result.Z = vector.Z / scale;
             result.W = vector.W / scale;
         }

💬 The operands in the divisive expression vector.Y / scale are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 src\Generator.Rewrite\Program.cs (line 193)

                                 {
                                     if (method.HasPInvokeInfo)
                                     {
▶                                        if (removedModuleReferences.Contains(method.PInvokeInfo.Module))
                                         {
                                             Console.Error.WriteLine($"The method {method} still references a removed ModuleReference {method.PInvokeInfo.Module}");
                                         }

💬 Type ModuleReference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Generator.Bind\CSharpSpecWriter.cs (line 236)

             // Emit native signatures.
             // These are required by the patcher.
             int current_signature = 0;
▶            foreach (var d in wrappers.Values.SelectMany(e => e).Select(w => w.WrappedDelegate).Distinct())
             {
                 sw.WriteLine("[Slot({0})]", d.Slot);
                 sw.WriteLine("[DllImport(Library, ExactSpelling = true, CallingConvention = CallingConvention.Winapi)]");

💬 Type Delegate is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 486 hits

📄 src\OpenTK.Mathematics\Data\Color4.cs (line 189)

         /// <returns>A System.Int32 containing the hashcode of this Color4 structure.</returns>
         public override readonly int GetHashCode()
         {
▶            return HashCode.Combine(R, G, B, A);
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field R (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\OpenTK.Mathematics\Data\Color4.cs (line 189)

         /// <returns>A System.Int32 containing the hashcode of this Color4 structure.</returns>
         public override readonly int GetHashCode()
         {
▶            return HashCode.Combine(R, G, B, A);
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field G (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS015 String placeholders in wrong order 64 hits

📄 src\OpenTK.Mathematics\Vector\Vector4i.cs (line 1855)

         /// <inheritdoc />
         public readonly string ToString(string format, IFormatProvider formatProvider)
         {
▶            return string.Format(
                 "({0}{4} {1}{4} {2}{4} {3})",
                 X.ToString(format, formatProvider),
                 Y.ToString(format, formatProvider),

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 src\OpenTK.Mathematics\Vector\Vector2b.cs (line 359)

         /// <inheritdoc cref="IFormattable.ToString(string?, IFormatProvider?)"/>
         public readonly string ToString(IFormatProvider formatProvider)
         {
▶            return string.Format(
                 "({0}{2} {1})",
                 X.ToString(formatProvider),
                 Y.ToString(formatProvider),

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 132 hits

📄 src\OpenTK.Mathematics\Geometry\BezierCurveCubic.cs (line 18)

     /// Represents a cubic bezier curve with two anchor and two control points.
     /// </summary>
     [Serializable]
▶    public struct BezierCurveCubic
     {
         /// <summary>
         /// Start anchor point.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BezierCurveCubic. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\OpenTK.Mathematics\Geometry\BezierCurveQuadric.cs (line 18)

     /// Represents a quadric bezier curve with two anchor and one control point.
     /// </summary>
     [Serializable]
▶    public struct BezierCurveQuadric
     {
         /// <summary>
         /// Start anchor point.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BezierCurveQuadric. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 src\OpenTK.Input\Hid\HidHelper.cs (line 18)

         /// <returns>An <see cref="int"/> that maps the HID usage value to a joystick axis.</returns>
         public static int TranslateJoystickAxis(HidPage page, int usage)
         {
▶            switch (page)
             {
                 case HidPage.GenericDesktop:
                     switch ((HidGenericDesktopUsage)usage)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\OpenTK.Input\Hid\HidHelper.cs (line 21)

             switch (page)
             {
                 case HidPage.GenericDesktop:
▶                    switch ((HidGenericDesktopUsage)usage)
                     {
                         case HidGenericDesktopUsage.X:
                             return 0;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 24 hits

📄 src\OpenTK.Input\Hid\HidHelper.cs (line 18)

         /// <returns>An <see cref="int"/> that maps the HID usage value to a joystick axis.</returns>
         public static int TranslateJoystickAxis(HidPage page, int usage)
         {
▶            switch (page)
             {
                 case HidPage.GenericDesktop:
                     switch ((HidGenericDesktopUsage)usage)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\OpenTK.Input\Hid\HidHelper.cs (line 21)

             switch (page)
             {
                 case HidPage.GenericDesktop:
▶                    switch ((HidGenericDesktopUsage)usage)
                     {
                         case HidGenericDesktopUsage.X:
                             return 0;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 115)

             {
                 if (Context == null)
                 {
▶                    throw new InvalidOperationException("Cannot control vsync when running with ContextAPI.NoAPI.");
                 }
 
                 return _vSync;

💬 An exception is thrown from the getter of property VSync (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 733)

                     case CursorModeValue.CursorCaptured:
                         return CursorState.Confined;
                     default:
▶                        throw new ArgumentOutOfRangeException();
                 }
             }
 

💬 An exception is thrown from the getter of property CursorState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS027 Exception thrown from Dispose 2 hits

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 2054)

                 }
                 else
                 {
▶                    throw new GLFWException("You can only dispose windows on the main thread. The window needs to be disposed as it cannot safely be disposed in the finalizer.");
                 }
             }
 

💬 An exception is thrown from the Dispose(bool) method in type NativeWindow (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 2054)

                 }
                 else
                 {
▶                    throw new GLFWException("You can only dispose windows on the main thread. The window needs to be disposed as it cannot safely be disposed in the finalizer.");
                 }
             }
 

💬 An exception is thrown from the Dispose(bool) method in type NativeWindow (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 src\OpenAL\OpenALGenerator\Program.cs (line 11)

 
 namespace OpenALGenerator
 {
▶    class EntryPointAttribute : Attribute
     {
         public string EntryPoint;
         public string OverloadName;

💬 EntryPointAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\OpenAL\OpenALGenerator\Program.cs (line 11)

 
 namespace OpenALGenerator
 {
▶    class EntryPointAttribute : Attribute
     {
         public string EntryPoint;
         public string OverloadName;

💬 EntryPointAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS046 Unbounded stackalloc 4 hits

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 181)

                 unsafe
                 {
                     var images = value.Images;
▶                    Span<GCHandle> handles = stackalloc GCHandle[images.Length];
                     Span<GraphicsLibraryFramework.Image> glfwImages =
                         stackalloc GraphicsLibraryFramework.Image[images.Length];
 

📄 src\OpenTK.Windowing.Desktop\NativeWindow.cs (line 183)

                     var images = value.Images;
                     Span<GCHandle> handles = stackalloc GCHandle[images.Length];
                     Span<GraphicsLibraryFramework.Image> glfwImages =
▶                        stackalloc GraphicsLibraryFramework.Image[images.Length];
 
                     for (var i = 0; i < images.Length; i++)
                     {

SS049 Comparing strings without StringComparison 10 hits

📄 src\Generator.Bind\FuncProcessor.cs (line 708)

             }
 
             // Find out the necessary wrapper types.
▶            if (p.CurrentType.ToLower() == "string" && p.Pointer == 0)
             {
                 // char* -> IntPtr
                 // Due to a bug in the Mono runtime, we need

📄 src\Generator.Bind\FuncProcessor.cs (line 720)

                 p.WrapperType |= WrapperTypes.StringParameter;
             }
 
▶            if (p.CurrentType.ToLower() == "string" && p.Pointer >= 1)
             {
                 // string* -> [In] String[]
                 // [Out] StringBuilder[] parameter is not currently supported

NAudio

736 total diagnostics across 13 rules

SS003 Integer divided by integer causing implicit rounding 302 hits

📄 NAudio.Core\Dsp\SmbPitchShifter.cs (line 62)

         private float[] gOutFIFO = new float[MAX_FRAME_LENGTH];
         private float[] gFFTworksp = new float[2*MAX_FRAME_LENGTH];
         private float[] gLastPhase = new float[MAX_FRAME_LENGTH/2 + 1];
▶        private float[] gSumPhase = new float[MAX_FRAME_LENGTH/2 + 1];
         private float[] gOutputAccum = new float[2*MAX_FRAME_LENGTH];
         private float[] gAnaFreq = new float[MAX_FRAME_LENGTH];
         private float[] gAnaMagn = new float[MAX_FRAME_LENGTH];

💬 The operands in the divisive expression MAX_FRAME_LENGTH/2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 NAudio.Core\Dsp\SmbPitchShifter.cs (line 61)

         private float[] gInFIFO = new float[MAX_FRAME_LENGTH];
         private float[] gOutFIFO = new float[MAX_FRAME_LENGTH];
         private float[] gFFTworksp = new float[2*MAX_FRAME_LENGTH];
▶        private float[] gLastPhase = new float[MAX_FRAME_LENGTH/2 + 1];
         private float[] gSumPhase = new float[MAX_FRAME_LENGTH/2 + 1];
         private float[] gOutputAccum = new float[2*MAX_FRAME_LENGTH];
         private float[] gAnaFreq = new float[MAX_FRAME_LENGTH];

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 NAudio.Core\Wave\WaveFormats\WaveFormat.cs (line 286)

         /// <returns>A hashcode</returns>
         public override int GetHashCode()
         {
▶            return (int) waveFormatTag ^ 
                 (int) channels ^ 
                 sampleRate ^ 
                 averageBytesPerSecond ^ 

💬 GetHashCode() refers to mutable field waveFormatTag (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 NAudio.Core\Wave\WaveFormats\WaveFormat.cs (line 287)

         public override int GetHashCode()
         {
             return (int) waveFormatTag ^ 
▶                (int) channels ^ 
                 sampleRate ^ 
                 averageBytesPerSecond ^ 
                 (int) blockAlign ^ 

💬 GetHashCode() refers to mutable field channels (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS015 String placeholders in wrong order 2 hits

📄 NAudio.Midi\Midi\TempoEvent.cs (line 50)

         /// <returns>String describing the tempo event</returns>
         public override string ToString() 
         {
▶            return String.Format("{0} {2}bpm ({1})",
                 base.ToString(),
                 microsecondsPerQuarterNote,
                 (60000000 / microsecondsPerQuarterNote));

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 NAudio.Midi\Midi\TempoEvent.cs (line 50)

         /// <returns>String describing the tempo event</returns>
         public override string ToString() 
         {
▶            return String.Format("{0} {2}bpm ({1})",
                 base.ToString(),
                 microsecondsPerQuarterNote,
                 (60000000 / microsecondsPerQuarterNote));

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 244 hits

📄 NAudio.Core\Dsp\Complex.cs (line 6)

     /// <summary>
     /// Type to represent complex number
     /// </summary>
▶    public struct Complex
     {
         /// <summary>
         /// Real Part

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Complex. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 NAudio.Core\Wave\SampleProviders\PanningSampleProvider.cs (line 107)

     /// <summary>
     /// Pair of floating point values, representing samples or multipliers
     /// </summary>
▶    public struct StereoSamplePair
     {
         /// <summary>
         /// Left value

💬 Implement Equals(), GetHashCode() and ToString() methods on struct StereoSamplePair. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 NAudio.Asio\ASIODriverExt.cs (line 336)

         private int AsioMessageCallBack(AsioMessageSelector selector, int value, IntPtr message, IntPtr opt)
         {
             // Check when this is called?
▶            switch (selector)
             {
                 case AsioMessageSelector.kAsioSelectorSupported:
                     AsioMessageSelector subValue = (AsioMessageSelector)Enum.ToObject(typeof(AsioMessageSelector), value);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 NAudio.Asio\ASIODriverExt.cs (line 340)

             {
                 case AsioMessageSelector.kAsioSelectorSupported:
                     AsioMessageSelector subValue = (AsioMessageSelector)Enum.ToObject(typeof(AsioMessageSelector), value);
▶                    switch (subValue)
                     {
                         case AsioMessageSelector.kAsioEngineVersion:
                             return 1;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 34 hits

📄 NAudio.Core\Dsp\EnvelopeGenerator.cs (line 170)

         /// <returns>A volume multiplier</returns>
         public float Process()
         {
▶            switch (state)
             {
                 case EnvelopeState.Idle:
                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 NAudio.Asio\ASIOSampleConvertor.cs (line 28)

             switch (asioType)
             {
                 case AsioSampleType.Int32LSB:
▶                    switch (waveFormat.BitsPerSample)
                     {
                         case 16:
                             convertor = (is2Channels) ? ConvertorShortToInt2Channels : (SampleConvertor)ConvertorShortToIntGeneric;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 40 hits

📄 NAudio.Core\Wave\WaveStreams\WaveFileReader.cs (line 143)

                     return dataChunkLength / BlockAlign;
                 }
                 // n.b. if there is a fact chunk, you can use that to get the number of samples
▶                throw new InvalidOperationException("Sample count is calculated only for the standard encodings");
             }
         }
 

💬 An exception is thrown from the getter of property SampleCount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 NAudio.Core\Wave\WaveStreams\AiffFileReader.cs (line 182)

                 }
                 else
                 {
▶                    throw new FormatException("Sample count is calculated only for the standard encodings");
                 }
             }
         }

💬 An exception is thrown from the getter of property SampleCount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS027 Exception thrown from Dispose 4 hits

📄 NAudio.WinMM\Compression\AcmStream.cs (line 245)

                 streamHandle = IntPtr.Zero;
                 if (result != MmResult.NoError)
                 {
▶                    throw new MmException(result, "acmStreamClose");
                 }
 
             }

💬 An exception is thrown from the Dispose(bool) method in type AcmStream (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 NAudio.WinMM\Compression\AcmStream.cs (line 245)

                 streamHandle = IntPtr.Zero;
                 if (result != MmResult.NoError)
                 {
▶                    throw new MmException(result, "acmStreamClose");
                 }
 
             }

💬 An exception is thrown from the Dispose(bool) method in type AcmStream (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS049 Comparing strings without StringComparison 4 hits

📄 NAudio.Core\Wave\WaveStreams\CueList.cs (line 263)

 
             foreach (RiffChunk chunk in reader.ExtraChunks)
             {
▶                if (chunk.IdentifierAsString.ToLower() == "cue ")
                 {
                     cueChunkData = reader.GetChunkData(chunk);
                 }

📄 NAudio.Core\Wave\WaveStreams\CueList.cs (line 267)

                 {
                     cueChunkData = reader.GetChunkData(chunk);
                 }
▶                else if (chunk.IdentifierAsString.ToLower() == "list")
                 {
                     listChunkData = reader.GetChunkData(chunk);
                 }

SS050 Parameter assigned in constructor 2 hits

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 115)

         {
             if (device == Guid.Empty)
             {
▶                device = DSDEVID_DefaultPlayback;
             }
             this.device = device;
             this.desiredLatency = latency;

💬 Suspicious assignment of parameter device in constructor of DirectSoundOut (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 115)

         {
             if (device == Guid.Empty)
             {
▶                device = DSDEVID_DefaultPlayback;
             }
             this.device = device;
             this.desiredLatency = latency;

💬 Suspicious assignment of parameter device in constructor of DirectSoundOut (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS051 Locking on mutable reference 12 hits

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 148)

                 notifyThread.Start();
             }
 
▶            lock (m_LockObject)
             {
                 playbackState = PlaybackState.Playing;
             }

💬 A lock was obtained on m_LockObject but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 181)

         /// </summary>
         public void Pause()
         {
▶            lock (m_LockObject)
             {
                 playbackState = PlaybackState.Paused;
             }

SS057 Collection manipulated during traversal 4 hits

📄 NAudio.Midi\Midi\MidiEventCollection.cs (line 209)

                 {
                     if (!MidiEvent.IsEndTrack(midiEvent))
                     {
▶                        trackEvents[0].Add(midiEvent);
                         eventsAdded = true;
                     }
                 }

📄 NAudio.Midi\Midi\MidiFile.cs (line 204)

                 if ((noteOnEvent.Channel == offEvent.Channel) && (noteOnEvent.NoteNumber == offEvent.NoteNumber)) 
                 {
                     noteOnEvent.OffEvent = offEvent;
▶                    outstandingNoteOns.Remove(noteOnEvent);
                     found = true;
                     break;
                 }

SS066 Disposable field is not disposed 68 hits

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 34)

         private IDirectSound directSound = null;
         private IDirectSoundBuffer primarySoundBuffer = null;
         private IDirectSoundBuffer secondaryBuffer = null;
▶        private EventWaitHandle frameEventWaitHandle1;
         private EventWaitHandle frameEventWaitHandle2;
         private EventWaitHandle endEventWaitHandle;
         private Thread notifyThread;

💬 Disposable field frameEventWaitHandle1 in type DirectSoundOut is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 NAudio.Core\Wave\WaveOutputs\DirectSoundOut.cs (line 35)

         private IDirectSoundBuffer primarySoundBuffer = null;
         private IDirectSoundBuffer secondaryBuffer = null;
         private EventWaitHandle frameEventWaitHandle1;
▶        private EventWaitHandle frameEventWaitHandle2;
         private EventWaitHandle endEventWaitHandle;
         private Thread notifyThread;
         private SynchronizationContext syncContext;

💬 Disposable field frameEventWaitHandle2 in type DirectSoundOut is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

cairoshell

724 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 72 hits

📄 Cairo Desktop\CairoDesktop.Common\Logging\Other\ManagedShellFileLoggerOptions.cs (line 13)

             DateFormat = "MM-dd-yyyy";
             FileExtension = "log";
 
▶            var date = DateTime.Now.ToString(DateFormat);
 
             LogFileName = $"{date}.{FileExtension}";
             BackupLogFileName = $"{date}-Backup.{FileExtension}";

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Cairo Desktop\CairoDesktop.Common\Logging\Other\ManagedShellLogger.cs (line 44)

             }
 
             string message = GetCategoryPrefix(_category) + formatter(state, exception);
▶            ShellLogger.OnLog(new LogEventArgs(logLevel.ToManagedShellLogSeverity(), message, exception, DateTime.Now));
         }
 
         private string GetCategoryPrefix(string category)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 48 hits

📄 Cairo Desktop\CairoDesktop.Taskbar\DwmThumbnail.xaml.cs (line 126)

                     if (size.x <= Rect.Width && size.y <= Rect.Height)
                     {
                         // do not scale
▶                        props.rcDestination.Top += (Rect.Height - size.y) / 2;
                         props.rcDestination.Left += (Rect.Width - size.x) / 2;
                         props.rcDestination.Right = props.rcDestination.Left + size.x;
                         props.rcDestination.Bottom = props.rcDestination.Top + size.y;

💬 The operands in the divisive expression (Rect.Height - size.y) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Cairo Desktop\CairoDesktop.Taskbar\DwmThumbnail.xaml.cs (line 127)

                     {
                         // do not scale
                         props.rcDestination.Top += (Rect.Height - size.y) / 2;
▶                        props.rcDestination.Left += (Rect.Width - size.x) / 2;
                         props.rcDestination.Right = props.rcDestination.Left + size.x;
                         props.rcDestination.Bottom = props.rcDestination.Top + size.y;
                     }

💬 The operands in the divisive expression (Rect.Width - size.x) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 8 hits

📄 Cairo Desktop\CairoDesktop.MenuBar\MenuBar.xaml.cs (line 94)

                     if (menuExtra != null)
                     {
                         MenuExtrasHost.Children.Add(menuExtra);
▶                        _loadedMenuExtras.Add(userControlMenuBarExtension, menuExtra);
                     }
                 }
                 catch (Exception ex)

💬 Type UserControlMenuBarExtension is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Cairo Desktop\CairoDesktop.MenuBar\MenuBar.xaml.cs (line 94)

                     if (menuExtra != null)
                     {
                         MenuExtrasHost.Children.Add(menuExtra);
▶                        _loadedMenuExtras.Add(userControlMenuBarExtension, menuExtra);
                     }
                 }
                 catch (Exception ex)

SS008 GetHashCode() refers to mutable or static member 16 hits

📄 Cairo Desktop\CairoDesktop.AppGrabber\ApplicationInfo.cs (line 340)

         public override int GetHashCode()
         {
             int hashCode = 0;
▶            if (Name != null)
                 hashCode ^= Name.GetHashCode();
             if (Path != null)
                 hashCode ^= Path.GetHashCode();

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Cairo Desktop\CairoDesktop.AppGrabber\ApplicationInfo.cs (line 341)

         {
             int hashCode = 0;
             if (Name != null)
▶                hashCode ^= Name.GetHashCode();
             if (Path != null)
                 hashCode ^= Path.GetHashCode();
             return hashCode;

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS011 OnPropertyChanged without nameof operator 112 hits

📄 Cairo Desktop\CairoDesktop.Common\NavigationManager.cs (line 27)

                 _currentIndex = value;
 
                 OnPropertyChanged("CurrentPath");
▶                OnPropertyChanged("CanGoBack");
                 OnPropertyChanged("CanGoForward");
                 OnPropertyChanged("CurrentPathFriendly");
                 OnPropertyChanged("HomePathFriendly");

💬 OnPropertyChanged(CanGoBack) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

📄 Cairo Desktop\CairoDesktop.Common\NavigationManager.cs (line 28)

 
                 OnPropertyChanged("CurrentPath");
                 OnPropertyChanged("CanGoBack");
▶                OnPropertyChanged("CanGoForward");
                 OnPropertyChanged("CurrentPathFriendly");
                 OnPropertyChanged("HomePathFriendly");
             }

💬 OnPropertyChanged(CanGoForward) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 20 hits

📄 Cairo Desktop\CairoDesktop.Application\Structs\CairoCommandParameter.cs (line 3)

 namespace CairoDesktop.Application.Structs
 {
▶    public struct CairoCommandParameter
     {
         public string Name;
         public string Description;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CairoCommandParameter. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Cairo Desktop\CairoDesktop.Application\Structs\MenuBarDimensions.cs (line 3)

 namespace CairoDesktop.Application.Structs
 {
▶    public struct MenuBarDimensions
     {
         /// <summary>
         /// ABE_LEFT = 0,

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MenuBarDimensions. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 256 hits

📄 Cairo Desktop\CairoDesktop.Common\CommandLineParser.cs (line 67)

             {
                 // Look for new parameters (-,/ or --) and a possible enclosed value (=,:)
                 paramElements = regexSplitter.Split(arg, 3);
▶                switch (paramElements.Length)
                 {
                     // Found a value (for the last parameter found (space separator))
                     case 1:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Cairo Desktop\CairoDesktop.Common\Icon.xaml.cs (line 58)

         {
             if (e != null && !string.IsNullOrWhiteSpace(e.PropertyName))
             {
▶                switch (e.PropertyName)
                 {
                     case "DesktopLabelPosition":
                     case "DesktopIconSize":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 8 hits

📄 Cairo Desktop\CairoDesktop.DynamicDesktop\SupportingClasses\BingWallpaperClient.cs (line 119)

                 {
                     if (!_loadcalled)
                     {
▶                        throw new InvalidOperationException("Call the DownLoad() method first");
                     }
 
                     return new BitmapImage(new Uri(_tempfilename));

💬 An exception is thrown from the getter of property WPFPhotoOfTheDay (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Cairo Desktop\CairoDesktop.DynamicDesktop\SupportingClasses\BingWallpaperClient.cs (line 134)

                 {
                     if (!_loadcalled)
                     {
▶                        throw new InvalidOperationException("Call the DownLoad() method first");
                     }
 
                     return new Bitmap(_tempfilename);

💬 An exception is thrown from the getter of property WFPhotoOfTheDay (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS048 Locking on discouraged object (string, Type, this) 24 hits

📄 Cairo Desktop\CairoDesktop.Common\Helpers\RegistryChangeMonitor.cs (line 66)

 
         public void Start()
         {
▶            lock (this)
             {
                 if (_monitorThread == null)
                 {

📄 Cairo Desktop\CairoDesktop.Common\Helpers\RegistryChangeMonitor.cs (line 83)

 
         public void Stop()
         {
▶            lock (this)
             {
                 Changed = null;
                 Error = null;

SS049 Comparing strings without StringComparison 12 hits

📄 Cairo Desktop\CairoDesktop.AppGrabber\QuickLaunchManager.cs (line 50)

             // it would be nice to cache this, but need to handle case of user adding/removing app via various means after first access
             foreach (ApplicationInfo ai in _appGrabber.QuickLaunch)
             {
▶                if (ai.Target.ToLower() == window.WinFileName.ToLower() || (window.IsUWP && ai.Target == window.AppUserModelID))
                 {
                     return ai;
                 }

📄 Cairo Desktop\CairoDesktop.AppGrabber\ApplicationInfo.cs (line 287)

             ai.Path = "appx:" + storeApp.AppUserModelId;
             ai.Target = storeApp.AppUserModelId;
             ai.IconColor = storeApp.IconColor;
▶            ai.AllowRunAsAdmin = storeApp.EntryPoint?.ToLower() == "windows.fulltrustapplication" || storeApp.HostId?.ToLower() == "pwa";
 
             return ai;
         }

SS058 String concatenated in a loop 4 hits

📄 Cairo Desktop\CairoDesktop.AppGrabber\AppGrabberUI.xaml.cs (line 99)

             string filter = "Programs and shortcuts|";
             foreach (string ext in AppGrabberService.ExecutableExtensions)
             {
▶                filter += $"*{ext};";
             }
 
             filter = filter.Substring(0, filter.Length - 2);

📄 Cairo Desktop\CairoDesktop.AppGrabber\AppGrabberUI.xaml.cs (line 99)

             string filter = "Programs and shortcuts|";
             foreach (string ext in AppGrabberService.ExecutableExtensions)
             {
▶                filter += $"*{ext};";
             }
 
             filter = filter.Substring(0, filter.Length - 2);

SS066 Disposable field is not disposed 144 hits

📄 Cairo Desktop\CairoDesktop.Common\Logging\Other\ManagedShellLoggerProvider.cs (line 17)

         private readonly IOptionsMonitor<ManagedShellFileLoggerOptions> _options;
         private readonly Settings cairoSettings;
         private readonly ConcurrentDictionary<string, Lazy<ManagedShellLogger>> _loggers;
▶        private readonly IDisposable _settingsChangeToken;
         private ManagedShellFileLoggerOptions _settings;
         private string _filename;
         private FileLog _fileLog = null;

💬 Disposable field _settingsChangeToken in type ManagedShellLoggerProvider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Cairo Desktop\CairoDesktop.Common\Logging\Other\ManagedShellLoggerProvider.cs (line 20)

         private readonly IDisposable _settingsChangeToken;
         private ManagedShellFileLoggerOptions _settings;
         private string _filename;
▶        private FileLog _fileLog = null;
 
         public ManagedShellLoggerProvider(ManagedShellFileLoggerOptions settings, Settings cairoSettings)
         {

💬 Disposable field _fileLog in type ManagedShellLoggerProvider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Blog.Core

708 total diagnostics across 17 rules

SS001 Async method with void return type 50 hits

📄 Blog.Core.Tests\Repository_Test\MongoRepository_Base_Should.cs (line 38)

 
 
         [Fact]
▶        public async void Add_Test()
         {
             await baseRepository.AddAsync(new MongoTest { isDel = false, name = "test", time = DateTime.UtcNow });
         }

💬 Method Add_Test is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Blog.Core.Tests\Service_Test\BlogArticleService_Should.cs (line 36)

 
         [Fact]
▶        public async void Get_Blogs_Test()
         {
             var data = await blogArticleServices.GetBlogs();

💬 Method Get_Blogs_Test is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 316 hits

📄 Blog.Core.Model\Models\AccessTrendLog.cs (line 25)

         /// <summary>
         /// 更新时间
         /// </summary>
▶        public DateTime UpdateTime { get; set; } = DateTime.Now;
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Blog.Core.Model\IDS4DbModels\ApplicationRole.cs (line 35)

         /// <summary>
         /// 创建时间
         /// </summary>
▶        public DateTime? CreateTime { get; set; } = DateTime.Now;
         /// <summary>
         /// 修改ID
         /// </summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 48 hits

📄 Blog.Core.Common\Helper\Base32Helper.cs (line 67)

         /// </exception>
         public static byte[] FromBase32String(string str)
         {
▶            int numBytes = str.Length * 5 / 8;
             byte[] bytes = new Byte[numBytes];
 
             // all UPPERCASE chars

💬 The operands in the divisive expression str.Length * 5 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Blog.Core.Common\Helper\Console\Table\TableExtension.cs (line 72)

             if (string.IsNullOrWhiteSpace(titleStr)) return "";
             //一行的宽度
             int rowWide = columnWides.Sum() + columnWides.Count * 2 * columnBlankNum + columnWides.Count + 1;
▶            int blankNum = (rowWide - titleStr.FullHalfLength()) / 2 - 1;
             string tilte = $"{delimiterStr}{"".PadLeft(blankNum, ' ')}{titleStr}{"".PadLeft(blankNum, ' ')}{delimiterStr}";
             if (tilte.FullHalfLength() != rowWide) tilte = tilte.Replace($" {delimiterStr}", $"  {delimiterStr}");
             return tilte;

💬 The operands in the divisive expression (rowWide - titleStr.FullHalfLength()) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS018 Switch does not handle all enum options 10 hits

📄 Blog.Core.Model\ApiResponse.cs (line 11)

 
         public ApiResponse(StatusCode apiCode, string msg = null)
         {
▶            switch (apiCode)
             {
                 case StatusCode.CODE401:
                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Blog.Core.Common\DB\TenantUtil.cs (line 23)

         {
             //此处默认配置 Sqlite 地址
             //实际业务中 也会有运维、系统管理员等来维护
▶            switch (tenant.DbType.Value)
             {
                 case DbType.Sqlite:
                     tenant.Connection = $"DataSource={Path.Combine(Environment.CurrentDirectory, tenant.ConfigId)}.db";

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 18 hits

📄 Blog.Core.Model\ApiResponse.cs (line 11)

 
         public ApiResponse(StatusCode apiCode, string msg = null)
         {
▶            switch (apiCode)
             {
                 case StatusCode.CODE401:
                 {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Blog.Core.Common\DB\TenantUtil.cs (line 23)

         {
             //此处默认配置 Sqlite 地址
             //实际业务中 也会有运维、系统管理员等来维护
▶            switch (tenant.DbType.Value)
             {
                 case DbType.Sqlite:
                     tenant.Connection = $"DataSource={Path.Combine(Environment.CurrentDirectory, tenant.ConfigId)}.db";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS032 Thread.Sleep used in async method 4 hits

📄 Blog.Core.Services\PayServices.cs (line 150)

                     case "Q":
                         int waittime = payResult.WAITTIME.ObjToInt();
                         if (waittime <= 0) waittime = 5;//如果需要等待默认等待5秒后再次查询
▶                        Thread.Sleep(waittime * 1000);
                         //轮询查询
                         messageModel = await PayCheck(payModel, 1);
                         break;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 Blog.Core.Services\PayServices.cs (line 377)

                     case "Q":
                         int waittime = payResult.WAITTIME.ObjToInt();
                         if (waittime <= 0) waittime = 5;//如果需要等待默认等待5秒后再次查询
▶                        Thread.Sleep(waittime * 1000);
                         //改成轮询查询
                         messageModel = await PayCheck(payModel, ++times);
                         break;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 58 hits

📄 Blog.Core.Serilog.Es\Sinks\TCP\TCPSocketWriter.cs (line 199)

                 {
                     if (_stream != null)
                     {
▶                        _stream.Dispose();
                     }
 
                     _disposed.SetResult(true);

💬 Async overload available for Stream.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Blog.Core.Common\Seed\DBSeed.cs (line 137)

 
                     if (!await myContext.Db.Queryable<BlogArticle>().AnyAsync())
                     {
▶                        myContext.GetEntityDB<BlogArticle>().InsertRange(
                             JsonHelper.ParseFormByJson<List<BlogArticle>>(
                                 FileHelper.ReadFile(string.Format(SeedDataFolder, "BlogArticle"), Encoding.UTF8)));
                         Console.WriteLine("Table:BlogArticle created success!");

💬 Async overload available for SimpleClient.InsertRange (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 58 hits

📄 Blog.Core.Serilog.Es\NetworkLoggerConfigurationExtensions.cs (line 72)

         {
             try
             {
▶                var ipHostEntry = Dns.GetHostEntryAsync(uri).Result;
                 if (!ipHostEntry.AddressList.Any())
                     return null;
                 return ipHostEntry.AddressList.First();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Blog.Core.Common\Helper\HttpHelper.cs (line 22)

                 string result = string.Empty;
                 Uri getUrl = new Uri(serviceAddress);
                 Httpclient.Timeout = new TimeSpan(0, 0, 60);
▶                result = await Httpclient.GetAsync(serviceAddress).Result.Content.ReadAsStringAsync();
                 return result;
             }
             catch (Exception e)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 8 hits

📄 Blog.Core.Common\Helper\HttpHelper.cs (line 13)

     /// </summary>
     public class HttpHelper
     {
▶        public static readonly HttpClient Httpclient = new HttpClient();
 
         public static async Task<string> GetAsync(string serviceAddress)
         {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 Blog.Core.Common\Helper\WeChatHelper.cs (line 56)

         public async static Task<WeChatApiDto> UploadMedia(string token, string type, string fileName, Stream inputStream)
         {
             var url = $"https://api.weixin.qq.com/cgi-bin/material/add_material?access_token={token}&type={type}"; 
▶            using var client = new HttpClient();
             using HttpContent content = new StreamContent(inputStream);
             var httpResponse = await client.PostAsync(url, content);
             var txt = await httpResponse.Content.ReadAsStringAsync();

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS040 Unused result on immutable object 4 hits

📄 Blog.Core.Common\Helper\SM\SM4Helper.cs (line 67)

                 for (int i = matchCol.Count - 1; i >= 0; i--)
                 {
                     Match item = matchCol[i];
▶                    cipherText.Remove(item.Index, item.Length);
                 }
             }
             return cipherText;

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 Blog.Core.Extensions\ServiceExtensions\SqlsugarSetup.cs (line 138)

         {
             foreach (var param in paramArr)
             {
▶                sql.Replace(param.ParameterName, param.Value.ObjToString());
             }
 
             return sql;

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS041 Unnecessary enumerable materialization 6 hits

📄 Blog.Core.Gateway\Controllers\UserController.cs (line 27)

             return new MessageModel<List<ClaimDto>>()
             {
                 success = true,
▶                response = (_user.GetClaimsIdentity().ToList()).Select(d =>
                     new ClaimDto
                     {
                         Type = d.Type,

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Blog.Core.Api\Controllers\ValuesController.cs (line 125)

             return new MessageModel<List<ClaimDto>>()
             {
                 success = true,
▶                response = (_user.GetClaimsIdentity().ToList()).Select(d =>
                     new ClaimDto
                     {
                         Type  = d.Type,

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS048 Locking on discouraged object (string, Type, this) 16 hits

📄 Blog.Core.Serilog.Es\Sinks\TCP\TCPSocketWriter.cs (line 287)

 
         public void Enqueue(T obj)
         {
▶            lock (this)
             {
                 if (IsCompleted)
                 {

📄 Blog.Core.Serilog.Es\Sinks\TCP\TCPSocketWriter.cs (line 306)

 
         public void CompleteAdding()
         {
▶            lock (this)
             {
                 IsCompleted = true;
             }

SS049 Comparing strings without StringComparison 30 hits

📄 Blog.Core.Serilog.Es\NetworkLoggerConfigurationExtensions.cs (line 97)

             }
             if (uri.Port == 0)
                 throw new UriFormatException("Uri port cannot be 0");
▶            if (!(uri.Scheme.ToLower() == "tcp" || uri.Scheme.ToLower() == "tls"))
                 throw new UriFormatException("Uri scheme must be tcp or tls");
             return uri;
         }

📄 Blog.Core.Serilog.Es\NetworkLoggerConfigurationExtensions.cs (line 97)

             }
             if (uri.Port == 0)
                 throw new UriFormatException("Uri port cannot be 0");
▶            if (!(uri.Scheme.ToLower() == "tcp" || uri.Scheme.ToLower() == "tls"))
                 throw new UriFormatException("Uri scheme must be tcp or tls");
             return uri;
         }

SS051 Locking on mutable reference 8 hits

📄 Blog.Core.Serilog.Es\Formatters\JsonConfigUtils.cs (line 34)

         /// <returns></returns>
         public static T GetAppSettings<T>(string AppSettingsFileName, string key) where T : class, new()
         {
▶            lock (__Lock__)
             {
                 if (Configuration == null)
                 {

💬 A lock was obtained on __Lock__ but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Ocelot.Provider.Nacos\NacosClient\LoadBalance\WeightRoundRobinLBStrategy.cs (line 47)

 
             var instanceId = string.Empty;
 
▶            lock (obj)
             {
                 if (_pos >= tagInstanceIdList.Count)
                     _pos = 0;

💬 A lock was obtained on obj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS058 String concatenated in a loop 34 hits

📄 Blog.Core.Common\Helper\CCBPayUtil.cs (line 271)

 			string text = "";
 			for (int i = 0; i < array.Length; i++)
 			{
▶				text += array[i].ToString("x2");
 			}
 			return text;
 		}

📄 Blog.Core.Common\DB\Aop\SqlsugarAop.cs (line 157)

         string key = "【SQL参数】：";
         foreach (var param in pars)
         {
▶            key += $"{param.ParameterName}:{param.Value}\n";
         }
 
         return key;

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 Blog.Core.EventBus\EventBusKafka\KafkaConsumerHostService.cs (line 123)

 
             if (_subsManager.HasSubscriptionsForEvent(eventName))
             {
▶                using (var scope = _autofac.BeginLifetimeScope(AUTOFAC_SCOPE_NAME))
                 {
                     var subscriptions = _subsManager.GetHandlersForEvent(eventName);
                     foreach (var subscription in subscriptions)

💬 ILifetimeScope can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Blog.Core.EventBus\RabbitMQPersistent\EventBusRabbitMQ.cs (line 320)

 
             if (_subsManager.HasSubscriptionsForEvent(eventName))
             {
▶                using (var scope = _autofac.BeginLifetimeScope(AUTOFAC_SCOPE_NAME))
                 {
                     var subscriptions = _subsManager.GetHandlersForEvent(eventName);
                     foreach (var subscription in subscriptions)

💬 ILifetimeScope can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 32 hits

📄 Blog.Core.Serilog.Es\Sinks\TCP\TCPSocketWriter.cs (line 53)

     {
         private readonly FixedSizeQueue<string> _eventQueue;
         private readonly ExponentialBackoffTcpReconnectionPolicy _reconnectPolicy = new ExponentialBackoffTcpReconnectionPolicy();
▶        private readonly CancellationTokenSource _tokenSource; // Must be private or Dispose will not function properly.
         private readonly TaskCompletionSource<bool> _disposed = new TaskCompletionSource<bool>();
 
         private Stream _stream;

💬 Disposable field _tokenSource in type TcpSocketWriter is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Blog.Core.Serilog.Es\Sinks\TCP\TCPSocketWriter.cs (line 56)

         private readonly CancellationTokenSource _tokenSource; // Must be private or Dispose will not function properly.
         private readonly TaskCompletionSource<bool> _disposed = new TaskCompletionSource<bool>();
 
▶        private Stream _stream;
 
         /// <summary>
         /// Event that is invoked when reconnecting after a TCP session is dropped fails.

💬 Disposable field _stream in type TcpSocketWriter is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

CsvHelper

674 total diagnostics across 9 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 76 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 42 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 42 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 42 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 310 hits

No source samples extracted

SS019 Switch is missing default label 24 hits

No source samples extracted

SS033 Async overload is available 48 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 62 hits

No source samples extracted

SS066 Disposable field is not disposed 28 hits

No source samples extracted

btcpayserver

662 total diagnostics across 17 rules

SS001 Async method with void return type 4 hits

📄 BTCPayServer.Tests\WalletTests.cs (line 353)

         await s.GoToWalletSend();
 
         // ReSharper disable once AsyncVoidMethod
▶        async void PasteBIP21(object sender, IDialog e)
         {
             await e.AcceptAsync(bip21);
         }

💬 Method PasteBIP21 is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 BTCPayServer.Tests\PlaywrightTester.cs (line 926)

         {
             // Handle the alert dialog in Playwright
             // ReSharper disable once AsyncVoidMethod
▶            async void Callback(object? sender, IDialog e)
                 => await e.AcceptAsync(text);
             Page.Dialog += Callback;
             try

💬 Method Callback is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 BTCPayServer.Client\JsonConverters\WordlistJsonConverter.cs (line 50)

     public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
     {
         if (value is Wordlist wl)
▶            writer.WriteValue(_WordlistsReverse[wl]);
     }
 
     readonly static Dictionary<string, Wordlist> _Wordlists;

💬 Type Wordlist is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 BTCPayServer.Tests\PayJoinTests.cs (line 116)

             var inputs = new[] { 1m };
             var result = await controller.SelectUTXO(network, utxos, inputs, paymentAmount, otherOutputs);
             Assert.Equal(PayJoinEndpointController.PayjoinUtxoSelectionType.HeuristicBased, result.selectionType);
▶            Assert.Contains(result.selectedUTXO, utxo => utxos.Contains(utxo));
 
             //no matter what here, no good selection, it seems that payment with 1 utxo generally makes payjoin coin selection unperformant
             utxos = new[] { FakeUTXO(0.3m), FakeUTXO(0.7m) };

💬 Type UTXO is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

📄 BTCPayServer.Common\SynchronizationContextRemover.cs (line 7)

 
 namespace BTCPayServer
 {
▶    public struct SynchronizationContextRemover : INotifyCompletion
     {
         public bool IsCompleted => SynchronizationContext.Current == null;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SynchronizationContextRemover. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 BTCPayServer.Common\Logging\ConsoleLogger.cs (line 310)

             }
         }
 
▶        private struct ConsoleColors
         {
             public ConsoleColors(ConsoleColor? foreground, ConsoleColor? background)
             {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ConsoleColors. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 6 hits

📄 BTCPayServer.Rating\RateRules.cs (line 413)

             public override void VisitBinaryExpression(BinaryExpressionSyntax node)
             {
                 base.VisitBinaryExpression(node);
▶                switch (node.Kind())
                 {
                     case SyntaxKind.AddExpression:
                     case SyntaxKind.MultiplyExpression:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 BTCPayServer.Rating\RateRules.cs (line 321)

 
 
                 bool invalid = false;
▶                switch (node.Kind())
                 {
                     case SyntaxKind.AddExpression:
                     case SyntaxKind.MultiplyExpression:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 16 hits

📄 BTCPayServer.Client\JsonConverters\NumericStringJsonConverter.cs (line 56)

 
         public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
         {
▶            switch (value)
             {
                 case null:
                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 BTCPayServer.Client\BTCPayServerClient.StoreRatesConfiguration.cs (line 18)

     }
 
     private string GetRateConfigPath(string storeId, bool? fallback)
▶    => fallback switch
     {
         null => $"api/v1/stores/{storeId}/rates/configuration",
         true => $"api/v1/stores/{storeId}/rates/configuration/fallback",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 BTCPayServer.Rating\MultiValueDictionary.cs (line 939)

                     switch (state)
                     {
                         case EnumerationState.BeforeFirst:
▶                            throw new InvalidOperationException(("Properties.Resources.InvalidOperation_EnumNotStarted"));
                         case EnumerationState.AfterLast:
                             throw new InvalidOperationException(("Properties.Resources.InvalidOperation_EnumEnded"));
                         default:

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 BTCPayServer.Rating\MultiValueDictionary.cs (line 941)

                         case EnumerationState.BeforeFirst:
                             throw new InvalidOperationException(("Properties.Resources.InvalidOperation_EnumNotStarted"));
                         case EnumerationState.AfterLast:
▶                            throw new InvalidOperationException(("Properties.Resources.InvalidOperation_EnumEnded"));
                         default:
                             return current;
                     }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 8 hits

📄 BTCPayServer.Tests\FastTests.cs (line 1284)

             await fetch.UpdateIfNecessary(default);
             spy.AssertNotHit();
             fetch.RefreshRate = TimeSpan.FromSeconds(1.0);
▶            Thread.Sleep(1020);
             fetchedRate = await fetcher.FetchRate(CurrencyPair.Parse("BTC_USD"), rateRules, null, default);
             spy.AssertNotHit();
             fetch.ValidatyTime = TimeSpan.FromSeconds(1.0);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 BTCPayServer.Tests\FastTests.cs (line 1291)

             await fetch.UpdateIfNecessary(default);
             spy.AssertHit();
             await fetch.GetRatesAsync(default);
▶            Thread.Sleep(1000);
             await Assert.ThrowsAsync<InvalidOperationException>(() => fetch.GetRatesAsync(default));
         }
 

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 290 hits

📄 BTCPayServer.Common\MultiProcessingQueue.cs (line 95)

             {
                 queues = _Queues.Select(c => c.Value).ToArray();
             }
▶            cts.Cancel();
             var delay = Task.Delay(-1, cancellationToken);
             foreach (var q in queues)
             {

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 BTCPayServer.PluginPacker\Program.cs (line 54)

             {
                 File.Delete(outputFile + ".btcpay");
             }
▶            ZipFile.CreateFromDirectory(directory, outputFile + ".btcpay", CompressionLevel.Optimal, false);
             await File.WriteAllTextAsync(outputFile + ".btcpay.json", json);
 
             var sha256sums = new StringBuilder();

💬 Async overload available for ZipFile.CreateFromDirectory (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 166 hits

📄 BTCPayServer.Abstractions\Services\PluginHookFilter.cs (line 12)

 
         public Task<object> Execute(object args)
         {
▶            return Execute(args is T args1 ? args1 : default).ContinueWith(task => task.Result as object);
         }
 
         public abstract Task<T> Execute(T arg);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 BTCPayServer.Tests\CrowdfundTests.cs (line 53)

             Assert.Equal(appType, vm.SelectedAppType);
             Assert.Null(vm.AppName);
             vm.AppName = "test";
▶            var redirect = Assert.IsType<RedirectResult>(apps.CreateApp(user.StoreId, vm).Result);
             Assert.EndsWith("/settings/crowdfund", redirect.Url);
             var appList = Assert.IsType<ListAppsViewModel>(Assert.IsType<ViewResult>(apps.ListApps(user.StoreId).Result).Model);
             var app = appList.Apps[0];

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 10 hits

📄 BTCPayServer.Tests\BitpayTests.cs (line 247)

 
             var k = new Key();
             var bitpay = new Bitpay(k, tester.PayTester.ServerUri);
▶            bitpay.AuthorizeClient(new PairingCode(storeController.GeneratedPairingCode)).Wait();
             Assert.True(await bitpay.TestAccessAsync(Facade.Merchant));
             Assert.True(await bitpay.TestAccessAsync(Facade.PointOfSale));
             // Same with a new instance

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 BTCPayServer.Tests\FastTests.cs (line 1714)

             Assert.True(new[] { true, true, true, false }.SequenceEqual(jobs));
             Assert.Equal(1, client.GetExecutingCount());
 
▶            Assert.False(waitJobsFinish.Wait(1));
             Assert.False(waitJobsFinish.IsCompletedSuccessfully);
 
             await mockDelay.Advance(TimeSpan.FromSeconds(1.0));

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS037 HttpClient instantiated directly 78 hits

📄 BTCPayServer.Rating\Providers\HitBTCRateProvider.cs (line 13)

     public class HitBTCRateProvider(HttpClient httpClient) : IRateProvider
     {
         public RateSourceInfo RateSourceInfo => new("hitbtc", "HitBTC", "https://api.hitbtc.com/api/2/public/ticker");
▶        private readonly HttpClient _httpClient = httpClient ?? new HttpClient();
 
         public async Task<PairRate[]> GetRatesAsync(CancellationToken cancellationToken)
         {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 BTCPayServer.Rating\Providers\KrakenExchangeRateProvider.cs (line 33)

         }
 
         HttpClient _LocalClient;
▶        static readonly HttpClient _Client = new HttpClient();
         string[] _Symbols = Array.Empty<string>();
         DateTimeOffset? _LastSymbolUpdate = null;
         readonly Dictionary<string, string> _TickerMapping = new Dictionary<string, string>()

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 4 hits

📄 BTCPayServer.Tests\CSVTester.cs (line 16)

         var lines = text.Split("\r\n").ToList();
         var headers = lines[0].Split(',');
         _indexes = headers.Select((h,i) => (h,i)).ToDictionary(h => h.h, h => h.i);
▶        _lines = lines.Skip(1).ToList().Select(l => l.Split(',')).ToList();
     }
 }

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 BTCPayServer.Tests\FastTests.cs (line 2441)

         {
             var result = new JObject();
 
▶            foreach (var property in original.Properties().ToList().OrderBy(p => p.Name))
             {
                 var value = property.Value as JObject;
 

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 BTCPayServer.Tests\OutputPathAttribute.cs (line 5)

 
 namespace BTCPayServer.Tests
 {
▶    public class OutputPathAttribute : Attribute
     {
         public OutputPathAttribute(string builtPath)
         {

💬 OutputPathAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 BTCPayServer.Tests\OutputPathAttribute.cs (line 5)

 
 namespace BTCPayServer.Tests
 {
▶    public class OutputPathAttribute : Attribute
     {
         public OutputPathAttribute(string builtPath)
         {

💬 OutputPathAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 10 hits

📄 BTCPayServer.Common\MultiProcessingQueue.cs (line 40)

         {
             get
             {
▶                lock (_Queues)
                 {
                     Cleanup();
                     return _Queues.Count;

💬 A lock was obtained on _Queues but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 BTCPayServer.Common\MultiProcessingQueue.cs (line 51)

         bool stopped;
         public void Enqueue(string queueName, ProcessingAction act)
         {
▶            lock (_Queues)
             {
 retry:
                 if (stopped)

SS058 String concatenated in a loop 2 hits

📄 BTCPayServer.Client\BTCPayServerClient.cs (line 180)

         {
             foreach (var item in (IEnumerable)keyValuePair.Value)
             {
▶                uriBuilder.Query = uriBuilder.Query + Uri.EscapeDataString(keyValuePair.Key) + "=" +
                                    Uri.EscapeDataString(item.ToString()) + "&";
             }
         }

📄 BTCPayServer.Client\BTCPayServerClient.cs (line 180)

         {
             foreach (var item in (IEnumerable)keyValuePair.Value)
             {
▶                uriBuilder.Query = uriBuilder.Query + Uri.EscapeDataString(keyValuePair.Key) + "=" +
                                    Uri.EscapeDataString(item.ToString()) + "&";
             }
         }

SS059 IAsyncDisposable not disposed asynchronously 34 hits

📄 BTCPayServer.Tests\DatabaseTester.cs (line 57)

 
         public async Task MigrateAsync()
         {
▶            using var ctx = CreateContext();
             await EnsureCreatedAsync();
             await ctx.Database.MigrateAsync();
         }

💬 ApplicationDbContext can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 BTCPayServer.Tests\DatabaseTester.cs (line 72)

 
         public async Task MigrateUntil(string migration = null)
         {
▶            using var ctx = CreateContext();
             var db = ctx.Database.GetDbConnection();
             await EnsureCreatedAsync();
             var migrations = ctx.Database.GetMigrations().ToArray();

💬 ApplicationDbContext can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 18 hits

📄 BTCPayServer.Common\Logging\ConsoleLogger.cs (line 347)

     {
         private const int _maxQueuedMessages = 1024;
 
▶        private readonly BlockingCollection<LogMessageEntry> _messageQueue = new BlockingCollection<LogMessageEntry>(_maxQueuedMessages);
         private readonly Task _outputTask;
 
         public IConsole Console;

💬 Disposable field _messageQueue in type ConsoleLoggerProcessor is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 BTCPayServer.Common\Logging\ConsoleLogger.cs (line 348)

         private const int _maxQueuedMessages = 1024;
 
         private readonly BlockingCollection<LogMessageEntry> _messageQueue = new BlockingCollection<LogMessageEntry>(_maxQueuedMessages);
▶        private readonly Task _outputTask;
 
         public IConsole Console;

💬 Disposable field _outputTask in type ConsoleLoggerProcessor is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

LiteDB

646 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 78 hits

📄 LiteDB\Client\Storage\LiteFileInfo.cs (line 29)

         public int Chunks { get; internal set; } = 0;
 
         [BsonField("uploadDate")]
▶        public DateTime UploadDate { get; internal set; } = DateTime.Now;
 
         [BsonField("metadata")]
         public BsonDocument Metadata { get; set; } = new BsonDocument();

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 LiteDB\Engine\FileReader\FileReaderError.cs (line 13)

     /// </summary>
     internal class FileReaderError
     {
▶        public DateTime Created { get; } = DateTime.Now;
         public FileOrigin Origin { get; set; }
         public long Position { get; set;  }
         public uint? PageID { get; set; }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 44 hits

📄 LiteDB\Document\ObjectId.cs (line 135)

 
             for (var i = 0; i < 24; i += 2)
             {
▶                bytes[i / 2] = Convert.ToByte(value.Substring(i, 2), 16);
             }
 
             return bytes;

💬 The operands in the divisive expression i / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 LiteDB\Engine\Disk\DiskService.cs (line 125)

         /// The result is used to prevent infinite loops in case of problems with pointers
         /// Each page support max of 255 items. Use 10 pages offset (avoid empty disk)
         /// </summary>
▶        public uint MAX_ITEMS_COUNT => (uint)(((_dataLength + _logLength) / PAGE_SIZE) + 10) * byte.MaxValue;
 
         /// <summary>
         /// When a page are requested as Writable but not saved in disk, must be discard before release

💬 The operands in the divisive expression (_dataLength + _logLength) / PAGE_SIZE are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 LiteDB.Tests\Mapper\LinqBsonExpression_Tests.cs (line 218)

 
             // contains
             TestExpr<User>(x => x.PhoneNumbers.Contains(1234), "PhoneNumbers ANY = @p0", 1234);
▶            TestExpr<User>(x => x.Phones2.Contains(new Phone { Number = 1 }), "Phones2 ANY = { Number: @p0 }", 1);
 
             // negated contains
             TestExpr<User>(x => !x.PhoneNumbers.Contains(1234), "(PhoneNumbers ANY = @p0) = false", 1234);

💬 Type Phone is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 LiteDB.Tests\Mapper\LinqBsonExpression_Tests.cs (line 222)

 
             // negated contains
             TestExpr<User>(x => !x.PhoneNumbers.Contains(1234), "(PhoneNumbers ANY = @p0) = false", 1234);
▶            TestExpr<User>(x => !x.Phones2.Contains(new Phone { Number = 1 }), "(Phones2 ANY = { Number: @p0 }) = false", 1);
 
             // fixed position with filter expression
             TestExpr<User>(x => x.Phones.First(p => p.Number == 1), "FIRST(FILTER($.Phones=>(@.Number=@p0)))", 1);

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 LiteDB\Engine\Structures\PagePosition.cs (line 41)

             unchecked
             {
                 int hash = 17;
▶                hash = hash * 23 + (int)this.PageID;
                 hash = hash * 23 + (int)this.Position;
                 return hash;
             }

💬 GetHashCode() refers to mutable field PageID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 LiteDB\Engine\Structures\PagePosition.cs (line 42)

             {
                 int hash = 17;
                 hash = hash * 23 + (int)this.PageID;
▶                hash = hash * 23 + (int)this.Position;
                 return hash;
             }
         }

💬 GetHashCode() refers to mutable field Position (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 18 hits

📄 LiteDB\Document\DataReader\BsonDataReader.cs (line 111)

                     catch (Exception ex)
                     {
                         _state.Handle(ex);
▶                        throw ex;
                     }
                 }
                 else

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 LiteDB\Engine\Query\QueryExecutor.cs (line 139)

                     catch (Exception ex)
                     {
                         _state.Handle(ex);
▶                        throw ex;
                     }
 
                     while (read)

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

📄 LiteDB\Utils\Extensions\LinqExtensions.cs (line 76)

         }
     }
 
▶    internal struct LastItem<T>
     {
         public T Item { get; set; }
         public bool IsLast { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LastItem. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 LiteDB\Utils\Result.cs (line 12)

     /// <summary>
     /// Implement a generic result structure with value and exception. This value can be partial value (like BsonDocument/Array)
     /// </summary>
▶    internal struct Result<T>
         where T : class
     {
         public T Value;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Result. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 24 hits

📄 LiteDB\Document\Json\JsonReader.cs (line 73)

         internal BsonValue ReadValue(Token token)
         {
             var value = token.Value;
▶            switch (token.Type)
             {
                 case TokenType.String: return value;
                 case TokenType.OpenBrace: return this.ReadObject();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 LiteDB\Document\Expression\Methods\Math.cs (line 18)

         /// </summary>
         public static BsonValue ABS(BsonValue value)
         {
▶            switch (value.Type)
             {
                 case BsonType.Int32: return Math.Abs(value.AsInt32); 
                 case BsonType.Int64: return Math.Abs(value.AsInt64); 

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 206 hits

📄 LiteDB\Client\Mapper\Linq\TypeResolver\ConvertResolver.cs (line 16)

     {
         public string ResolveMethod(MethodInfo method)
         {
▶            switch (method.Name)
             {
                 case "ToInt32": return "INT32(@0)";
                 case "ToInt64": return "INT64(@0)";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 LiteDB\Client\Mapper\Linq\TypeResolver\DateTimeResolver.cs (line 16)

     {
         public string ResolveMethod(MethodInfo method)
         {
▶            switch (method.Name)
             {
                 // instance methods
                 case "AddYears": return "DATEADD('y', @0, #)";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS044 Attribute must specify [AttributeUsage] 38 hits

📄 LiteDB\Client\Mapper\Attributes\BsonIgnoreAttribute.cs (line 9)

     /// <summary>
     /// Indicate that property will not be persist in Bson serialization
     /// </summary>
▶    public class BsonIgnoreAttribute : Attribute
     {
     }
 }

💬 BsonIgnoreAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 LiteDB\Client\Mapper\Attributes\BsonRefAttribute.cs (line 9)

     /// <summary>
     /// Indicate that field are not persisted inside this document but it's a reference for another document (DbRef)
     /// </summary>
▶    public class BsonRefAttribute : Attribute
     {
         public string Collection { get; set; }
 

💬 BsonRefAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 10 hits

📄 LiteDB\Client\Mapper\BsonMapper.GetEntityMapper.cs (line 213)

                 MemberMapper mi = null;
                 foreach (MemberMapper member in mapper.Members)
                 {
▶                    if (member.MemberName.ToLower() == par.Name.ToLower() && member.DataType == par.ParameterType)
                     {
                         mi = member;
                         break;

📄 LiteDB\Client\Mapper\BsonMapper.GetEntityMapper.cs (line 213)

                 MemberMapper mi = null;
                 foreach (MemberMapper member in mapper.Members)
                 {
▶                    if (member.MemberName.ToLower() == par.Name.ToLower() && member.DataType == par.ParameterType)
                     {
                         mi = member;
                         break;

SS058 String concatenated in a loop 2 hits

📄 LiteDB.Shell\Shell\InputCommand.cs (line 46)

                     Console.Write("| ");
 
                     var line = this.ReadLine();
▶                    cmd += Environment.NewLine + line;
                 }
             }
 

📄 LiteDB.Shell\Shell\InputCommand.cs (line 46)

                     Console.Write("| ");
 
                     var line = this.ReadLine();
▶                    cmd += Environment.NewLine + line;
                 }
             }
 

SS066 Disposable field is not disposed 186 hits

📄 LiteDB\Engine\Sort\SortService.cs (line 23)

     /// </summary>
     internal class SortService : IDisposable
     {
▶        private readonly SortDisk _disk;
 
         private readonly List<SortContainer> _containers = new List<SortContainer>();
         private readonly int _containerSize;

💬 Disposable field _disk in type SortService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 LiteDB\Engine\Disk\Serializer\BufferWriter.cs (line 14)

     /// </summary>
     internal class BufferWriter : IDisposable
     {
▶        private readonly IEnumerator<BufferSlice> _source;
 
         private BufferSlice _current;
         private int _currentPosition = 0; // position in _current

💬 Disposable field _source in type BufferWriter is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

QRCoder

602 total diagnostics across 4 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 14 hits

📄 QRCoder\PayloadGenerator\BezahlCode.cs (line 217)

                 _currency = currency;
 
                 if (executionDate == null)
▶                    _executionDate = DateTime.Now;
                 else
                 {
                     if (DateTime.Today.Ticks > executionDate.Value.Ticks)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 QRCoder\PayloadGenerator\BezahlCode.cs (line 217)

                 _currency = currency;
 
                 if (executionDate == null)
▶                    _executionDate = DateTime.Now;
                 else
                 {
                     if (DateTime.Today.Ticks > executionDate.Value.Ticks)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 420 hits

📄 QRCoder\ASCIIQRCode.cs (line 54)

         //to keep the QR code as square as possible.
         var quietZonesModifier = (drawQuietZones ? 0 : 8);
         var quietZonesOffset = (int)(quietZonesModifier * 0.5);
▶        var adjustmentValueForNumberOfCharacters = darkColorString.Length / 2 != 1 ? darkColorString.Length / 2 : 0;
         var verticalNumberOfRepeats = repeatPerModule + adjustmentValueForNumberOfCharacters;
         var sideLength = (QrCodeData.ModuleMatrix.Count - quietZonesModifier) * verticalNumberOfRepeats;
         var qrCode = new string[sideLength];

💬 The operands in the divisive expression darkColorString.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 QRCoder\ASCIIQRCode.cs (line 54)

         //to keep the QR code as square as possible.
         var quietZonesModifier = (drawQuietZones ? 0 : 8);
         var quietZonesOffset = (int)(quietZonesModifier * 0.5);
▶        var adjustmentValueForNumberOfCharacters = darkColorString.Length / 2 != 1 ? darkColorString.Length / 2 : 0;
         var verticalNumberOfRepeats = repeatPerModule + adjustmentValueForNumberOfCharacters;
         var sideLength = (QrCodeData.ModuleMatrix.Count - quietZonesModifier) * verticalNumberOfRepeats;
         var qrCode = new string[sideLength];

SS017 Struct without Equals/GetHashCode/ToString overridden 154 hits

📄 QRCoder\QRCodeGenerator\AlignmentPattern.cs (line 9)

     /// Represents the alignment pattern used in QR codes, which helps ensure the code remains readable even if it is somewhat distorted.
     /// Each QR code version has its own specific alignment pattern locations which this struct encapsulates.
     /// </summary>
▶    private struct AlignmentPattern
     {
         /// <summary>
         /// The version of the QR code. Higher versions have more complex and numerous alignment patterns.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AlignmentPattern. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 QRCoder\QRCodeGenerator\AlignmentPattern.cs (line 9)

     /// Represents the alignment pattern used in QR codes, which helps ensure the code remains readable even if it is somewhat distorted.
     /// Each QR code version has its own specific alignment pattern locations which this struct encapsulates.
     /// </summary>
▶    private struct AlignmentPattern
     {
         /// <summary>
         /// The version of the QR code. Higher versions have more complex and numerous alignment patterns.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AlignmentPattern. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS066 Disposable field is not disposed 14 hits

📄 QRCoder\PngByteQRCode.cs (line 172)

             Indexed = 3
         }
 
▶        private MemoryStream _stream = new MemoryStream();
 
         public void Dispose()
         {

💬 Disposable field _stream in type PngBuilder is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 QRCoder\PngByteQRCode.cs (line 172)

             Indexed = 3
         }
 
▶        private MemoryStream _stream = new MemoryStream();
 
         public void Dispose()
         {

💬 Disposable field _stream in type PngBuilder is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Akka.NET

590 total diagnostics across 16 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 16 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 70 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 20 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 112 hits

No source samples extracted

SS015 String placeholders in wrong order 4 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 116 hits

No source samples extracted

SS018 Switch does not handle all enum options 16 hits

No source samples extracted

SS019 Switch is missing default label 80 hits

No source samples extracted

SS023 Exception thrown from property getter 56 hits

No source samples extracted

SS034 Accessing Task.Result without await 48 hits

No source samples extracted

SS046 Unbounded stackalloc 8 hits

No source samples extracted

SS047 LINQ traversal before filter 4 hits

No source samples extracted

SS048 Locking on discouraged object (string, Type, this) 4 hits

No source samples extracted

SS052 [ThreadStatic] field with initializer 8 hits

No source samples extracted

SS058 String concatenated in a loop 8 hits

No source samples extracted

SS066 Disposable field is not disposed 20 hits

No source samples extracted

FastEndpoints

588 total diagnostics across 17 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 58 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 14 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 34 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 94 hits

No source samples extracted

SS018 Switch does not handle all enum options 6 hits

No source samples extracted

SS019 Switch is missing default label 130 hits

No source samples extracted

SS024 Exception thrown from static constructor 18 hits

No source samples extracted

SS033 Async overload is available 106 hits

No source samples extracted

SS037 HttpClient instantiated directly 20 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 8 hits

No source samples extracted

SS047 LINQ traversal before filter 6 hits

No source samples extracted

SS053 Pointless collection ToString() 10 hits

No source samples extracted

SS056 HttpRequest.Form read synchronously 30 hits

No source samples extracted

SS057 Collection manipulated during traversal 18 hits

No source samples extracted

SS058 String concatenated in a loop 6 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 6 hits

No source samples extracted

SS066 Disposable field is not disposed 24 hits

No source samples extracted

lively

586 total diagnostics across 11 rules

SS001 Async method with void return type 6 hits

📄 src\Lively\Lively.Common\Extensions\TaskExtensions.cs (line 11)

     {
         //Ref: https://www.youtube.com/watch?v=O1Tx-k4Vao0
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Major Bug", "S3168:\"async\" methods should not return \"void\"", Justification = "Error is handled as event")]
▶        public async static void Await(this Task task, Action completedCallBack, Action<Exception> errorCallBack)
         {
             try
             {

💬 Method Await is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Lively\Lively.Common.Services\HardwareUsageService.cs (line 79)

             }
         }
 
▶        private async void HWMonitorLoop()
         {
             try
             {

💬 Method HWMonitorLoop is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 20 hits

📄 src\Lively\Lively.Common.Services\GithubUpdaterService.cs (line 59)

 
         private void RetryTimer_Elapsed(object sender, System.Timers.ElapsedEventArgs e)
         {
▶            if ((DateTime.Now - LastCheckTime).TotalMilliseconds > (Status != AppUpdateStatus.error ? fetchDelayRepeat : fetchDelayError))
             {
                 _ = CheckUpdate(0);
             }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Lively\Lively.Common.Services\GithubUpdaterService.cs (line 100)

                 Debug.WriteLine("Update fetch error:" + e.ToString());
                 Status = AppUpdateStatus.error;
             }
▶            LastCheckTime = DateTime.Now;
 
             UpdateChecked?.Invoke(this,
                 new AppUpdaterEventArgs(Status,

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 110 hits

📄 src\Lively\Lively.ML\Helpers\ImageUtil.cs (line 21)

             var pixels = image.GetPixels();
             for (int i = 0; i < floatArray.Length; i++)
             {
▶                pixels.SetPixel(i % width, i / width, new byte[] { (byte)(floatArray[i] * Quantum.Max), (byte)(floatArray[i] * Quantum.Max), (byte)(floatArray[i] * Quantum.Max) });
             }
             return image;
         }

💬 The operands in the divisive expression i / width are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Lively\Lively.Common\Helpers\Hardware\SystemInfo.cs (line 129)

         public static long GetTotalInstalledMemory()
         {
             GetPhysicallyInstalledSystemMemory(out long memKb);
▶            return (memKb / 1024);
         }
     }
 }

💬 The operands in the divisive expression memKb / 1024 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 src\Lively\Lively\Commandline\CommandHandler.cs (line 199)

 
                                         // Select a random wallpaper that is Not already used and Not the same as the current wallpaper on this screen.
                                         var newWallpaper =
▶                                            wallpapers.FirstOrDefault(x => (currentWallpaper == null || x.LivelyInfoFolderPath != currentWallpaper.Model.LivelyInfoFolderPath) && !usedWallpapers.Contains(x))
                                             // Fallback if all match currentWallpaper
                                             ?? wallpapers.FirstOrDefault(x => !usedWallpapers.Contains(x))
                                             // Fallback to the first wallpaper if all are used

💬 Type LibraryModel is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Lively\Lively\Commandline\CommandHandler.cs (line 201)

                                         var newWallpaper =
                                             wallpapers.FirstOrDefault(x => (currentWallpaper == null || x.LivelyInfoFolderPath != currentWallpaper.Model.LivelyInfoFolderPath) && !usedWallpapers.Contains(x))
                                             // Fallback if all match currentWallpaper
▶                                            ?? wallpapers.FirstOrDefault(x => !usedWallpapers.Contains(x))
                                             // Fallback to the first wallpaper if all are used
                                             ?? wallpapers.First();
 

SS017 Struct without Equals/GetHashCode/ToString overridden 32 hits

📄 src\Lively\Lively.Common\Helpers\Pinvoke\DwmThumbnailWrapper.cs (line 97)

         #region native
 
         [StructLayout(LayoutKind.Sequential)]
▶        internal struct DWM_THUMBNAIL_PROPERTIES
         {
             public int dwFlags;
             public RECT rcDestination;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DWM_THUMBNAIL_PROPERTIES. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Lively\Lively.Common\Helpers\Shell\ThumbnailUtil.cs (line 86)

         }
 
         [StructLayout(LayoutKind.Sequential)]
▶        internal struct NativeSize
         {
             private int width;
             private int height;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NativeSize. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 28 hits

📄 src\Lively\Lively\Views\WindowMsg\RawInputMsgWindow.xaml.cs (line 96)

                             break;
                         }
 
▶                        switch (mouse.Mouse.Buttons)
                         {
                             case Linearstar.Windows.RawInput.Native.RawMouseButtonFlags.LeftButtonDown:
                                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Lively\Lively\Core\Wallpapers\WebWebView2.cs (line 265)

                 }
 
                 // Process message
▶                switch (obj.Type)
                 {
                     case MessageType.msg_hwnd:
                         if (!isInitialized)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 182 hits

📄 src\Lively\Lively.Common\Factories\WallpaperLibraryFactory.cs (line 183)

             if (!metadata.IsAbsolutePath)
                 return;
 
▶            switch (metadata.Type)
             {
                 case WallpaperType.video:
                 case WallpaperType.gif:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Lively\Lively.Common\Helpers\LivelyPropertyUtil.cs (line 102)

                     continue;
 
                 var value = localized.Value;
▶                switch (control.Type)
                 {
                     case "dropdown":
                     case "scalerDropdown":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 6 hits

📄 src\Lively\Lively.Gallery.Client\GalleryClient.cs (line 92)

                     _server.Routes.Static.Add(WatsonWebserver.HttpMethod.GET, "signin-oidc", GoogleCallback);
                     break;
             }
▶            _server.Start();
 
             LinkUtil.OpenBrowser(
                 provider switch

💬 Async overload available for Server.Start (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Lively\Lively\Helpers\CaptureScreen.cs (line 140)

                         // Optionally optimize the images (images should have the same size).
                         collection.Optimize();
                         // Save image to disk.
▶                        collection.Write(savePath);
                     }
                 }
                 finally

💬 Async overload available for MagickImageCollection.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 36 hits

📄 src\Lively\Lively\Core\Wallpapers\WebWebView2.cs (line 191)

                 process.BeginOutputReadLine();
 
                 await tcsProcessWait.Task;
▶                if (tcsProcessWait.Task.Result is not null)
                     throw tcsProcessWait.Task.Result;
             }
             catch (Exception)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Lively\Lively\Core\Wallpapers\WebWebView2.cs (line 192)

 
                 await tcsProcessWait.Task;
                 if (tcsProcessWait.Task.Result is not null)
▶                    throw tcsProcessWait.Task.Result;
             }
             catch (Exception)
             {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS059 IAsyncDisposable not disposed asynchronously 26 hits

📄 src\Lively\Lively.Common.Services\HttpDownloadService.cs (line 27)

                 if (!string.IsNullOrEmpty(directory))
                     Directory.CreateDirectory(directory);
 
▶                using var stream = File.Create(filePath);
                 await DownloadFileAsync(url, stream, cancellationToken, (downloadedBytes, totalBytes) =>
                 {
                     var downloadedInMB = Math.Truncate(ByteToMegabyte(downloadedBytes));

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Lively\Lively.Common.Services\HttpDownloadService.cs (line 80)

             if (progressCallback != null)
             {
                 long length = response.Content.Headers.ContentLength ?? -1;
▶                using var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
                 byte[] buffer = new byte[4096];
                 int read;
                 int totalRead = 0;

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 128 hits

📄 src\Lively\Lively.ML\DepthEstimate\MiDaS.cs (line 17)

     public class MiDaS : IDepthEstimate
     {
         public string ModelPath { get; private set; }
▶        private InferenceSession session;
         private string inputName;
         private int width, height;
         private bool disposedValue;

💬 Disposable field session in type MiDaS is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Lively\Lively.Grpc.Client\DisplayManagerClient.cs (line 27)

         public System.Drawing.Rectangle VirtulScreenBounds { get; private set; }
 
         private readonly DisplayService.DisplayServiceClient client;
▶        private readonly SemaphoreSlim displayChangedLock = new SemaphoreSlim(1, 1);
         private readonly CancellationTokenSource cancellationTokeneDisplayChanged;
         private readonly Task displayChangedTask;
         private bool disposedValue;

💬 Disposable field displayChangedLock in type DisplayManagerClient is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

netmq

582 total diagnostics across 14 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 44 hits

📄 src\NetMQ.Tests\PgmTests.cs (line 284)

 
                         monitor.Closed += (sender, args) => closed.Set();
 
▶                        var time = DateTime.Now;
 
                         sub.Unbind(address);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\NetMQ.Tests\RequestWithRetryTests.cs (line 27)

             using (var server = new ResponseSocket(address))
             {
                 progressSubscriber.SubscribeToAnyTopic();
▶                var progressProactor = new NetMQProactor(progressSubscriber, (socket, message) => Debug.WriteLine("C: {0} {1:ss.fff}", message[0].ConvertToString(), DateTime.Now));
 
                 var serverProactor = new NetMQProactor(server, (socket, message) =>
                 {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 72 hits

📄 src\NetMQ\Core\Utils\Clock.cs (line 90)

 
             if (tsc == 0)
             {
▶                return NowUs() / 1000;
             }
 
             if (tsc - s_lastTsc <= Config.ClockPrecision / 2 && tsc >= s_lastTsc)

💬 The operands in the divisive expression NowUs() / 1000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\NetMQ\Core\Utils\Clock.cs (line 93)

                 return NowUs() / 1000;
             }
 
▶            if (tsc - s_lastTsc <= Config.ClockPrecision / 2 && tsc >= s_lastTsc)
             {
                 return s_lastTime;
             }

💬 The operands in the divisive expression Config.ClockPrecision / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 144 hits

📄 src\NetMQ\Core\Utils\Proactor.cs (line 74)

         public void AddSocket(AsyncSocket socket, IProactorEvents proactorEvents)
         {
             var item = new Item(proactorEvents);
▶            m_sockets.Add(socket, item);
 
             m_completionPort.AssociateSocket(socket, item);
             AdjustLoad(1);

💬 Type AsyncSocket is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\NetMQ\Core\Utils\Proactor.cs (line 84)

         {
             AdjustLoad(-1);
 
▶            var item = m_sockets[socket];
             m_sockets.Remove(socket);
             item.Cancelled = true;
         }

SS008 GetHashCode() refers to mutable or static member 96 hits

📄 src\NetMQ\RoutingKey.cs (line 118)

         {
             unchecked
             {
▶                int remainder = bytes.Length & 3;
                 int alignedLength = bytes.Length - remainder;
 
                 uint hash = 0;

💬 GetHashCode() refers to mutable field bytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\NetMQ\RoutingKey.cs (line 119)

             unchecked
             {
                 int remainder = bytes.Length & 3;
▶                int alignedLength = bytes.Length - remainder;
 
                 uint hash = 0;
 

💬 GetHashCode() refers to mutable field bytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 18 hits

📄 src\NetMQ\Core\Command.cs (line 27)

     /// <summary>
     /// Defines a command sent between threads.
     /// </summary>
▶    internal struct Command
     {
         /// <summary>
         /// Create a new Command object for the given destination, type, and optional argument.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Command. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\NetMQ\NetMQBeacon.cs (line 534)

     /// <summary>
     /// Contents of a message received from a beacon.
     /// </summary>
▶    public struct BeaconMessage
     {
         /// <summary>
         /// THe beacon content as a byte array.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BeaconMessage. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 24 hits

📄 src\NetMQ\Core\Patterns\Router.cs (line 186)

         {
             T Get<T>() => optval is T v ? v : throw new ArgumentException($"Option {option} value must be of type {typeof(T).Name}.");
 
▶            switch (option)
             {
                 case ZmqSocketOption.RouterRawSocket:
                     m_rawSocket = Get<bool>();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\NetMQ\Core\Patterns\XPub.cs (line 227)

         {
             T Get<T>() => optionValue is T v ? v : throw new ArgumentException($"Option {option} value must be of type {typeof(T).Name}.");
 
▶            switch (option)
             {
                 case ZmqSocketOption.XpubVerbose:
                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 90 hits

📄 src\NetMQ\Core\Address.cs (line 115)

         {
             if (Resolved != null)
             {
▶                switch (Protocol)
                 {
                     case TcpProtocol: return Resolved!.ToString()!;
                     case IpcProtocol: return Resolved!.ToString()!;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\NetMQ\RoutingKey.cs (line 142)

                     uint k = 0;
 
                     // determine how many bytes we have left to work with based on length
▶                    switch (remainder)
                     {
                         case 3:
                             k ^= (uint)bytes[alignedLength + 2] << 16;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS027 Exception thrown from Dispose 12 hits

📄 src\NetMQ\NetMQPoller.cs (line 708)

             // Attempting to dispose from the poller thread would cause a deadlock.
             // Throw an exception to improve the debugging experience.
             if (IsPollerThread)
▶                throw new InvalidOperationException("Cannot dispose poller from the poller thread.");
 
             if (Interlocked.CompareExchange(ref m_disposeState, (int)DisposeState.Disposing, (int)DisposeState.Undisposed) != (int)DisposeState.Undisposed)
                 return;

💬 An exception is thrown from the Dispose() method in type NetMQPoller (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 src\NetMQ\NetMQPoller.cs (line 731)

             foreach (var socket in m_sockets)
             {
                 if (socket.IsDisposed)
▶                    throw new NetMQException($"Invalid state detected: {nameof(NetMQPoller)} contains a disposed {nameof(NetMQSocket)}. Sockets must be either removed before being disposed, or disposed after the poller is disposed.");
                 socket.EventsChanged -= OnSocketEventsChanged;
             }
 

💬 An exception is thrown from the Dispose() method in type NetMQPoller (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS032 Thread.Sleep used in async method 4 hits

📄 src\NetMQ.Tests\NetMQMonitorTests.cs (line 68)

             using (var monitor = new NetMQMonitor(rep, "inproc://foo", SocketEvents.Closed))
             {
                 var task = monitor.StartAsync();
▶                Thread.Sleep(200);
                 Assert.Equal(TaskStatus.Running, task.Status);
                 monitor.Stop();
                 var completedTask = await Task.WhenAny(task, Task.Delay(1000));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\NetMQ.Tests\NetMQMonitorTests.cs (line 68)

             using (var monitor = new NetMQMonitor(rep, "inproc://foo", SocketEvents.Closed))
             {
                 var task = monitor.StartAsync();
▶                Thread.Sleep(200);
                 Assert.Equal(TaskStatus.Running, task.Status);
                 monitor.Stop();
                 var completedTask = await Task.WhenAny(task, Task.Delay(1000));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 12 hits

📄 src\NetMQ.Tests\ClientServer.cs (line 146)

 
             for (int i = 0; i < 15000; i++)
             {
▶                client.Send("0");
             }
             
             // Send the end message to both of the threads

💬 Async overload available for SendThreadSafeSocketExtensions.Send (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\NetMQ.Tests\ClientServer.cs (line 150)

             }
             
             // Send the end message to both of the threads
▶            client.Send("1");
             client.Send("1");
 
             await Task.WhenAll(t1, t2);

💬 Async overload available for SendThreadSafeSocketExtensions.Send (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 src\NetMQ\NetMQPoller.cs (line 752)

         object ISynchronizeInvoke.EndInvoke(IAsyncResult result)
         {
             var task = (Task<object>)result;
▶            return task.Result;
         }
 
         object? ISynchronizeInvoke.Invoke(Delegate method, object?[]? args)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\NetMQ\NetMQPoller.cs (line 762)

 
             var task = new Task<object?>(() => method.DynamicInvoke(args));
             task.Start(this);
▶            return task.Result;
         }
 
         bool ISynchronizeInvoke.InvokeRequired => !CanExecuteTaskInline;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS051 Locking on mutable reference 12 hits

📄 src\NetMQ\Core\MailboxSafe.cs (line 62)

 
         public void Send(Command cmd)
         {
▶            lock (m_sync)
             {
                 m_commandPipe.Write(ref cmd, false);
                 bool ok = m_commandPipe.Flush();

💬 A lock was obtained on m_sync but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\NetMQ\Core\SocketBase.cs (line 1197)

                 m_handle = ((Mailbox)m_mailbox).Handle;
             else
             {
▶                lock (m_threadSafeSync)
                 {
                     m_reaperSignaler = new Signaler();
                     m_handle = m_reaperSignaler.Handle;

💬 A lock was obtained on m_threadSafeSync but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS058 String concatenated in a loop 6 hits

📄 src\NetMQ\NetMQCertificate.cs (line 49)

                     UInt32 divisor = 85 * 85 * 85 * 85;
                     while (divisor != 0) 
                     {
▶                        dest += Encoder[(int)(value / divisor % 85)];
                         divisor /= 85;
                     }
                     value = 0;

📄 src\NetMQ\NetMQCertificate.cs (line 49)

                     UInt32 divisor = 85 * 85 * 85 * 85;
                     while (divisor != 0) 
                     {
▶                        dest += Encoder[(int)(value / divisor % 85)];
                         divisor /= 85;
                     }
                     value = 0;

SS066 Disposable field is not disposed 36 hits

📄 src\NetMQ\Core\Mechanisms\CurveMechanismBase.cs (line 26)

 
         protected UInt64 m_nonce;
         protected UInt64 m_peerNonce;
▶        protected Curve25519XSalsa20Poly1305? m_box;
 
         protected CurveMechanismBase(SessionBase session, Options options,
             string encodeNoncePrefix, string decodeNoncePrefix) : base(session, options)

💬 Disposable field m_box in type CurveMechanismBase is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\NetMQ\NetMQSocket.cs (line 25)

         private EventHandler<NetMQSocketEventArgs>? m_sendReady;
         private int m_isClosed;
 
▶        private NetMQRuntime? m_runtime;
 
         internal enum DefaultAction
         {

💬 Disposable field m_runtime in type NetMQSocket is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

MassTransit

548 total diagnostics across 12 rules

SS003 Integer divided by integer causing implicit rounding 70 hits

No source samples extracted

SS007 [Flags] enum values are not powers of two 10 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 162 hits

No source samples extracted

SS018 Switch does not handle all enum options 4 hits

No source samples extracted

SS019 Switch is missing default label 28 hits

No source samples extracted

SS022 Exception thrown from implicit operator 20 hits

No source samples extracted

SS033 Async overload is available 24 hits

No source samples extracted

SS034 Accessing Task.Result without await 30 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 10 hits

No source samples extracted

SS046 Unbounded stackalloc 10 hits

No source samples extracted

SS048 Locking on discouraged object (string, Type, this) 140 hits

No source samples extracted

SS066 Disposable field is not disposed 40 hits

No source samples extracted

SharpZipLib

544 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 30 hits

📄 src\ICSharpCode.SharpZipLib\Zip\ZipEntryFactory.cs (line 366)

 		#region Instance Fields
 
 		private INameTransform nameTransform_;
▶		private DateTime fixedDateTime_ = DateTime.Now;
 		private TimeSetting timeSetting_ = TimeSetting.LastWriteTime;
 		private bool isUnicodeText_;
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\ICSharpCode.SharpZipLib\Core\StreamUtils.cs (line 226)

 
 			bool copying = true;
 
▶			DateTime marker = DateTime.Now;
 			long processed = 0;
 			long target = 0;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 150 hits

📄 src\ICSharpCode.SharpZipLib\BZip2\BZip2Constants.cs (line 110)

 		/// <summary>
 		/// Backend constant
 		/// </summary>
▶		public const int MaximumSelectors = (2 + (900000 / GroupSize));
 
 		/// <summary>
 		/// Backend constant

💬 The operands in the divisive expression 900000 / GroupSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\ICSharpCode.SharpZipLib\Zip\Compression\DeflaterConstants.cs (line 84)

 		/// <summary>
 		/// Internal compression engine constant
 		/// </summary>
▶		public const int HASH_SHIFT = (HASH_BITS + MIN_MATCH - 1) / MIN_MATCH;
 
 		/// <summary>
 		/// Internal compression engine constant

💬 The operands in the divisive expression (HASH_BITS + MIN_MATCH - 1) / MIN_MATCH are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 src\ICSharpCode.SharpZipLib\Tar\TarEntry.cs (line 160)

 		/// <returns>A Hash code for the current <see cref="Object"/></returns>
 		public override int GetHashCode()
 		{
▶			return Name.GetHashCode();
 		}
 
 		/// <summary>

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\ICSharpCode.SharpZipLib\Tar\TarHeader.cs (line 684)

 		/// <returns>A hash code for the current object.</returns>
 		public override int GetHashCode()
 		{
▶			return Name.GetHashCode();
 		}
 
 		/// <summary>

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 18 hits

📄 src\ICSharpCode.SharpZipLib\BZip2\BZip2OutputStream.cs (line 2026)

 			return b;
 		}
 
▶		private struct StackElement
 		{
 			public int ll;
 			public int hh;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct StackElement. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\ICSharpCode.SharpZipLib\Zip\ZipFormat.cs (line 36)

 		}
 	}
 
▶	internal struct EntryPatchData
 	{
 		public long SizePatchOffset { get; set; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EntryPatchData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 12 hits

📄 src\ICSharpCode.SharpZipLib\Zip\FastZip.cs (line 691)

 			// (it might have been set up by the entry factory, and if so we let that take precedence)
 			if (!string.IsNullOrEmpty(Password) && entry.AESEncryptionStrength == 0)
 			{
▶				switch (EntryEncryptionMethod)
 				{
 					case ZipEncryptionMethod.AES128:
 						entry.AESKeySize = 128;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\ICSharpCode.SharpZipLib\Zip\ZipInputStream.cs (line 699)

 
 			bool finished = false;
 
▶			switch (method)
 			{
 				case CompressionMethod.Deflated:
 					count = base.Read(buffer, offset, count);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 66 hits

📄 src\ICSharpCode.SharpZipLib\BZip2\BZip2InputStream.cs (line 301)

 			}
 
 			int retChar = currentChar;
▶			switch (currentState)
 			{
 				case RAND_PART_B_STATE:
 					SetupRandPartB();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\ICSharpCode.SharpZipLib\BZip2\BZip2OutputStream.cs (line 1768)

 						zPend--;
 						while (true)
 						{
▶							switch (zPend % 2)
 							{
 								case 0:
 									szptr[wr] = (short)BZip2Constants.RunA;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 84 hits

📄 src\ICSharpCode.SharpZipLib\Core\ExactMemoryPool.cs (line 51)

 					T[] array = this.array;
 					if (array == null)
 					{
▶						throw new ObjectDisposedException(nameof(ExactMemoryPoolBuffer));
 					}
 
 					return new Memory<T>(array).Slice(0, size);

💬 An exception is thrown from the getter of property Memory (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\ICSharpCode.SharpZipLib\Tar\TarArchive.cs (line 276)

 			{
 				if (isDisposed)
 				{
▶					throw new ObjectDisposedException("TarArchive");
 				}
 
 				return asciiTranslate;

💬 An exception is thrown from the getter of property AsciiTranslate (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 6 hits

📄 src\ICSharpCode.SharpZipLib\Zip\Compression\InflaterHuffmanTree.cs (line 68)

 			}
 			catch (Exception)
 			{
▶				throw new SharpZipBaseException("InflaterHuffmanTree: static tree length illegal");
 			}
 		}
 

💬 An exception is thrown from InflaterHuffmanTree its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 src\ICSharpCode.SharpZipLib\Zip\Compression\InflaterHuffmanTree.cs (line 68)

 			}
 			catch (Exception)
 			{
▶				throw new SharpZipBaseException("InflaterHuffmanTree: static tree length illegal");
 			}
 		}
 

💬 An exception is thrown from InflaterHuffmanTree its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS033 Async overload is available 74 hits

📄 src\ICSharpCode.SharpZipLib\GZip\GzipOutputStream.cs (line 169)

 				}
 				else
 				{
▶					WriteHeader();
 				}
 			}
 

💬 Async overload available for GZipOutputStream.WriteHeader (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\ICSharpCode.SharpZipLib\GZip\GzipOutputStream.cs (line 184)

 			}
 			else
 			{
▶				base.Write(buffer, offset, count);
 			}
 		}
 

💬 Async overload available for DeflaterOutputStream.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS051 Locking on mutable reference 24 hits

📄 src\ICSharpCode.SharpZipLib\Zip\ZipFile.cs (line 1179)

 		/// <returns>The offset of the entries data in the file</returns>
 		private long TestLocalHeader(ZipEntry entry, HeaderTest tests)
 		{
▶			lock (baseStream_)
 			{
 				bool testHeader = (tests & HeaderTest.Header) != 0;
 				bool testData = (tests & HeaderTest.Extract) != 0;

💬 A lock was obtained on baseStream_ but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\ICSharpCode.SharpZipLib\Zip\ZipFile.cs (line 3448)

 
 				if (IsStreamOwner && (baseStream_ != null))
 				{
▶					lock (baseStream_)
 					{
 						baseStream_.Dispose();
 					}

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 src\ICSharpCode.SharpZipLib\Core\StreamUtils.cs (line 289)

 		
 		internal static async Task WriteProcToStreamAsync(this Stream targetStream, Action<Stream> writeProc, CancellationToken ct)
 		{
▶			using (var ms = new MemoryStream())
 			{
 				await WriteProcToStreamAsync(targetStream, ms, writeProc, ct).ConfigureAwait(false);
 			}

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\ICSharpCode.SharpZipLib\Zip\ZipOutputStream.cs (line 913)

 		/// <inheritdoc cref="Finish"/>>
 		public override async Task FinishAsync(CancellationToken ct)
 		{
▶			using (var ms = new MemoryStream())
 			{
 				if (entries == null)
 				{

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 60 hits

📄 src\ICSharpCode.SharpZipLib\Tar\TarOutputStream.cs (line 602)

 		/// <summary>
 		/// the destination stream for the archive contents
 		/// </summary>
▶		protected Stream outputStream;
 
 		/// <summary>
 		/// name encoding

💬 Disposable field outputStream in type TarOutputStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\ICSharpCode.SharpZipLib\Encryption\ZipAESStream.cs (line 51)

 		// total length of block + auth code
 		private const int BLOCK_AND_AUTH = CRYPTO_BLOCK_SIZE + AUTH_CODE_LENGTH;
 
▶		private Stream _stream;
 		private ZipAESTransform _transform;
 		private byte[] _slideBuffer;
 		private int _slideBufStartPos;

💬 Disposable field _stream in type ZipAESStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

LiteMonitor

542 total diagnostics across 11 rules

SS001 Async method with void return type 10 hits

📄 src\UI\Settings\TaskbarPage.cs (line 61)

             PopulateFonts();
         }
 
▶        private async void PopulateFonts()
         {
             if (_cbFont == null || _cbFont.Inner.Items.Count > 5) return; 
 

💬 Method PopulateFonts is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\UI\Settings\SystemHardwarPage.cs (line 48)

         }
 
         // 将 PopulateAsyncData 改为“批量处理”模式
▶        private async void PopulateAsyncData()
         {
             try 
             {

💬 Method PopulateAsyncData is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 98 hits

📄 LiteMonitor.Updater\Program.cs (line 301)

             try
             {
                 File.AppendAllText(Path.Combine(dir, "update_error.log"),
▶                    DateTime.Now + " " + msg + Environment.NewLine);
             }
             catch { }
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\System\HardwareMonitor.cs (line 45)

         private long _tickCounter = 0;
         private double _secondAccumulator = 0;
         private long _secondsCounter = 0;
▶        private DateTime _lastTrafficTime = DateTime.Now;
         #endregion
 
         #region Public Properties

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 102 hits

📄 src\Core\UIUtils.cs (line 87)

                     // Cache eviction policy
                     if (_brushCache.Count >= MAX_BRUSH_CACHE)
                     {
▶                        var keysToRemove = _brushCache.Keys.Take(_brushCache.Count / 2).ToList();
                         foreach (var k in keysToRemove)
                         {
                             if (_brushCache.TryGetValue(k, out var oldBrush))

💬 The operands in the divisive expression _brushCache.Count / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\UI\HorizontalLayout.cs (line 59)

             
             var s = _settings.GetStyle();
             int pad = _padding;
▶            int padV = _padding / 2;
             bool isTaskbarSingle = (_mode == LayoutMode.Taskbar && _settings.TaskbarSingleLine);
             bool isHorizontalSingle = (_mode == LayoutMode.Horizontal && _settings.HorizontalSingleLine);
 

💬 The operands in the divisive expression _padding / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 8 hits

📄 src\UI\Settings\MonitorPage.cs (line 456)

                     var newVisibleList = uiRows.Select(r => r.Config).ToList();
                     
                     var fullList = _workingList.OrderBy(x => x.TaskbarSortIndex).ToList();
▶                    var oldVisibleList = fullList.Where(x => newVisibleList.Contains(x)).ToList();
 
                     var lcs = GetLCS(oldVisibleList, newVisibleList);
                     var anchors = new HashSet<MonitorItemConfig>(lcs);

💬 Type MonitorItemConfig is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\UI\Settings\MonitorPage.cs (line 464)

                     var backbone = new List<MonitorItemConfig>();
                     foreach (var item in fullList)
                     {
▶                        if (!newVisibleList.Contains(item) || anchors.Contains(item))
                         {
                             backbone.Add(item);
                         }

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 src\Core\Settings.cs (line 156)

         public List<PluginInstanceConfig> PluginInstances { get; set; } = new List<PluginInstanceConfig>();
 
         // ★★★ [新增] 极简样式封装（复制到 Settings 类里） ★★★
▶        public struct TBStyle { 
             public string Font; public float Size; public bool Bold; 
             public int Gap; public int Inner; public int VOff; 
         }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TBStyle. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\System\HardwareServices\FpsCounter.cs (line 95)

         /// 内部结构体：一次采样的记录
         /// 存储某段时间内的帧数和持续时间
         /// </summary>
▶        private struct FrameSample
         {
             public int Count;       // 这一段收到的帧数
             public double Duration; // 这一段花费的时间(秒)

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FrameSample. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 2 hits

📄 src\Plugins\PluginProcessor.cs (line 98)

 
                 string val = context[src];
 
▶                switch (t.Function)
                 {
                     case "regex_replace":
                         val = ApplyRegexReplace(val, t, context);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Plugins\PluginProcessor.cs (line 98)

 
                 string val = context[src];
 
▶                switch (t.Function)
                 {
                     case "regex_replace":
                         val = ApplyRegexReplace(val, t, context);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 6 hits

📄 src\Core\NetworkSpeedTester.cs (line 281)

             catch (TaskCanceledException) { }
 
             // 取消所有任务
▶            cts.Cancel();
             
             // 优化点3：增加 Task.WhenAll 的等待时限，避免卡死在收尾阶段
             try

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Core\NetworkSpeedTester.cs (line 404)

             }
             catch (TaskCanceledException) { }
 
▶            cts.Cancel();
             
             // 优化点3：增加 Task.WhenAll 的等待时限
             try

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 src\UI\Settings\SystemHardwarPage.cs (line 87)

                 }
 
                 // 3. 瞬间填入所有数据 (因为布局被挂起，用户看不见中间过程)
▶                FillSync(_cbDisk, taskDisks.Result, Config.PreferredDisk);
                 FillSync(_cbNet, taskNets.Result, Config.PreferredNetwork);
                 FillSync(_cbMobo, taskMobo.Result, Config.PreferredMoboTemp);
                 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\UI\Settings\SystemHardwarPage.cs (line 88)

 
                 // 3. 瞬间填入所有数据 (因为布局被挂起，用户看不见中间过程)
                 FillSync(_cbDisk, taskDisks.Result, Config.PreferredDisk);
▶                FillSync(_cbNet, taskNets.Result, Config.PreferredNetwork);
                 FillSync(_cbMobo, taskMobo.Result, Config.PreferredMoboTemp);
                 
                 // Fan 的数据是复用的

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 26 hits

📄 src\UI\UpdateDialog.cs (line 38)

         
         private CancellationTokenSource? _cts;
         private Stopwatch _speedWatch;
▶        private bool IsChinese => _settings?.Language?.ToLower() == "zh";
 
         public UpdateDialog(DownloadContext context, Settings settings)
         {

📄 src\System\UpdateChecker.cs (line 134)

                     var sortedUrls = await GetSortedZipUrls(latest);
 
                     // ---- 加载设置并弹出更新窗口 ----
▶                    bool isZh = settings?.Language?.ToLower() == "zh";
 
                     var context = new DownloadContext
                     {

SS059 IAsyncDisposable not disposed asynchronously 14 hits

📄 src\System\UpdateChecker.cs (line 287)

                 if (!resp.IsSuccessStatusCode)
                     return (url, 0);
 
▶                using var stream = await resp.Content.ReadAsStreamAsync();
 
                 byte[] testBuf = new byte[32 * 1024];
                 int read = await stream.ReadAsync(testBuf, 0, testBuf.Length);

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Core\NetworkSpeedTester.cs (line 132)

                                     continue;
                                 }
 
▶                                using var stream = await resp.Content.ReadAsStreamAsync();
                                 var sw = Stopwatch.StartNew();
                                 
                                 // 持续读取直到竞速时间结束

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 256 hits

📄 src\UI\Controls\LiteUI.cs (line 431)

 
     public class LiteColorInput : Panel
     {
▶        public LiteUnderlineInput Input;
         public LiteColorPicker Picker;
         public string HexValue { get => Input.Inner.Text; set { Input.Inner.Text = value; Picker.SetHex(value); } }
 

💬 Disposable field Input in type LiteColorInput is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\UI\Controls\LiteUI.cs (line 432)

     public class LiteColorInput : Panel
     {
         public LiteUnderlineInput Input;
▶        public LiteColorPicker Picker;
         public string HexValue { get => Input.Inner.Text; set { Input.Inner.Text = value; Picker.SetHex(value); } }
 
         public LiteColorInput(string initialHex)

💬 Disposable field Picker in type LiteColorInput is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

libgit2sharp

540 total diagnostics across 10 rules

SS003 Integer divided by integer causing implicit rounding 6 hits

📄 LibGit2Sharp.Tests\FilterFixture.cs (line 351)

             }
 
             int len = count * sizeof(char);
▶            int cnt = len / sizeof(long);
 
             fixed (char* c1 = array1, c2 = array2)
             {

💬 The operands in the divisive expression len / sizeof(long) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 LibGit2Sharp.Tests\FilterFixture.cs (line 351)

             }
 
             int len = count * sizeof(char);
▶            int cnt = len / sizeof(long);
 
             fixed (char* c1 = array1, c2 = array2)
             {

SS008 GetHashCode() refers to mutable or static member 72 hits

📄 LibGit2Sharp\Worktree.cs (line 117)

         /// <returns>A 32-bit signed integer hash code.</returns>
         public override int GetHashCode()
         {
▶            return equalityHelper.GetHashCode(this);
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field equalityHelper (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 LibGit2Sharp\BlameHunk.cs (line 153)

         /// <returns>A 32-bit signed integer hash code.</returns>
         public override int GetHashCode()
         {
▶            return equalityHelper.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field equalityHelper (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS015 String placeholders in wrong order 6 hits

📄 LibGit2Sharp.Tests\FetchFixture.cs (line 126)

             {
                 repo.Network.Remotes.Add(remoteName, url);
 
▶                string refSpec = string.Format("refs/heads/{2}:refs/remotes/{0}/{1}", remoteName, localBranchName, remoteBranchName);
 
                 // Set up structures for the expected results
                 // and verifying the RemoteUpdateTips callback.

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 LibGit2Sharp.Tests\FetchFixture.cs (line 126)

             {
                 repo.Network.Remotes.Add(remoteName, url);
 
▶                string refSpec = string.Format("refs/heads/{2}:refs/remotes/{0}/{1}", remoteName, localBranchName, remoteBranchName);
 
                 // Set up structures for the expected results
                 // and verifying the RemoteUpdateTips callback.

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 278 hits

📄 LibGit2Sharp\SignatureInfo.cs (line 8)

     /// <summary>
     /// Structure for holding a signature extracted from a commit or a tag
     /// </summary>
▶    public struct SignatureInfo
     {
         /// <summary>
         /// The signature data, PGP/GPG or otherwise.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SignatureInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 LibGit2Sharp\RebaseOperationImpl.cs (line 201)

             }
         }
 
▶        private struct RebaseProgress
         {
             public long current;
             public long total;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RebaseProgress. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 20 hits

📄 LibGit2Sharp\Diff.cs (line 604)

                 RenameLimit = (UIntPtr)similarityOptions.RenameLimit,
             };
 
▶            switch (similarityOptions.RenameDetectionMode)
             {
                 case RenameDetectionMode.Exact:
                     opts.Flags = GitDiffFindFlags.GIT_DIFF_FIND_EXACT_MATCH_ONLY |

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 LibGit2Sharp\Core\GitCheckoutOptsWrapper.cs (line 64)

         {
             CheckoutStrategy flags = default(CheckoutStrategy);
 
▶            switch (fileConflictStrategy)
             {
                 case CheckoutFileConflictStrategy.Ours:
                     flags = CheckoutStrategy.GIT_CHECKOUT_USE_OURS;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 34 hits

📄 LibGit2Sharp\Diff.cs (line 604)

                 RenameLimit = (UIntPtr)similarityOptions.RenameLimit,
             };
 
▶            switch (similarityOptions.RenameDetectionMode)
             {
                 case RenameDetectionMode.Exact:
                     opts.Flags = GitDiffFindFlags.GIT_DIFF_FIND_EXACT_MATCH_ONLY |

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 LibGit2Sharp\Diff.cs (line 631)

                 opts.Flags |= GitDiffFindFlags.GIT_DIFF_FIND_REMOVE_UNMODIFIED;
             }
 
▶            switch (similarityOptions.WhitespaceMode)
             {
                 case WhitespaceMode.DontIgnoreWhitespace:
                     opts.Flags |= GitDiffFindFlags.GIT_DIFF_FIND_DONT_IGNORE_WHITESPACE;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 20 hits

📄 LibGit2Sharp\Core\WriteStream.cs (line 29)

             set { throw new InvalidOperationException(); }
         }
 
▶        public override long Length { get { throw new InvalidOperationException(); } }
 
         public override void Flush()
         { }

💬 An exception is thrown from the getter of property Length (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 LibGit2Sharp\GlobalSettings.cs (line 178)

             {
                 if (!nativeLibraryPathAllowed)
                 {
▶                    throw new LibGit2SharpException("Querying the native hint path is only supported on .NET Framework and .NET Core platforms");
                 }
 
                 return nativeLibraryPath ?? nativeLibraryDefaultPath;

💬 An exception is thrown from the getter of property NativeLibraryPath (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 4 hits

📄 LibGit2Sharp.Tests\FilterFixture.cs (line 206)

 
                 foreach (var file in files)
                 {
▶                    string readAllText = File.ReadAllText(file.FullName);
                     Assert.Equal(decodedInput, readAllText);
                 }
             }

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 LibGit2Sharp.Tests\FilterFixture.cs (line 206)

 
                 foreach (var file in files)
                 {
▶                    string readAllText = File.ReadAllText(file.FullName);
                     Assert.Equal(decodedInput, readAllText);
                 }
             }

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS041 Unnecessary enumerable materialization 60 hits

📄 LibGit2Sharp.Tests\FilterBranchFixture.cs (line 30)

         [Fact]
         public void CanRewriteHistoryWithoutChangingCommitMetadata()
         {
▶            var originalRefs = repo.Refs.ToList().OrderBy(r => r.CanonicalName);
             var commits = repo.Commits.QueryBy(new CommitFilter { IncludeReachableFrom = repo.Refs }).ToArray();
 
             // Noop header rewriter

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 LibGit2Sharp.Tests\FilterBranchFixture.cs (line 43)

 
             AssertSucceedingButNotError();
 
▶            Assert.Equal(originalRefs, repo.Refs.ToList().OrderBy(r => r.CanonicalName));
             Assert.Equal(commits, repo.Commits.QueryBy(new CommitFilter { IncludeReachableFrom = repo.Refs }).ToArray());
         }

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS066 Disposable field is not disposed 40 hits

📄 LibGit2Sharp\CommitLog.cs (line 110)

 
         private class CommitEnumerator : IEnumerator<Commit>
         {
▶            private readonly Repository repo;
             private readonly RevWalkerHandle handle;
             private ObjectId currentOid;
 

💬 Disposable field repo in type CommitEnumerator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 LibGit2Sharp\CommitLog.cs (line 111)

         private class CommitEnumerator : IEnumerator<Commit>
         {
             private readonly Repository repo;
▶            private readonly RevWalkerHandle handle;
             private ObjectId currentOid;
 
             public CommitEnumerator(Repository repo, CommitFilter filter)

💬 Disposable field handle in type CommitEnumerator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Jackett

540 total diagnostics across 20 rules

SS001 Async method with void return type 4 hits

📄 src\Jackett.Common\Services\UpdateService.cs (line 65)

             locker.Set();
         }
 
▶        private async void UpdateWorkerThread()
         {
             var delayHours = 1; // first check after 1 hour (for users not running jackett 24/7)
             while (true)

💬 Method UpdateWorkerThread is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Jackett.Common\Services\UpdateService.cs (line 65)

             locker.Set();
         }
 
▶        private async void UpdateWorkerThread()
         {
             var delayHours = 1; // first check after 1 hour (for users not running jackett 24/7)
             while (true)

💬 Method UpdateWorkerThread is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 188 hits

📄 src\DateTimeRoutines\DateTimeRoutines.cs (line 150)

             get => DefaultDateIsNow ? DateTime.Now : _DefaultDate;
         }
 
▶        private static DateTime _DefaultDate = DateTime.Now;
 
         /// <summary>
         /// If true then DefaultDate property is ignored and DefaultDate is always DateTime.Now

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\DateTimeRoutines\DateTimeRoutines.cs (line 147)

                 _DefaultDate = value;
                 DefaultDateIsNow = false;
             }
▶            get => DefaultDateIsNow ? DateTime.Now : _DefaultDate;
         }
 
         private static DateTime _DefaultDate = DateTime.Now;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 72 hits

📄 src\Jackett.Common\Extensions\ListExtensions.cs (line 9)

     public static class ListExtensions
     {
         public static List<List<T>> ChunkBy<T>(this List<T> source, int chunkSize) => source
▶            .Select((x, i) => new { Index = i, Value = x }).GroupBy(x => x.Index / chunkSize)
             .Select(x => x.Select(v => v.Value).ToList()).ToList();
     }
 }

💬 The operands in the divisive expression x.Index / chunkSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Jackett.Common\Utils\DateTimeUtil.cs (line 42)

         {
             var date = dt.ToUniversalTime();
             var ticks = date.Ticks - new DateTime(1970, 1, 1, 0, 0, 0, 0, DateTimeKind.Utc).Ticks;
▶            var ts = ticks / TimeSpan.TicksPerSecond;
             return ts;
         }
 

💬 The operands in the divisive expression ticks / TimeSpan.TicksPerSecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 src\Jackett.Common\Indexers\Meta\BaseMetaIndexer.cs (line 107)

             var unorderedResult = aggregateTask.Result.SelectMany(r => r.Releases);
             var resultFilters = resultFilterProvider.FiltersForQuery(query);
             var filteredResults = resultFilters.Select(async f => await f.FilterResults(unorderedResult)).SelectMany(t => t.Result);
▶            var uniqueFilteredResults = filteredResults.Distinct();
             var orderedResults = uniqueFilteredResults.OrderByDescending(r => r.Gain);
             // Limiting the response size might be interesting for use-cases where there are
             // tons of trackers configured in Jackett. For now just use the limit param if

💬 Type ReleaseInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Jackett.Common\Indexers\Meta\BaseMetaIndexer.cs (line 107)

             var unorderedResult = aggregateTask.Result.SelectMany(r => r.Releases);
             var resultFilters = resultFilterProvider.FiltersForQuery(query);
             var filteredResults = resultFilters.Select(async f => await f.FilterResults(unorderedResult)).SelectMany(t => t.Result);
▶            var uniqueFilteredResults = filteredResults.Distinct();
             var orderedResults = uniqueFilteredResults.OrderByDescending(r => r.Gain);
             // Limiting the response size might be interesting for use-cases where there are
             // tons of trackers configured in Jackett. For now just use the limit param if

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 src\Jackett.Common\Models\TorznabCategory.cs (line 39)

 
         // Get Hash code should be calculated off read only properties.
         // ID is not readonly
▶        public override int GetHashCode() => ID;
 
         public TorznabCategory CopyWithoutSubCategories() => new TorznabCategory(ID, Name);
     }

💬 GetHashCode() refers to mutable property ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Jackett.Common\Models\TorznabCategory.cs (line 39)

 
         // Get Hash code should be calculated off read only properties.
         // ID is not readonly
▶        public override int GetHashCode() => ID;
 
         public TorznabCategory CopyWithoutSubCategories() => new TorznabCategory(ID, Name);
     }

💬 GetHashCode() refers to mutable property ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 src\Jackett.Common\Services\ImdbResolver.cs (line 10)

 
 namespace Jackett.Common.Services
 {
▶    public struct Movie
     {
         public string Title;
         public string Year;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Movie. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Jackett.Common\Services\ImdbResolver.cs (line 10)

 
 namespace Jackett.Common.Services
 {
▶    public struct Movie
     {
         public string Title;
         public string Year;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Movie. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 32 hits

📄 src\DateTimeRoutines\DateTimeRoutines.cs (line 513)

                 var indexOfDate = m.Index;
                 var lengthOfDate = m.Length;
 
▶                switch (m.Groups["month"].Value)
                 {
                     case "Jan":
                     case "JAN":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\DateTimeRoutines\DateTimeRoutines.cs (line 513)

                 var indexOfDate = m.Index;
                 var lengthOfDate = m.Length;
 
▶                switch (m.Groups["month"].Value)
                 {
                     case "Jan":
                     case "JAN":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS032 Thread.Sleep used in async method 8 hits

📄 src\Jackett.Common\Utils\Clients\HttpWebClient2.cs (line 209)

                             // it shoudln't include service unavailable..only if we have this redirect header.
                             responseMessage.StatusCode = System.Net.HttpStatusCode.Redirect;
                             redirtime = int.Parse(value.Substring(0, end));
▶                            System.Threading.Thread.Sleep(redirtime * 1000);
                         }
                     }
                 }

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\Jackett.Common\Utils\Clients\HttpWebClient.cs (line 187)

                                                 // it shoudln't include service unavailable..only if we have this redirect header.
                                                 response.StatusCode = System.Net.HttpStatusCode.Redirect;
                                                 redirtime = int.Parse(value.Substring(0, end));
▶                                                System.Threading.Thread.Sleep(redirtime * 1000);
                                             }
                                         }
                                     }

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 8 hits

📄 src\Jackett.Common\Services\UpdateService.cs (line 281)

             if (isWindows)
             {
                 var zipPath = Path.Combine(tempDir, "Update.zip");
▶                File.WriteAllBytes(zipPath, data.ContentBytes);
                 var fastZip = new FastZip();
                 fastZip.ExtractZip(zipPath, tempDir, null);
             }

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Jackett.Common\Services\UpdateService.cs (line 288)

             else
             {
                 var gzPath = Path.Combine(tempDir, "Update.tar.gz");
▶                File.WriteAllBytes(gzPath, data.ContentBytes);
                 Stream inStream = File.OpenRead(gzPath);
                 Stream gzipStream = new GZipInputStream(inStream);
 

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 64 hits

📄 src\Jackett.Common\Utils\Extensions.cs (line 37)

             var continuation = anyTask.ContinueWith((_) =>
             {
                 var completedTasks = tasks.Where(t => t.Status == TaskStatus.RanToCompletion);
▶                var results = completedTasks.Select(t => t.Result);
                 return results;
             });
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Jackett.Common\Indexers\Meta\BaseMetaIndexer.cs (line 80)

             IEnumerable<Task<IndexerResult>> supportedTasks = indexers.Where(i => i.CanHandleQuery(query)).Select(i => i.ResultsForQuery(query, true)).ToList(); // explicit conversion to List to execute LINQ query
 
             var fallbackStrategies = fallbackStrategyProvider.FallbackStrategiesForQuery(query);
▶            var fallbackQueries = fallbackStrategies.Select(async f => await f.FallbackQueries()).SelectMany(t => t.Result);
             var fallbackTasks = fallbackQueries.SelectMany(q => indexers.Where(i => !i.CanHandleQuery(query) && i.CanHandleQuery(q)).Select(i => i.ResultsForQuery(q, true)));
             var tasks = supportedTasks.Concat(fallbackTasks).ToList(); // explicit conversion to List to execute LINQ query
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 8 hits

📄 src\Jackett.Common\Indexers\Definitions\Wolfmax4K.cs (line 148)

                 if (data == null)
                     return new List<ReleaseInfo>();
 
▶                return data.Values().Select(item => ExtractReleaseInfo(item as JObject, query)).ToList()
                            .Where(x => x != null);
             }
             catch (Exception ex)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Jackett.Common\Indexers\Definitions\Wolfmax4K.cs (line 148)

                 if (data == null)
                     return new List<ReleaseInfo>();
 
▶                return data.Values().Select(item => ExtractReleaseInfo(item as JObject, query)).ToList()
                            .Where(x => x != null);
             }
             catch (Exception ex)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 src\Jackett.Common\JackettProtectedAttribute.cs (line 5)

 
 namespace Jackett.Common
 {
▶    public class JackettProtectedAttribute : Attribute
     {
     }
 }

💬 JackettProtectedAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Jackett.Common\JackettProtectedAttribute.cs (line 5)

 
 namespace Jackett.Common
 {
▶    public class JackettProtectedAttribute : Attribute
     {
     }
 }

💬 JackettProtectedAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 4 hits

📄 src\Jackett.Common\Models\IndexerConfig\ConfigurationData.cs (line 65)

 
         private IEnumerable<ConfigurationItem> GetAllConfigurationItems()
         {
▶            var properties = GetType()
                 .GetProperties()
                 .Where(p => p.CanRead)
                 .Where(p => p.PropertyType.IsSubclassOf(typeof(ConfigurationItem)))

📄 src\Jackett.Common\Models\IndexerConfig\ConfigurationData.cs (line 65)

 
         private IEnumerable<ConfigurationItem> GetAllConfigurationItems()
         {
▶            var properties = GetType()
                 .GetProperties()
                 .Where(p => p.CanRead)
                 .Where(p => p.PropertyType.IsSubclassOf(typeof(ConfigurationItem)))

SS049 Comparing strings without StringComparison 16 hits

📄 src\Jackett.Common\Indexers\Definitions\BroadcasTheNet.cs (line 326)

                     DownloadVolumeFactor = 0, // ratioless
                     UploadVolumeFactor = 1,
                     MinimumRatio = 1,
▶                    MinimumSeedTime = btnResult.Category.ToUpperInvariant() == "SEASON" ? 432000 : 86400 // 120 hours for seasons and 24 hours for episodes
                 };
 
                 if (btnResult.SeriesBanner.IsNotNullOrWhiteSpace())

📄 src\Jackett.Common\Indexers\Definitions\MTeamTp.cs (line 242)

             {
                 if (jsonResponse != null &&
                     jsonResponse.Message.IsNotNullOrWhiteSpace() &&
▶                    jsonResponse.Message.ToUpperInvariant() != "SUCCESS")
                 {
                     throw new Exception($"Invalid response received from M-Team. Response from API: {jsonResponse.Message}");
                 }

SS051 Locking on mutable reference 16 hits

📄 src\Jackett.Common\Services\LogCacheService.cs (line 20)

         {
             get
             {
▶                lock (_Logs)
                 {
                     return _Logs.ToList();
                 }

💬 A lock was obtained on _Logs but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\Jackett.Common\Services\LogCacheService.cs (line 31)

 
         private static void AddLog(LogEventInfo logEvent, string logMessage)
         {
▶            lock (_Logs)
             {
                 _Logs.Insert(0, new CachedLog
                 {

SS053 Pointless collection ToString() 12 hits

📄 src\Jackett.Common\Indexers\Definitions\CardigannIndexer.cs (line 2256)

                     }
                     else
                     {
▶                        value = release.Category.ToString();
                     }
 
                     break;

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

📄 src\Jackett.Common\Indexers\Definitions\CardigannIndexer.cs (line 2281)

                     }
                     else
                     {
▶                        value = release.Category.ToString();
                     }
 
                     break;

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

SS057 Collection manipulated during traversal 4 hits

📄 src\Jackett.Common\Indexers\Definitions\CardigannIndexer.cs (line 1826)

                                         CurrentRow.Append(MergeRow.ChildNodes.ToArray());
                                     }
                                 }
▶                                Rows.RemoveRange(i + 1, After);
                             }
                         }
 

📄 src\Jackett.Common\Indexers\Definitions\CardigannIndexer.cs (line 1826)

                                         CurrentRow.Append(MergeRow.ChildNodes.ToArray());
                                     }
                                 }
▶                                Rows.RemoveRange(i + 1, After);
                             }
                         }
 

SS058 String concatenated in a loop 80 hits

📄 src\Jackett.Common\Utils\ParseUtil.cs (line 93)

                     continue;
                 }
 
▶                extractedLong += c;
             }
 
             return CoerceLong(extractedLong);

📄 src\Jackett.Common\Indexers\Definitions\BroadcasTheNet.cs (line 335)

 
                     if (posterUrl.StartsWith("//"))
                     {
▶                        posterUrl = "https:" + posterUrl;
                     }
 
                     release.Poster = new Uri(posterUrl);

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\Jackett.Common\Indexers\Definitions\Wolfmax4K.cs (line 547)

 
             var decryptor = aesAlg.CreateDecryptor(aesAlg.Key, aesAlg.IV);
 
▶            using var msDecrypt = new MemoryStream(cipherText);
             using var csDecrypt = new CryptoStream(msDecrypt, decryptor, CryptoStreamMode.Read);
             using var srDecrypt = new StreamReader(csDecrypt);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Jackett.Common\Indexers\Definitions\Wolfmax4K.cs (line 548)

             var decryptor = aesAlg.CreateDecryptor(aesAlg.Key, aesAlg.IV);
 
             using var msDecrypt = new MemoryStream(cipherText);
▶            using var csDecrypt = new CryptoStream(msDecrypt, decryptor, CryptoStreamMode.Read);
             using var srDecrypt = new StreamReader(csDecrypt);
 
             return await srDecrypt.ReadToEndAsync();

💬 CryptoStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 4 hits

📄 src\Jackett.Service\Service.cs (line 16)

     public partial class Service : ServiceBase
     {
         private readonly IProcessService processService;
▶        private Process consoleProcess;
         private readonly Logger logger;
         private bool serviceStopInitiated;
 

💬 Disposable field consoleProcess in type Service is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Jackett.Tray\Main.cs (line 27)

         private readonly ISerializeService serializeService;
         private readonly IConfigurationService configurationService;
         private readonly ServerConfig serverConfig;
▶        private Process consoleProcess;
         private readonly Logger logger;
         private bool closeApplicationInitiated;
 

💬 Disposable field consoleProcess in type Main is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

MelonLoader

528 total diagnostics across 14 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 40 hits

📄 MelonLoader.Bootstrap\Logging\MelonLogger.cs (line 77)

         }
 
         var latestPath = Path.Combine(LoaderConfig.Current.Loader.BaseDirectory, "MelonLoader", "Latest.log");
▶        var cachedPath = Path.Combine(logsDir, $"{DateTime.Now:%y-%M-%d_%H-%m-%s}.log");
 
         MelonDebug.Log("Opening stream to latest log");
         try

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 MelonLoader.Bootstrap\Logging\MelonLogger.cs (line 142)

 
     public static void Log(ColorARGB msgColor, ReadOnlySpan<char> msg, ReadOnlySpan<char> strippedMessage)
     {
▶        var time = DateTime.Now.ToString(timeFormat);
 
         LogToFiles($"[{time}] {strippedMessage}");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 112 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\BZip2\BZip2Constants.cs (line 113)

 		/// <summary>
 		/// Backend constant
 		/// </summary>
▶		public const int MaximumSelectors = (2 + (900000 / GroupSize));
 
 		/// <summary>
 		/// Backend constant

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\Compression\DeflaterConstants.cs (line 85)

 		/// <summary>
 		/// Internal compression engine constant
 		/// </summary>
▶		public const int HASH_SHIFT = (HASH_BITS + MIN_MATCH - 1) / MIN_MATCH;
 
 		/// <summary>
 		/// Internal compression engine constant

SS004 Elementary methods of type in collection not overridden 34 hits

📄 MelonLoader\InternalUtils\DependencyGraph.cs (line 91)

                 {
                     if (nameLookup.TryGetValue(dependency.Name, out Vertex dependencyVertex))
                     {
▶                        if (!melonVertex.dependencies.Contains(dependencyVertex))
                             melonVertex.dependencies.Add(dependencyVertex);
                         if (!dependencyVertex.dependents.Contains(melonVertex))
                             dependencyVertex.dependents.Add(melonVertex);

💬 Type Vertex is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 MelonLoader\InternalUtils\DependencyGraph.cs (line 93)

                     {
                         if (!melonVertex.dependencies.Contains(dependencyVertex))
                             melonVertex.dependencies.Add(dependencyVertex);
▶                        if (!dependencyVertex.dependents.Contains(melonVertex))
                             dependencyVertex.dependents.Add(melonVertex);
                     }
                     else if (!TryLoad(dependency)

SS008 GetHashCode() refers to mutable or static member 28 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Tar\TarEntry.cs (line 160)

 		/// <returns>A Hash code for the current <see cref="Object"/></returns>
 		public override int GetHashCode()
 		{
▶			return Name.GetHashCode();
 		}
 
 		/// <summary>

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 MelonLoader\BackwardsCompatibility\Harmony\Patch.cs (line 43)

 		public MethodInfo GetMethod(MethodBase original) => patchWrapper.GetMethod(original);
 		public override bool Equals(object obj) => patchWrapper.Equals(obj);
 		public int CompareTo(object obj) => patchWrapper.CompareTo(obj);
▶		public override int GetHashCode() => patchWrapper.GetHashCode();
 	}
 }

💬 GetHashCode() refers to mutable field patchWrapper (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 76 hits

📄 MelonLoader.Bootstrap\Logging\ColorARGB.cs (line 7)

 namespace MelonLoader.Logging;
 
 [StructLayout(LayoutKind.Sequential)]
▶public readonly struct ColorARGB : IEquatable<ColorARGB>
 {
     private readonly uint value;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ColorARGB. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 MelonLoader.Bootstrap\RuntimeHandlers\Mono\MonoLib.cs (line 267)

     }
 
     [StructLayout(LayoutKind.Sequential)]
▶    public unsafe struct AssemblyName
     {
         public nint Name;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AssemblyName. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 16 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\FastZip.cs (line 664)

 			// (it might have been set up by the entry factory, and if so we let that take precedence)
 			if (!string.IsNullOrEmpty(Password) && entry.AESEncryptionStrength == 0)
 			{
▶				switch (EntryEncryptionMethod)
 				{
 					case ZipEncryptionMethod.AES128:
 						entry.AESKeySize = 128;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\ZipOutputStream.cs (line 787)

 
 			size += count;
 
▶			switch (curMethod)
 			{
 				case CompressionMethod.Deflated:
 					base.Write(buffer, offset, count);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 72 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\Compression\Deflater.cs (line 481)

 
 				if (!engine.Deflate((state & IS_FLUSHING) != 0, (state & IS_FINISHING) != 0))
 				{
▶					switch (state)
 					{
 						case BUSY_STATE:
 							// We need more input now

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\BZip2\BZip2InputStream.cs (line 302)

 			}
 
 			int retChar = currentChar;
▶			switch (currentState)
 			{
 				case RAND_PART_B_STATE:
 					SetupRandPartB();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 60 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Tar\TarArchive.cs (line 277)

 			{
 				if (isDisposed)
 				{
▶					throw new ObjectDisposedException("TarArchive");
 				}
 
 				return asciiTranslate;

💬 An exception is thrown from the getter of property AsciiTranslate (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Tar\TarArchive.cs (line 348)

 			{
 				if (isDisposed)
 				{
▶					throw new ObjectDisposedException("TarArchive");
 				}
 
 				return rootPath;

💬 An exception is thrown from the getter of property RootPath (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 4 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\Compression\InflaterHuffmanTree.cs (line 69)

 			}
 			catch (Exception)
 			{
▶				throw new SharpZipBaseException("InflaterHuffmanTree: static tree length illegal");
 			}
 		}
 

💬 An exception is thrown from InflaterHuffmanTree its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\Compression\InflaterHuffmanTree.cs (line 69)

 			}
 			catch (Exception)
 			{
▶				throw new SharpZipBaseException("InflaterHuffmanTree: static tree length illegal");
 			}
 		}
 

💬 An exception is thrown from InflaterHuffmanTree its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 MelonLoader\BackwardsCompatibility\Harmony\Attributes.cs (line 41)

 	}
 
 	[Obsolete("Harmony.HarmonyAttribute is Only Here for Compatibility Reasons. Please use HarmonyLib.HarmonyAttribute instead. This will be removed in a future update.", true)]
▶	public class HarmonyAttribute : HarmonyLib.HarmonyAttribute { }
 
 	[Obsolete("Harmony.HarmonyPatch is Only Here for Compatibility Reasons. Please use HarmonyLib.HarmonyPatch instead. This will be removed in a future update.", true)]
 	[AttributeUsage(AttributeTargets.Class | AttributeTargets.Delegate | AttributeTargets.Method, AllowMultiple = true)]

💬 HarmonyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 MelonLoader\BackwardsCompatibility\Harmony\Attributes.cs (line 41)

 	}
 
 	[Obsolete("Harmony.HarmonyAttribute is Only Here for Compatibility Reasons. Please use HarmonyLib.HarmonyAttribute instead. This will be removed in a future update.", true)]
▶	public class HarmonyAttribute : HarmonyLib.HarmonyAttribute { }
 
 	[Obsolete("Harmony.HarmonyPatch is Only Here for Compatibility Reasons. Please use HarmonyLib.HarmonyPatch instead. This will be removed in a future update.", true)]
 	[AttributeUsage(AttributeTargets.Class | AttributeTargets.Delegate | AttributeTargets.Method, AllowMultiple = true)]

💬 HarmonyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 32 hits

📄 MelonLoader\Preferences\IO\Watcher.cs (line 76)

                 return;
             }
 
▶            lock (SyncLock)
             {
                 DateTime lastWriteUtc = System.IO.File.GetLastWriteTimeUtc(PrefFile.FilePath);
                 if (lastWriteUtc > LastReadTimeUtc)

💬 A lock was obtained on SyncLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 MelonLoader\Resolver\AssemblyResolveInfo.cs (line 33)

 
     public void SetVersionSpecific(Version version, Assembly assembly = null)
     {
▶        lock (Versions)
             Versions[version] = assembly;
     }
     public Assembly GetVersionSpecific(Version version)

💬 A lock was obtained on Versions but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS057 Collection manipulated during traversal 8 hits

📄 MelonLoader\Melons\Events\MelonEvent.cs (line 52)

                         var act = actions[b];
                         if (a.priority < act.priority)
                         {
▶                            actions.Insert(b, a);
                             UpdateEnumerator();
                             return;
                         }

📄 MelonLoader\Melons\Events\MelonEvent.cs (line 98)

                         continue;
 
                     any = true;
▶                    actions.RemoveAt(a);
                     if (act.melonAssembly != null)
                         MelonDebug.Msg($"MelonAssembly '{act.melonAssembly.Assembly.GetName().Name}' unsubscribed with {act.del.Method.Name}");
                 }

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 MelonLoader.Bootstrap\RuntimeHandlers\Il2Cpp\DotnetInstaller.cs (line 53)

         {
             Directory.CreateDirectory(Path.GetDirectoryName(installerPath)!);
 
▶            using var str = File.Create(installerPath);
             await resp.Content.CopyToAsync(str);
         }
         catch

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 MelonLoader.Bootstrap\RuntimeHandlers\Il2Cpp\DotnetInstaller.cs (line 53)

         {
             Directory.CreateDirectory(Path.GetDirectoryName(installerPath)!);
 
▶            using var str = File.Create(installerPath);
             await resp.Content.CopyToAsync(str);
         }
         catch

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 40 hits

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\ZipFile.cs (line 4392)

 
 			#region Instance Fields
 
▶			private ZipFile zipFile_;
 			private Stream baseStream_;
 			private readonly long start_;
 			private readonly long length_;

💬 Disposable field zipFile_ in type PartialInputStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 MelonLoader\BackwardsCompatibility\ICSharpCode\SharpZipLib\Zip\ZipFile.cs (line 4393)

 			#region Instance Fields
 
 			private ZipFile zipFile_;
▶			private Stream baseStream_;
 			private readonly long start_;
 			private readonly long length_;
 			private long readPos_;

💬 Disposable field baseStream_ in type PartialInputStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Ombi

520 total diagnostics across 19 rules

SS001 Async method with void return type 2 hits

📄 src\Ombi.Helpers\OmbiQuartz.cs (line 34)

             Init();
         }
 
▶        private async void Init()
         {
             _scheduler = await new StdSchedulerFactory().GetScheduler();
         }

💬 Method Init is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Ombi.Helpers\OmbiQuartz.cs (line 34)

             Init();
         }
 
▶        private async void Init()
         {
             _scheduler = await new StdSchedulerFactory().GetScheduler();
         }

💬 Method Init is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 224 hits

📄 src\Ombi.Notifications.Templates\NewsletterTemplate.cs (line 43)

             sb.Replace(SubjectKey, subject);
             sb.Replace(TableLocation, tableHtml);
             sb.Replace(IntroText, intro);
▶            sb.Replace(DateKey, DateTime.Now.ToString("f"));
             sb.Replace(AppUrl, applicationUrl);
             sb.Replace(Logo, string.IsNullOrEmpty(logo) ? OmbiLogo : logo);
             sb.Replace(Unsubscribe, string.IsNullOrEmpty(unsubscribeLink) ? string.Empty : unsubscribeLink);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Ombi.Notifications.Templates\EmailBasicTemplate.cs (line 36)

             var sb = new StringBuilder(File.ReadAllText(TemplateLocation));
             sb.Replace(SubjectKey, subject);
             sb.Replace(BodyKey, body);
▶            sb.Replace(DateKey, DateTime.Now.ToString("f"));
             sb.Replace(Poster, GetPosterContent(imgsrc, url));
             sb.Replace(Logo, string.IsNullOrEmpty(logo) ? OmbiLogo : logo);
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 src\Ombi.Helpers\PaginationHelper.cs (line 13)

         {
             var result = new List<PagesToLoad>();
 
▶            var firstPage = currentlyLoaded / maxItemsPerPage + 1;
             var startPos = currentlyLoaded % maxItemsPerPage + 1;
 
             var lastItemIndex = currentlyLoaded + toTake - 1;

💬 The operands in the divisive expression currentlyLoaded / maxItemsPerPage are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Ombi.Helpers\PaginationHelper.cs (line 17)

             var startPos = currentlyLoaded % maxItemsPerPage + 1;
 
             var lastItemIndex = currentlyLoaded + toTake - 1;
▶            var lastPage = lastItemIndex / maxItemsPerPage + 1;
             var stopPos = lastItemIndex % maxItemsPerPage + 1;
 
             while (currentlyLoaded >= maxItemsPerPage)

💬 The operands in the divisive expression lastItemIndex / maxItemsPerPage are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 72 hits

📄 src\Ombi.Core\Engine\RecentlyAddedEngine.cs (line 221)

         {
             foreach (var emby in embyMovies)
             {
▶                model.Add(new RecentlyAddedMovieModel
                 {
                     Id = emby.Id,
                     ImdbId = emby.ImdbId,

💬 Type RecentlyAddedMovieModel is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Ombi.Core\Engine\RecentlyAddedEngine.cs (line 253)

         {
             foreach (var plex in plexMovies)
             {
▶                model.Add(new RecentlyAddedMovieModel
                 {
                     Id = plex.Id,
                     ImdbId = plex.ImdbId,

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 src\Ombi.Helpers.Tests\CacheServiceTests.cs (line 343)

 
             public override int GetHashCode()
             {
▶                return HashCode.Combine(Id, Name);
             }
         }
     }

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Ombi.Helpers.Tests\CacheServiceTests.cs (line 343)

 
             public override int GetHashCode()
             {
▶                return HashCode.Combine(Id, Name);
             }
         }
     }

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS018 Switch does not handle all enum options 2 hits

📄 src\Ombi\Controllers\V2\RequestsController.cs (line 213)

         [HttpPost("reprocess/{type}/{requestId}/{is4K}")]
         public async Task<IActionResult> ReProcessRequest(RequestType type, int requestId, bool? is4K)
         {
▶            switch (type)
             {
                 case RequestType.TvShow:
                     return Ok(await _tvRequestEngine.ReProcessRequest(requestId, false, HttpContext.RequestAborted));

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Ombi\Controllers\V2\RequestsController.cs (line 213)

         [HttpPost("reprocess/{type}/{requestId}/{is4K}")]
         public async Task<IActionResult> ReProcessRequest(RequestType type, int requestId, bool? is4K)
         {
▶            switch (type)
             {
                 case RequestType.TvShow:
                     return Ok(await _tvRequestEngine.ReProcessRequest(requestId, false, HttpContext.RequestAborted));

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 18 hits

📄 src\Ombi.Core\Services\RequestLimitService.cs (line 155)

             int count = 0;
             DateTime oldestRequestedAt = DateTime.Now;
             DateTime nextRequest = DateTime.Now;
▶            switch (type)
             {
                 case RequestLimitType.Day:
                     count = limit - await log.CountAsync(x => x.RequestDate >= now.Date);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Ombi.Core\Services\RequestLimitService.cs (line 260)

                 };
             }
 
▶            switch (user.EpisodeRequestLimitType)
             {
                 case RequestLimitType.Day:
 

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 34 hits

📄 src\Ombi.Core.Tests\Engine\CalendarEngineTests.cs (line 20)

     [TestFixture]
     public class CalendarEngineTests
     {
▶        public Mock<IMovieRequestRepository> MovieRepo { get; set; }
         public Mock<ITvRequestRepository> TvRepo { get; set; }
         public CalendarEngine CalendarEngine { get; set; }
 

💬 Method set_MovieRepo might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 src\Ombi.Core.Tests\Engine\CalendarEngineTests.cs (line 21)

     public class CalendarEngineTests
     {
         public Mock<IMovieRequestRepository> MovieRepo { get; set; }
▶        public Mock<ITvRequestRepository> TvRepo { get; set; }
         public CalendarEngine CalendarEngine { get; set; }
 
         [SetUp]

💬 Method set_TvRepo might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 4 hits

📄 src\Ombi.Api.External\NotificationServices\GroupMe\Models\GroupMeResponse.cs (line 36)

                     case GroupMeStatusCode.ServiceUnavailable:
                         return false;
                     default:
▶                        throw new ArgumentOutOfRangeException(nameof(GroupMeStatusCode));
                 }
             }
         }

💬 An exception is thrown from the getter of property Successful (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Ombi.Core\Models\Search\V2\CalendarViewModel.cs (line 28)

                     case RequestType.Album:
                         return "#797979";
                     default:
▶                        throw new ArgumentOutOfRangeException();
                 }
             }
         }

💬 An exception is thrown from the getter of property BorderColor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 38 hits

📄 src\Ombi.Store\Repository\BaseRepository.cs (line 50)

 
         public async Task AddRange(IEnumerable<T> content, bool save = true)
         {
▶            _db.AddRange(content);
             if (save)
             {
                 await InternalSaveChanges();

💬 Async overload available for DbSet.AddRange (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Ombi.Store\Repository\EmbyContentRepository.cs (line 90)

 
         public override async Task AddRange(IEnumerable<IMediaServerEpisode> content)
         {
▶            Db.EmbyEpisode.AddRange((IEnumerable<EmbyEpisode>)content);
             await InternalSaveChanges();
         }
 

💬 Async overload available for DbSet.AddRange (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS037 HttpClient instantiated directly 4 hits

📄 src\Ombi.Api.External\NotificationServices\Mattermost\Models\MattermostClient.cs (line 21)

     public class MatterhookClient
     {
         private readonly Uri _webhookUrl;
▶        private readonly HttpClient _httpClient = new HttpClient();
 
         /// <summary>
         /// Create a new Mattermost Client

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 src\Ombi\Program.cs (line 136)

             }
 
             await SortOutBaseUrl(baseUrl, settingsDb, ombiSettingsContent);
▶            var httpClient = new HttpClient();
             // Create minimal dependencies for migration code (no caching needed during migration)
             var nullCache = new NullCacheService();
             var stubEnvironment = new StubHostEnvironment();

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS040 Unused result on immutable object 2 hits

📄 src\Ombi.Api.External\ExternalApis\CouchPotato\CouchPotatoApi.cs (line 70)

             request.AddQueryString("status",string.Join(",", status));
             request.OnBeforeDeserialization = json =>
             {
▶                json.Replace("[]", "{}");
             };
             return await _api.Request<CouchPotatoMovies>(request);
         }

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 src\Ombi.Api.External\ExternalApis\CouchPotato\CouchPotatoApi.cs (line 70)

             request.AddQueryString("status",string.Join(",", status));
             request.OnBeforeDeserialization = json =>
             {
▶                json.Replace("[]", "{}");
             };
             return await _api.Request<CouchPotatoMovies>(request);
         }

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 src\Ombi.Schedule\Jobs\Ombi\NewsletterJob.cs (line 334)

         private HashSet<LidarrAlbumCache> GetMusicContent(IExternalRepository<LidarrAlbumCache> repository, bool test)
         {
 
▶            var lidarrContent = repository.GetAll().AsNoTracking().ToList().Where(x => x.FullyAvailable);
 
             HashSet<LidarrAlbumCache> albumsToSend;
             if (test)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Ombi.Schedule\Jobs\Ombi\NewsletterJob.cs (line 334)

         private HashSet<LidarrAlbumCache> GetMusicContent(IExternalRepository<LidarrAlbumCache> repository, bool test)
         {
 
▶            var lidarrContent = repository.GetAll().AsNoTracking().ToList().Where(x => x.FullyAvailable);
 
             HashSet<LidarrAlbumCache> albumsToSend;
             if (test)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 src\Ombi.Api\Attribute\JsonPluralNameAttribute.cs (line 5)

 
 namespace Ombi.Api
 {
▶    public class JsonPropertyNameBasedOnItemClassAttribute : Attribute
     {
     }
 

💬 JsonPropertyNameBasedOnItemClassAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Ombi.Api\Attribute\JsonPluralNameAttribute.cs (line 9)

     {
     }
 
▶    public class JsonPluralNameAttribute : Attribute
     {
         public string PluralName { get; set; }
         public JsonPluralNameAttribute(string pluralName)

💬 JsonPluralNameAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 2 hits

📄 src\Ombi\Controllers\V1\External\TesterController.cs (line 340)

 
         private async Task<OmbiUser> GetCurrentUserAsync()
         {
▶            return await UserManager.Users.FirstOrDefaultAsync(x => x.NormalizedUserName == UserPrinciple.Identity.Name.ToUpper());
         }
 
         /// <summary>

📄 src\Ombi\Controllers\V1\External\TesterController.cs (line 340)

 
         private async Task<OmbiUser> GetCurrentUserAsync()
         {
▶            return await UserManager.Users.FirstOrDefaultAsync(x => x.NormalizedUserName == UserPrinciple.Identity.Name.ToUpper());
         }
 
         /// <summary>

SS057 Collection manipulated during traversal 6 hits

📄 src\Ombi.Core\Engine\Demo\DemoTvSearchEngine.cs (line 47)

             {
                 if (!_demoLists.TvShows.Contains(searchResult[i].show?.externals?.thetvdb ?? 0))
                 {
▶                    searchResult.RemoveAt(i);
                 }
             }
 

📄 src\Ombi.Core\Engine\Demo\DemoMovieSearchEngine.cs (line 46)

             {
                 if (!_demoLists.Movies.Contains(result[i].Id))
                 {
▶                    result.RemoveAt(i);
                 }  
             }
             if(result.Count > 0)

SS058 String concatenated in a loop 6 hits

📄 src\Ombi.Api.External\NotificationServices\Mattermost\Models\MattermostClient.cs (line 103)

                         outMessages.Add(CloneMessage(inMessage));
                     }
 
▶                    outMessages[msgCount].Text += $"{line}\r\n";
                 }
 
                 //Length of text on the last (or first if only one) inMessage.

📄 src\Ombi.Api.External\NotificationServices\Mattermost\Models\MattermostClient.cs (line 140)

                                 outMessages[msgCount].Attachments = new List<MattermostAttachment> { CloneAttachment(att) };
                             }
 
▶                            outMessages[msgCount].Attachments[attIndex].Text += $"{line}\r\n";
                         }
                     }
                 }

SS059 IAsyncDisposable not disposed asynchronously 44 hits

📄 src\Ombi.Schedule\Jobs\Radarr\RadarrSync.cs (line 45)

             {
                 _logger.LogInformation("[RadarrSync] Starting Radarr cache sync - clearing existing cache");
                 // Let's remove the old cached data
▶                using var tran = await _ctx.Database.BeginTransactionAsync();
                 await _ctx.Database.ExecuteSqlRawAsync("DELETE FROM RadarrCache");
                 await tran.CommitAsync();
                 _logger.LogInformation("[RadarrSync] RadarrCache cleared");

💬 IDbContextTransaction can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Ombi.Schedule\Jobs\Couchpotato\CouchPotatoSync.cs (line 82)

                     await strat.ExecuteAsync(async () =>
                     {
                         // Let's remove the old cached data
▶                        using var tran = await _ctx.Database.BeginTransactionAsync();
                         await _ctx.Database.ExecuteSqlRawAsync("DELETE FROM CouchPotatoCache");
                         await tran.CommitAsync();
                     });

💬 IDbContextTransaction can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 42 hits

📄 src\Ombi.Hubs\NotificationHub.cs (line 16)

 
 public class NotificationHub : Hub
 {
▶    private readonly OmbiUserManager _userManager;
     public static readonly ConcurrentDictionary<string, NotificationHubUser> UsersOnline = new();
     
     public NotificationHub(OmbiUserManager userManager)

💬 Disposable field _userManager in type NotificationHub is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Ombi.Schedule\Jobs\Ombi\NewsletterJob.cs (line 76)

         private readonly IMovieDbApi _movieApi;
         private readonly IEmailProvider _email;
         private readonly ISettingsService<CustomizationSettings> _customizationSettings;
▶        private readonly INotificationTemplatesRepository _templateRepo;
         private readonly ISettingsService<EmailNotificationSettings> _emailSettings;
         private readonly ISettingsService<NewsletterSettings> _newsletterSettings;
         private readonly ISettingsService<OmbiSettings> _ombiSettings;

💬 Disposable field _templateRepo in type NewsletterJob is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

P

492 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 Src\PCompiler\CompilerCore\Backend\PObserve\Constants.cs (line 74)

         private static readonly string rawFFIBanner = $@"
 P <-> Java Foreign Function Interface Stubs
 
▶This file was auto-generated on {DateTime.Now.ToLongDateString()} at {DateTime.Now.ToLongTimeString()}.
 
 Please separate each generated class into its own .java file (detailed throughout the file), filling
 in the body of each function definition as necessary for your project's business logic.

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Src\PCompiler\CompilerCore\Backend\PObserve\Constants.cs (line 74)

         private static readonly string rawFFIBanner = $@"
 P <-> Java Foreign Function Interface Stubs
 
▶This file was auto-generated on {DateTime.Now.ToLongDateString()} at {DateTime.Now.ToLongTimeString()}.
 
 Please separate each generated class into its own .java file (detailed throughout the file), filling
 in the body of each function definition as necessary for your project's business logic.

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 18 hits

📄 Src\PChecker\CheckerCore\SystematicTesting\Strategies\Feedback\Coverage\BehavioralObserver.cs (line 52)

             }
             scoreSum += score;
         }
▶        return scoreSum/AllTimeline.Count;
     }
     
     public static void PrintTimeline(List<(VectorTime, Event, EventType)> timeline)

💬 The operands in the divisive expression scoreSum/AllTimeline.Count are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Src\PChecker\CheckerCore\SystematicTesting\Strategies\Feedback\Generator\Utils.cs (line 15)

     public static RandomChoices<T> MutateRandomChoices<T> (RandomChoices<T> randomChoices, int meanMutationCount, int meanMutationSize, System.Random random)
         where T: IConvertible
     {
▶        meanMutationCount = Math.Max(Math.Min(randomChoices.Data.Count / 3, meanMutationCount), 1);
         meanMutationSize = Math.Max(Math.Min(randomChoices.Data.Count / 3, meanMutationSize), 1);
         RandomChoices<T> newChoices = new RandomChoices<T>(randomChoices);
         int mutations = SampleGeometric(1.0f / meanMutationCount, random.NextDouble());

💬 The operands in the divisive expression randomChoices.Data.Count / 3 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 248 hits

📄 Src\PChecker\CheckerCore\SystematicTesting\Operations\TaskOperation.cs (line 85)

         internal void OnWaitTask(SystemTasks.Task task)
         {
             Debug.WriteLine("<ScheduleDebug> Operation '{0}' is waiting for task '{1}'.", Id, task.Id);
▶            JoinDependencies.Add(task);
             Status = AsyncOperationStatus.BlockedOnWaitAll;
             Scheduler.ScheduleNextEnabledOperation(AsyncOperationType.Join);
             IsAwaiterControlled = false;

💬 Type Task is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Src\PChecker\CheckerCore\SystematicTesting\Operations\TaskOperation.cs (line 101)

                 if (!task.IsCompleted)
                 {
                     Debug.WriteLine("<ScheduleDebug> Operation '{0}' is waiting for task '{1}'.", Id, task.Id);
▶                    JoinDependencies.Add(task.UncontrolledTask);
                 }
             }
 

SS005 Equals() and GetHashCode() not implemented together 12 hits

📄 Src\PChecker\CheckerCore\Runtime\Values\PMachineValue.cs (line 14)

         }
     }
 
▶    public class PMachineValue : IPValue
     {
         public PMachineValue(StateMachineId machine, List<string> permissions)
         {

💬 Equals() and GetHashcode() must be implemented together on PMachineValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 Src\PChecker\CheckerCore\Runtime\Values\PSeq.cs (line 9)

 
 namespace PChecker.Runtime.Values
 {
▶    public sealed class PSeq : IPMutableValue, IReadOnlyList<IPValue>
     {
         private readonly List<IPValue> values = new List<IPValue>();
 

💬 Equals() and GetHashcode() must be implemented together on PSeq (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 38 hits

📄 Src\PChecker\CheckerCore\Runtime\VectorTime.cs (line 115)

     public override int GetHashCode()
     {
         int hash = 17;
▶        foreach (var entry in Clock)
         {
             hash = hash * 31 + entry.Key.GetHashCode();
             hash = hash * 31 + entry.Value.GetHashCode();

💬 GetHashCode() refers to mutable property Clock (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Src\PChecker\CheckerCore\SystematicTesting\Traces\ScheduleStep.cs (line 125)

         /// <summary>
         /// Returns the hash code for this instance.
         /// </summary>
▶        public override int GetHashCode() => Index.GetHashCode();
     }
 }

💬 GetHashCode() refers to mutable field Index (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 26 hits

📄 Src\PChecker\CheckerCore\Tasks\AsyncTaskMethodBuilder.cs (line 22)

     /// <remarks>This type is intended for compiler use rather than use directly in code.</remarks>
     [EditorBrowsable(EditorBrowsableState.Never)]
     [StructLayout(LayoutKind.Auto)]
▶    public struct AsyncTaskMethodBuilder
     {
         /// <summary>
         /// Responsible for controlling the execution of tasks during systematic testing.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AsyncTaskMethodBuilder. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Src\PChecker\CheckerCore\Tasks\AsyncTaskMethodBuilder.cs (line 171)

     /// <remarks>This type is intended for compiler use rather than use directly in code.</remarks>
     [EditorBrowsable(EditorBrowsableState.Never)]
     [StructLayout(LayoutKind.Auto)]
▶    public struct AsyncTaskMethodBuilder<TResult>
     {
         /// <summary>
         /// Responsible for controlling the execution of tasks during systematic testing.

SS019 Switch is missing default label 50 hits

📄 Src\PChecker\CheckerCore\Runtime\Logging\JsonWriter.cs (line 252)

             // Always update the local machine count by one on any event.
             _contextVcMap[machine][machine] += 1;
 
▶            switch (logType)
             {
                 // On send event, hash the string containing information about the target machine to be sent to, the event name, and payload
                 // This is used as an unique id necessary to correctly update the vector clock for the right machine-event-payload combo that

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Src\PCompiler\CompilerCore\Backend\Stately\StatelyCodeGenerator.cs (line 38)

         private void WriteDecl(CompilationContext context, StringWriter output, IPDecl decl)
         {
             //string declName;
▶            switch (decl)
             {
                 case Machine machine:
                     if (!machine.IsSpec)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 6 hits

📄 Src\PChecker\CheckerCore\Tasks\TaskCompletionSource.cs (line 105)

                                 }
                                 else if (Status is TaskStatus.Faulted)
                                 {
▶                                    throw Exception;
                                 }
 
                                 return Result;

💬 An exception is thrown from the getter of property Task (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Src\PCompiler\CompilerCore\Backend\PObserve\TypeManager.cs (line 36)

                 {
                     if (_unboxedType == null)
                     {
▶                        throw new Exception($"TypeName not implemented for {GetType()}");
                     }
 
                     return _unboxedType;

💬 An exception is thrown from the getter of property TypeName (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 10 hits

📄 Src\PChecker\CheckerCore\ExhaustiveEngine.cs (line 148)

                 switch (proc.ExitCode)
                 {
                     case 0:
▶                        _logger.WriteLine("... Checker run finished.");
                         break;
                     case 2:
                         _logger.WriteLine("... Checker found a bug.");

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Src\PChecker\CheckerCore\ExhaustiveEngine.cs (line 151)

                         _logger.WriteLine("... Checker run finished.");
                         break;
                     case 2:
▶                        _logger.WriteLine("... Checker found a bug.");
                         break;
                     case 3:
                         _logger.WriteLine("... Checker timed out.");

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 6 hits

📄 Src\PChecker\CheckerCore\Tasks\Task.cs (line 697)

                 {
                     if (TaskController is null)
                     {
▶                        return UncontrolledTask.Result;
                     }
 
                     return TaskController.WaitTaskCompletes(this);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Src\PChecker\CheckerCore\SystematicTesting\TaskController.cs (line 258)

                     {
                         var resultTask = funcWithGenericTaskResult();
                         OnWaitTask(operationId, resultTask);
▶                        return resultTask.Result;
                     }
                     else if (work is Func<TResult> funcWithGenericResult)
                     {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 Src\PCompiler\CompilerCore\TypeChecker\ParamAssignment.cs (line 156)

     public static void IterateAssignments(SafetyTest safety, List<Variable> globalParams,
         Action<Dictionary<Variable, IPExpr>> generateTestCode)
     {
▶        var indexArr = safety.ParamExprMap.ToList()
             .Zip(Enumerable.Repeat(0, safety.ParamExprMap.Count), (x, y) => (x.Key, y)).ToArray();
         var universe = safety.ParamExprMap.ToDictionary(kv => kv.Key, kv => kv.Value.Count);
         var assignmentIndices = new List<Dictionary<string, int>>();

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 Src\PCompiler\CompilerCore\TypeChecker\ParamAssignment.cs (line 156)

     public static void IterateAssignments(SafetyTest safety, List<Variable> globalParams,
         Action<Dictionary<Variable, IPExpr>> generateTestCode)
     {
▶        var indexArr = safety.ParamExprMap.ToList()
             .Zip(Enumerable.Repeat(0, safety.ParamExprMap.Count), (x, y) => (x.Key, y)).ToArray();
         var universe = safety.ParamExprMap.ToDictionary(kv => kv.Key, kv => kv.Value.Count);
         var assignmentIndices = new List<Dictionary<string, int>>();

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS053 Pointless collection ToString() 2 hits

📄 Tst\UnitTests\Core\TestCaseFactory.cs (line 95)

                 : new CompileSuccessValidator();
 
             var tempDirName =
▶                Directory.CreateDirectory(Path.Combine(testTempBaseDir.FullName, output.ToString(), testName));
             return new CompilerTestCase(tempDirName, runner, validator);
         }
     }

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

📄 Tst\UnitTests\Core\TestCaseFactory.cs (line 95)

                 : new CompileSuccessValidator();
 
             var tempDirName =
▶                Directory.CreateDirectory(Path.Combine(testTempBaseDir.FullName, output.ToString(), testName));
             return new CompilerTestCase(tempDirName, runner, validator);
         }
     }

💬 .ToString() was called on a collection which results in impractical output (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS053-PointlessCollectionToString.md)

SS057 Collection manipulated during traversal 6 hits

📄 Src\PCompiler\CompilerCore\Backend\PEx\TransformASTPass.cs (line 462)

                     replacement.Scope = entry.Value.Scope;
                     foreach (var local in entry.Value.LocalVariables) replacement.AddLocalVariable(local);
                     foreach (var i in entry.Value.CreatesInterfaces) replacement.AddCreatesInterface(i);
▶                    foreach (var param in entry.Value.Signature.Parameters) replacement.Signature.Parameters.Add(param);
                     replacement.Signature.ReturnType = entry.Value.Signature.ReturnType;
                     foreach (var callee in entry.Value.Callees) replacement.AddCallee(callee);
                     replacement.Body = (CompoundStmt)ReplaceVars(entry.Value.Body, varMap);

📄 Src\PCompiler\CompilerCore\Backend\PEx\TransformASTPass.cs (line 580)

         transformedFunction.CanRaiseEvent = function.CanRaiseEvent;
         transformedFunction.CanChangeState = function.CanChangeState;
         transformedFunction.IsNondeterministic = function.IsNondeterministic;
▶        foreach (var param in function.Signature.Parameters) transformedFunction.Signature.Parameters.Add(param);
         transformedFunction.Signature.ReturnType = function.Signature.ReturnType;
         return transformedFunction;
     }

SS058 String concatenated in a loop 58 hits

📄 Src\PChecker\CheckerCore\Runtime\Values\PTuple.cs (line 221)

             var retStr = "<";
             for (var i = 0; i < fieldValues.Count; i++)
             {
▶                retStr += fieldNames[i] + ":" + fieldValues[i] + ", ";
             }
 
             retStr += ">";

📄 Src\PChecker\CheckerCore\Runtime\Values\PTuple.cs (line 234)

             for (var i = 0; i < fieldValues.Count; i++)
             {
                 var v = fieldValues[i] == null ? "null" : fieldValues[i].ToEscapedString();
▶                retStr += fieldNames[i] + ":" + v + ", ";
             }
 
             retStr += ">";

SS060 ConcurrentDictionary emptiness check without IsEmpty 2 hits

📄 Src\PChecker\CheckerCore\SystematicTesting\OperationScheduler.cs (line 286)

         /// <returns>True if the operation was successfully registered, else false if it already exists.</returns>
         internal bool RegisterOperation(AsyncOperation op)
         {
▶            if (OperationMap.Count == 0)
             {
                 ScheduledOperation = op;
             }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 Src\PChecker\CheckerCore\SystematicTesting\OperationScheduler.cs (line 286)

         /// <returns>True if the operation was successfully registered, else false if it already exists.</returns>
         internal bool RegisterOperation(AsyncOperation op)
         {
▶            if (OperationMap.Count == 0)
             {
                 ScheduledOperation = op;
             }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

puppeteer-sharp

484 total diagnostics across 8 rules

SS003 Integer divided by integer causing implicit rounding 20 hits

📄 lib\PuppeteerSharp\PredefinedNetworkConditions.cs (line 17)

             [NetworkConditions.Slow3G] = new NetworkConditions
             {
                 // ~500Kbps down
▶                Download = ((500 * 1000) / 8) * 0.8,
 
                 // ~500Kbps up
                 Upload = ((500 * 1000) / 8) * 0.8,

💬 The operands in the divisive expression (500 * 1000) / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 lib\PuppeteerSharp\PredefinedNetworkConditions.cs (line 20)

                 Download = ((500 * 1000) / 8) * 0.8,
 
                 // ~500Kbps up
▶                Upload = ((500 * 1000) / 8) * 0.8,
 
                 // 400ms RTT
                 Latency = 400 * 5,

SS004 Elementary methods of type in collection not overridden 8 hits

📄 lib\PuppeteerSharp\Cdp\FrameManager.cs (line 142)

 
         internal async Task AddExposedFunctionBindingAsync(Binding binding)
         {
▶            _bindings.Add(binding);
             await Task.WhenAll(
                 GetFrames().Select(frame => ((CdpFrame)frame).AddExposedFunctionBindingAsync(binding))).ConfigureAwait(false);
         }

💬 Type Binding is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 lib\PuppeteerSharp\PageAccessibility\Accessibility.cs (line 153)

                 children.AddRange(SerializeTree(child, whitelistedNodes));
             }
 
▶            if (whitelistedNodes?.Contains(node) == false)
             {
                 return children.ToArray();
             }

💬 Type AXNode is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 172 hits

📄 lib\PuppeteerSharp\BoundingBox.cs (line 83)

 
         /// <inheritdoc/>
         public override int GetHashCode()
▶            => X.GetHashCode() * 397
                 ^ Y.GetHashCode() * 397
                 ^ Width.GetHashCode() * 397
                 ^ Height.GetHashCode() * 397;

💬 GetHashCode() refers to mutable property X (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 lib\PuppeteerSharp\BoundingBox.cs (line 84)

         /// <inheritdoc/>
         public override int GetHashCode()
             => X.GetHashCode() * 397
▶                ^ Y.GetHashCode() * 397
                 ^ Width.GetHashCode() * 397
                 ^ Height.GetHashCode() * 397;
 

💬 GetHashCode() refers to mutable property Y (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS023 Exception thrown from property getter 4 hits

📄 lib\PuppeteerSharp\QueryHandlers\QueryHandler.cs (line 51)

 
                 if (string.IsNullOrEmpty(QuerySelectorAll))
                 {
▶                    throw new PuppeteerException("Cannot create default query selector");
                 }
 
                 const string querySelector = @"async (node, selector, PuppeteerUtil) => {

💬 An exception is thrown from the getter of property QuerySelector (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 lib\PuppeteerSharp\QueryHandlers\QueryHandler.cs (line 51)

 
                 if (string.IsNullOrEmpty(QuerySelectorAll))
                 {
▶                    throw new PuppeteerException("Cannot create default query selector");
                 }
 
                 const string querySelector = @"async (node, selector, PuppeteerUtil) => {

💬 An exception is thrown from the getter of property QuerySelector (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS034 Accessing Task.Result without await 52 hits

📄 lib\PuppeteerSharp\Cdp\CdpFrame.cs (line 163)

         await completedTask.ConfigureAwait(false);
 
         return completedTask == navigationResponseTask
▶            ? navigationResponseTask.Result
             : null;
     }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 lib\PuppeteerSharp\Cdp\CdpPageTarget.cs (line 54)

             _ = InitializedTaskWrapper.Task.ContinueWith(
                 async initializedTask =>
                 {
▶                    var success = initializedTask.Result;
                     if (success != InitializationStatus.Success)
                     {
                         return;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS057 Collection manipulated during traversal 20 hits

📄 lib\PuppeteerSharp\Bidi\ExposableFunction.cs (line 156)

         var contexts = new List<BrowsingContext> { _frame.BrowsingContext };
         for (var i = 0; i < contexts.Count; i++)
         {
▶            contexts.AddRange(contexts[i].Children);
         }
 
         // Add preload script only to the top-level context (for future navigations).

📄 lib\PuppeteerSharp\Bidi\ExposableFunction.cs (line 435)

                 return frame;
             }
 
▶            frames.AddRange(frame.ChildFrames.OfType<BidiFrame>());
         }
 
         return null;

SS058 String concatenated in a loop 8 hits

📄 lib\PuppeteerSharp\ExecutionContext.cs (line 172)

                 {
                     var location = $"{callframe.Url}:{callframe.LineNumber}:{callframe.ColumnNumber}";
                     var functionName = string.IsNullOrEmpty(callframe.FunctionName) ? "<anonymous>" : callframe.FunctionName;
▶                    message += $"\n at ${functionName} (${location})";
                 }
             }
 

📄 lib\PuppeteerSharp\Cdp\CdpPage.cs (line 1337)

         {
             var location = $"{callFrame.Url}:{callFrame.LineNumber}:{callFrame.ColumnNumber}";
             var functionName = callFrame.FunctionName ?? "<anonymous>";
▶            message += $"\n at {functionName} ({location})";
         }
 
         return message;

SS066 Disposable field is not disposed 200 hits

📄 lib\PuppeteerSharp\Bidi\BidiPage.cs (line 86)

     }
 
     /// <inheritdoc />
▶    public override IBrowserContext BrowserContext { get; }
 
     /// <inheritdoc />
     public override CDPSession Client { get; }

💬 Disposable field BrowserContext in type BidiPage is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 lib\PuppeteerSharp\Bidi\BidiPage.cs (line 137)

     internal TaskQueue RequestInterceptionQueue => _requestInterceptionQueue;
 
     /// <inheritdoc />
▶    protected override Browser Browser { get; }
 
     private Task ClosedTask
     {

💬 Disposable field Browser in type BidiPage is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Inveigh

472 total diagnostics across 7 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 78 hits

📄 Inveigh\Protocols\Quiddity\Quiddity\Listeners\HTTPListener.cs (line 125)

                                 TcpClient tcpClient = tcpListener.EndAcceptTcpClient(tcpAsync);
                                 string sourceIP = ((IPEndPoint)(tcpClient.Client.RemoteEndPoint)).Address.ToString();
 
▶                                if (type.Equals("Proxy") && tcpSessionTable.ContainsKey(sourceIP) && DateTime.Compare((DateTime)tcpSessionTable[sourceIP], DateTime.Now) > 0)
                                 {
                                     tcpClient.Client.Close();
                                 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Inveigh\Support\Control.cs (line 123)

         {           
             Program.consoleList.Clear();
             Program.enabledConsoleOutput = true;
▶            Output.Queue(String.Format("[+] Inveigh exited at {0}", DateTime.Now.ToString("s")));
             Output.ProcessOutput();
             Output.ProcessFileOutput();
             Sniffer.isRunning = false;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 6 hits

📄 Inveigh\Support\Output.cs (line 141)

         public static void OutputCommand(string description, string[] headings, IList<string> list, ConsoleColor color)
         {
             Console.ForegroundColor = color;
▶            int padLeft = (Console.WindowWidth - description.Length) / 2;
             int padRight = padLeft;
             int pad = Console.WindowWidth - description.Length - padLeft - padRight;
             padRight += pad;

💬 The operands in the divisive expression (Console.WindowWidth - description.Length) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Inveigh\Support\Output.cs (line 141)

         public static void OutputCommand(string description, string[] headings, IList<string> list, ConsoleColor color)
         {
             Console.ForegroundColor = color;
▶            int padLeft = (Console.WindowWidth - description.Length) / 2;
             int padRight = padLeft;
             int pad = Console.WindowWidth - description.Length - padLeft - padRight;
             padRight += pad;

SS015 String placeholders in wrong order 4 hits

📄 Inveigh\Listeners\HTTPListener.cs (line 33)

 
         protected override void OutputRequestMethod(string protocol, string listenerPort, string clientIP, string clientPort, string uri, string method)
         {
▶            Output.Queue(String.Format("[.] [{0}] {1}({2}) {3} request from {5}:{6} for {4}", Output.Timestamp(), protocol, listenerPort, method, uri, clientIP, clientPort));
         }
 
         protected override void OutputNTLM(string protocol, string listenerPort, string clientIP, string clientPort, string user, string domain, string host, string ntlmChallenge, string ntlmResponseHash, string lmResponseHash)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 Inveigh\Listeners\HTTPListener.cs (line 33)

 
         protected override void OutputRequestMethod(string protocol, string listenerPort, string clientIP, string clientPort, string uri, string method)
         {
▶            Output.Queue(String.Format("[.] [{0}] {1}({2}) {3} request from {5}:{6} for {4}", Output.Timestamp(), protocol, listenerPort, method, uri, clientIP, clientPort));
         }
 
         protected override void OutputNTLM(string protocol, string listenerPort, string clientIP, string clientPort, string user, string domain, string host, string ntlmChallenge, string ntlmResponseHash, string lmResponseHash)

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS019 Switch is missing default label 120 hits

📄 Inveigh\Protocols\Quiddity\Quiddity\Listeners\DHCPv6Listener.cs (line 128)

                 byte msgType = 0;
                 string leaseIP = "";
 
▶                switch (packet.Message.MsgType)
                 {
                     case 1:
                         msgType = 2;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Inveigh\Protocols\Quiddity\Quiddity\Protocols\LDAP\LDAPMessage.cs (line 60)

         public byte[] Encode(int type)
         {
 
▶            switch (type)
             {
 
                 case 3:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS049 Comparing strings without StringComparison 78 hits

📄 Inveigh\Protocols\Quiddity\Quiddity\Protocols\MDNS\MDNSChecker.cs (line 75)

         public bool QuestionIsAllowed(string question)
         {
  
▶            if (!Utilities.ArrayIsNullOrEmpty(this.Questions) && !Array.Exists(this.Questions, element => element == question.ToUpper()))
             {
                 return false;
             }

📄 Inveigh\Protocols\Quiddity\Quiddity\Protocols\DNS\DNSChecker.cs (line 187)

                     service = "GC";
                 }
 
▶                if (!Utilities.ArrayIsNullOrEmpty(this.Services) && (!Array.Exists(this.Services, element => element == service.ToUpper())))
                 {
                     return false;
                 }

SS051 Locking on mutable reference 144 hits

📄 Inveigh\Support\Output.cs (line 57)

         public static void Queue(string Output)
         {
 
▶            lock (Program.outputList)
             {
                 Program.outputList.Add(Output);
             }

💬 A lock was obtained on outputList but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Inveigh\Support\Output.cs (line 567)

                             if (Program.enabledFileOutput && (!Program.enabledFileUnique || !isUnique))
                             {
 
▶                                lock (Program.ntlmv2FileList)
                                 {
                                     Program.ntlmv2FileList.Add(challengeResponse);
                                 }

💬 A lock was obtained on ntlmv2FileList but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS058 String concatenated in a loop 42 hits

📄 Inveigh\Protocols\Quiddity\Quiddity\Protocols\DNS\DNSQuestion.cs (line 120)

                 int hostnameSegmentLength = hostnameLength;
                 byte[] hostnameSegment = new byte[hostnameSegmentLength];
                 Buffer.BlockCopy(this.QName, (index + 1), hostnameSegment, 0, hostnameSegmentLength);
▶                hostname += Encoding.UTF8.GetString(hostnameSegment);
                 index += hostnameLength + 1;
                 hostnameLength = this.QName[index];
                 i++;

📄 Inveigh\Protocols\Quiddity\Quiddity\Protocols\DNS\DNSQuestion.cs (line 127)

 
                 if (hostnameLength > 0)
                 {
▶                    hostname += ".";
                 }
 
             }

OpenUtau

470 total diagnostics across 17 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 6 hits

📄 OpenUtau.Core\Classic\VoicebankFiles.cs (line 101)

         }
 
         public void ReleaseSourceTemp() {
▶            var expire = DateTime.Now - TimeSpan.FromDays(7);
             string path = PathManager.Inst.CachePath;
             Log.Information($"ReleaseSourceTemp {path}");
             Directory.EnumerateFiles(path, "*.*", SearchOption.TopDirectoryOnly)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 OpenUtau.Core\Util\TimeAxis.cs (line 44)

         public long Timestamp { get; private set; }
 
         public void BuildSegments(UProject project) {
▶            Timestamp = DateTime.Now.ToFileTimeUtc();
             timeSigSegments.Clear();
             for (var i = 0; i < project.timeSignatures.Count; ++i) {
                 var timesig = project.timeSignatures[i];

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 192 hits

📄 OpenUtau.Core\VocalShaper\VSVocoder.cs (line 41)

         public VSVocoder(int fs, double frameMs, double noiseTimeSec = 5)
         {
             samplesPerSec = fs;
▶            halfSameplesPerSec = samplesPerSec / 2;
             hopSize = (int)(frameMs / 1000 * samplesPerSec);
             frameSize = 2 * hopSize;
             halfWinLen = VSMath.Min2N(hopSize);

💬 The operands in the divisive expression samplesPerSec / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 OpenUtau.Core\Audio\MiniAudioOutput.cs (line 139)

                 eof = true;
             }
             Marshal.Copy(temp, 0, (IntPtr)buffer, samples);
▶            currentTimeMs += n / channels * 1000.0 / sampleRate;
         }
 
         public long GetPosition() {

💬 The operands in the divisive expression n / channels are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 20 hits

📄 OpenUtau.Core\Api\PhonemizerRunner.cs (line 58)

                         toRun.Add(request);
                     }
                     foreach (var request in toRun) {
▶                        parts.Add(request.part);
                     }
                     for (int i = toRun.Count - 1; i >= 0; i--) {
                         if (parts.Remove(toRun[i].part)) {

💬 Type UVoicePart is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 OpenUtau.Core\Api\PhonemizerRunner.cs (line 76)

 
         void SendResponse(PhonemizerResponse response) {
             Task.Factory.StartNew(_ => {
▶                if (DocManager.Inst.Project.parts.Contains(response.part)) {
                     response.part.SetPhonemizerResponse(response);
                 }
                 DocManager.Inst.Project.Validate(new ValidateOptions {

💬 Type UPart is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS005 Equals() and GetHashCode() not implemented together 2 hits

📄 OpenUtau.Core\Ustx\USinger.cs (line 215)

 
     }
 
▶    public class USinger : INotifyPropertyChanged, IEquatable<USinger> {
         protected static readonly List<UOto> emptyOtos = new List<UOto>();
 
         public virtual string Id { get; }

💬 Equals() and GetHashcode() must be implemented together on USinger (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 OpenUtau.Core\Ustx\USinger.cs (line 215)

 
     }
 
▶    public class USinger : INotifyPropertyChanged, IEquatable<USinger> {
         protected static readonly List<UOto> emptyOtos = new List<UOto>();
 
         public virtual string Id { get; }

💬 Equals() and GetHashcode() must be implemented together on USinger (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS013 Rethrow exception without losing stacktrace 4 hits

📄 OpenUtau.Core\Classic\WorldlineResampler.cs (line 34)

                         $"<translate:errors.failed.synth.cutoffbeforeoffset>\n{item.phone.phoneme}",
                         e);
                 }
▶                throw e;
             }
         }
 

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 OpenUtau.Core\Classic\WorldlineRenderer.cs (line 109)

                                     $"<translate:errors.failed.synth.cutoffbeforeoffset>\n{item.phone.phoneme}",
                                     e);
                             }
▶                            throw e;
                         }
                     }
                     int frames = (int)Math.Ceiling(result.estimatedLengthMs / frameMs);

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 88 hits

📄 OpenUtau.Core\Api\G2pDictionaryData.cs (line 6)

     /// Data class used to deserialize yaml dictionary.
     /// </summary>
     public class G2pDictionaryData {
▶        public struct SymbolData {
             public string symbol;
             public string type;
         }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SymbolData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 OpenUtau.Core\Api\G2pDictionaryData.cs (line 11)

             public string type;
         }
 
▶        public struct Entry {
             public string grapheme;
             public string[] phonemes;
         }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Entry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 OpenUtau.Core\Classic\UstNote.cs (line 112)

                 var pby = new List<string>();
                 var pbm = new List<string>();
                 for (var i = 0; i < points.Count; ++i) {
▶                    switch (points[i].shape) {
                         case PitchPointShape.o:
                             pbm.Add("r");
                             break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 OpenUtau.Core\Classic\UstNote.cs (line 112)

                 var pby = new List<string>();
                 var pbm = new List<string>();
                 for (var i = 0; i < points.Count; ++i) {
▶                    switch (points[i].shape) {
                         case PitchPointShape.o:
                             pbm.Add("r");
                             break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 14 hits

📄 OpenUtau.Core\Classic\Presamp.cs (line 92)

                     if (TryGetLinesFromIniBrocks(blocks, "[ALIAS]", out List<IniLine> alias)) {
                         foreach (IniLine line in alias) {
                             var parts = line.line.Split('=');
▶                            switch (parts[0]) {
                                 case "VCV":
                                     AliasRules.VCV = parts[1];
                                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 OpenUtau.Core\Voicevox\VoicevoxRenderer.cs (line 280)

                     int correction = 0;
                     var flag = phrase.phones[i].flags.FirstOrDefault(f => f.Item3.Equals(DUCM));
                     if (flag != null) {
▶                        switch (flag.Item1) {
                             case VoicevoxUtils.ON:
                                 correction = 1;
                                 break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 12 hits

📄 OpenUtau.Core\Voicevox\VoicevoxClient.cs (line 22)

                         Log.Information($"VoicevoxProcess sending {request}");
                         var response = client.SendAsync(request);
                         Log.Information($"VoicevoxProcess received");
▶                        string str = response.Result.Content.ReadAsStringAsync().Result;
                         //May not fit json format
                         if (!str.StartsWith("{") || !str.EndsWith("}")) {
                             str = "{ \"json\":" + str + "}";

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 OpenUtau.Core\Voicevox\VoicevoxClient.cs (line 22)

                         Log.Information($"VoicevoxProcess sending {request}");
                         var response = client.SendAsync(request);
                         Log.Information($"VoicevoxProcess received");
▶                        string str = response.Result.Content.ReadAsStringAsync().Result;
                         //May not fit json format
                         if (!str.StartsWith("{") || !str.EndsWith("}")) {
                             str = "{ \"json\":" + str + "}";

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS040 Unused result on immutable object 4 hits

📄 OpenUtau.Core\Classic\PluginLoader.cs (line 30)

                         if (s.Length != 2) {
                             s = line.Split(new char[] { ':' });
                         }
▶                        Array.ForEach(s, temp => temp.Trim());
                         if (s.Length == 2) {
                             s[0] = s[0].ToLowerInvariant();
                             if (s[0] == "name") {

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 OpenUtau.Core\Classic\VoicebankLoader.cs (line 134)

                     if (s.Length < 2) {
                         s = line.Split('：', 2);
                     }
▶                    Array.ForEach(s, temp => temp.Trim());
                     if (s.Length == 2) {
                         s[0] = s[0].ToLowerInvariant();
                         if (s[0] == "name") {

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS048 Locking on discouraged object (string, Type, this) 8 hits

📄 OpenUtau.Core\Ustx\UPart.cs (line 249)

         }
 
         internal void SetPhonemizerResponse(PhonemizerResponse response) {
▶            lock (this) {
                 phonemizerResponse = response;
             }
         }

📄 OpenUtau.Core\Ustx\UPart.cs (line 147)

                 notesTimestamp = request.timestamp;
                 DocManager.Inst.PhonemizerRunner?.Push(request);
             }
▶            lock (this) {
                 if (phonemizerResponse != null) {
                     var resp = phonemizerResponse;
                     if (resp.timestamp == notesTimestamp) {

SS049 Comparing strings without StringComparison 14 hits

📄 OpenUtau.Core\Classic\Ust.cs (line 122)

                                 ParseNote(project, note, lastNotePos, lastNoteEnd, block.lines, out var noteTempo);
                                 lastNotePos = note.position;
                                 lastNoteEnd = note.End;
▶                                if (note.lyric.ToLowerInvariant() != "r") {
                                     part.notes.Add(note);
                                 }
                                 if (noteTempo != null) {

📄 OpenUtau.Core\Classic\Ust.cs (line 327)

                 int end = ustNote.position + ustNote.duration + part.position;
                 var tempo = project.tempos[tempoIndex];
                 if (pos <= tempo.position && tempo.position < end) {
▶                    if (pos == tempo.position || ustNote.lyric.ToLowerInvariant() != "r") {
                         // Does not break up the note even if the tempo change is in the middle.
                         ustNote.tempo = tempo.bpm;
                         tempoIndex++;

SS051 Locking on mutable reference 50 hits

📄 OpenUtau.Core\Classic\ExeWavtool.cs (line 49)

             }
             PrepareHelper();
             string batPath = Path.Combine(PathManager.Inst.CachePath, "temp.bat");
▶            lock (tempBatLock) {
                 using (var stream = File.Open(batPath, FileMode.Create)) {
                     UTF8Encoding noBomEncoding = new UTF8Encoding(false);
                     using (var writer = new StreamWriter(stream, OS.IsWindows() ? osEncoding : noBomEncoding)) {

💬 A lock was obtained on tempBatLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 OpenUtau.Core\Classic\ToolsManager.cs (line 22)

 
         public List<IResampler> Resamplers {
             get {
▶                lock (_locker) {
                     return resamplers.ToList();
                 }
             }

💬 A lock was obtained on _locker but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS057 Collection manipulated during traversal 8 hits

📄 OpenUtau.Core\Classic\Ust.cs (line 338)

                         inserted.position = tempo.position - part.position;
                         inserted.duration = end - tempo.position;
                         inserted.tempo = tempo.bpm;
▶                        ustNotes.Insert(i + 1, inserted);
                         tempoIndex++;
                     }
                 }

📄 OpenUtau.Core\PlaybackManager.cs (line 154)

                 lock (_lockObj) {
                     // Move to inactive frequencies list
                     inactiveFrequencies.Add(tone.Value);
▶                    activeFrequencies.Remove(tone.Key);
                 }
             }
 

SS058 String concatenated in a loop 14 hits

📄 OpenUtau.Core\Classic\PluginLoader.cs (line 38)

                                 var match = reg.Match(s[1]);
                                 if (match.Success) {
                                     plugin.Shortcut = match.Groups[2].Value;
▶                                    plugin.Name = match.Groups[1].Value + " (" + plugin.Shortcut + ")";
                                 } else {
                                     plugin.Name = s[1];
                                 }

📄 OpenUtau.Core\Editing\LyricBatchEdits.cs (line 116)

 
                     for (int i = 0; i < colors[clrIndex].Length && i < value.Length; i++) {
                         if(colors[clrIndex][i] == value[i]) {
▶                            suffix += value[i];
                         } else {
                             break;
                         }

SS059 IAsyncDisposable not disposed asynchronously 10 hits

📄 OpenUtau.Core\PackageManager.cs (line 150)

                 using var response = await client.GetAsync(mirror.url, HttpCompletionOption.ResponseHeadersRead);
                 response.EnsureSuccessStatusCode();
                 var contentLength = response.Content.Headers.ContentLength;
▶                using var responseStream = await response.Content.ReadAsStreamAsync();
                 using var ms = new MemoryStream();
                 var buffer = new byte[81920];
                 long totalRead = 0;

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 OpenUtau.Core\PackageManager.cs (line 151)

                 response.EnsureSuccessStatusCode();
                 var contentLength = response.Content.Headers.ContentLength;
                 using var responseStream = await response.Content.ReadAsStreamAsync();
▶                using var ms = new MemoryStream();
                 var buffer = new byte[81920];
                 long totalRead = 0;
                 int read;

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 22 hits

📄 OpenUtau.Core\DiffSinger\DiffSingerVariance.cs (line 29)

         Dictionary<string, int> phonemeTokens;
         ulong linguisticHash;
         ulong varianceHash;
▶        InferenceSession linguisticModel;
         InferenceSession varianceModel;
         IG2p g2p;
         float frameMs;

💬 Disposable field linguisticModel in type DsVariance is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 OpenUtau.Core\DiffSinger\DiffSingerVariance.cs (line 30)

         ulong linguisticHash;
         ulong varianceHash;
         InferenceSession linguisticModel;
▶        InferenceSession varianceModel;
         IG2p g2p;
         float frameMs;
         DiffSingerSpeakerEmbedManager speakerEmbedManager;

💬 Disposable field varianceModel in type DsVariance is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Bulk-Crap-Uninstaller

464 total diagnostics across 13 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 source\NBug_custom\Core\Submission\Dispatcher.cs (line 36)

                 ||
                 File.GetLastWriteTime(Settings.EntryAssembly.Location)
                     .AddDays(Settings.StopReportingAfter)
▶                    .CompareTo(DateTime.Now) > 0)
             {
                 if (isAsynchronous)
                 {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 source\NBug_custom\Core\Util\Web\StreamUpload.cs (line 29)

 
         public StreamUpload()
         {
▶            boundary = "---------------------------" + DateTime.Now.Ticks.ToString("x", NumberFormatInfo.InvariantInfo);
         }
 
         public static StreamUpload Create()

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 142 hits

📄 source\ObjectListView\VirtualObjectListView.cs (line 537)

 
                 // Scroll so that the last item of the previous group is just out of sight,
                 // which will make the desired group header visible.
▶                int delta = r.Y + r.Height / 2;
                 NativeMethods.Scroll(this, 0, delta);
             }
         }

💬 The operands in the divisive expression r.Height / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 source\ObjectListView\DragDrop\DropSink.cs (line 919)

 
             if (pt.Y <= (r.Top + close)) {
                 // Scroll faster if the mouse is closer to the top
▶                timer.Interval = ((pt.Y <= (r.Top + close / 2)) ? 100 : 350);
                 timer.Start();
                 scrollAmount = -rowHeight;
             } else {

💬 The operands in the divisive expression close / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 38 hits

📄 source\ObjectListView\Utilities\ColumnSelectionForm.cs (line 73)

             RearrangableColumns = new List<OLVColumn>(AllColumns);
             foreach (OLVColumn col in RearrangableColumns) {
                 if (view == View.Details)
▶                    MapColumnToVisible[col] = col.IsVisible;
                 else
                     MapColumnToVisible[col] = col.IsTileViewColumn;
             }

💬 Type OLVColumn is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 source\ObjectListView\Utilities\ColumnSelectionForm.cs (line 75)

                 if (view == View.Details)
                     MapColumnToVisible[col] = col.IsVisible;
                 else
▶                    MapColumnToVisible[col] = col.IsTileViewColumn;
             }
             RearrangableColumns.Sort(new SortByDisplayOrder(this));
 

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 source\KlocTools\Limited.cs (line 167)

 
         public override int GetHashCode()
         {
▶            return _value.GetHashCode();
         }
 
         TypeCode IConvertible.GetTypeCode()

💬 GetHashCode() refers to mutable field _value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 source\KlocTools\IO\FileSize.cs (line 87)

 
         public override int GetHashCode()
         {
▶            return _sizeInKb.GetHashCode();
         }
 
         public int CompareTo(FileSize other)

💬 GetHashCode() refers to mutable field _sizeInKb (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS015 String placeholders in wrong order 8 hits

📄 source\ObjectListView\VirtualObjectListView.cs (line 235)

 
                 EndUpdate();
 
▶                Debug.WriteLine(String.Format("PERF - Setting virtual CheckedObjects on {2} objects took {0}ms / {1} ticks", sw.ElapsedMilliseconds, sw.ElapsedTicks, GetItemCount()));
             }
         }

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

📄 source\ObjectListView\ObjectListView.cs (line 1359)

                 }
                 EndUpdate();
 
▶                Debug.WriteLine(String.Format("PERF - Setting CheckedObjects on {2} objects took {0}ms / {1} ticks", sw.ElapsedMilliseconds, sw.ElapsedTicks, GetItemCount()));
 
             }
         }

💬 string.Format() Placeholders are not in ascending order. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS015-StringPlaceholdersInWrongOrder.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 74 hits

📄 source\ObjectListView\Implementation\NativeMethods.cs (line 204)

         }
 
         [StructLayout(LayoutKind.Sequential)]
▶        public struct IMAGELISTDRAWPARAMS
         {
             public int cbSize;
             public IntPtr himl;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct IMAGELISTDRAWPARAMS. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 source\ObjectListView\Implementation\NativeMethods.cs (line 226)

         }
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Auto)]
▶        public struct LVBKIMAGE
         {
             public int ulFlags;
             public IntPtr hBmp;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LVBKIMAGE. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 18 hits

📄 source\ObjectListView\CellEditing\CellEditKeyEngine.cs (line 376)

             CellEditAtEdgeBehaviour atEdgeBehaviour;
             if (!CellEditKeyAtEdgeBehaviourMap.TryGetValue(keyData, out atEdgeBehaviour))
                 atEdgeBehaviour = CellEditAtEdgeBehaviour.Wrap;
▶            switch (atEdgeBehaviour) {
             case CellEditAtEdgeBehaviour.Ignore:
                 break;
             case CellEditAtEdgeBehaviour.EndEdit:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 source\ObjectListView\CellEditing\CellEditKeyEngine.cs (line 432)

                 CellEditAtEdgeBehaviour atEdgeBehaviour;
                 if (!CellEditKeyAtEdgeBehaviourMap.TryGetValue(keyData, out atEdgeBehaviour))
                     atEdgeBehaviour = CellEditAtEdgeBehaviour.Wrap;
▶                switch (atEdgeBehaviour)
                 {
                     case CellEditAtEdgeBehaviour.Ignore:
                         return;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 60 hits

📄 source\ObjectListView\CellEditing\CellEditKeyEngine.cs (line 376)

             CellEditAtEdgeBehaviour atEdgeBehaviour;
             if (!CellEditKeyAtEdgeBehaviourMap.TryGetValue(keyData, out atEdgeBehaviour))
                 atEdgeBehaviour = CellEditAtEdgeBehaviour.Wrap;
▶            switch (atEdgeBehaviour) {
             case CellEditAtEdgeBehaviour.Ignore:
                 break;
             case CellEditAtEdgeBehaviour.EndEdit:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 source\ObjectListView\CellEditing\CellEditKeyEngine.cs (line 432)

                 CellEditAtEdgeBehaviour atEdgeBehaviour;
                 if (!CellEditKeyAtEdgeBehaviourMap.TryGetValue(keyData, out atEdgeBehaviour))
                     atEdgeBehaviour = CellEditAtEdgeBehaviour.Wrap;
▶                switch (atEdgeBehaviour)
                 {
                     case CellEditAtEdgeBehaviour.Ignore:
                         return;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 6 hits

📄 source\PortableSettingsProvider\PortableSettingsProvider.cs (line 57)

                         _settingsXml.Load(Path.Combine(GetAppSettingsPath(), GetAppSettingsFilename()));
 
                         if (_settingsXml.SelectSingleNode(SettingsRootName) == null)
▶                            throw new Exception("Invalid config file");
                     }
                     catch (Exception)
                     {

💬 An exception is thrown from the getter of property SettingsXml (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 source\ObjectListView\Rendering\Renderers.cs (line 1748)

                     case StringAlignment.Far:
                         return TextFormatFlags.Bottom;
                     default:
▶                        throw new ArgumentOutOfRangeException();
                 }
             }
         }

💬 An exception is thrown from the getter of property CellVerticalAlignmentAsTextFormatFlag (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 source\KlocTools\Localising\LocalisedNameAttribute.cs (line 14)

     /// <summary>
     ///     Used alongside GetFancyName method to give custom names to properties, fields and enums
     /// </summary>
▶    public class LocalisedNameAttribute : Attribute
     {
         public LocalisedNameAttribute(string name)
         {

💬 LocalisedNameAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 source\KlocTools\Forms\Tools\WindowStyleController.cs (line 76)

             return attrib == null || attrib.AllowStyleChange;
         }
 
▶        public class ControlStyleAttribute : Attribute
         {
             public ControlStyleAttribute(bool allowStyleChange)
             {

💬 ControlStyleAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 6 hits

📄 source\NBug_custom\Core\Reporting\MiniDump\DumpWriter.cs (line 80)

 
         private static bool Write(SafeHandle fileHandle, string dumpType)
         {
▶            if (dumpType.ToLower() == MiniDumpType.Tiny.ToString().ToLower())
             {
                 return Write(fileHandle, DumpTypeFlag.WithIndirectlyReferencedMemory | DumpTypeFlag.ScanMemory);
             }

📄 source\NBug_custom\Core\Reporting\MiniDump\DumpWriter.cs (line 84)

             {
                 return Write(fileHandle, DumpTypeFlag.WithIndirectlyReferencedMemory | DumpTypeFlag.ScanMemory);
             }
▶            if (dumpType.ToLower() == MiniDumpType.Normal.ToString().ToLower())
             {
                 return Write(fileHandle, DumpTypeFlag.Normal);
             }

SS058 String concatenated in a loop 2 hits

📄 source\NBug_custom\Core\Submission\ProtocolBase.cs (line 79)

                         if (!string.IsNullOrEmpty(val))
                         {
                             // Escape = and ; characters
▶                            connectionString += string.Format(
                                 "{0}={1};", property.Name.Replace(";", @"\;").Replace("=", @"\="),
                                 val.Replace(";", @"\;").Replace("=", @"\="));
                         }

📄 source\NBug_custom\Core\Submission\ProtocolBase.cs (line 79)

                         if (!string.IsNullOrEmpty(val))
                         {
                             // Escape = and ; characters
▶                            connectionString += string.Format(
                                 "{0}={1};", property.Name.Replace(";", @"\;").Replace("=", @"\="),
                                 val.Replace(";", @"\;").Replace("=", @"\="));
                         }

SS066 Disposable field is not disposed 92 hits

📄 source\ObjectListView\ObjectListView.cs (line 8955)

                 objectListView.ResumeSelectionEvents();
             }
 
▶            private readonly ObjectListView objectListView;
         }
 
         #endregion

💬 Disposable field objectListView in type SuspendSelectionDisposable is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 source\ObjectListView\Rendering\TreeRenderer.cs (line 69)

                 get { return linePen; }
                 set { linePen = value; }
             }
▶            private Pen linePen;
 
             /// <summary>
             /// Should the renderer draw triangles as the expansion glyphs?

💬 Disposable field linePen in type TreeRenderer is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

UniTask

458 total diagnostics across 10 rules

SS003 Integer divided by integer causing implicit rounding 8 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\Internal\MinimumQueue.cs (line 67)

 
         void Grow()
         {
▶            int newcapacity = (int)((long)array.Length * (long)GrowFactor / 100);
             if (newcapacity < array.Length + MinimumGrow)
             {
                 newcapacity = array.Length + MinimumGrow;

💬 The operands in the divisive expression (long)array.Length * (long)GrowFactor / 100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\Internal\MinimumQueue.cs (line 67)

 
         void Grow()
         {
▶            int newcapacity = (int)((long)array.Length * (long)GrowFactor / 100);
             if (newcapacity < array.Length + MinimumGrow)
             {
                 newcapacity = array.Length + MinimumGrow;

SS017 Struct without Equals/GetHashCode/ToString overridden 236 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\Internal\ArrayPoolUtil.cs (line 81)

             }
         }
 
▶        public struct RentArray<T> : IDisposable
         {
             public readonly T[] Array;
             public readonly int Length;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RentArray. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\IUniTaskAsyncEnumerable.cs (line 68)

         }
 
         [StructLayout(LayoutKind.Auto)]
▶        public readonly struct Enumerator
         {
             private readonly IUniTaskAsyncEnumerator<T> enumerator;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Enumerator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS023 Exception thrown from property getter 16 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\UniTaskObservableExtensions.cs (line 380)

             get
             {
                 ThrowIfDisposed();
▶                if (!isStopped) throw new InvalidOperationException("AsyncSubject is not completed yet");
                 if (lastError != null) ExceptionDispatchInfo.Capture(lastError).Throw();
                 return lastValue;
             }

💬 An exception is thrown from the getter of property Value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\Internal\ValueStopwatch.cs (line 29)

             {
                 if (startTimestamp == 0)
                 {
▶                    throw new InvalidOperationException("Detected invalid initialization(use 'default'), only to create from StartNew().");
                 }
 
                 var delta = Stopwatch.GetTimestamp() - startTimestamp;

💬 An exception is thrown from the getter of property ElapsedTicks (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 8 hits

📄 src\UniTask.NetCoreTests\AsyncLazyTest.cs (line 76)

         async UniTask After()
         {
             await UniTask.Yield();
▶            Thread.Sleep(TimeSpan.FromSeconds(1));
             await UniTask.Yield();
             await UniTask.Yield();
         }

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\UniTask.NetCoreTests\AsyncLazyTest.cs (line 84)

         async UniTask AfterException()
         {
             await UniTask.Yield();
▶            Thread.Sleep(TimeSpan.FromSeconds(1));
             await UniTask.Yield();
             throw new TaskTestException();
         }

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 12 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\UniTaskExtensions.cs (line 326)

                 }
                 finally
                 {
▶                    tokenRegistration.Dispose();
                 }
             }
 

💬 Async overload available for CancellationTokenRegistration.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\UniTaskExtensions.cs (line 268)

                 }
                 finally
                 {
▶                    tokenRegistration.Dispose();
                 }
             }
 

💬 Async overload available for CancellationTokenRegistration.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 8 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\UniTaskExtensions.cs (line 34)

                         p.TrySetException(x.Exception.InnerException ?? x.Exception);
                         break;
                     case TaskStatus.RanToCompletion:
▶                        p.TrySetResult(x.Result);
                         break;
                     default:
                         throw new NotSupportedException();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\UniTaskExtensions.cs (line 34)

                         p.TrySetException(x.Exception.InnerException ?? x.Exception);
                         break;
                     case TaskStatus.RanToCompletion:
▶                        p.TrySetResult(x.Result);
                         break;
                     default:
                         throw new NotSupportedException();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 8 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\CompilerServices\AsyncMethodBuilderAttribute.cs (line 7)

 
 namespace System.Runtime.CompilerServices
 {
▶    internal sealed class AsyncMethodBuilderAttribute : Attribute
     {
         public Type BuilderType { get; }
 

💬 AsyncMethodBuilderAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\CompilerServices\AsyncMethodBuilderAttribute.cs (line 7)

 
 namespace System.Runtime.CompilerServices
 {
▶    internal sealed class AsyncMethodBuilderAttribute : Attribute
     {
         public Type BuilderType { get; }
 

💬 AsyncMethodBuilderAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 88 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\TaskPool.cs (line 45)

 
         public static IEnumerable<(Type, int)> GetCacheSizeInfo()
         {
▶            lock (sizes)
             {
                 foreach (var item in sizes)
                 {

💬 A lock was obtained on sizes but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\TaskPool.cs (line 56)

 
         public static void RegisterSizeGetter(Type type, Func<int> getSize)
         {
▶            lock (sizes)
             {
                 sizes[type] = getSize;
             }

SS063 ValueTask awaited multiple times 2 hits

📄 src\UniTask.NetCoreTests\ChannelTest.cs (line 239)

             wait1 = reference.Reader.WaitToReadAsync();
             wait2 = channel.Reader.WaitToReadAsync();
 
▶            (await Assert.ThrowsAsync<Exception>(async () => await wait1)).Should().Be(ex);
             (await Assert.ThrowsAsync<Exception>(async () => await wait2)).Should().Be(ex);
 
             completion1.Status.Should().Be(TaskStatus.Faulted);

💬 A ValueTask can only be awaited once (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS063-ValueTaskAwaitedMultipleTimes.md)

📄 src\UniTask.NetCoreTests\ChannelTest.cs (line 239)

             wait1 = reference.Reader.WaitToReadAsync();
             wait2 = channel.Reader.WaitToReadAsync();
 
▶            (await Assert.ThrowsAsync<Exception>(async () => await wait1)).Should().Be(ex);
             (await Assert.ThrowsAsync<Exception>(async () => await wait2)).Should().Be(ex);
 
             completion1.Status.Should().Be(TaskStatus.Faulted);

💬 A ValueTask can only be awaited once (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS063-ValueTaskAwaitedMultipleTimes.md)

SS066 Disposable field is not disposed 72 hits

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\AsyncReactiveProperty.cs (line 551)

         {
             static Action<object> cancellationCallback = CancellationCallback;
 
▶            readonly ReadOnlyAsyncReactiveProperty<T> parent;
             readonly CancellationToken cancellationToken;
             readonly CancellationTokenRegistration cancellationTokenRegistration;
             T value;

💬 Disposable field parent in type Enumerator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\UniTask\Assets\Plugins\UniTask\Runtime\AsyncReactiveProperty.cs (line 553)

 
             readonly ReadOnlyAsyncReactiveProperty<T> parent;
             readonly CancellationToken cancellationToken;
▶            readonly CancellationTokenRegistration cancellationTokenRegistration;
             T value;
             bool isDisposed;
             bool firstCall;

💬 Disposable field cancellationTokenRegistration in type Enumerator is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

MQTTnet

456 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 Source\MQTTnet.TestApp\PerformanceTest.cs (line 144)

             stopwatch.Stop();
             Console.WriteLine($"Sent 10.000 messages within {stopwatch.ElapsedMilliseconds} ms ({stopwatch.ElapsedMilliseconds / (float)testMessageCount} ms / message).");
 
▶            var last = DateTime.Now;
             var msgCount = 0;
 
             while (true)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Source\MQTTnet.TestApp\PerformanceTest.cs (line 172)

                     }
                 }
 
▶                var now = DateTime.Now;
                 if (last < now - TimeSpan.FromSeconds(1))
                 {
                     Console.WriteLine($"sending {msgCount} intended {msgChunkSize / interval.TotalSeconds}");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 Source\MQTTnet.Benchmarks\MessageDeliveryBenchmark.cs (line 175)

         _allSubscribedTopics = new List<string>();
 
         var totalNumTopics = _numPublishers * _numTopicsPerPublisher;
▶        var topicIndexStep = totalNumTopics / (_numSubscribedTopicsPerSubscriber * _numSubscribers);
         if (topicIndexStep * _numSubscribedTopicsPerSubscriber * _numSubscribers != totalNumTopics)
         {
             throw new InvalidOperationException(

💬 The operands in the divisive expression totalNumTopics / (_numSubscribedTopicsPerSubscriber * _numSubscribers) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Source\MQTTnet.Benchmarks\MessageDeliveryBenchmark.cs (line 175)

         _allSubscribedTopics = new List<string>();
 
         var totalNumTopics = _numPublishers * _numTopicsPerPublisher;
▶        var topicIndexStep = totalNumTopics / (_numSubscribedTopicsPerSubscriber * _numSubscribers);
         if (topicIndexStep * _numSubscribedTopicsPerSubscriber * _numSubscribers != totalNumTopics)
         {
             throw new InvalidOperationException(

SS004 Elementary methods of type in collection not overridden 12 hits

📄 Source\MQTTnet.Server\Internal\TopicHashMaskSubscriptions.cs (line 17)

             subscriptions = new HashSet<MqttSubscription>();
             SubscriptionsByHashMask.Add(subscription.TopicHashMask, subscriptions);
         }
▶        subscriptions.Add(subscription);
     }
 
     public void RemoveSubscription(MqttSubscription subscription)

💬 Type MqttSubscription is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Source\MQTTnet.Server\Internal\TopicHashMaskSubscriptions.cs (line 17)

             subscriptions = new HashSet<MqttSubscription>();
             SubscriptionsByHashMask.Add(subscription.TopicHashMask, subscriptions);
         }
▶        subscriptions.Add(subscription);
     }
 
     public void RemoveSubscription(MqttSubscription subscription)

SS017 Struct without Equals/GetHashCode/ToString overridden 40 hits

📄 Source\MQTTnet\Internal\AsyncEventInvocator.cs (line 7)

 
 namespace MQTTnet.Internal;
 
▶public readonly struct AsyncEventInvocator<TEventArgs>
 {
     readonly Action<TEventArgs> _handler;
     readonly Func<TEventArgs, Task> _asyncHandler;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AsyncEventInvocator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Source\MQTTnet\Internal\AsyncLock.cs (line 136)

         }
     }
 
▶    readonly struct Releaser : IDisposable
     {
         readonly AsyncLock _asyncLock;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Releaser. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 36 hits

📄 Source\MQTTnet\MqttClient.cs (line 589)

 
         do
         {
▶            switch (connectionStatus)
             {
                 case MqttClientConnectionStatus.Disconnected:
                 case MqttClientConnectionStatus.Disconnecting:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Source\MQTTnet\MqttClient.cs (line 589)

 
         do
         {
▶            switch (connectionStatus)
             {
                 case MqttClientConnectionStatus.Disconnected:
                 case MqttClientConnectionStatus.Disconnecting:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 8 hits

📄 Source\MQTTnet.Tests\Server\User_Properties_Tests.cs (line 17)

 [TestClass]
 public class Feature_Tests
 {
▶    public TestContext TestContext { get; set; }
 
     [TestMethod]
     public async Task Use_User_Properties()

💬 Method set_TestContext might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 Source\MQTTnet.Tests\RoundtripTime_Tests.cs (line 16)

 [TestClass]
 public class RoundtripTime_Tests
 {
▶    public TestContext TestContext { get; set; }
 
     [TestMethod]
     public async Task Round_Trip_Time()

💬 Method set_TestContext might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS027 Exception thrown from Dispose 4 hits

📄 Source\MQTTnet.Tests\Mockups\TestEnvironment.cs (line 328)

             if (_exceptions.Count > 0)
             {
                 // ReSharper disable once ThrowExceptionInUnexpectedLocation
▶                throw new InvalidOperationException($"{_exceptions.Count} exceptions tracked.\r\n" + string.Join(Environment.NewLine, _exceptions));
             }
         }
         finally

💬 An exception is thrown from the Dispose() method in type TestEnvironment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 Source\MQTTnet.Tests\Mockups\TestEnvironment.cs (line 328)

             if (_exceptions.Count > 0)
             {
                 // ReSharper disable once ThrowExceptionInUnexpectedLocation
▶                throw new InvalidOperationException($"{_exceptions.Count} exceptions tracked.\r\n" + string.Join(Environment.NewLine, _exceptions));
             }
         }
         finally

💬 An exception is thrown from the Dispose() method in type TestEnvironment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS033 Async overload is available 12 hits

📄 Source\MQTTnet.AspnetCore\MqttConnectionContext.cs (line 200)

         catch (Exception exception)
         {
             // completing the channel makes sure that there is no more data read after a protocol error
▶            _input?.Complete(exception);
             _output?.Complete(exception);
 
             throw;

💬 Async overload available for PipeReader.Complete (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Source\MQTTnet.AspnetCore\MqttConnectionContext.cs (line 201)

         {
             // completing the channel makes sure that there is no more data read after a protocol error
             _input?.Complete(exception);
▶            _output?.Complete(exception);
 
             throw;
         }

💬 Async overload available for PipeWriter.Complete (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 64 hits

📄 Source\MQTTnet\Adapter\MqttChannelAdapter.cs (line 148)

             var receivedPacketTask = ReceiveAsync(cancellationToken);
             if (receivedPacketTask.IsCompleted)
             {
▶                receivedPacket = receivedPacketTask.Result;
             }
             else
             {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Source\MQTTnet\MqttClient.cs (line 782)

         MqttPacket packet;
         if (packetTask.IsCompleted)
         {
▶            packet = packetTask.Result;
         }
         else
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 32 hits

📄 Source\MQTTnet.Tests\Server\HotSwapCerts_Tests.cs (line 39)

         client01.WaitForConnectOrFail(DefaultTimeout);
 
         client01.HotSwapClientCert();
▶        server.ForceDisconnectAsync(client01).Wait(DefaultTimeout);
         client01.WaitForDisconnectOrFail(DefaultTimeout);
 
         client01.WaitForConnectToFail(DefaultTimeout);

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 Source\MQTTnet.Tests\Server\HotSwapCerts_Tests.cs (line 61)

         client01.WaitForConnectOrFail(DefaultTimeout);
 
         client01.HotSwapClientCert();
▶        server.ForceDisconnectAsync(client01).Wait(DefaultTimeout);
         client01.WaitForDisconnectOrFail(DefaultTimeout);
 
         server.InstallNewClientCert(client01.GetCurrentClientCert());

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS051 Locking on mutable reference 4 hits

📄 Source\MQTTnet.Benchmarks\MessageDeliveryBenchmark.cs (line 144)

             mqttSubscriberClient.ApplicationMessageReceivedAsync += _ =>
             {
                 // count messages and signal cancellation when expected message count is reached
▶                lock (_lockMsgCount)
                 {
                     ++_messagesReceivedCount;
                     if (_messagesReceivedCount == _messagesExpectedCount)

💬 A lock was obtained on _lockMsgCount but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Source\MQTTnet.Benchmarks\MessageDeliveryBenchmark.cs (line 144)

             mqttSubscriberClient.ApplicationMessageReceivedAsync += _ =>
             {
                 // count messages and signal cancellation when expected message count is reached
▶                lock (_lockMsgCount)
                 {
                     ++_messagesReceivedCount;
                     if (_messagesReceivedCount == _messagesExpectedCount)

SS066 Disposable field is not disposed 228 hits

📄 Source\MQTTnet\Implementations\MqttTcpChannel.cs (line 22)

     readonly MqttClientOptions _clientOptions;
     readonly MqttClientTcpOptions _tcpOptions;
 
▶    Stream _stream;
 
     public MqttTcpChannel()
     {

💬 Disposable field _stream in type MqttTcpChannel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Source\MQTTnet\Implementations\MqttTcpChannel.cs (line 47)

         ClientCertificate = clientCertificate;
     }
 
▶    public X509Certificate2 ClientCertificate { get; }
 
     public bool IsSecureConnection { get; }

💬 Disposable field ClientCertificate in type MqttTcpChannel is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

SignalR

406 total diagnostics across 11 rules

SS001 Async method with void return type 2 hits

No source samples extracted

SS003 Integer divided by integer causing implicit rounding 36 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 4 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 32 hits

No source samples extracted

SS019 Switch is missing default label 24 hits

No source samples extracted

SS023 Exception thrown from property getter 2 hits

No source samples extracted

SS034 Accessing Task.Result without await 236 hits

No source samples extracted

SS035 Synchronous task wait instead of await 2 hits

No source samples extracted

SS051 Locking on mutable reference 22 hits

No source samples extracted

SS060 ConcurrentDictionary emptiness check without IsEmpty 2 hits

No source samples extracted

SS066 Disposable field is not disposed 44 hits

No source samples extracted

Dapper

400 total diagnostics across 8 rules

SS007 [Flags] enum values are not powers of two 16 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 64 hits

No source samples extracted

SS018 Switch does not handle all enum options 64 hits

No source samples extracted

SS019 Switch is missing default label 112 hits

No source samples extracted

SS033 Async overload is available 8 hits

No source samples extracted

SS034 Accessing Task.Result without await 48 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 72 hits

No source samples extracted

SS066 Disposable field is not disposed 16 hits

No source samples extracted

ExcelDataReader

400 total diagnostics across 6 rules

SS003 Integer divided by integer causing implicit rounding 144 hits

📄 src\ExcelDataReader\Misc\DateTimeHelper.cs (line 66)

             millis -= millis % MillisPerDay * 2;
         }
 
▶        millis += DoubleDateOffset / TicksPerMillisecond;
 
         if (millis is < 0 or >= MaxMillis)
             throw new ArgumentException("OA Date out of range");

💬 The operands in the divisive expression DoubleDateOffset / TicksPerMillisecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\ExcelDataReader\Core\OfficeCrypto\StandardEncryption.cs (line 286)

 
         byte[] x1 = hashAlgorithm.ComputeHash(derivedKey);
 
▶        if (verifierHashSize > keySize / 8)
             return x1;
 
         for (int i = 0; i < derivedKey.Length; i++)

💬 The operands in the divisive expression keySize / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 src\ExcelDataReader\Log\Logger\NullLogFactory.cs (line 6)

 /// <summary>
 /// The default logger until one is set.
 /// </summary>
▶public readonly struct NullLogFactory : ILogFactory, ILog
 {
     /// <inheritdoc />
     public void Debug(string message, params object[] formatting)

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NullLogFactory. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\ExcelDataReader\Log\Logger\NullLogFactory.cs (line 6)

 /// <summary>
 /// The default logger until one is set.
 /// </summary>
▶public readonly struct NullLogFactory : ILogFactory, ILog
 {
     /// <inheritdoc />
     public void Debug(string message, params object[] formatting)

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NullLogFactory. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 32 hits

📄 src\ExcelDataReader\Core\BinaryFormat\XlsWorksheet.cs (line 235)

     {
         LogManager.Log(this).Debug("ReadMultiCell {0}", cell.Id);
 
▶        switch (cell.Id)
         {
             case BIFFRECORDTYPE.MULRK:
 

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\ExcelDataReader\Core\BinaryFormat\XlsWorksheet.cs (line 267)

 
         object value = null;
         CellError? error = null;
▶        switch (cell.Id)
         {
             case BIFFRECORDTYPE.BOOLERR:
                 if (cell.ReadByte(7) == 0)

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 144 hits

📄 src\ExcelDataReader\Core\OpenXmlFormat\XlsxWorkbook.cs (line 58)

 
         while (reader.Read() is { } record)
         {
▶            switch (record)
             {
                 case SharedStringRecord pr:
                     SST.Add(pr.Value);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\ExcelDataReader\Core\OpenXmlFormat\XlsxWorkbook.cs (line 35)

 
         while (reader?.Read() is { } record)
         {                
▶            switch (record)
             {
                 case WorkbookPrRecord pr:
                     IsDate1904 = pr.Date1904;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 8 hits

📄 src\ExcelDataReader\Core\CsvFormat\CsvWorksheet.cs (line 61)

         {
             if (AnalyzedPartial)
             {
▶                throw new InvalidOperationException("Cannot use RowCount with AnalyzeInitialCsvRows > 0");
             }
 
             return AnalyzedRowCount;

💬 An exception is thrown from the getter of property RowCount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\ExcelDataReader\Core\CsvFormat\CsvWorksheet.cs (line 61)

         {
             if (AnalyzedPartial)
             {
▶                throw new InvalidOperationException("Cannot use RowCount with AnalyzeInitialCsvRows > 0");
             }
 
             return AnalyzedRowCount;

💬 An exception is thrown from the getter of property RowCount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS066 Disposable field is not disposed 64 hits

📄 src\ExcelDataReader\Core\BinaryFormat\XlsBiffStream.cs (line 83)

     /// </summary>
     public int Position { get => (int)BaseStream.Position; set => Seek(value, SeekOrigin.Begin); }
 
▶    public Stream BaseStream { get; }
 
     public byte[] SecretKey { get; }

💬 Disposable field BaseStream in type XlsBiffStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\ExcelDataReader\Misc\LeaveOpenStream.cs (line 17)

 
     public override long Position { get => BaseStream.Position; set => BaseStream.Position = value; }
 
▶    private Stream BaseStream { get; } = baseStream;
 
     public override void Flush() => BaseStream.Flush();

💬 Disposable field BaseStream in type LeaveOpenStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

g-helper

400 total diagnostics across 9 rules

SS001 Async method with void return type 8 hits

📄 app\AutoUpdate\AutoUpdateControl.cs (line 66)

             }
         }
 
▶        async void CheckForUpdatesAsync(bool force = false)
         {
 
             if (AppConfig.Is("skip_updates")) return;

💬 Method CheckForUpdatesAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 app\AutoUpdate\AutoUpdateControl.cs (line 145)

             return Regex.Replace(Regex.Replace(input, @"\[|\]", "`$0"), @"\'", "''");
         }
 
▶        async void AutoUpdate(string requestUri)
         {
 
             Uri uri = new Uri(requestUri);

💬 Method AutoUpdate is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 14 hits

📄 app\Helpers\Logger.cs (line 10)

 
     public static void WriteLine(string logMessage)
     {
▶        Debug.WriteLine($"{DateTime.Now}: {logMessage}");
         if (!Directory.Exists(appPath)) Directory.CreateDirectory(appPath);
 
         try

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 app\Helpers\Logger.cs (line 17)

         {
             using (StreamWriter w = File.AppendText(logFile))
             {
▶                w.WriteLine($"{DateTime.Now}: {logMessage}");
                 w.Close();
             }
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 92 hits

📄 app\AsusACPI.cs (line 528)

         if (curve.Length != 16) return -1;
         if (curve.All(singleByte => singleByte == 0)) return -1;
 
▶        byte min = (byte)(curve[8] * 255 / 100);
         byte max = (byte)(curve[15] * 255 / 100);
         byte[] range = { min, max };
 

💬 The operands in the divisive expression curve

📄 app\AsusACPI.cs (line 529)

         if (curve.All(singleByte => singleByte == 0)) return -1;
 
         byte min = (byte)(curve[8] * 255 / 100);
▶        byte max = (byte)(curve[15] * 255 / 100);
         byte[] range = { min, max };
 
         int result;

💬 The operands in the divisive expression curve

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 app\Peripherals\Mouse\AsusMouse.cs (line 151)

 
         public override int GetHashCode()
         {
▶            return HashCode.Combine(LightingMode, Brightness, RGBColor, RandomColor, AnimationSpeed, AnimationDirection);
         }
 
         public override string? ToString()

💬 GetHashCode() refers to mutable property LightingMode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 app\Peripherals\Mouse\AsusMouse.cs (line 151)

 
         public override int GetHashCode()
         {
▶            return HashCode.Combine(LightingMode, Brightness, RGBColor, RandomColor, AnimationSpeed, AnimationDirection);
         }
 
         public override string? ToString()

💬 GetHashCode() refers to mutable property Brightness (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 132 hits

📄 app\Display\GammaRamp.cs (line 7)

 {
 
     [StructLayout(LayoutKind.Sequential)]
▶    internal struct GammaRamp
     {
         public const int DataPoints = 256;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GammaRamp. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 app\Helpers\RestrictedProcessHelper.cs (line 117)

     }
 
     [StructLayout(LayoutKind.Sequential)]
▶    private struct PROCESS_INFORMATION
     {
         public IntPtr hProcess;
         public IntPtr hThread;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PROCESS_INFORMATION. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 24 hits

📄 app\Input\KeyboardHook.cs (line 38)

 
     public static void KeyPress(Keys key)
     {
▶        switch (key)
         {
             case Keys.LButton:
                 mouse_event(MOUSEEVENTF_LEFTDOWN | MOUSEEVENTF_LEFTUP, (uint)Cursor.Position.X, (uint)Cursor.Position.Y, 0, 0);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 app\Ally\AllyControl.cs (line 723)

 
         public void ToggleMode()
         {
▶            switch (_mode)
             {
                 case ControllerMode.Auto:
                     SetMode(ControllerMode.Gamepad);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 62 hits

📄 app\Input\KeyboardHook.cs (line 38)

 
     public static void KeyPress(Keys key)
     {
▶        switch (key)
         {
             case Keys.LButton:
                 mouse_event(MOUSEEVENTF_LEFTDOWN | MOUSEEVENTF_LEFTUP, (uint)Cursor.Position.X, (uint)Cursor.Position.Y, 0, 0);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 app\Ryzen\RyzenSmu.cs (line 45)

             RyzenNbAccesss = new Ols();
 
             // Check WinRing0 status
▶            switch (RyzenNbAccesss.GetDllStatus())
             {
                 case (uint)Ols.OlsDllStatus.OLS_DLL_NO_ERROR:
                     if (ShowDebug)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS049 Comparing strings without StringComparison 6 hits

📄 app\UI\RForm.cs (line 74)

         {
             string? uiMode = AppConfig.GetString("ui_mode");
 
▶            if (uiMode is not null && uiMode.ToLower() == "dark")
             {
                 return true;
             }

📄 app\UI\RForm.cs (line 79)

                 return true;
             }
 
▶            if (uiMode is not null && uiMode.ToLower() == "light")
             {
                 return false;
             }

SS066 Disposable field is not disposed 50 hits

📄 app\Updates.cs (line 25)

         static int updatesCount = 0;
         private static long lastUpdate;
 
▶        private readonly Font _boldUnderlineFont;
         private readonly Font _font;
 
         public struct DriverDownload

💬 Disposable field _boldUnderlineFont in type Updates is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 app\Updates.cs (line 26)

         private static long lastUpdate;
 
         private readonly Font _boldUnderlineFont;
▶        private readonly Font _font;
 
         public struct DriverDownload
         {

💬 Disposable field _font in type Updates is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

git-credential-manager

396 total diagnostics across 10 rules

SS001 Async method with void return type 4 hits

📄 src\shared\Core\Diagnostics\NetworkingDiagnostic.cs (line 101)

             return true;
         }
 
▶        internal /* For testing purposes */ async void SendHttpRequest(StringBuilder log, HttpClient httpClient)
         {
             foreach (var uri in new List<string> { TestHttpUri, TestHttpUriFallback })
             {

💬 Method SendHttpRequest is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\shared\Core\Diagnostics\NetworkingDiagnostic.cs (line 101)

             return true;
         }
 
▶        internal /* For testing purposes */ async void SendHttpRequest(StringBuilder log, HttpClient httpClient)
         {
             foreach (var uri in new List<string> { TestHttpUri, TestHttpUriFallback })
             {

💬 Method SendHttpRequest is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\shared\Core\Trace.cs (line 328)

             }
 
             // Git's trace format is "{timestamp,-15} {source,-23} trace: {details}"
▶            string text = $"{DateTime.Now:HH:mm:ss.ffffff} {source,-23} trace: [{memberName}] {message}";
 
             return text;
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\shared\Core\Trace.cs (line 328)

             }
 
             // Git's trace format is "{timestamp,-15} {source,-23} trace: {details}"
▶            string text = $"{DateTime.Now:HH:mm:ss.ffffff} {source,-23} trace: [{memberName}] {message}";
 
             return text;
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 src\shared\Core\Trace.cs (line 149)

             lock (_writersLock)
             {
                 // Try not to add the same listener more than once
▶                if (_writers.Contains(listener))
                     return;
 
                 _writers.Add(listener);

💬 Type TextWriter is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\shared\Core\Trace.cs (line 149)

             lock (_writersLock)
             {
                 // Try not to add the same listener more than once
▶                if (_writers.Contains(listener))
                     return;
 
                 _writers.Add(listener);

SS017 Struct without Equals/GetHashCode/ToString overridden 80 hits

📄 src\shared\Core\IniFile.cs (line 30)

     }
 
     [DebuggerDisplay("{DebuggerDisplay}")]
▶    public readonly struct IniSectionName : IEquatable<IniSectionName>
     {
         public IniSectionName(string name, string subName = null)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct IniSectionName. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\shared\Core\PlatformUtils.cs (line 499)

         }
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
▶        private unsafe struct RTL_OSVERSIONINFOEX
         {
             internal uint dwOSVersionInfoSize;
             internal uint dwMajorVersion;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RTL_OSVERSIONINFOEX. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 12 hits

📄 src\shared\Core\UI\Dispatcher.cs (line 146)

             {
                 lock (_queue)
                 {
▶                    switch (_state)
                     {
                         case State.Started:
                             throw new InvalidOperationException("Dispatcher has already started.");

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\shared\Core\UI\Dispatcher.cs (line 169)

             {
                 lock (_queue)
                 {
▶                    switch (_state)
                     {
                         case State.NotStarted:
                             throw new InvalidOperationException("Dispatcher is not running.");

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 24 hits

📄 src\shared\Core\UI\ViewModels\CredentialsViewModel.cs (line 21)

 
         private void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
         {
▶            switch (e.PropertyName)
             {
                 case nameof(UserName):
                 case nameof(Password):

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\shared\Core\InputArguments.cs (line 148)

                     // We know the first piece is the path
                     ub.Path = pathParts[0];
 
▶                    switch (pathParts.Length)
                     {
                         // If we have 3 items, that means path, query, and fragment
                         case 3:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 150 hits

📄 src\shared\Core\Commands\GetCommand.cs (line 50)

             Context.Trace.WriteDictionarySecrets(output, new []{ "password" }, StringComparer.OrdinalIgnoreCase);
 
             // Write the values to standard out
▶            Context.Streams.Out.WriteDictionary(output);
         }
     }
 }

💬 Async overload available for StreamExtensions.WriteDictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\shared\Core\ConfigurationService.cs (line 100)

             foreach (IConfigurableComponent component in _components)
             {
                 _context.Trace.WriteLine($"Unconfiguring component '{component.Name}'...");
▶                _context.Streams.Error.WriteLine($"Unconfiguring component '{component.Name}'...");
                 await component.UnconfigureAsync(target);
             }
         }

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS057 Collection manipulated during traversal 8 hits

📄 src\shared\Core\Trace.cs (line 299)

                     {
                         using (var writer = _writers[i])
                         {
▶                            _writers.Remove(writer);
                         }
                     }
                 }

📄 src\shared\Core\Trace2.cs (line 467)

                 {
                     using (var writer = _writers[i])
                     {
▶                        _writers.Remove(writer);
                     }
                 }
             }

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 src\shared\Core\Commands\DiagnoseCommand.cs (line 80)

             string logFilePath = Path.Combine(outputDir, "gcm-diagnose.log");
             var extraLogs = new List<string>();
 
▶            using var fullLog = new StreamWriter(logFilePath, append: false, Encoding.UTF8);
             fullLog.WriteLine("Diagnose log at {0:s}Z", DateTime.UtcNow);
             fullLog.WriteLine();
             fullLog.WriteLine($"AppPath: {_context.ApplicationPath}");

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\shared\Core\Commands\DiagnoseCommand.cs (line 80)

             string logFilePath = Path.Combine(outputDir, "gcm-diagnose.log");
             var extraLogs = new List<string>();
 
▶            using var fullLog = new StreamWriter(logFilePath, append: false, Encoding.UTF8);
             fullLog.WriteLine("Diagnose log at {0:s}Z", DateTime.UtcNow);
             fullLog.WriteLine();
             fullLog.WriteLine($"AppPath: {_context.ApplicationPath}");

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 108 hits

📄 src\shared\Core\Interop\Windows\WindowsTerminal.cs (line 167)

 
         private class TtyContext : IDisposable
         {
▶            private readonly ITrace _trace;
             private readonly ITrace2 _trace2;
             private readonly SafeFileHandle _stream;
 

💬 Disposable field _trace in type TtyContext is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\shared\Core\Interop\Windows\WindowsTerminal.cs (line 168)

         private class TtyContext : IDisposable
         {
             private readonly ITrace _trace;
▶            private readonly ITrace2 _trace2;
             private readonly SafeFileHandle _stream;
 
             private ConsoleMode _originalMode;

💬 Disposable field _trace2 in type TtyContext is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Util

384 total diagnostics across 19 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 24 hits

📄 src\Util.Core\Helpers\FileWatcher.cs (line 249)

     /// <param name="path">文件路径</param>
     /// <param name="debounceInterval">防抖间隔</param>
     internal bool IsValid( string path, int debounceInterval ) {
▶        if ( _file != null && path == _file.Path && DateTime.Now - _file.Time < TimeSpan.FromMilliseconds( debounceInterval ) ) {
             _file = new WatchFile( path );
             return false;
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Util.Core\Helpers\FileWatcher.cs (line 268)

     /// <param name="path">文件路径</param>
     public WatchFile( string path ) {
         Path = path;
▶        Time = DateTime.Now;
     }
 
     /// <summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 20 hits

📄 src\Util.Core\Helpers\Time.cs (line 150)

     public static long GetUnixTimestamp( DateTime time ) {
         var start = TimeZoneInfo.ConvertTime( new DateTime( 1970, 1, 1 ), TimeZoneInfo.Local );
         long ticks = ( time - start.Add( new TimeSpan( 8, 0, 0 ) ) ).Ticks;
▶        return Util.Helpers.Convert.ToLong( ticks / TimeSpan.TicksPerSecond );
     }
 
     /// <summary>

📄 src\Util.Images.ImageSharp\ImageWrapper.cs (line 140)

         var options = new RichTextOptions( _font ) {
             VerticalAlignment = VerticalAlignment.Center,
             HorizontalAlignment = HorizontalAlignment.Center,
▶            Origin = new Vector2( _width / 2, _height / 2 )
         };
         return Text( text, color, options );
     }

💬 The operands in the divisive expression _width / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 26 hits

📄 src\Util.Core\Expressions\ParameterRebinder.cs (line 34)

     /// </summary>
     /// <param name="parameterExpression">参数</param>
     protected override Expression VisitParameter( ParameterExpression parameterExpression ) {
▶        if( _map.TryGetValue( parameterExpression, out var replacement ) )
             parameterExpression = replacement;
         return base.VisitParameter( parameterExpression );
     }

💬 Type ParameterExpression is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Util.Templates.Razor\RazorEngineCore\RazorEngineCompilationOptionsBuilder.cs (line 40)

 
     public void AddMetadataReference(MetadataReference reference)
     {
▶        this.Options.MetadataReferences.Add(reference);
     }
 
     public void AddUsing(string namespaceName)

💬 Type MetadataReference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 4 hits

📄 src\Util.Domain\Entities\EntityBase.cs (line 58)

     /// 获取哈希
     /// </summary>
     public override int GetHashCode() {
▶        return ReferenceEquals( Id, null ) ? 0 : Id.GetHashCode();
     }
 
     /// <summary>

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Util.Domain\Entities\EntityBase.cs (line 58)

     /// 获取哈希
     /// </summary>
     public override int GetHashCode() {
▶        return ReferenceEquals( Id, null ) ? 0 : Id.GetHashCode();
     }
 
     /// <summary>

💬 GetHashCode() refers to mutable property Id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\Util.FileStorage.Abstractions\FileSize.cs (line 6)

 /// <summary>
 /// 文件大小
 /// </summary>
▶public readonly struct FileSize {
     /// <summary>
     /// 文件字节长度
     /// </summary>

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FileSize. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Util.FileStorage.Abstractions\FileSize.cs (line 6)

 /// <summary>
 /// 文件大小
 /// </summary>
▶public readonly struct FileSize {
     /// <summary>
     /// 文件字节长度
     /// </summary>

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FileSize. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 34 hits

📄 src\Util.Core\ExpressionExtensions.cs (line 329)

     /// <param name="operator">运算符</param>
     /// <param name="value">值</param>
     public static Expression Operation( this Expression left, Operator @operator, Expression value ) {
▶        switch( @operator ) {
             case Operator.Equal:
                 return left.Equal( value );
             case Operator.NotEqual:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Util.Core\ExpressionExtensions.cs (line 299)

     /// <param name="operator">运算符</param>
     /// <param name="value">值</param>
     public static Expression Operation( this Expression left, Operator @operator, object value ) {
▶        switch( @operator ) {
             case Operator.Equal:
                 return left.Equal( value );
             case Operator.NotEqual:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 54 hits

📄 src\Util.Core\ExpressionExtensions.cs (line 329)

     /// <param name="operator">运算符</param>
     /// <param name="value">值</param>
     public static Expression Operation( this Expression left, Operator @operator, Expression value ) {
▶        switch( @operator ) {
             case Operator.Equal:
                 return left.Equal( value );
             case Operator.NotEqual:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Util.Core\ExpressionExtensions.cs (line 299)

     /// <param name="operator">运算符</param>
     /// <param name="value">值</param>
     public static Expression Operation( this Expression left, Operator @operator, object value ) {
▶        switch( @operator ) {
             case Operator.Equal:
                 return left.Equal( value );
             case Operator.NotEqual:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 2 hits

📄 src\Util.Generators\Contexts\EntityContext.cs (line 78)

             var result = Properties.FirstOrDefault( t => t.IsKey );
             if( result == null ) {
                 var message = string.Format( GeneratorResource.NotSetPrimaryKey, GetNameWithSchema() );
▶                throw new InvalidOperationException( message );
             }
             return result;
         }

💬 An exception is thrown from the getter of property Key (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Util.Generators\Contexts\EntityContext.cs (line 78)

             var result = Properties.FirstOrDefault( t => t.IsKey );
             if( result == null ) {
                 var message = string.Format( GeneratorResource.NotSetPrimaryKey, GetNameWithSchema() );
▶                throw new InvalidOperationException( message );
             }
             return result;
         }

💬 An exception is thrown from the getter of property Key (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 122 hits

📄 test\Util.Microservices.Dapr.PubsubSample\Program.cs (line 20)

 app.UseCloudEvents();
 app.MapSubscribeHandler();
 app.MapControllers();
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 test\Util.Microservices.Dapr.WebApiSample\Program.cs (line 20)

 app.UseCloudEvents();
 app.MapSubscribeHandler();
 app.MapControllers();
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 8 hits

📄 src\Util.Ui\Sources\Spa\Util\TaskTimeoutExtensions.cs (line 24)

     {
         if (task == await Task.WhenAny(task, Task.Delay(timeoutDelay)))
         {
▶            return task.Result;
         }
         else
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Util.Ui\Sources\Spa\Proxying\SpaProxy.cs (line 290)

                 await Task.Delay(100, cancellationToken);
             }
 
▶            var result = resultTask.Result; // We know it's completed already
             if (result.MessageType == WebSocketMessageType.Close)
             {
                 if (destination.State == WebSocketState.Open || destination.State == WebSocketState.CloseReceived)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 2 hits

📄 src\Util.Ui\Sources\Spa\Util\TaskTimeoutExtensions.cs (line 12)

     {
         if (task == await Task.WhenAny(task, Task.Delay(timeoutDelay)))
         {
▶            task.Wait(); // Allow any errors to propagate
         }
         else
         {

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 src\Util.Ui\Sources\Spa\Util\TaskTimeoutExtensions.cs (line 12)

     {
         if (task == await Task.WhenAny(task, Task.Delay(timeoutDelay)))
         {
▶            task.Wait(); // Allow any errors to propagate
         }
         else
         {

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS037 HttpClient instantiated directly 4 hits

📄 src\Util.Ui\Sources\Spa\Proxying\SpaProxy.cs (line 44)

             UseCookies = false,
         };
 
▶        return new HttpClient(handler)
         {
             Timeout = requestTimeout
         };

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 src\Util.Ui\Sources\Spa\AngularCli\AngularCliMiddleware.cs (line 87)

     }
 
     private static async Task WaitForAngularCliServerToAcceptRequests( Uri cliServerUri, CancellationToken applicationStoppingToken ) {
▶        using var client = new HttpClient();
         var i = 0;
         while ( true ) {
             try {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 src\Util.Security\Helpers\Encrypt.cs (line 273)

         encoding ??= Encoding.UTF8;
         var sha256 = new HMACSHA256( Encoding.ASCII.GetBytes( key ) );
         var hash = sha256.ComputeHash( encoding.GetBytes( value ) );
▶        return string.Join( "", hash.ToList().Select( t => t.ToString( "x2" ) ).ToArray() );
     }
 
     #endregion

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Util.Security\Helpers\Encrypt.cs (line 273)

         encoding ??= Encoding.UTF8;
         var sha256 = new HMACSHA256( Encoding.ASCII.GetBytes( key ) );
         var hash = sha256.ComputeHash( encoding.GetBytes( value ) );
▶        return string.Join( "", hash.ToList().Select( t => t.ToString( "x2" ) ).ToArray() );
     }
 
     #endregion

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 10 hits

📄 src\Util.Core\Ui\HtmlAttribute.cs (line 6)

 /// <summary>
 /// 用于控制Razor Page生成Html的路径
 /// </summary>
▶public class HtmlAttribute : Attribute {
     /// <summary>
     /// 生成路径，相对根路径，范例：/ClientApp/src/app/app.component.html
     /// </summary>

💬 HtmlAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Util.Localization\LocalizedTypeAttribute.cs (line 6)

 /// <summary>
 /// 本地化资源类型
 /// </summary>
▶public class LocalizedTypeAttribute : Attribute {
     /// <summary>
     /// 本地化资源类型
     /// </summary>

💬 LocalizedTypeAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 46 hits

📄 src\Util.FileStorage\FileNameProcessorFactory.cs (line 24)

     public IFileNameProcessor CreateProcessor( string policy ) {
         if ( policy.IsEmpty() )
             return new FileNameProcessor();
▶        if ( policy.ToUpperInvariant() == UserTimeFileNameProcessor.Policy )
             return new UserTimeFileNameProcessor( _session );
         throw new NotImplementedException( $"文件名处理策略 {policy} 未实现." );
     }

📄 test\Util.FileStorage.Tests.Integration\Samples\TestFileNameProcessorFactory.cs (line 15)

     public IFileNameProcessor CreateProcessor( string policy ) {
         if ( policy.IsEmpty() )
             return new FileNameProcessor();
▶        if ( policy.ToLowerInvariant() == "test" )
             return new TestFileNameProcessor();
         throw new NotImplementedException( $"文件名处理策略 {policy} 未实现." );
     }

SS056 HttpRequest.Form read synchronously 4 hits

📄 src\Util.AspNetCore\Helpers\Web.cs (line 151)

     /// </summary>
     public static List<IFormFile> GetFiles() {
         var result = new List<IFormFile>();
▶        var files = Request.Form.Files;
         if ( files.Count == 0 )
             return result;
         result.AddRange( files.Where( file => file?.Length > 0 ) );

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 src\Util.AspNetCore\Helpers\Web.cs (line 186)

         string result = Request.Query[name];
         if ( result.IsEmpty() == false )
             return result;
▶        result = Request.Form[name];
         if ( result.IsEmpty() == false )
             return result;
         return Request.Headers[name];

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS058 String concatenated in a loop 2 hits

📄 src\Util.Tenants\Resolvers\Internal\DomainTenantResolver.cs (line 39)

                     domainMap.Add( item.Key, item.Value );
                 }
             }
▶            domainFormat += $",{resolver.DomainFormat}";
         }
         var map = await DomainTenantResolverHelper.CombineMapAsync( domainMap, _store );
         return DomainTenantResolverHelper.ResolveTenantId( host, map, domainFormat );

📄 src\Util.Tenants\Resolvers\Internal\DomainTenantResolver.cs (line 39)

                     domainMap.Add( item.Key, item.Value );
                 }
             }
▶            domainFormat += $",{resolver.DomainFormat}";
         }
         var map = await DomainTenantResolverHelper.CombineMapAsync( domainMap, _store );
         return DomainTenantResolverHelper.ResolveTenantId( host, map, domainFormat );

SS059 IAsyncDisposable not disposed asynchronously 10 hits

📄 src\Util.Images.ImageSharp\ImageWrapper.cs (line 188)

     /// <inheritdoc />
     public async Task<byte[]> ToStreamAsync( CancellationToken cancellationToken = default ) {
         using var image = GetImage();
▶        using var stream = new MemoryStream();
         _commands.ForEach( command => command.Invoke( image ) );
         await image.SaveAsync( stream, GetImageEncoder(), cancellationToken );
         return await Util.Helpers.File.ToBytesAsync( stream, cancellationToken );

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Util.QrCode.ZXing\ZXing\ZXingQrCodeService.cs (line 167)

     /// <inheritdoc />
     public async Task<byte[]> ToBytesAsync( CancellationToken cancellationToken = default ) {
         using var image = GetImage();
▶        using var stream = new MemoryStream();
         await image.SaveAsync( stream, GetImageEncoder(), cancellationToken );
         return stream.ToArray();
     }

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 8 hits

📄 src\Util.Core\Helpers\FileWatcher.cs (line 10)

     /// <summary>
     /// 文件系统监视器
     /// </summary>
▶    private readonly FileSystemWatcher _watcher;
     /// <summary>
     /// 防抖间隔
     /// </summary>

💬 Disposable field _watcher in type FileWatcher is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Util.Data.EntityFrameworkCore\StoreBase.cs (line 55)

     /// <summary>
     /// 工作单元
     /// </summary>
▶    protected UnitOfWorkBase UnitOfWork { get; }
 
     /// <summary>
     /// 实体集

💬 Disposable field UnitOfWork in type StoreBase is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Il2CppDumper

380 total diagnostics across 7 rules

SS003 Integer divided by integer causing implicit rounding 96 hits

📄 Il2CppDumper\ExecutableFormats\Elf64.cs (line 32)

                 FixedProgramSegment();
             }
             pt_dynamic = programSegment.First(x => x.p_type == PT_DYNAMIC);
▶            dynamicSection = ReadClassArray<Elf64_Dyn>(pt_dynamic.p_offset, pt_dynamic.p_filesz / 16L);
             if (IsDumped)
             {
                 FixedDynamicSection();

💬 The operands in the divisive expression pt_dynamic.p_filesz / 16L are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Il2CppDumper\ExecutableFormats\Elf.cs (line 41)

                 FixedProgramSegment();
             }
             pt_dynamic = programSegment.First(x => x.p_type == PT_DYNAMIC);
▶            dynamicSection = ReadClassArray<Elf32_Dyn>(pt_dynamic.p_offset, pt_dynamic.p_filesz / 8u);
             if (IsDumped)
             {
                 FixedDynamicSection();

💬 The operands in the divisive expression pt_dynamic.p_filesz / 8u are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 128 hits

📄 Il2CppDumper\Il2Cpp\Il2Cpp.cs (line 255)

                     methodDefinitionMethodSpecs.Add(methodDefinitionIndex, list);
                 }
                 list.Add(methodSpec);
▶                methodSpecGenericMethodPointers.Add(methodSpec, genericMethodPointers[table.indices.methodIndex]);
             }
         }
 

💬 Type Il2CppMethodSpec is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Il2CppDumper\Utils\DummyAssemblyGenerator.cs (line 90)

                     var namespaceName = metadata.GetStringFromIndex(typeDef.namespaceIndex);
                     var typeName = metadata.GetStringFromIndex(typeDef.nameIndex);
                     var typeDefinition = new TypeDefinition(namespaceName, typeName, (TypeAttributes)typeDef.flags);
▶                    typeDefinitionDic.Add(typeDef, typeDefinition);
                     if (typeDef.declaringTypeIndex == -1)
                     {
                         moduleDefinition.Types.Add(typeDefinition);

💬 Type Il2CppTypeDefinition is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 Il2CppDumper\Utils\FileDialogNative.cs (line 146)

         }
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Auto, Pack = 4)]
▶        internal struct COMDLG_FILTERSPEC
         {
             [MarshalAs(UnmanagedType.LPWStr)]
             internal string pszName;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct COMDLG_FILTERSPEC. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Il2CppDumper\Utils\FileDialogNative.cs (line 146)

         }
 
         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Auto, Pack = 4)]
▶        internal struct COMDLG_FILTERSPEC
         {
             [MarshalAs(UnmanagedType.LPWStr)]
             internal string pszName;

SS018 Switch does not handle all enum options 16 hits

📄 Il2CppDumper\Outputs\StructGenerator.cs (line 832)

                     {
                         rgctxDefData = definitionData.data;
                     }
▶                    switch (definitionData.type)
                     {
                         case Il2CppRGCTXDataType.IL2CPP_RGCTX_DATA_TYPE:
                             {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Il2CppDumper\Outputs\StructGenerator.cs (line 878)

                     {
                         rgctxDefData = definitionData.data;
                     }
▶                    switch (definitionData.type)
                     {
                         case Il2CppRGCTXDataType.IL2CPP_RGCTX_DATA_TYPE:
                             {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 96 hits

📄 Il2CppDumper\Utils\SectionHelper.cs (line 153)

 
         private void SetSection(SearchSectionType type, List<SearchSection> secs)
         {
▶            switch (type)
             {
                 case SearchSectionType.Exec:
                     exec = secs;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Il2CppDumper\ExecutableFormats\Elf64.cs (line 108)

             foreach (var symbol in symbolTable)
             {
                 var name = ReadStringToNull(dynstrOffset + symbol.st_name);
▶                switch (name)
                 {
                     case "g_CodeRegistration":
                         codeRegistration = symbol.st_value;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS058 String concatenated in a loop 28 hits

📄 Il2CppDumper\Outputs\StructGenerator.cs (line 103)

                             var returnType = ParseType(methodReturnType);
                             if (methodReturnType.byref == 1)
                             {
▶                                returnType += "*";
                             }
                             methodTypeSignature.Add(methodReturnType.byref == 1 ? Il2CppTypeEnum.IL2CPP_TYPE_PTR : methodReturnType.type);
                             var signature = $"{returnType} {FixName(methodFullName)} (";

📄 Il2CppDumper\Outputs\StructGenerator.cs (line 134)

                             }
                             methodTypeSignature.Add(Il2CppTypeEnum.IL2CPP_TYPE_PTR);
                             parameterStrs.Add("const MethodInfo* method");
▶                            signature += string.Join(", ", parameterStrs);
                             signature += ");";
                             scriptMethod.Signature = signature;
                             scriptMethod.TypeSignature = GetMethodTypeSignature(methodTypeSignature);

SS066 Disposable field is not disposed 12 hits

📄 Il2CppDumper\IO\BinaryStream.cs (line 15)

         public double Version;
         public bool Is32Bit;
         public ulong ImageBase;
▶        private readonly Stream stream;
         private readonly BinaryReader reader;
         private readonly BinaryWriter writer;
         private readonly MethodInfo readClass;

💬 Disposable field stream in type BinaryStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Il2CppDumper\Utils\CustomAttributeDataReader.cs (line 9)

     public class CustomAttributeDataReader : BinaryReader
     {
         private readonly Il2CppExecutor executor;
▶        private readonly Metadata metadata;
         private long ctorBuffer;
         private long dataBuffer;
 

💬 Disposable field metadata in type CustomAttributeDataReader is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

SwarmUI

378 total diagnostics across 21 rules

SS001 Async method with void return type 2 hits

📄 src\Backends\NetworkBackendUtils.cs (line 572)

             }
         }
         new Thread(MonitorLoop) { Name = $"SelfStart{nameSimple.Replace(' ', '_')}_Monitor" }.Start();
▶        async void MonitorErrLoop()
         {
             try
             {

💬 Method MonitorErrLoop is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Backends\NetworkBackendUtils.cs (line 572)

             }
         }
         new Thread(MonitorLoop) { Name = $"SelfStart{nameSimple.Replace(' ', '_')}_Monitor" }.Start();
▶        async void MonitorErrLoop()
         {
             try
             {

💬 Method MonitorErrLoop is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\WebAPI\AdminAPI.cs (line 341)

         FormUrlEncodedContent content = new(new Dictionary<string, string>()
         {
             ["pastetype"] = "swarm",
▶            ["pastetitle"] = $"SwarmUI v{Utilities.Version} Server Log - {DateTime.Now:yyyy-MM-dd HH:mm:ss}",
             ["response"] = "micro",
             ["v"] = "300",
             ["pastecontents"] = logText

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\WebAPI\AdminAPI.cs (line 341)

         FormUrlEncodedContent content = new(new Dictionary<string, string>()
         {
             ["pastetype"] = "swarm",
▶            ["pastetitle"] = $"SwarmUI v{Utilities.Version} Server Log - {DateTime.Now:yyyy-MM-dd HH:mm:ss}",
             ["response"] = "micro",
             ["v"] = "300",
             ["pastecontents"] = logText

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 50 hits

📄 src\Accounts\User.cs (line 507)

     {
         string id = Utilities.SecureRandomHex(32);
         string validationText = Utilities.SecureRandomHex(32);
▶        byte[] salt = RandomNumberGenerator.GetBytes(128 / 8);
         byte[] hashedText = KeyDerivation.Pbkdf2(password: validationText, salt: salt, prf: KeyDerivationPrf.HMACSHA256, iterationCount: 10, numBytesRequested: 256 / 8);
         string validationHashed = Utilities.BytesToHex(salt) + ":" + Utilities.BytesToHex(hashedText);
         long nowUnix = DateTimeOffset.Now.ToUnixTimeSeconds();

💬 The operands in the divisive expression 128 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Accounts\User.cs (line 508)

         string id = Utilities.SecureRandomHex(32);
         string validationText = Utilities.SecureRandomHex(32);
         byte[] salt = RandomNumberGenerator.GetBytes(128 / 8);
▶        byte[] hashedText = KeyDerivation.Pbkdf2(password: validationText, salt: salt, prf: KeyDerivationPrf.HMACSHA256, iterationCount: 10, numBytesRequested: 256 / 8);
         string validationHashed = Utilities.BytesToHex(salt) + ":" + Utilities.BytesToHex(hashedText);
         long nowUnix = DateTimeOffset.Now.ToUnixTimeSeconds();
         SessionHandler.LoginSession session = new()

💬 The operands in the divisive expression 256 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIWebAPI.cs (line 224)

                 }
                 else
                 {
▶                    backendsToStart = [.. backendsToStart.Concat(backendsStopped).Distinct()];
                 }
             }
             if (doFullRestart)

💬 Type ComfyUISelfStartBackend is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIWebAPI.cs (line 224)

                 }
                 else
                 {
▶                    backendsToStart = [.. backendsToStart.Concat(backendsStopped).Distinct()];
                 }
             }
             if (doFullRestart)

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 src\Accounts\Session.cs (line 281)

     /// <summary>Gets a hash code for this session, for C# equality comparsion.</summary>
     public override int GetHashCode()
     {
▶        return ID.GetHashCode();
     }
 
     /// <summary>Returns true if this session is the same as another.</summary>

💬 GetHashCode() refers to mutable field ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Accounts\Session.cs (line 281)

     /// <summary>Gets a hash code for this session, for C# equality comparsion.</summary>
     public override int GetHashCode()
     {
▶        return ID.GetHashCode();
     }
 
     /// <summary>Returns true if this session is the same as another.</summary>

💬 GetHashCode() refers to mutable field ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\Utils\MemoryNum.cs (line 4)

 namespace SwarmUI.Utils;
 
 /// <summary>Mini-struct to hold data about a memory (bytes) size number.</summary>
▶public struct MemoryNum(long inBytes)
 {
     public long InBytes = inBytes;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemoryNum. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Utils\MemoryNum.cs (line 4)

 namespace SwarmUI.Utils;
 
 /// <summary>Mini-struct to hold data about a memory (bytes) size number.</summary>
▶public struct MemoryNum(long inBytes)
 {
     public long InBytes = inBytes;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemoryNum. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 src\Text2Image\T2IParamTypes.cs (line 971)

         {
             throw new SwarmUserErrorException("Unknown parameter type");
         }
▶        switch (type.Type)
         {
             case T2IParamDataType.INTEGER:
                 if (!long.TryParse(val, out long valInt))

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Text2Image\T2IParamTypes.cs (line 971)

         {
             throw new SwarmUserErrorException("Unknown parameter type");
         }
▶        switch (type.Type)
         {
             case T2IParamDataType.INTEGER:
                 if (!long.TryParse(val, out long valInt))

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 12 hits

📄 src\Text2Image\T2IModel.cs (line 396)

 
     public static JToken ReadRawGGUFObject(Stream file, string modelPath, int keyId, GGUFMetadataValueType type, byte[] buf)
     {
▶        switch (type)
         {
             case GGUFMetadataValueType.UINT8: return file.ReadByte();
             case GGUFMetadataValueType.INT8: return (sbyte)file.ReadByte();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Core\Program.cs (line 364)

             Thread.Sleep(500);
             try
             {
▶                switch (LaunchMode.Trim().ToLowerFast())
                 {
                     case "web":
                         Logs.Init("Launch web browser...");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS032 Thread.Sleep used in async method 2 hits

📄 src\Backends\BackendHandler.cs (line 831)

                         Logs.Info($"Backend {backend.ID} ({backend.AbstractBackend.HandlerTypeData.Name}) has been locked in use for at least 5 seconds after shutdown, giving up and killing anyway.");
                         break;
                     }
▶                    Thread.Sleep(100);
                 }
                 tasks.Add((backend, backend.AbstractBackend.DoShutdownNow()));
             })));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\Backends\BackendHandler.cs (line 831)

                         Logs.Info($"Backend {backend.ID} ({backend.AbstractBackend.HandlerTypeData.Name}) has been locked in use for at least 5 seconds after shutdown, giving up and killing anyway.");
                         break;
                     }
▶                    Thread.Sleep(100);
                 }
                 tasks.Add((backend, backend.AbstractBackend.DoShutdownNow()));
             })));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 38 hits

📄 src\BuiltinExtensions\AutoWebUIBackend\AutoWebUISelfStartBackend.cs (line 45)

                 Status = BackendStatus.ERRORED;
                 return;
             }
▶            string scrContent = File.ReadAllText(settings.StartScript);
             if (!scrContent.Contains("%*") && !scrContent.Contains("%~")) // on Windows, it's only valid if you forward swarm's CLI args
             {
                 Logs.Error($"Refusing init of AutoWebUI with 'webui-user.bat' target script. Please use the 'webui.bat' script instead. (If webui-user.bat usage is intentional, please forward CLI args, eg 'COMMANDLINE_ARGS=%*'.");

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\BuiltinExtensions\ImageBatchTool\ImageBatchToolExtension.cs (line 130)

             {
                 break;
             }
▶            Image image = new(File.ReadAllBytes(file), MediaType.GetByExtension(file.AfterLast('.')));
             ISImage imgData = image.ToIS;
             T2IParamInput param = baseParams.Clone();
             void setRes(int width, int height)

💬 Async overload available for File.ReadAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 28 hits

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIRedirectHelper.cs (line 45)

         try
         {
             using CancellationTokenSource cancel = Utilities.TimedCancel(TimeSpan.FromMinutes(1));
▶            result = backend.Client.GetAsync($"{backend.APIAddress}/object_info", cancel.Token).Result.Content.ReadAsStringAsync().Result.ParseToJson();
         }
         catch (Exception ex)
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIRedirectHelper.cs (line 45)

         try
         {
             using CancellationTokenSource cancel = Utilities.TimedCancel(TimeSpan.FromMinutes(1));
▶            result = backend.Client.GetAsync($"{backend.APIAddress}/object_info", cancel.Token).Result.Content.ReadAsStringAsync().Result.ParseToJson();
         }
         catch (Exception ex)
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 4 hits

📄 src\BuiltinExtensions\GridGenerator\GridGeneratorExtension.cs (line 273)

             if (requests < Program.ServerSettings.Backends.MaxRequestsForcedOrder)
             {
                 Logs.Debug($"Grid Gen micro-pausing to maintain order as {requests} < {Program.ServerSettings.Backends.MaxRequestsForcedOrder}");
▶                Task.Delay(20).Wait(); // Tiny few-ms delay to encourage tasks retaining order.
             }
             return t;
         };

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 src\WebAPI\T2IAPI.cs (line 413)

                 })));
             if (Program.Backends.QueuedRequests < Program.ServerSettings.Backends.MaxRequestsForcedOrder)
             {
▶                Task.Delay(20).Wait(); // Tiny few-ms delay to encourage tasks retaining order.
             }
         }
         while (tasks.Any())

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS037 HttpClient instantiated directly 2 hits

📄 src\Backends\NetworkBackendUtils.cs (line 24)

     /// <summary>Create and preconfigure a basic <see cref="HttpClient"/> instance to make web requests with.</summary>
     public static HttpClient MakeHttpClient(int timeoutMinutes = 10)
     {
▶        HttpClient client = new(new SocketsHttpHandler() { PooledConnectionLifetime = TimeSpan.FromMinutes(10), MaxConnectionsPerServer = 1000 });
         client.DefaultRequestHeaders.UserAgent.ParseAdd($"SwarmUI/{Utilities.Version}");
         client.Timeout = TimeSpan.FromMinutes(timeoutMinutes);
         return client;

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 src\Backends\NetworkBackendUtils.cs (line 24)

     /// <summary>Create and preconfigure a basic <see cref="HttpClient"/> instance to make web requests with.</summary>
     public static HttpClient MakeHttpClient(int timeoutMinutes = 10)
     {
▶        HttpClient client = new(new SocketsHttpHandler() { PooledConnectionLifetime = TimeSpan.FromMinutes(10), MaxConnectionsPerServer = 1000 });
         client.DefaultRequestHeaders.UserAgent.ParseAdd($"SwarmUI/{Utilities.Version}");
         client.Timeout = TimeSpan.FromMinutes(timeoutMinutes);
         return client;

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS038 HttpContext stored in a field 2 hits

📄 src\Utils\GeneratePageModel.cs (line 9)

 
 public class GeneratePageModel
 {
▶    public HttpContext HttpContext;
 
     public string AlwaysRefreshOnLoad => Program.ServerSettings.Backends.AlwaysRefreshOnLoad ? "true" : "false";

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

📄 src\Utils\GeneratePageModel.cs (line 9)

 
 public class GeneratePageModel
 {
▶    public HttpContext HttpContext;
 
     public string AlwaysRefreshOnLoad => Program.ServerSettings.Backends.AlwaysRefreshOnLoad ? "true" : "false";

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

SS041 Unnecessary enumerable materialization 10 hits

📄 src\WebAPI\APICallReflectBuilder.cs (line 25)

         [typeof(bool)] = input => (bool.TryParse(input.ToString(), out bool output), output),
         [typeof(byte)] = input => (byte.TryParse(input.ToString(), out byte output), output),
         [typeof(char)] = input => (char.TryParse(input.ToString(), out char output), output),
▶        [typeof(string[])] = input => (true, input.ToList().Select(j => j.ToString()).ToArray())
     };
 
     public static APICall BuildFor(object obj, MethodInfo method, bool isUserUpdate, PermInfo permission)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Core\ExtensionsManager.cs (line 78)

                 Logs.CriticalLoadError($"Failed to delete extension folder SwarmUI/{deletable}: {ex.ReadableString()}, you will need to remove it manually");
             }
         }
▶        foreach (Type extType in AppDomain.CurrentDomain.GetAssemblies().ToList().SelectMany(x => x.GetTypes()).Where(t => typeof(Extension).IsAssignableFrom(t) && !t.IsAbstract))
         {
             bool isCore = extType.Namespace.StartsWith("SwarmUI.");
             string[] possible = isCore ? builtins : extras;

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 src\Media\ImageFile.cs (line 67)

         {
             if (_CacheISImg is null)
             {
▶                lock (this)
                 {
                     _CacheISImg ??= ISImage.Load(RawData);
                 }

📄 src\Core\WebServer.cs (line 61)

         {
             if (Value is null)
             {
▶                lock (this)
                 {
                     Value ??= Getter();
                 }

SS051 Locking on mutable reference 150 hits

📄 src\BuiltinExtensions\AutoWebUIBackend\AutoWebUIBackendExtension.cs (line 27)

 
     public static void LoadSamplerList(List<string> newSamplers)
     {
▶        lock (ExtBackLock)
         {
             Samplers = [.. Samplers.Union(newSamplers).Distinct()];
         }

💬 A lock was obtained on ExtBackLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\Accounts\Permissions.cs (line 21)

         {
             throw new InvalidOperationException($"Permission key '{perm.ID}' is already registered.");
         }
▶        lock (OrderedKeys)
         {
             OrderedKeys.Add(perm.ID);
         }

💬 A lock was obtained on OrderedKeys but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS057 Collection manipulated during traversal 4 hits

📄 src\BuiltinExtensions\ImageBatchTool\ImageBatchToolExtension.cs (line 110)

                     {
                         Logs.Error($"Image generation failed: {tasks[i].Exception}");
                     }
▶                    tasks.RemoveAt(i--);
                 }
             }
         }

📄 src\WebAPI\T2IAPI.cs (line 309)

                     {
                         Logs.Error($"Image generation failed: {tasks[i].Exception}");
                     }
▶                    tasks.RemoveAt(i--);
                 }
             }
         }

SS058 String concatenated in a loop 44 hits

📄 src\BuiltinExtensions\AutoWebUIBackend\AutoWebUIAPIAbstractBackend.cs (line 86)

                 {
                     lora = lora.BeforeLast('.');
                 }
▶                promptAdd += $"<lora:{lora}:{loraWeights[i]}>";
             }
         }
         JObject toSend = new()

📄 src\Utils\WebUtil.cs (line 78)

         string basic = "";
         foreach (NvidiaUtil.NvidiaInfo info in nv)
         {
▶            basic += $"{(info == bestGpu ? "* " : "")}GPU {info.ID}: <b>{info.GPUName}</b>, <b>{info.TotalMemory}</b> VRAM\n<br>";
         }
         if (nv.Length > 1)
         {

SS059 IAsyncDisposable not disposed asynchronously 10 hits

📄 src\Utils\Utilities.cs (line 308)

     public static async Task<byte[]> ReceiveData(this WebSocket socket, long maxBytes, CancellationToken limit)
     {
         byte[] buffer = new byte[8192];
▶        using MemoryStream ms = new();
         WebSocketReceiveResult result;
         do
         {

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIRedirectHelper.cs (line 332)

             {
                 try
                 {
▶                    using MemoryStream memStream = new();
                     await context.Request.Body.CopyToAsync(memStream);
                     byte[] data = memStream.ToArray();
                     JObject parsed = StringConversionHelper.UTF8Encoding.GetString(data).ParseToJson();

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 6 hits

📄 src\WebAPI\T2IAPI.cs (line 128)

         });
         Task handle = API.RunWebsocketHandlerCallWS(GenT2I_Internal, session, (images, rawInput, data, 0), socket);
         tasks.TryAdd(handle, handle);
▶        while (Volatile.Read(ref retain) || tasks.Any())
         {
             await Task.WhenAny(tasks.Keys.ToList());
             foreach (Task t in tasks.Keys.Where(t => t.IsCompleted).ToList())

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 src\Utils\Utilities.cs (line 99)

                 return;
             }
         }
▶        if (Program.Backends.T2IBackendRequests.Any() || Program.Backends.QueuedRequests > 0 || Program.Backends.AllBackends.Values.Any(b => b.CheckIsInUseAtAll))
         {
             return;
         }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

cecil

376 total diagnostics across 7 rules

SS003 Integer divided by integer causing implicit rounding 48 hits

📄 Mono\MergeSort.cs (line 49)

 			if (end - start < 2)
 				return;
 
▶			int middle = (end + start) / 2;
 			TopDownSplitMerge (b, a, start, middle);
 			TopDownSplitMerge (b, a, middle, end);
 			TopDownMerge (a, b, start, middle, end);

📄 Mono.Cecil\AssemblyNameReference.cs (line 203)

 					if (pk_token == "null")
 						break;
 
▶					name.PublicKeyToken = new byte [pk_token.Length / 2];
 					for (int j = 0; j < name.PublicKeyToken.Length; j++)
 						name.PublicKeyToken [j] = Byte.Parse (pk_token.Substring (j * 2, 2), NumberStyles.HexNumber);
 

💬 The operands in the divisive expression pk_token.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 44 hits

📄 Mono.Cecil.Metadata\Buffers.cs (line 447)

 		public uint GetBlobIndex (ByteBuffer blob)
 		{
 			uint index;
▶			if (blobs.TryGetValue (blob, out index))
 				return index;
 
 			index = (uint) base.position;

💬 Type ByteBuffer is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Mono.Cecil.Metadata\Buffers.cs (line 452)

 
 			index = (uint) base.position;
 			WriteBlob (blob);
▶			blobs.Add (blob, index);
 			return index;
 		}
 

SS017 Struct without Equals/GetHashCode/ToString overridden 80 hits

📄 Mono\Disposable.cs (line 28)

 		}
 	}
 
▶	struct Disposable<T> : IDisposable where T : class, IDisposable {
 
 		internal readonly T value;
 		readonly bool owned;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Disposable. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Mono.Collections.Generic\Collection.cs (line 350)

 			return new Enumerator (this);
 		}
 
▶		public struct Enumerator : IEnumerator<T>, IDisposable {
 
 			Collection<T> collection;
 			T current;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Enumerator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 64 hits

📄 Mono.Cecil\TypeReference.cs (line 324)

 
 		public static bool IsTypeSpecification (this TypeReference type)
 		{
▶			switch (type.etype) {
 			case ElementType.Array:
 			case ElementType.ByRef:
 			case ElementType.CModOpt:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Mono.Cecil\AssemblyWriter.cs (line 1273)

 				return exported_type.DeclaringType.MetadataToken;
 
 			var scope = exported_type.Scope;
▶			switch (scope.MetadataToken.TokenType) {
 			case TokenType.AssemblyRef:
 				return scope.MetadataToken;
 			case TokenType.ModuleRef:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 104 hits

📄 Mono.Security.Cryptography\CryptoConvert.cs (line 238)

 			if (offset >= blob.Length)
 				throw new ArgumentException ("blob is too small.");
 
▶			switch (blob [offset]) {
 				case 0x00:
 					// this could be a public key inside an header
 					// like "sn -e" would produce

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Mono.Cecil\AssemblyNameReference.cs (line 191)

 				if (parts.Length != 2)
 					throw new ArgumentException ("Malformed name");
 
▶				switch (parts [0].ToLowerInvariant ()) {
 				case "version":
 					name.Version = new Version (parts [1]);
 					break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 Mono.Collections.Generic\Collection.cs (line 367)

 					CheckState ();
 
 					if (next <= 0)
▶						throw new InvalidOperationException ();
 
 					return current;
 				}

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Mono.Collections.Generic\Collection.cs (line 367)

 					CheckState ();
 
 					if (next <= 0)
▶						throw new InvalidOperationException ();
 
 					return current;
 				}

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS066 Disposable field is not disposed 32 hits

📄 Mono.Cecil\ModuleDefinition.cs (line 261)

 		internal ushort subsystem_minor = 0;
 		internal uint timestamp;
 
▶		internal AssemblyDefinition assembly;
 		MethodDefinition entry_point;
 		bool entry_point_set;
 

💬 Disposable field assembly in type ModuleDefinition is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Mono.Cecil.Cil\PortablePdb.cs (line 521)

 
 	public sealed class EmbeddedPortablePdbWriter : ISymbolWriter {
 
▶		readonly Stream stream;
 		readonly PortablePdbWriter writer;
 
 		internal EmbeddedPortablePdbWriter (Stream stream, PortablePdbWriter writer)

💬 Disposable field stream in type EmbeddedPortablePdbWriter is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

RestSharp

340 total diagnostics across 9 rules

SS001 Async method with void return type 12 hits

No source samples extracted

SS002 Use DateTime.UtcNow instead of DateTime.Now 88 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 12 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 20 hits

No source samples extracted

SS019 Switch is missing default label 12 hits

No source samples extracted

SS033 Async overload is available 42 hits

No source samples extracted

SS037 HttpClient instantiated directly 48 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 24 hits

No source samples extracted

SS066 Disposable field is not disposed 82 hits

No source samples extracted

Vue.NetCore

334 total diagnostics across 17 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 140 hits

📄 vol.api.sqlsugar\VOL.Core\Services\Logger.cs (line 29)

     public static class Logger
     {
         public static ConcurrentQueue<Sys_Log> loggerQueueData = new ConcurrentQueue<Sys_Log>();
▶        private static DateTime lastClearFileDT = DateTime.Now.AddDays(-1);
         private static string _loggerPath = AppSetting.DownLoadPath + "Logger\\Queue\\";
         static Logger()
         {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 vol.api.sqlsugar\VOL.Core\Extensions\StringExtension.cs (line 52)

             if (string.IsNullOrEmpty(urlPath))
                 return null;
             userId = userId ?? UserContext.Current.UserInfo.User_Id;
▶            return $"{urlPath}{(urlPath.IndexOf("?token") > 0 ? "&" : "?")}uid={userId}&rt_v={DateTime.Now.ToString("HHmmss")}";
             //  return urlPath + ((urlPath.IndexOf("?token") > 0 ? "&" : "?") + "uid=" + userId);
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 8 hits

📄 vol.api.sqlsugar\VOL.Core\Extensions\StringExtension.cs (line 34)

         /// <returns></returns>
         public static long GetTimeStamp(this DateTime dateTime)
         {
▶            return (dateTime.ToUniversalTime().Ticks - longTime) / samllTime;
         }
         /// <summary>
         /// 时间戳转换成日期

💬 The operands in the divisive expression (dateTime.ToUniversalTime().Ticks - longTime) / samllTime are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 vol.api.sqlsugar\VOL.Core\Filters\ApiAuthorizeFilter.cs (line 75)

             DateTime expDate = context.HttpContext.User.Claims.Where(x => x.Type == JwtRegisteredClaimNames.Exp)
                 .Select(x => x.Value).FirstOrDefault().GetTimeSpmpToDate();
             //动态标识刷新token(2021.05.01)
▶            if ((expDate - DateTime.Now).TotalMinutes < AppSetting.ExpMinutes/ 3 && context.HttpContext.Request.Path != replaceTokenPath)
             {
                 context.HttpContext.Response.Headers["vol_exp"]= "1";
             }

💬 The operands in the divisive expression AppSetting.ExpMinutes/ 3 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 vol.api.sqlsugar\VOL.Core\UserManager\RoleContext.cs (line 88)

         /// <param name="roleId"></param>
         private static List<RoleNodes> GetChildren(List<RoleNodes> roles, int roleId)
         {
▶            List<RoleNodes> rolesChildren = roles.Where(x => x.Id == roleId).Distinct().ToList();
 
             for (int i = 0; i < rolesChildren.Count; i++)
             {

💬 Type RoleNodes is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 vol.api.sqlsugar\VOL.Core\UserManager\RoleContext.cs (line 93)

             for (int i = 0; i < rolesChildren.Count; i++)
             {
                 RoleNodes node = rolesChildren[i];
▶                var children = roles.Where(x => x.ParentId == node.Id && !rolesChildren.Any(c => c.Id == x.Id)).Distinct().ToList();
                 rolesChildren.AddRange(children);
             }
             return rolesChildren;

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 vol.api.sqlsugar\VOL.Core\Const\HtmlElementType.cs (line 7)

 
 namespace VOL.Core.Const
 {
▶    public struct HtmlElementType
     {
         public const string drop = "drop";
         public const string droplist = "droplist";

💬 Implement Equals(), GetHashCode() and ToString() methods on struct HtmlElementType. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 vol.api.sqlsugar\VOL.Core\Const\SqlDbTypeName.cs (line 7)

 
 namespace VOL.Core.Const
 {
▶    public struct SqlDbTypeName
     {
         public const string NVarChar = "nvarchar";
         public const string VarChar = "varchar";

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SqlDbTypeName. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzNETExtension.cs (line 263)

                     return new { status = false, msg = errorMsg };
                 }
                 object result = null;
▶                switch (action)
                 {
                     case JobAction.删除:
 

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzNETExtension.cs (line 263)

                     return new { status = false, msg = errorMsg };
                 }
                 object result = null;
▶                switch (action)
                 {
                     case JobAction.删除:
 

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 6 hits

📄 vol.api.sqlsugar\VOL.Core\Extensions\StringExtension.cs (line 389)

 
         public static object ParseTo(this string str, string type)
         {
▶            switch (type)
             {
                 case "System.Boolean":
                     return ToBoolean(str);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzNETExtension.cs (line 263)

                     return new { status = false, msg = errorMsg };
                 }
                 object result = null;
▶                switch (action)
                 {
                     case JobAction.删除:
 

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 vol.api.sqlsugar\VOL.Builder\Services\Core\Partial\Sys_TableInfoService.cs (line 54)

                 webProject = ProjectPath.GetLastIndexOfDirectoryName(".WebApi") ?? ProjectPath.GetLastIndexOfDirectoryName("Api") ?? ProjectPath.GetLastIndexOfDirectoryName(".Web");
                 if (webProject == null)
                 {
▶                    throw new Exception("未获取到以.WebApi结尾的项目名称,无法创建页面");
                 }
                 return webProject;
             }

💬 An exception is thrown from the getter of property WebProject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 vol.api.sqlsugar\VOL.Builder\Services\Core\Partial\Sys_TableInfoService.cs (line 68)

                 apiNameSpace = ProjectPath.GetLastIndexOfDirectoryName(".WebApi");
                 if (apiNameSpace == null)
                 {
▶                    throw new Exception("未获取到以.WebApi,无法创建Api控制器");
                 }
                 return apiNameSpace;
             }

💬 An exception is thrown from the getter of property ApiNameSpace (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 8 hits

📄 vol.api.sqlsugar\VOL.Core\Quartz\HttpResultfulJob.cs (line 66)

                     _taskOptions.LastRunTime = DateTime.Now;
                     DbManger.SqlSugarClient.Update(_taskOptions, new string[] { "LastRunTime" });
 
▶                    DbManger.SqlSugarClient.SaveChanges();
                 }
 
                 Dictionary<string, string> header = new Dictionary<string, string>();

💬 Async overload available for SqlSugarExtension.SaveChanges (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 vol.api.sqlsugar\VOL.Core\Quartz\HttpResultfulJob.cs (line 105)

                         EndDate = DateTime.Now
                     };
                     DbManger.SqlSugarClient.Add(log);
▶                    DbManger.SqlSugarClient.SaveChanges();
                 }
                 catch (Exception ex)
                 {

💬 Async overload available for SqlSugarExtension.SaveChanges (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzNETExtension.cs (line 63)

             {
                 return false;
             }
▶            JobKey jobKey = jobKeys.Where(s => scheduler.GetTriggersOfJob(s).Result
                             .Any(x => (x as CronTriggerImpl).Name == taskName))
                             .FirstOrDefault();
             if (jobKey == null)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzNETExtension.cs (line 240)

                 string groupName = "group";
                 string taskName = taskOptions.Id.ToString();
                 IScheduler scheduler = await schedulerFactory.GetScheduler();
▶                List<JobKey> jobKeys = scheduler.GetJobKeys(GroupMatcher<JobKey>.GroupEquals(groupName)).Result.ToList();
                 if (jobKeys == null || jobKeys.Count() == 0)
                 {
                     errorMsg = $"未找到分组[{groupName}]";

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS038 HttpContext stored in a field 2 hits

📄 vol.api.sqlsugar\VOL.Sys\Services\System\Partial\Sys_UserService.cs (line 25)

 {
     public partial class Sys_UserService
     {
▶        private Microsoft.AspNetCore.Http.HttpContext _context;
         private ISys_UserRepository _repository;
         [ActivatorUtilitiesConstructor]
         public Sys_UserService(IHttpContextAccessor httpContextAccessor, ISys_UserRepository repository)

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

📄 vol.api.sqlsugar\VOL.Sys\Services\System\Partial\Sys_UserService.cs (line 25)

 {
     public partial class Sys_UserService
     {
▶        private Microsoft.AspNetCore.Http.HttpContext _context;
         private ISys_UserRepository _repository;
         [ActivatorUtilitiesConstructor]
         public Sys_UserService(IHttpContextAccessor httpContextAccessor, ISys_UserRepository repository)

💬 HttpContext was stored in a field. Use IHttpContextAccessor instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS038-HttpContextStoredInField.md)

SS040 Unused result on immutable object 6 hits

📄 vol.api.sqlsugar\VOL.Core\Extensions\ConvertJsonExtension.cs (line 186)

             {
                 jsonString += ToJson(item) + ",";
             }
▶            jsonString.Remove(jsonString.Length - 1, jsonString.Length);
             return jsonString + "]";
         }
         #endregion

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 vol.api.sqlsugar\VOL.Core\Extensions\ConvertJsonExtension.cs (line 204)

             {
                 jsonString = ToJson(item.ToString()) + ",";
             }
▶            jsonString.Remove(jsonString.Length - 1, jsonString.Length);
             return jsonString + "]";
         }
         #endregion

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS044 Attribute must specify [AttributeUsage] 16 hits

📄 vol.api.sqlsugar\VOL.Entity\AttributeManager\PermissionTableAttribute.cs (line 5)

 
 namespace VOL.Entity.AttributeManager
 {
▶    public class PermissionTableAttribute : Attribute
     {
         /// <summary>
         /// 需要控制权限的表名与Sys_Menu表的表名必须一致

💬 PermissionTableAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 vol.api.sqlsugar\VOL.Entity\AttributeManager\EntityAttribute.cs (line 9)

 
 namespace VOL.Entity
 {
▶    public class EntityAttribute : Attribute
     {
         /// <summary>
         /// 真实表名(数据库表名，若没有填写默认实体为表名)

💬 EntityAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 82 hits

📄 vol.api.sqlsugar\VOL.Core\BaseProvider\ServiceBase.cs (line 142)

                     Dictionary<string, QueryOrderBy> sortDic = new Dictionary<string, QueryOrderBy>();
                     foreach (var name in sortArr)
                     {
▶                        sortDic[name] = pageData.Order?.ToLower() == _asc ? QueryOrderBy.Asc : QueryOrderBy.Desc;
                     }
                     return sortDic;
                 }

📄 vol.api.sqlsugar\VOL.Core\BaseProvider\ServiceBase.cs (line 150)

                 {
                     return new Dictionary<string, QueryOrderBy>() { {
                             pageData.Sort,
▶                            pageData.Order?.ToLower() == _asc? QueryOrderBy.Asc: QueryOrderBy.Desc
                      } };
                 }
             }

SS051 Locking on mutable reference 10 hits

📄 vol.api.sqlsugar\VOL.Core\Infrastructure\DictionaryManager.cs (line 85)

                 return _dictionaries;
             }
 
▶            lock (_dicObj)
             {
                 if (_dicVersionn != "" && _dictionaries != null && _dicVersionn == cacheService.Get(Key)) return _dictionaries;
                 _dictionaries = DBServerProvider.DbContext

💬 A lock was obtained on _dicObj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 vol.api.sqlsugar\VOL.Core\UserManager\RoleContext.cs (line 30)

             {
                 return _roles;
             }
▶            lock (_RoleObj)
             {
                 if (_RoleVersionn != "" && _roles != null && _RoleVersionn == cacheService.Get(Key)) return _roles;
                 _roles = DBServerProvider.DbContext

💬 A lock was obtained on _RoleObj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS056 HttpRequest.Form read synchronously 2 hits

📄 vol.api.sqlsugar\VOL.Core\Extensions\RequestExtension.cs (line 54)

                 if (context == null)
                     return null;
                 if (context.Request.Method == "POST")
▶                    return context.Request.Form[parameter].ToString();
                 else
                     return context.Request.Query[parameter].ToString();
             }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 vol.api.sqlsugar\VOL.Core\Extensions\RequestExtension.cs (line 54)

                 if (context == null)
                     return null;
                 if (context.Request.Method == "POST")
▶                    return context.Request.Form[parameter].ToString();
                 else
                     return context.Request.Query[parameter].ToString();
             }

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS058 String concatenated in a loop 10 hits

📄 vol.api.sqlsugar\VOL.Core\Utilities\VierificationCode.cs (line 30)

                     return RandomText();
                 }
                 temp = t;
▶                code += _chars[t];
             }
             return code;
         }

📄 vol.api.sqlsugar\VOL.Core\Quartz\QuartzAuthorization.cs (line 47)

                 for (int i = 0; i < s.Length; i++)
                 {
                     string btos = s[i].ToString("X2");
▶                    md5str += btos;
                 }
                 return md5str;
             }

SS066 Disposable field is not disposed 6 hits

📄 vol.api.sqlsugar\VOL.WebApi\Controllers\Sys\Partial\Sys_UserController.cs (line 38)

     public partial class Sys_UserController
     {
         private ISys_UserRepository _userRepository;
▶        private ICacheService _cache;
         [ActivatorUtilitiesConstructor]
         public Sys_UserController(
                ISys_UserService userService,

💬 Disposable field _cache in type Sys_UserController is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 vol.api.sqlsugar\VOL.WebApi\Controllers\Hubs\HomePageMessageHub.cs (line 22)

     /// </summary>
     public class HomePageMessageHub : Hub
     {
▶        private readonly ICacheService _cacheService;
 
 
         private static ConcurrentDictionary<string, string> _connectionIds = new ConcurrentDictionary<string, string>();

💬 Disposable field _cacheService in type HomePageMessageHub is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

MemoryPack

328 total diagnostics across 12 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 sandbox\Benchmark\Models\BinaryPackModels\NeuralNetworkLayerModel.cs (line 66)

                 Biases[i] = (float)RandomProvider.NextDouble();
             }
             Activation = ActivationType.Sigmoid;
▶            LastUpdateTime = DateTime.Now;
         }
 
         /// <inheritdoc/>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 sandbox\Benchmark\Micro\Hyper.cs (line 26)

             // Gn
             A = i,
             B = i,
▶            C = DateTime.Now.Date,
             D = (uint)i,
             E = i,
             F = DateTime.Now - DateTime.Now.AddDays(-1),

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 18 hits

📄 src\MemoryPack.Core\Compression\BitPackFormatter.cs (line 118)

             return;
         }
 
▶        var readCount = ((length - 1) / 32) + 1;
         var requireSize = readCount * 4;
         if (reader.Remaining < requireSize)
         {

💬 The operands in the divisive expression (length - 1) / 32 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\MemoryPack.Core\Compression\BitPackFormatter.cs (line 118)

             return;
         }
 
▶        var readCount = ((length - 1) / 32) + 1;
         var requireSize = readCount * 4;
         if (reader.Remaining < requireSize)
         {

SS005 Equals() and GetHashCode() not implemented together 2 hits

📄 tests\MemoryPack.Tests\ArrayFormatterTest.cs (line 201)

 }
 
 [MemoryPackable]
▶public partial class ObjectValue : IEquatable<ObjectValue>
 {
     public int Value { get; }
 

💬 Equals() and GetHashcode() must be implemented together on ObjectValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 tests\MemoryPack.Tests\ArrayFormatterTest.cs (line 201)

 }
 
 [MemoryPackable]
▶public partial class ObjectValue : IEquatable<ObjectValue>
 {
     public int Value { get; }
 

💬 Equals() and GetHashcode() must be implemented together on ObjectValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 sandbox\SandboxConsoleApp\Program.cs (line 91)

     }
     public override int GetHashCode()
     {
▶        return System.HashCode.Combine(x, y, z);
     }
 }
 [MemoryPackable]

💬 GetHashCode() refers to mutable field x (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 sandbox\SandboxConsoleApp\Program.cs (line 91)

     }
     public override int GetHashCode()
     {
▶        return System.HashCode.Combine(x, y, z);
     }
 }
 [MemoryPackable]

💬 GetHashCode() refers to mutable field y (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 242 hits

📄 src\MemoryPack.Generator\EquatableArray.cs (line 6)

 
 namespace MemoryPack.Generator;
 
▶public readonly struct EquatableArray<T> : IEquatable<EquatableArray<T>>, IEnumerable<T>
     where T : IEquatable<T>
 {
     readonly T[]? array;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EquatableArray. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\MemoryPack.Core\Compression\BrotliDecompressor.cs (line 8)

 
 namespace MemoryPack.Compression;
 
▶public struct BrotliDecompressor : IDisposable
 {
     ReusableReadOnlySequenceBuilder? sequenceBuilder;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BrotliDecompressor. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 4 hits

📄 src\MemoryPack.Generator\MemoryPackGenerator.Emitter.cs (line 305)

             Members = originalMembers;
         }
 
▶        var classOrStructOrRecord = (IsRecord, IsValueType) switch
         {
             (true, true) => "record struct",
             (true, false) => "record",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\MemoryPack.Generator\MemoryPackGenerator.Emitter.cs (line 317)

         var containingType = Symbol.ContainingType;
         while (containingType is not null)
         {
▶            containingTypeDeclarations.Add((containingType.IsRecord, containingType.IsValueType) switch
             {
                 (true, true) => $"partial record struct {containingType.Name}",
                 (true, false) => $"partial record {containingType.Name}",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS030 Exception thrown from Equals 4 hits

📄 sandbox\Benchmark\Models\BinaryPackModels\JsonResponseModel.cs (line 400)

         public bool Equals(ImageModel? other)
         {
             if (other is null) return false;
▶            if (ReferenceEquals(this, other)) throw new InvalidOperationException();
             return
                 Url?.Equals(other.Url) == true &&
                 Width == other.Width &&

💬 An exception is thrown from the Equals(ImageModel?) method in type ImageModel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

📄 sandbox\Benchmark\Models\BinaryPackModels\JsonResponseModel.cs (line 131)

         public bool Equals(ApiModelContainer? other)
         {
             if (other is null) return false;
▶            if (ReferenceEquals(this, other)) throw new InvalidOperationException();
             return
                 Id?.Equals(other.Id) == true &&
                 Type?.Equals(other.Type) == true &&

💬 An exception is thrown from the Equals(ApiModelContainer?) method in type ApiModelContainer (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

SS033 Async overload is available 2 hits

📄 sandbox\SandboxWebApp\Program.cs (line 33)

 
 app.MapControllers();
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 sandbox\SandboxWebApp\Program.cs (line 33)

 
 app.MapControllers();
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 6 hits

📄 src\MemoryPack.Core\Internal\PreserveAttribute.cs (line 5)

 
 // Preserve for Unity IL2CPP(internal but used for code generator)
 
▶public sealed class PreserveAttribute : System.Attribute
 {
 }

💬 PreserveAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\MemoryPack.Core\Internal\PreserveAttribute.cs (line 5)

 
 // Preserve for Unity IL2CPP(internal but used for code generator)
 
▶public sealed class PreserveAttribute : System.Attribute
 {
 }

💬 PreserveAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS047 LINQ traversal before filter 2 hits

📄 src\MemoryPack.Generator\MemoryPackGenerator.Parser.cs (line 81)

         this.TypeName = symbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
         this.Constructor = ChooseConstructor(symbol, reference);
 
▶        this.Members = symbol.GetAllMembers() // iterate includes parent type
             .Where(x => x is (IFieldSymbol or IPropertySymbol) and { IsStatic: false, IsImplicitlyDeclared: false, CanBeReferencedByName: true })
             .Reverse()
             .DistinctBy(x => x.Name) // remove duplicate name(new)

📄 src\MemoryPack.Generator\MemoryPackGenerator.Parser.cs (line 81)

         this.TypeName = symbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
         this.Constructor = ChooseConstructor(symbol, reference);
 
▶        this.Members = symbol.GetAllMembers() // iterate includes parent type
             .Where(x => x is (IFieldSymbol or IPropertySymbol) and { IsStatic: false, IsImplicitlyDeclared: false, CanBeReferencedByName: true })
             .Reverse()
             .DistinctBy(x => x.Name) // remove duplicate name(new)

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 tests\MemoryPack.Tests\NonGenerics.cs (line 30)

     [Fact]
     public async Task StreamCheck()
     {
▶        using var ms = new MemoryStream();
 
         // Generic version works
         await MemoryPackSerializer.SerializeAsync(ms, new Item());

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 tests\MemoryPack.Tests\NonGenerics.cs (line 30)

     [Fact]
     public async Task StreamCheck()
     {
▶        using var ms = new MemoryStream();
 
         // Generic version works
         await MemoryPackSerializer.SerializeAsync(ms, new Item());

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 24 hits

📄 src\MemoryPack.Core\MemoryPackSerializer.StateBackup.cs (line 26)

         readonly bool _resetReaderState;
         readonly bool _resetWriterState;
         readonly SerializerWriterThreadStaticState? _threadStaticState;
▶        readonly MemoryPackWriterOptionalState? _threadStaticWriterOptionalState;
         readonly MemoryPackReaderOptionalState? _threadStaticReaderOptionalState;
 
         internal StateSnapshot(bool resetReaderState, bool resetWriterState)

💬 Disposable field _threadStaticWriterOptionalState in type StateSnapshot is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\MemoryPack.Core\MemoryPackSerializer.StateBackup.cs (line 27)

         readonly bool _resetWriterState;
         readonly SerializerWriterThreadStaticState? _threadStaticState;
         readonly MemoryPackWriterOptionalState? _threadStaticWriterOptionalState;
▶        readonly MemoryPackReaderOptionalState? _threadStaticReaderOptionalState;
 
         internal StateSnapshot(bool resetReaderState, bool resetWriterState)
         {

💬 Disposable field _threadStaticReaderOptionalState in type StateSnapshot is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

YamlDotNet

326 total diagnostics across 9 rules

SS003 Integer divided by integer causing implicit rounding 20 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 100 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 60 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 60 hits

No source samples extracted

SS018 Switch does not handle all enum options 20 hits

No source samples extracted

SS019 Switch is missing default label 44 hits

No source samples extracted

SS023 Exception thrown from property getter 10 hits

No source samples extracted

SS057 Collection manipulated during traversal 10 hits

No source samples extracted

SS058 String concatenated in a loop 2 hits

No source samples extracted

Windows-Auto-Night-Mode

284 total diagnostics across 14 rules

SS001 Async method with void return type 26 hits

📄 AutoDarkModeSvc\Communication\AsyncPipeServer.cs (line 125)

         });
     }
 
▶    private async void HandleClient()
     {
         Tuple<string, string> result = await HandleRequest();
         // if no string was received, add the worker back to the pool

💬 Method HandleClient is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 AutoDarkModeSvc\Communication\AsyncPipeServer.cs (line 234)

         return new(msg, responderPipeId);
     }
 
▶    private async void HandleResponse(string msg, string responderPipeId)
     {
         // for the response timeout, we don't want to wait forever, so it also adheres to streamTimeout
         using CancellationTokenSource connectTimeoutTokenSource = new();

💬 Method HandleResponse is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 148 hits

📄 AutoDarkModeLib\Configs\LocationData.cs (line 23)

 
 public class LocationData
 {
▶    public DateTime Sunrise { get; set; } = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 7, 0, 0);
     public DateTime Sunset { get; set; } = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 19, 0, 0);
     public double Lat { get; set; }
     public double Lon { get; set; }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 AutoDarkModeLib\Configs\LocationData.cs (line 23)

 
 public class LocationData
 {
▶    public DateTime Sunrise { get; set; } = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 7, 0, 0);
     public DateTime Sunset { get; set; } = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 19, 0, 0);
     public double Lat { get; set; }
     public double Lon { get; set; }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 20 hits

📄 AutoDarkModeSvc\Timers\TimerFrequency.cs (line 25)

     public static int Main { get; set; } = 60000;
     // Short Timer for operations that need to be performed a little bit more often
     // By default this is half of main
▶    public static int Short { get; set; } = Main > 1 ? (Main/2) : 1;
     // IO Timer is 2h
     public const int IO = 7200000;
     //location Timer is 1h

💬 The operands in the divisive expression Main/2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 AutoDarkModeSvc\Handlers\UpdateHandler.cs (line 664)

         {
             if (percent % 10 == 0)
             {
▶                string mbReceived = (receivedBytes / 1000000).ToString();
                 string mbTotal = (totalBytes / 1000000).ToString();
                 nfi.NumberDecimalSeparator = ".";
                 Progress = percent;

💬 The operands in the divisive expression receivedBytes / 1000000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 8 hits

📄 AutoDarkModeLib\ComponentSettings\Base\ScriptSwitchSettings.cs (line 80)

 
     public override int GetHashCode()
     {
▶        return HashCode.Combine(Name, Command, ArgsLight, ArgsDark);
     }
 }

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 AutoDarkModeLib\ComponentSettings\Base\ScriptSwitchSettings.cs (line 80)

 
     public override int GetHashCode()
     {
▶        return HashCode.Combine(Name, Command, ArgsLight, ArgsDark);
     }
 }

💬 GetHashCode() refers to mutable property Command (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

📄 AutoDarkModeSvc\Handlers\DisplayHandler.cs (line 162)

     }
 
     [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)]
▶    private struct DISPLAY_DEVICE
     {
         [MarshalAs(UnmanagedType.U4)]
         public int cb;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DISPLAY_DEVICE. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 AutoDarkModeSvc\Modules\SystemIdleCheckModule.cs (line 73)

 
     [DllImport("User32.dll")]
     private static extern bool GetLastInputInfo(ref LASTINPUTINFO plii);
▶    internal struct LASTINPUTINFO
     {
         public uint cbSize;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LASTINPUTINFO. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 4 hits

📄 AutoDarkModeSvc\SwitchComponents\Base\WallpaperSwitch.cs (line 474)

 
         WallpaperType type = e.Theme == Theme.Dark ? Settings.Component.TypeDark : Settings.Component.TypeLight;
 
▶        switch (type)
         {
             case WallpaperType.Individual:
                 List<string> wallpapersTarget =

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 AutoDarkModeSvc\Handlers\ThemeHandler.cs (line 120)

     public static void EnforceNoMonitorUpdates(AdmConfigBuilder builder, GlobalState state, Theme theme)
     {
         string themePath = "";
▶        switch (theme)
         {
             case Theme.Light:
                 themePath = Helper.PathUnmanagedLightTheme;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 10 hits

📄 AutoDarkModeSvc\SwitchComponents\Base\WallpaperSwitch.cs (line 474)

 
         WallpaperType type = e.Theme == Theme.Dark ? Settings.Component.TypeDark : Settings.Component.TypeLight;
 
▶        switch (type)
         {
             case WallpaperType.Individual:
                 List<string> wallpapersTarget =

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 AutoDarkModeSvc\Handlers\ThemeHandler.cs (line 120)

     public static void EnforceNoMonitorUpdates(AdmConfigBuilder builder, GlobalState state, Theme theme)
     {
         string themePath = "";
▶        switch (theme)
         {
             case Theme.Light:
                 themePath = Helper.PathUnmanagedLightTheme;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 6 hits

📄 AutoDarkModeSvc\Communication\AsyncPipeServer.cs (line 180)

                 using StreamReader sr = new(requestPipe);
 
                 // read two lines, the message and the output pipe address
▶                if (requestPipe.IsConnected) msg = sr.ReadLine();
                 if (requestPipe.IsConnected) responderPipeId = sr.ReadLine() ?? "";
                 if (msg == null)
                 {

💬 Async overload available for StreamReader.ReadLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 AutoDarkModeSvc\Communication\AsyncPipeServer.cs (line 181)

 
                 // read two lines, the message and the output pipe address
                 if (requestPipe.IsConnected) msg = sr.ReadLine();
▶                if (requestPipe.IsConnected) responderPipeId = sr.ReadLine() ?? "";
                 if (msg == null)
                 {
                     Logger.Warn("no message received within request window");

💬 Async overload available for StreamReader.ReadLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 20 hits

📄 AutoDarkModeLib\ComponentSettings\Base\WallpaperSwitchSettings.cs (line 80)

         {
             try
             {
▶                DisplayMonitor monitor = Task.Run(async () => await GetMonitorInfoAsync()).Result;
                 if (monitor != null)
                 {
                     Connected = true;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 AutoDarkModeSvc\Handlers\WallpaperHandler.cs (line 102)

     {
         IDesktopWallpaper handler = (IDesktopWallpaper)new DesktopWallpaperClass();
         handler.SetPosition(position);
▶        var monitors = Task.Run(DisplayHandler.GetMonitorInfosAsync).Result;
 
         foreach (var monitor in monitors)
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 4 hits

📄 AutoDarkModeSvc\SwitchComponents\Base\WallpaperSwitch.cs (line 376)

 
         // global wallpaper enable state synchronization;
         string globalWallpaper = WallpaperHandler.GetGlobalWallpaper().ToLower();
▶        if (globalWallpaper == Settings.Component.GlobalWallpaper.Light?.ToLower()) currentGlobalTheme = Theme.Light;
         else if (globalWallpaper == Settings.Component.GlobalWallpaper.Dark?.ToLower()) currentGlobalTheme = Theme.Dark;
 
         // solid color enable state synchronization

📄 AutoDarkModeSvc\SwitchComponents\Base\WallpaperSwitch.cs (line 377)

         // global wallpaper enable state synchronization;
         string globalWallpaper = WallpaperHandler.GetGlobalWallpaper().ToLower();
         if (globalWallpaper == Settings.Component.GlobalWallpaper.Light?.ToLower()) currentGlobalTheme = Theme.Light;
▶        else if (globalWallpaper == Settings.Component.GlobalWallpaper.Dark?.ToLower()) currentGlobalTheme = Theme.Dark;
 
         // solid color enable state synchronization
         if (GlobalState.ManagedThemeFile.Desktop.Wallpaper.Length == 0 &&

SS057 Collection manipulated during traversal 6 hits

📄 AutoDarkModeSvc\Handlers\ThemeFiles\ThemeFile.cs (line 338)

             if (line.Length != 0 && !line.Contains('=') && !line.StartsWith('[') && !line.StartsWith(';'))
             {
                 Logger.Warn($"invalid ini file entry detected: {line}, removing line to preserve theme file integrity");
▶                ThemeFileContent.RemoveAt(i);
                 i--;
             }
             // removes invalid sections

📄 AutoDarkModeSvc\Handlers\ThemeFiles\ThemeFile.cs (line 354)

             {
                 if ((i + 1) < ThemeFileContent.Count && ThemeFileContent[i + 1].Length == 0)
                 {
▶                    ThemeFileContent.RemoveAt(i + 1);
                     i--;
                 }
             }

SS058 String concatenated in a loop 2 hits

📄 AutoDarkModeSvc\Handlers\ThemeDllHandler.cs (line 44)

         string line = "";
         while (!bridge.StandardOutput.EndOfStream)
         {
▶            line += bridge.StandardOutput.ReadLine();
         }
         bridge.WaitForExit();
         int exitCode = bridge.ExitCode;

📄 AutoDarkModeSvc\Handlers\ThemeDllHandler.cs (line 44)

         string line = "";
         while (!bridge.StandardOutput.EndOfStream)
         {
▶            line += bridge.StandardOutput.ReadLine();
         }
         bridge.WaitForExit();
         int exitCode = bridge.ExitCode;

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 AutoDarkModeSvc\HttpClientProgressExtensions.cs (line 32)

         using (var response = await client.GetAsync(requestUrl, HttpCompletionOption.ResponseHeadersRead))
         {
             var contentLength = response.Content.Headers.ContentLength;
▶            using (var download = await response.Content.ReadAsStreamAsync())
             {
                 // no progress... no contentLength... very sad
                 if (progress is null || !contentLength.HasValue)

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 AutoDarkModeSvc\Communication\AsyncPipeServer.cs (line 152)

         try
         {
             // this stream is the main requester loop and should only be cancelled from the outside if the server is stopped
▶            using NamedPipeServerStream requestPipe = new(Address.PipePrefix + Address.PipeRequest, PipeDirection.InOut, WorkerCount, PipeTransmissionMode.Message, PipeOptions.Asynchronous);
             await requestPipe.WaitForConnectionAsync(WorkerTokenSource.Token);
             Interlocked.Decrement(ref availableWorkers);
             if (AvailableWorkers == 0)

💬 NamedPipeServerStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 18 hits

📄 AutoDarkModeSvc\Service.cs (line 46)

     private static readonly NLog.Logger Logger = NLog.LogManager.GetCurrentClassLogger();
 
     private AdmConfigBuilder builder = AdmConfigBuilder.Instance();
▶    private NotifyIcon NotifyIcon { get; }
     private List<ModuleTimer> Timers { get; set; }
     private IMessageServer MessageServer { get; }
     private AdmConfigMonitor ConfigMonitor { get; }

💬 Disposable field NotifyIcon in type Service is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 AutoDarkModeSvc\Service.cs (line 54)

     GlobalState state = GlobalState.Instance();
 
 
▶    public readonly ToolStripMenuItem forceDarkMenuItem = new();
     public readonly ToolStripMenuItem forceLightMenuItem = new();
     public readonly ToolStripMenuItem autoThemeSwitchingItem = new();
     public readonly ToolStripMenuItem toggleThemeItem = new();

💬 Disposable field forceDarkMenuItem in type Service is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

LiteNetLib

280 total diagnostics across 10 rules

SS003 Integer divided by integer causing implicit rounding 108 hits

📄 LiteNetLib\NetConstants.cs (line 50)

         public const int FragmentHeaderSize = 6;
         public const int FragmentedHeaderTotalSize = ChanneledHeaderSize + FragmentHeaderSize;
         public const ushort MaxSequence = 32768;
▶        public const ushort HalfMaxSequence = MaxSequence / 2;
 
         //protocol
         internal const int ProtocolId = 13;

💬 The operands in the divisive expression MaxSequence / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 LiteNetLib\NetConstants.cs (line 57)

         internal const int MaxUdpHeaderSize = 68;
         internal const int ChannelTypeCount = 4;
         internal const int FragmentedChannelsCount = 2;
▶        internal const int MaxFragmentsInWindow = DefaultWindowSize / 2;
 
         internal static readonly int[] PossibleMtu =
         {

💬 The operands in the divisive expression DefaultWindowSize / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 16 hits

📄 LiteNetLib\LiteNetManager.Socket.cs (line 146)

                         continue;
                     }
                     bool messageReceived = false;
▶                    if (socketv4.Available != 0 || selectReadList.Contains(socketv4))
                     {
                         if (NativeReceiveFrom(socketHandle4, addrBuffer4) == false)
                             return;

💬 Type Socket is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 LiteNetLib\LiteNetManager.Socket.cs (line 152)

                             return;
                         messageReceived = true;
                     }
▶                    if (socketV6.Available != 0 || selectReadList.Contains(socketV6))
                     {
                         if (NativeReceiveFrom(socketHandle6, addrBuffer6) == false)
                             return;

SS005 Equals() and GetHashCode() not implemented together 4 hits

📄 LiteNetLib\LiteNetPeer.cs (line 53)

     /// <summary>
     /// Network peer. Main purpose is sending messages to specific peer.
     /// </summary>
▶    public class LiteNetPeer : IPEndPoint
     {
         //Ping and RTT
         private int _rtt;

💬 Equals() and GetHashcode() must be implemented together on LiteNetPeer (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 LiteNetLib\LiteNetPeer.cs (line 53)

     /// <summary>
     /// Network peer. Main purpose is sending messages to specific peer.
     /// </summary>
▶    public class LiteNetPeer : IPEndPoint
     {
         //Ping and RTT
         private int _rtt;

💬 Equals() and GetHashcode() must be implemented together on LiteNetPeer (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 8 hits

📄 LiteNetLib\LiteNetPeer.cs (line 228)

 
         public override int GetHashCode() =>
             //uses SocketAddress hash in NET8 and IPEndPoint hash for NativeSockets and previous NET versions
▶            _cachedHashCode;
 
         //incoming connection constructor
         internal LiteNetPeer(LiteNetManager netManager, IPEndPoint remoteEndPoint, int id) : base(remoteEndPoint.Address, remoteEndPoint.Port)

💬 GetHashCode() refers to mutable field _cachedHashCode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 LiteNetLib\LiteNetPeer.cs (line 228)

 
         public override int GetHashCode() =>
             //uses SocketAddress hash in NET8 and IPEndPoint hash for NativeSockets and previous NET versions
▶            _cachedHashCode;
 
         //incoming connection constructor
         internal LiteNetPeer(LiteNetManager netManager, IPEndPoint remoteEndPoint, int id) : base(remoteEndPoint.Address, remoteEndPoint.Port)

💬 GetHashCode() refers to mutable field _cachedHashCode (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 60 hits

📄 LiteNetLib\INetEventListener.cs (line 59)

     /// <summary>
     /// Additional information about disconnection
     /// </summary>
▶    public struct DisconnectInfo
     {
         /// <summary>
         /// Additional info why peer disconnected

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DisconnectInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 LiteNetLib\NatPunchModule.cs (line 47)

     /// </summary>
     public sealed class NatPunchModule
     {
▶        struct RequestEventData
         {
             public IPEndPoint LocalEndPoint;
             public IPEndPoint RemoteEndPoint;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RequestEventData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 28 hits

📄 LiteNetLib\LiteNetManager.cs (line 835)

                 return;
             }
 
▶            switch (packet.Property)
             {
                 //special case connect request
                 case PacketProperty.ConnectRequest:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 LiteNetLib\LiteNetPeer.cs (line 935)

         internal ConnectRequestResult ProcessConnectRequest(NetConnectRequestPacket connRequest)
         {
             //current or new request
▶            switch (_connectionState)
             {
                 //P2P case
                 case ConnectionState.Outgoing:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 36 hits

📄 LiteNetLib\LiteNetManager.cs (line 391)

         {
             NetDebug.Write("[NM] Processing event: " + evt.Type);
             bool emptyData = evt.DataReader.IsNull;
▶            switch (evt.Type)
             {
                 case NetEvent.EType.Connect:
                     _netEventListener.OnPeerConnected(evt.Peer);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 LiteNetLib\NetManager.cs (line 148)

             NetDebug.Write("[NM] Processing event: " + evt.Type);
             bool emptyData = evt.DataReader.IsNull;
             var netPeer = evt.Peer as NetPeer;
▶            switch (evt.Type)
             {
                 case NetEvent.EType.Connect:
                     _netEventListener.OnPeerConnected(netPeer);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 8 hits

📄 LiteNetLib.Tests\LiteCommunicationTest.cs (line 39)

         private const string DefaultAppKey = "test_server";
         private static readonly byte[] DefaultAppKeyBytes = [12, 0, 116, 101, 115, 116, 95, 115, 101, 114, 118, 101, 114];
 
▶        public LiteNetManagerStack ManagerStack { get; set; }
 
         [Test, CancelAfter(TestTimeout)]
         public void ConnectionByIpV4()

💬 Method set_ManagerStack might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 LiteNetLib.Tests\CommunicationTest.cs (line 39)

         private const string DefaultAppKey = "test_server";
         private static readonly byte[] DefaultAppKeyBytes = [12, 0, 116, 101, 115, 116, 95, 115, 101, 114, 118, 101, 114];
 
▶        public NetManagerStack ManagerStack { get; set; }
 
         [Test, CancelAfter(TestTimeout)]
         public void ConnectionByIpV4()

💬 Method set_ManagerStack might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS057 Collection manipulated during traversal 8 hits

📄 LiteNetLib\LiteNetManager.cs (line 539)

                     if (incomingData.TimeWhenGet <= time)
                     {
                         HandleMessageReceived(incomingData.Data, incomingData.EndPoint);
▶                        _pingSimulationList.RemoveAt(i);
                         i--;
                     }
                 }

📄 LiteNetLib\LiteNetManager.cs (line 555)

                     {
                         // Send the delayed packet directly to socket layer bypassing simulation
                         SendRawCore(outboundData.Data, outboundData.Start, outboundData.Length, outboundData.EndPoint);
▶                        _outboundSimulationList.RemoveAt(i);
                         i--;
                     }
                 }

SS060 ConcurrentDictionary emptiness check without IsEmpty 4 hits

📄 LiteNetLib\NetManager.cs (line 95)

 
         internal override bool CustomMessageHandle(NetPacket packet, IPEndPoint remoteEndPoint)
         {
▶            if (_ntpRequests.Count > 0 && _ntpRequests.TryGetValue(remoteEndPoint, out _))
             {
                 if (packet.Size < 48)
                 {

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 LiteNetLib\NetManager.cs (line 95)

 
         internal override bool CustomMessageHandle(NetPacket packet, IPEndPoint remoteEndPoint)
         {
▶            if (_ntpRequests.Count > 0 && _ntpRequests.TryGetValue(remoteEndPoint, out _))
             {
                 if (packet.Size < 48)
                 {

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

TwitchDownloader

276 total diagnostics across 14 rules

SS001 Async method with void return type 4 hits

📄 TwitchDownloaderWPF\MainWindow.xaml.cs (line 136)

 #endif
         }
 
▶        private async void FlashTaskbarIconIfNotForeground(TimeSpan flashDuration)
         {
             var currentWindow = new WindowInteropHelper(this).Handle;
             var foregroundWindow = NativeFunctions.GetForegroundWindow();

💬 Method FlashTaskbarIconIfNotForeground is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 TwitchDownloaderWPF\MainWindow.xaml.cs (line 136)

 #endif
         }
 
▶        private async void FlashTaskbarIconIfNotForeground(TimeSpan flashDuration)
         {
             var currentWindow = new WindowInteropHelper(this).Handle;
             var foregroundWindow = NativeFunctions.GetForegroundWindow();

💬 Method FlashTaskbarIconIfNotForeground is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 8 hits

📄 TwitchDownloaderCore\ChatDownloader.cs (line 368)

         {
             var chatRoot = new ChatRoot
             {
▶                FileInfo = new ChatRootInfo { Version = ChatRootVersion.CurrentVersion, CreatedAt = DateTime.Now },
                 streamer = new Streamer(),
                 video = new Video(),
                 comments = new List<Comment>()

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 TwitchDownloaderCore\ChatUpdater.cs (line 59)

 
         private async Task UpdateAsyncImpl(FileInfo outputFileInfo, FileStream outputFs, CancellationToken cancellationToken)
         {
▶            chatRoot.FileInfo = new() { Version = ChatRootVersion.CurrentVersion, CreatedAt = chatRoot.FileInfo.CreatedAt, UpdatedAt = DateTime.Now };
             if (!Path.GetExtension(_updateOptions.InputFile.Replace(".gz", ""))!.Equals(".json", StringComparison.OrdinalIgnoreCase))
             {
                 throw new NotSupportedException("Only JSON chat files can be used as update input. HTML support may come in the future.");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 64 hits

📄 TwitchDownloaderCore\ChatDownloader.cs (line 488)

                 {
                     percentages[tc] = Math.Clamp(percent, 0, 100);
 
▶                    var reportPercent = percentages.Sum() / connectionCount;
                     _progress.ReportProgress(reportPercent);
                 });
 

💬 The operands in the divisive expression percentages.Sum() / connectionCount are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 TwitchDownloaderCore\ChatDownloader.cs (line 576)

                     imageScale = emote.ImageScale,
                     data = emote.ImageData,
                     name = emote.Name,
▶                    width = emote.Width / emote.ImageScale,
                     height = emote.Height / emote.ImageScale,
                     isZeroWidth = emote.IsZeroWidth,
                 };

💬 The operands in the divisive expression emote.Width / emote.ImageScale are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 TwitchDownloaderCore\ChatUpdater.cs (line 469)

                 commentsSet.EnsureCapacity(commentsSet.Count + chatRoot.comments.Count);
                 foreach (var comment in chatRoot.comments)
                 {
▶                    commentsSet.Add(comment);
                 }
 
                 chatRoot.comments = commentsSet.ToList();

💬 Type Comment is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 TwitchDownloaderCore\ChatUpdater.cs (line 469)

                 commentsSet.EnsureCapacity(commentsSet.Count + chatRoot.comments.Count);
                 foreach (var comment in chatRoot.comments)
                 {
▶                    commentsSet.Add(comment);
                 }
 
                 chatRoot.comments = commentsSet.ToList();

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 TwitchDownloaderCore\TwitchObjects\CommentSection.cs (line 13)

         public int CommentIndex { get; set; }
     }
 
▶    public struct Point
     {
         public int X { get; set; }
         public int Y { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Point. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 TwitchDownloaderCore\TwitchObjects\CommentSection.cs (line 13)

         public int CommentIndex { get; set; }
     }
 
▶    public struct Point
     {
         public int X { get; set; }
         public int Y { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Point. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 20 hits

📄 TwitchDownloaderCore\Tools\TimeSpanHFormat.cs (line 100)

                         bigHStart = -1;
                     }
 
▶                    switch (readChar)
                     {
                         // If the current char is an escape we can skip the next char
                         case '\\':

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 TwitchDownloaderCLI\Tools\UserPrompt.cs (line 25)

                     return UserPromptResult.Unknown;
                 }
 
▶                switch (userInput.Trim().ToLower())
                 {
                     case "y" or "yes":
                         return UserPromptResult.Yes;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 6 hits

📄 TwitchDownloaderCore\TwitchHelper.cs (line 826)

                         await ms.CopyToAsync(fs, cancellationToken);
                     }
 
▶                    using var archive = ZipFile.OpenRead(emojiZipPath);
                     var emojiAssetsPath = emojiVendor.AssetPath();
                     var emojis = archive.Entries
                         .Where(x => !string.IsNullOrWhiteSpace(x.Name) && Path.GetDirectoryName(x.FullName) == emojiAssetsPath);

💬 Async overload available for ZipFile.OpenRead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 TwitchDownloaderCore\TwitchHelper.cs (line 840)

                         {
                             try
                             {
▶                                emoji.ExtractToFile(filePath);
                             }
                             catch { /* Being written by a parallel process? */ }
                         }

💬 Async overload available for ZipFileExtensions.ExtractToFile (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 68 hits

📄 TwitchDownloaderCore\ChatDownloader.cs (line 506)

             _progress.ReportProgress(100);
 
             var commentList = downloadTasks
▶                .SelectMany(task => task.Result)
                 .ToHashSet(new CommentIdEqualityComparer())
                 .ToList();
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 TwitchDownloaderCore\ChatRenderer.cs (line 1743)

             GC.Collect();
             GC.WaitForPendingFinalizers();
 
▶            badgeList = badgeTask.Result;
             emoteList = emoteTask.Result;
             emoteThirdList = emoteThirdTask.Result;
             cheermotesList = cheerTask.Result;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 TwitchDownloaderCore\ChatDownloader.cs (line 505)

 
             _progress.ReportProgress(100);
 
▶            var commentList = downloadTasks
                 .SelectMany(task => task.Result)
                 .ToHashSet(new CommentIdEqualityComparer())
                 .ToList();

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 TwitchDownloaderCore\ChatDownloader.cs (line 505)

 
             _progress.ReportProgress(100);
 
▶            var commentList = downloadTasks
                 .SelectMany(task => task.Result)
                 .ToHashSet(new CommentIdEqualityComparer())
                 .ToList();

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS047 LINQ traversal before filter 4 hits

📄 TwitchDownloaderCore\VideoDownloader.cs (line 124)

                 var concatListPath = Path.Combine(_vodCacheDir, "concat.txt");
                 var streamIds = GetStreamIds(playlist);
 
▶                var validParts = playlist.Streams
                     .Take(videoListCrop)
                     .Where(x => File.Exists(Path.Combine(_vodCacheDir, DownloadTools.RemoveQueryString(x.Path))))
                     .ToArray();

📄 TwitchDownloaderCore\VideoDownloader.cs (line 133)

                 if (validParts.Length < videoListCrop.GetOffsetAndLength(playlist.Streams.Length).Length)
                 {
                     // This is probably super inefficient, but it's a very cold path anyway
▶                    var missingParts = playlist.Streams
                         .Take(videoListCrop)
                         .Where(x => !validParts.Contains(x));
 

SS048 Locking on discouraged object (string, Type, this) 50 hits

📄 TwitchDownloaderCLI\Tools\CliTaskProgress.cs (line 41)

         {
             if ((_logLevel & LogLevel.Status) == 0) return;
 
▶            lock (this)
             {
                 _status = status;
                 _statusIsTemplate = false;

📄 TwitchDownloaderCLI\Tools\CliTaskProgress.cs (line 54)

         {
             if ((_logLevel & LogLevel.Status) == 0) return;
 
▶            lock (this)
             {
                 _status = statusTemplate;
                 _statusIsTemplate = true;

SS057 Collection manipulated during traversal 4 hits

📄 TwitchDownloaderCore\TwitchObjects\TwitchEmote.cs (line 82)

             {
                 for (int i = 0; i < EmoteFrameDurations.Count; i++)
                 {
▶                    EmoteFrameDurations.RemoveAt(i);
                     EmoteFrameDurations.Insert(i, 10);
                 }
                 TotalDuration = EmoteFrameDurations.Count * 10;

📄 TwitchDownloaderCore\TwitchObjects\TwitchEmote.cs (line 83)

                 for (int i = 0; i < EmoteFrameDurations.Count; i++)
                 {
                     EmoteFrameDurations.RemoveAt(i);
▶                    EmoteFrameDurations.Insert(i, 10);
                 }
                 TotalDuration = EmoteFrameDurations.Count * 10;
             }

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 TwitchDownloaderCore\Chat\ChatHtml.cs (line 33)

 
             cancellationToken.ThrowIfCancellationRequested();
 
▶            using var templateStream = new MemoryStream(Properties.Resources.chat_template);
             using var templateReader = new StreamReader(templateStream);
 
             await using var sw = new StreamWriter(outputStream, leaveOpen: true);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 TwitchDownloaderCore\TwitchHelper.cs (line 820)

                 var emojiZipPath = Path.Combine(emojiFolder, Path.GetRandomFileName());
                 try
                 {
▶                    using (var ms = emojiVendor.MemoryStream())
                     {
                         await using var fs = File.OpenWrite(emojiZipPath);
                         await ms.CopyToAsync(fs, cancellationToken);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 34 hits

📄 TwitchDownloaderCore\Tools\HighlightIcons.cs (line 64)

         [GeneratedRegex("""^We added \d+ Gift Subs (?:AND \d+ Bonus Gift Subs )?to """)]
         private static partial Regex SubtemberRegex { get; }
 
▶        private SKImage _subscribedTierIcon;
         private SKImage _subscribedPrimeIcon;
         private SKImage _giftSingleIcon;
         private SKImage _giftManyIcon;

💬 Disposable field _subscribedTierIcon in type HighlightIcons is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 TwitchDownloaderCore\Tools\HighlightIcons.cs (line 65)

         private static partial Regex SubtemberRegex { get; }
 
         private SKImage _subscribedTierIcon;
▶        private SKImage _subscribedPrimeIcon;
         private SKImage _giftSingleIcon;
         private SKImage _giftManyIcon;
         private SKImage _giftAnonymousIcon;

💬 Disposable field _subscribedPrimeIcon in type HighlightIcons is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

commandline

276 total diagnostics across 9 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 24 hits

📄 src\CommandLine\Text\CopyrightInfo.cs (line 123)

                             //if both copyrightAttr and companyAttr aren't available in Assembly,don't fire Exception
                             ? Empty
                             // if no copyright attribute exist but a company attribute does, use it as copyright holder
▶                            : new CopyrightInfo(companyAttr.FromJust().Company, DateTime.Now.Year);
                         
                 }
             }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\CommandLine\Text\CopyrightInfo.cs (line 34)

         {
             get
             {
▶                return new CopyrightInfo("author", DateTime.Now.Year);
             }
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 112 hits

📄 src\CommandLine\UnParserExtensions.cs (line 171)

                                 select info;
 
             var optSpecs = settings.GroupSwitches
▶                ? allOptSpecs.Where(info => !shortSwitches.Contains(info))
                 : allOptSpecs;
 
             var valSpecs = from info in specs.Where(i => i.Specification.Tag == SpecificationType.Value)

💬 Type is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\CommandLine\Core\TokenPartitioner.cs (line 78)

                             break;
                         case TargetType.Sequence:
                             nameToken = token;
▶                            if (! sequences.ContainsKey(nameToken))
                             {
                                 sequences[nameToken] = new List<Token>();
                                 count[nameToken] = 0;

💬 Type Token is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

📄 src\CommandLine\Core\TypeDescriptor.cs (line 8)

 
 namespace CommandLine.Core
 {
▶    struct TypeDescriptor
     {
         private readonly TargetType targetType;
         private readonly Maybe<int> maxItems;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TypeDescriptor. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\CommandLine\Text\HelpText.cs (line 25)

 
▶    public struct ComparableOption
     {
         public bool Required;
         public bool IsOption;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ComparableOption. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 24 hits

📄 src\CommandLine\Core\ValueMapper.cs (line 74)

 
         private static Maybe<int> CountOfMaxNumberOfValues(this Specification specification)
         {
▶            switch (specification.TargetType)
             {
                 case TargetType.Scalar:
                     return Maybe.Just(1);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\CommandLine\UnParserExtensions.cs (line 219)

         private static string FormatValue(Specification spec, object value)
         {
             var builder = new StringBuilder();
▶            switch (spec.TargetType)
             {
                 case TargetType.Scalar:
                     builder.Append(FormatWithQuotesIfString(value));

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 48 hits

📄 src\CommandLine\Core\ValueMapper.cs (line 74)

 
         private static Maybe<int> CountOfMaxNumberOfValues(this Specification specification)
         {
▶            switch (specification.TargetType)
             {
                 case TargetType.Scalar:
                     return Maybe.Just(1);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\CommandLine\Core\GetoptTokenizer.cs (line 44)

             var enumerator = arguments.GetEnumerator();
             while (enumerator.MoveNext())
             {
▶                switch (enumerator.Current) {
                     case null:
                         break;
 

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 8 hits

📄 src\CommandLine\Text\SentenceBuilder.cs (line 168)

                                     return MultipleDefaultVerbsError.ErrorMessage;
 
                             }
▶                            throw new InvalidOperationException();
                         };
                 }
             }

💬 An exception is thrown from the getter of property FormatError (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\CommandLine\Text\SentenceBuilder.cs (line 168)

                                     return MultipleDefaultVerbsError.ErrorMessage;
 
                             }
▶                            throw new InvalidOperationException();
                         };
                 }
             }

💬 An exception is thrown from the getter of property FormatError (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS041 Unnecessary enumerable materialization 8 hits

📄 src\CommandLine\Text\HelpText.cs (line 884)

             if (OptionComparison != null)
             {
                 int i = -1;
▶                var comparables = specifications.ToList().Select(s =>
                 {
                     i++;
                     return ToComparableOption(s, i);

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\CommandLine\Text\HelpText.cs (line 884)

             if (OptionComparison != null)
             {
                 int i = -1;
▶                var comparables = specifications.ToList().Select(s =>
                 {
                     i++;
                     return ToComparableOption(s, i);

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 20 hits

📄 src\CommandLine\BaseAttribute.cs (line 10)

     /// <summary>
     /// Models a base attribute to define command line syntax.
     /// </summary>
▶    public abstract class BaseAttribute : Attribute
     {
         private int min;
         private int max;

💬 BaseAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\CommandLine\Text\MultiLineTextAttribute.cs (line 12)

     /// <summary>
     /// Provides base properties for creating an attribute, used to define multiple lines of text.
     /// </summary>
▶    public abstract class MultilineTextAttribute : Attribute
     {
         private readonly string line1;
         private readonly string line2;

💬 MultilineTextAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS066 Disposable field is not disposed 8 hits

📄 src\CommandLine\ParserSettings.cs (line 22)

         private bool disposed;
         private bool caseSensitive;
         private bool caseInsensitiveEnumValues;
▶        private TextWriter helpWriter;
         private bool ignoreUnknownArguments;
         private bool autoHelp;
         private bool autoVersion;

💬 Disposable field helpWriter in type ParserSettings is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\CommandLine\ParserSettings.cs (line 22)

         private bool disposed;
         private bool caseSensitive;
         private bool caseInsensitiveEnumValues;
▶        private TextWriter helpWriter;
         private bool ignoreUnknownArguments;
         private bool autoHelp;
         private bool autoVersion;

💬 Disposable field helpWriter in type ParserSettings is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Autofac

256 total diagnostics across 10 rules

SS004 Elementary methods of type in collection not overridden 8 hits

📄 test\Autofac.Test\Util\Cache\ReflectionCacheParameterDictionaryTests.cs (line 49)

     {
         var cache = new ReflectionCacheParameterDictionary<bool>
         {
▶            [SampleParameter] = true,
         };
 
         cache.Clear((_, _) => false);

💬 Type ParameterInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 test\Autofac.Test\Util\Cache\ReflectionCacheParameterDictionaryTests.cs (line 62)

     {
         var cache = new ReflectionCacheParameterDictionary<bool>
         {
▶            [SampleParameter] = true,
         };
 
         cache.Clear((member, _) => member == SampleParameter.Member);

SS008 GetHashCode() refers to mutable or static member 8 hits

📄 src\Autofac\Features\OwnedInstances\InstancePerOwnedKey.cs (line 32)

 
     /// <inheritdoc/>
     public override int GetHashCode()
▶        => _serviceWithType.ServiceType.GetHashCode();
 }

💬 GetHashCode() refers to mutable field _serviceWithType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Autofac\Features\OwnedInstances\InstancePerOwnedKey.cs (line 32)

 
     /// <inheritdoc/>
     public override int GetHashCode()
▶        => _serviceWithType.ServiceType.GetHashCode();
 }

💬 GetHashCode() refers to mutable field _serviceWithType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 52 hits

📄 src\Autofac\Core\Activators\Reflection\InjectablePropertyState.cs (line 9)

 /// <summary>
 /// Structure used to track whether or not we have set a property during activation.
 /// </summary>
▶internal struct InjectablePropertyState
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="InjectablePropertyState"/> struct.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct InjectablePropertyState. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Autofac\Diagnostics\ValueStopwatch.cs (line 15)

 /// Lightweight stopwatch for timing without heap allocations.
 /// </summary>
 [ExcludeFromCodeCoverage]
▶internal struct ValueStopwatch
 {
 #if !NET7_0_OR_GREATER
     private static readonly double TimestampToTicks = TimeSpan.TicksPerSecond / (double)Stopwatch.Frequency;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ValueStopwatch. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS023 Exception thrown from property getter 20 hits

📄 src\Autofac\Module.cs (line 63)

             var baseType = thisType.BaseType;
             if (baseType != typeof(Module))
             {
▶                throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, ModuleResources.ThisAssemblyUnavailable, thisType, baseType));
             }
 
             return thisType.Assembly;

💬 An exception is thrown from the getter of property ThisAssembly (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Autofac\Core\Resolving\SegmentedStack.cs (line 159)

             {
                 if (_index < 0)
                 {
▶                    throw new InvalidOperationException(SegmentedStackResources.EnumeratorNotValid);
                 }
 
                 return _currentElement!;

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS027 Exception thrown from Dispose 8 hits

📄 src\Autofac\Core\Resolving\SegmentedStack.cs (line 131)

             // the segment was not fully popped before exiting the segment.
             if (_stack.Count > 0)
             {
▶                throw new InvalidOperationException(SegmentedStackResources.CannotExitSegmentWithRemainingItems);
             }
 
             _stack._activeSegmentBase = _resetPosition;

💬 An exception is thrown from the Dispose() method in type StackSegment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 src\Autofac\Core\Resolving\SegmentedStack.cs (line 131)

             // the segment was not fully popped before exiting the segment.
             if (_stack.Count > 0)
             {
▶                throw new InvalidOperationException(SegmentedStackResources.CannotExitSegmentWithRemainingItems);
             }
 
             _stack._activeSegmentBase = _resetPosition;

💬 An exception is thrown from the Dispose() method in type StackSegment (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS033 Async overload is available 12 hits

📄 src\Autofac\Util\AsyncReleaseAction.cs (line 42)

             await _action(_factory()).ConfigureAwait(false);
         }
 
▶        base.Dispose(disposing);
     }
 
     /// <inheritdoc/>

💬 Async overload available for Disposable.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Autofac\Util\AsyncReleaseAction.cs (line 42)

             await _action(_factory()).ConfigureAwait(false);
         }
 
▶        base.Dispose(disposing);
     }
 
     /// <inheritdoc/>

💬 Async overload available for Disposable.Dispose (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 test\Autofac.Test.Scenarios.ScannedAssembly\MetadataAttributeScanningScenario\DuplicatedNameAttribute.cs (line 8)

 
 namespace Autofac.Test.Scenarios.ScannedAssembly.MetadataAttributeScanningScenario
 {
▶    public class DuplicatedNameAttribute : Attribute, IHaveName
     {
         public DuplicatedNameAttribute(string name)
         {

💬 DuplicatedNameAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 test\Autofac.Test.Scenarios.ScannedAssembly\MetadataAttributeScanningScenario\NameAttribute.cs (line 8)

 
 namespace Autofac.Test.Scenarios.ScannedAssembly.MetadataAttributeScanningScenario
 {
▶    public class NameAttribute : Attribute, IHaveName
     {
         public NameAttribute(string name)
         {

💬 NameAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 test\Autofac.Test\Core\ComponentRegistrationTests.cs (line 40)

 
         await using var disposable = new AsyncDisposeTracker();
 
▶        using var activator = Factory.CreateProvidedInstanceActivator(disposable);
         activator.DisposeInstance = true;
 
         var registration = Factory.CreateSingletonRegistration(services, activator);

💬 ProvidedInstanceActivator can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 test\Autofac.Test\Core\ComponentRegistrationTests.cs (line 55)

     {
         var services = new Service[] { new TypedService(typeof(object)) };
 
▶        using var activator = Factory.CreateProvidedInstanceActivator(new object());
         var registration = Factory.CreateSingletonRegistration(services, activator);
 
         await registration.DisposeAsync();

💬 ProvidedInstanceActivator can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 32 hits

📄 src\Autofac\Util\Cache\ReflectionCacheTupleDictionary.cs (line 26)

     /// <inheritdoc />
     public void Clear(ReflectionCacheClearPredicate predicate)
     {
▶        if (Count == 0)
         {
             return;
         }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 src\Autofac\Util\Cache\ReflectionCacheParameterDictionary.cs (line 28)

             throw new ArgumentNullException(nameof(predicate));
         }
 
▶        if (Count == 0)
         {
             return;
         }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

SS066 Disposable field is not disposed 104 hits

📄 src\Autofac\Features\OwnedInstances\Owned.cs (line 67)

 [SuppressMessage("Microsoft.ApiDesignGuidelines", "CA2213", Justification = "False positive - the lifetime does get disposed.")]
 public class Owned<T> : Disposable
 {
▶    private IDisposable? _lifetime;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="Owned{T}"/> class.

💬 Disposable field _lifetime in type Owned is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Autofac\Core\Registration\ComponentRegistration.cs (line 24)

                                                                             RegistrationOptions.ExcludeFromCollections |
                                                                             RegistrationOptions.DisableDecoration;
 
▶    private readonly IComponentRegistration? _target;
     private readonly IResolvePipelineBuilder _lateBuildPipeline;
 
     private EventHandler<IResolvePipelineBuilder>? _pipelineBuildEvent;

💬 Disposable field _target in type ComponentRegistration is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

LLamaSharp

244 total diagnostics across 12 rules

SS001 Async method with void return type 2 hits

📄 LLama.Examples\Examples\SpeechChat.cs (line 199)

                 }
 
 
▶                async void SendTranscription()
                 {
                     var bytesPerClip = _waveFormat.BitsPerSample * (int)ClipLength.TotalMilliseconds * 2;
                     var capturedClipBytes = _recordedBytes.TakeLast(bytesPerClip * (_nonIdleTime + 2)).ToArray();

💬 Method SendTranscription is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 LLama.Examples\Examples\SpeechChat.cs (line 199)

                 }
 
 
▶                async void SendTranscription()
                 {
                     var bytesPerClip = _waveFormat.BitsPerSample * (int)ClipLength.TotalMilliseconds * 2;
                     var capturedClipBytes = _recordedBytes.TakeLast(bytesPerClip * (_nonIdleTime + 2)).ToArray();

💬 Method SendTranscription is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS003 Integer divided by integer causing implicit rounding 30 hits

📄 LLama\Batched\BatchedExecutor.cs (line 231)

                 return;
             }
 
▶            if (_batchQueueHead > CleanupThreshold && _batchQueueHead > _batchQueue.Count / 2)
             {
                 _batchQueue.RemoveRange(0, _batchQueueHead);
                 _batchQueueHead = 0;

💬 The operands in the divisive expression _batchQueue.Count / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 LLama\Batched\Conversation.cs (line 436)

         AssertCanBePrompted();
 
         var dim = Executor.Model.EmbeddingSize;
▶        var count = embeddings.Length / dim;
         if (count * dim != embeddings.Length)
             throw new ArgumentException($"Incorrect embeddings span size, length ({embeddings.Length}) must be divisible by embedding dimensions ({Executor.Model.EmbeddingSize})");
 

💬 The operands in the divisive expression embeddings.Length / dim are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 100 hits

📄 LLama\Batched\Conversation.cs (line 537)

     /// Provides direct access to the KV cache of a <see cref="Conversation"/>.
     /// See <see cref="Modify"/> for how to use this.
     /// </summary>
▶    public readonly ref struct KvAccessor
     {
         private readonly Conversation _conversation;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct KvAccessor. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 LLama\Extensions\IReadOnlyListExtensions.cs (line 84)

             return tokens.TokensEndsWithAnyString(new ReadonlyWrapper<string>(queries), model, encoding);
         }
 
▶        private readonly struct ReadonlyWrapper<T>
             : IReadOnlyList<T>
         {
             private readonly IList<T> _list;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ReadonlyWrapper. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 6 hits

📄 LLama\Extensions\IContextParamsExtensions.cs (line 54)

             result.offload_kqv = !@params.NoKqvOffload;
             result.llama_pooling_type = @params.PoolingType;
             result.attention_type = @params.AttentionType;
▶            result.llama_flash_attn_type = @params.FlashAttention switch
             {
                 true => LLamaFlashAttentionType.LLAMA_FLASH_ATTENTION_TYPE_ENABLED,
                 false => LLamaFlashAttentionType.LLAMA_FLASH_ATTENTION_TYPE_DISABLED,

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 LLama\Extensions\IContextParamsExtensions.cs (line 54)

             result.offload_kqv = !@params.NoKqvOffload;
             result.llama_pooling_type = @params.PoolingType;
             result.attention_type = @params.AttentionType;
▶            result.llama_flash_attn_type = @params.FlashAttention switch
             {
                 true => LLamaFlashAttentionType.LLAMA_FLASH_ATTENTION_TYPE_ENABLED,
                 false => LLamaFlashAttentionType.LLAMA_FLASH_ATTENTION_TYPE_DISABLED,

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 LLama\Native\SafeMtmdEmbed.cs (line 209)

                     unsafe
                     {
                         if (!IsValid)
▶                            throw new ObjectDisposedException("Cannot access Embed data, accessor has been disposed");
                         return new ReadOnlySpan<byte>(_dataPtr, _dataLength);
                     }
                 }

💬 An exception is thrown from the getter of property Data (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 LLama\Native\SafeMtmdEmbed.cs (line 209)

                     unsafe
                     {
                         if (!IsValid)
▶                            throw new ObjectDisposedException("Cannot access Embed data, accessor has been disposed");
                         return new ReadOnlySpan<byte>(_dataPtr, _dataLength);
                     }
                 }

💬 An exception is thrown from the getter of property Data (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 4 hits

📄 LLama\Native\NativeApi.Load.cs (line 29)

             }
             catch (DllNotFoundException)
             {
▶                throw new RuntimeError("The native library cannot be correctly loaded. It could be one of the following reasons: \n" +
                     "1. No LLamaSharp backend was installed. Please search LLamaSharp.Backend and install one of them. \n" +
                     "2. You are using a device with only CPU but installed cuda backend. Please install cpu backend instead. \n" +
                     "3. One of the dependency of the native library is missed. Please use `ldd` on linux, `dumpbin` on windows and `otool`" +

💬 An exception is thrown from NativeApi its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 LLama\Native\NativeApi.Load.cs (line 29)

             }
             catch (DllNotFoundException)
             {
▶                throw new RuntimeError("The native library cannot be correctly loaded. It could be one of the following reasons: \n" +
                     "1. No LLamaSharp backend was installed. Please search LLamaSharp.Backend and install one of them. \n" +
                     "2. You are using a device with only CPU but installed cuda backend. Please install cpu backend instead. \n" +
                     "3. One of the dependency of the native library is missed. Please use `ldd` on linux, `dumpbin` on windows and `otool`" +

💬 An exception is thrown from NativeApi its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS027 Exception thrown from Dispose 4 hits

📄 LLama\Batched\Conversation.cs (line 743)

         public override void Dispose()
         {
             if (IsDisposed)
▶                throw new ObjectDisposedException(nameof(State));
             IsDisposed = true;
 
             SequenceState.Dispose();

💬 An exception is thrown from the Dispose() method in type PrivateState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 LLama\Batched\Conversation.cs (line 743)

         public override void Dispose()
         {
             if (IsDisposed)
▶                throw new ObjectDisposedException(nameof(State));
             IsDisposed = true;
 
             SequenceState.Dispose();

💬 An exception is thrown from the Dispose() method in type PrivateState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS033 Async overload is available 14 hits

📄 LLama.WebAPI\Program.cs (line 32)

     _ = endpoints.MapControllers();
 });
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 LLama.Web\Program.cs (line 50)

 
 app.MapHub<SessionConnectionHub>(nameof(SessionConnectionHub));
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 LLama.Experimental\Native\AutoDownloadedLibraries.cs (line 81)

                 foreach (var relativePath in _macLibrary.Prepare(systemInfo, logCallback))
                 {
                     yield return relativePath;
▶                    var path = NativeLibraryDownloader.DownloadLibraryFile(_settings, relativePath, logCallback).Result;
                     if (path is not null)
                     {
                         yield return path;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 LLama.Experimental\Native\AutoDownloadedLibraries.cs (line 27)

                 foreach(var relativePath in _cudaLibrary.Prepare(systemInfo, logCallback))
                 {
                     yield return relativePath;
▶                    var path = NativeLibraryDownloader.DownloadLibraryFile(_settings, relativePath, logCallback).Result;
                     if (path is not null)
                     {
                         yield return path;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS058 String concatenated in a loop 2 hits

📄 LLama.WebAPI\Services\StatefulChatService.cs (line 63)

         await foreach (var output in outputs)
         {
             _logger.LogInformation("Message: {output}", output);
▶            result += output;
         }
 
         return result;

📄 LLama.WebAPI\Services\StatefulChatService.cs (line 63)

         await foreach (var output in outputs)
         {
             _logger.LogInformation("Message: {output}", output);
▶            result += output;
         }
 
         return result;

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 LLama\LLamaInstructExecutor.cs (line 115)

         public override async Task SaveState(string filename, CancellationToken cancellationToken = default)
         {
             var state = (InstructExecutorState)GetStateData();
▶            using (var fs = new FileStream(filename, FileMode.Create, FileAccess.Write))
             {
                 await JsonSerializer.SerializeAsync(fs, state, cancellationToken: cancellationToken);
             }

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 LLama\LLamaInteractExecutor.cs (line 101)

         public override async Task SaveState(string filename, CancellationToken cancellationToken = default)
         {
             var state = (InteractiveExecutorState)GetStateData();
▶            using (var fs = new FileStream(filename, FileMode.Create, FileAccess.Write))
             {
                 await JsonSerializer.SerializeAsync(fs, state, cancellationToken: cancellationToken);
             }

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 58 hits

📄 LLama\Native\SafeLLamaContextHandle.cs (line 75)

         /// </summary>
         public SafeLlamaModelHandle.Vocabulary Vocab => ThrowIfDisposed().Vocab;
 
▶        private SafeLlamaModelHandle? _model;
         #endregion
 
         #region construction/destruction

💬 Disposable field _model in type SafeLLamaContextHandle is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 LLama\LLamaEmbedder.cs (line 31)

     /// </summary>
     public LLamaContext Context { get; private set; }
 
▶    private LLamaWeights _weights;
     private IContextParams _params;
     private ILogger? _logger;
 

💬 Disposable field _weights in type LLamaEmbedder is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

StableSwarmUI

236 total diagnostics across 19 rules

SS001 Async method with void return type 2 hits

📄 src\Backends\NetworkBackendUtils.cs (line 444)

             }
         }
         new Thread(MonitorLoop) { Name = $"SelfStart{nameSimple.Replace(' ', '_')}_Monitor" }.Start();
▶        async void MonitorErrLoop()
         {
             StringBuilder errorLog = new();
             string line;

💬 Method MonitorErrLoop is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Backends\NetworkBackendUtils.cs (line 444)

             }
         }
         new Thread(MonitorLoop) { Name = $"SelfStart{nameSimple.Replace(' ', '_')}_Monitor" }.Start();
▶        async void MonitorErrLoop()
         {
             StringBuilder errorLog = new();
             string line;

💬 Method MonitorErrLoop is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\Text2Image\T2IParamInput.cs (line 440)

         SourceSession = session;
         InterruptToken = session is null ? new CancellationTokenSource().Token : session.SessInterrupt.Token;
         ExtraMeta["swarm_version"] = Utilities.Version;
▶        ExtraMeta["date"] = DateTime.Now.ToString("yyyy-MM-dd");
     }
 
     /// <summary>Gets the desired image width, automatically using alt-res parameter if needed.</summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Text2Image\T2IParamInput.cs (line 440)

         SourceSession = session;
         InterruptToken = session is null ? new CancellationTokenSource().Token : session.SessInterrupt.Token;
         ExtraMeta["swarm_version"] = Utilities.Version;
▶        ExtraMeta["date"] = DateTime.Now.ToString("yyyy-MM-dd");
     }
 
     /// <summary>Gets the desired image width, automatically using alt-res parameter if needed.</summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 20 hits

📄 src\Backends\BackendHandler.cs (line 711)

         public LockObject Locker = new();
 
         /// <summary>Gets a loose heuristic for model order preference - sort by earliest requester, but higher count of requests is worth 10 seconds.</summary>
▶        public long Heuristic(long timeRel) => Count * 10 + ((timeRel - TimeFirstRequest) / 1000); // TODO: 10 -> ?
     }
 
     /// <summary>Used by <see cref="GetNextT2IBackend(TimeSpan, T2IModel)"/> to determine which model to load onto a backend, heuristically.</summary>

💬 The operands in the divisive expression (timeRel - TimeFirstRequest) / 1000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\WebAPI\BackendAPI.cs (line 54)

     public static JObject BackendToNet(BackendHandler.T2IBackendData backend, bool full = false)
     {
         long timeLastRelease = backend.TimeLastRelease;
▶        long timeSinceUsed = timeLastRelease == 0 ? 0 : (Environment.TickCount64 - timeLastRelease) / 1000;
         JObject data = new()
         {
             ["type"] = backend.Backend.HandlerTypeData.ID,

💬 The operands in the divisive expression (Environment.TickCount64 - timeLastRelease) / 1000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 src\Accounts\Session.cs (line 211)

     /// <summary>Gets a hash code for this session, for C# equality comparsion.</summary>
     public override int GetHashCode()
     {
▶        return ID.GetHashCode();
     }
 
     /// <summary>Returns true if this session is the same as another.</summary>

💬 GetHashCode() refers to mutable field ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Accounts\Session.cs (line 211)

     /// <summary>Gets a hash code for this session, for C# equality comparsion.</summary>
     public override int GetHashCode()
     {
▶        return ID.GetHashCode();
     }
 
     /// <summary>Returns true if this session is the same as another.</summary>

💬 GetHashCode() refers to mutable field ID (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\Utils\MemoryNum.cs (line 4)

 namespace StableSwarmUI.Utils;
 
 /// <summary>Mini-struct to hold data about a memory (bytes) size number.</summary>
▶public struct MemoryNum(long inBytes)
 {
     public long InBytes = inBytes;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemoryNum. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Utils\MemoryNum.cs (line 4)

 namespace StableSwarmUI.Utils;
 
 /// <summary>Mini-struct to hold data about a memory (bytes) size number.</summary>
▶public struct MemoryNum(long inBytes)
 {
     public long InBytes = inBytes;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemoryNum. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 src\Text2Image\T2IParamTypes.cs (line 679)

         {
             throw new InvalidDataException("Unknown parameter type");
         }
▶        switch (type.Type)
         {
             case T2IParamDataType.INTEGER:
                 if (!long.TryParse(val, out long valInt))

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Text2Image\T2IParamTypes.cs (line 679)

         {
             throw new InvalidDataException("Unknown parameter type");
         }
▶        switch (type.Type)
         {
             case T2IParamDataType.INTEGER:
                 if (!long.TryParse(val, out long valInt))

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 10 hits

📄 src\Core\Program.cs (line 236)

             Thread.Sleep(500);
             try
             {
▶                switch (LaunchMode.Trim().ToLowerFast())
                 {
                     case "web":
                         Logs.Init("Launch web browser...");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Core\Program.cs (line 488)

     public static void ApplyCommandLineSettings()
     {
         ReapplySettings();
▶        string environment = GetCommandLineFlag("environment", "production").ToLowerFast() switch
         {
             "dev" or "development" => "Development",
             "prod" or "production" => "Production",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS032 Thread.Sleep used in async method 2 hits

📄 src\Backends\BackendHandler.cs (line 654)

                         Logs.Info($"Backend {backend.ID} ({backend.Backend.HandlerTypeData.Name}) has been locked in use for at least 5 seconds after shutdown, giving up and killing anyway.");
                         break;
                     }
▶                    Thread.Sleep(100);
                 }
                 tasks.Add((backend, backend.Backend.DoShutdownNow()));
             })));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\Backends\BackendHandler.cs (line 654)

                         Logs.Info($"Backend {backend.ID} ({backend.Backend.HandlerTypeData.Name}) has been locked in use for at least 5 seconds after shutdown, giving up and killing anyway.");
                         break;
                     }
▶                    Thread.Sleep(100);
                 }
                 tasks.Add((backend, backend.Backend.DoShutdownNow()));
             })));

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 28 hits

📄 src\BuiltinExtensions\AutoWebUIBackend\AutoWebUISelfStartBackend.cs (line 45)

                 Status = BackendStatus.ERRORED;
                 return;
             }
▶            string scrContent = File.ReadAllText(settings.StartScript);
             if (!scrContent.Contains("%*") && !scrContent.Contains("%~")) // on Windows, it's only valid if you forward swarm's CLI args
             {
                 Logs.Error($"Refusing init of AutoWebUI with 'webui-user.bat' target script. Please use the 'webui.bat' script instead. (If webui-user.bat usage is intentional, please forward CLI args, eg 'COMMANDLINE_ARGS=%*'.");

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\BuiltinExtensions\StabilityAPI\StabilityAPIBackend.cs (line 43)

             Status = BackendStatus.DISABLED;
             return;
         }
▶        Key = File.ReadAllText(fn).Trim();
         WebClient = NetworkBackendUtils.MakeHttpClient();
         WebClient.DefaultRequestHeaders.Add("Authorization", $"Bearer {Key}");
         await UpdateBalance();

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 14 hits

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIRedirectHelper.cs (line 115)

         ComfyUIBackendExtension.ComfyBackendData backend = ComfyUIBackendExtension.ComfyBackendsDirect().First();
         try
         {
▶            JObject result = backend.Client.GetAsync($"{backend.Address}/object_info", Utilities.TimedCancel(TimeSpan.FromMinutes(1))).Result.Content.ReadAsStringAsync().Result.ParseToJson();
             if (result is not null)
             {
                 LastObjectInfo = result;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIRedirectHelper.cs (line 115)

         ComfyUIBackendExtension.ComfyBackendData backend = ComfyUIBackendExtension.ComfyBackendsDirect().First();
         try
         {
▶            JObject result = backend.Client.GetAsync($"{backend.Address}/object_info", Utilities.TimedCancel(TimeSpan.FromMinutes(1))).Result.Content.ReadAsStringAsync().Result.ParseToJson();
             if (result is not null)
             {
                 LastObjectInfo = result;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS035 Synchronous task wait instead of await 6 hits

📄 src\BuiltinExtensions\GridGenerator\GridGeneratorExtension.cs (line 216)

             if (requests < Program.ServerSettings.Backends.MaxRequestsForcedOrder)
             {
                 Logs.Debug($"Grid Gen micro-pausing to maintain order as {requests} < {Program.ServerSettings.Backends.MaxRequestsForcedOrder}");
▶                Task.Delay(20).Wait(); // Tiny few-ms delay to encourage tasks retaining order.
             }
             return t;
         };

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

📄 src\Backends\SwarmSwarmBackend.cs (line 443)

                 if (user_input.InterruptToken.IsCancellationRequested)
                 {
                     // TODO: This will require separate remote sessions per-user for multiuser support
▶                    HttpClient.PostJson($"{Address}/API/InterruptAll", new JObject()
                     {
                         ["session_id"] = Session,
                         ["other_sessions"] = false

💬 Asynchronously wait for task completion using await instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS035-SynchronousTaskWait.md)

SS037 HttpClient instantiated directly 2 hits

📄 src\Backends\NetworkBackendUtils.cs (line 21)

     /// <summary>Create and preconfigure a basic <see cref="HttpClient"/> instance to make web requests with.</summary>
     public static HttpClient MakeHttpClient()
     {
▶        HttpClient client = new(new SocketsHttpHandler() { PooledConnectionLifetime = TimeSpan.FromMinutes(10) });
         client.DefaultRequestHeaders.UserAgent.ParseAdd($"StableSwarmUI/{Utilities.Version}");
         client.Timeout = TimeSpan.FromMinutes(10);
         return client;

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 src\Backends\NetworkBackendUtils.cs (line 21)

     /// <summary>Create and preconfigure a basic <see cref="HttpClient"/> instance to make web requests with.</summary>
     public static HttpClient MakeHttpClient()
     {
▶        HttpClient client = new(new SocketsHttpHandler() { PooledConnectionLifetime = TimeSpan.FromMinutes(10) });
         client.DefaultRequestHeaders.UserAgent.ParseAdd($"StableSwarmUI/{Utilities.Version}");
         client.Timeout = TimeSpan.FromMinutes(10);
         return client;

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 10 hits

📄 src\WebAPI\APICallReflectBuilder.cs (line 25)

         [typeof(bool)] = (JToken input) => (bool.TryParse(input.ToString(), out bool output), output),
         [typeof(byte)] = (JToken input) => (byte.TryParse(input.ToString(), out byte output), output),
         [typeof(char)] = (JToken input) => (char.TryParse(input.ToString(), out char output), output),
▶        [typeof(string[])] = (JToken input) => (true, input.ToList().Select(j => j.ToString()).ToArray())
     };
 
     public static APICall BuildFor(object obj, MethodInfo method, bool isUserUpdate)

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\BuiltinExtensions\ComfyUIBackend\ComfyUIWebAPI.cs (line 97)

     /// <summary>API route to read a list of available Comfy custom workflows.</summary>
     public static async Task<JObject> ComfyListWorkflows()
     {
▶        return new JObject() { ["workflows"] = JToken.FromObject(ComfyUIBackendExtension.CustomWorkflows.Keys.ToList()
             .Select(ComfyUIBackendExtension.GetWorkflowByName).OrderBy(w => w.Name).Select(w => new JObject()
             {
                 ["name"] = w.Name,

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS051 Locking on mutable reference 92 hits

📄 src\Accounts\User.cs (line 54)

     public void Save()
     {
         Data.RawSettings = Settings.Save(false).ToString();
▶        lock (SessionHandlerSource.DBLock)
         {
             SessionHandlerSource.UserDatabase.Upsert(Data);
         }

💬 A lock was obtained on DBLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\Accounts\User.cs (line 63)

     /// <summary>Returns the user generic-data for the given name, or null if not found.</summary>
     public string GetGenericData(string dataname, string name)
     {
▶        lock (SessionHandlerSource.DBLock)
         {
             return SessionHandlerSource.GenericData.FindById($"{UserID}///${dataname}///{name.ToLowerFast()}")?.Data;
         }

SS057 Collection manipulated during traversal 4 hits

📄 src\BuiltinExtensions\ImageBatchTool\ImageBatchToolExtension.cs (line 104)

                     {
                         Logs.Error($"Image generation failed: {tasks[i].Exception}");
                     }
▶                    tasks.RemoveAt(i--);
                 }
             }
         }

📄 src\WebAPI\T2IAPI.cs (line 215)

                     {
                         Logs.Error($"Image generation failed: {tasks[i].Exception}");
                     }
▶                    tasks.RemoveAt(i--);
                 }
             }
         }

SS058 String concatenated in a loop 26 hits

📄 src\BuiltinExtensions\AutoWebUIBackend\AutoWebUIAPIAbstractBackend.cs (line 88)

                 {
                     lora = lora.BeforeLast('.');
                 }
▶                promptAdd += $"<lora:{lora}:{loraWeights[i]}>";
             }
         }
         JObject toSend = new()

📄 src\BuiltinExtensions\GridGenerator\GridGenCore.cs (line 216)

                     }
                     if (key.Length < 4 || keys.Contains(key))
                     {
▶                        key = $"{key}{index}";
                     }
                     while (keys.Contains(key)) // Backup for if there's a key that looks like the indexed key of another value for some reason
                     {

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 src\Utils\Utilities.cs (line 208)

     public static async Task<byte[]> ReceiveData(this WebSocket socket, int maxBytes, CancellationToken limit)
     {
         byte[] buffer = new byte[8192];
▶        using MemoryStream ms = new();
         WebSocketReceiveResult result;
         do
         {

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Utils\Utilities.cs (line 510)

     public static async Task DownloadFile(string url, string filepath, Action<long, long> progressUpdate, string altUrl = null)
     {
         altUrl ??= url;
▶        using FileStream writer = File.OpenWrite(filepath);
         using HttpResponseMessage response = await UtilWebClient.SendAsync(new HttpRequestMessage(HttpMethod.Get, url), HttpCompletionOption.ResponseHeadersRead, Program.GlobalProgramCancel);
         long length = response.Content.Headers.ContentLength ?? 0;
         byte[] buffer = new byte[Math.Min(length + 1024, 1024 * 1024 * 64)]; // up to 64 megabytes, just grab as big a chunk as we can at a time

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 2 hits

📄 src\Backends\BackendHandler.cs (line 384)

     /// <summary>Loads the backends list from a file.</summary>
     public void Load()
     {
▶        if (T2IBackends.Any()) // Backup to prevent duplicate calls
         {
             return;
         }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 src\Backends\BackendHandler.cs (line 384)

     /// <summary>Loads the backends list from a file.</summary>
     public void Load()
     {
▶        if (T2IBackends.Any()) // Backup to prevent duplicate calls
         {
             return;
         }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

SS066 Disposable field is not disposed 2 hits

📄 src\Accounts\Session.cs (line 67)

         public CancellationToken InterruptToken;
 
         /// <summary>Token source to interrupt just this claim's set.</summary>
▶        public CancellationTokenSource LocalClaimInterrupt = new();
 
         /// <summary>Unique claim ID from an incremental number.</summary>
         public long ID = Interlocked.Increment(ref ClaimID);

💬 Disposable field LocalClaimInterrupt in type GenClaim is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Accounts\Session.cs (line 67)

         public CancellationToken InterruptToken;
 
         /// <summary>Token source to interrupt just this claim's set.</summary>
▶        public CancellationTokenSource LocalClaimInterrupt = new();
 
         /// <summary>Unique claim ID from an incremental number.</summary>
         public long ID = Interlocked.Increment(ref ClaimID);

💬 Disposable field LocalClaimInterrupt in type GenClaim is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

winsw

230 total diagnostics across 10 rules

SS001 Async method with void return type 8 hits

📄 src\WinSW.Core\LogAppenders.cs (line 132)

 
         protected abstract Task LogError(StreamReader errorReader);
 
▶        private async void SafeLogOutput(StreamReader outputReader)
         {
             try
             {

💬 Method SafeLogOutput is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\WinSW.Core\LogAppenders.cs (line 144)

             }
         }
 
▶        private async void SafeLogError(StreamReader errorReader)
         {
             try
             {

💬 Method SafeLogError is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 24 hits

📄 src\WinSW.Core\PeriodicRollingCalendar.cs (line 17)

         {
             this.format = format;
             this.period = period;
▶            this.currentRoll = DateTime.Now;
         }
 
         public void Init()

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\WinSW.Core\LogAppenders.cs (line 447)

                         {
                             writer.Dispose();
 
▶                            var now = DateTime.Now.AddDays(-1);
                             int nextFileNumber = this.GetNextFileNumber(extension, baseDirectory, baseFileName, now);
                             string? nextFileName = Path.Combine(baseDirectory, string.Format("{0}.{1}.#{2:D4}{3}", baseFileName, now.ToString(this.FilePattern), nextFileNumber, extension));
                             File.Move(logFile, nextFileName);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 src\WinSW.Tasks\Trim.cs (line 45)

                     continue;
                 }
 
▶                if (this.usedTypes.Contains(type))
                 {
                     continue;
                 }

💬 Type TypeDefinition is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\WinSW.Tasks\Trim.cs (line 82)

 
             if (typeRef is TypeDefinition typeDef)
             {
▶                if (!this.usedTypes.Add(typeDef))
                 {
                     return;
                 }

SS017 Struct without Equals/GetHashCode/ToString overridden 108 hits

📄 src\WinSW.Core\Configuration\ProcessCommand.cs (line 3)

 namespace WinSW
 {
▶    public struct ProcessCommand
     {
         public string? Executable;
         public string? Arguments;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ProcessCommand. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\WinSW.Core\Native\FileTime.cs (line 5)

 
 namespace WinSW.Native
 {
▶    internal struct FileTime
     {
         internal int LowDateTime;
         internal int HighDateTime;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FileTime. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 4 hits

📄 src\WinSW.Core\WrapperService.cs (line 372)

                 var process = this.process;
                 Log.Debug("ProcessKill " + process.Id);
                 bool? result = process.Stop(this.config.StopTimeoutInMs);
▶                this.LogMinimal($"Child process '{process.Format()}' " + result switch
                 {
                     true => $"canceled with code {process.ExitCode}.",
                     false => "terminated.",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\WinSW.Core\WrapperService.cs (line 372)

                 var process = this.process;
                 Log.Debug("ProcessKill " + process.Id);
                 bool? result = process.Stop(this.config.StopTimeoutInMs);
▶                this.LogMinimal($"Child process '{process.Format()}' " + result switch
                 {
                     true => $"canceled with code {process.ExitCode}.",
                     false => "terminated.",

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 24 hits

📄 src\WinSW.Core\Configuration\XmlServiceConfig.cs (line 299)

                         var patternNode = e.SelectSingleNode("pattern");
                         if (patternNode is null)
                         {
▶                            throw new InvalidDataException("Time Based rolling policy is specified but no pattern can be found in configuration XML.");
                         }
 
                         string? pattern = patternNode.InnerText;

💬 An exception is thrown from the getter of property LogHandler (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\WinSW.Core\Configuration\XmlServiceConfig.cs (line 319)

                         var filePatternNode = e.SelectSingleNode("pattern");
                         if (filePatternNode is null)
                         {
▶                            throw new InvalidDataException("Roll-Size-Time Based rolling policy is specified but no pattern can be found in configuration XML.");
                         }
 
                         var autoRollAtTimeNode = e.SelectSingleNode("autoRollAtTime");

💬 An exception is thrown from the getter of property LogHandler (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 30 hits

📄 src\WinSW.Core\LogAppenders.cs (line 675)

                 {
                     int count = newLineIndex - startIndex + 1;
                     total += count;
▶                    destination.Write(buffer, startIndex, count);
                     destination.Flush();
                     startIndex = (newLineIndex + 1) % BufferSize;
                     break;

💬 Async overload available for Stream.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\WinSW.Core\LogAppenders.cs (line 676)

                     int count = newLineIndex - startIndex + 1;
                     total += count;
                     destination.Write(buffer, startIndex, count);
▶                    destination.Flush();
                     startIndex = (newLineIndex + 1) % BufferSize;
                     break;
                 }

💬 Async overload available for Stream.Flush (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS048 Locking on discouraged object (string, Type, this) 12 hits

📄 src\WinSW.Core\WrapperService.cs (line 326)

 
                     Process StartProcessLocked()
                     {
▶                        lock (this)
                         {
                             return this.startingProcess = this.StartProcess(poststartExecutable, poststart.Arguments, poststart.CreateLogHandler());
                         }

📄 src\WinSW.Core\WrapperService.cs (line 446)

 
             Process StartProcessLocked(string executable, string? arguments, LogHandler? logHandler = null)
             {
▶                lock (this)
                 {
                     return this.stoppingProcess = this.StartProcess(executable, arguments, logHandler);
                 }

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\WinSW.Core\Download.cs (line 173)

             try
             {
                 using (var response = await request.GetResponseAsync().ConfigureAwait(false))
▶                using (var responseStream = response.GetResponseStream())
                 using (var tmpStream = new FileStream(tmpFilePath, FileMode.Create))
                 {
                     if (supportsIfModifiedSince)

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\WinSW.Core\Download.cs (line 174)

             {
                 using (var response = await request.GetResponseAsync().ConfigureAwait(false))
                 using (var responseStream = response.GetResponseStream())
▶                using (var tmpStream = new FileStream(tmpFilePath, FileMode.Create))
                 {
                     if (supportsIfModifiedSince)
                     {

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 12 hits

📄 src\WinSW.Core\WrapperService.cs (line 27)

 
         private readonly XmlServiceConfig config;
 
▶        private Process process = null!;
         private volatile Process? startingProcess;
         private volatile Process? stoppingProcess;

💬 Disposable field process in type WrapperService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\WinSW.Core\WrapperService.cs (line 28)

         private readonly XmlServiceConfig config;
 
         private Process process = null!;
▶        private volatile Process? startingProcess;
         private volatile Process? stoppingProcess;
 
         internal WinSWExtensionManager ExtensionManager { get; }

💬 Disposable field startingProcess in type WrapperService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

XUnity.AutoTranslator

224 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\XUnity.AutoTranslator.Plugin.Core\Web\Internal\ConnectionTrackingWebClient.cs (line 1535)

          {
             str = "application/octet-stream";
          }
▶         string str3 = "------------" + DateTime.Now.Ticks.ToString( "x" );
          this.Headers[ "Content-Type" ] = string.Format( "multipart/form-data; boundary={0}", str3 );
          Stream requestStream = null;
          Stream stream2 = null;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\TextTranslationCache.cs (line 156)

 
          if( anyChanges )
          {
▶            var backupFileName = input.FullName + "." + DateTime.Now.ToString( "yyyyMMddHHmmssfff.bak" );
             File.Move( input.FullName, backupFileName );
 
             using( var outputFile = new FileStream( input.FullName, FileMode.Create ) )

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 18 hits

📄 src\Translators\Common.ExtProtocol\Utilities\SimpleJson.cs (line 399)

       {
          var sb = EscapeBuilder;
          sb.Length = 0;
▶         if( sb.Capacity < aText.Length + aText.Length / 10 )
             sb.Capacity = aText.Length + aText.Length / 10;
          foreach( char c in aText )
          {

💬 The operands in the divisive expression aText.Length / 10 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Translators\Common.ExtProtocol\Utilities\SimpleJson.cs (line 400)

          var sb = EscapeBuilder;
          sb.Length = 0;
          if( sb.Capacity < aText.Length + aText.Length / 10 )
▶            sb.Capacity = aText.Length + aText.Length / 10;
          foreach( char c in aText )
          {
             switch( c )

SS004 Elementary methods of type in collection not overridden 24 hits

📄 src\XUnity.Common\Utilities\ExtensionDataHelper.cs (line 61)

 #if IL2CPP
             if( obj is Il2CppObjectBase obj2 )
             {
▶               if( DynamicFields.TryGetValue( obj2, out object value ) )
                {
                   if( value is Dictionary<Type, object> existingDictionary )
                   {

💬 Type Il2CppObjectBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\XUnity.Common\Utilities\ExtensionDataHelper.cs (line 72)

                      var newDictionary = new Dictionary<Type, object>();
                      newDictionary.Add( value.GetType(), value );
                      newDictionary[ typeof( T ) ] = t;
▶                     DynamicFields[ obj2 ] = newDictionary;
                   }
                }
                else

SS008 GetHashCode() refers to mutable or static member 22 hits

📄 src\XUnity.RuntimeHooker.Core\Utilities\ReflectionCache.cs (line 91)

          // override object.GetHashCode
          public override int GetHashCode()
          {
▶            return Type.GetHashCode() + MemberName.GetHashCode();
          }
       }
    }

💬 GetHashCode() refers to mutable property Type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\XUnity.RuntimeHooker.Core\Utilities\ReflectionCache.cs (line 91)

          // override object.GetHashCode
          public override int GetHashCode()
          {
▶            return Type.GetHashCode() + MemberName.GetHashCode();
          }
       }
    }

💬 GetHashCode() refers to mutable property MemberName (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 26 hits

📄 src\XUnity.RuntimeHooker.Core\Utilities\ReflectionCache.cs (line 66)

          return cachedMember;
       }
 
▶      public struct MemberLookupKey
       {
          public MemberLookupKey( Type type, string memberName )
          {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemberLookupKey. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Translators\Common.ExtProtocol\Utilities\SimpleJson.cs (line 55)

    public abstract partial class JSONNode
    {
       #region Enumerators
▶      public struct Enumerator
       {
          private enum Type { None, Array, Object }
          private Type type;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Enumerator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 30 hits

📄 src\XUnity.Common\Utilities\UnityInput.cs (line 213)

 
         private static ButtonControl GetControl(KeyCode key, bool silent = false)
         {
▶            switch (key)
             {
                 case KeyCode.None:
                     break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\Utilities\DynamicQueryable.cs (line 645)

                CheckAndPromoteOperands( isEquality ? typeof( IEqualitySignatures ) : typeof( IRelationalSignatures ),
                    op.text, ref left, ref right, op.pos );
             }
▶            switch( op.id )
             {
                case TokenId.Equal:
                case TokenId.DoubleEqual:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 32 hits

📄 src\XUnity.Common\Utilities\UnityInput.cs (line 213)

 
         private static ButtonControl GetControl(KeyCode key, bool silent = false)
         {
▶            switch (key)
             {
                 case KeyCode.None:
                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\Utilities\DynamicQueryable.cs (line 645)

                CheckAndPromoteOperands( isEquality ? typeof( IEqualitySignatures ) : typeof( IRelationalSignatures ),
                    op.text, ref left, ref right, op.pos );
             }
▶            switch( op.id )
             {
                case TokenId.Equal:
                case TokenId.DoubleEqual:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 src\XUnity.AutoTranslator.Plugin.Core\Web\Internal\ConnectionTrackingWebClient.cs (line 1941)

       {
          get
          {
▶            throw GetMustImplement();
          }
          set
          {

💬 An exception is thrown from the getter of property CachePolicy (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\Web\Internal\ConnectionTrackingWebClient.cs (line 2041)

       {
          get
          {
▶            throw GetMustImplement();
          }
          set
          {

💬 An exception is thrown from the getter of property UseDefaultCredentials (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 4 hits

📄 src\Translators\Common.ExtProtocol.Executor\ExtProtocolHandler.cs (line 58)

 
                while( true )
                {
▶                  var receivedPayload = reader.ReadLine();
                   if( string.IsNullOrEmpty( receivedPayload ) ) return;
 
                   var message = ExtProtocolConvert.Decode( receivedPayload );

💬 Async overload available for StreamReader.ReadLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Translators\Common.ExtProtocol.Executor\ExtProtocolHandler.cs (line 110)

                      }
 
                      var translatedPayload = ExtProtocolConvert.Encode( response );
▶                     writer.WriteLine( translatedPayload );
                   }
                   else
                   {

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 src\XUnity.Common\Utilities\HookingHelperPriorityAttribute.cs (line 11)

    /// <summary>
    /// WARNING: Pubternal API (internal). Do not use. May change during any update.
    /// </summary>
▶   public class HookingHelperPriorityAttribute : Attribute
    {
       /// <summary>
       /// WARNING: Pubternal API (internal). Do not use. May change during any update.

💬 HookingHelperPriorityAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\XUnity.Common\Utilities\HookingHelperPriorityAttribute.cs (line 11)

    /// <summary>
    /// WARNING: Pubternal API (internal). Do not use. May change during any update.
    /// </summary>
▶   public class HookingHelperPriorityAttribute : Attribute
    {
       /// <summary>
       /// WARNING: Pubternal API (internal). Do not use. May change during any update.

💬 HookingHelperPriorityAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS050 Parameter assigned in constructor 4 hits

📄 src\XUnity.AutoTranslator.Plugin.Core\UntranslatedText.cs (line 208)

                TemplatedText = originalText.TemplatizeByNumbers();
                if( TemplatedText != null )
                {
▶                  originalText = TemplatedText.Template;
                }
             }
             else

💬 Suspicious assignment of parameter originalText in constructor of UntranslatedText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\UntranslatedText.cs (line 216)

                TemplatedText = templateAllNumbersAway ? originalText.TemplatizeByReplacementsAndNumbers() : originalText.TemplatizeByReplacements();
                if( TemplatedText != null )
                {
▶                  originalText = TemplatedText.Template;
                }
             }
          }

💬 Suspicious assignment of parameter originalText in constructor of UntranslatedText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS051 Locking on mutable reference 14 hits

📄 src\XUnity.AutoTranslator.Plugin.Core\SafeFileWatcher.cs (line 86)

 
       private void UpdateRaisingEvents( bool enabled )
       {
▶         lock( _sync )
          {
             if( enabled )
             {

💬 A lock was obtained on _sync but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 src\XUnity.AutoTranslator.Plugin.Core\SimpleTextTranslationCache.cs (line 284)

 
       private void QueueNewTranslationForDisk( string key, string value, bool hadTranslated )
       {
▶         lock( _newTranslations )
          {
             _newTranslations[ key ] = value;
 

💬 A lock was obtained on _newTranslations but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS057 Collection manipulated during traversal 4 hits

📄 src\XUnity.Common\Extensions\StringExtensions.cs (line 87)

                   var previousIndex = i - 1;
                   if( previousIndex >= 0 )
                   {
▶                     fileDirs.RemoveAt( i );
                      fileDirs.RemoveAt( previousIndex );
                      i -= 2;
                   }

📄 src\XUnity.Common\Extensions\StringExtensions.cs (line 88)

                   if( previousIndex >= 0 )
                   {
                      fileDirs.RemoveAt( i );
▶                     fileDirs.RemoveAt( previousIndex );
                      i -= 2;
                   }
                }

SS058 String concatenated in a loop 18 hits

📄 src\Translators\GoogleTranslateCompat.ExtProtocol\GoogleTranslateCompatTranslate.cs (line 145)

                   if( current >= translatedLines.Length ) context.Fail( "Batch operation received incorrect number of translations." );
 
                   var translatedLine = translatedLines[ current++ ];
▶                  translatedText += translatedLine;
 
                   if( i != untranslatedLinesCount - 1 ) translatedText += '\n';
                }

📄 src\Translators\GoogleTranslateCompat.ExtProtocol\GoogleTranslateCompatTranslate.cs (line 147)

                   var translatedLine = translatedLines[ current++ ];
                   translatedText += translatedLine;
 
▶                  if( i != untranslatedLinesCount - 1 ) translatedText += '\n';
                }
 
                translatedTexts.Add( translatedText );

SS066 Disposable field is not disposed 18 hits

📄 src\Translators\DeepLTranslate.ExtProtocol\ExtDeepLTranslate.cs (line 83)

       private static readonly string Referer = Referers[ RandomNumbers.Next( Referers.Length ) ];
       private static readonly string Origin = Origins[ RandomNumbers.Next( Origins.Length ) ];
 
▶      private SemaphoreSlim _sem;
 
       private HttpClient _client;
       private HttpClientHandler _handler;

💬 Disposable field _sem in type ExtDeepLTranslate is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Translators\DeepLTranslate.ExtProtocol\ExtDeepLTranslate.cs (line 85)

 
       private SemaphoreSlim _sem;
 
▶      private HttpClient _client;
       private HttpClientHandler _handler;
       private bool _hasSetup = false;
       private int _translationCount = 0;

💬 Disposable field _client in type ExtDeepLTranslate is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

WeiXinMPSDK

224 total diagnostics across 10 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Tools\ForTestController.cs (line 33)

 
             Response.Cookies.Append("TestCookie", SystemTime.Now.ToString());
 
▶            return Content(data + " Ajax:" + isAjax + " Server Time:" + DateTime.Now);
         }
 
         [HttpGet]

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Tools\ForTestController.cs (line 43)

 
             Response.Cookies.Append("TestCookie", SystemTime.Now.ToString());
 
▶            return Content(data + " Ajax:" + isAjax + " Server Time:" + DateTime.Now);
         }
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\WeixinController_OldPost.cs (line 191)

             //根据MsgId去重结束
 
             string responseXml = null;//响应消息XML
▶            var responseTime = (SystemTime.Now.Ticks - new DateTime(1970, 1, 1).Ticks) / 10000000 - 8 * 60 * 60;
 
             switch (msgType)
             {

💬 The operands in the divisive expression (SystemTime.Now.Ticks - new DateTime(1970, 1, 1).Ticks) / 10000000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\WeixinController_OldPost.cs (line 191)

             //根据MsgId去重结束
 
             string responseXml = null;//响应消息XML
▶            var responseTime = (SystemTime.Now.Ticks - new DateTime(1970, 1, 1).Ticks) / 10000000 - 8 * 60 * 60;
 
             switch (msgType)
             {

SS004 Elementary methods of type in collection not overridden 12 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\HomeController.cs (line 62)

             sdkList.Add(new Home_IndexVD_AssemblyModel("开放平台", "Senparc.Weixin.Open", typeof(Senparc.Weixin.Open.Register), gitHubUrl: sdkGitHubUrl));
             //TempData["QYVersion"] = getDisplayVersion(getFileVersionInfo("Senparc.Weixin.QY.dll"));//已经停止更新
             sdkList.Add(new Home_IndexVD_AssemblyModel("企业微信", "Senparc.Weixin.Work", typeof(Senparc.Weixin.Work.Register), gitHubUrl: sdkGitHubUrl));
▶            vd.AssemblyModelCollection[sdkGroup] = sdkList;
 
 
             var aspnetGroup = new Home_IndexVD_GroupInfo()

💬 Type Home_IndexVD_GroupInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\HomeController.cs (line 77)

             aspnetList.Add(new Home_IndexVD_AssemblyModel("公众号消息中间件", "Senparc.Weixin.MP.Middleware", typeof(Senparc.Weixin.MP.MessageHandlers.Middleware.MessageHandlerMiddlewareExtension), gitHubUrl: sdkGitHubUrl));
             aspnetList.Add(new Home_IndexVD_AssemblyModel("小程序消息中间件", "Senparc.Weixin.WxOpen.Middleware", typeof(Senparc.Weixin.WxOpen.MessageHandlers.Middleware.MessageHandlerMiddlewareExtension), gitHubUrl: sdkGitHubUrl));
             aspnetList.Add(new Home_IndexVD_AssemblyModel("企业微信消息中间件", "Senparc.Weixin.Work.Middleware", typeof(Senparc.Weixin.Work.MessageHandlers.Middleware.MessageHandlerMiddlewareExtension), gitHubUrl: sdkGitHubUrl));
▶            vd.AssemblyModelCollection[aspnetGroup] = aspnetList;
 
             var cacheAndExtensionGroup = new Home_IndexVD_GroupInfo()
             {

SS032 Thread.Sleep used in async method 2 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Tools\SimulateToolController.cs (line 315)

             }
 
             var responseMessageXml = await MessageAgent.RequestXmlAsync(null, _serviceProvider, url, token, requestMessaageDoc.ToString(), autoFillUrlParameters, 1000 * 20);
▶            Thread.Sleep(sleepMillionSeconds); //模拟服务器响应时间
 
             _responseMessageXml = responseMessageXml;
             return responseMessageXml;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Tools\SimulateToolController.cs (line 315)

             }
 
             var responseMessageXml = await MessageAgent.RequestXmlAsync(null, _serviceProvider, url, token, requestMessaageDoc.ToString(), autoFillUrlParameters, 1000 * 20);
▶            Thread.Sleep(sleepMillionSeconds); //模拟服务器响应时间
 
             _responseMessageXml = responseMessageXml;
             return responseMessageXml;

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 54 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\WeixinController.cs (line 138)

 
                 using (TextWriter tw = new StreamWriter(ServerUtility.ContentRootMapPath("~/App_Data/Error_" + _getRandomFileName() + ".txt")))
                 {
▶                    tw.WriteLine("ExecptionMessage:" + ex.Message);
                     tw.WriteLine(ex.Source);
                     tw.WriteLine(ex.StackTrace);
                     //tw.WriteLine("InnerExecptionMessage:" + ex.InnerException.Message);

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\WeixinController.cs (line 139)

                 using (TextWriter tw = new StreamWriter(ServerUtility.ContentRootMapPath("~/App_Data/Error_" + _getRandomFileName() + ".txt")))
                 {
                     tw.WriteLine("ExecptionMessage:" + ex.Message);
▶                    tw.WriteLine(ex.Source);
                     tw.WriteLine(ex.StackTrace);
                     //tw.WriteLine("InnerExecptionMessage:" + ex.InnerException.Message);
 

💬 Async overload available for TextWriter.WriteLine (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 8 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\AsyncMethodsController.cs (line 88)

         public ActionResult DeadLockTest()
         {
             var result =
▶                RequestUtility.HttpGetAsync(CommonDI.CommonSP, "https://sdk.weixin.senparc.com",
                     cookieContainer: null).Result;
             return Content(result);
         }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\AsyncMethodsController.cs (line 122)

         /// <returns></returns>
         public ActionResult DeadLockTest2()
         {
▶            var result = GetRemoteData().Result;
             return Content(result);
         }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 4 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Tools\SimulateToolController.cs (line 298)

             }
 
             //修改文字内容
▶            if (requestMessaageDoc.Root.Element("MsgType") != null && requestMessaageDoc.Root.Element("MsgType").Value.ToUpper() == "TEXT")
             {
                 var values = requestMessaageDoc.Root.Element("Content").Value.Split('|').Select(z => z.Trim()).ToList();
                 if (values.Count == 1)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\TenPay\TenPayV3Controller.cs (line 489)

 
                 resHandler.SetKey(TenPayV3Info.Key);
                 //验证请求是否从微信发过来（安全）
▶                if (resHandler.IsTenpaySign() && return_code.ToUpper() == "SUCCESS")
                 {
                     res = "success";//正确的订单处理
                     //直到这里，才能认为交易真正成功了，可以进行数据库操作，但是别忘了返回规定格式的消息！

SS056 HttpRequest.Form read synchronously 112 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\TenPay\TenPayController.cs (line 97)

             string packageValue = null;
             string paySign = null;
 
▶            string sp_billno = Request.Form["order_no"];
             //当前时间 yyyyMMdd
             string date = SystemTime.Now.ToString("yyyyMMdd");
 

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\TenPay\TenPayController.cs (line 108)

             }
             else
             {
▶                sp_billno = Request.Form["order_no"].ToString();
             }
 
             sp_billno = TenPayInfo.PartnerId + sp_billno;

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS059 IAsyncDisposable not disposed asynchronously 16 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\WxOpen\WxOpenController.cs (line 119)

             }
             catch (Exception ex)
             {
▶                using (TextWriter tw = new StreamWriter(ServerUtility.ContentRootMapPath("~/App_Data/Error_WxOpen_" + _getRandomFileName() + ".txt")))
                 {
                     await tw.WriteLineAsync("ExecptionMessage:" + ex.Message);
                     await tw.WriteLineAsync(ex.Source);

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\MP\WeixinController.cs (line 136)

                 #region 异常处理
                 WeixinTrace.Log("MessageHandler错误：{0}", ex.Message);
 
▶                using (TextWriter tw = new StreamWriter(ServerUtility.ContentRootMapPath("~/App_Data/Error_" + _getRandomFileName() + ".txt")))
                 {
                     tw.WriteLine("ExecptionMessage:" + ex.Message);
                     tw.WriteLine(ex.Source);

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 2 hits

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\TenPay\TenPayV3Controller.cs (line 998)

             }
         }
 
▶        private Stream _fileStream = null;
 
         /// <summary>
         /// 显示二维码

💬 Disposable field _fileStream in type TenPayV3Controller is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Samples\All\net10-mvc\Senparc.Weixin.Sample.Net10\Controllers\Weixin\TenPay\TenPayV3Controller.cs (line 998)

             }
         }
 
▶        private Stream _fileStream = null;
 
         /// <summary>
         /// 显示二维码

💬 Disposable field _fileStream in type TenPayV3Controller is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

VPet

222 total diagnostics across 13 rules

SS001 Async method with void return type 2 hits

📄 VPet-Simulator.Core\Graph\PNGAnimation.cs (line 110)

         /// </summary>
         public static int MaxLoadMemory = 2000;
 
▶        private async void startup(string path, FileInfo[] paths)
         {
             while (Function.MemoryUsage() > MaxLoadMemory)
             {

💬 Method startup is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 VPet-Simulator.Core\Graph\PNGAnimation.cs (line 110)

         /// </summary>
         public static int MaxLoadMemory = 2000;
 
▶        private async void startup(string path, FileInfo[] paths)
         {
             while (Function.MemoryUsage() > MaxLoadMemory)
             {

💬 Method startup is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 46 hits

📄 VPet-Simulator.Core\Display\MessageBar.xaml.cs (line 252)

         /// <summary>
         /// 流式传输用的阻断文字显示用的计时器
         /// </summary>
▶        DateTime nextshow = DateTime.Now;
         /// <summary>
         /// 增加显示新词
         /// </summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 VPet-Simulator.Core\Display\MainLogic.cs (line 31)

         /// <summary>
         /// 上次交互时间
         /// </summary>
▶        public DateTime LastInteractionTime { get; set; } = DateTime.Now;
         /// <summary>
         /// 事件Timer
         /// </summary>

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 VPet-Simulator.Core\Display\Main.xaml.cs (line 254)

             {
                 Dispatcher.Invoke(() =>
                 {
▶                    LabelDisplay.Opacity = labeldisplaycount / 50;
                 });
             }
         }

💬 The operands in the divisive expression labeldisplaycount / 50 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 VPet-Simulator.Core\Handle\GameSave.cs (line 268)

             if (Health <= realhel)
             {
                 //可以确认从状态不佳和生病二选一
▶                if (Health <= realhel / 2)
                 {//生病
                     return ModeType.Ill;
                 }

💬 The operands in the divisive expression realhel / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 114 hits

📄 VPet-Simulator.Core\Graph\FoodAnimation.cs (line 51)

 
         public static void LoadGraph(GraphCore graph, FileSystemInfo path, ILine info)
         {
▶            bool isLoop = info[(gbol)"loop"];
             FoodAnimation pa = new FoodAnimation(graph, new GraphInfo(path, info), info[(gstr)"front_lay"], info[(gstr)"back_lay"], info, isLoop);
             graph.AddGraph(pa);
         }

💬 Type gbol is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 VPet-Simulator.Core\Graph\FoodAnimation.cs (line 52)

         public static void LoadGraph(GraphCore graph, FileSystemInfo path, ILine info)
         {
             bool isLoop = info[(gbol)"loop"];
▶            FoodAnimation pa = new FoodAnimation(graph, new GraphInfo(path, info), info[(gstr)"front_lay"], info[(gstr)"back_lay"], info, isLoop);
             graph.AddGraph(pa);
         }
         /// <summary>

💬 Type gstr is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 VPet-Simulator.Core\Display\WorkTimer.xaml.cs (line 44)

         /// <summary>
         /// 完成工作信息
         /// </summary>
▶        public struct FinishWorkInfo
         {
             /// <summary>
             /// 当前完成工作

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FinishWorkInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 VPet-Simulator.Core\Display\WorkTimer.xaml.cs (line 44)

         /// <summary>
         /// 完成工作信息
         /// </summary>
▶        public struct FinishWorkInfo
         {
             /// <summary>
             /// 当前完成工作

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FinishWorkInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 VPet-Simulator.Core\Graph\GraphHelper.cs (line 475)

                 {
                     if (m.MoveTimerSmartMove)
                     {
▶                        switch (LocateType)
                         {
                             case DirectionType.Top:
                                 m.Core.Controller.MoveWindows(0, -m.Core.Controller.GetWindowsDistanceUp() / m.Core.Controller.ZoomRatio - LocateLength);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 VPet-Simulator.Core\Graph\GraphHelper.cs (line 475)

                 {
                     if (m.MoveTimerSmartMove)
                     {
▶                        switch (LocateType)
                         {
                             case DirectionType.Top:
                                 m.Core.Controller.MoveWindows(0, -m.Core.Controller.GetWindowsDistanceUp() / m.Core.Controller.ZoomRatio - LocateLength);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 14 hits

📄 VPet-Simulator.Core\Display\ToolBar.xaml.cs (line 347)

             {
                 clickCallback?.Invoke();
             };
▶            switch (parentMenu)
             {
                 case MenuType.Feed:
                     MenuFeed.Items.Add(menuItem);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 VPet-Simulator.Core\Graph\FoodAnimation.cs (line 171)

                 //然后等待帧时间毫秒
                 Thread.Sleep(Time);
                 //判断是否要下一步
▶                switch (Control.Type)
                 {
                     case TaskControl.ControlType.Stop:
                         Control.EndAction?.Invoke();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 2 hits

📄 VPet-Simulator.Core\Display\MainLogic.cs (line 62)

                 }
                 sayInfo.GraphName = SayRndFunction(sayInfo.CurrentText.ToString());
                 if (sayInfo.IsFinishGen)
▶                    Say(sayInfo.ToNoneStream().Result);
                 else
                     Say(sayInfo);
             });

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 VPet-Simulator.Core\Display\MainLogic.cs (line 62)

                 }
                 sayInfo.GraphName = SayRndFunction(sayInfo.CurrentText.ToString());
                 if (sayInfo.IsFinishGen)
▶                    Say(sayInfo.ToNoneStream().Result);
                 else
                     Say(sayInfo);
             });

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS051 Locking on mutable reference 4 hits

📄 VPet-Simulator.Core\Display\Main.xaml.cs (line 134)

                             {
                                 if (ig3.IsFail)
                                 {
▶                                    lock (ErrorMessage) // 确保线程安全
                                     {
                                         ErrorMessage.Add(ig3.FailMessage);
                                         ig2.Remove(ig3);

💬 A lock was obtained on ErrorMessage but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 VPet-Simulator.Core\Display\MessageBar.xaml.cs (line 263)

             Task.Run(() =>
             {
                 int sleeptime = 0;
▶                lock (oldsaystream)
                     if (DateTime.Now < nextshow)
                     {
                         sleeptime = (int)(nextshow - DateTime.Now).TotalMilliseconds;

💬 A lock was obtained on oldsaystream but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS057 Collection manipulated during traversal 6 hits

📄 VPet-Simulator.Core\Display\Main.xaml.cs (line 95)

                             if (ig3.IsFail)
                             {
                                 ErrorMessage.Add(ig3.FailMessage);
▶                                ig2.Remove(ig3);
                                 break;
                             }
                             else

📄 VPet-Simulator.Core\Display\MainDisplay.cs (line 116)

                 }
                 else
                 {
▶                    list.RemoveAt(i);
                 }
             }
             return false;

SS058 String concatenated in a loop 2 hits

📄 VPet-Simulator.Core\Display\MessageBar.xaml.cs (line 108)

 
                 for (int i = 0; i < batchSize; i++)
                 {
▶                    textToAdd += outputtext[0];
                     outputtext.RemoveAt(0);
                 }
                 outputtextsample.Append(textToAdd);

📄 VPet-Simulator.Core\Display\MessageBar.xaml.cs (line 108)

 
                 for (int i = 0; i < batchSize; i++)
                 {
▶                    textToAdd += outputtext[0];
                     outputtext.RemoveAt(0);
                 }
                 outputtextsample.Append(textToAdd);

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 VPet-Simulator.Core\Graph\PNGAnimation.cs (line 176)

                         // Save the combined image to the cache path
                         using (var image = SKImage.FromBitmap(combinedBitmap))
                         using (var data = image.Encode(SKEncodedImageFormat.Png, 100))
▶                        using (var stream = File.OpenWrite(Path))
                         {
                             data.SaveTo(stream);
                         }

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 VPet-Simulator.Core\Graph\PNGAnimation.cs (line 176)

                         // Save the combined image to the cache path
                         using (var image = SKImage.FromBitmap(combinedBitmap))
                         using (var data = image.Encode(SKEncodedImageFormat.Png, 100))
▶                        using (var stream = File.OpenWrite(Path))
                         {
                             data.SaveTo(stream);
                         }

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 16 hits

📄 VPet-Simulator.Core\Display\MessageBar.xaml.cs (line 67)

     public partial class MessageBar : UserControl, IDisposable, IMassageBar
     {
         public Control This => this;
▶        Main m;
         public MessageBar(Main m)
         {
             InitializeComponent();

💬 Disposable field m in type MessageBar is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 VPet-Simulator.Core\Display\Main.xaml.cs (line 52)

         /// 是否开始运行
         /// </summary>
         public bool IsWorking { get; private set; } = false;
▶        public SoundPlayer soundPlayer = new SoundPlayer();
         public bool windowMediaPlayerAvailable = true;
 
         public void Load_0_BaseConsole()

💬 Disposable field soundPlayer in type Main is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

slskd

206 total diagnostics across 11 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\slskd\Search\Types\Search.cs (line 56)

         }
 
         public string SearchText { get; init; }
▶        public DateTime StartedAt { get; init; } = DateTime.Now;
         public SearchStates State { get; set; }
         public int Token { get; init; }
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\slskd\Search\Types\Search.cs (line 56)

         }
 
         public string SearchText { get; init; }
▶        public DateTime StartedAt { get; init; } = DateTime.Now;
         public SearchStates State { get; set; }
         public int Token { get; init; }
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 26 hits

📄 src\slskd\Common\Cryptography\Aes.cs (line 31)

     public static class Aes
     {
         private static readonly int BlockSizeInBits = 128;
▶        private static readonly int BlockSizeInBytes = BlockSizeInBits / 8;
         private static readonly int KeySizeInBits = 256;
         private static readonly int KeySizeInBytes = KeySizeInBits / 8;
 

💬 The operands in the divisive expression BlockSizeInBits / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\slskd\Common\Cryptography\Aes.cs (line 33)

         private static readonly int BlockSizeInBits = 128;
         private static readonly int BlockSizeInBytes = BlockSizeInBits / 8;
         private static readonly int KeySizeInBits = 256;
▶        private static readonly int KeySizeInBytes = KeySizeInBits / 8;
 
         /// <summary>
         ///     Decrypts the specified <paramref name="encryptedBytes"/> with the specified <paramref name="key"/>.

💬 The operands in the divisive expression KeySizeInBits / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 30 hits

📄 src\slskd\Core\Data\ConnectionStringDictionary.cs (line 34)

 
     private Dictionary<Database, ConnectionString> Strings { get; } = [];
 
▶    public ConnectionString this[Database database] => Strings[database];
 }

💬 Type Database is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\slskd\Core\Data\Migrations\Z12282025_AdditionalTransferIndexesMigration.cs (line 32)

 {
     public Z12282025_AdditionalTransferIndexesMigration(ConnectionStringDictionary connectionStrings)
     {
▶        ConnectionString = connectionStrings[Database.Transfers];
     }
 
     private ILogger Log { get; } = Serilog.Log.ForContext<Z12282025_AdditionalTransferIndexesMigration>();

SS033 Async overload is available 54 hits

📄 src\slskd\Common\CommonExtensions.cs (line 57)

 
             if (completedTask == task)
             {
▶                timeoutCancellationTokenSource.Cancel();
                 return await task;
             }
             else

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\slskd\Common\CommonExtensions.cs (line 81)

 
             if (completedTask == task)
             {
▶                timeoutCancellationTokenSource.Cancel();
                 await task;
             }
             else

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 src\slskd\Core\Options.cs (line 1284)

                 try
                 {
                     // async not supported here, .Result is all we have
▶                    _ = slskd.Blacklist.DetectFormat(File).Result;
                 }
                 catch
                 {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\slskd\Core\Options.cs (line 1284)

                 try
                 {
                     // async not supported here, .Result is all we have
▶                    _ = slskd.Blacklist.DetectFormat(File).Result;
                 }
                 catch
                 {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 8 hits

📄 src\slskd\Common\Dumper.cs (line 97)

 
         private async Task Download(string url, string destination)
         {
▶            using var http = new HttpClient();
 
             using var localStream = new FileStream(destination, FileMode.OpenOrCreate);
             using var remoteStream = await http.GetStreamAsync(url);

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 src\slskd\Common\GitHub.cs (line 34)

 
             try
             {
▶                using var http = new HttpClient();
                 http.DefaultRequestHeaders.UserAgent.TryParseAdd(userAgent);
 
                 var response = await http.GetFromJsonAsync<JsonDocument>(url);

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 src\slskd\Shares\ShareService.cs (line 566)

                     return;
                 }
 
▶                var shares = options.Shares.Directories
                     .Select(share => share.TrimEnd('/', '\\'))
                     .ToHashSet() // remove duplicates
                     .Select(share => new Share(share)) // convert to Shares

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\slskd\Shares\ShareService.cs (line 566)

                     return;
                 }
 
▶                var shares = options.Shares.Directories
                     .Select(share => share.TrimEnd('/', '\\'))
                     .ToHashSet() // remove duplicates
                     .Select(share => new Share(share)) // convert to Shares

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS044 Attribute must specify [AttributeUsage] 18 hits

📄 src\slskd\Common\Validation\AbsoluteFilePathAttribute.cs (line 26)

     /// <summary>
     ///     Validates that the specified path is absolute.
     /// </summary>
▶    public class AbsoluteFilePathAttribute : ValidationAttribute
     {
         protected override ValidationResult IsValid(object value, ValidationContext validationContext)
         {

💬 AbsoluteFilePathAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\slskd\Common\Validation\DirectoryExistsAttributes.cs (line 28)

     /// <summary>
     ///     Validates that the directory at the specified path exists.
     /// </summary>
▶    public class DirectoryExistsAttribute : ValidationAttribute
     {
         /// <summary>
         ///     Initializes a new instance of the <see cref="DirectoryExistsAttribute"/> class.

💬 DirectoryExistsAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS056 HttpRequest.Form read synchronously 4 hits

📄 src\slskd\Relay\API\Controllers\RelayController.cs (line 294)

 
             try
             {
▶                shares = Request.Form["shares"].ToString().FromJson<IEnumerable<Share>>();
                 database = Request.Form.Files[0];
             }
             catch (Exception ex)

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

📄 src\slskd\Relay\API\Controllers\RelayController.cs (line 295)

             try
             {
                 shares = Request.Form["shares"].ToString().FromJson<IEnumerable<Share>>();
▶                database = Request.Form.Files[0];
             }
             catch (Exception ex)
             {

💬 Synchronously accessed HttpRequest.Form. Use HttpRequest.ReadFormAsync() instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS056-FormReadSynchronously.md)

SS059 IAsyncDisposable not disposed asynchronously 42 hits

📄 src\slskd\Common\Dumper.cs (line 99)

         {
             using var http = new HttpClient();
 
▶            using var localStream = new FileStream(destination, FileMode.OpenOrCreate);
             using var remoteStream = await http.GetStreamAsync(url);
 
             await remoteStream.CopyToAsync(localStream);

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\slskd\Common\Dumper.cs (line 100)

             using var http = new HttpClient();
 
             using var localStream = new FileStream(destination, FileMode.OpenOrCreate);
▶            using var remoteStream = await http.GetStreamAsync(url);
 
             await remoteStream.CopyToAsync(localStream);
         }

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 18 hits

📄 src\slskd\Relay\RelayClient.cs (line 71)

         public IStateMonitor<RelayClientState> StateMonitor { get; }
 
         private FileService Files { get; }
▶        private SemaphoreSlim ConfigurationSyncRoot { get; } = new SemaphoreSlim(1, 1);
         private bool Disposed { get; set; }
         private IHttpClientFactory HttpClientFactory { get; }
         private HubConnection HubConnection { get; set; }

💬 Disposable field ConfigurationSyncRoot in type RelayClient is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\slskd\Relay\RelayClient.cs (line 81)

         private TaskCompletionSource LoggedInTaskCompletionSource { get; set; }
         private IOptionsMonitor<Options> OptionsMonitor { get; }
         private IShareService Shares { get; }
▶        private CancellationTokenSource StartCancellationTokenSource { get; set; }
         private bool StartRequested { get; set; }
         private ManagedState<RelayClientState> State { get; } = new();
         private SemaphoreSlim StateSyncRoot { get; } = new SemaphoreSlim(1, 1);

💬 Disposable field StartCancellationTokenSource in type RelayClient is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

pythonnet

182 total diagnostics across 18 rules

SS003 Integer divided by integer causing implicit rounding 26 hits

📄 src\runtime\Native\LibraryLoader.cs (line 149)

             while (bytes < needsBytes)
             {
                 bytes = needsBytes;
▶                result = new IntPtr[bytes / IntPtr.Size];
                 if (!EnumProcessModules(self.Handle, result, bytes, out needsBytes))
                     throw new Win32Exception();
             }

💬 The operands in the divisive expression bytes / IntPtr.Size are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\runtime\Native\LibraryLoader.cs (line 153)

                 if (!EnumProcessModules(self.Handle, result, bytes, out needsBytes))
                     throw new Win32Exception();
             }
▶            return result.Take((int)(needsBytes / IntPtr.Size)).ToArray();
         }
 
         [DllImport(NativeDll, SetLastError = true)]

💬 The operands in the divisive expression needsBytes / IntPtr.Size are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS005 Equals() and GetHashCode() not implemented together 10 hits

📄 src\runtime\PythonTypes\PyDict.cs (line 13)

     /// for details.
     /// </summary>
     [Serializable]
▶    public class PyDict : PyIterable
     {
         internal PyDict(BorrowedReference reference) : base(reference) { }
         internal PyDict(in StolenReference reference) : base(reference) { }

💬 Equals() and GetHashcode() must be implemented together on PyDict (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\runtime\PythonTypes\PyFloat.cs (line 11)

     /// PY3: https://docs.python.org/3/c-api/float.html
     /// for details.
     /// </summary>
▶    public partial class PyFloat : PyNumber
     {
         internal PyFloat(in StolenReference ptr) : base(ptr)
         {

💬 Equals() and GetHashcode() must be implemented together on PyFloat (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 src\runtime\Codecs\PyObjectConversions.cs (line 152)

             }
 
             public override int GetHashCode()
▶                => this.ClrType.GetHashCode() ^ this.PyType.GetHashCode();
 
             public bool Equals(TypePair other)
                 => this.PyType == other.PyType && this.ClrType == other.ClrType;

💬 GetHashCode() refers to mutable field ClrType (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\runtime\PythonTypes\PyDict.cs (line 173)

             Runtime.PyDict_Clear(obj);
         }
 
▶        public override int GetHashCode() => rawPtr.GetHashCode();
 
         public override bool Equals(PyObject? other)
         {

💬 GetHashCode() refers to mutable field rawPtr (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 56 hits

📄 src\runtime\Native\NewReference.cs (line 12)

     /// Represents a reference to a Python object, that is tracked by Python's reference counting.
     /// </summary>
     [NonCopyable]
▶    ref struct NewReference
     {
         IntPtr pointer;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NewReference. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\runtime\StateSerialization\MaybeMemberInfo.cs (line 8)

 namespace Python.Runtime
 {
     [Serializable]
▶    internal struct MaybeMemberInfo<T> : ISerializable where T : MemberInfo
     {
         // .ToString() of the serialized object
         const string SerializationDescription = "d";

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MaybeMemberInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 src\runtime\Types\ClassBase.cs (line 638)

                 TypeManager.InitializeSlotIfEmpty(pyType, TypeOffset.mp_length, new Interop.B_P(MpLengthSlot.impl), slotsHolder);
             }
 
▶            switch (Type.GetTypeCode(type.Value))
             {
                 case TypeCode.Boolean:
                 case TypeCode.SByte:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\runtime\Types\ClassBase.cs (line 638)

                 TypeManager.InitializeSlotIfEmpty(pyType, TypeOffset.mp_length, new Interop.B_P(MpLengthSlot.impl), slotsHolder);
             }
 
▶            switch (Type.GetTypeCode(type.Value))
             {
                 case TypeCode.Boolean:
                 case TypeCode.SByte:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 8 hits

📄 src\runtime\ClassManager.cs (line 436)

             {
                 var mi = (MemberInfo)items[i];
 
▶                switch (mi.MemberType)
                 {
                     case MemberTypes.Method:
                         meth = (MethodInfo)mi;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\runtime\Types\ClassObject.cs (line 250)

             {
                 if (ManagedType.GetManagedObject(op) is CLRObject clrObject)
                 {
▶                    switch (clrObject.inst)
                     {
                         case nint val:
                             result = new IntPtr(val);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 4 hits

📄 src\embed_tests\Codecs.cs (line 387)

             }
         }
 
▶        public static void AcceptsDateTime(DateTime v) {}
 
         [Test]
         public void As_Object_AffectedByDecoders()

💬 Method AcceptsDateTime might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 src\embed_tests\Codecs.cs (line 387)

             }
         }
 
▶        public static void AcceptsDateTime(DateTime v) {}
 
         [Test]
         public void As_Object_AffectedByDecoders()

💬 Method AcceptsDateTime might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 18 hits

📄 src\runtime\Native\StrPtr.cs (line 46)

         {
             get
             {
▶                if (this.RawPointer == IntPtr.Zero) throw new NullReferenceException();
 
                 nuint zeroIndex = 0;
                 while (this.Bytes[zeroIndex] != 0)

💬 An exception is thrown from the getter of property ByteCount (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\runtime\PythonEngine.cs (line 67)

             {
                 if (delegateManager == null)
                 {
▶                    throw new InvalidOperationException(
                         "DelegateManager has not yet been initialized using Python.Runtime.PythonEngine.Initialize().");
                 }
                 return delegateManager;

💬 An exception is thrown from the getter of property DelegateManager (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 6 hits

📄 src\runtime\InternString.cs (line 22)

             var validNames = new HashSet<string>(identifierNames);
             if (validNames.Count != _builtinNames.Length)
             {
▶                throw new InvalidOperationException("Identifiers args not matching");
             }
             foreach (var name in _builtinNames)
             {

💬 An exception is thrown from InternString its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 src\runtime\InternString.cs (line 28)

             {
                 if (!validNames.Contains(name))
                 {
▶                    throw new InvalidOperationException($"{name} is not declared");
                 }
             }
         }

💬 An exception is thrown from InternString its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS026 Exception thrown from equality operator 4 hits

📄 src\runtime\PythonTypes\PyObject.cs (line 1454)

 
             using var _ = Py.GIL();
             int result = Runtime.PyObject_RichCompareBool(a.obj, b.obj, Runtime.Py_EQ);
▶            if (result < 0) throw PythonException.ThrowLastAsClrException();
             return result != 0;
         }
 

💬 An exception is thrown from the == operator between PyObject? and PyObject? in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS026-ExceptionThrownFromEqualityOperator.md)

📄 src\runtime\PythonTypes\PyObject.cs (line 1471)

 
             using var _ = Py.GIL();
             int result = Runtime.PyObject_RichCompareBool(a.obj, b.obj, Runtime.Py_NE);
▶            if (result < 0) throw PythonException.ThrowLastAsClrException();
             return result != 0;
         }
 

💬 An exception is thrown from the != operator between PyObject? and PyObject? in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS026-ExceptionThrownFromEqualityOperator.md)

SS027 Exception thrown from Dispose 6 hits

📄 src\runtime\Py.cs (line 55)

         public override void Dispose()
         {
             if (this.owner != Thread.CurrentThread)
▶                throw new InvalidOperationException("GIL must always be released from the same thread, that acquired it");
 
             base.Dispose();
         }

💬 An exception is thrown from the Dispose() method in type DebugGILState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

📄 src\runtime\PythonTypes\PyObject.cs (line 196)

 
             if (Runtime.Py_IsInitialized() == 0 && Runtime._Py_IsFinalizing() != true)
             {
▶                throw new InvalidOperationException("Python runtime must be initialized");
             }
 
             nint refcount = Runtime.Refcount(this.obj);

💬 An exception is thrown from the Dispose(bool) method in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS027-ExceptionThrownFromDispose.md)

SS028 Exception thrown from finalizer 2 hits

📄 src\runtime\Py.cs (line 41)

 
         ~GILState()
         {
▶            throw new InvalidOperationException("GIL must always be released, and it must be released from the same thread that acquired it.");
         }
     }
 

💬 An exception is thrown from the finalizer method in type GILState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS028-ExceptionThrownFromFinalizer.md)

📄 src\runtime\Py.cs (line 41)

 
         ~GILState()
         {
▶            throw new InvalidOperationException("GIL must always be released, and it must be released from the same thread that acquired it.");
         }
     }
 

💬 An exception is thrown from the finalizer method in type GILState (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS028-ExceptionThrownFromFinalizer.md)

SS029 Exception thrown from GetHashCode 2 hits

📄 src\runtime\PythonTypes\PyObject.cs (line 1111)

             nint pyHash = Runtime.PyObject_Hash(obj);
             if (pyHash == -1 && Exceptions.ErrorOccurred())
             {
▶                throw PythonException.ThrowLastAsClrException();
             }
             return pyHash.GetHashCode();
         }

💬 An exception is thrown from the GetHashCode() method in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS029-ExceptionThrownFromGetHashCode.md)

📄 src\runtime\PythonTypes\PyObject.cs (line 1111)

             nint pyHash = Runtime.PyObject_Hash(obj);
             if (pyHash == -1 && Exceptions.ErrorOccurred())
             {
▶                throw PythonException.ThrowLastAsClrException();
             }
             return pyHash.GetHashCode();
         }

💬 An exception is thrown from the GetHashCode() method in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS029-ExceptionThrownFromGetHashCode.md)

SS030 Exception thrown from Equals 2 hits

📄 src\runtime\PythonTypes\PyObject.cs (line 1092)

                 return true;
             }
             int result = Runtime.PyObject_RichCompareBool(obj, other.obj, Runtime.Py_EQ);
▶            if (result < 0) throw PythonException.ThrowLastAsClrException();
             return result != 0;
         }
 

💬 An exception is thrown from the Equals(PyObject?) method in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

📄 src\runtime\PythonTypes\PyObject.cs (line 1092)

                 return true;
             }
             int result = Runtime.PyObject_RichCompareBool(obj, other.obj, Runtime.Py_EQ);
▶            if (result < 0) throw PythonException.ThrowLastAsClrException();
             return result != 0;
         }
 

💬 An exception is thrown from the Equals(PyObject?) method in type PyObject (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS030-ExceptionThrownFromEquals.md)

SS034 Accessing Task.Result without await 4 hits

📄 src\embed_tests\TestInterrupt.cs (line 93)

             Assert.That(asyncCall.Wait(TimeSpan.FromSeconds(5)), Is.True, "Async thread was not interrupted in time");
             PythonEngine.EndAllowThreads(threadState);
 
▶            Assert.That(asyncCall.Result, Is.EqualTo(0));
         }
     }
 }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\embed_tests\TestInterrupt.cs (line 93)

             Assert.That(asyncCall.Wait(TimeSpan.FromSeconds(5)), Is.True, "Async thread was not interrupted in time");
             PythonEngine.EndAllowThreads(threadState);
 
▶            Assert.That(asyncCall.Result, Is.EqualTo(0));
         }
     }
 }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS057 Collection manipulated during traversal 2 hits

📄 src\runtime\Util\EventHandlerCollection.cs (line 101)

             {
                 continue;
             }
▶            list.RemoveAt(i);
             if (list.Count == 0)
             {
                 Remove(key);

📄 src\runtime\Util\EventHandlerCollection.cs (line 101)

             {
                 continue;
             }
▶            list.RemoveAt(i);
             if (list.Count == 0)
             {
                 Remove(key);

SS058 String concatenated in a loop 12 hits

📄 src\runtime\Types\ClassObject.cs (line 45)

             {
                 if (str.Length > 0)
                 {
▶                    str += Environment.NewLine;
                 }
                 str += t.ToString();
             }

📄 src\runtime\Types\ClassObject.cs (line 47)

                 {
                     str += Environment.NewLine;
                 }
▶                str += t.ToString();
             }
             return Runtime.PyString_FromString(str);
         }

SS066 Disposable field is not disposed 6 hits

📄 src\runtime\Native\NativeTypeSpec.cs (line 10)

     [StructLayout(LayoutKind.Sequential)]
     struct NativeTypeSpec : IDisposable
     {
▶        public readonly StrPtr Name;
         public readonly int BasicSize;
         public readonly int ItemSize;
         public readonly int Flags;

💬 Disposable field Name in type NativeTypeSpec is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\runtime\PythonTypes\PyBuffer.cs (line 11)

 {
     public sealed class PyBuffer : IDisposable
     {
▶        private PyObject _exporter;
         private Py_buffer _view;
 
         internal PyBuffer(PyObject exporter, PyBUF flags)

💬 Disposable field _exporter in type PyBuffer is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

VFSForGit

180 total diagnostics across 10 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 34 hits

📄 GVFS\GVFS.Tests\NUnitRunner.cs (line 152)

                 this.args.Add(filters);
             }
 
▶            DateTime now = DateTime.Now;
             int result = new AutoRun(Assembly.GetEntryAssembly()).Execute(this.args.ToArray());
 
             Console.WriteLine("Completed test pass in {0}", DateTime.Now - now);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 GVFS\GVFS.Tests\NUnitRunner.cs (line 155)

             DateTime now = DateTime.Now;
             int result = new AutoRun(Assembly.GetEntryAssembly()).Execute(this.args.ToArray());
 
▶            Console.WriteLine("Completed test pass in {0}", DateTime.Now - now);
             Console.WriteLine();
 
             return result;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 14 hits

📄 GVFS\GVFS.Common\ConsoleHelper.cs (line 79)

                                 }
                                 else
                                 {
▶                                    output.Write("\r{0}...{1}", message, waiting[(retries / 2) % waiting.Length]);
                                     initialMessageWritten = true;
                                     actionIsDone.WaitOne(100);
                                 }

💬 The operands in the divisive expression retries / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 GVFS\GVFS.Common\SHA1Util.cs (line 62)

 
         public static byte[] BytesFromHexString(string sha)
         {
▶            byte[] arr = new byte[sha.Length / 2];
 
             for (int i = 0; i < arr.Length; ++i)
             {

💬 The operands in the divisive expression sha.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 10 hits

📄 GVFS\GVFS.Common\Prefetch\Git\DiffHelper.cs (line 225)

 
             if (result.TargetIsDirectory)
             {
▶                if (!this.stagedDirectoryOperations.Add(result))
                 {
                     EventMetadata metadata = new EventMetadata();
                     metadata.Add(nameof(result.TargetPath), result.TargetPath);

💬 Type DiffTreeResult is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 GVFS\GVFS.Common\Prefetch\Git\DiffHelper.cs (line 234)

 
                     // Since we match only on filename, re-adding is the easiest way to update the set.
                     this.stagedDirectoryOperations.Remove(result);
▶                    this.stagedDirectoryOperations.Add(result);
                 }
             }
             else

SS017 Struct without Equals/GetHashCode/ToString overridden 28 hits

📄 GVFS\GVFS.MSBuild\GenerateGVFSConstants.cs (line 92)

             return false;
         }
 
▶        private struct GitVersion
         {
             public int Major { get; set; }
             public int Minor { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GitVersion. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 GVFS\GVFS.GVFlt\GVFltCallbacks.cs (line 15)

         /// This struct should only be used by the upgrader, it has been replaced by GVFS.Virtualization.Background.FileSystemTask
         /// </remarks>
         [Serializable]
▶        public struct BackgroundGitUpdate
         {
             // This enum must be present or the BinarySerializer will always deserialze Operation as 0
             public enum OperationType

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BackgroundGitUpdate. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 GVFS\GVFS.Common\Git\LibGit2Repo.cs (line 80)

 
             try
             {
▶                switch (Native.Object.GetType(objHandle))
                 {
                     case Native.ObjectTypes.Commit:
                         GitOid output = Native.IntPtrToGitOid(Native.Commit.GetTreeId(objHandle));

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 GVFS\GVFS.Common\Tracing\TelemetryDaemonEventListener.cs (line 69)

             QueuedPipeStringWriterState state,
             Exception exception)
         {
▶            switch (state)
             {
                 case QueuedPipeStringWriterState.Failing:
                     this.RaiseListenerFailure(exception?.ToString());

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 18 hits

📄 GVFS\GVFS.Hooks\Program.cs (line 86)

         private static void RunPreCommands(string[] args)
         {
             string command = GetGitCommand(args);
▶            switch (command)
             {
                 case "fetch":
                 case "pull":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 GVFS\GVFS.Common\ConsoleHelper.cs (line 110)

             }
             finally
             {
▶                switch (result)
                 {
                     case ActionResult.Success:
                         if (initialMessageWritten)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS040 Unused result on immutable object 2 hits

📄 GVFS\GVFS.Common\HealthCalculator\EnlistmentPathData.cs (line 176)

             {
                 if (path.Last() == GVFSConstants.GitPathSeparator)
                 {
▶                    path.TrimEnd(GVFSConstants.GitPathSeparator);
                     this.ModifiedFolderPaths.Add(path);
                 }
                 else

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

📄 GVFS\GVFS.Common\HealthCalculator\EnlistmentPathData.cs (line 176)

             {
                 if (path.Last() == GVFSConstants.GitPathSeparator)
                 {
▶                    path.TrimEnd(GVFSConstants.GitPathSeparator);
                     this.ModifiedFolderPaths.Add(path);
                 }
                 else

💬 The result of an operation on an immutable object is unused (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS040-UnusedResultOnImmutableObject.md)

SS051 Locking on mutable reference 24 hits

📄 GVFS\GVFS.Common\Database\SparseTable.cs (line 38)

                     command.CommandText = "INSERT OR REPLACE INTO Sparse (path) VALUES (@path);";
                     command.AddParameter("@path", DbType.String, GVFSDatabase.NormalizePath(directoryPath));
 
▶                    lock (this.writerLock)
                     {
                         command.ExecuteNonQuery();
                     }

💬 A lock was obtained on writerLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 GVFS\GVFS.Common\Database\SparseTable.cs (line 86)

                     command.CommandText = "DELETE FROM Sparse WHERE path = @path;";
                     command.AddParameter("@path", DbType.String, GVFSDatabase.NormalizePath(directoryPath));
 
▶                    lock (this.writerLock)
                     {
                         command.ExecuteNonQuery();
                     }

SS058 String concatenated in a loop 2 hits

📄 GVFS\GVFS.Common\ModifiedPathsDatabase.cs (line 247)

             parentFolder = string.Empty;
             for (int i = 0; i < pathParts.Length - 1; i++)
             {
▶                parentFolder += pathParts[i] + GVFSConstants.GitPathSeparatorString;
                 if (this.modifiedPaths.Contains(parentFolder))
                 {
                     return true;

📄 GVFS\GVFS.Common\ModifiedPathsDatabase.cs (line 247)

             parentFolder = string.Empty;
             for (int i = 0; i < pathParts.Length - 1; i++)
             {
▶                parentFolder += pathParts[i] + GVFSConstants.GitPathSeparatorString;
                 if (this.modifiedPaths.Contains(parentFolder))
                 {
                     return true;

SS066 Disposable field is not disposed 40 hits

📄 GVFS\GVFS.Common\Git\LibGit2Repo.cs (line 49)

             this.Dispose(false);
         }
 
▶        protected ITracer Tracer { get; }
         protected IntPtr RepoHandle { get; private set; }
 
         public Native.ObjectTypes? GetObjectType(string sha)

💬 Disposable field Tracer in type LibGit2Repo is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 GVFS\GVFS.Common\Git\LibGit2RepoInvoker.cs (line 10)

     public class LibGit2RepoInvoker : IDisposable
     {
         private readonly Func<LibGit2Repo> createRepo;
▶        private readonly ITracer tracer;
         private readonly object sharedRepoLock = new object();
         private volatile bool disposing;
         private volatile int activeCallers;

💬 Disposable field tracer in type LibGit2RepoInvoker is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Papercut-SMTP

174 total diagnostics across 10 rules

SS001 Async method with void return type 2 hits

📄 src\Papercut.Service.TrayNotification\AppLayer\ServiceTrayCoordinator.cs (line 128)

         }
     }
 
▶    private async void OnServiceStatusChanged(object? sender, ServiceControllerStatus status)
     {
         UpdateTrayIcon();
     }

💬 Method OnServiceStatusChanged is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Papercut.Service.TrayNotification\AppLayer\ServiceTrayCoordinator.cs (line 128)

         }
     }
 
▶    private async void OnServiceStatusChanged(object? sender, ServiceControllerStatus status)
     {
         UpdateTrayIcon();
     }

💬 Method OnServiceStatusChanged is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 76 hits

📄 src\Papercut.Core\Domain\Message\MessageEntry.cs (line 116)

             _created = _info.CreationTime;
         }
 
▶        if (_created > DateTime.Now.Add(-TimeSpan.FromMinutes(5)))
         {
             _hasBeenSeen = false;
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Papercut.Core\Domain\Network\EndpointDefinition.cs (line 114)

                 }
 
                 // Log warnings for certificate validity issues
▶                var now = DateTime.Now;
                 if (cert2.NotBefore > now)
                 {
                     Log.Warning(

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS019 Switch is missing default label 8 hits

📄 src\Papercut.Infrastructure.IPComm\PapercutIPCommClientFactory.cs (line 34)

 {
     public PapercutIPCommClient GetClient(PapercutIPCommClientConnectTo connectTo)
     {
▶        switch (connectTo)
         {
             case PapercutIPCommClientConnectTo.Service:
                 return new PapercutIPCommClient(endpoints.Service, logger.ForContext<PapercutIPCommClient>());

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Papercut.Message\MessageRepository.cs (line 170)

             var repl = replacement ?? '\0';
             if (fancy)
             {
▶                switch (ch)
                 {
                     case '"':
                         // U+201D right double quotation mark

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 2 hits

📄 test\Papercut.Rules.Tests\MailRetentionRuleDispatchTests.cs (line 303)

         _mockRepository.Setup(r => r.LoadMessages()).Returns(oldMessages);
 
         var cts = new CancellationTokenSource();
▶        cts.Cancel();
 
         var action = async () => await _dispatch.DispatchAsync(rule, null, cts.Token);
         await action.Should().ThrowAsync<OperationCanceledException>();

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 test\Papercut.Rules.Tests\MailRetentionRuleDispatchTests.cs (line 303)

         _mockRepository.Setup(r => r.LoadMessages()).Returns(oldMessages);
 
         var cts = new CancellationTokenSource();
▶        cts.Cancel();
 
         var action = async () => await _dispatch.DispatchAsync(rule, null, cts.Token);
         await action.Should().ThrowAsync<OperationCanceledException>();

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 src\Papercut.Core\Infrastructure\Async\AsyncHelpers.cs (line 61)

         {
             SynchronizationContext.SetSynchronizationContext(null);
 
▶            return task.Result;
         }
         finally
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Papercut.Core\Infrastructure\Async\AsyncHelpers.cs (line 61)

         {
             SynchronizationContext.SetSynchronizationContext(null);
 
▶            return task.Result;
         }
         finally
         {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 src\Papercut.Common\Extensions\CollectionExtensions.cs (line 64)

 
         var count = 0;
 
▶        foreach (var key in keys.ToList().Where(dictionary.ContainsKey)) {
             dictionary.Remove(key);
             count++;
         }

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Papercut.Common\Extensions\CollectionExtensions.cs (line 64)

 
         var count = 0;
 
▶        foreach (var key in keys.ToList().Where(dictionary.ContainsKey)) {
             dictionary.Remove(key);
             count++;
         }

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 src\Papercut.Infrastructure.IPComm\Network\PapercutIPCommServer.cs (line 57)

     {
         get
         {
▶            lock (this)
             {
                 return this._isActive;
             }

📄 src\Papercut.Infrastructure.IPComm\Network\PapercutIPCommServer.cs (line 64)

         }
         private set
         {
▶            lock (this)
             {
                 this._isActive = value;
             }

SS049 Comparing strings without StringComparison 10 hits

📄 src\Papercut.Infrastructure.IPComm\Network\PapercutIPCommClient.cs (line 118)

     {
         string response = (await stream.ReadStringBufferedAsync(token: token)).Trim();
 
▶        if (response != AppConstants.ApplicationName.ToUpper()) return false;
 
         var eventJson = PapercutIPCommSerializer.ToJson(@event);

📄 src\Papercut.UI\Helpers\HtmlPreviewVisitor.cs (line 180)

         // Remove any existing oncontextmenu attribute to allow WebView2 custom context menus
         foreach (var attribute in ctx.Attributes)
         {
▶            if (attribute.Name.ToLowerInvariant() == "oncontextmenu")
                 continue;
 
             htmlWriter.WriteAttribute(attribute);

SS059 IAsyncDisposable not disposed asynchronously 12 hits

📄 src\Papercut.Common\Extensions\FileInfoExtensions.cs (line 47)

 
         try
         {
▶            using var ms = new MemoryStream();
             await using var fileStream = file.Open(FileMode.Open, FileAccess.Read, FileShare.Read);
 
             await fileStream.CopyToAsync(ms);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Papercut.Infrastructure.IPComm\StreamExtensions.cs (line 34)

     {
         if (stream == null) throw new ArgumentNullException(nameof(stream));
 
▶        using var ms = new MemoryStream();
         await stream.CopyBufferedToAsync(ms, maxBytes, bufferSize, token: token);
 
         return ms.ToArray();

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 56 hits

📄 src\Papercut.Core\Infrastructure\BackgroundTasks\BackgroundTaskRunner.cs (line 33)

 {
     private readonly CancellationTokenSource _cancellationTokenSource;
     private readonly ILogger _logger;
▶    private readonly Task _processingTask;
     private readonly Channel<Func<CancellationToken, Task>> _taskChannel;
 
     public BackgroundTaskRunner(ILogger logger)

💬 Disposable field _processingTask in type BackgroundTaskRunner is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Papercut.Message\MimeMessageLoader.cs (line 36)

 {
     public static MemoryCache MimeMessageCache;
 
▶    private readonly Task _backgroundLoader;
 
     private readonly CancellationTokenSource _cancellationSource;

💬 Disposable field _backgroundLoader in type MimeMessageLoader is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

BruteShark

172 total diagnostics across 11 rules

SS001 Async method with void return type 4 hits

📄 BruteShark\BruteSharkDesktop\MainForm.cs (line 427)

             StartLiveCaptureAsync();
         }
 
▶        private async void StartLiveCaptureAsync()
         {
             this.progressBar.CustomText = "Live capture is ON...";
             this.progressBar.Refresh();

💬 Method StartLiveCaptureAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 BruteShark\BruteSharkDesktop\MainForm.cs (line 521)

             modulesTreeView.SelectedNode = modulesTreeView.Nodes[0];
         }
 
▶        private async void CheckForUpdates()
         {
             try
             {

💬 Method CheckForUpdates is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS003 Integer divided by integer causing implicit rounding 6 hits

📄 BruteShark\BruteSharkCli\PrintDataExtensions.cs (line 786)

             if (lastRowFilledCellsCount == 0)
                 lastRowFilledCellsCount = repeatColumns;
             int lastRowEmptyCellsCount = repeatColumns - lastRowFilledCellsCount;
▶            int rowsCount = (dataRows.Count() / repeatColumns) + (dataRows.Count() % repeatColumns > 0 ? 1 : 0);
 
             if (delimiter == null)
                 delimiter = string.Empty;

💬 The operands in the divisive expression dataRows.Count() / repeatColumns are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 BruteShark\BruteSharkDesktop\UserControls\TextProgressBar.cs (line 50)

                 SizeF len = g.MeasureString(text, f);
                 // Calculate the location of the text (the middle of progress bar)
                 // Point location = new Point(Convert.ToInt32((rect.Width / 2) - (len.Width / 2)), Convert.ToInt32((rect.Height / 2) - (len.Height / 2)));
▶                Point location = new Point(Convert.ToInt32((Width / 2) - len.Width / 2), Convert.ToInt32((Height / 2) - len.Height / 2));
                 // The commented-out code will centre the text into the highlighted area only. This will centre the text regardless of the highlighted area.
                 // Draw the custom text
                 g.DrawString(text, f, Brushes.Red, location);

💬 The operands in the divisive expression Width / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 12 hits

📄 BruteShark\PcapProcessor\ProcessingPrecentsPredicator.cs (line 62)

 
         public void NotifyAboutProcessedFile(FileInfo fileProcessed)
         {
▶            this.FilesProcessed.Add(fileProcessed);
             this.DataProcessed = this.FilesProcessed.Sum(fi => fi.Length);
         }
 

💬 Type FileInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 BruteShark\PcapAnalyzer\Modules\DnsModule\DnsModule.cs (line 99)

                 return;
             }
 
▶            if (_mappings.Add(response))
             {
                 this.ParsedItemDetected(this, new ParsedItemDetectedEventArgs()
                 {

💬 Type DnsNameMapping is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 52 hits

📄 BruteShark\PcapAnalyzer\Modules\FilesExtractingModule\NetworkFile.cs (line 42)

         public override int GetHashCode()
         {
             return base.GetHashCode() ^
▶                   this.FileData.GetHashCode() ^
                    this.Extention.GetHashCode() ^
                    this.Algorithm.GetHashCode();
         }

💬 GetHashCode() refers to mutable property FileData (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 BruteShark\PcapAnalyzer\Modules\FilesExtractingModule\NetworkFile.cs (line 43)

         {
             return base.GetHashCode() ^
                    this.FileData.GetHashCode() ^
▶                   this.Extention.GetHashCode() ^
                    this.Algorithm.GetHashCode();
         }
 

💬 GetHashCode() refers to mutable property Extention (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 BruteShark\BruteSharkDesktop\GithubAutoUpdater.cs (line 15)

         public string LatestVersionUrl { get; set; }
     }
 
▶    public struct GithubUpdateReleaseResponse
     {
         public bool ShouldUpdate { get; set; }
         public string NewVersionUrl { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GithubUpdateReleaseResponse. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 BruteShark\BruteSharkDesktop\GithubAutoUpdater.cs (line 9)

 
 namespace BruteSharkDesktop
 {
▶    public struct GithubReleaseVersion
     {
         public string Version { get; set; }
         public string LatestVersionUrl { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct GithubReleaseVersion. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 4 hits

📄 BruteShark\PcapAnalyzer\Modules\VoipCallsModule\VoipCallsModule.cs (line 81)

             // Check if the voip calls set already contains this call.
             if (_voipCalls.Contains(call))
             {
▶                switch (sipRequest.Method)
                 {
                     case SIPMethodsEnum.ACK:
                         GetCall(call).CallState = CallState.InCall;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 BruteShark\PcapAnalyzer\Modules\VoipCallsModule\VoipCallsModule.cs (line 122)

             // Check if the voip calls hash set already contains this call.
             if (_voipCalls.Contains(call))
             {
▶                switch (sipRequest.Method)
                 {
                     case SIPMethodsEnum.ACK:
                         GetCall(call).CallState = CallState.InCall;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 8 hits

📄 BruteShark\PcapAnalyzer\Modules\PasswordsModule\CredentialsParsers\KerberosPackets\KerberosPacketParser.cs (line 47)

                 AsnElt asn_object = AsnElt.Decode(asn_buffer);
 
                 // Get the application number.
▶                switch (asn_object.TagValue)
                 {
                     case (int)MessageType.krb_tgs_rep:
                         result = new KerberosTgsRepPacket(kdc_rep: asn_object.Sub[0].Sub);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 BruteShark\PcapAnalyzer\Modules\PasswordsModule\CredentialsParsers\KerberosPackets\KerberosPrincipalName.cs (line 60)

 
             foreach (AsnElt s in principalNameData.Sub)
             {
▶                switch (s.TagValue)
                 {
                     case 0:
                         this.NameType = Convert.ToInt32(s.Sub[0].GetInteger());

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 14 hits

📄 BruteShark\PcapProcessorTest\PcapProcessorTest.cs (line 14)

     [TestClass]
     public class PcapProcessorTest
     {
▶        public string UdpFilePath { get; set; }
         public string TcpFivePacketsFilePath { get; set; }
         public string HttpSmallFilePath { get; set; }
         public string PcapNGFile { get; set; }

💬 Method set_UdpFilePath might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 BruteShark\PcapProcessorTest\PcapProcessorTest.cs (line 16)

     {
         public string UdpFilePath { get; set; }
         public string TcpFivePacketsFilePath { get; set; }
▶        public string HttpSmallFilePath { get; set; }
         public string PcapNGFile { get; set; }
 
 

💬 Method set_HttpSmallFilePath might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS051 Locking on mutable reference 6 hits

📄 BruteShark\PcapProcessor\Sniffer.cs (line 251)

         {
             var packet = PacketDotNet.Packet.ParsePacket(e.GetPacket().LinkLayerType, e.GetPacket().Data);
 
▶            lock (_packetsQueueLock)
             {
                 _packets.Enqueue(packet);
             }

💬 A lock was obtained on _packetsQueueLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 BruteShark\PcapProcessor\Sniffer.cs (line 261)

         {
             while (true)
             {
▶                lock (_packetsQueueLock)
                 {
                     while (_packets.Count > 0)
                     {

SS058 String concatenated in a loop 30 hits

📄 BruteShark\PcapAnalyzer\Modules\PasswordsModule\CredentialsParsers\TelnetPasswordParser.cs (line 73)

                         // Buffer the username (relevant for char mode).
                         // NOTE: Telnet username can be passed a char by char (Character-Mode) or 
                         // at once (Line-Mode).
▶                        username += getNvtAsciiDataString(packet.Data);
                     }
                     else if (packetData.Contains("Password:") && state == TelnetServerState.WaitForUsername)
                     {

📄 BruteShark\PcapAnalyzer\Modules\PasswordsModule\CredentialsParsers\TelnetPasswordParser.cs (line 82)

                     else if (state == TelnetServerState.WaitForPassword && packet.SourceIp == clientIp)
                     {
                         // Buffer the password (relevant for char mode).
▶                        password += getNvtAsciiDataString(packet.Data);
                     }
                     else if (packet.SourceIp == serverIp && packet.Data.Length > 0 && state == TelnetServerState.WaitForPassword)
                     {

SS066 Disposable field is not disposed 32 hits

📄 BruteShark\BruteSharkDesktop\MainForm.cs (line 20)

 {
     public partial class MainForm : Form
     {
▶        private CancellationTokenSource _cts;
         private HashSet<string> _files;
         private CommonUi.NetworkContext _networkContext;
         private PcapProcessor.Processor _processor;

💬 Disposable field _cts in type MainForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 BruteShark\BruteSharkDesktop\MainForm.cs (line 27)

         private PcapProcessor.Sniffer _sniffer;
         private PcapAnalyzer.Analyzer _analyzer;
 
▶        private GenericTableUserControl _passwordsUserControl;
         private HashesUserControl _hashesUserControl;
         private NetworkMapUserControl _networkMapUserControl;
         private SessionsExplorerUserControl _sessionsExplorerUserControl;

💬 Disposable field _passwordsUserControl in type MainForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

FlaUI

170 total diagnostics across 8 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 src\FlaUI.Core\Capturing\InfoOverlay.cs (line 117)

                 .Replace("{mem.v.used.perc}", $"{SystemInfo.VirtualMemoryUsedPercent,5:##.00}%");
 
             // Replace the date/time
▶            var now = DateTime.Now;
             overlayString = Regex.Replace(overlayString, @"\{dt:?(.*?)\}", m => now.ToString(m.Groups[1].Value));
 
             // Replace the custom timespan

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\FlaUI.TestUtilities\FlaUITestBase.cs (line 67)

         /// <summary>
         /// static member which holds the current execution date and time
         /// </summary> 
▶        private static string _testDateTime = DateTime.Now.ToString("yyyyMMddHHmmss");
 
         /// <summary>
         /// Path of the directory for the screenshots and videos for the tests.

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 72 hits

📄 src\FlaUI.Core\Capturing\InfoOverlay.cs (line 90)

             }
             else if (IsPositionCenter())
             {
▶                textPosX = bgWidth / 2 - textSize.Width / 2 - textOffsetToBg / 2;
             }
             // Draw the background
             g.FillRectangle(bgBrush, bgPosX, bgPosY, bgWidth, bgHeight);

💬 The operands in the divisive expression bgWidth / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\FlaUI.Core\Capturing\InfoOverlay.cs (line 90)

             }
             else if (IsPositionCenter())
             {
▶                textPosX = bgWidth / 2 - textSize.Width / 2 - textOffsetToBg / 2;
             }
             // Draw the background
             g.FillRectangle(bgBrush, bgPosX, bgPosY, bgWidth, bgHeight);

💬 The operands in the divisive expression textOffsetToBg / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS005 Equals() and GetHashCode() not implemented together 12 hits

📄 src\FlaUI.UIA2\UIA2FrameworkAutomationElement.cs (line 20)

 
 namespace FlaUI.UIA2
 {
▶    public partial class UIA2FrameworkAutomationElement : FrameworkAutomationElementBase
     {
         public UIA2FrameworkAutomationElement(UIA2Automation automation, UIA.AutomationElement nativeElement) : base(automation)
         {

💬 Equals() and GetHashcode() must be implemented together on UIA2FrameworkAutomationElement (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\FlaUI.UIA3\UIA3FrameworkAutomationElement.cs (line 18)

 
 namespace FlaUI.UIA3
 {
▶    public partial class UIA3FrameworkAutomationElement : FrameworkAutomationElementBase
     {
         public UIA3FrameworkAutomationElement(UIA3Automation automation, UIA.IUIAutomationElement nativeElement) : base(automation)
         {

💬 Equals() and GetHashcode() must be implemented together on UIA3FrameworkAutomationElement (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS019 Switch is missing default label 6 hits

📄 src\FlaUI.Core\Capturing\CaptureImage.cs (line 51)

         {
             var imageFormat = ImageFormat.Png;
             var ext = Path.GetExtension(filePath)?.ToLower();
▶            switch (ext)
             {
                 case ".jpg":
                 case ".jpeg":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\FlaUI.Core\Capturing\CaptureImage.cs (line 51)

         {
             var imageFormat = ImageFormat.Png;
             var ext = Path.GetExtension(filePath)?.ToLower();
▶            switch (ext)
             {
                 case ".jpg":
                 case ".jpeg":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 30 hits

📄 src\FlaUI.Core\AutomationElements\ComboBox.cs (line 96)

                 {
                     return edit.AsTextBox();
                 }
▶                throw new Exception("ComboBox is not editable.");
             }
         }
 

💬 An exception is thrown from the getter of property EditableItem (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\FlaUI.Core\AutomationElements\DateTimePicker.cs (line 66)

                     return date;
                 }
 
▶                throw new Exception("Unable to get the selected date from this DateTimePicker");
             }
             set
             {

💬 An exception is thrown from the getter of property SelectedDate (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 6 hits

📄 src\FlaUI.Core\Input\Touch.cs (line 26)

         {
             if (!User32.InitializeTouchInjection())
             {
▶                throw new Win32Exception();
             }
         }
 

💬 An exception is thrown from Touch its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 src\FlaUI.Core\Input\Touch.cs (line 26)

         {
             if (!User32.InitializeTouchInjection())
             {
▶                throw new Win32Exception();
             }
         }
 

💬 An exception is thrown from Touch its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS033 Async overload is available 4 hits

📄 src\FlaUI.Core\Capturing\VideoRecorder.cs (line 270)

             {
                 // Download
                 byte[] fileBytes = await _httpClient.GetByteArrayAsync(uri);
▶                File.WriteAllBytes(archivePath, fileBytes);
                 // Extract
                 Directory.CreateDirectory(targetFolder);
                 await Task.Run(() =>

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\FlaUI.Core\Capturing\VideoRecorder.cs (line 270)

             {
                 // Download
                 byte[] fileBytes = await _httpClient.GetByteArrayAsync(uri);
▶                File.WriteAllBytes(archivePath, fileBytes);
                 // Extract
                 Directory.CreateDirectory(targetFolder);
                 await Task.Run(() =>

💬 Async overload available for File.WriteAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS066 Disposable field is not disposed 30 hits

📄 src\FlaUI.Core\Capturing\VideoRecorder.cs (line 24)

     {
         private readonly VideoRecorderSettings _settings;
         private readonly Func<VideoRecorder, CaptureImage> _captureMethod;
▶        private readonly BlockingCollection<ImageData> _frames;
         private Task? _recordTask;
         private bool _shouldRecord;
         private Task? _writeTask;

💬 Disposable field _frames in type VideoRecorder is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\FlaUI.Core\Capturing\VideoRecorder.cs (line 25)

         private readonly VideoRecorderSettings _settings;
         private readonly Func<VideoRecorder, CaptureImage> _captureMethod;
         private readonly BlockingCollection<ImageData> _frames;
▶        private Task? _recordTask;
         private bool _shouldRecord;
         private Task? _writeTask;
         private DateTime _recordStartTime;

💬 Disposable field _recordTask in type VideoRecorder is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

DotnetSpider

156 total diagnostics across 15 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 52 hits

📄 src\DotnetSpider\Infrastructure\DateTimeHelper.cs (line 14)

     {
         get
         {
▶            var now = DateTime.Now.Date;
             return now.AddDays(now.Day * -1 + 1);
         }
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\DotnetSpider\Infrastructure\DateTimeHelper.cs (line 37)

     /// <summary>
     /// 当天
     /// </summary>
▶    public static DateTime Today => DateTime.Now.Date;
 
     /// <summary>
     /// 星期一

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 8 hits

📄 src\DotnetSpider\Proxy\ProxyService.cs (line 42)

         _queue = new ConcurrentQueue<ProxyEntry>();
         _dict = new ConcurrentDictionary<Uri, ProxyEntry>();
         _ignoreCount = 6;
▶        _reDetectCount = _ignoreCount / 2;
     }
 
     public async Task ReturnAsync(Uri proxy, HttpStatusCode statusCode)

💬 The operands in the divisive expression _ignoreCount / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\DotnetSpider\Infrastructure\BloomFilter.cs (line 147)

                 digest = KeyedHashAlgorithm.ComputeHash(data);
             }
 
▶            for (var i = 0; i < digest.Length / 4 && k < hashes; i++)
             {
                 var h = 0;
                 for (var j = i * 4; j < i * 4 + 4; j++)

💬 The operands in the divisive expression digest.Length / 4 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\DotnetSpider\DataFlow\Storage\Entity\EntityBase.cs (line 121)

             throw new SpiderException("索引列不能为空");
         }
 
▶        _tableMetadata.Value.Indexes.Add(new IndexMetadata(columns.ToArray(), isUnique));
         return this as T;
     }
 

💬 Type IndexMetadata is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\DotnetSpider\DataFlow\Storage\Entity\EntityBase.cs (line 121)

             throw new SpiderException("索引列不能为空");
         }
 
▶        _tableMetadata.Value.Indexes.Add(new IndexMetadata(columns.ToArray(), isUnique));
         return this as T;
     }
 

SS005 Equals() and GetHashCode() not implemented together 4 hits

📄 src\DotnetSpider\Selector\XPathSelector.cs (line 11)

 /// <summary>
 /// Xpath 查询器
 /// </summary>
▶public class XPathSelector : ISelector
 {
     private static readonly Regex AttributeXPathRegex =
         new(@"@[\w\s-]+", RegexOptions.RightToLeft | RegexOptions.IgnoreCase);

💬 Equals() and GetHashcode() must be implemented together on XPathSelector (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\DotnetSpider\DataFlow\Storage\Entity\IndexMetadata.cs (line 8)

 /// <summary>
 /// 索引元数据
 /// </summary>
▶public class IndexMetadata
 {
     private readonly bool _isUnique;
     private readonly string _name;

💬 Equals() and GetHashcode() must be implemented together on IndexMetadata (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 18 hits

📄 src\DotnetSpider\HtmlAgilityPack.Css\Either.cs (line 92)

 
         public override int GetHashCode()
         {
▶            return _value.GetHashCode();
         }
 
         public override bool Equals(object obj)

💬 GetHashCode() refers to mutable field _value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\DotnetSpider\HtmlAgilityPack.Css\Either.cs (line 59)

 
         public override int GetHashCode()
         {
▶            return _value.GetHashCode();
         }
 
         public override bool Equals(object obj)

💬 GetHashCode() refers to mutable field _value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

📄 src\DotnetSpider\Infrastructure\SpiderId.cs (line 5)

 
 namespace DotnetSpider.Infrastructure;
 
▶public readonly struct SpiderId
 {
     public readonly string Id;
     public readonly string Name;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SpiderId. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\DotnetSpider\Infrastructure\MachineInfo.cs (line 76)

         //[StructLayout(LayoutKind.Sequential, Pack = 1)]
         [SuppressMessage("ReSharper", "InconsistentNaming")]
 #pragma warning disable 649
▶        private readonly struct VmStatistics
         {
             public readonly int free_count; /* # 空闲内存页数量，没有被占用的 */
             public readonly int active_count; /* # 活跃内存页数量，正在使用或者最近被使用 */

💬 Implement Equals(), GetHashCode() and ToString() methods on struct VmStatistics. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 6 hits

📄 src\DotnetSpider\HtmlAgilityPack.Css\Parser.cs (line 145)

         }
         else
         {
▶            switch (token.Value.Kind)
             {
                 case TokenKind.Tilde: _generator.GeneralSibling(); break;
                 case TokenKind.Greater: _generator.Child(); break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\DotnetSpider\Infrastructure\ObjectId.cs (line 715)

 
     object IConvertible.ToType(Type conversionType, IFormatProvider provider)
     {
▶        switch (Type.GetTypeCode(conversionType))
         {
             case TypeCode.String:
                 return ((IConvertible)this).ToString(provider);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 12 hits

📄 src\DotnetSpider\HtmlAgilityPack.Css\Tokener.cs (line 117)

                     if (reader.Read() != '=')
                         throw new FormatException(string.Format("Invalid character at position {0}.", reader.Position));
 
▶                    switch (ch)
                     {
                         case '^': yield return Token.PrefixMatch(); break;
                         case '$': yield return Token.SuffixMatch(); break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\DotnetSpider\DataFlow\Parser\DataParser`.cs (line 30)

         {
             foreach (var followSelector in Model.FollowRequestSelectors)
             {
▶                switch (followSelector.SelectorType)
                 {
                     case SelectorType.Css:
                     {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 8 hits

📄 src\DotnetSpider.Tests\DataParserTests.cs (line 24)

         var request = new Request("http://cnblogs.com");
         var dataContext =
             new DataFlowContext(null, new SpiderOptions(), request,
▶                new Response { Content = new ByteArrayContent(File.ReadAllBytes("cnblogs.html")) });
 
 
         var dataParser = new TestDataParser();

💬 Async overload available for File.ReadAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\DotnetSpider.Tests\DataParserTests.cs (line 46)

         var request = new Request("http://cnblogs.com");
         var dataContext =
             new DataFlowContext(null, new SpiderOptions(), request,
▶                new Response { Content = new ByteArrayContent(File.ReadAllBytes("cnblogs.html")) });
 
         var dataParser = new TestDataParser();
         dataParser.SetLogger(NullLogger.Instance);

💬 Async overload available for File.ReadAllBytes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 src\DotnetSpider.Tests\MySqlQueueSchedulerTests.cs (line 60)

         ParallelUtilities.For(0, 1000, new ExecutionDataflowBlockOptions {MaxDegreeOfParallelism = 20},
             async _ => { await scheduler.DequeueAsync(); });
 
▶        Assert.Equal(1002, scheduler.GetTotalAsync().Result);
         await scheduler.CleanAsync();
     }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\DotnetSpider.Tests\QueueSchedulerTests.cs (line 34)

         Parallel.For(0, 1000, new ParallelOptions {MaxDegreeOfParallelism = 20},
             async i => { await scheduler.DequeueAsync(); });
 
▶        Assert.Equal(1002, scheduler.GetTotalAsync().Result);
     }
 
     [Fact(DisplayName = "EnqueueAndDequeueQueueBfs")]

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 src\DotnetSpider\DataFlow\Parser\Selector.cs (line 9)

 /// <summary>
 /// 选择器特性
 /// </summary>
▶public class Selector : System.Attribute
 {
     /// <summary>
     /// 避免被序列化出去

💬 Selector should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\DotnetSpider\DataFlow\Storage\Entity\Schema.cs (line 8)

 /// <summary>
 /// Schema 信息
 /// </summary>
▶public class Schema : Attribute
 {
     /// <summary>
     /// 数据库名

💬 Schema should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 src\DotnetSpider\Infrastructure\MachineInfo.cs (line 292)

     {
         get
         {
▶            lock (typeof(MachineInfo))
             {
                 try
                 {

💬 A lock was used on an object of type Type which can lead to deadlocks. It is recommended to create a dedicated lock instance of type System.Object instead. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS048-LockingOnDiscouragedObject.md)

📄 src\DotnetSpider.Tests\RabbitMQTests.cs (line 117)

         var counter = 0;
         consumer.Received += async bytes =>
         {
▶            lock (this)
             {
                 counter += 1;
             }

SS049 Comparing strings without StringComparison 2 hits

📄 src\DotnetSpider\DataFlow\Storage\Entity\EntityBase.cs (line 68)

         // 如果未设置主键, 但实体中有名为 Id 的属性, 则默认把 Id 作为主键
         if (_tableMetadata.Value.Primary == null || _tableMetadata.Value.Primary.Count == 0)
         {
▶            var primary = properties.FirstOrDefault(x => x.Name.ToLower() == "id");
             if (primary != null)
             {
                 _tableMetadata.Value.Primary = [primary.Name];

📄 src\DotnetSpider\DataFlow\Storage\Entity\EntityBase.cs (line 68)

         // 如果未设置主键, 但实体中有名为 Id 的属性, 则默认把 Id 作为主键
         if (_tableMetadata.Value.Primary == null || _tableMetadata.Value.Primary.Count == 0)
         {
▶            var primary = properties.FirstOrDefault(x => x.Name.ToLower() == "id");
             if (primary != null)
             {
                 _tableMetadata.Value.Primary = [primary.Name];

SS058 String concatenated in a loop 8 hits

📄 src\DotnetSpider\DataFlow\Storage\Entity\SqlServerEntityStorage.cs (line 274)

         var where = "";
         foreach (var column in tableMetadata.Primary)
         {
▶            where += $" [{GetNameSql(column)}] = @{column} AND";
         }
 
         where = where.Substring(0, where.Length - 3);

📄 src\DotnetSpider\DataFlow\Storage\Entity\SqlServerEntityStorage.cs (line 314)

         var where = "";
         foreach (var column in tableMetadata.Primary)
         {
▶            where += $" [{GetNameSql(column)}] = @{column} AND";
         }
 
         where = where.Substring(0, where.Length - 3);

SS066 Disposable field is not disposed 10 hits

📄 src\DotnetSpider\Spider.cs (line 33)

 {
     private readonly FlowBuilder _flowBuilder;
     private readonly IList<IRequestSupplier> _requestSuppliers;
▶    private readonly RequestedQueue _requestedQueue;
     private AsyncMessageConsumer<byte[]> _consumer;
     private readonly DependenceServices _services;
     private readonly IList<DataParser> _dataParsers;

💬 Disposable field _requestedQueue in type Spider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\DotnetSpider\Spider.cs (line 35)

     private readonly IList<IRequestSupplier> _requestSuppliers;
     private readonly RequestedQueue _requestedQueue;
     private AsyncMessageConsumer<byte[]> _consumer;
▶    private readonly DependenceServices _services;
     private readonly IList<DataParser> _dataParsers;
     private ResponseDelegate _delegate;
 

💬 Disposable field _services in type Spider is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

openai

154 total diagnostics across 11 rules

SS018 Switch does not handle all enum options 12 hits

📄 OpenAI.SDK\ObjectModels\ResponseModels\FineTuningJobResponseModels\NEpochsConverter.cs (line 10)

 {
     public override int? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
▶        switch (reader.TokenType)
         {
             case JsonTokenType.String:
             {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 OpenAI.SDK\ObjectModels\ResponseModels\FineTuningJobResponseModels\NEpochsConverter.cs (line 10)

 {
     public override int? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
▶        switch (reader.TokenType)
         {
             case JsonTokenType.String:
             {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 36 hits

📄 Betalgo.Ranul.OpenAI.Contracts\Responses\Base\ResponseError.cs (line 32)

     {
         set
         {
▶            switch (value)
             {
                 case string s:
                     Message = s;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Betalgo.Ranul.OpenAI.Contracts\Responses\Base\ResponseError.cs (line 32)

     {
         set
         {
▶            switch (value)
             {
                 case string s:
                     Message = s;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 54 hits

📄 OpenAI.SDK\ObjectModels\RequestModels\ToolDefinition.cs (line 43)

         {
             if (FunctionsAsObject != null && Function != null)
             {
▶                throw new ValidationException("FunctionAsObject and Function can not be assigned at the same time. One of them is should be null.");
             }
 
             return Function ?? FunctionsAsObject;

💬 An exception is thrown from the getter of property FunctionCalculated (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 OpenAI.SDK\ObjectModels\RequestModels\CompletionCreateRequest.cs (line 39)

         {
             if (Prompt != null && PromptAsList != null)
             {
▶                throw new ValidationException("Prompt and PromptAsList can not be assigned at the same time. One of them is should be null.");
             }
 
             if (Prompt != null)

💬 An exception is thrown from the getter of property PromptCalculated (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 4 hits

📄 OpenAI.SDK\Managers\OpenAIRealtimeService.cs (line 573)

     /// <inheritdoc />
     public async ValueTask DisposeAsync()
     {
▶        _disposeCts.Cancel();
 
         if (_receiveTask != null)
         {

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 OpenAI.SDK\Managers\OpenAIRealtimeService.cs (line 573)

     /// <inheritdoc />
     public async ValueTask DisposeAsync()
     {
▶        _disposeCts.Cancel();
 
         if (_receiveTask != null)
         {

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 OpenAI.Utilities\Embedding\EmbeddingTools.cs (line 146)

     public string CreateContext(string question, DataFrame df, int maxLen = 1800)
     {
         // Get the embeddings for the question
▶        var questionEmbeddingResult = _sdk.Embeddings.CreateEmbedding(new()
             {
                 Input = question,
                 Model = _embeddingModel

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 OpenAI.Utilities\Embedding\EmbeddingTools.cs (line 146)

     public string CreateContext(string question, DataFrame df, int maxLen = 1800)
     {
         // Get the embeddings for the question
▶        var questionEmbeddingResult = _sdk.Embeddings.CreateEmbedding(new()
             {
                 Input = question,
                 Model = _embeddingModel

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 6 hits

📄 OpenAI.SDK\Managers\OpenAIService.cs (line 27)

         if (httpClient == null)
         {
             _disposeHttpClient = true;
▶            _httpClient = new();
         }
         else
         {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 OpenAI.SDK\Managers\OpenAIService.cs (line 27)

         if (httpClient == null)
         {
             _disposeHttpClient = true;
▶            _httpClient = new();
         }
         else
         {

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 6 hits

📄 OpenAI.SDK\Tokenizer\GPT3\TokenizerGpt3.cs (line 115)

             return cachedResult;
         }
 
▶        List<string> word = (from x in token.ToList() select x.ToString()).ToList();
         var pairs = GetPairs(word);
         if (pairs.Count == 0)
         {

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 OpenAI.SDK\Tokenizer\GPT3\TokenizerGpt3.cs (line 115)

             return cachedResult;
         }
 
▶        List<string> word = (from x in token.ToList() select x.ToString()).ToList();
         var pairs = GetPairs(word);
         if (pairs.Count == 0)
         {

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS049 Comparing strings without StringComparison 6 hits

📄 OpenAI.SDK\ObjectModels\ResponseModels\FineTuningJobResponseModels\NEpochsConverter.cs (line 15)

             case JsonTokenType.String:
             {
                 var stringValue = reader.GetString();
▶                if (stringValue?.ToLower() == "auto")
                     return -1;
                 break;
             }

📄 OpenAI.SDK\ObjectModels\ResponseModels\FineTuningJobResponseModels\NEpochsConverter.cs (line 15)

             case JsonTokenType.String:
             {
                 var stringValue = reader.GetString();
▶                if (stringValue?.ToLower() == "auto")
                     return -1;
                 break;
             }

SS058 String concatenated in a loop 6 hits

📄 OpenAI.Playground\TestHelpers\ChatCompletionTestHelper.cs (line 377)

                                 {
                                     if (functionArguments.TryGetValue(i, out var currentArguments))
                                     {
▶                                        currentArguments += fn.Arguments;
                                     }
                                     else
                                     {

📄 OpenAI.Playground\TestHelpers\ChatCompletionTestHelper.cs (line 377)

                                 {
                                     if (functionArguments.TryGetValue(i, out var currentArguments))
                                     {
▶                                        currentArguments += fn.Arguments;
                                     }
                                     else
                                     {

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 OpenAI.Playground\TestHelpers\RealtimeHelpers\VoiceInput.cs (line 110)

     /// <param name="filePath">Path to the audio file to send</param>
     public async Task SendAudioFile(string filePath)
     {
▶        using var audioFileReader = new AudioFileReader(filePath);
         // Calculate buffer size based on minimum buffer duration
         var bufferSize = (int)(audioFileReader.WaveFormat.AverageBytesPerSecond * (MinimumBufferMs / 1000.0));
         var buffer = new byte[bufferSize];

💬 AudioFileReader can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 OpenAI.Playground\TestHelpers\RealtimeHelpers\VoiceInput.cs (line 110)

     /// <param name="filePath">Path to the audio file to send</param>
     public async Task SendAudioFile(string filePath)
     {
▶        using var audioFileReader = new AudioFileReader(filePath);
         // Calculate buffer size based on minimum buffer duration
         var bufferSize = (int)(audioFileReader.WaveFormat.AverageBytesPerSecond * (MinimumBufferMs / 1000.0));
         var buffer = new byte[bufferSize];

💬 AudioFileReader can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 18 hits

📄 OpenAI.SDK\Managers\OpenAIRealtimeService.cs (line 197)

     private readonly ILogger<OpenAIRealtimeService> _logger;
     private readonly OpenAIOptions _openAIOptions;
     private readonly SemaphoreSlim _sendLock = new(1, 1);
▶    private Task? _receiveTask;
     private ClientWebSocket? _webSocket;
     private readonly object _webSocketLock = new();
 

💬 Disposable field _receiveTask in type OpenAIRealtimeService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 OpenAI.SDK\Managers\OpenAIRealtimeService.cs (line 198)

     private readonly OpenAIOptions _openAIOptions;
     private readonly SemaphoreSlim _sendLock = new(1, 1);
     private Task? _receiveTask;
▶    private ClientWebSocket? _webSocket;
     private readonly object _webSocketLock = new();
 
     private readonly ClientEventsImplementation _clientEvents;

💬 Disposable field _webSocket in type OpenAIRealtimeService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

luban

152 total diagnostics across 12 rules

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 src\Luban.Cpp\CodeTarget\CppCodeTargetBase.cs (line 160)

                 GenerateSchemaCpp(ctx,
                     beanTypes.GetRange(startIndex, Math.Min(typeCountPerStubFile, beanTypes.Count - startIndex)),
                     schemaFileName,
▶                    $"{schemaFileNameWithoutExt}_{startIndex / typeCountPerStubFile}.cpp")));
         }
 
         Task.WaitAll(cppTasks.ToArray());

💬 The operands in the divisive expression startIndex / typeCountPerStubFile are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Luban.DataLoader.Builtin\Excel\Cell.cs (line 40)

 
     private static string ToAlphaString(int column)
     {
▶        int h = column / 26;
         int n = column % 26;
         return $"{(h > 0 ? ((char)('A' + h - 1)).ToString() : "")}{(char)('A' + n)}";
     }

💬 The operands in the divisive expression column / 26 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 62 hits

📄 src\Luban.Core\DataTransformer\DataTransfomerBase.cs (line 218)

         {
             DType newKey = ele.Key.Apply(this, mapType.KeyType);
             DType newValue = ele.Value.Apply(this, mapType.ValueType);
▶            newDatas[newKey] = newValue;
         }
         return new DMap(data.Type, newDatas);
     }

💬 Type DType is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Luban.Core\Datas\DSet.cs (line 41)

         var set = new HashSet<DType>();
         foreach (var data in datas)
         {
▶            if (!set.Add(data))
             {
                 throw new Exception($"set 的 value:{data} 重复");
             }

SS008 GetHashCode() refers to mutable or static member 6 hits

📄 src\Luban.Core\Serialization\ByteBuf.cs (line 1699)

     public override int GetHashCode()
     {
         int hash = 17;
▶        for (int i = ReaderIndex; i < WriterIndex; i++)
         {
             hash = hash * 23 + Bytes[i];
         }

💬 GetHashCode() refers to mutable property ReaderIndex (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Luban.Core\Serialization\ByteBuf.cs (line 1699)

     public override int GetHashCode()
     {
         int hash = 17;
▶        for (int i = ReaderIndex; i < WriterIndex; i++)
         {
             hash = hash * 23 + Bytes[i];
         }

💬 GetHashCode() refers to mutable property WriterIndex (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

📄 src\Luban.Core\Serialization\ByteBuf.cs (line 27)

 
 namespace Luban.Serialization;
 
▶public readonly struct SegmentSaveState
 {
     public SegmentSaveState(int readerIndex, int writerIndex)
     {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SegmentSaveState. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Luban.Core\Serialization\ThreadLocalTemporalByteBufPool.cs (line 23)

 
 namespace Luban.Serialization;
 
▶public readonly struct TemporalByteBuf : IDisposable
 {
     public ByteBuf Buf { get; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TemporalByteBuf. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 6 hits

📄 src\Luban.Core\DataTarget\DataExporterBase.cs (line 33)

     public virtual void Handle(GenerationContext ctx, IDataTarget dataTarget, OutputFileManifest manifest)
     {
         List<DefTable> tables = dataTarget.ExportAllRecords ? ctx.Tables : ctx.ExportTables;
▶        switch (dataTarget.AggregationType)
         {
             case AggregationType.Table:
             {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Luban.Core\Defs\DefField.cs (line 131)

         //    throw new Exception($"type:{HostType.FullName} field:{Name} type:{Type} is collection or bean. not support nullable");
         //}
 
▶        switch (CType)
         {
             case TArray t:
             {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 src\Luban.DataLoader.Builtin\Excel\TitleRow.cs (line 47)

             }
             else
             {
▶                throw new Exception($"简单数据类型字段 不支持子列名或者多行");
             }
         }
     }

💬 An exception is thrown from the getter of property Current (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\Luban.DataLoader.Builtin\Excel\TitleRow.cs (line 106)

             {
                 return Elements.All(e => e.IsBlank);
             }
▶            throw new Exception();
         }
     }
 

💬 An exception is thrown from the getter of property IsBlank (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS034 Accessing Task.Result without await 16 hits

📄 src\Luban.Core\DataLoader\DataLoaderManager.cs (line 64)

         var records = new List<Record>();
         foreach (var task in tasks)
         {
▶            records.AddRange(task.Result);
         }
         ctx.AddDataTable(table, records, null);
     }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Luban.Core\CodeTarget\CodeTargetBase.cs (line 212)

         Task.WaitAll(tasks.ToArray());
         foreach (var task in tasks)
         {
▶            manifest.AddFile(task.Result);
         }
     }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 4 hits

📄 src\Luban.Core\PostProcess\PostProcessAttribute.cs (line 34)

     DataConvert = 0x4,
 }
 
▶public class PostProcessAttribute : BehaviourBaseAttribute
 {
     public TargetFileType TargetFileType { get; }
 

💬 PostProcessAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\Luban.Core\CustomBehaviour\BehaviourBaseAttribute.cs (line 23)

 
 namespace Luban.CustomBehaviour;
 
▶public abstract class BehaviourBaseAttribute : Attribute, ICustomBehaviour
 {
     public string Name { get; }

💬 BehaviourBaseAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS048 Locking on discouraged object (string, Type, this) 22 hits

📄 src\Luban.Core\GenerationContext.cs (line 261)

 
     public object GetUniqueObject(string key)
     {
▶        lock (this)
         {
             return _uniqueObjects[key];
         }

📄 src\Luban.Core\GenerationContext.cs (line 269)

 
     public object TryGetUniqueObject(string key)
     {
▶        lock (this)
         {
             _uniqueObjects.TryGetValue(key, out var obj);
             return obj;

SS049 Comparing strings without StringComparison 4 hits

📄 src\Luban.Core\Utils\TimeZoneUtil.cs (line 48)

                 }
             }
         }
▶        if (timeZoneName.ToLower() == "local")
         {
             return TimeZoneInfo.Local;
         }

📄 src\Luban.Core\Utils\TimeZoneUtil.cs (line 52)

         {
             return TimeZoneInfo.Local;
         }
▶        if (timeZoneName.ToLower() == "utc")
         {
             return TimeZoneInfo.Utc;
         }

SS058 String concatenated in a loop 14 hits

📄 src\Luban.Java\TypeVisitors\JavaJsonUnderlyingDeserializeVisitor.cs (line 97)

             typeStr = $"{type.FinalElementType.Apply(JavaDeclaringTypeNameVisitor.Ins)}[{__n}]";
             for (int i = 0; i < type.Dimension - 1; i++)
             {
▶                typeStr += "[]";
             }
         }
         return $"{{ com.google.gson.JsonArray _json{depth}_ = {json}.getAsJsonArray(); int {__n} = _json{depth}_.size(); {x} = new {typeStr}; int {__index}=0; for(JsonElement {__e} : _json{depth}_) {{ {type.ElementType.Apply(JavaDeclaringTypeNameVisitor.Ins)} {__v};  {type.ElementType.Apply(this, $"{__e}", $"{__v}", depth + 1)}  {x}[{__index}++] = {__v}; }}   }}";

📄 src\Luban.Java\TypeVisitors\JavaBinUnderlyingDeserializeVisitor.cs (line 97)

             typeStr = $"{type.FinalElementType.Apply(JavaDeclaringTypeNameVisitor.Ins)}[{__n}]";
             for (int i = 0; i < type.Dimension - 1; i++)
             {
▶                typeStr += "[]";
             }
         }
         return $"{{int {__n} = {bufName}.readSize(); {fieldName} = new {typeStr};for(int {__i} = 0 ; {__i} < {__n} ; {__i}++) {{ {type.ElementType.Apply(JavaDeclaringTypeNameVisitor.Ins)} {__e};{type.ElementType.Apply(this, bufName, __e, depth + 1)} {fieldName}[{__i}] = {__e};}}}}";

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\Luban.Core\Utils\FileUtil.cs (line 179)

     public static async Task<byte[]> ReadAllBytesAsync(string file)
     {
         // File.ReadAllBytesAsync 无法读取被打开的excel文件，只好重新实现了一个
▶        using var fs = new FileStream(file, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
         long count = fs.Length;
         var bytes = new byte[count];
         int writeIndex = 0;

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Luban.Core\Utils\FileUtil.cs (line 223)

 
     public static async Task WriteAllBytesAsync(string file, byte[] bytes)
     {
▶        using var fs = new FileStream(file, FileMode.OpenOrCreate, FileAccess.Write, FileShare.ReadWrite);
         long count = bytes.LongLength;
         fs.SetLength(count);
         fs.Seek(0, SeekOrigin.Begin);

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

netch

146 total diagnostics across 10 rules

SS001 Async method with void return type 2 hits

📄 Netch\Forms\MainForm.cs (line 1276)

         Hide();
     }
 
▶    public async void Exit(bool forceExit = false, bool saveConfiguration = true)
     {
         if (!IsWaiting() && !Global.Settings.StopWhenExited && !forceExit)
         {

💬 Method Exit is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Netch\Forms\MainForm.cs (line 1276)

         Hide();
     }
 
▶    public async void Exit(bool forceExit = false, bool saveConfiguration = true)
     {
         if (!IsWaiting() && !Global.Settings.StopWhenExited && !forceExit)
         {

💬 Method Exit is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 Netch\Utils\DelayTestHelper.cs (line 15)

 
     private static readonly AsyncSemaphore PoolLock = new(16);
 
▶    public static readonly NumberRange Range = new(0, int.MaxValue / 1000);
 
     private static bool _enabled = true;

💬 The operands in the divisive expression int.MaxValue / 1000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Netch\Forms\MainForm.cs (line 106)

 
     private void RecordSize()
     {
▶        _numberBoxWidth = ServerComboBox.Width / 10;
         _numberBoxX = _numberBoxWidth * 9;
         _numberBoxWrap = _numberBoxWidth / 30;
 

💬 The operands in the divisive expression ServerComboBox.Width / 10 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 40 hits

📄 Netch\Forms\BindingForm.cs (line 20)

     protected virtual void BindTextBox<T>(TextBoxBase control, Func<T, bool> check, Action<T> save, object value)
     {
         control.Text = value.ToString();
▶        _checkActions.Add(control,
             s =>
             {
                 try

💬 Type Control is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Netch\Forms\BindingForm.cs (line 33)

                 }
             });
 
▶        _saveActions.Add(control, c => save((T)Convert.ChangeType(((TextBoxBase)c).Text, typeof(T))));
     }
 
     protected void BindCheckBox(CheckBox control, Action<bool> save, bool value)

SS017 Struct without Equals/GetHashCode/ToString overridden 10 hits

📄 Netch\Models\NatTypeTestResult.cs (line 3)

 namespace Netch.Models;
 
▶public struct NatTypeTestResult
 {
     public string? Result;
     public string? LocalEnd;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NatTypeTestResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Netch\Models\NetRoute.cs (line 6)

 
 namespace Netch.Models;
 
▶public struct NetRoute
 {
     public static NetRoute TemplateBuilder(string gateway, int interfaceIndex, int metric = 0)
     {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NetRoute. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 8 hits

📄 Netch\Controllers\Guard.cs (line 88)

             for (var i = 0; i < 1000; i++)
             {
                 await Task.Delay(50);
▶                switch (State)
                 {
                     case State.Started:
                         OnStarted();

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Netch\Forms\MainForm.cs (line 992)

             DelayTestHelper.Enabled = IsWaiting(_state);
 
             StatusText();
▶            switch (value)
             {
                 case State.Waiting:
                     ControlButton.Enabled = true;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 40 hits

📄 Netch\Controllers\Guard.cs (line 88)

             for (var i = 0; i < 1000; i++)
             {
                 await Task.Delay(50);
▶                switch (State)
                 {
                     case State.Started:
                         OnStarted();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Netch\Utils\Utils.cs (line 148)

     public static void ComponentIterator(in Component component, in Action<Component> func)
     {
         func.Invoke(component);
▶        switch (component)
         {
             case ListView listView:
                 // ListView sub item

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 2 hits

📄 Netch\Forms\SubscriptionForm.cs (line 26)

         get
         {
             if (SubscriptionLinkListView.MultiSelect)
▶                throw new Exception();
 
             return SubscriptionLinkListView.SelectedIndices.Count == 0 ? -1 : SubscriptionLinkListView.SelectedIndices[0];
         }

💬 An exception is thrown from the getter of property SelectedIndex (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 Netch\Forms\SubscriptionForm.cs (line 26)

         get
         {
             if (SubscriptionLinkListView.MultiSelect)
▶                throw new Exception();
 
             return SubscriptionLinkListView.SelectedIndices.Count == 0 ? -1 : SubscriptionLinkListView.SelectedIndices[0];
         }

💬 An exception is thrown from the getter of property SelectedIndex (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS034 Accessing Task.Result without await 4 hits

📄 Netch\Controllers\TUNController.cs (line 137)

             string binDriver = Path.Combine(Global.NetchDir, Constants.WintunDllFile);
             string sysDriver = $@"{Environment.SystemDirectory}\wintun.dll";
 
▶            var binHash = Utils.Utils.Sha256CheckSumAsync(binDriver).Result;
             var sysHash = Utils.Utils.Sha256CheckSumAsync(sysDriver).Result;
             Log.Information("Built-in  wintun.dll Hash: {Hash}", binHash);
             Log.Information("Installed wintun.dll Hash: {Hash}", sysHash);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Netch\Controllers\TUNController.cs (line 138)

             string sysDriver = $@"{Environment.SystemDirectory}\wintun.dll";
 
             var binHash = Utils.Utils.Sha256CheckSumAsync(binDriver).Result;
▶            var sysHash = Utils.Utils.Sha256CheckSumAsync(sysDriver).Result;
             Log.Information("Built-in  wintun.dll Hash: {Hash}", binHash);
             Log.Information("Installed wintun.dll Hash: {Hash}", sysHash);
             if (binHash == sysHash)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS047 LINQ traversal before filter 2 hits

📄 Netch\Forms\MainForm.cs (line 52)

 
     private void AddAddServerToolStripMenuItems()
     {
▶        foreach (var serversUtil in ServerHelper.ServerUtilDictionary.Values.OrderBy(i => i.Priority).Where(i => !string.IsNullOrEmpty(i.FullName)))
         {
             var fullName = serversUtil.FullName;
             var control = new ToolStripMenuItem

📄 Netch\Forms\MainForm.cs (line 52)

 
     private void AddAddServerToolStripMenuItems()
     {
▶        foreach (var serversUtil in ServerHelper.ServerUtilDictionary.Values.OrderBy(i => i.Priority).Where(i => !string.IsNullOrEmpty(i.FullName)))
         {
             var fullName = serversUtil.FullName;
             var control = new ToolStripMenuItem

SS066 Disposable field is not disposed 28 hits

📄 Netch\Forms\ServerForm.cs (line 21)

     private readonly Dictionary<Control, Action<object>> _saveActions = new();
 
     private int _controlLines = 2;
▶    private Label AddressLabel;
     protected TextBox AddressTextBox;
 
     private readonly IContainer components = null;

💬 Disposable field AddressLabel in type ServerForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Netch\Forms\ServerForm.cs (line 22)

 
     private int _controlLines = 2;
     private Label AddressLabel;
▶    protected TextBox AddressTextBox;
 
     private readonly IContainer components = null;

💬 Disposable field AddressTextBox in type ServerForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

NetCoreServer

138 total diagnostics across 4 rules

SS003 Integer divided by integer causing implicit rounding 64 hits

📄 source\NetCoreServer\Utilities.cs (line 25)

 
             if (absBytes >= (1024L * 1024L * 1024L * 1024L))
             {
▶                long tb = bytes / (1024L * 1024L * 1024L * 1024L);
                 long gb = (bytes % (1024L * 1024L * 1024L * 1024L)) / (1024 * 1024 * 1024);
                 sb.Append(tb);
                 sb.Append('.');

💬 The operands in the divisive expression bytes / (1024L * 1024L * 1024L * 1024L) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 source\NetCoreServer\Utilities.cs (line 26)

             if (absBytes >= (1024L * 1024L * 1024L * 1024L))
             {
                 long tb = bytes / (1024L * 1024L * 1024L * 1024L);
▶                long gb = (bytes % (1024L * 1024L * 1024L * 1024L)) / (1024 * 1024 * 1024);
                 sb.Append(tb);
                 sb.Append('.');
                 sb.Append((gb < 100) ? "0" : "");

💬 The operands in the divisive expression (bytes % (1024L * 1024L * 1024L * 1024L)) / (1024 * 1024 * 1024) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS019 Switch is missing default label 2 hits

📄 source\NetCoreServer\WebSocket.cs (line 459)

                         {
                             WsFinalReceived = true;
 
▶                            switch (WsOpcode)
                             {
                                 case WS_PING:
                                 {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 source\NetCoreServer\WebSocket.cs (line 459)

                         {
                             WsFinalReceived = true;
 
▶                            switch (WsOpcode)
                             {
                                 case WS_PING:
                                 {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 60 hits

📄 examples\HttpClient\Program.cs (line 60)

 
                 if (commands[0].ToUpper() == "HEAD")
                 {
▶                    var response = client.SendHeadRequest(commands[1]).Result;
                     Console.WriteLine(response);
                 }
                 else if (commands[0].ToUpper() == "GET")

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 examples\HttpClient\Program.cs (line 65)

                 }
                 else if (commands[0].ToUpper() == "GET")
                 {
▶                    var response = client.SendGetRequest(commands[1]).Result;
                     Console.WriteLine(response);
                 }
                 else if (commands[0].ToUpper() == "POST")

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS066 Disposable field is not disposed 12 hits

📄 source\NetCoreServer\HttpsSession.cs (line 21)

         /// <summary>
         /// Get the static content cache
         /// </summary>
▶        public FileCache Cache { get; }
 
         /// <summary>
         /// Get the HTTP request

💬 Disposable field Cache in type HttpsSession is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 source\NetCoreServer\HttpsClient.cs (line 411)

         #endregion
 
         private TaskCompletionSource<HttpResponse> _tcs = new TaskCompletionSource<HttpResponse>();
▶        private Timer _timer;
 
         private void SetResultValue(HttpResponse response)
         {

💬 Disposable field _timer in type HttpsClientEx is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Serilog

134 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 14 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 64 hits

No source samples extracted

SS066 Disposable field is not disposed 56 hits

No source samples extracted

OneOf

130 total diagnostics across 3 rules

SS004 Elementary methods of type in collection not overridden 2 hits

📄 OneOf.SourceGenerator.Tests\SourceGeneratorTests.cs (line 102)

             NestedGeneric nested1 = new List<List<string>> { new() { "a", "b", "c" } };
             Assert.True(nested1.IsT0);
 
▶            NestedGeneric nested2 = new Dictionary<List<string>, string> { { new List<string> { "a", "b", "c" }, "d" } };
             Assert.True(nested2.IsT2);
         }
 

💬 Type List is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 OneOf.SourceGenerator.Tests\SourceGeneratorTests.cs (line 102)

             NestedGeneric nested1 = new List<List<string>> { new() { "a", "b", "c" } };
             Assert.True(nested1.IsT0);
 
▶            NestedGeneric nested2 = new Dictionary<List<string>, string> { { new List<string> { "a", "b", "c" }, "d" } };
             Assert.True(nested2.IsT2);
         }
 

SS017 Struct without Equals/GetHashCode/ToString overridden 120 hits

📄 OneOf\Types\Assorted.cs (line 14)

     public struct True { }
     public struct False { }
 
▶    public struct All { }
     public struct Some { }
     
     public struct None 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct All. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 OneOf\Types\Assorted.cs (line 12)

 
     public struct Unknown { }
     public struct True { }
▶    public struct False { }
 
     public struct All { }
     public struct Some { }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct False. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS033 Async overload is available 8 hits

📄 Generator\Program.cs (line 14)

 for (var i = 1; i < 10; i++) {
     var output = GetContent(true, i);
     var outpath = Combine(sourceRoot, $"OneOf\\OneOfT{i - 1}.generated.cs");
▶    File.WriteAllText(outpath, output);
 
     var output2 = GetContent(false, i);
     var outpath2 = Combine(sourceRoot, $"OneOf\\OneOfBaseT{i - 1}.generated.cs");

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Generator\Program.cs (line 18)

 
     var output2 = GetContent(false, i);
     var outpath2 = Combine(sourceRoot, $"OneOf\\OneOfBaseT{i - 1}.generated.cs");
▶    File.WriteAllText(outpath2, output2);
 }
 
 for (var i = 10; i < 33; i++) {

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

Flow.Launcher

126 total diagnostics across 11 rules

SS001 Async method with void return type 14 hits

📄 Plugins\Flow.Launcher.Plugin.WebSearch\SearchSourceSetting.xaml.cs (line 34)

         }
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "VSTHRD100:Avoid async void methods", Justification = "<Pending>")]
▶        private async void Initialize(IList<SearchSource> sources, PluginInitContext context, Action action)
         {
             InitializeComponent();
             DataContext = _viewModel;

💬 Method Initialize is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Plugins\Flow.Launcher.Plugin.WebSearch\SearchSourceSetting.xaml.cs (line 34)

         }
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "VSTHRD100:Avoid async void methods", Justification = "<Pending>")]
▶        private async void Initialize(IList<SearchSource> sources, PluginInitContext context, Action action)
         {
             InitializeComponent();
             DataContext = _viewModel;

💬 Method Initialize is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 26 hits

📄 Plugins\Flow.Launcher.Plugin.Explorer\ViewModels\SettingsViewModel.cs (line 207)

             }
         }
 
▶        public string PreviewPanelDateFormatDemo => DateTime.Now.ToString(PreviewPanelDateFormat, CultureInfo.CurrentCulture);
         public string PreviewPanelTimeFormatDemo => DateTime.Now.ToString(PreviewPanelTimeFormat, CultureInfo.CurrentCulture);
 
         public bool ShowPreviewPanelDateTimeChoices => ShowCreatedDateInPreviewPanel || ShowModifiedDateInPreviewPanel;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Plugins\Flow.Launcher.Plugin.Explorer\ViewModels\SettingsViewModel.cs (line 208)

         }
 
         public string PreviewPanelDateFormatDemo => DateTime.Now.ToString(PreviewPanelDateFormat, CultureInfo.CurrentCulture);
▶        public string PreviewPanelTimeFormatDemo => DateTime.Now.ToString(PreviewPanelTimeFormat, CultureInfo.CurrentCulture);
 
         public bool ShowPreviewPanelDateTimeChoices => ShowCreatedDateInPreviewPanel || ShowModifiedDateInPreviewPanel;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 6 hits

📄 Flow.Launcher.Infrastructure\StringMatcher.cs (line 204)

             // return acronym match if all query char matched
             if (acronymsMatched > 0 && acronymsMatched == query.Length)
             {
▶                int acronymScore = acronymsMatched * 100 / acronymsTotalCount;
 
                 if (acronymScore >= (int)UserSettingSearchPrecision)
                 {

💬 The operands in the divisive expression acronymsMatched * 100 / acronymsTotalCount are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Flow.Launcher.Infrastructure\StringMatcher.cs (line 321)

             // A match found near the beginning of a string is scored more than a match found near the end
             // A match is scored more if the characters in the patterns are closer to each other, 
             // while the score is lower if they are more spread out
▶            var score = 100 * (query.Length + 1) / ((1 + firstIndex) + (matchLen + 1));
 
             // Give more weight to a match that is closer to the start of the string. 
             // if the first matched char is immediately before space and all strings are contained in the compare string e.g. 'world' matching 'hello world'

💬 The operands in the divisive expression 100 * (query.Length + 1) / ((1 + firstIndex) + (matchLen + 1)) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 6 hits

📄 Plugins\Flow.Launcher.Plugin.Explorer\Search\SearchManager.cs (line 157)

                     if (IsResultTypeFilteredByActionKeyword(search.Type, actions))
                         continue;
 
▶                    results.Add(ResultManager.CreateResult(query, search));
                 }
             }
             catch (OperationCanceledException)

💬 Type Result is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Plugins\Flow.Launcher.Plugin.Explorer\Search\SearchManager.cs (line 223)

 
             var retrievedDirectoryPath = FilesFolders.ReturnPreviousDirectoryIfIncompleteString(path);
 
▶            results.Add(retrievedDirectoryPath.EndsWith(":\\")
                 ? ResultManager.CreateDriveSpaceDisplayResult(retrievedDirectoryPath, query.ActionKeyword, useIndexSearch)
                 : ResultManager.CreateOpenCurrentFolderResult(retrievedDirectoryPath, query.ActionKeyword, useIndexSearch));

SS008 GetHashCode() refers to mutable or static member 22 hits

📄 Flow.Launcher.Plugin\PluginPair.cs (line 50)

         /// <returns></returns>
         public override int GetHashCode()
         {
▶            var hashcode = Metadata.ID?.GetHashCode() ?? 0;
             return hashcode;
         }
     }

💬 GetHashCode() refers to mutable property Metadata (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Plugins\Flow.Launcher.Plugin.Program\Views\Models\ProgramSource.cs (line 85)

 
         public override int GetHashCode()
         {
▶            return uniqueIdentifier.GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable field uniqueIdentifier (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 14 hits

📄 Plugins\Flow.Launcher.Plugin.Explorer\Helper\ShellContextMenuDisplayHelper.cs (line 477)

 }
 
 [StructLayout(LayoutKind.Sequential)]
▶public struct CMINVOKECOMMANDINFO
 {
     public uint cbSize;
     public uint fMask;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CMINVOKECOMMANDINFO. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Plugins\Flow.Launcher.Plugin.Explorer\Helper\ShellContextMenuDisplayHelper.cs (line 491)

 }
 
 [StructLayout(LayoutKind.Sequential)]
▶public struct MENUITEMINFO
 {
     public uint cbSize;
     public uint fMask;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MENUITEMINFO. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 2 hits

📄 Plugins\Flow.Launcher.Plugin.Explorer\Search\ResultManager.cs (line 81)

             var yOfScreenCenter = screenWithMouseCursor.WorkingArea.Top + screenWithMouseCursor.WorkingArea.Height / 2;
             var showPosition = new System.Drawing.Point((int)xOfScreenCenter, (int)yOfScreenCenter);
 
▶            switch (type)
             {
                 case ResultType.File:
                     var fileInfo = new FileInfo[] { new(path) };

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Plugins\Flow.Launcher.Plugin.Explorer\Search\ResultManager.cs (line 81)

             var yOfScreenCenter = screenWithMouseCursor.WorkingArea.Top + screenWithMouseCursor.WorkingArea.Height / 2;
             var showPosition = new System.Drawing.Point((int)xOfScreenCenter, (int)yOfScreenCenter);
 
▶            switch (type)
             {
                 case ResultType.File:
                     var fileInfo = new FileInfo[] { new(path) };

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 24 hits

📄 Plugins\Flow.Launcher.Plugin.Calculator\Main.cs (line 191)

             // Find the top-level comma that separates the two arguments of pow.
             for (var i = 0; i < argsContent.Length; i++)
             {
▶                switch (argsContent[i])
                 {
                     case '(':
                     case '[':

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Plugins\Flow.Launcher.Plugin.Calculator\Main.cs (line 191)

             // Find the top-level comma that separates the two arguments of pow.
             for (var i = 0; i < argsContent.Length; i++)
             {
▶                switch (argsContent[i])
                 {
                     case '(':
                     case '[':

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 4 hits

📄 Flow.Launcher.Core\ExternalPlugins\CommunityPluginStore.cs (line 49)

                         // one of the requests completed successfully; keep its results
                         // and cancel the remaining http requests.
                         pluginResults = result;
▶                        cts.Cancel();
                     }
                 }
                 tasks.Remove(completedTask);

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Flow.Launcher.Core\Plugin\PluginInstaller.cs (line 121)

                 throw new FileNotFoundException("The zip file does not contain a plugin.json file.");
 
             using Stream stream = pluginJsonEntry.Open();
▶            plugin = JsonSerializer.Deserialize<UserPlugin>(stream);
             plugin.IcoPath = "Images\\zipfolder.png";
             plugin.LocalInstallPath = filePath;
         }

💬 Async overload available for JsonSerializer.Deserialize (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 Flow.Launcher.Core\Plugin\PluginInstaller.cs (line 120)

             var pluginJsonEntry = archive.Entries.FirstOrDefault(x => x.Name == "plugin.json") ??
                 throw new FileNotFoundException("The zip file does not contain a plugin.json file.");
 
▶            using Stream stream = pluginJsonEntry.Open();
             plugin = JsonSerializer.Deserialize<UserPlugin>(stream);
             plugin.IcoPath = "Images\\zipfolder.png";
             plugin.LocalInstallPath = filePath;

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs (line 181)

             }
 
             var sourceBuffer = BufferManager.GetStream();
▶            using var errorBuffer = BufferManager.GetStream();
 
             var sourceCopyTask = process.StandardOutput.BaseStream.CopyToAsync(sourceBuffer, token);
             var errorCopyTask = process.StandardError.BaseStream.CopyToAsync(errorBuffer, token);

💬 RecyclableMemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 2 hits

📄 Flow.Launcher.Infrastructure\DialogJump\Models\WindowsDialog.cs (line 77)

 
         // After jumping folder, file editor handle of Save / SaveAs file dialogs cannot be found anymore
         // So we need to cache the current tab and use the original handle
▶        private IDialogJumpDialogWindowTab _currentTab { get; set; } = null;
 
         private readonly DialogType _dialogType;

💬 Disposable field _currentTab in type WindowsDialogWindow is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Flow.Launcher.Infrastructure\DialogJump\Models\WindowsDialog.cs (line 77)

 
         // After jumping folder, file editor handle of Save / SaveAs file dialogs cannot be found anymore
         // So we need to cache the current tab and use the original handle
▶        private IDialogJumpDialogWindowTab _currentTab { get; set; } = null;
 
         private readonly DialogType _dialogType;

💬 Disposable field _currentTab in type WindowsDialogWindow is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Respawn

124 total diagnostics across 3 rules

SS058 String concatenated in a loop 84 hits

📄 Respawn\MySqlAdapter.cs (line 42)

                     {
                         var args = string.Join(",", tableGroup.Tables.Select(table => $"'{table.Schema}.{table.Name}'"));
 
▶                        commandText += " AND t.TABLE_SCHEMA + '.' + t.TABLE_NAME NOT IN (" + args + ")";
                     }
                     else
                     {

📄 Respawn\MySqlAdapter.cs (line 48)

                     {
                         var args = string.Join(",", tableGroup.Tables.Select(table => $"'{table.Name}'"));
 
▶                        commandText += " AND t.TABLE_NAME NOT IN (" + args + ")";
                     }
                 }
             }

SS059 IAsyncDisposable not disposed asynchronously 16 hits

📄 Respawn.DatabaseTests\SnowflakeTests.cs (line 52)

 
         private async Task ExecuteNonQueryAsync(string commandText)
         {
▶            using (var command = _connection.CreateCommand())
             {
                 command.CommandText = commandText;
                 await command.ExecuteNonQueryAsync();

💬 DbCommand can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Respawn.DatabaseTests\SnowflakeTests.cs (line 257)

 
         private async Task InsertDataAsync(string tableName, int value)
         {
▶            using (var command = _connection.CreateCommand())
             {
                 command.CommandText = $"INSERT INTO {tableName} (Value) VALUES ({value})";
                 await command.ExecuteNonQueryAsync();

💬 DbCommand can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 24 hits

📄 Respawn.DatabaseTests\SqliteTests.cs (line 16)

     public class SqliteTests : IAsyncLifetime
     {
         private readonly ITestOutputHelper _output;
▶        private SqliteConnection _connection;
         private Database _database;
         private string _dbFileName;
 

💬 Disposable field _connection in type SqliteTests is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Respawn.DatabaseTests\SqliteTests.cs (line 17)

     {
         private readonly ITestOutputHelper _output;
         private SqliteConnection _connection;
▶        private Database _database;
         private string _dbFileName;
 
         public SqliteTests(ITestOutputHelper output) => _output = output;

💬 Disposable field _database in type SqliteTests is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Translumo

122 total diagnostics across 10 rules

SS001 Async method with void return type 8 hits

📄 src\Translumo\MVVM\ViewModels\ChatWindowViewModel.cs (line 175)

             }
         }
 
▶        private async void OnLoadedCommand()
         {
             SendHelpText();
 

💬 Method OnLoadedCommand is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 src\Translumo\MVVM\ViewModels\SettingsViewModel.cs (line 93)

             }
         }
 
▶        private async void OnAboutDialogOpened()
         {
             await DialogService.ShowDialogAsync(new AboutDialogViewModel() {HasUpdates = HasUpdates});
         }

💬 Method OnAboutDialogOpened is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\Translumo.Translation\Papago\PapagoEncodingProvider.cs (line 46)

 
         private static long GetTimeMs()
         {
▶            var time = (DateTime.Now.ToUniversalTime() - new DateTime(1970, 1, 1));
             return (long)(time.TotalMilliseconds + 0.5);
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Translumo.Translation\Papago\PapagoEncodingProvider.cs (line 46)

 
         private static long GetTimeMs()
         {
▶            var time = (DateTime.Now.ToUniversalTime() - new DateTime(1970, 1, 1));
             return (long)(time.TotalMilliseconds + 0.5);
         }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 src\Translumo.Utils\Extensions\StringExtensions.cs (line 20)

                 return 0.0;
             }
 
▶            int distanceSep = (Math.Min(str.Length, anotherStr.Length) / 2) + 1;
             StringBuilder builder = GetCommonCharacters(str, anotherStr, distanceSep);
             int length = builder.Length;
             if (length == 0)

💬 The operands in the divisive expression Math.Min(str.Length, anotherStr.Length) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Translumo.Infrastructure\Encryption\AesEncryptionService.cs (line 10)

 {
     public class AesEncryptionService : IEncryptionService
     {
▶        private const int AES_BLOCK_BYTE_SIZE = 128 / 8;
 
         private const int PASSWORD_SALT_BYTE_SIZE = 128 / 8;
         private const int PASSWORD_BYTE_SIZE = 256 / 8;

💬 The operands in the divisive expression 128 / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS005 Equals() and GetHashCode() not implemented together 8 hits

📄 src\Translumo\HotKeys\GamepadHotKeyInfo.cs (line 5)

 
 namespace Translumo.HotKeys
 {
▶    public class GamepadHotKeyInfo
     {
         public GamepadKeyCode Key { get; set; }
 

💬 Equals() and GetHashcode() must be implemented together on GamepadHotKeyInfo (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 src\Translumo\HotKeys\HotKeyInfo.cs (line 5)

 
 namespace Translumo.HotKeys
 {
▶    public class HotKeyInfo
     {
         public Key Key { get; set; }
 

💬 Equals() and GetHashcode() must be implemented together on HotKeyInfo (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 src\Translumo.Infrastructure\Language\LanguageDescriptor.cs (line 46)

 
         public override int GetHashCode()
         {
▶            return Language.GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable property Language (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Translumo.Infrastructure\Language\LanguageDescriptor.cs (line 46)

 
         public override int GetHashCode()
         {
▶            return Language.GetHashCode();
         }
     }
 }

💬 GetHashCode() refers to mutable property Language (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 2 hits

📄 src\Translumo.Utils\Http\HttpReader.cs (line 99)

             {
                 if (ThrowExceptions)
                 {
▶                    throw ex;
                 }
                 return new HttpResponse(isSuccessful: false, null, ex);
             }

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 src\Translumo.Utils\Http\HttpReader.cs (line 99)

             {
                 if (ThrowExceptions)
                 {
▶                    throw ex;
                 }
                 return new HttpResponse(isSuccessful: false, null, ex);
             }

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 12 hits

📄 src\Translumo.Utils\IntertopStruct\Rect.cs (line 6)

 namespace Translumo.Utils.IntertopStruct
 {
     [StructLayout(LayoutKind.Sequential)]
▶    public struct RECT
     {
         public int Left; // x position of upper-left corner
         public int Top; // y position of upper-left corner

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RECT. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\Translumo.Infrastructure\Python\PythonCommand.cs (line 11)

 
 namespace Translumo.Infrastructure.Python
 {
▶    public struct PythonCommandResult 
     {
         public string Output { get; init; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PythonCommandResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 4 hits

📄 src\Translumo\Utils\ChatWindowConfigurationExtensions.cs (line 16)

 
         public static Brush GetTextForegroundBrush(this ChatWindowConfiguration configuration, TextTypes textType)
         {
▶            switch (textType)
             {
                 case TextTypes.Translation:
                     return GetTranslationTextBrush(configuration.FontColor);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Translumo\Utils\ChatWindowConfigurationExtensions.cs (line 16)

 
         public static Brush GetTextForegroundBrush(this ChatWindowConfiguration configuration, TextTypes textType)
         {
▶            switch (textType)
             {
                 case TextTypes.Translation:
                     return GetTranslationTextBrush(configuration.FontColor);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 26 hits

📄 src\Translumo.OCR\WindowsOCR\WindowsOCREngine.cs (line 45)

             using (var randStream = new InMemoryRandomAccessStream())
             {
                 bitmap.Save(randStream.AsStream(), ImgFormat);
▶                var decoder = BitmapDecoder.CreateAsync(randStream).AsTask().Result;
                 softwareBitmap = decoder.GetSoftwareBitmapAsync().AsTask().Result;
             }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Translumo.OCR\WindowsOCR\WindowsOCREngine.cs (line 46)

             {
                 bitmap.Save(randStream.AsStream(), ImgFormat);
                 var decoder = BitmapDecoder.CreateAsync(randStream).AsTask().Result;
▶                softwareBitmap = decoder.GetSoftwareBitmapAsync().AsTask().Result;
             }
 
             OcrResult result = MsEngine.RecognizeAsync(softwareBitmap).AsTask().Result;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS066 Disposable field is not disposed 48 hits

📄 src\Translumo.Infrastructure\MachineLearning\MlPredictor.cs (line 15)

 
         private readonly MLContext _context;
         private ITransformer _model;
▶        private PredictionEngine<TInput, TOutput> _predictor;
 
         public MlPredictor()
         {

💬 Disposable field _predictor in type MlPredictor is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Translumo.OCR\Tesseract\TesseractOCREngine.cs (line 20)

         public virtual int Confidence => 1;
         public virtual byte PrimaryPriority => 3;
 
▶        protected TesseractEngine Engine;
         protected bool IsInitialized;
 
         protected const string LINES_SEPARATOR = "\n";

💬 Disposable field Engine in type TesseractOCREngine is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

modular-monolith-with-ddd

116 total diagnostics across 7 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 20 hits

📄 src\BuildingBlocks\Tests\IntegrationTests\Probing\Timeout.cs (line 14)

 
         public bool HasTimedOut()
         {
▶            return DateTime.Now > _endTime;
         }
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\BuildingBlocks\Tests\IntegrationTests\Probing\Timeout.cs (line 9)

 
         public Timeout(int duration)
         {
▶            this._endTime = DateTime.Now.AddMilliseconds(duration);
         }
 
         public bool HasTimedOut()

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\API\CompanyName.MyMeetings.API\Configuration\Extensions\SwaggerExtensions.cs (line 37)

                 options.AddSecurityRequirement(new OpenApiSecurityRequirement
                 {
                     {
▶                        new OpenApiSecurityScheme
                         {
                             Reference = new OpenApiReference
                             {

💬 Type OpenApiSecurityScheme is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\API\CompanyName.MyMeetings.API\Configuration\Extensions\SwaggerExtensions.cs (line 37)

                 options.AddSecurityRequirement(new OpenApiSecurityRequirement
                 {
                     {
▶                        new OpenApiSecurityScheme
                         {
                             Reference = new OpenApiReference
                             {

SS017 Struct without Equals/GetHashCode/ToString overridden 16 hits

📄 src\BuildingBlocks\Application\Emails\EmailMessage.cs (line 3)

 namespace CompanyName.MyMeetings.BuildingBlocks.Application.Emails
 {
▶    public struct EmailMessage
     {
         public string To { get; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EmailMessage. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\BuildingBlocks\Application\Queries\PageData.cs (line 3)

 namespace CompanyName.MyMeetings.BuildingBlocks.Application.Queries
 {
▶    public struct PageData
     {
         public int Offset { get; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PageData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS023 Exception thrown from property getter 4 hits

📄 src\API\CompanyName.MyMeetings.API\Configuration\ExecutionContext\ExecutionContextAccessor.cs (line 29)

                         x => x.Type == "sub").Value);
                 }
 
▶                throw new ApplicationException("User context is not available");
             }
         }
 

💬 An exception is thrown from the getter of property UserId (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\API\CompanyName.MyMeetings.API\Configuration\ExecutionContext\ExecutionContextAccessor.cs (line 44)

                         _httpContextAccessor.HttpContext.Request.Headers[CorrelationMiddleware.CorrelationHeaderKey]);
                 }
 
▶                throw new ApplicationException("Http context and correlation id is not available");
             }
         }
 

💬 An exception is thrown from the getter of property CorrelationId (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS032 Thread.Sleep used in async method 2 hits

📄 src\Tests\SUT\SeedWork\AsyncOperationsHelper.cs (line 92)

                     return;
                 }
 
▶                Thread.Sleep(100);
             }
 
             throw new Exception("Timeout for processing elapsed.");

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 src\Tests\SUT\SeedWork\AsyncOperationsHelper.cs (line 92)

                     return;
                 }
 
▶                Thread.Sleep(100);
             }
 
             throw new Exception("Timeout for processing elapsed.");

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS059 IAsyncDisposable not disposed asynchronously 64 hits

📄 src\Modules\Meetings\Infrastructure\Configuration\EventsBus\IntegrationEventGenericHandler.cs (line 15)

     {
         public async Task Handle(T @event)
         {
▶            using (var scope = MeetingsCompositionRoot.BeginLifetimeScope())
             {
                 using (var connection = scope.Resolve<ISqlConnectionFactory>().GetOpenConnection())
                 {

💬 ILifetimeScope can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Modules\Meetings\Infrastructure\MeetingsModule.cs (line 23)

 
         public async Task<TResult> ExecuteQueryAsync<TResult>(IQuery<TResult> query)
         {
▶            using (var scope = MeetingsCompositionRoot.BeginLifetimeScope())
             {
                 var mediator = scope.Resolve<IMediator>();
 

💬 ILifetimeScope can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 8 hits

📄 src\Modules\Meetings\Infrastructure\MeetingsContext.cs (line 38)

 
         public DbSet<MeetingMemberCommentLike> MeetingMemberCommentLikes { get; set; }
 
▶        private readonly ILoggerFactory _loggerFactory;
 
         public MeetingsContext(DbContextOptions options, ILoggerFactory loggerFactory)
             : base(options)

💬 Disposable field _loggerFactory in type MeetingsContext is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Modules\UserAccess\Infrastructure\UserAccessContext.cs (line 20)

 
         public DbSet<InternalCommand> InternalCommands { get; set; }
 
▶        private readonly ILoggerFactory _loggerFactory;
 
         public UserAccessContext(DbContextOptions options, ILoggerFactory loggerFactory)
             : base(options)

💬 Disposable field _loggerFactory in type UserAccessContext is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

imewlconverter

108 total diagnostics across 8 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 16 hits

📄 src\ImeWlConverterCore\ConsoleRun.cs (line 358)

 
     private void MainBody_ProcessNotice(string message)
     {
▶        Console.WriteLine(DateTime.Now.ToString("HH:mm:ss") + "\t" + message);
     }
 
     [RequiresUnreferencedCode("Calls System.Reflection.Assembly.GetTypes()")]

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\ImeWlConverterCore\IME\Win10MsWubi.cs (line 115)

         bw.Write(BitConverter.GetBytes(0x40 + 4 * wlList.Count)); //phrase_start=phrase_offset_start + 4*phrase_count
         bw.Write(BitConverter.GetBytes(0)); //phrase_end input after process all!
         bw.Write(BitConverter.GetBytes(wlList.Count)); //phrase_count
▶        bw.Write(BitConverter.GetBytes(DateTime.Now.Ticks)); //timestamp
         bw.Write(BitConverter.GetBytes((long)0)); //0
         bw.Write(BitConverter.GetBytes((long)0)); //0
         bw.Write(BitConverter.GetBytes((long)0)); //0

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 26 hits

📄 src\ImeWlConverterCore\IME\ZiGuangPinyinUwl.cs (line 118)

         var wl = new WordLibrary();
         var lenWord = stream.ReadByte();
         var lenCode = stream.ReadByte();
▶        lenCode = lenCode % 0x10 * 2 + lenWord / 0x80;
         lenWord = lenWord % 0x80 - 1;
         lenByte = 4 + lenWord + lenCode * 2;
 

💬 The operands in the divisive expression lenWord / 0x80 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\ImeWlConverterCore\Filters\RankPercentageFilter.cs (line 29)

     public WordLibraryList Filter(WordLibraryList list)
     {
         if (Percentage == 100) return list;
▶        var count = list.Count * Percentage / 100;
         list.Sort((a, b) => a.Rank - b.Rank);
         var result = new WordLibraryList();
         for (var i = 0; i < count; i++) result.Add(list[i]);

💬 The operands in the divisive expression list.Count * Percentage / 100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 20 hits

📄 src\ImeWlConverterCore\Generaters\Cangjie5Generater.cs (line 31)

 {
     public bool IgnoreContainRule { get; set; }
 
▶    public struct Cangjie
     {
         public string Code { get; set; }
         public string SplitCode { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Cangjie. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\ImeWlConverterCore\Generaters\ZhengmaGenerater.cs (line 79)

 
     #region Nested type: Zhengma
 
▶    private struct Zhengma
     {
         /// <summary>
         ///     构词码

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Zhengma. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 6 hits

📄 src\ImeWlConverterCore\IME\Rime.cs (line 83)

 
     private string GetLineSplit(OperationSystem os)
     {
▶        switch (os)
         {
             case OperationSystem.Windows:
                 return "\r\n";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\ImeWlConverterCore\IME\RimeUserDb.cs (line 81)

 
     private string GetLineSplit(OperationSystem os)
     {
▶        switch (os)
         {
             case OperationSystem.Windows:
                 return "\r\n";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 src\ImeWlConverterCore\ComboBoxShowAttribute.cs (line 22)

 
 namespace Studyzy.IMEWLConverter;
 
▶public class ComboBoxShowAttribute : Attribute
 {
     public ComboBoxShowAttribute(string name, string shortCode, int index)
     {

💬 ComboBoxShowAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\ImeWlConverterCore\ComboBoxShowAttribute.cs (line 22)

 
 namespace Studyzy.IMEWLConverter;
 
▶public class ComboBoxShowAttribute : Attribute
 {
     public ComboBoxShowAttribute(string name, string shortCode, int index)
     {

💬 ComboBoxShowAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS049 Comparing strings without StringComparison 6 hits

📄 src\ImeWlConverterCore\ConsoleRun.cs (line 221)

             _ => BuildType.None
         };
 
▶        pattern.ContainCode = format[6].ToString().ToLower() == "y";
 
         if (format.Length > 8)
         {

📄 src\ImeWlConverterCore\ConsoleRun.cs (line 225)

 
         if (format.Length > 8)
         {
▶            pattern.ContainRank = format[8].ToString().ToLower() == "y";
         }
         else
         {

SS058 String concatenated in a loop 28 hits

📄 src\ImeWlConverterCore\Helpers\CollectionHelper.cs (line 79)

         //循环当前数组
         foreach (var item in astr)
             if (count + 1 < list.Count)
▶                temp += Descartes(list, count + 1, result, data + item);
             else
                 result.Add(data + item);
 

📄 src\ImeWlConverterCore\Generaters\Cangjie5Generater.cs (line 279)

                         if (arr[0].Length > 2) lastCode = arr[0][arr[0].Length - 1];
                     }
 
▶                    code += lastCode;
                 }
 
                 if (!result.Contains(code))

SS066 Disposable field is not disposed 4 hits

📄 src\ImeWlConverterCore\MainBody.cs (line 41)

     private int currentStatus;
     private bool isImportProgress;
     private string processMessage;
▶    private Timer timer;
 
     public MainBody()
     {

💬 Disposable field timer in type MainBody is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\IME WL Converter Win\Forms\MainForm.cs (line 51)

     private IWordLibraryImport import;
 
     //private Encoding ld2WordEncoding=Encoding.UTF8;
▶    private MainBody mainBody;
     private IWordRankGenerater wordRankGenerater = new DefaultWordRankGenerater();
     private bool exportDirectly => toolStripMenuItemExportDirectly.Checked;
 

💬 Disposable field mainBody in type MainForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

C-Sharp-Algorithms

108 total diagnostics across 6 rules

SS003 Integer divided by integer causing implicit rounding 66 hits

📄 DataStructures\Common\Helpers.cs (line 46)

             int length = text.Length;
             int charactersToPad = newWidth - length;
             if (charactersToPad < 0) throw new ArgumentException("New width must be greater than string length.", "newWidth");
▶            int padLeft = charactersToPad / 2 + charactersToPad % 2;
             //add a space to the left if the string is an odd number
             int padRight = charactersToPad / 2;
 

💬 The operands in the divisive expression charactersToPad / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 DataStructures\Common\Helpers.cs (line 48)

             if (charactersToPad < 0) throw new ArgumentException("New width must be greater than string length.", "newWidth");
             int padLeft = charactersToPad / 2 + charactersToPad % 2;
             //add a space to the left if the string is an odd number
▶            int padRight = charactersToPad / 2;
 
             return new String(fillerCharacter, padLeft) + text + new String(fillerCharacter, padRight);
         }

SS018 Switch does not handle all enum options 2 hits

📄 DataStructures\Heaps\MinPriorityQueue.cs (line 116)

             {
                 object maxValue = default(TPriority);
                 TypeCode typeCode = Type.GetTypeCode(typeof(TPriority));
▶                switch (typeCode)
                 {
                     case TypeCode.Byte:
                         maxValue = byte.MaxValue;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 DataStructures\Heaps\MinPriorityQueue.cs (line 116)

             {
                 object maxValue = default(TPriority);
                 TypeCode typeCode = Type.GetTypeCode(typeof(TPriority));
▶                switch (typeCode)
                 {
                     case TypeCode.Byte:
                         maxValue = byte.MaxValue;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 6 hits

📄 DataStructures\Heaps\MinPriorityQueue.cs (line 116)

             {
                 object maxValue = default(TPriority);
                 TypeCode typeCode = Type.GetTypeCode(typeof(TPriority));
▶                switch (typeCode)
                 {
                     case TypeCode.Byte:
                         maxValue = byte.MaxValue;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 DataStructures\Heaps\BinomialMinHeap.cs (line 142)

                 whichCase += (treeRoot2 == null ? 0 : 2);
                 whichCase += (carryNode == null ? 0 : 4);
 
▶                switch (whichCase)
                 {
                     case 0: /* No trees */
                     case 1: /* Only this */

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS020 Test method without public modifier 14 hits

📄 UnitTest\AlgorithmsTests\BinaryTreeRecursiveWalkerTests.cs (line 30)

         #region <<Test Tree Traversal methods>>
 
         [Fact]
▶        private static void TestPreOrderTraversal()
         {
             var preOrder = BinaryTreeRecursiveWalker.TraversalMode.PreOrder;
 

💬 Test method "TestPreOrderTraversal" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 UnitTest\AlgorithmsTests\BinaryTreeRecursiveWalkerTests.cs (line 53)

         }
 
         [Fact]
▶        private static void TestInOrderTraversal()
         {
             var inOrder = BinaryTreeRecursiveWalker.TraversalMode.InOrder;
 

💬 Test method "TestInOrderTraversal" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS023 Exception thrown from property getter 18 hits

📄 DataStructures\Lists\Stack.cs (line 71)

                 }
                 catch (Exception)
                 {
▶                    throw new Exception("Stack is empty.");
                 }
             }
         }

💬 An exception is thrown from the getter of property Top (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 DataStructures\Lists\ArrayList.cs (line 169)

             {
                 if (Count == 0)
                 {
▶                    throw new IndexOutOfRangeException("List is empty.");
                 }
 
                 return _collection[0];

💬 An exception is thrown from the getter of property First (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS058 String concatenated in a loop 2 hits

📄 DataStructures\Graphs\CliqueGraph.cs (line 39)

                 string ret = "{";
                 foreach (var x in this)
                 {
▶                    ret += x.ToString() + " ";
                 }
                 ret += "}";
                 return ret;

📄 DataStructures\Graphs\CliqueGraph.cs (line 39)

                 string ret = "{";
                 foreach (var x in this)
                 {
▶                    ret += x.ToString() + " ";
                 }
                 ret += "}";
                 return ret;

videoduplicatefinder

102 total diagnostics across 12 rules

SS001 Async method with void return type 26 hits

📄 VDF.Core\ScanEngine.cs (line 123)

 		public static bool FFprobeExists => !string.IsNullOrEmpty(FFProbeEngine.FFprobePath);
 		public static bool NativeFFmpegExists => FFTools.FFmpegNative.FFmpegHelper.DoFFmpegLibraryFilesExist;
 
▶		public async void StartSearch() {
 			PrepareSearch();
 			SearchTimer.Start();
 			ElapsedTimer.Start();

💬 Method StartSearch is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 VDF.Core\ScanEngine.cs (line 148)

 			}
 		}
 
▶		public async void StartCompare() {
 			PrepareCompare();
 			SearchTimer.Start();
 			ElapsedTimer.Start();

💬 Method StartCompare is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 VDF.Core\ScanEngine.cs (line 59)

 		readonly Stopwatch SearchTimer = new();
 		public Stopwatch ElapsedTimer = new();
 		int processedFiles;
▶		DateTime startTime = DateTime.Now;
 		DateTime lastProgressUpdate = DateTime.MinValue;
 		static readonly TimeSpan progressUpdateIntervall = TimeSpan.FromMilliseconds(300);
 		const int maxExcludedLogsPerReason = 5;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 VDF.Core\Utils\Logger.cs (line 29)

 #pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
 		static readonly object lockObject = new();
 		public void Info(string text) {
▶			LogItemAdded?.Invoke($"{DateTime.Now:HH:mm:ss} => {text}");
 			lock (lockObject) {
 				File.AppendAllText(Path.Combine(CoreUtils.CurrentFolder, "log.txt"), $"{DateTime.Now:HH:mm:ss} => {text}{Environment.NewLine}");
 			}

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 VDF.Core\ScanEngine.cs (line 107)

 								lastProgressUpdate + progressUpdateIntervall < DateTime.UtcNow;
 			if (!pushUpdate) return;
 			lastProgressUpdate = DateTime.UtcNow;
▶			var timeRemaining = TimeSpan.FromTicks(DateTime.UtcNow.Subtract(startTime).Ticks *
 									(scanProgressMaxValue - (processedFiles + 1)) / (processedFiles + 1));
 			Progress?.Invoke(this,
 							new ScanProgressChangedEventArgs {

💬 The operands in the divisive expression DateTime.UtcNow.Subtract(startTime).Ticks *

📄 VDF.Core\ScanEngine.cs (line 107)

 								lastProgressUpdate + progressUpdateIntervall < DateTime.UtcNow;
 			if (!pushUpdate) return;
 			lastProgressUpdate = DateTime.UtcNow;
▶			var timeRemaining = TimeSpan.FromTicks(DateTime.UtcNow.Subtract(startTime).Ticks *
 									(scanProgressMaxValue - (processedFiles + 1)) / (processedFiles + 1));
 			Progress?.Invoke(this,
 							new ScanProgressChangedEventArgs {

💬 The operands in the divisive expression DateTime.UtcNow.Subtract(startTime).Ticks *

SS004 Elementary methods of type in collection not overridden 8 hits

📄 VDF.GUI\ViewModels\MainWindowVM.cs (line 1536)

 					else
 						ScanEngine.RemoveFromDatabase(fe);
 
▶					actuallyDeleted.Add(dub);
 				}
 				catch (Exception ex) {
 					Logger.Instance.Info($"Failed to delete '{dub.ItemInfo.Path}': {ex.Message}\n{ex.StackTrace}");

💬 Type DuplicateItemVM is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 VDF.GUI\ViewModels\MainWindowVM_Filter.cs (line 250)

 			if (!n.IsGroup)
 				return n.Item!.ItemInfo.GroupId;
 
▶			if (_groupNodeToGuid.TryGetValue(n, out var gid))
 				return gid;
 
 			// Find first leaf in AllChildren to read its GroupId

💬 Type RowNode is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 6 hits

📄 VDF.Core\FileEntry.cs (line 120)

 				StringComparison.OrdinalIgnoreCase :
 				StringComparison.Ordinal);
 
▶		public override int GetHashCode() => CoreUtils.IsWindows ?
 			StringComparer.OrdinalIgnoreCase.GetHashCode(Path) :
 			HashCode.Combine(Path);
 	}

💬 GetHashCode() refers to mutable field IsWindows (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 VDF.Core\FileEntry.cs (line 121)

 				StringComparison.Ordinal);
 
 		public override int GetHashCode() => CoreUtils.IsWindows ?
▶			StringComparer.OrdinalIgnoreCase.GetHashCode(Path) :
 			HashCode.Combine(Path);
 	}
 }

💬 GetHashCode() refers to mutable property Path (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 10 hits

📄 VDF.Core\ScanProgressChangedEventArgs.cs (line 20)

 using System;
 
 namespace VDF.Core {
▶	public struct ScanProgressChangedEventArgs {
 
 		public string CurrentFile;
 		public int CurrentPosition;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ScanProgressChangedEventArgs. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 VDF.Core\FFTools\FfmpegEngine.cs (line 278)

 		}
 	}
 
▶	internal struct FfmpegSettings {
 		public byte GrayScale;
 		public byte Fullsize;
 		public string File;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FfmpegSettings. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 6 hits

📄 VDF.GUI\ViewModels\MainWindowVM_FfmpegDownloader.cs (line 141)

 
 			Architecture arch = RuntimeInformation.ProcessArchitecture;
 			if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) {
▶				switch (arch) {
 				case Architecture.X64:
 					plans.Add(new FfmpegDownloadPlan(
 						new Uri($"https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n{versionTag}-latest-win64-gpl-shared-{versionTag}.zip"),

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 VDF.GUI\ViewModels\MainWindowVM_FfmpegDownloader.cs (line 166)

 				}
 			}
 			else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) {
▶				switch (arch) {
 				case Architecture.X64:
 					plans.Add(new FfmpegDownloadPlan(
 						new Uri($"https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n{versionTag}-latest-linux64-gpl-shared-{versionTag}.tar.xz"),

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 8 hits

📄 VDF.GUI\ViewModels\MainWindowVM_FfmpegDownloader.cs (line 141)

 
 			Architecture arch = RuntimeInformation.ProcessArchitecture;
 			if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) {
▶				switch (arch) {
 				case Architecture.X64:
 					plans.Add(new FfmpegDownloadPlan(
 						new Uri($"https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n{versionTag}-latest-win64-gpl-shared-{versionTag}.zip"),

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 VDF.GUI\ViewModels\MainWindowVM_FfmpegDownloader.cs (line 166)

 				}
 			}
 			else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) {
▶				switch (arch) {
 				case Architecture.X64:
 					plans.Add(new FfmpegDownloadPlan(
 						new Uri($"https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n{versionTag}-latest-linux64-gpl-shared-{versionTag}.tar.xz"),

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 VDF.GUI\ViewModels\DuplicateItemVM.cs (line 70)

 				if (string.IsNullOrEmpty(ThumbnailKey)) return null;
 				if (ThumbCacheHelpers.Provider == null)
 #if DEBUG
▶					throw new InvalidOperationException("No active thumbnail provider");
 #else
 					return null;
 #endif

💬 An exception is thrown from the getter of property Thumbnail (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 VDF.GUI\ViewModels\DuplicateItemVM.cs (line 88)

 				}
 				catch {
 #if DEBUG
▶					throw;
 #endif
 					return null;
 				}

💬 An exception is thrown from the getter of property Thumbnail (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 10 hits

📄 VDF.GUI\ViewModels\CustomSelectionVM.cs (line 92)

 			if (string.IsNullOrEmpty(result)) return;
 
 			try {
▶				File.WriteAllText(result, JsonSerializer.Serialize(Data));
 			}
 			catch (Exception ex) {
 				await MessageBoxService.Show($"Saving to file has failed: {ex.Message}");

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 VDF.GUI\ViewModels\CustomSelectionVM.cs (line 108)

 			if (string.IsNullOrEmpty(result)) return;
 
 			try {
▶				Data = JsonSerializer.Deserialize<CustomSelectionData>(File.ReadAllText(result))!;
 
 			}
 			catch (Exception ex) {

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS059 IAsyncDisposable not disposed asynchronously 10 hits

📄 VDF.GUI\ViewModels\MainWindowVM.cs (line 934)

 
 						if (File.Exists(packPath) && Utils.ThumbCacheHelpers.Provider != null) {
 							var packEntry = zip.CreateEntry("thumbs.pack", CompressionLevel.NoCompression);
▶							using var es = packEntry.Open();
 							Utils.ThumbCacheHelpers.Provider.CopyTo(es);
 						}
 

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 VDF.GUI\ViewModels\MainWindowVM.cs (line 940)

 
 						if (File.Exists(idxPath)) {
 							var idxEntry = zip.CreateEntry("thumbs.idx", CompressionLevel.NoCompression);
▶							using var es = idxEntry.Open();
 							using var fs2 = File.OpenRead(idxPath);
 							fs2.CopyTo(es);
 						}

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 2 hits

📄 VDF.GUI\Utils\ThumbnailStore.cs (line 192)

 	}
 
 	internal sealed class LengthCountingStream : Stream {
▶		readonly Stream _inner;
 		public long BytesWritten { get; private set; }
 		public LengthCountingStream(Stream inner) => _inner = inner;
 		public override bool CanRead => false; public override bool CanSeek => false; public override bool CanWrite => true;

💬 Disposable field _inner in type LengthCountingStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 VDF.GUI\Utils\ThumbnailStore.cs (line 192)

 	}
 
 	internal sealed class LengthCountingStream : Stream {
▶		readonly Stream _inner;
 		public long BytesWritten { get; private set; }
 		public LengthCountingStream(Stream inner) => _inner = inner;
 		public override bool CanRead => false; public override bool CanSeek => false; public override bool CanWrite => true;

💬 Disposable field _inner in type LengthCountingStream is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

CAP

94 total diagnostics across 6 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 52 hits

No source samples extracted

SS033 Async overload is available 24 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 2 hits

No source samples extracted

SS051 Locking on mutable reference 2 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 8 hits

No source samples extracted

SS066 Disposable field is not disposed 6 hits

No source samples extracted

ink

94 total diagnostics across 11 rules

SS003 Integer divided by integer causing implicit rounding 8 hits

📄 ink-engine-runtime\NativeFunctionCall.cs (line 334)

                 AddIntBinaryOp(Add,      (x, y) => x + y);
                 AddIntBinaryOp(Subtract, (x, y) => x - y);
                 AddIntBinaryOp(Multiply, (x, y) => x * y);
▶                AddIntBinaryOp(Divide,   (x, y) => x / y);
                 AddIntBinaryOp(Mod,      (x, y) => x % y); 
                 AddIntUnaryOp (Negate,   x => -x); 
 

💬 The operands in the divisive expression x / y are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 ink-engine-runtime\Story.cs (line 2791)

 
             var seqCountVal = state.PopEvaluationStack () as IntValue;
             var seqCount = seqCountVal.value;
▶            var loopIndex = seqCount / numElements;
             var iterationIndex = seqCount % numElements;
 
             // Generate the same shuffle based on:

💬 The operands in the divisive expression seqCount / numElements are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 ink-engine-runtime\StoryState.cs (line 1145)

 					foreach (var n in rawList.originNames) {
                         ListDefinition def = null;
                         story.listDefinitions.TryListGetDefinition (n, out def);
▶						if( !rawList.origins.Contains(def) )
 							rawList.origins.Add (def);
                     }
                 }

💬 Type ListDefinition is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 ink-engine-runtime\StoryState.cs (line 1145)

 					foreach (var n in rawList.originNames) {
                         ListDefinition def = null;
                         story.listDefinitions.TryListGetDefinition (n, out def);
▶						if( !rawList.origins.Contains(def) )
 							rawList.origins.Add (def);
                     }
                 }

SS008 GetHashCode() refers to mutable or static member 20 hits

📄 ink-engine-runtime\Divert.cs (line 100)

         {
             if (hasVariableTarget) {
                 const int variableTargetSalt = 12345;
▶                return variableDivertName.GetHashCode() + variableTargetSalt;
             } else {
                 const int pathTargetSalt = 54321;
                 return targetPath.GetHashCode() + pathTargetSalt;

💬 GetHashCode() refers to mutable property variableDivertName (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 ink-engine-runtime\Divert.cs (line 103)

                 return variableDivertName.GetHashCode() + variableTargetSalt;
             } else {
                 const int pathTargetSalt = 54321;
▶                return targetPath.GetHashCode() + pathTargetSalt;
             }
         }
 

💬 GetHashCode() refers to mutable property targetPath (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS013 Rethrow exception without losing stacktrace 2 hits

📄 inklecate\CommandLineTool.cs (line 205)

                         OnError (e.Message, ErrorType.Error);
                         PrintAllMessages ();
                     } else {
▶                        throw e;
                     }
                 } catch (System.Exception e) {
                     string storyPath = "<END>";

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

📄 inklecate\CommandLineTool.cs (line 205)

                         OnError (e.Message, ErrorType.Error);
                         PrintAllMessages ();
                     } else {
▶                        throw e;
                     }
                 } catch (System.Exception e) {
                     string storyPath = "<END>";

💬 Rethrown exception loses the stacktrace. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS013-RethrowExceptionWithoutLosingStacktrace.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 26 hits

📄 ink-engine-runtime\SearchResult.cs (line 10)

     // try to recover by finding an approximate result by working up the story hierarchy
     // in the path to find the closest valid container. Instead of crashing horribly,
     // we might see some slight oddness in the content, but hopefully it recovers!
▶    public struct SearchResult
     {
         public Runtime.Object obj;
         public bool approximate;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SearchResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ink-engine-runtime\Pointer.cs (line 13)

     /// possible to increment the pointer (move the story forwards) in a way that's as
     /// native to the internal engine as possible.
     /// </summary>
▶	public struct Pointer
 	{
 		public Container container;
 		public int index;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Pointer. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 12 hits

📄 ink-engine-runtime\SimpleJson.cs (line 551)

                     if (c < ' ')
                     {
                         // Don't write any control characters except \n and \t
▶                        switch (c)
                         {
                             case '\n':
                                 _writer.Write("\\n");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 ink-engine-runtime\SimpleJson.cs (line 551)

                     if (c < ' ')
                     {
                         // Don't write any control characters except \n and \t
▶                        switch (c)
                         {
                             case '\n':
                                 _writer.Write("\\n");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 2 hits

📄 tests\Tests.cs (line 624)

             Assert.AreEqual("gather\ntest\nchoice content\ngather\nsecond time round\n", story.ContinueMaximally());
         }
 
▶        public void TestElseBranches()
         {
             var storyStr =
                 @"

💬 Method TestElseBranches might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 tests\Tests.cs (line 624)

             Assert.AreEqual("gather\ntest\nchoice content\ngather\nsecond time round\n", story.ContinueMaximally());
         }
 
▶        public void TestElseBranches()
         {
             var storyStr =
                 @"

💬 Method TestElseBranches might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

SS023 Exception thrown from property getter 10 hits

📄 ink-engine-runtime\Value.cs (line 264)

     {
         public Path targetPath { get { return this.value; } set { this.value = value; } }
         public override ValueType valueType { get { return ValueType.DivertTarget; } }
▶        public override bool isTruthy { get { throw new System.Exception("Shouldn't be checking the truthiness of a divert target"); } }
             
         public DivertTargetValue(Path targetPath) : base(targetPath)
         {

💬 An exception is thrown from the getter of property isTruthy (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 ink-engine-runtime\Value.cs (line 293)

     {
         public string variableName { get { return this.value; } set { this.value = value; } }
         public override ValueType valueType { get { return ValueType.VariablePointer; } }
▶        public override bool isTruthy { get { throw new System.Exception("Shouldn't be checking the truthiness of a variable pointer"); } }
 
         // Where the variable is located
         // -1 = default, unknown, yet to be determined

💬 An exception is thrown from the getter of property isTruthy (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS024 Exception thrown from static constructor 4 hits

📄 ink-engine-runtime\JsonSerialisation.cs (line 743)

 
             for (int i = 0; i < (int)ControlCommand.CommandType.TOTAL_VALUES; ++i) {
                 if (_controlCommandNames [i] == null)
▶                    throw new System.Exception ("Control command not accounted for in serialisation");
             }
         }
 

💬 An exception is thrown from Json its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

📄 ink-engine-runtime\JsonSerialisation.cs (line 743)

 
             for (int i = 0; i < (int)ControlCommand.CommandType.TOTAL_VALUES; ++i) {
                 if (_controlCommandNames [i] == null)
▶                    throw new System.Exception ("Control command not accounted for in serialisation");
             }
         }
 

💬 An exception is thrown from Json its static constructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS024-ExceptionThrownFromStaticConstructor.md)

SS057 Collection manipulated during traversal 4 hits

📄 ink-engine-runtime\StoryState.cs (line 568)

             // and we can simply ref-copy the choices with their existing threads.
             if( forBackgroundSave ) {
                 foreach(var choice in _currentFlow.currentChoices)
▶                    copy._currentFlow.currentChoices.Add(choice.Clone());
             } else {
                 copy._currentFlow.currentChoices.AddRange(_currentFlow.currentChoices);
             }

📄 ink-engine-runtime\StoryState.cs (line 568)

             // and we can simply ref-copy the choices with their existing threads.
             if( forBackgroundSave ) {
                 foreach(var choice in _currentFlow.currentChoices)
▶                    copy._currentFlow.currentChoices.Add(choice.Clone());
             } else {
                 copy._currentFlow.currentChoices.AddRange(_currentFlow.currentChoices);
             }

SS058 String concatenated in a loop 2 hits

📄 tests\Tests.cs (line 850)

                 string result = "";
                 for (int i = 0; i < numberOfTimes; i++)
                 {
▶                    result += str;
                 }
                 return result;
             });

📄 tests\Tests.cs (line 850)

                 string result = "";
                 for (int i = 0; i < numberOfTimes; i++)
                 {
▶                    result += str;
                 }
                 return result;
             });

AutoMapper

90 total diagnostics across 4 rules

SS004 Elementary methods of type in collection not overridden 30 hits

No source samples extracted

SS015 String placeholders in wrong order 10 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 40 hits

No source samples extracted

SS058 String concatenated in a loop 10 hits

No source samples extracted

hashids.net

90 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 24 hits

📄 src\Hashids.net\Hashids.cs (line 343)

                 }
             }
 
▶            var halfLength = _alphabet.Length / 2;
 
             var stringBuilder = StringBuilderPool.Get();
 #if NETSTANDARD2_0

💬 The operands in the divisive expression _alphabet.Length / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Hashids.net\Hashids.cs (line 368)

                 var excess = stringBuilder.Length - _minHashLength;
                 if (excess > 0)
                 {
▶                    stringBuilder.Remove(0, excess / 2);
                     stringBuilder.Remove(_minHashLength, stringBuilder.Length - _minHashLength);
                 }
             }

💬 The operands in the divisive expression excess / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS020 Test method without public modifier 48 hits

📄 test\Hashids.net.test\IssueSpecificTests.cs (line 11)

     public class IssueSpecificTests
     {
         [Fact]
▶        void Issue_8_should_not_throw_out_of_range_exception()
         {
             var hashids = new Hashids("janottaa", 6);
             var numbers = hashids.Decode("NgAzADEANAA=");

💬 Test method "Issue_8_should_not_throw_out_of_range_exception" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

📄 test\Hashids.net.test\IssueSpecificTests.cs (line 21)

         // seems to happen when you are encoding A LOT of longs at the same time.
         // see if it is possible to make this a faster test (or remove it since it is unlikely that it will reapper).
         [Fact]
▶        void Issue_12_should_not_throw_out_of_range_exception()
         {
             var hash = new Hashids("zXZVFf2N38uV");
             var longs = new List<long>();

💬 Test method "Issue_12_should_not_throw_out_of_range_exception" is not public. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS020-TestMethodWithoutPublicModifier.md)

SS046 Unbounded stackalloc 18 hits

📄 src\Hashids.net\Hashids.cs (line 310)

             var startIndex = 1 + _salt.Length;
             var length = _alphabet.Length - startIndex;
 
▶            Span<char> hashBuffer = stackalloc char[_minBufferSize];
 
             if (length > 0)
                 alphabet.Slice(0, length).CopyTo(shuffleBuffer.Slice(startIndex));

📄 src\Hashids.net\Hashids.cs (line 415)

             var startIndex = 1 + _salt.Length;
             var length = _alphabet.Length - startIndex;
 
▶            Span<char> hashBuffer = stackalloc char[_minBufferSize];
 
             for (var i = 0; i < numbers.Length; i++)
             {

Hearthstone-Deck-Tracker

88 total diagnostics across 6 rules

SS001 Async method with void return type 42 hits

📄 HearthWatcher\BattlegroundsLeaderboardWatcher.cs (line 37)

 
 		public void Stop() => _watch = false;
 
▶		private async void Update()
 		{
 			_running = true;
 			while(_watch)

💬 Method Update is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 HearthWatcher\BaconWatcher.cs (line 36)

 
 		public void Stop() => _watch = false;
 
▶		private async void Update()
 		{
 			_running = true;
 			while(_watch)

💬 Method Update is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 HearthWatcher\LogReader\LogLine.cs (line 38)

 	}
 
 	public string Namespace { get; }
▶	public DateTime Time { get; } = DateTime.Now;
 	public string Line { get; }
 	public string LineContent { get; }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 HearthWatcher\LogReader\LogLine.cs (line 30)

 			if(DateTime.TryParse(ts, out time))
 			{
 				Time = DateTime.Today.Add(time.TimeOfDay);
▶				if(Time > DateTime.Now)
 					Time = Time.AddDays(-1);
 			}
 			LineContent = match.Groups["line"].Value;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 HDTUpdate\Program.cs (line 116)

 						{
 							Console.CursorLeft = 0;
 							Console.CursorTop = 1;
▶							Console.WriteLine("Downloading latest version... {0}/{1}KB ({2}%)", e.BytesReceived / (1024), e.TotalBytesToReceive / (1024), e.ProgressPercentage);
 						}
 					};
 					await wc.DownloadFileTaskAsync(url, filePath);

💬 The operands in the divisive expression e.BytesReceived / (1024) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 HDTUpdate\Program.cs (line 116)

 						{
 							Console.CursorLeft = 0;
 							Console.CursorTop = 1;
▶							Console.WriteLine("Downloading latest version... {0}/{1}KB ({2}%)", e.BytesReceived / (1024), e.TotalBytesToReceive / (1024), e.ProgressPercentage);
 						}
 					};
 					await wc.DownloadFileTaskAsync(url, filePath);

💬 The operands in the divisive expression e.TotalBytesToReceive / (1024) are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS005 Equals() and GetHashCode() not implemented together 4 hits

📄 HearthWatcher\EventArgs\BattlegroundsLeaderboardArgs.cs (line 3)

 namespace HearthWatcher.EventArgs
 {
▶	public class BattlegroundsLeaderboardArgs : System.EventArgs
 	{
 		public int? HoveredEntityId { get; }
 

💬 Equals() and GetHashcode() must be implemented together on BattlegroundsLeaderboardArgs (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

📄 HearthWatcher\EventArgs\BattlegroundsTeammateBoardStateArgs.cs (line 7)

 
 namespace HearthWatcher.EventArgs
 {
▶	public class BattlegroundsTeammateBoardStateArgs : System.EventArgs
 	{
 		public bool IsViewingTeammate { get; }
 

💬 Equals() and GetHashcode() must be implemented together on BattlegroundsTeammateBoardStateArgs (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS005-EqualsAndGetHashcodeNotImplementedTogether.md)

SS011 OnPropertyChanged without nameof operator 24 hits

📄 HDTUninstaller\MainWindow.xaml.cs (line 95)

 				var regKey = Registry.CurrentUser.OpenSubKey("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run", true);
 				if(regKey != null)
 					regKey.DeleteValue("Hearthstone Deck Tracker", false);
▶				OnPropertyChanged("TextAutostart");
 				OnPropertyChanged("BackgroundAutostart");
 			}
 			catch(Exception ex)

💬 OnPropertyChanged(TextAutostart) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

📄 HDTUninstaller\MainWindow.xaml.cs (line 96)

 				if(regKey != null)
 					regKey.DeleteValue("Hearthstone Deck Tracker", false);
 				OnPropertyChanged("TextAutostart");
▶				OnPropertyChanged("BackgroundAutostart");
 			}
 			catch(Exception ex)
 			{

💬 OnPropertyChanged(BackgroundAutostart) can use the nameof() operator. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS011-OnPropertyChangedWithoutNameofOperator.md)

SS019 Switch is missing default label 2 hits

📄 HDTUpdate\Program.cs (line 50)

 			catch(Exception e)
 			{
 				Console.WriteLine(e);
▶				switch(_state)
 				{
 					case UpdatingState.Preparation:
 						Console.WriteLine("Please delete the 'temp' directory and try to update again. Press any key to exit.");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 HDTUpdate\Program.cs (line 50)

 			catch(Exception e)
 			{
 				Console.WriteLine(e);
▶				switch(_state)
 				{
 					case UpdatingState.Preparation:
 						Console.WriteLine("Please delete the 'temp' directory and try to update again. Press any key to exit.");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

XboxDownload

86 total diagnostics across 11 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 XboxDownload\Models\Services\ServiceModels.cs (line 34)

         RequestMethod = method;
         Content = content;
         ClientIp = ip;
▶        Timestamp = DateTime.Now;
     }
 
     [ObservableProperty]

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 XboxDownload\ViewModels\StoreViewModel.cs (line 811)

 
     private async Task GetGamePackageAsync(PlatformDownloadItem platformDownload, string contentId, CancellationToken token = default)
     {
▶        if (!_platformPackageFetchTimes.TryGetValue(platformDownload.Key, out var value) || DateTime.Compare(value, DateTime.Now) < 0)
         {
             _platformPackageFetchTimes[platformDownload.Key] = DateTime.Now.AddMinutes(3);
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 XboxDownload\Services\SpeedTestService.cs (line 94)

                 {
                     // Even if the request fails, record the amount of data that was downloaded.
                     response.Dispose();
▶                    ipResults[ipItem] = totalBytes;
                 }
             }
 

💬 Type IpItem is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 XboxDownload\Services\SpeedTestService.cs (line 94)

                 {
                     // Even if the request fails, record the amount of data that was downloaded.
                     response.Dispose();
▶                    ipResults[ipItem] = totalBytes;
                 }
             }
 

SS018 Switch does not handle all enum options 4 hits

📄 XboxDownload\Services\DnsConnectionListener.cs (line 654)

         // 2. Normalize IPv4-mapped IPv6 (e.g., ::ffff:192.168.1.1)
         var effectiveIp = ip.IsIPv4MappedToIPv6 ? ip.MapToIPv4() : ip;
 
▶        switch (effectiveIp.AddressFamily)
         {
             case AddressFamily.InterNetwork: // IPv4
                 Span<byte> v4 = stackalloc byte[4];

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 XboxDownload\Services\DnsConnectionListener.cs (line 697)

                         var queryName = (dns.Queries[0].QueryName ?? string.Empty).ToLowerInvariant();
                         if (string.IsNullOrWhiteSpace(queryName)) return;
 
▶                        switch (dns.Queries[0].QueryType)
                         {
                             case QueryType.A:
                                 {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 38 hits

📄 XboxDownload\ViewModels\Dialog\DohServerDialogViewModel.cs (line 55)

     [RelayCommand]
     private void UpdateSelection(string? parameter)
     {
▶        switch (parameter)
         {
             case "SelectAll":
                 foreach (var option in SpeedTestMappings)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 XboxDownload\Services\DnsConnectionListener.cs (line 654)

         // 2. Normalize IPv4-mapped IPv6 (e.g., ::ffff:192.168.1.1)
         var effectiveIp = ip.IsIPv4MappedToIPv6 ? ip.MapToIPv4() : ip;
 
▶        switch (effectiveIp.AddressFamily)
         {
             case AddressFamily.InterNetwork: // IPv4
                 Span<byte> v4 = stackalloc byte[4];

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 2 hits

📄 XboxDownload\Services\XboxGameManager.cs (line 49)

         try
         {
             // ReSharper disable once MethodHasAsyncOverload
▶            _saveCancellationTokenSource?.Cancel();
 
             _saveCancellationTokenSource = new CancellationTokenSource();
             var token = _saveCancellationTokenSource.Token;

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 XboxDownload\Services\XboxGameManager.cs (line 49)

         try
         {
             // ReSharper disable once MethodHasAsyncOverload
▶            _saveCancellationTokenSource?.Cancel();
 
             _saveCancellationTokenSource = new CancellationTokenSource();
             var token = _saveCancellationTokenSource.Token;

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 2 hits

📄 XboxDownload\Services\SpeedTestService.cs (line 111)

 
         if (result.Task.IsCompletedSuccessfully)
         {
▶            return result.Task.Result;
         }
 
         var best = ipResults

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 XboxDownload\Services\SpeedTestService.cs (line 111)

 
         if (result.Task.IsCompletedSuccessfully)
         {
▶            return result.Task.Result;
         }
 
         var best = ipResults

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 2 hits

📄 XboxDownload\Helpers\Network\HttpClientHelper.cs (line 225)

 
         try
         {
▶            using var client = new HttpClient(handler, disposeHandler: true);
 
             using var request = new HttpRequestMessage(HttpMethod.Get, uri);
             request.Headers.Range = new RangeHeaderValue(rangeFrom, rangeTo);

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 XboxDownload\Helpers\Network\HttpClientHelper.cs (line 225)

 
         try
         {
▶            using var client = new HttpClient(handler, disposeHandler: true);
 
             using var request = new HttpRequestMessage(HttpMethod.Get, uri);
             request.Headers.Range = new RangeHeaderValue(rangeFrom, rangeTo);

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

SS041 Unnecessary enumerable materialization 4 hits

📄 XboxDownload\ViewModels\Dialog\ResolveDomainDialogViewModel.cs (line 81)

             return;
         }
 
▶        foreach (var entry in _hostViewModel.HostMappings.ToList().Where(entry => entry.HostName.Equals(HostnameToResolve)))
         {
             _hostViewModel.HostMappings.Remove(entry);
         }

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 XboxDownload\ViewModels\Dialog\LocalProxyDialogViewModel.cs (line 401)

         const string url = "https://github.com/SpaceTimee/Cealing-Host/raw/main/Cealing-Host.json";
         using var cts = new CancellationTokenSource();
 
▶        var tasks = UpdateService.Proxies1.Concat([""]).ToArray().Select(async proxy => await HttpClientHelper.GetStringContentAsync(proxy + url, token: cts.Token, timeout: 6000)).ToList();
         while (tasks.Count > 0)
         {
             var completedTask = await Task.WhenAny(tasks);

💬 ToArray is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS058 String concatenated in a loop 8 hits

📄 XboxDownload\ViewModels\StoreViewModel.cs (line 491)

                                                     {
                                                         platformDownload.Outdated = true;
                                                         platformDownload.FileSize = xboxGame.FileSize;
▶                                                        platformDownload.Display += $" ({ResourceHelper.GetString("Store.UpdateAvailable")})";
                                                         tasks.Add(Task.Run(async () =>
                                                         {
                                                             await GetGamePackageAsync(platformDownload, contentId, token);

📄 XboxDownload\ViewModels\StoreViewModel.cs (line 529)

                                                     {
                                                         platformDownload.Outdated = true;
                                                         platformDownload.FileSize = xboxGame.FileSize;
▶                                                        platformDownload.Display += $" ({ResourceHelper.GetString("Store.UpdateAvailable")})";
                                                         tasks.Add(Task.Run(async () =>
                                                         {
                                                             await GetGamePackageAsync(platformDownload, contentId, token);

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 XboxDownload\Models\Store\StoreSearchResult.cs (line 29)

         if (response is { IsSuccessStatusCode: true })
         {
             var buffer = await response.Content.ReadAsByteArrayAsync();
▶            using var stream = new MemoryStream(buffer);
             IconBitmap = new Bitmap(stream);
         }
     }

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 XboxDownload\Helpers\Network\HttpClientHelper.cs (line 89)

             var url = proxy + (string.IsNullOrEmpty(proxy) ? path : path.Replace("https://", ""));
             using var response = await SendRequestAsync(url, headers: headers, timeout: timeout, name: HttpClientNames.SpeedTest, token: cts.Token);
             if (response is not { IsSuccessStatusCode: true }) return null;
▶            using var ms = new MemoryStream();
             try
             {
                 await using var stream = await response.Content.ReadAsStreamAsync(cts.Token);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 4 hits

📄 XboxDownload\Helpers\Utilities\UsbWatcher.cs (line 12)

     public event Action<string>? UsbInserted;
     public event Action<string>? UsbRemoved;
 
▶    private ManagementEventWatcher? _insertWatcher;
     private ManagementEventWatcher? _removeWatcher;
 
     [SupportedOSPlatform("windows")]

💬 Disposable field _insertWatcher in type UsbWatcher is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 XboxDownload\Helpers\Utilities\UsbWatcher.cs (line 13)

     public event Action<string>? UsbRemoved;
 
     private ManagementEventWatcher? _insertWatcher;
▶    private ManagementEventWatcher? _removeWatcher;
 
     [SupportedOSPlatform("windows")]
     public void Start()

💬 Disposable field _removeWatcher in type UsbWatcher is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

FluentAssertions

86 total diagnostics across 9 rules

SS003 Integer divided by integer causing implicit rounding 8 hits

No source samples extracted

SS004 Elementary methods of type in collection not overridden 18 hits

No source samples extracted

SS005 Equals() and GetHashCode() not implemented together 38 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 6 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

No source samples extracted

SS023 Exception thrown from property getter 4 hits

No source samples extracted

SS034 Accessing Task.Result without await 4 hits

No source samples extracted

SS058 String concatenated in a loop 2 hits

No source samples extracted

SS066 Disposable field is not disposed 4 hits

No source samples extracted

BepInEx

84 total diagnostics across 9 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 18 hits

📄 Runtimes\Unity\BepInEx.Unity.Mono.Preloader\DoorstopEntrypoint.cs (line 17)

     public static void Start()
     {
         // We set it to the current directory first as a fallback, but try to use the same location as the .exe file.
▶        var silentExceptionLog = $"preloader_{DateTime.Now:yyyyMMdd_HHmmss_fff}.log";
 
         try
         {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Runtimes\Unity\BepInEx.Unity.Mono.Preloader\UnityPreloader.cs (line 128)

             catch { }
 
             File.WriteAllText(
▶                              Path.Combine(Paths.GameRootPath, $"preloader_{DateTime.Now:yyyyMMdd_HHmmss_fff}.log"),
                               log + ex);
         }
     }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 4 hits

📄 Runtimes\Unity\BepInEx.Unity.IL2CPP\Il2CppInteropManager.AsmToCecilConverter.cs (line 50)

 
         private AssemblyDefinition Convert(AsmResolver.DotNet.AssemblyDefinition asmResolverAssembly, ReaderParameters readerParameters)
         {
▶            if (asmToCecil.TryGetValue(asmResolverAssembly, out var cecilAssembly))
             {
                 return cecilAssembly;
             }

💬 Type AssemblyDefinition is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Runtimes\Unity\BepInEx.Unity.IL2CPP\Il2CppInteropManager.AsmToCecilConverter.cs (line 59)

             stream.Position = 0;
             cecilAssembly = AssemblyDefinition.ReadAssembly(stream, readerParameters);
             cecilDictionary.Add(cecilAssembly.Name.Name, cecilAssembly);
▶            asmToCecil.Add(asmResolverAssembly, cecilAssembly);
             return cecilAssembly;
         }
     }

SS008 GetHashCode() refers to mutable or static member 8 hits

📄 Runtimes\Unity\BepInEx.Unity.Mono\Configuration\KeyboardShortcut.cs (line 176)

     {
         if (MainKey == KeyCode.None) return 0;
 
▶        return _allKeys.Aggregate(_allKeys.Length, (current, item) => unchecked(current * 31 + (int) item));
     }
 }

💬 GetHashCode() refers to mutable field _allKeys (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 Runtimes\Unity\BepInEx.Unity.Mono\Configuration\KeyboardShortcut.cs (line 176)

     {
         if (MainKey == KeyCode.None) return 0;
 
▶        return _allKeys.Aggregate(_allKeys.Length, (current, item) => unchecked(current * 31 + (int) item));
     }
 }

💬 GetHashCode() refers to mutable field _allKeys (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

📄 BepInEx.Core\Console\Windows\Kon.cs (line 28)

 
         #region Types
 
▶        private struct CONSOLE_SCREEN_BUFFER_INFO
         {
             internal COORD dwSize;
             internal COORD dwCursorPosition;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CONSOLE_SCREEN_BUFFER_INFO. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 BepInEx.Core\Console\Windows\Kon.cs (line 37)

             internal COORD dwMaximumWindowSize;
         }
 
▶        private struct COORD
         {
             internal short X;
             internal short Y;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct COORD. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 4 hits

📄 Runtimes\Unity\BepInEx.Unity.Mono\UnityInput.cs (line 173)

 
         private static ButtonControl GetControl(KeyCode key, bool silent = false)
         {
▶            switch (key)
             {
                 case KeyCode.None:
                     break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Runtimes\Unity\BepInEx.Unity.Mono\UnityInput.cs (line 173)

 
         private static ButtonControl GetControl(KeyCode key, bool silent = false)
         {
▶            switch (key)
             {
                 case KeyCode.None:
                     break;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 6 hits

📄 Runtimes\Unity\BepInEx.Unity.Mono\UnityInput.cs (line 173)

 
         private static ButtonControl GetControl(KeyCode key, bool silent = false)
         {
▶            switch (key)
             {
                 case KeyCode.None:
                     break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Runtimes\Unity\BepInEx.Unity.IL2CPP\Utils\Collections\Il2CppManagedEnumerator.cs (line 39)

         ClassInjector.DerivedConstructorBody(this);
     }
 
▶    public Object Current => enumerator.Current switch
     {
         Il2CppIEnumerator i => i.Cast<Object>(),
         IEnumerator e       => new Il2CppManagedEnumerator(e),

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS023 Exception thrown from property getter 4 hits

📄 BepInEx.Core\Console\Unix\ConsoleWriter.cs (line 44)

 
             cStreamWriterConstructor = ctorParams.Select(GetCtor).FirstOrDefault(f => f != null);
             if (cStreamWriterConstructor == null)
▶                throw new AmbiguousMatchException("Failed to find suitable constructor for CStreamWriter");
             return cStreamWriterConstructor;
         }
     }

💬 An exception is thrown from the getter of property CStreamWriterConstructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 BepInEx.Core\Console\Unix\ConsoleWriter.cs (line 44)

 
             cStreamWriterConstructor = ctorParams.Select(GetCtor).FirstOrDefault(f => f != null);
             if (cStreamWriterConstructor == null)
▶                throw new AmbiguousMatchException("Failed to find suitable constructor for CStreamWriter");
             return cStreamWriterConstructor;
         }
     }

💬 An exception is thrown from the getter of property CStreamWriterConstructor (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS051 Locking on mutable reference 4 hits

📄 Runtimes\Unity\BepInEx.Unity.Mono.Preloader\RuntimeFixes\TraceFix.cs (line 60)

 
         var type = (TraceEventType) Enum.Parse(typeof(TraceEventType), kind);
 
▶        lock (ListenersSyncRoot)
         {
             foreach (var obj in Listeners)
             {

💬 A lock was obtained on ListenersSyncRoot but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Runtimes\Unity\BepInEx.Unity.Mono.Preloader\RuntimeFixes\TraceFix.cs (line 60)

 
         var type = (TraceEventType) Enum.Parse(typeof(TraceEventType), kind);
 
▶        lock (ListenersSyncRoot)
         {
             foreach (var obj in Listeners)
             {

SS066 Disposable field is not disposed 12 hits

📄 BepInEx.Core\Logging\TraceLogSource.cs (line 29)

     /// <summary>
     ///     Internal log source.
     /// </summary>
▶    protected ManualLogSource LogSource { get; }
 
     /// <summary>
     ///     Creates a new trace log source.

💬 Disposable field LogSource in type TraceLogSource is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 BepInEx.Core\Logging\TraceLogSource.cs (line 29)

     /// <summary>
     ///     Internal log source.
     /// </summary>
▶    protected ManualLogSource LogSource { get; }
 
     /// <summary>
     ///     Creates a new trace log source.

💬 Disposable field LogSource in type TraceLogSource is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

optick

84 total diagnostics across 7 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 16 hits

📄 gui\InteractiveDataDisplay.WPF\Navigation\MouseNavigation.cs (line 414)

                                 selectStart = cursorPosition;
                                 this.CaptureMouse();
                             }
▶                            lastClick = DateTime.Now;
                         }
                         else
                         {

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 gui\InteractiveDataDisplay.WPF\Navigation\MouseNavigation.cs (line 418)

                         }
                         else
                         {
▶                            DateTime d = DateTime.Now;
                             if ((d - lastClick).TotalMilliseconds < 200)
                             {
                                 masterPlot.IsAutoFitEnabled = true;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 gui\InteractiveDataDisplay.WPF\Plots\Base\BackgroundBitmapRenderer.cs (line 162)

 
                 WriteableBitmap wr = new WriteableBitmap((int)r.Output.Width, (int)r.Output.Height, 96, 96, PixelFormats.Bgra32, null);
                 // Calculate the number of bytes per pixel. 
▶                int bytesPerPixel = (wr.Format.BitsPerPixel + 7) / 8;
                 // Stride is bytes per pixel times the number of pixels.
                 // Stride is the byte width of a single rectangle row.
                 int stride = wr.PixelWidth * bytesPerPixel;

💬 The operands in the divisive expression (wr.Format.BitsPerPixel + 7) / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 gui\InteractiveDataDisplay.WPF\Plots\Base\BackgroundBitmapRenderer.cs (line 162)

 
                 WriteableBitmap wr = new WriteableBitmap((int)r.Output.Width, (int)r.Output.Height, 96, 96, PixelFormats.Bgra32, null);
                 // Calculate the number of bytes per pixel. 
▶                int bytesPerPixel = (wr.Format.BitsPerPixel + 7) / 8;
                 // Stride is bytes per pixel times the number of pixels.
                 // Stride is the byte width of a single rectangle row.
                 int stride = wr.PixelWidth * bytesPerPixel;

SS008 GetHashCode() refers to mutable or static member 24 hits

📄 gui\InteractiveDataDisplay.WPF\Common\Range.cs (line 147)

         /// <returns>The hash code for current instance</returns>
         public override int GetHashCode()
         {
▶            return minimum.GetHashCode() ^ maximum.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field minimum (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 gui\InteractiveDataDisplay.WPF\Common\Range.cs (line 147)

         /// <returns>The hash code for current instance</returns>
         public override int GetHashCode()
         {
▶            return minimum.GetHashCode() ^ maximum.GetHashCode();
         }
 
         /// <summary>

💬 GetHashCode() refers to mutable field maximum (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 gui\InteractiveDataDisplay.WPF\Common\DataRect.cs (line 15)

     /// points to bottom (that's why <see cref="System.Windows.Rect"/>'s Bottom property is greater than Top).
     /// This type describes rectange in usual coordinates, and y axis point to top.
     /// </summary>
▶    public struct DataRect
     {
         private Range x;
         private Range y;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DataRect. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 gui\InteractiveDataDisplay.WPF\PlotCompositionChange.cs (line 7)

 namespace InteractiveDataDisplay.WPF
 {
     /// <summary>Identifies event when collection of related plots in composition change</summary>
▶    public struct PlotCompositionChange
     {
         private PlotBase master;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct PlotCompositionChange. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 8 hits

📄 gui\InteractiveDataDisplay.WPF\Axes\Axis.cs (line 442)

             double labelArrangeOriginY = 0;
 
 
▶            switch (AxisOrientation)
             {
                 case AxisOrientation.Top:
                     majorTicksPath.Arrange(new Rect(0, finalSize.Height - tickLength, finalSize.Width, tickLength));

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 gui\InteractiveDataDisplay.WPF\Axes\Axis.cs (line 501)

             double maxLabelWidth = CalculateMaxLabelWidth();
             double maxLabelHeight = CalculateMaxLabelHeight();
 
▶            switch (AxisOrientation)
             {
                 case AxisOrientation.Top:
 

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS048 Locking on discouraged object (string, Type, this) 4 hits

📄 gui\InteractiveDataDisplay.WPF\Plots\Markers\MarkerGraph.cs (line 806)

         {
             get
             {
▶                lock (this)
                 {
                     return isDrawing;
                 }

📄 gui\InteractiveDataDisplay.WPF\Plots\Markers\MarkerGraph.cs (line 806)

         {
             get
             {
▶                lock (this)
                 {
                     return isDrawing;
                 }

SS051 Locking on mutable reference 20 hits

📄 gui\InteractiveDataDisplay.WPF\Plots\Heatmap\HeatmapGraph.cs (line 75)

         public long Plot(double[,] data, double[] x, double[] y, double missingValue)
         {
             VerifyDimensions(data, x, y);
▶            lock (locker)
             {
                 this.xArr = x;
                 this.yArr = y;

📄 gui\InteractiveDataDisplay.WPF\Plots\Heatmap\HeatmapGraph.cs (line 166)

         private static void OnPalettePropertyChanged(object sender, DependencyPropertyChangedEventArgs e)
         {
             HeatmapGraph heatmap = (HeatmapGraph)sender;
▶            lock (heatmap.locker)
             {
                 heatmap.paletteRangeUpdateRequired = true;
                 heatmap.palette = (Palette)e.NewValue;

fluentmigrator

78 total diagnostics across 9 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\FluentMigrator.Runner.Core\StopWatch.cs (line 39)

         /// This field allows overriding the default behavior of retrieving the current date and time
         /// (using <see cref="DateTime.Now"/>) for testing or customization purposes.
         /// </remarks>
▶        public static Func<DateTime> TimeNow = () => DateTime.Now;
 
         private DateTime _startTime;
         private DateTime _endTime;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\FluentMigrator.Runner.Core\StopWatch.cs (line 39)

         /// This field allows overriding the default behavior of retrieving the current date and time
         /// (using <see cref="DateTime.Now"/>) for testing or customization purposes.
         /// </remarks>
▶        public static Func<DateTime> TimeNow = () => DateTime.Now;
 
         private DateTime _startTime;
         private DateTime _endTime;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 src\FluentMigrator.Runner.Core\MigrationRunner.cs (line 822)

 
             if (insertCount > 0)
             {
▶                var avg = new TimeSpan(insertTicks / insertCount);
                 var msg = string.Format("-> {0} Insert operations completed in {1} taking an average of {2}", insertCount, new TimeSpan(insertTicks), avg);
                 _logger.LogSay(msg);
             }

💬 The operands in the divisive expression insertTicks / insertCount are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\FluentMigrator.Runner.Core\MigrationRunner.cs (line 822)

 
             if (insertCount > 0)
             {
▶                var avg = new TimeSpan(insertTicks / insertCount);
                 var msg = string.Format("-> {0} Insert operations completed in {1} taking an average of {2}", insertCount, new TimeSpan(insertTicks), avg);
                 _logger.LogSay(msg);
             }

SS004 Elementary methods of type in collection not overridden 12 hits

📄 src\FluentMigrator\Builders\ColumnExpressionBuilderHelper.cs (line 68)

         {
             var column = _builder.Column;
             ExistingRowsData exRowExpr;
▶            if (_existingRowsDataByColumn.TryGetValue(column, out exRowExpr))
             {
                 if (exRowExpr.SetExistingRowsExpression != null)
                 {

💬 Type ColumnDefinition is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\FluentMigrator\Builders\ColumnExpressionBuilderHelper.cs (line 130)

                 //ensure an UpdateDataExpression is created and cached for this column
 
                 ExistingRowsData exRowExpr;
▶                if (!_existingRowsDataByColumn.TryGetValue(column, out exRowExpr))
                 {
                     exRowExpr = new ExistingRowsData();
                     _existingRowsDataByColumn.Add(column, exRowExpr);

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\FluentMigrator.Analyzers\MigrationClassDeclaration.cs (line 24)

     /// <summary>
     /// Represents a migration class declaration with its associated metadata.
     /// </summary>
▶    public struct MigrationClassDeclaration
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="MigrationClassDeclaration"/> struct.

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MigrationClassDeclaration. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\FluentMigrator.Analyzers\MigrationClassDeclaration.cs (line 24)

     /// <summary>
     /// Represents a migration class declaration with its associated metadata.
     /// </summary>
▶    public struct MigrationClassDeclaration
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="MigrationClassDeclaration"/> struct.

SS018 Switch does not handle all enum options 4 hits

📄 src\FluentMigrator.Runner.Core\Logging\FluentMigratorLogger.cs (line 42)

         /// <inheritdoc />
         public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)
         {
▶            switch (logLevel)
             {
                 case LogLevel.Error:
                 case LogLevel.Critical:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\FluentMigrator.Runner.Core\Logging\FluentMigratorLogger.cs (line 42)

         /// <inheritdoc />
         public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)
         {
▶            switch (logLevel)
             {
                 case LogLevel.Error:
                 case LogLevel.Critical:

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 20 hits

📄 src\FluentMigrator.Abstractions\ValidationUtilities.cs (line 82)

                         continue;
                     }
 
▶                    switch (additionalFeaturesValue)
                     {
                         case string _:
                         case decimal _:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\FluentMigrator.Abstractions\ValidationUtilities.cs (line 82)

                         continue;
                     }
 
▶                    switch (additionalFeaturesValue)
                     {
                         case string _:
                         case decimal _:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS044 Attribute must specify [AttributeUsage] 8 hits

📄 src\FluentMigrator.Runner.Core\Constraints\CurrentVersionMigrationConstraintAttribute.cs (line 23)

     /// <summary>
     /// Specifies minimum schema version against which this migration will be run.
     /// </summary>
▶    public class CurrentVersionMigrationConstraintAttribute : MigrationConstraintAttribute
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="CurrentVersionMigrationConstraintAttribute"/> class.

💬 CurrentVersionMigrationConstraintAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 src\FluentMigrator.Runner.Core\Constraints\MigrationConstraintAttribute.cs (line 25)

     /// <summary>
     /// Can be used to apply conditions when migrations will be run.
     /// </summary>
▶    public class MigrationConstraintAttribute : Attribute
     {
         private readonly Func<MigrationConstraintContext, bool> _predicate;
 

💬 MigrationConstraintAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS058 String concatenated in a loop 4 hits

📄 src\FluentMigrator.Runner.Core\Exceptions\VersionOrderInvalidException.cs (line 95)

 
                 foreach (var pair in InvalidMigrations)
                 {
▶                    result += $"{Environment.NewLine}{pair.Key} - {pair.Value.Migration.GetType().Name}";
                 }
 
                 return result;

📄 src\FluentMigrator.Runner.Core\Exceptions\VersionOrderInvalidException.cs (line 95)

 
                 foreach (var pair in InvalidMigrations)
                 {
▶                    result += $"{Environment.NewLine}{pair.Key} - {pair.Value.Migration.GetType().Name}";
                 }
 
                 return result;

SS066 Disposable field is not disposed 20 hits

📄 src\FluentMigrator.Runner.Core\Initialization\TaskExecutor.cs (line 221)

             private readonly TaskExecutor _executor;
 
             [CanBeNull]
▶            private readonly IServiceScope _serviceScope;
 
             private readonly bool _hasCustomRunner;

💬 Disposable field _serviceScope in type RunnerScope is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\FluentMigrator.Runner.Core\TransactionalMigrationScope.cs (line 26)

     /// </summary>
     public class TransactionalMigrationScope : TrackingMigrationScope
     {
▶        private readonly IMigrationProcessor _migrationProcessor;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="TransactionalMigrationScope"/> class.

💬 Disposable field _migrationProcessor in type TransactionalMigrationScope is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

BBDown

76 total diagnostics across 4 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 BBDown.Core\Logger.cs (line 13)

 
     public static void LogError(object text)
     {
▶        Console.Write(DateTime.Now.ToString("[yyyy-MM-dd HH:mm:ss.fff]") + " - ");
         Console.ForegroundColor = ConsoleColor.Red;
         Console.Write(text);
         Console.ResetColor();

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 BBDown.Core\Logger.cs (line 7)

 {
     public static void Log(object text, bool enter = true)
     {
▶        Console.Write(DateTime.Now.ToString("[yyyy-MM-dd HH:mm:ss.fff]") + " - " + text);
         if (enter) Console.WriteLine();
     }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 34 hits

📄 BBDown.Core\DanmakuUtil.cs (line 122)

 
     protected class PositionController
     {
▶        readonly int maxLine = MONITOR_HEIGHT * PROTECT_LENGTH / FONT_SIZE / 100;    //总行数
         // 三个位置的弹幕队列，记录弹幕结束时间
 
         readonly List<double> moveQueue = new();

💬 The operands in the divisive expression MONITOR_HEIGHT * PROTECT_LENGTH / FONT_SIZE / 100 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 BBDown.Core\DanmakuUtil.cs (line 122)

 
     protected class PositionController
     {
▶        readonly int maxLine = MONITOR_HEIGHT * PROTECT_LENGTH / FONT_SIZE / 100;    //总行数
         // 三个位置的弹幕队列，记录弹幕结束时间
 
         readonly List<double> moveQueue = new();

💬 The operands in the divisive expression MONITOR_HEIGHT * PROTECT_LENGTH / FONT_SIZE are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 30 hits

📄 BBDown.Core\Entity\Entity.cs (line 178)

 
         public override int GetHashCode()
         {
▶            return HashCode.Combine(id, dfn, codecs, bandwith, dur);
         }
     }
 

💬 GetHashCode() refers to mutable field id (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 BBDown.Core\Entity\Entity.cs (line 178)

 
         public override int GetHashCode()
         {
▶            return HashCode.Combine(id, dfn, codecs, bandwith, dur);
         }
     }
 

💬 GetHashCode() refers to mutable field dfn (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS058 String concatenated in a loop 2 hits

📄 BBDown.Core\Fetcher\BangumiInfoFetcher.cs (line 36)

                 {
                     if (section.ToString().Contains($"/ep{id}"))
                     {
▶                        title += "[" + section.GetProperty("title").ToString() + "]";
                         pages = section.GetProperty("episodes").EnumerateArray();
                         break;
                     }

📄 BBDown.Core\Fetcher\BangumiInfoFetcher.cs (line 36)

                 {
                     if (section.ToString().Contains($"/ep{id}"))
                     {
▶                        title += "[" + section.GetProperty("title").ToString() + "]";
                         pages = section.GetProperty("episodes").EnumerateArray();
                         break;
                     }

RyTuneX

76 total diagnostics across 10 rules

SS001 Async method with void return type 10 hits

📄 MainWindow.xaml.cs (line 35)

         this.AppWindow.Closing += MainWindow_Closing;
     }
 
▶    private async void MainWindow_Closing(Microsoft.UI.Windowing.AppWindow sender, Microsoft.UI.Windowing.AppWindowClosingEventArgs e)
     {
         try
         {

💬 Method MainWindow_Closing is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Views\DebloatSystemPage.xaml.cs (line 91)

         }
     }
 
▶    private async void LoadInstalledApps(bool uninstallableOnly = true, bool win32Only = false, CancellationToken cancellationToken = default)
     {
         try
         {

💬 Method LoadInstalledApps is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 Helpers\LogHelper.cs (line 15)

         try
         {
             var tempFolder = ApplicationData.Current.TemporaryFolder;
▶            var logFile = await tempFolder.CreateFileAsync($"{fileName}_{DateTime.Now:yyyy-MM-dd}.txt", CreationCollisionOption.OpenIfExists);
 
             // Ensure UTF-8 encoding when appending to the log file
             using (var stream = await logFile.OpenStreamForWriteAsync())

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Helpers\LogHelper.cs (line 23)

                 stream.Seek(0, SeekOrigin.End); // Append to the file
                 using (var writer = new StreamWriter(stream, new UTF8Encoding(false))) // Disable BOM
                 {
▶                    await writer.WriteLineAsync($"{DateTime.Now:T}: {message}");
                 }
             }
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 Views\HomePage.xaml.cs (line 204)

             var total = _systemDriveInfo.TotalSize;
             var free = _systemDriveInfo.TotalFreeSpace;
             var used = total - free;
▶            var percent = total == 0 ? 0 : (int)((used * 100L) / total);
             return Math.Clamp(percent, 0, 100);
         }
         catch

💬 The operands in the divisive expression (used * 100L) / total are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Views\HomePage.xaml.cs (line 204)

             var total = _systemDriveInfo.TotalSize;
             var free = _systemDriveInfo.TotalFreeSpace;
             var used = total - free;
▶            var percent = total == 0 ? 0 : (int)((used * 100L) / total);
             return Math.Clamp(percent, 0, 100);
         }
         catch

SS017 Struct without Equals/GetHashCode/ToString overridden 14 hits

📄 App.xaml.cs (line 44)

 {
     // P/Invoke for Taskbar Flashing
     [StructLayout(LayoutKind.Sequential)]
▶    private struct FLASHWINFO
     {
         public uint cbSize;
         public IntPtr hwnd;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct FLASHWINFO. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Helpers\PseudoConsoleHelper.cs (line 43)

     private static extern bool GetExitCodeProcess(IntPtr hProcess, out uint lpExitCode);
 
     [StructLayout(LayoutKind.Sequential)]
▶    private struct COORD
     {
         public short X, Y;
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct COORD. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 8 hits

📄 Views\DebloatSystemPage.xaml.cs (line 439)

 
     private void appsFilter_SelectionChanged(object sender, RoutedEventArgs e)
     {
▶        switch (appsFilter.SelectedIndex)
         {
             case 0:
                 LoadInstalledApps(true, false, cancellationTokenSource.Token);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Views\OptimizeSystemPage.xaml.cs (line 240)

                 key?.SetValue("WindowsUpdatesMode", mode, RegistryValueKind.String);
 
                 // Apply the selected mode
▶                switch (mode)
                 {
                     case "Default":
                         await OptimizeSystemHelper.SetWindowsUpdatesDefault();

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 12 hits

📄 Views\GroupPolicyPage.xaml.cs (line 55)

 
     private async Task ScanPoliciesAsync()
     {
▶        _cancellationTokenSource?.Cancel();
         if (_cancellationRegistrationId.HasValue)
         {
             OperationCancellationManager.Unregister(_cancellationRegistrationId.Value);

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Helpers\OptimizeSystemHelper.cs (line 541)

         };
 
         var lines = new List<string>();
▶        lines.AddRange(File.ReadAllLines(hostsPath));
 
         foreach (var host in safeTelemetryHosts)
         {

💬 Async overload available for File.ReadAllLines (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 4 hits

📄 Helpers\OptimizationOptions.cs (line 57)

 
         await Task.WhenAll(uwpAppsTask, win32AppsTask);
 
▶        var installedApps = uwpAppsTask.Result.Concat(win32AppsTask.Result).ToList();
 
         installedApps = [.. installedApps
             .DistinctBy(app => app.Item1)  // Remove duplicates based on app name

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Helpers\OptimizationOptions.cs (line 57)

 
         await Task.WhenAll(uwpAppsTask, win32AppsTask);
 
▶        var installedApps = uwpAppsTask.Result.Concat(win32AppsTask.Result).ToList();
 
         installedApps = [.. installedApps
             .DistinctBy(app => app.Item1)  // Remove duplicates based on app name

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS058 String concatenated in a loop 2 hits

📄 Helpers\OptimizationOptions.cs (line 123)

                 }
                 else if (!string.IsNullOrWhiteSpace(currentLocation) && line.StartsWith(" ", StringComparison.Ordinal))
                 {
▶                    currentLocation += " " + line.Trim();
                 }
             }
 

📄 Helpers\OptimizationOptions.cs (line 123)

                 }
                 else if (!string.IsNullOrWhiteSpace(currentLocation) && line.StartsWith(" ", StringComparison.Ordinal))
                 {
▶                    currentLocation += " " + line.Trim();
                 }
             }
 

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 Helpers\LogHelper.cs (line 18)

             var logFile = await tempFolder.CreateFileAsync($"{fileName}_{DateTime.Now:yyyy-MM-dd}.txt", CreationCollisionOption.OpenIfExists);
 
             // Ensure UTF-8 encoding when appending to the log file
▶            using (var stream = await logFile.OpenStreamForWriteAsync())
             {
                 stream.Seek(0, SeekOrigin.End); // Append to the file
                 using (var writer = new StreamWriter(stream, new UTF8Encoding(false))) // Disable BOM

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Helpers\LogHelper.cs (line 21)

             using (var stream = await logFile.OpenStreamForWriteAsync())
             {
                 stream.Seek(0, SeekOrigin.End); // Append to the file
▶                using (var writer = new StreamWriter(stream, new UTF8Encoding(false))) // Disable BOM
                 {
                     await writer.WriteLineAsync($"{DateTime.Now:T}: {message}");
                 }

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS060 ConcurrentDictionary emptiness check without IsEmpty 4 hits

📄 Helpers\OperationCancellationManager.cs (line 60)

         var hasTimeout = timeout.HasValue;
         var to = timeout ?? TimeSpan.Zero;
 
▶        while (_ctsMap.Count > 0 || OptimizationOptions.HasPendingToggleOperations)
         {
             if (hasTimeout && sw.Elapsed >= to)
                 break;

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

📄 Helpers\OperationCancellationManager.cs (line 68)

             await Task.Delay(250).ConfigureAwait(false);
         }
 
▶        return _ctsMap.Count == 0 && !OptimizationOptions.HasPendingToggleOperations;
     }
 }

💬 Use ConcurrentDictionary.IsEmpty to check for emptiness without locking the entire dictionary (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS060-ConcurrentDictionaryEmptyCheck.md)

OpenTabletDriver

74 total diagnostics across 6 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 OpenTabletDriver.Plugin\Logging\LogMessage.cs (line 23)

         /// <summary>
         /// The time in which a log message was created.
         /// </summary>
▶        public DateTime Time { set; get; } = DateTime.Now;
 
         /// <summary>
         /// The group in which the log message belongs to.

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 OpenTabletDriver.Plugin\Logging\LogMessage.cs (line 23)

         /// <summary>
         /// The time in which a log message was created.
         /// </summary>
▶        public DateTime Time { set; get; } = DateTime.Now;
 
         /// <summary>
         /// The group in which the log message belongs to.

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 OpenTabletDriver.Native\Windows\USB\StringDescriptor.cs (line 26)

             if (descriptor->bLength == 0)
                 return "";
 
▶            var unicodeLength = (descriptor->bLength - 1) / 2;
             var deviceString = new Span<char>(&descriptor->bString, unicodeLength).ToString();
             return deviceString;
         }

💬 The operands in the divisive expression (descriptor->bLength - 1) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 OpenTabletDriver.Native\Windows\USB\StringDescriptor.cs (line 26)

             if (descriptor->bLength == 0)
                 return "";
 
▶            var unicodeLength = (descriptor->bLength - 1) / 2;
             var deviceString = new Span<char>(&descriptor->bString, unicodeLength).ToString();
             return deviceString;
         }

SS017 Struct without Equals/GetHashCode/ToString overridden 58 hits

📄 OpenTabletDriver.Plugin\Tablet\DeviceReport.cs (line 3)

 namespace OpenTabletDriver.Plugin.Tablet
 {
▶    public struct DeviceReport : IDeviceReport
     {
         public DeviceReport(byte[] report)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DeviceReport. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 OpenTabletDriver.Plugin\Tablet\AuxReport.cs (line 3)

 namespace OpenTabletDriver.Plugin.Tablet
 {
▶    public struct AuxReport : IAuxReport
     {
         public AuxReport(byte[] report)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct AuxReport. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 4 hits

📄 OpenTabletDriver.Plugin\Output\PipelineManager.cs (line 13)

         {
             if (source != null && destination != null)
             {
▶                switch (destination)
                 {
                     case IPipelineElement<T> nextElement:
                         source.Emit += nextElement.Consume;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 OpenTabletDriver.Plugin\Output\PipelineManager.cs (line 32)

         {
             if (source != null && destination != null)
             {
▶                switch (destination)
                 {
                     case IPipelineElement<T> nextElement:
                         source.Emit -= nextElement.Consume;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS044 Attribute must specify [AttributeUsage] 6 hits

📄 OpenTabletDriver.Plugin\Attributes\ModifierAttribute.cs (line 8)

     /// <summary>
     /// Base attribute class for attributes which provide extra information to a property.
     /// </summary>
▶    public abstract class ModifierAttribute : Attribute
     {
     }
 }

💬 ModifierAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 OpenTabletDriver.Plugin\Attributes\ToolTipAttribute.cs (line 8)

     /// <summary>
     /// Applies a tooltip to a property on the client.
     /// </summary>
▶    public class ToolTipAttribute : ModifierAttribute
     {
         public ToolTipAttribute(string tooltip)
         {

💬 ToolTipAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS051 Locking on mutable reference 2 hits

📄 OpenTabletDriver.Native\Linux\Xorg\XLib.cs (line 20)

         private extern unsafe static IntPtr sys_XOpenDisplay(char* display);
         public static unsafe IntPtr XOpenDisplay(char* display)
         {
▶            lock (Lock)
                 return sys_XOpenDisplay(display);
         }
 

💬 A lock was obtained on Lock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 OpenTabletDriver.Native\Linux\Xorg\XLib.cs (line 20)

         private extern unsafe static IntPtr sys_XOpenDisplay(char* display);
         public static unsafe IntPtr XOpenDisplay(char* display)
         {
▶            lock (Lock)
                 return sys_XOpenDisplay(display);
         }
 

CSharpRepl

72 total diagnostics across 11 rules

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 CSharpRepl.Services\Roslyn\Formatting\CustomObjectFormatters\IEnumerableFormatter.cs (line 41)

                         sb.Append(", ");
 
                         if (maxParagraphLength > sb.Length &&
▶                            sb.Length > formatter.ConsoleProfile.Width / 2) //just heuristic
                         {
                             sb.Append(", ...");
                             break;

💬 The operands in the divisive expression formatter.ConsoleProfile.Width / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 CSharpRepl.Services\Roslyn\Formatting\CustomObjectFormatters\IEnumerableFormatter.cs (line 41)

                         sb.Append(", ");
 
                         if (maxParagraphLength > sb.Length &&
▶                            sb.Length > formatter.ConsoleProfile.Width / 2) //just heuristic
                         {
                             sb.Append(", ...");
                             break;

SS004 Elementary methods of type in collection not overridden 4 hits

📄 CSharpRepl.Services\Roslyn\References\AssemblyReferenceService.cs (line 55)

         this.loadedReferenceAssemblies = new(new AssemblyReferenceComparer());
         this.loadedImplementationAssemblies = new(new AssemblyReferenceComparer());
 
▶        this.usings = new[] {
                     "System", "System.IO", "System.Collections.Generic",
                     "System.Linq", "System.Net.Http",
                     "System.Text", "System.Threading.Tasks"

💬 Type UsingDirectiveSyntax is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 CSharpRepl.Services\Roslyn\MetadataResolvers\SolutionFileMetadataResolver.cs (line 69)

             console.WriteErrorLine(error.Message);
         }
 
▶        return projects
             .SelectMany(p =>
                 p.MetadataReferences
                 .OfType<PortableExecutableReference>()

💬 Type PortableExecutableReference is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 CSharpRepl.Services\Roslyn\MetadataResolvers\CompositeMetadataReferenceResolver.cs (line 57)

         && EqualityComparer<IIndividualMetadataReferenceResolver[]>.Default.Equals(resolvers, other.resolvers);
 
     public override int GetHashCode() =>
▶        HashCode.Combine(resolvers);
 }

💬 GetHashCode() refers to mutable field resolvers (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 CSharpRepl.Services\Roslyn\MetadataResolvers\CompositeMetadataReferenceResolver.cs (line 57)

         && EqualityComparer<IIndividualMetadataReferenceResolver[]>.Default.Equals(resolvers, other.resolvers);
 
     public override int GetHashCode() =>
▶        HashCode.Combine(resolvers);
 }

💬 GetHashCode() refers to mutable field resolvers (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 28 hits

📄 CSharpRepl.Services\Roslyn\Microsoft.CodeAnalysis.PooledObjects\ObjectPool`1.cs (line 45)

 internal class ObjectPool<T> where T : class
 {
     [DebuggerDisplay("{Value,nq}")]
▶    private struct Element
     {
         internal T? Value;
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Element. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 CSharpRepl.Services\Theming\SyntaxHighlightingColor.cs (line 10)

 
 namespace CSharpRepl.Services.Theming;
 
▶public readonly struct SyntaxHighlightingColor
 {
     [JsonConstructor]
     public SyntaxHighlightingColor(string name, string foreground)

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SyntaxHighlightingColor. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 6 hits

📄 CSharpRepl.Services\Roslyn\Microsoft.CodeAnalysis.CSharp\ObjectDisplay.cs (line 37)

     private static bool TryReplaceChar(char c, out string replaceWith)
     {
         replaceWith = null;
▶        switch (c)
         {
             case '\\':
                 replaceWith = "\\\\";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 CSharpRepl\ReadEvalPrintLoop.cs (line 119)

 
     private static async Task PrintAsync(RoslynServices roslyn, IConsoleEx console, EvaluationResult result, Level level)
     {
▶        switch (result)
         {
             case EvaluationResult.Success ok:
                 if (ok.ReturnValue.HasValue)

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 8 hits

📄 CSharpRepl.Services\Roslyn\RoslynServices.cs (line 438)

             {
                 if (runtimeHelperStream != null)
                 {
▶                    var runtimeHelperText = new StreamReader(runtimeHelperStream).ReadToEnd();
                     evaluationTask = EvaluateAsync(runtimeHelperText, args);
                 }
                 else

💬 Async overload available for StreamReader.ReadToEnd (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 CSharpRepl.Services\Roslyn\RoslynServices.cs (line 467)

 
         if ((await scriptRunner.HasValueReturningStatement(input, cancellationToken).ConfigureAwait(false)).TryGet(out var result))
         {
▶            var root = result.Expression.SyntaxTree.GetRoot(cancellationToken);
             var expressionToBeWrapped = result.Expression;
             var wrappedExpression = expressionToBeWrapped;
             if (result.Type is { Name: "Span" or "ReadOnlySpan", ContainingNamespace.Name: "System" })

💬 Async overload available for SyntaxTree.GetRoot (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS050 Parameter assigned in constructor 2 hits

📄 CSharpRepl.Services\Configuration.cs (line 99)

         }
         else
         {
▶            if (string.IsNullOrEmpty(theme)) theme = DefaultThemeRelativePath;
             bool themeExists = File.Exists(theme);
             if (!themeExists)
             {

💬 Suspicious assignment of parameter theme in constructor of Configuration (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

📄 CSharpRepl.Services\Configuration.cs (line 99)

         }
         else
         {
▶            if (string.IsNullOrEmpty(theme)) theme = DefaultThemeRelativePath;
             bool themeExists = File.Exists(theme);
             if (!themeExists)
             {

💬 Suspicious assignment of parameter theme in constructor of Configuration (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS050-ParameterAssignedInConstructor.md)

SS057 Collection manipulated during traversal 2 hits

📄 CSharpRepl.Services\Nuget\ConsoleNugetLogger.cs (line 71)

                 {
                     if (!lines[i].IsError)
                     {
▶                        lines.RemoveAt(i);
                         break;
                     }
                 }

📄 CSharpRepl.Services\Nuget\ConsoleNugetLogger.cs (line 71)

                 {
                     if (!lines[i].IsError)
                     {
▶                        lines.RemoveAt(i);
                         break;
                     }
                 }

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 CSharpRepl.Services\Roslyn\RoslynServices.cs (line 434)

 
             const string RuntimeHelperName = "CSharpRepl.Services.RuntimeHelper.cs";
             Task evaluationTask;
▶            using (var runtimeHelperStream = Assembly.GetExecutingAssembly().GetManifestResourceStream(RuntimeHelperName))
             {
                 if (runtimeHelperStream != null)
                 {

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 CSharpRepl.Services\Roslyn\RoslynServices.cs (line 434)

 
             const string RuntimeHelperName = "CSharpRepl.Services.RuntimeHelper.cs";
             Task evaluationTask;
▶            using (var runtimeHelperStream = Assembly.GetExecutingAssembly().GetManifestResourceStream(RuntimeHelperName))
             {
                 if (runtimeHelperStream != null)
                 {

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS064 Unnecessary ToString() on Span 8 hits

📄 CSharpRepl.Tests\FakeConsole.cs (line 306)

     public void Write(ReadOnlySpan<char> value) => Write(value.ToString());
     public void WriteError(ReadOnlySpan<char> value) => WriteError(value.ToString());
     public void WriteErrorLine(ReadOnlySpan<char> value) => WriteErrorLine(value.ToString());
▶    public void WriteLine(ReadOnlySpan<char> value) => WriteLine(value.ToString());
 }

💬 Unnecessary ToString() call, an overload that accepts ReadOnlySpan<char> is available (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS064-UnnecessaryToStringOnSpan.md)

📄 CSharpRepl.Tests\FakeConsole.cs (line 303)

     public abstract void WriteLine(string? value);
 
     //following implementations is needed because NSubstitute does not support ROS
▶    public void Write(ReadOnlySpan<char> value) => Write(value.ToString());
     public void WriteError(ReadOnlySpan<char> value) => WriteError(value.ToString());
     public void WriteErrorLine(ReadOnlySpan<char> value) => WriteErrorLine(value.ToString());
     public void WriteLine(ReadOnlySpan<char> value) => WriteLine(value.ToString());

💬 Unnecessary ToString() call, an overload that accepts ReadOnlySpan<char> is available (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS064-UnnecessaryToStringOnSpan.md)

SS066 Disposable field is not disposed 8 hits

📄 CSharpRepl.Tests\ProgramTests.cs (line 61)

 {
     private static readonly Semaphore semaphore = new(1, 1);
 
▶    private readonly TextWriter normalStandardOutput;
     private readonly TextWriter normalStandardError;
     private readonly StringWriter fakeConsoleOutput;
     private readonly StringWriter fakeConsoleError;

💬 Disposable field normalStandardOutput in type OutputCollector is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 CSharpRepl.Tests\ProgramTests.cs (line 62)

     private static readonly Semaphore semaphore = new(1, 1);
 
     private readonly TextWriter normalStandardOutput;
▶    private readonly TextWriter normalStandardError;
     private readonly StringWriter fakeConsoleOutput;
     private readonly StringWriter fakeConsoleError;
 

💬 Disposable field normalStandardError in type OutputCollector is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

orleans

64 total diagnostics across 6 rules

SS005 Equals() and GetHashCode() not implemented together 2 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 12 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 10 hits

No source samples extracted

SS018 Switch does not handle all enum options 4 hits

No source samples extracted

SS019 Switch is missing default label 34 hits

No source samples extracted

SS046 Unbounded stackalloc 2 hits

No source samples extracted

VsVim

64 total diagnostics across 5 rules

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 Src\VimWpf\Implementation\Mouse\VimMouseProcessor.cs (line 34)

             _mouseDevice = InputManager.Current.PrimaryMouseDevice;
             _mouseCaptured = false;
             _scrollTimer = new DispatcherTimer(
▶                new TimeSpan(0, 0, 0, 0, 1000 / s_linesPerSecond),
                 DispatcherPriority.Normal,
                 protectedOperations.GetProtectedEventHandler(OnScrollTimer),
                 Dispatcher.CurrentDispatcher);

💬 The operands in the divisive expression 1000 / s_linesPerSecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Src\VimWpf\Implementation\CharDisplay\CharDisplayTaggerSource.cs (line 174)

 
             do
             {
▶                mid = (min + max) / 2;
                 current = _adornmentCache[mid].Position;
 
                 if (current == position)

💬 The operands in the divisive expression (min + max) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 12 hits

📄 Src\VimTestUtils\Extensions.cs (line 42)

                 TaskScheduler.Default);
         }
 
▶        internal readonly struct SemaphoreDisposer : IDisposable
         {
             private readonly Semaphore _semaphore;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct SemaphoreDisposer. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Src\VimEditorHost\KeyboardInputSimulation.cs (line 176)

 
         #region KeyData
 
▶        private readonly struct KeyData
         {
             internal readonly Key Key;
             internal readonly ModifierKeys ModifierKeys;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct KeyData. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 18 hits

📄 Src\VimEditorHost\KeyboardInputSimulation.cs (line 415)

 
         private Key VimKeyToKey(VimKey vimKey)
         {
▶            switch (vimKey)
             {
                 case VimKey.Escape:
                     return Key.Escape;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 Src\VimApp\VimAppHost.cs (line 241)

                 }
 
                 var target = -1;
▶                switch (windowKind)
                 {
                     case WindowKind.Up:
                         target = i - 1;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 26 hits

📄 Src\VimEditorHost\KeyboardInputSimulation.cs (line 415)

 
         private Key VimKeyToKey(VimKey vimKey)
         {
▶            switch (vimKey)
             {
                 case VimKey.Escape:
                     return Key.Escape;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Src\VimApp\VimAppHost.cs (line 241)

                 }
 
                 var target = -1;
▶                switch (windowKind)
                 {
                     case WindowKind.Up:
                         target = i - 1;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS066 Disposable field is not disposed 4 hits

📄 Src\VimTestUtils\Extensions.cs (line 44)

 
         internal readonly struct SemaphoreDisposer : IDisposable
         {
▶            private readonly Semaphore _semaphore;
 
             public SemaphoreDisposer(Semaphore semaphore)
             {

💬 Disposable field _semaphore in type SemaphoreDisposer is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Src\VimWpf\Implementation\RelativeLineNumbers\RelativeLineNumbersMargin.cs (line 18)

         private readonly IWpfTextView _textView;
         private readonly ILineFormatTracker _formatTracker;
         private readonly IVimLocalSettings _localSettings;
▶        private readonly IWpfTextViewMargin _marginContainer;
         private readonly IProtectedOperations _protectedOperations;
 
         private readonly LineNumbersTracker _linesTracker;

💬 Disposable field _marginContainer in type RelativeLineNumbersMargin is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Emby.Plugins.JavScraper

64 total diagnostics across 7 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 32 hits

📄 Emby.Actress\EmbyActressImportService.cs (line 32)

 
             sb.AppendLine($@"<?xml version=""1.0"" encoding=""utf-8"" standalone=""yes""?>
 <movie>
▶  <dateadded>{DateTime.Now:yyyy-MM-dd HH:mm}</dateadded>
   <title>全部女优</title>");
 
             foreach (var a in ls)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Emby.Plugins.JavScraper\Baidu\BaiduAccessToken.cs (line 53)

         /// <summary>
         /// 创建时间
         /// </summary>
▶        public DateTime created { get; set; } = DateTime.Now;
 
         /// <summary>
         /// 过期时间

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 8 hits

📄 Emby.Plugins.JavScraper\Services\ImageProxyService.cs (line 186)

                         {
                             var h = bitmap.Height;
                             var w = bitmap.Width;
▶                            var w2 = h * 2 / 3; //封面宽度
 
                             if (w2 < w) //需要剪裁
                             {

💬 The operands in the divisive expression h * 2 / 3 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Emby.Plugins.JavScraper\Services\ImageProxyService.cs (line 195)

 
                                 if (x > 0) //百度人体识别，中心点位置
                                 {
▶                                    if (x + w2 / 2 > w) //右边
                                         start_w = w - w2;
                                     else if (x - w2 / 2 < 0)//左边
                                         start_w = 0;

💬 The operands in the divisive expression w2 / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS032 Thread.Sleep used in async method 4 hits

📄 Emby.Plugins.JavScraper\Extensions\NamedLockerAsync.cs (line 43)

             finally
             {
                 locker.Release();
▶                Thread.Sleep(1);
                 if (locker.CurrentCount == 1)
                 {
                     _lockDict.TryRemove(name, out locker);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

📄 Emby.Plugins.JavScraper\Extensions\NamedLockerAsync.cs (line 71)

             finally
             {
                 locker.Release();
▶                Thread.Sleep(1);
                 if (locker.CurrentCount == 1)
                 {
                     _lockDict.TryRemove(name, out locker);

💬 Synchronously sleeping thread in an async method (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS032-ThreadSleepInAsyncMethod.md)

SS033 Async overload is available 8 hits

📄 Emby.Plugins.JavScraper\Services\UpdateService.cs (line 84)

 
                 if (resp.StatusCode == System.Net.HttpStatusCode.OK)
                 {
▶                    var data = jsonSerializer.DeserializeFromStream<Rootobject>(await resp.Content.ReadAsStreamAsync());
                     r.UpdateMessage = data.body;
 
                     string key =

💬 Async overload available for IJsonSerializer.DeserializeFromStream (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Emby.Actress\EmbyActressImportService.cs (line 67)

 
             try
             {
▶                File.WriteAllText(nfo_name, nfo_txt);
                 Console.WriteLine($"保存 {nfo_name} 文件成功，如何使用请参阅 https://github.com/JavScraper/Emby.Plugins.JavScraper/Emby.Actress");
             }
             catch

💬 Async overload available for File.WriteAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 6 hits

📄 Emby.Plugins.JavScraper\Extensions\NamedLockerAsync.cs (line 95)

             return wait.IsCompleted ?
                         m_releaser :
                         wait.ContinueWith((_, state) => (IDisposable)state,
▶                            m_releaser.Result, CancellationToken.None,
             TaskContinuationOptions.ExecuteSynchronously, TaskScheduler.Default);
         }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Emby.Plugins.JavScraper\JavMovieProvider.cs (line 301)

                 scrapers = scrapers.Where(o => enableScrapers.Contains(o.Name)).ToList();
             var tasks = scrapers.Select(o => o.Query(key)).ToArray();
             await Task.WhenAll(tasks);
▶            var all = tasks.Where(o => o.Result?.Any() == true).SelectMany(o => o.Result).ToList();
 
             _logger?.Info($"{nameof(GetSearchResults)} name:{searchInfo.Name} id:{javid?.id} count:{all.Count}");
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS047 LINQ traversal before filter 4 hits

📄 Emby.Plugins.JavScraper\FixChineseSubtitleGenreTask.cs (line 78)

                     dir.LibraryOptions.TypeOptions?.Any(o => o.MetadataFetchers?.Contains(Plugin.NAME) == true) == true)
                 .SelectMany(o => o.Locations).ToList();
 
▶            var eligibleFiles = libraryFolderPaths.SelectMany(GetVideoFiles)
                 .OrderBy(_fileSystem.GetCreationTimeUtc)
                 .Where(i => IsVideoFile(i))
                 .ToList();

📄 Emby.Plugins.JavScraper\JavOrganizeTask.cs (line 98)

                 .Where(o => IsValidWatchLocation(o, libraryFolderPaths))
                 .ToList();
 
▶            var eligibleFiles = watchLocations.SelectMany(GetFilesToOrganize)
                 .OrderBy(_fileSystem.GetCreationTimeUtc)
                 .Where(i => EnableOrganization(i, options))
                 .ToList();

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 Emby.Plugins.JavScraper\Services\ImageProxyService.cs (line 177)

             logger?.Info($"{nameof(CutImage)}: staring...");
             try
             {
▶                using (var ms = new MemoryStream(bytes))
                 {
                     ms.Position = 0;
                     using (var inputStream = new SKManagedStream(ms))

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Emby.Plugins.JavScraper\Services\ImageProxyService.cs (line 177)

             logger?.Info($"{nameof(CutImage)}: staring...");
             try
             {
▶                using (var ms = new MemoryStream(bytes))
                 {
                     ms.Position = 0;
                     using (var inputStream = new SKManagedStream(ms))

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

FluentTerminal

62 total diagnostics across 1 rules

SS008 GetHashCode() refers to mutable or static member 62 hits

📄 FluentTerminal.Models\ExportedTerminalTheme.cs (line 28)

 
         public override int GetHashCode()
         {
▶            return -1751912210 + EqualityComparer<string>.Default.GetHashCode(EncodedImage);
         }
     }
 }

💬 GetHashCode() refers to mutable property EncodedImage (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 FluentTerminal.Models\TerminalTheme.cs (line 42)

 
         public override int GetHashCode()
         {
▶            return HashCode.Combine(Name, Author, Colors);
         }
     }
 }

💬 GetHashCode() refers to mutable property Name (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

YoutubePlaylistDownloader

56 total diagnostics across 4 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 YoutubePlaylistDownloader\GlobalConsts.cs (line 252)

     public static async Task Log(string message, object sender)
     {
         using StreamWriter sw = new(ErrorFilePath, true);
▶        await sw.WriteLineAsync($"[{DateTime.Now.ToUniversalTime()}], [{sender}]:\n\n{message}\n\n").ConfigureAwait(false);
 
     }
     public static string CleanFileName(string filename)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 YoutubePlaylistDownloader\GlobalConsts.cs (line 252)

     public static async Task Log(string message, object sender)
     {
         using StreamWriter sw = new(ErrorFilePath, true);
▶        await sw.WriteLineAsync($"[{DateTime.Now.ToUniversalTime()}], [{sender}]:\n\n{message}\n\n").ConfigureAwait(false);
 
     }
     public static string CleanFileName(string filename)

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 12 hits

📄 YoutubePlaylistDownloader\GlobalConsts.cs (line 281)

     {
         using var imageBuffer = new MemoryStream(imageBytes);
         using var image = System.Drawing.Image.FromStream(imageBuffer);
▶        var cropRectangle = new Rectangle((image.Width - image.Height) / 2, 0, image.Height, image.Height);
         using var bitmap = new Bitmap(cropRectangle.Width, cropRectangle.Height);
         using var graphics = Graphics.FromImage(bitmap);
         graphics.DrawImage(image, new Rectangle(0, 0, bitmap.Width, bitmap.Height), cropRectangle, GraphicsUnit.Pixel);

💬 The operands in the divisive expression (image.Width - image.Height) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 YoutubePlaylistDownloader\DownloadPage.xaml.cs (line 370)

                         {
                             try
                             {
▶                                var percent = Convert.ToInt32(args.StreamLength * 100 / bestQuality.Size.Bytes);
                                 CurrentProgressPercent = percent;
                                 double speedInMB = 0;
                                 var delta = sw.Elapsed - ts;

💬 The operands in the divisive expression args.StreamLength * 100 / bestQuality.Size.Bytes are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS059 IAsyncDisposable not disposed asynchronously 24 hits

📄 YoutubePlaylistDownloader\GlobalConsts.cs (line 251)

     }
     public static async Task Log(string message, object sender)
     {
▶        using StreamWriter sw = new(ErrorFilePath, true);
         await sw.WriteLineAsync($"[{DateTime.Now.ToUniversalTime()}], [{sender}]:\n\n{message}\n\n").ConfigureAwait(false);
 
     }

💬 StreamWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 YoutubePlaylistDownloader\DownloadUpdate.xaml.cs (line 116)

     private async Task StartUpdate()
     {
         await Dispatcher.InvokeAsync(() => HeadlineTextBlock.Text = $"{FindResource("DownloadingUpdateSetup")}");
▶        using var fs = new ProgressStream(new FileStream(GlobalConsts.UpdateSetupLocation, FileMode.Create));
         fs.BytesWritten += DownloadProgressChanged;
         var latestVersionLink = await httpClient.GetAsync("https://raw.githubusercontent.com/shaked6540/YoutubePlaylistDownloader/master/YoutubePlaylistDownloader/latestVersionLink.txt").ConfigureAwait(false);
         var response = await httpClient.GetAsync(await latestVersionLink.Content.ReadAsStringAsync().ConfigureAwait(false)).ConfigureAwait(false);

💬 ProgressStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 16 hits

📄 YoutubePlaylistDownloader\DownloadUpdate.xaml.cs (line 81)

             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(CurrentStatus)));
         }
     }
▶    private HttpClient httpClient;
     private readonly CancellationTokenSource cancellationTokenSource;
 
     public DownloadUpdate(Version latestVersion, string changelog, bool updateLater = false)

💬 Disposable field httpClient in type DownloadUpdate is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 YoutubePlaylistDownloader\DownloadUpdate.xaml.cs (line 82)

         }
     }
     private HttpClient httpClient;
▶    private readonly CancellationTokenSource cancellationTokenSource;
 
     public DownloadUpdate(Version latestVersion, string changelog, bool updateLater = false)
     {

💬 Disposable field cancellationTokenSource in type DownloadUpdate is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

parsec-vdd

54 total diagnostics across 6 rules

SS003 Integer divided by integer causing implicit rounding 6 hits

📄 app\Components\CustomPage.xaml.cs (line 42)

                     // Check negative values & limit 8K resolution
                     if (width < 0 || width > 7680 || height < 0 || height > 4320 || hz < 0)
                     {
▶                        MessageBox.Show(App.GetTranslation("t_msg_custom_invalid_slot", i / 3 + 1),
                             Program.AppName, MessageBoxButton.OK, MessageBoxImage.Warning);
                         return;
                     }

💬 The operands in the divisive expression i / 3 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 app\MirrorWindow.cs (line 254)

             }
 
             // center the viewport
▶            viewportX = (clientWidth - viewportWidth) / 2;
             viewportY = (clientHeight - viewportHeight) / 2;
 
             return new Viewport

💬 The operands in the divisive expression (clientWidth - viewportWidth) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 30 hits

📄 app\Helper.cs (line 107)

         static extern int DwmSetWindowAttribute(IntPtr hwnd, int attr, ref int attrValue, int attrSize);
 
         [StructLayout(LayoutKind.Sequential)]
▶        struct MARGINS
         {
             public int leftWidth;
             public int rightWidth;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MARGINS. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 app\PowerEvents.cs (line 233)

             public delegate uint DeviceNotifyCallbackRoutine(IntPtr Context, uint Type, IntPtr Setting);
 
             [StructLayout(LayoutKind.Sequential)]
▶            public struct DEVICE_NOTIFY_SUBSCRIBE_PARAMETERS
             {
                 [MarshalAs(UnmanagedType.FunctionPtr)]
                 public DeviceNotifyCallbackRoutine Callback;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DEVICE_NOTIFY_SUBSCRIBE_PARAMETERS. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 2 hits

📄 app\Tray.cs (line 178)

             }
             else if (ex is Vdd.ErrorOperationFailed errOperation)
             {
▶                switch (errOperation.Type)
                 {
                     case Vdd.ErrorOperationFailed.Operation.AddDisplay:
                         message = App.GetTranslation("t_msg_failed_to_add_display");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 app\Tray.cs (line 178)

             }
             else if (ex is Vdd.ErrorOperationFailed errOperation)
             {
▶                switch (errOperation.Type)
                 {
                     case Vdd.ErrorOperationFailed.Operation.AddDisplay:
                         message = App.GetTranslation("t_msg_failed_to_add_display");

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 2 hits

📄 app\MirrorWindow.cs (line 66)

 
         private void MirrorWorker(string displayDevice, int fps)
         {
▶            var hwnd = WhenHwnd.Task.Result;
 
             var dcDest = Native.GetDC(hwnd);
             var bgBrush = Native.GetStockObject(/*BLACK_BRUSH*/ 4);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 app\MirrorWindow.cs (line 66)

 
         private void MirrorWorker(string displayDevice, int fps)
         {
▶            var hwnd = WhenHwnd.Task.Result;
 
             var dcDest = Native.GetDC(hwnd);
             var bgBrush = Native.GetStockObject(/*BLACK_BRUSH*/ 4);

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS046 Unbounded stackalloc 4 hits

📄 app\Device.cs (line 163)

         {
             uint propType;
             int length = 128 * sizeof(ushort);
▶            var buffer = stackalloc byte[length];
 
             Native.CM_Get_DevNode_PropertyW(devInst,
                 ref Native.DEVPROPKEY.Device_DeviceDesc, &propType, buffer, &length, 0);

📄 app\Device.cs (line 202)

         public static Version GetDeviceDriverVersion(uint devInst)
         {
             int length = 64;
▶            var buffer = stackalloc byte[length];
 
             uint propType;
             Native.CM_Get_DevNode_PropertyW(devInst,

SS066 Disposable field is not disposed 10 hits

📄 app\Tray.cs (line 18)

         NotifyIcon TrayIcon;
         Thread GuiThread;
 
▶        ToolStripMenuItem MI_Language;
 
         ToolStripMenuItem MI_RunOnStartup;
         ToolStripMenuItem MI_RestoreDisplays;

💬 Disposable field MI_Language in type Tray is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 app\Tray.cs (line 20)

 
         ToolStripMenuItem MI_Language;
 
▶        ToolStripMenuItem MI_RunOnStartup;
         ToolStripMenuItem MI_RestoreDisplays;
         ToolStripMenuItem MI_FallbackDisplay;
         ToolStripMenuItem MI_KeepScreenOn;

💬 Disposable field MI_RunOnStartup in type Tray is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Seq.Api

52 total diagnostics across 5 rules

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

No source samples extracted

SS033 Async overload is available 12 hits

No source samples extracted

SS034 Accessing Task.Result without await 6 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 4 hits

No source samples extracted

SS066 Disposable field is not disposed 6 hits

No source samples extracted

qmk_toolbox

50 total diagnostics across 6 rules

SS001 Async method with void return type 10 hits

📄 windows\QMK Toolbox\MainWindow.cs (line 312)

             }
         }
 
▶        private async void ResetAllAsync()
         {
             string selectedMcu = (string)mcuBox.SelectedValue;
 

💬 Method ResetAllAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 windows\QMK Toolbox\MainWindow.cs (line 277)

             }
         }
 
▶        private async void FlashAllAsync()
         {
             string selectedMcu = (string)mcuBox.SelectedValue;
             string filePath = filepathBox.Text;

💬 Method FlashAllAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS019 Switch is missing default label 22 hits

📄 windows\QMK Toolbox\LogTextBox.cs (line 64)

 
             foreach (string line in lines)
             {
▶                switch (type)
                 {
                     case MessageType.Bootloader:
                         AppendText($"{line}\n", Color.Yellow);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 windows\QMK Toolbox\KeyTester\KeyTesterWindow.cs (line 198)

             // If scancode is 0 but marked as extended, switch on VK instead as it's most likely a media key that won't change with keyboard layout anyway
             if (scanCode == 0x100)
             {
▶                switch (vKey)
                 {
                     case VK_VOLUME_MUTE:
                         return keyMute;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS034 Accessing Task.Result without await 2 hits

📄 windows\QMK Toolbox\Hid\HidConsoleDevice.cs (line 22)

 
         private void RegisterReportTask()
         {
▶            Task.Run(async () => await ReadReportAsync()).ContinueWith(t => HidDeviceReportEvent(t.Result));
         }
 
         private async Task<HidReport> ReadReportAsync()

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 windows\QMK Toolbox\Hid\HidConsoleDevice.cs (line 22)

 
         private void RegisterReportTask()
         {
▶            Task.Run(async () => await ReadReportAsync()).ContinueWith(t => HidDeviceReportEvent(t.Result));
         }
 
         private async Task<HidReport> ReadReportAsync()

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 windows\QMK Toolbox\Usb\UsbListener.cs (line 30)

 
         private void EnumerateUsbDevices(bool connected)
         {
▶            var enumeratedDevices = new ManagementObjectSearcher(@"SELECT * FROM Win32_PnPEntity WHERE DeviceID LIKE 'USB%'").Get()
                 .Cast<ManagementBaseObject>().ToList()
                 .Where(d => (d.GetPropertyValue("HardwareID") as string[])?.Any(s => UsbIdRegex.Match(s).Success) ?? false);
 

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 windows\QMK Toolbox\Usb\UsbListener.cs (line 30)

 
         private void EnumerateUsbDevices(bool connected)
         {
▶            var enumeratedDevices = new ManagementObjectSearcher(@"SELECT * FROM Win32_PnPEntity WHERE DeviceID LIKE 'USB%'").Get()
                 .Cast<ManagementBaseObject>().ToList()
                 .Where(d => (d.GetPropertyValue("HardwareID") as string[])?.Any(s => UsbIdRegex.Match(s).Success) ?? false);
 

💬 ToList is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 windows\QMK Toolbox\MainWindow.cs (line 465)

                 client.DefaultRequestHeaders.UserAgent.ParseAdd("QMK Toolbox");
 
                 var response = await client.GetAsync(url);
▶                using (var fs = new FileStream(destFile, FileMode.CreateNew))
                 {
                     await response.Content.CopyToAsync(fs);
                     logTextBox.LogInfo($"File saved to: {destFile}");

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 windows\QMK Toolbox\MainWindow.cs (line 465)

                 client.DefaultRequestHeaders.UserAgent.ParseAdd("QMK Toolbox");
 
                 var response = await client.GetAsync(url);
▶                using (var fs = new FileStream(destFile, FileMode.CreateNew))
                 {
                     await response.Content.CopyToAsync(fs);
                     logTextBox.LogInfo($"File saved to: {destFile}");

💬 FileStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 12 hits

📄 windows\QMK Toolbox\Hid\HidConsoleWindow.cs (line 49)

         #endregion
 
         #region HID Console
▶        private readonly HidListener hidListener = new();
 
         private HidConsoleDevice lastReportedDevice;

💬 Disposable field hidListener in type HidConsoleWindow is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 windows\QMK Toolbox\Hid\HidListener.cs (line 84)

             consoleReportReceived?.Invoke(device, data);
         }
 
▶        private ManagementEventWatcher deviceConnectedWatcher;
         private ManagementEventWatcher deviceDisconnectedWatcher;
 
         private static ManagementEventWatcher CreateManagementEventWatcher(string eventType)

💬 Disposable field deviceConnectedWatcher in type HidListener is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

blazor-starter-kit

50 total diagnostics across 7 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 24 hits

📄 src\Application\Features\Dashboards\Queries\GetData\GetDashboardDataQuery.cs (line 50)

                 RoleCount = await _roleService.GetCountAsync()
             };
 
▶            var selectedYear = DateTime.Now.Year;
             double[] productsFigure = new double[13];
             double[] brandsFigure = new double[13];
             double[] documentsFigure = new double[13];

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Infrastructure\DatabaseSeeder.cs (line 69)

                     UserName = "mukesh",
                     EmailConfirmed = true,
                     PhoneNumberConfirmed = true,
▶                    CreatedOn = DateTime.Now,
                     IsActive = true
                 };
                 var superUserInDb = await _userManager.FindByEmailAsync(superUser.Email);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 src\Infrastructure\Services\UploadService.cs (line 77)

 
             while (max != min + 1)
             {
▶                int pivot = (max + min) / 2;
                 if (File.Exists(string.Format(pattern, pivot)))
                     min = pivot;
                 else

💬 The operands in the divisive expression (max + min) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\Infrastructure\Services\UploadService.cs (line 77)

 
             while (max != min + 1)
             {
▶                int pivot = (max + min) / 2;
                 if (File.Exists(string.Format(pattern, pivot)))
                     min = pivot;
                 else

SS004 Elementary methods of type in collection not overridden 6 hits

📄 src\Application\Extensions\ExpressionExtensions.cs (line 28)

             ParameterExpression p = left.Parameters.First();
             SubstExpressionVisitor visitor = new SubstExpressionVisitor
             {
▶                Subst = {[right.Parameters.First()] = p}
             };
 
             Expression body = Expression.OrElse(left.Body, visitor.Visit(right.Body));

📄 src\Application\Extensions\ExpressionExtensions.cs (line 15)

             ParameterExpression p = left.Parameters.First();
             SubstExpressionVisitor visitor = new SubstExpressionVisitor
             {
▶                Subst = {[right.Parameters.First()] = p}
             };
 
             Expression body = Expression.AndAlso(left.Body, visitor.Visit(right.Body));

SS018 Switch does not handle all enum options 4 hits

📄 src\Infrastructure\Contexts\BlazorHeroContext.cs (line 39)

         {
             foreach (var entry in ChangeTracker.Entries<IAuditableEntity>().ToList())
             {
▶                switch (entry.State)
                 {
                     case EntityState.Added:
                         entry.Entity.CreatedOn = _dateTimeService.NowUtc;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 src\Infrastructure\Contexts\AuditableContext.cs (line 60)

                         continue;
                     }
 
▶                    switch (entry.State)
                     {
                         case EntityState.Added:
                             auditEntry.AuditType = AuditType.Create;

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 10 hits

📄 src\Infrastructure\Contexts\BlazorHeroContext.cs (line 39)

         {
             foreach (var entry in ChangeTracker.Entries<IAuditableEntity>().ToList())
             {
▶                switch (entry.State)
                 {
                     case EntityState.Added:
                         entry.Entity.CreatedOn = _dateTimeService.NowUtc;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Infrastructure\Contexts\AuditableContext.cs (line 60)

                         continue;
                     }
 
▶                    switch (entry.State)
                     {
                         case EntityState.Added:
                             auditEntry.AuditType = AuditType.Create;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS058 String concatenated in a loop 2 hits

📄 src\Client.Infrastructure\Routes\ProductsEndpoints.cs (line 14)

             {
                 foreach (var orderByPart in orderBy)
                 {
▶                    url += $"{orderByPart},";
                 }
                 url = url[..^1]; // loose training ,
             }

📄 src\Client.Infrastructure\Routes\ProductsEndpoints.cs (line 14)

             {
                 foreach (var orderByPart in orderBy)
                 {
▶                    url += $"{orderByPart},";
                 }
                 url = url[..^1]; // loose training ,
             }

SS066 Disposable field is not disposed 2 hits

📄 src\Client.Infrastructure\Managers\Interceptors\HttpInterceptorManager.cs (line 17)

         private readonly HttpClientInterceptor _interceptor;
         private readonly IAuthenticationManager _authenticationManager;
         private readonly NavigationManager _navigationManager;
▶        private readonly ISnackbar _snackBar;
         private readonly IStringLocalizer<HttpInterceptorManager> _localizer;
 
         public HttpInterceptorManager(

💬 Disposable field _snackBar in type HttpInterceptorManager is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Client.Infrastructure\Managers\Interceptors\HttpInterceptorManager.cs (line 17)

         private readonly HttpClientInterceptor _interceptor;
         private readonly IAuthenticationManager _authenticationManager;
         private readonly NavigationManager _navigationManager;
▶        private readonly ISnackbar _snackBar;
         private readonly IStringLocalizer<HttpInterceptorManager> _localizer;
 
         public HttpInterceptorManager(

💬 Disposable field _snackBar in type HttpInterceptorManager is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

GuardClauses

44 total diagnostics across 3 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 38 hits

📄 test\GuardClauses.UnitTests\GuardAgainstDefault.cs (line 16)

         Guard.Against.Default("", "string");
         Guard.Against.Default(1, "int");
         Guard.Against.Default(Guid.NewGuid(), "guid");
▶        Guard.Against.Default(DateTime.Now, "datetime");
         Guard.Against.Default(new Object(), "object");
     }
 

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 test\GuardClauses.UnitTests\GuardAgainstOutOfRangeForDateTime.cs (line 16)

     [InlineData(-1, 0)]
     public void DoesNothingGivenInRangeValue(int rangeFromOffset, int rangeToOffset)
     {
▶        DateTime input = DateTime.Now;
         DateTime rangeFrom = input.AddSeconds(rangeFromOffset);
         DateTime rangeTo = input.AddSeconds(rangeToOffset);
         Guard.Against.OutOfRange(input, "index", rangeFrom, rangeTo);

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 test\GuardClauses.UnitTests\GuardAgainstExpression.cs (line 10)

 
 public class GuardAgainstExpression
 {
▶    public struct CustomStruct
     {
         public string FieldName { get; set; }
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CustomStruct. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 test\GuardClauses.UnitTests\GuardAgainstExpressionDeprecated.cs (line 13)

 /// </summary>
 public class GuardAgainstExpressionDeprecated
 {
▶    public struct CustomStruct
     {
         public string FieldName { get; set; }
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct CustomStruct. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS049 Comparing strings without StringComparison 2 hits

📄 test\GuardClauses.UnitTests\NamespaceSeparate\ExtendingGuard.cs (line 18)

     public static void Foo(this IGuardClause guardClause, string input, [CallerArgumentExpression("input")] string? parameterName = null)
 #endif
     {
▶        if (input?.ToLower() == "foo")
             throw new ArgumentException("Should not have been foo!", parameterName);
     }
 }

📄 test\GuardClauses.UnitTests\NamespaceSeparate\ExtendingGuard.cs (line 18)

     public static void Foo(this IGuardClause guardClause, string input, [CallerArgumentExpression("input")] string? parameterName = null)
 #endif
     {
▶        if (input?.ToLower() == "foo")
             throw new ArgumentException("Should not have been foo!", parameterName);
     }
 }

DotNetGuide

44 total diagnostics across 6 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 10 hits

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\LinqExercise.cs (line 187)

Source context not available

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\LinqExercise.cs (line 191)

Source context not available

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 20 hits

Source context not available

💬 The operands in the divisive expression (right - left) / 2 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

Source context not available

💬 The operands in the divisive expression max / exp are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\LinqExercise.cs (line 324)

Source context not available

💬 Type StudentInfo is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\LinqExercise.cs (line 324)

Source context not available

SS009 Random instantiated in a loop 4 hits

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\GotoExercise.cs (line 17)

Source context not available

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\GotoExercise.cs (line 57)

Source context not available

💬 Variable random of type System.Random is instantiated in a loop. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS009-LoopedRandomInstantiation.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\CSharp12GrammarExercise.cs (line 84)

Source context not available

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Distance. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\CSharp12GrammarExercise.cs (line 99)

Source context not available

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Buffer. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS051 Locking on mutable reference 4 hits

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\CSharp13GrammarExercise.cs (line 32)

Source context not available

💬 A lock was obtained on _oldLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 DotNetGuidePractice\HelloDotNetGuide\CSharpÞ»¡µ│ò\CSharp13GrammarExercise.cs (line 38)

Source context not available

💬 A lock was obtained on _newLock but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

Telegram.Bot

42 total diagnostics across 6 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 test\Telegram.Bot.Tests.Integ\Games\GamesFixture.cs (line 57)

     static async Task<User> GetPlayerIdFromChatAdmins(TestsFixture testsFixture, long chatId)
     {
         ChatMember[] admins = await testsFixture.BotClient.GetChatAdministrators(chatId);
▶        ChatMember player = admins[new Random(DateTime.Now.Millisecond).Next(admins.Length)];
         return player.User;
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 test\Telegram.Bot.Tests.Integ\Games\GamesFixture.cs (line 57)

     static async Task<User> GetPlayerIdFromChatAdmins(TestsFixture testsFixture, long chatId)
     {
         ChatMember[] admins = await testsFixture.BotClient.GetChatAdministrators(chatId);
▶        ChatMember player = admins[new Random(DateTime.Now.Millisecond).Next(admins.Length)];
         return player.User;
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS019 Switch is missing default label 12 hits

📄 src\Telegram.Bot\Extensions\FormatExtensions.cs (line 196)

                     sb.Insert(i, tag); i += tag.Length;
                 }
             }
▶            switch (sb[i])
             {
                 case '&': sb.Insert(i + 1, "amp;"); i += 4; break;
                 case '<': sb.Insert(i, "&lt"); sb[i += 3] = ';'; break;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Telegram.Bot\Extensions\FormatExtensions.cs (line 77)

                     sb.Insert(i, md); i += md.Length;
                 }
             }
▶            switch (lastCh = sb[i])
             {
                 case '_': case '*': case '~': case '#': case '+': case '-': case '=': case '.': case '!':
                 case '[': case ']': case '(': case ')': case '{': case '}': case '>': case '|': case '\\':

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 8 hits

📄 test\Telegram.Bot.Tests.Unit\Polling\ReceiveAsyncTests.cs (line 27)

             await Task.Delay(10, cancellationTokenSource.Token);
             if (update.Message.Text is "end")
             {
▶                cancellationTokenSource.Cancel();
             }
         }
 

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 test\Telegram.Bot.Tests.Unit\Polling\ReceiveAsyncTests.cs (line 65)

             await Task.Delay(10, cancellationTokenSource.Token);
             if (update.Message.Text is "end")
             {
▶                globalCancelToken.Cancel();
             }
         }
 

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS058 String concatenated in a loop 4 hits

📄 src\Telegram.Bot\Extensions\FormatExtensions.cs (line 64)

                         else if (nextEntity.Type is MessageEntityType.DateTime)
                         {
                             closing.md = string.IsNullOrEmpty(nextEntity.DateTimeFormat) ? "" : $"&format={nextEntity.DateTimeFormat}";
▶                            closing.md = $"](tg://time?unix={((DateTimeOffset)nextEntity.UnixTime!).ToUnixTimeSeconds()}{closing.md})";
                         }
                     }
                     else if (md[0] == '>')

📄 src\Telegram.Bot\Extensions\FormatExtensions.cs (line 64)

                         else if (nextEntity.Type is MessageEntityType.DateTime)
                         {
                             closing.md = string.IsNullOrEmpty(nextEntity.DateTimeFormat) ? "" : $"&format={nextEntity.DateTimeFormat}";
▶                            closing.md = $"](tg://time?unix={((DateTimeOffset)nextEntity.UnixTime!).ToUnixTimeSeconds()}{closing.md})";
                         }
                     }
                     else if (md[0] == '>')

SS059 IAsyncDisposable not disposed asynchronously 10 hits

📄 src\Telegram.Bot\ITelegramBotClient.cs (line 97)

         if (passportFile == null) throw new ArgumentNullException(nameof(passportFile));
         if (fileCredentials == null) throw new ArgumentNullException(nameof(fileCredentials));
         if (destination == null) throw new ArgumentNullException(nameof(destination));
▶        using var encryptedContentStream = passportFile.FileSize > 0 ? new MemoryStream((int)passportFile.FileSize) : new MemoryStream();
         var fileInfo = await botClient.ThrowIfNull().GetInfoAndDownloadFile(passportFile.FileId, encryptedContentStream, cancellationToken).ConfigureAwait(false);
         encryptedContentStream.Position = 0;
         await new Passport.Decrypter().DecryptFileAsync(encryptedContentStream, fileCredentials, destination, cancellationToken).ConfigureAwait(false);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Telegram.Bot\PassportDecrypter.cs (line 154)

             aes.Padding = PaddingMode.None;
 
             using var decrypter = aes.CreateDecryptor();
▶            using CryptoStream aesStream = new CryptoStream(data, decrypter, CryptoStreamMode.Read);
             using var sha256 = SHA256.Create();
             using CryptoStream shaStream = new CryptoStream(aesStream, sha256, CryptoStreamMode.Read);
             byte[] paddingBuffer = new byte[256];

💬 CryptoStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 6 hits

📄 test\Telegram.Bot.Tests.Integ\Framework\TestsFixture.cs (line 22)

 public class TestsFixture : IDisposable
 {
     readonly IMessageSink _diagnosticMessageSink;
▶    ConfigurationProvider _configurationProvider;
 
     public TestConfiguration Configuration => _configurationProvider.Configuration;
 

💬 Disposable field _configurationProvider in type TestsFixture is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 test\Telegram.Bot.Tests.Integ\Admin Bot\SupergroupAdminBotTestsFixture.cs (line 14)

     byte[] _oldChatPhoto;
     ChatPermissions _existingDefaultPermissions;
 
▶    public TestsFixture TestsFixture { get; }
     public ChatFullInfo Chat => TestsFixture.SupergroupChat;
     public List<Message> PinnedMessages { get; }
     public ChatInviteLink ChatInviteLink { get; set; }

💬 Disposable field TestsFixture in type SupergroupAdminBotTestsFixture is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

opentrace

40 total diagnostics across 4 rules

SS001 Async method with void return type 2 hits

📄 UI\MainForm.cs (line 92)

             }
         }
 
▶        private async void CheckUpdateAsync()
         {
             string currentVersion = System.Reflection.Assembly.GetExecutingAssembly().GetName().Version.ToString(3);
             string latestVersion = await updateService.CheckForUpdateAsync(currentVersion);

💬 Method CheckUpdateAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 UI\MainForm.cs (line 92)

             }
         }
 
▶        private async void CheckUpdateAsync()
         {
             string currentVersion = System.Reflection.Assembly.GetExecutingAssembly().GetName().Version.ToString(3);
             string latestVersion = await updateService.CheckForUpdateAsync(currentVersion);

💬 Method CheckUpdateAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS033 Async overload is available 2 hits

📄 UI\MainForm.cs (line 98)

             string latestVersion = await updateService.CheckForUpdateAsync(currentVersion);
             if (latestVersion != null)
             {
▶                App.app.Invoke(() =>
                 {
                     App.app.MainForm.Title += " " + string.Format(Resources.UPDATE_AVAILABLE, latestVersion);
                 });

💬 Async overload available for Application.Invoke (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 UI\MainForm.cs (line 98)

             string latestVersion = await updateService.CheckForUpdateAsync(currentVersion);
             if (latestVersion != null)
             {
▶                App.app.Invoke(() =>
                 {
                     App.app.MainForm.Title += " " + string.Format(Resources.UPDATE_AVAILABLE, latestVersion);
                 });

💬 Async overload available for Application.Invoke (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 8 hits

📄 Services\DnsResolverService.cs (line 52)

             IDnsClient dnsClient = new DnsHttpClient(httpClient);
 
             // 同时查询 A 和 AAAA 记录
▶            DnsMessage aResult = Task.Run(() => dnsClient.Query(DnsQueryFactory.CreateQuery(host, Ae.Dns.Protocol.Enums.DnsQueryType.A))).Result;
             DnsMessage aaaaResult = Task.Run(() => dnsClient.Query(DnsQueryFactory.CreateQuery(host, Ae.Dns.Protocol.Enums.DnsQueryType.AAAA))).Result;
 
             if (aResult.Answers.Count == 0 && aaaaResult.Answers.Count == 0)

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Services\DnsResolverService.cs (line 53)

 
             // 同时查询 A 和 AAAA 记录
             DnsMessage aResult = Task.Run(() => dnsClient.Query(DnsQueryFactory.CreateQuery(host, Ae.Dns.Protocol.Enums.DnsQueryType.A))).Result;
▶            DnsMessage aaaaResult = Task.Run(() => dnsClient.Query(DnsQueryFactory.CreateQuery(host, Ae.Dns.Protocol.Enums.DnsQueryType.AAAA))).Result;
 
             if (aResult.Answers.Count == 0 && aaaaResult.Answers.Count == 0)
             {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS066 Disposable field is not disposed 28 hits

📄 UI\Dialogs\PreferencesDialog.xeto.cs (line 22)

     public partial class PreferencesDialog : Dialog
     {
         private ObservableCollection<TracerouteResult> tracerouteResultCollection = new ObservableCollection<TracerouteResult>();
▶        private TextOutputForm textOutputForm = new TextOutputForm();
         private static NextTraceWrapper CurrentInstance { get; set; }
         UserSettings userSettings = new UserSettings();
         public PreferencesDialog()

💬 Disposable field textOutputForm in type PreferencesDialog is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 UI\Forms\ExceptionalOutputForm.xeto.cs (line 11)

 {
     public partial class ExceptionalOutputForm : Form
     {
▶        private TextArea OutputContainer;
         public ExceptionalOutputForm()
         {
             XamlReader.Load(this);

💬 Disposable field OutputContainer in type ExceptionalOutputForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

SymSpell

36 total diagnostics across 5 rules

SS003 Integer divided by integer causing implicit rounding 14 hits

📄 SymSpell\SymSpell.cs (line 801)

         public int Count { get; private set; }
         public ChunkArray(int initialCapacity)
         {
▶            int chunks = (initialCapacity + ChunkSize - 1) / ChunkSize;
             Values = new T[chunks][];
             for (int i = 0; i < Values.Length; i++) Values[i] = new T[ChunkSize];
         }

💬 The operands in the divisive expression (initialCapacity + ChunkSize - 1) / ChunkSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 SymSpell\SymSpell.cs (line 801)

         public int Count { get; private set; }
         public ChunkArray(int initialCapacity)
         {
▶            int chunks = (initialCapacity + ChunkSize - 1) / ChunkSize;
             Values = new T[chunks][];
             for (int i = 0; i < Values.Length; i++) Values[i] = new T[ChunkSize];
         }

SS008 GetHashCode() refers to mutable or static member 6 hits

📄 SymSpell\SymSpell.cs (line 110)

 
         public override int GetHashCode()
         {
▶            return term.GetHashCode();
         }
         public override string ToString()
         {

💬 GetHashCode() refers to mutable field term (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 SymSpell\SymSpell.cs (line 110)

 
         public override int GetHashCode()
         {
▶            return term.GetHashCode();
         }
         public override string ToString()
         {

💬 GetHashCode() refers to mutable field term (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 8 hits

📄 SymSpell\SymSpell.cs (line 639)

             public string suggestion;
             public int next;
         }
▶        private struct Entry
         {
             public int count;
             public int first;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Entry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 SymSpell\SymSpell.cs (line 634)

     /// of time can be achieved, as well as a reduction in final memory usage.</summary>
     public class SuggestionStage
     {
▶        private struct Node
         {
             public string suggestion;
             public int next;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Node. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS018 Switch does not handle all enum options 4 hits

📄 SymSpell\SymSpell.cs (line 578)

                         SuggestItem si = new SuggestItem(suggestion, distance, suggestionCount);
                         if (suggestions.Count > 0)
                         {
▶                            switch (verbosity)
                             {
                                 case Verbosity.Closest:
                                     {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 SymSpell\SymSpell.cs (line 578)

                         SuggestItem si = new SuggestItem(suggestion, distance, suggestionCount);
                         if (suggestions.Count > 0)
                         {
▶                            switch (verbosity)
                             {
                                 case Verbosity.Closest:
                                     {

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 4 hits

📄 SymSpell\SymSpell.cs (line 578)

                         SuggestItem si = new SuggestItem(suggestion, distance, suggestionCount);
                         if (suggestions.Count > 0)
                         {
▶                            switch (verbosity)
                             {
                                 case Verbosity.Closest:
                                     {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 SymSpell\SymSpell.cs (line 578)

                         SuggestItem si = new SuggestItem(suggestion, distance, suggestionCount);
                         if (suggestions.Count > 0)
                         {
▶                            switch (verbosity)
                             {
                                 case Verbosity.Closest:
                                     {

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

dotnet-script

36 total diagnostics across 5 rules

SS008 GetHashCode() refers to mutable or static member 10 hits

📄 src\Dotnet.Script.DependencyModel.Nuget\NuGetMetadataReferenceResolver.cs (line 32)

 
         public override int GetHashCode()
         {
▶            return _metadataReferenceResolver.GetHashCode();
         }
 
         public override bool ResolveMissingAssemblies => _metadataReferenceResolver.ResolveMissingAssemblies;

💬 GetHashCode() refers to mutable field _metadataReferenceResolver (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Dotnet.Script.DependencyModel.Nuget\NuGetSourceReferenceResolver.cs (line 34)

 
         public override int GetHashCode()
         {
▶            return _sourceReferenceResolver.GetHashCode();
         }
 
         public override string NormalizePath(string path, string baseFilePath)

💬 GetHashCode() refers to mutable field _sourceReferenceResolver (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS033 Async overload is available 8 hits

📄 src\Dotnet.Script.Core\Interactive\InteractiveRunner.cs (line 46)

         {
             while (!_shouldExit)
             {
▶                Console.Out.Write("> ");
                 var input = ReadInput();
 
                 if (InteractiveCommandParser.TryProvideCommand(input, out var command))

💬 Async overload available for TextWriter.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Dotnet.Script.Core\Interactive\InteractiveRunner.cs (line 46)

         {
             while (!_shouldExit)
             {
▶                Console.Out.Write("> ");
                 var input = ReadInput();
 
                 if (InteractiveCommandParser.TryProvideCommand(input, out var command))

💬 Async overload available for TextWriter.Write (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 4 hits

📄 src\Dotnet.Script.Extras\RemoteFileResolver.cs (line 51)

             if (uri == null) return _fileBasedResolver.ResolveReference(path, baseFilePath);
 
             var client = new HttpClient();
▶            var response = client.GetAsync(path).Result;
 
             if (response.IsSuccessStatusCode)
                 _remoteFiles[path] = response.Content.ReadAsByteArrayAsync().Result;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Dotnet.Script.Extras\RemoteFileResolver.cs (line 54)

             var response = client.GetAsync(path).Result;
 
             if (response.IsSuccessStatusCode)
▶                _remoteFiles[path] = response.Content.ReadAsByteArrayAsync().Result;
 
             return path;
         }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS049 Comparing strings without StringComparison 2 hits

📄 src\Dotnet.Script.DependencyModel\ScriptPackage\ScriptFilesDependencyResolver.cs (line 78)

 
             if (rootfiles.Length > 1)
             {
▶                return rootfiles.SingleOrDefault(rf => rf.ToLower() == "main.csx");
             }
 
             return null;

📄 src\Dotnet.Script.DependencyModel\ScriptPackage\ScriptFilesDependencyResolver.cs (line 78)

 
             if (rootfiles.Length > 1)
             {
▶                return rootfiles.SingleOrDefault(rf => rf.ToLower() == "main.csx");
             }
 
             return null;

SS059 IAsyncDisposable not disposed asynchronously 12 hits

📄 src\Dotnet.Script.Core\ScriptDownloader.cs (line 33)

                     return await content.ReadAsStringAsync();
                 case "application/gzip":
                 case "application/x-gzip":
▶                    using (var stream = await content.ReadAsStreamAsync())
                     using (var gzip = new GZipStream(stream, CompressionMode.Decompress))
                     using (var reader = new StreamReader(gzip))
                         return await reader.ReadToEndAsync();

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\Dotnet.Script.Core\ScriptDownloader.cs (line 34)

                 case "application/gzip":
                 case "application/x-gzip":
                     using (var stream = await content.ReadAsStreamAsync())
▶                    using (var gzip = new GZipStream(stream, CompressionMode.Decompress))
                     using (var reader = new StreamReader(gzip))
                         return await reader.ReadToEndAsync();
                 default:

💬 GZipStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

RunCat365

36 total diagnostics across 3 rules

SS017 Struct without Equals/GetHashCode/ToString overridden 16 hits

📄 RunCat365\BalloonTipType.cs (line 19)

 
 namespace RunCat365
 {
▶    internal readonly struct BalloonTipInfo(string title, string text, ToolTipIcon icon)
     {
         internal string Title { get; } = title;
         internal string Text { get; } = text;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct BalloonTipInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 RunCat365\MemoryRepository.cs (line 20)

 
 namespace RunCat365
 {
▶    struct MemoryInfo
     {
         internal uint MemoryLoad { get; set; }
         internal long TotalMemory { get; set; }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct MemoryInfo. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS034 Accessing Task.Result without await 6 hits

📄 RunCat365\LaunchAtStartupManager.cs (line 32)

 
         public bool GetEnabled()
         {
▶            startupTask ??= Task.Run(async () => await StartupTask.GetAsync("RunCatStartup")).Result;
             if (startupTask is null) return false;
             if (startupTask.State == StartupTaskState.Enabled) return true;
             return false;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 RunCat365\LaunchAtStartupManager.cs (line 40)

 
         public bool SetEnabled(bool enabled)
         {
▶            startupTask ??= Task.Run(async () => await StartupTask.GetAsync("RunCatStartup")).Result;
             if (enabled)
             {
                 if (startupTask.State == StartupTaskState.Enabled) startupTask.Disable();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS066 Disposable field is not disposed 14 hits

📄 RunCat365\EndlessGameForm.cs (line 26)

     internal class EndlessGameForm : Form
     {
         private const int JUMP_THREDHOLD = 17;
▶        private readonly FormsTimer timer;
         private readonly Theme systemTheme;
         private GameStatus status = GameStatus.NewGame;
         private Cat cat = new Cat.Running(Cat.Running.Frame.Frame0);

💬 Disposable field timer in type EndlessGameForm is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 RunCat365\ContextMenuManager.cs (line 22)

 {
     internal class ContextMenuManager : IDisposable
     {
▶        private readonly CustomToolStripMenuItem systemInfoMenu = new();
         private readonly NotifyIcon notifyIcon = new();
         private readonly List<Icon> icons = [];
         private readonly Lock iconLock = new();

💬 Disposable field systemInfoMenu in type ContextMenuManager is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Steam-auto-crack

34 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 Steamless.API\PE64\Pe64File.cs (line 369)

         /// <returns></returns>
         public ulong GetAlignment(ulong val, ulong align)
         {
▶            return (((val + align - 1) / align) * align);
         }
 
         /// <summary>

💬 The operands in the divisive expression (val + align - 1) / align are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Steamless.API\PE32\Pe32File.cs (line 366)

         /// <returns></returns>
         public uint GetAlignment(uint val, uint align)
         {
▶            return (((val + align - 1) / align) * align);
         }
 
         /// <summary>

SS017 Struct without Equals/GetHashCode/ToString overridden 28 hits

📄 Steamless.API\PE64\NativeApi64.cs (line 37)

         /// IMAGE_DOS_HEADER Structure
         /// </summary>
         [StructLayout(LayoutKind.Sequential)]
▶        public struct ImageDosHeader64
         {
             public ushort e_magic;
             public ushort e_cblp;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ImageDosHeader64. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Steamless.API\PE32\NativeApi32.cs (line 37)

         /// IMAGE_DOS_HEADER Structure
         /// </summary>
         [StructLayout(LayoutKind.Sequential)]
▶        public struct ImageDosHeader32
         {
             public ushort e_magic;
             public ushort e_cblp;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ImageDosHeader32. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS066 Disposable field is not disposed 2 hits

📄 Steamless.API\Crypto\AesHelper.cs (line 48)

         /// <summary>
         /// Internal AES crypto provider.
         /// </summary>
▶        private Aes m_AesCryptoProvider = Aes.Create();
 
         /// <summary>
         /// Default Constructor

💬 Disposable field m_AesCryptoProvider in type AesHelper is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Steamless.API\Crypto\AesHelper.cs (line 48)

         /// <summary>
         /// Internal AES crypto provider.
         /// </summary>
▶        private Aes m_AesCryptoProvider = Aes.Create();
 
         /// <summary>
         /// Default Constructor

💬 Disposable field m_AesCryptoProvider in type AesHelper is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

NSubstitute

32 total diagnostics across 3 rules

SS004 Elementary methods of type in collection not overridden 8 hits

No source samples extracted

SS015 String placeholders in wrong order 4 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 20 hits

No source samples extracted

app

32 total diagnostics across 4 rules

SS003 Integer divided by integer causing implicit rounding 12 hits

📄 Stratum.Core\src\Generator\Totp.cs (line 25)

 
         public static byte[] GetCounterBytes(long counter, int period)
         {
▶            var window = counter / period;
             var bytes = new byte[sizeof(long)];
             BinaryPrimitives.WriteInt64BigEndian(bytes, window);    
             return bytes;

💬 The operands in the divisive expression counter / period are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 Stratum.Core\src\Generator\MobileOtp.cs (line 26)

 
         public string Compute(long counter)
         {
▶            var timestamp = counter / 10;
 
             var builder = new StringBuilder();
             builder.Append(timestamp);

💬 The operands in the divisive expression counter / 10 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS019 Switch is missing default label 10 hits

📄 Stratum.Core\src\Entity\Authenticator.cs (line 87)

                 _ => throw new ArgumentException("Unknown authenticator type")
             };
 
▶            switch (Type.GetGenerationMethod())
             {
                 case GenerationMethod.Time:
                     _code = _generator.Compute(counter);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Stratum.Core\src\JvmStringDecoder.cs (line 43)

 
                 var width = GetUtf8CharacterWidth(b);
 
▶                switch (width)
                 {
                     // 1 byte and 2 byte characters are the same as UTF-8
                     case 1:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 Stratum.Core\src\Converter\WinAuthBackupConverter.cs (line 29)

                 return await base.ConvertAsync(data);
             }
 
▶            using var inputMemory = new MemoryStream(data);
             using var zip = new ZipFile(inputMemory);
             zip.Password = password;
 

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Stratum.Core\src\Converter\WinAuthBackupConverter.cs (line 40)

                 throw new ArgumentException("No file found in zip");
             }
 
▶            using var outputMemory = new MemoryStream();
 
             try
             {

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 4 hits

📄 Stratum.Core\src\Generator\YandexOtp.cs (line 19)

         public const int SecretByteCount = 16;
         private const int Period = 30;
 
▶        private readonly HMAC _hmac;
         private bool _isDisposed;
 
         public YandexOtp(string secret, string pin)

💬 Disposable field _hmac in type YandexOtp is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Stratum.Core\src\Generator\HmacOtp.cs (line 13)

 {
     public abstract class HmacOtp : IDisposable
     {
▶        private readonly HMAC _hmac;
         private readonly int _digits;
         private bool _isDisposed;
 

💬 Disposable field _hmac in type HmacOtp is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Scrutor

32 total diagnostics across 2 rules

SS004 Elementary methods of type in collection not overridden 8 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

No source samples extracted

ApiEndpoints

30 total diagnostics across 6 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 sample\Sample.WeatherForecast\Endpoints\Get.cs (line 33)

   {
     return Enumerable.Range(1, 5).Select(index => new WeatherForecast
                      {
▶                       Date = DateTime.Now.AddDays(index),
                        TemperatureC = Random.Shared.Next(-20, 55),
                        Summary = Summaries[Random.Shared.Next(Summaries.Length)]
                      })

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 sample\Sample.WeatherForecast\Endpoints\Get.cs (line 33)

   {
     return Enumerable.Range(1, 5).Select(index => new WeatherForecast
                      {
▶                       Date = DateTime.Now.AddDays(index),
                        TemperatureC = Random.Shared.Next(-20, 55),
                        Summary = Summaries[Random.Shared.Next(Summaries.Length)]
                      })

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\DiagnosticVerifier.Helper.cs (line 53)

     var projects = new HashSet<Project>();
     foreach (var document in documents)
     {
▶      projects.Add(document.Project);
     }
 
     var diagnostics = new List<Diagnostic>();

💬 Type Project is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\DiagnosticVerifier.Helper.cs (line 53)

     var projects = new HashSet<Project>();
     foreach (var document in documents)
     {
▶      projects.Add(document.Project);
     }
 
     var diagnostics = new List<Diagnostic>();

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\DiagnosticResult.cs (line 10)

 /// <summary>
 /// Location where the diagnostic appears, as determined by path, line number, and column number.
 /// </summary>
▶public struct DiagnosticResultLocation
 {
   public DiagnosticResultLocation(string path, int line, int column)
   {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DiagnosticResultLocation. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\DiagnosticResult.cs (line 37)

 /// <summary>
 /// Struct that stores information about a Diagnostic appearing in a source
 /// </summary>
▶public struct DiagnosticResult
 {
   private DiagnosticResultLocation[] locations;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DiagnosticResult. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS033 Async overload is available 2 hits

📄 sample\Sample.WeatherForecast\Program.cs (line 24)

 
 app.MapControllers();
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 sample\Sample.WeatherForecast\Program.cs (line 24)

 
 app.MapControllers();
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 18 hits

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\CodeFixVerifier.Helper.cs (line 25)

   /// <returns>A Document with the changes from the CodeAction</returns>
   private static Document ApplyFix(Document document, CodeAction codeAction)
   {
▶    var operations = codeAction.GetOperationsAsync(CancellationToken.None).Result;
     var solution = operations.OfType<ApplyChangesOperation>().Single().ChangedSolution;
     return solution.GetDocument(document.Id);
   }

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 tests\Ardalis.ApiEndpoints.CodeAnalyzers.Test\Helpers\DiagnosticVerifier.Helper.cs (line 59)

     var diagnostics = new List<Diagnostic>();
     foreach (var project in projects)
     {
▶      var compilationWithAnalyzers = project.GetCompilationAsync().Result.WithAnalyzers(ImmutableArray.Create(analyzer));
       var diags = compilationWithAnalyzers.GetAnalyzerDiagnosticsAsync().Result;
       foreach (var diag in diags)
       {

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS044 Attribute must specify [AttributeUsage] 2 hits

📄 sample\SampleEndpointApp\FromMultiSourceAttribute.cs (line 5)

 
 namespace SampleEndpointApp;
 
▶public sealed class FromMultiSourceAttribute : Attribute, IBindingSourceMetadata
 {
   public BindingSource BindingSource { get; } = CompositeBindingSource.Create(
       new[] { BindingSource.Path, BindingSource.Query },

💬 FromMultiSourceAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 sample\SampleEndpointApp\FromMultiSourceAttribute.cs (line 5)

 
 namespace SampleEndpointApp;
 
▶public sealed class FromMultiSourceAttribute : Attribute, IBindingSourceMetadata
 {
   public BindingSource BindingSource { get; } = CompositeBindingSource.Create(
       new[] { BindingSource.Path, BindingSource.Query },

💬 FromMultiSourceAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

N_m3u8DL-RE

30 total diagnostics across 4 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\N_m3u8DL-RE.Common\Log\Logger.cs (line 70)

 
     private static string GetCurrTime()
     {
▶        return DateTime.Now.ToString("HH:mm:ss.fff");
     }
 
     private static void HandleLog(string write, string subWrite = "")

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\N_m3u8DL-RE.Common\Log\Logger.cs (line 42)

                 Directory.CreateDirectory(logDir);
             }
 
▶            var now = DateTime.Now;
             if (string.IsNullOrEmpty(LogFilePath))
             {
                 LogFilePath = Path.Combine(logDir, now.ToString("yyyy-MM-dd_HH-mm-ss-fff") + ".log");

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 src\N_m3u8DL-RE.Common\Util\BinaryContentCheckUtil.cs (line 78)

         const int packetSize = 188;
         if (buffer.Length < packetSize) return false;
         int syncCount = 0;
▶        for (int i = 0; i < Math.Min(buffer.Length / packetSize, 5); i++)
         {
             if (buffer[i * packetSize] == 0x47) syncCount++;
         }

💬 The operands in the divisive expression buffer.Length / packetSize are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\N_m3u8DL-RE.Common\Entity\WebVttSub.cs (line 168)

         if ((this.Cues.Count > 0 && sub.Cues.Count > 0 && sub.Cues.First().StartTime < this.Cues.Last().EndTime && sub.Cues.First().EndTime != this.Cues.Last().EndTime) || this.Cues.Count == 0)
         {
             // The MPEG2 transport stream clocks (PCR, PTS, DTS) all have units of 1/90000 second
▶            var seconds = (sub.MpegtsTimestamp - baseTimestamp) / 90000;
             var offset = TimeSpan.FromSeconds(seconds);
             // 当前预添加的字幕的起始时间小于实际上已经走过的时间(如offset已经是100秒，而字幕起始却是2秒)，才修复
             if (sub.Cues.Count > 0 && sub.Cues.First().StartTime < offset)

💬 The operands in the divisive expression (sub.MpegtsTimestamp - baseTimestamp) / 90000 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 20 hits

📄 src\N_m3u8DL-RE.Common\Entity\SubCue.cs (line 21)

 
     public override int GetHashCode()
     {
▶        return HashCode.Combine(StartTime, EndTime, Payload, Settings);
     }
 }

💬 GetHashCode() refers to mutable property StartTime (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\N_m3u8DL-RE.Common\Entity\SubCue.cs (line 21)

 
     public override int GetHashCode()
     {
▶        return HashCode.Combine(StartTime, EndTime, Payload, Settings);
     }
 }

💬 GetHashCode() refers to mutable property EndTime (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS059 IAsyncDisposable not disposed asynchronously 2 hits

📄 src\N_m3u8DL-RE.Common\Util\HTTPUtil.cs (line 145)

         }
 
         // 否则是文本，完整读取
▶        using var ms = new MemoryStream();
         ms.Write(buffer, 0, bytesRead);
         await responseStream.CopyToAsync(ms);
 

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\N_m3u8DL-RE.Common\Util\HTTPUtil.cs (line 145)

         }
 
         // 否则是文本，完整读取
▶        using var ms = new MemoryStream();
         ms.Write(buffer, 0, bytesRead);
         await responseStream.CopyToAsync(ms);
 

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

coravel

28 total diagnostics across 6 rules

SS001 Async method with void return type 2 hits

📄 Src\Coravel\Scheduling\HostedService\SchedulerHost.cs (line 50)

             this._timer = new Timer(this.RunSchedulerPerSecondAsync, null, TimeSpan.Zero, TimeSpan.FromSeconds(1));
         }
 
▶        private async void RunSchedulerPerSecondAsync(object state)
         {
             if (this._schedulerEnabled)
             {

💬 Method RunSchedulerPerSecondAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Src\Coravel\Scheduling\HostedService\SchedulerHost.cs (line 50)

             this._timer = new Timer(this.RunSchedulerPerSecondAsync, null, TimeSpan.Zero, TimeSpan.FromSeconds(1));
         }
 
▶        private async void RunSchedulerPerSecondAsync(object state)
         {
             if (this._schedulerEnabled)
             {

💬 Method RunSchedulerPerSecondAsync is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 Src\Coravel.Cli\Commands\InstallCoravelCommand.cs (line 6)

 
 namespace Coravel.Cli.Commands
 {
▶    public struct InstallCoravelCommand
     {
         public void Execute()
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct InstallCoravelCommand. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 Src\Coravel\Events\Dispatcher.cs (line 83)

     /// <summary>
     /// Represents an event subscription.
     /// </summary>
▶    public struct EventSubscription<TEvent> : IEventSubscription<TEvent> where TEvent : IEvent
     {
         private List<Type> _listeners;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EventSubscription. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS033 Async overload is available 4 hits

📄 Src\UnitTests\CoravelUnitTests\Queuing\CancellableInvocableForQueueTests.cs (line 28)

             var (_, token2) = queue.QueueCancellableInvocable<TestCancellableInvocable>();
             var (_, token3) = queue.QueueCancellableInvocable<TestCancellableInvocable>();
 
▶            token1.Cancel();
             token3.Cancel();
 
             TestCancellableInvocable.TokensCancelled = 0;

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Src\UnitTests\CoravelUnitTests\Queuing\CancellableInvocableForQueueTests.cs (line 29)

             var (_, token3) = queue.QueueCancellableInvocable<TestCancellableInvocable>();
 
             token1.Cancel();
▶            token3.Cancel();
 
             TestCancellableInvocable.TokensCancelled = 0;
             await queue.ConsumeQueueAsync();

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS051 Locking on mutable reference 4 hits

📄 Src\Coravel\Scheduling\Schedule\Scheduler.cs (line 112)

             bool isFirstTick = false;
             if(this._isFirstTick)
             {
▶                lock(this._isFirstTickLockObj)
                 {
                     // Set to `this._isFirstTick` not `true` because there might be multiple threads coming into
                     // this critical section - but only one should count as "the first run".

💬 A lock was obtained on _isFirstTickLockObj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

📄 Src\Coravel\Scheduling\HostedService\SchedulerHost.cs (line 59)

                 // miss a tick - which we want to make sure the scheduler doesn't miss and catches up.
                 var now = DateTime.UtcNow;
                 DateTime[] ticks = null;
▶                lock (_tickLockObj)
                 {
                     // This class isn't thread-safe.
                     ticks = this._ensureContinuousSecondTicks.GetTicksBetweenPreviousAndNext(now).ToArray();

💬 A lock was obtained on _tickLockObj but the field is mutable. This can lead to deadlocks when a new value is assigned. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS051-LockingOnMutableReference.md)

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 Src\Coravel\Scheduling\Schedule\Scheduler.cs (line 163)

 
         private async Task InvokeEventWithLoggerScope(ScheduledEvent scheduledEvent)
         {         
▶            using var scope = this._scopeFactory.CreateAsyncScope();
             ILogger<IScheduler> logger = null;
 
             if(this._shouldLogProgress)

💬 AsyncServiceScope can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Src\Coravel.Mailer\Mail\Renderers\RazorRenderer.cs (line 49)

             var actionContext = GetActionContext();
             var view = FindView(actionContext, viewName);
 
▶            using (var output = new StringWriter())
             {
                 var viewContext = new ViewContext(
                     actionContext,

💬 StringWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SS066 Disposable field is not disposed 8 hits

📄 Src\Coravel\Scheduling\HostedService\SchedulerHost.cs (line 19)

         private readonly ILogger<SchedulerHost> _logger;
         private readonly IHostApplicationLifetime _lifetime;
         private readonly IConfiguration _config;
▶        private Timer _timer;
         private bool _schedulerEnabled = true;
         private object _tickLockObj = new object();
         private EnsureContinuousSecondTicks _ensureContinuousSecondTicks;

💬 Disposable field _timer in type SchedulerHost is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 Src\Coravel\Queuing\HostedService\QueuingHost.cs (line 13)

 {
     internal class QueuingHost : IHostedService, IDisposable
     {
▶        private CancellationTokenSource _shutdown = new CancellationTokenSource();
         private SemaphoreSlim _signal = new SemaphoreSlim(0);
         private Timer _timer;
         private Queue _queue;

💬 Disposable field _shutdown in type QueuingHost is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

Entitas

28 total diagnostics across 3 rules

SS008 GetHashCode() refers to mutable or static member 14 hits

📄 src\Entitas\Matcher\MatcherEquals.cs (line 46)

 
         public override int GetHashCode()
         {
▶            if (!_isHashCached)
             {
                 var hash = GetType().GetHashCode();
                 hash = ApplyHash(hash, _allOfIndexes, 3, 53);

💬 GetHashCode() refers to mutable field _isHashCached (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Entitas\Matcher\MatcherEquals.cs (line 49)

             if (!_isHashCached)
             {
                 var hash = GetType().GetHashCode();
▶                hash = ApplyHash(hash, _allOfIndexes, 3, 53);
                 hash = ApplyHash(hash, _anyOfIndexes, 307, 367);
                 hash = ApplyHash(hash, _noneOfIndexes, 647, 683);
                 _hash = hash;

💬 GetHashCode() refers to mutable field _allOfIndexes (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 12 hits

📄 src\Entitas\Collector\TriggerOnEvent.cs (line 3)

 namespace Entitas
 {
▶    public struct TriggerOnEvent<TEntity> where TEntity : Entity
     {
         public readonly IMatcher<TEntity> Matcher;
         public readonly GroupEvent GroupEvent;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct TriggerOnEvent. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 gen\Entitas.Generators\Component\EventDeclaration.cs (line 5)

 
 namespace Entitas.Generators
 {
▶    public struct EventDeclaration
     {
         public readonly int EventTarget;
         public readonly int EventType;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EventDeclaration. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 2 hits

📄 src\Entitas\Collector\Collector.cs (line 64)

             {
                 var group = _groups[i];
                 var groupEvent = _groupEvents[i];
▶                switch (groupEvent)
                 {
                     case GroupEvent.Added:
                         group.OnEntityAdded -= _onEntityDelegate;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Entitas\Collector\Collector.cs (line 64)

             {
                 var group = _groups[i];
                 var groupEvent = _groupEvents[i];
▶                switch (groupEvent)
                 {
                     case GroupEvent.Added:
                         group.OnEntityAdded -= _onEntityDelegate;

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

ScreenToGif

26 total diagnostics across 3 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 12 hits

📄 Other\Translator\Util\LogWriter.cs (line 34)

 
             #region Creates the file
 
▶            var date = Path.Combine(folder, DateTime.Now.ToString("yy_MM_dd") + ".txt");
             var dateTime = Path.Combine(folder, DateTime.Now.ToString("yy_MM_dd hh_mm_ss_fff") + ".txt");
 
             FileStream fs = null;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 Other\Translator\Util\LogWriter.cs (line 35)

             #region Creates the file
 
             var date = Path.Combine(folder, DateTime.Now.ToString("yy_MM_dd") + ".txt");
▶            var dateTime = Path.Combine(folder, DateTime.Now.ToString("yy_MM_dd hh_mm_ss_fff") + ".txt");
 
             FileStream fs = null;
             var inUse = false;

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

📄 ScreenToGif.Model\Enums\Native\DisplayDevices.cs (line 6)

 namespace ScreenToGif.Domain.Enums.Native;
 
 [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Auto)]
▶public struct DisplayDevices
 {
     public DisplayDevices(bool? filler) : this()
     {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct DisplayDevices. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 ScreenToGif.Model\Models\Native\NativeRect.cs (line 7)

 namespace ScreenToGif.Domain.Models.Native;
 
 [StructLayout(LayoutKind.Sequential)]
▶public struct NativeRect
 {
     public int Left;        // x position of upper-left corner
     public int Top;         // y position of upper-left corner

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NativeRect. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS059 IAsyncDisposable not disposed asynchronously 8 hits

📄 Other\Translator\TranslatorWindow.xaml.cs (line 706)

 
         var response = (HttpWebResponse)await request.GetResponseAsync();
 
▶        using (var resultStream = response.GetResponseStream())
         {
             if (resultStream == null)
                 throw new WebException("Empty response from server when getting language codes");

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 Other\Translator\TranslatorWindow.xaml.cs (line 733)

 
         var response = (HttpWebResponse)await request.GetResponseAsync();
 
▶        using (var resultStream = response.GetResponseStream())
         {
             if (resultStream == null)
                 throw new WebException("Empty response from server when getting language codes path");

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

AspNetCoreDiagnosticScenarios

26 total diagnostics across 4 rules

SS001 Async method with void return type 2 hits

📄 Scenarios\Controllers\AsyncVoidController.cs (line 13)

     public class AsyncVoidController : Controller
     {
         [HttpGet("/async-void-1")]
▶        public async void Get()
         {
             await Task.Delay(1000);
 

💬 Method Get is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 Scenarios\Controllers\AsyncVoidController.cs (line 13)

     public class AsyncVoidController : Controller
     {
         [HttpGet("/async-void-1")]
▶        public async void Get()
         {
             await Task.Delay(1000);
 

💬 Method Get is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS033 Async overload is available 8 hits

📄 Scenarios\Controllers\FireAndForgetController.cs (line 26)

                 // This closure is capturing the context from the Controller action parameter. This is bad because this work item could run
                 // outside of the request scope and the PokemonDbContext is scoped to the request. As a result, this will crash the process with
                 // and ObjectDisposedException
▶                context.Pokemon.Add(new Pokemon());
                 await context.SaveChangesAsync();
             });
 

💬 Async overload available for DbSet.Add (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 Scenarios\Controllers\FireAndForgetController.cs (line 46)

 
                 // This closure is capturing the context from the Controller action parameter. This is bad because this work item could run
                 // outside of the request scope and the PokemonDbContext is scoped to the request. As a result, this will throw an unhandled ObjectDisposedException.
▶                context.Pokemon.Add(new Pokemon());
                 await context.SaveChangesAsync();
             });
 

💬 Async overload available for DbSet.Add (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 12 hits

📄 Scenarios\Services\LegacyService.cs (line 15)

     {
         public string DoOperationBlocking()
         {
▶            return Task.Run(() => DoAsyncOperation()).Result;
         }
 
         public string DoOperationBlocking2()

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 Scenarios\Services\LegacyService.cs (line 25)

 
         public string DoOperationBlocking3()
         {
▶            return Task.Run(() => DoAsyncOperation().Result).Result;
         }
 
         public string DoOperationBlocking4()

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS037 HttpClient instantiated directly 4 hits

📄 Scenarios\Controllers\HttpClientController.cs (line 15)

         [Route("/httpclient-1")]
         public async Task<string> OutgoingWorse()
         {
▶            var client = new HttpClient();
             return await client.GetStringAsync(_url);
         }
 

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 Scenarios\Controllers\HttpClientController.cs (line 22)

         [Route("/httpclient-2")]
         public async Task<string> OutgoingBad()
         {
▶            using (var client = new HttpClient())
             {
                 return await client.GetStringAsync(_url);
             }

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

maui-samples

24 total diagnostics across 2 rules

SS001 Async method with void return type 12 hits

📄 10.0\Animations\Animations\Pages\Controls\EasingCard.cs (line 42)

         });
     }
 
▶    private async void OnDblTap(object obj)
     {
         _cancelTapToken.Cancel();
         Debug.WriteLine("You DOUBLE tapped");

💬 Method OnDblTap is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

📄 10.0\Animations\Animations\Pages\Controls\EasingCard.cs (line 53)

         //await Shell.Current.GoToAsync($"{nameof(EasingEditorPage)}", navigationParameter);
     }
 
▶    private async void OnTap(object obj)
     {
         await DebouncedTap().ConfigureAwait(false);
     }

💬 Method OnTap is marked as async but has a void return type (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS001-AsyncMethodWithVoidReturnType.md)

SS033 Async overload is available 12 hits

📄 10.0\Animations\Animations\Pages\Controls\EasingCard.cs (line 44)

 
     private async void OnDblTap(object obj)
     {
▶        _cancelTapToken.Cancel();
         Debug.WriteLine("You DOUBLE tapped");
         var navigationParameter = new Dictionary<string, object>
             {

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 10.0\Animations\Animations\Pages\Controls\EasingCard.cs (line 64)

     {
         try
         {
▶            Interlocked.Exchange(ref _cancelTapToken, new CancellationTokenSource()).Cancel();
 
             //NOTE THE 500 HERE - WHICH IS THE TIME TO WAIT
             await Task.Delay(TimeSpan.FromMilliseconds(300), _cancelTapToken.Token)

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SimplCommerce

24 total diagnostics across 3 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 18 hits

📄 test\SimplCommerce.Module.Pricing.Tests\Controllers\CartRuleApiControllerTests.cs (line 56)

                 Id = 1,
                 Name = "Test Cart Rule",
                 IsActive = true,
▶                StartOn = DateTime.Now,
                 EndOn = DateTime.Now.AddDays(7),
                 IsCouponRequired = true,
                 RuleToApply = "Coupon",

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 test\SimplCommerce.Module.Pricing.Tests\Controllers\CartRuleApiControllerTests.cs (line 57)

                 Name = "Test Cart Rule",
                 IsActive = true,
                 StartOn = DateTime.Now,
▶                EndOn = DateTime.Now.AddDays(7),
                 IsCouponRequired = true,
                 RuleToApply = "Coupon",
                 DiscountAmount = 10,

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS033 Async overload is available 2 hits

📄 src\SimplCommerce.WebHost\Program.cs (line 28)

 ConfigureService();
 var app = builder.Build();
 Configure();
▶app.Run();
 
 void ConfigureService() 
 {

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\SimplCommerce.WebHost\Program.cs (line 28)

 ConfigureService();
 var app = builder.Build();
 Configure();
▶app.Run();
 
 void ConfigureService() 
 {

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS059 IAsyncDisposable not disposed asynchronously 4 hits

📄 src\SimplCommerce.Infrastructure\Extensions\HttpClientExtensions.cs (line 14)

 
         public static async Task<T> ReadAsJsonAsync<T>(this HttpContent httpContent)
         {
▶            using (var stream = await httpContent.ReadAsStreamAsync())
             {
                 var jsonReader = new JsonTextReader(new StreamReader(stream));
 

💬 Stream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 src\SimplCommerce.Infrastructure\Web\RazorViewToStringRenderer.cs (line 42)

                 Model = model
             };
 
▶            using (var output = new StringWriter())
             {
                 var viewContext = new ViewContext(
                     actionContext,

💬 StringWriter can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SteamAchievementManager

24 total diagnostics across 1 rules

SS017 Struct without Equals/GetHashCode/ToString overridden 24 hits

📄 SAM.API\Interfaces\ISteamApps001.cs (line 29)

 namespace SAM.API.Interfaces
 {
     [StructLayout(LayoutKind.Sequential, Pack = 1)]
▶    public struct ISteamApps001
     {
         public IntPtr GetAppData;
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct ISteamApps001. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 SAM.API\NativeClass.cs (line 29)

 namespace SAM.API
 {
     [StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Ansi)]
▶    internal struct NativeClass
     {
         public IntPtr VirtualTable;
     }

💬 Implement Equals(), GetHashCode() and ToString() methods on struct NativeClass. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

querybuilder

22 total diagnostics across 5 rules

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 QueryBuilder\Compilers\SqlServerCompiler.cs (line 181)

             var colNames = string.Join(", ", adHoc.Columns.Select(Wrap));
 
             var valueRow = string.Join(", ", Enumerable.Repeat(parameterPlaceholder, adHoc.Columns.Count));
▶            var valueRows = string.Join(", ", Enumerable.Repeat($"({valueRow})", adHoc.Values.Count / adHoc.Columns.Count));
             var sql = $"SELECT {colNames} FROM (VALUES {valueRows}) AS tbl ({colNames})";
 
             ctx.RawSql = sql;

💬 The operands in the divisive expression adHoc.Values.Count / adHoc.Columns.Count are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 QueryBuilder\Compilers\Compiler.cs (line 243)

                 row += $" FROM {fromTable}";
             }
 
▶            var rows = string.Join(" UNION ALL ", Enumerable.Repeat(row, adHoc.Values.Count / adHoc.Columns.Count));
 
             ctx.RawSql = rows;
             ctx.Bindings = adHoc.Values;

SS019 Switch is missing default label 4 hits

📄 QueryBuilder\Compilers\PostgresCompiler.cs (line 35)

             {
                 method = x.CaseSensitive ? "LIKE" : "ILIKE";
 
▶                switch (x.Operator)
                 {
                     case "starts":
                         value = $"{value}%";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 QueryBuilder\Compilers\Compiler.Conditions.cs (line 120)

 
                 method = "LIKE";
 
▶                switch (x.Operator)
                 {
                     case "starts":
                         value = $"{value}%";

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS033 Async overload is available 4 hits

📄 SqlKata.Execution\QueryFactory.cs (line 569)

 
             while (result.HasNext)
             {
▶                result = result.Next(transaction);
                 if (!func(result.List, result.Page))
                 {
                     return;

💬 Async overload available for PaginationResult.Next (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 SqlKata.Execution\QueryFactory.cs (line 605)

 
             while (result.HasNext)
             {
▶                result = result.Next(transaction);
                 action(result.List, result.Page);
             }
         }

💬 Async overload available for PaginationResult.Next (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS044 Attribute must specify [AttributeUsage] 6 hits

📄 QueryBuilder\ColumnAttribute.cs (line 8)

     /// <summary>
     /// This class is used as metadata on a property to generate different name in the output query.
     /// </summary>
▶    public class ColumnAttribute : Attribute
     {
         public string Name { get; private set; }
         public ColumnAttribute(string name)

💬 ColumnAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

📄 QueryBuilder\ColumnAttribute.cs (line 25)

     /// <summary>
     /// This class is used as metadata on a property to determine if it is a primary key
     /// </summary>
▶    public class KeyAttribute : ColumnAttribute
     {
         public KeyAttribute([System.Runtime.CompilerServices.CallerMemberName] string name = "")
         : base(name)

💬 KeyAttribute should specify how the attribute can be used (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS044-AttributeMustSpecifyAttributeUsage.md)

SS058 String concatenated in a loop 4 hits

📄 QueryBuilder\Compilers\OracleCompiler.cs (line 169)

                 string intoFormat = " INTO {0}{1} VALUES ({2})";
                 var nextInsert = string.Format(intoFormat, table, columns, values);
 
▶                ctx.RawSql += nextInsert;
             }
 
             ctx.RawSql += " SELECT 1 FROM DUAL";

📄 QueryBuilder\Compilers\Compiler.cs (line 464)

             foreach (var insert in inserts.Skip(1))
             {
                 string values = string.Join(", ", Parameterize(ctx, insert.Values));
▶                ctx.RawSql += $", ({values})";
             }
             return ctx;
         }

keepass2android

22 total diagnostics across 4 rules

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\Kp2aAutofillParser.Tests\AutofillTest.cs (line 124)

         if (expectedHints == null)
           expectedHints = new string[0];
         string[] actualHints;
▶        parser.FieldsMappedToHints.TryGetValue(field, out actualHints);
         if (actualHints == null)
           actualHints = new string[0];
         if (actualHints.Any() || expectedHints.Any())

💬 Type TestInputField is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\Kp2aAutofillParser.Tests\AutofillTest.cs (line 124)

         if (expectedHints == null)
           expectedHints = new string[0];
         string[] actualHints;
▶        parser.FieldsMappedToHints.TryGetValue(field, out actualHints);
         if (actualHints == null)
           actualHints = new string[0];
         if (actualHints.Any() || expectedHints.Any())

SS008 GetHashCode() refers to mutable or static member 12 hits

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 722)

     {
       unchecked
       {
▶        var result = TextValue != null ? TextValue.GetHashCode() : 0;
         result = 31 * result + (DateValue != null ? DateValue.GetHashCode() : 0);
         result = 31 * result + (ToggleValue != null ? ToggleValue.GetHashCode() : 0);
         return result;

💬 GetHashCode() refers to mutable property TextValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 722)

     {
       unchecked
       {
▶        var result = TextValue != null ? TextValue.GetHashCode() : 0;
         result = 31 * result + (DateValue != null ? DateValue.GetHashCode() : 0);
         result = 31 * result + (ToggleValue != null ? ToggleValue.GetHashCode() : 0);
         return result;

💬 GetHashCode() refers to mutable property TextValue (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS019 Switch is missing default label 6 hits

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 116)

 
     public static bool isW3cTypePrefix(string hint)
     {
▶      switch (hint.ToLower())
       {
         case W3cHints.PREFIX_WORK:
         case W3cHints.PREFIX_FAX:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 105)

 
     public static bool isW3cAddressType(string hint)
     {
▶      switch (hint.ToLower())
       {
         case W3cHints.SHIPPING:
         case W3cHints.BILLING:

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS041 Unnecessary enumerable materialization 2 hits

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 870)

           if (viewHints.Where(h => h != null).Select(AutofillHintsHelper.ToCanonicalHint).Intersect(_autofillHintsForLogin).Any())
           {
 
▶            AddFieldToHintMap(viewNode, viewHints.Where(h => h != null).Select(AutofillHintsHelper.ToCanonicalHint).ToHashSet().ToArray());
           }
 
         }

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

📄 src\Kp2aAutofillParser\AutofillParser.cs (line 870)

           if (viewHints.Where(h => h != null).Select(AutofillHintsHelper.ToCanonicalHint).Intersect(_autofillHintsForLogin).Any())
           {
 
▶            AddFieldToHintMap(viewNode, viewHints.Where(h => h != null).Select(AutofillHintsHelper.ToCanonicalHint).ToHashSet().ToArray());
           }
 
         }

💬 ToHashSet is unnecessarily materializing the IEnumerable and can be omitted (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS041-UnnecessaryEnumerableMaterialization.md)

eShop

20 total diagnostics across 5 rules

SS004 Elementary methods of type in collection not overridden 2 hits

No source samples extracted

SS008 GetHashCode() refers to mutable or static member 8 hits

No source samples extracted

SS019 Switch is missing default label 2 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 2 hits

No source samples extracted

SS066 Disposable field is not disposed 6 hits

No source samples extracted

EquinoxProject

20 total diagnostics across 5 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 2 hits

📄 src\Equinox.Domain\Commands\Validations\CustomerValidation.cs (line 38)

 
         protected static bool HaveMinimumAge(DateTime birthDate)
         {
▶            return birthDate <= DateTime.Now.AddYears(-18);
         }
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\Equinox.Domain\Commands\Validations\CustomerValidation.cs (line 38)

 
         protected static bool HaveMinimumAge(DateTime birthDate)
         {
▶            return birthDate <= DateTime.Now.AddYears(-18);
         }
     }
 }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\Equinox.Services.Api\Configurations\SwaggerConfig.cs (line 37)

                 s.AddSecurityRequirement(new OpenApiSecurityRequirement
                 {
                     {
▶                        new OpenApiSecurityScheme
                         {
                             Reference = new OpenApiReference
                             {

📄 src\Equinox.Services.Api\Configurations\SwaggerConfig.cs (line 37)

                 s.AddSecurityRequirement(new OpenApiSecurityRequirement
                 {
                     {
▶                        new OpenApiSecurityScheme
                         {
                             Reference = new OpenApiReference
                             {

SS033 Async overload is available 4 hits

📄 src\Equinox.Services.Api\Program.cs (line 31)

 app.MapIdentityApi<IdentityUser>();
 
 app.UseSwaggerSetup();
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\Equinox.UI.Web\Program.cs (line 39)

 // Applying migrations and seeding some data
 app.UseDbSeed();
 
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

SS034 Accessing Task.Result without await 6 hits

📄 src\Equinox.Infra.CrossCutting.Identity\API\JwtBuilder.cs (line 38)

         {
             if (string.IsNullOrEmpty(email)) throw new ArgumentException(nameof(email));
 
▶            _user = _userManager.FindByEmailAsync(email).Result;
             _userClaims = new List<Claim>();
             _jwtClaims = new List<Claim>();
             _identityClaims = new ClaimsIdentity();

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 src\Equinox.Infra.CrossCutting.Identity\API\JwtBuilder.cs (line 61)

 
         public JwtBuilder<TIdentityUser, TKey> WithUserClaims()
         {
▶            _userClaims = _userManager.GetClaimsAsync(_user).Result;
             _identityClaims.AddClaims(_userClaims);
 
             return this;

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS066 Disposable field is not disposed 6 hits

📄 src\Equinox.Application\Services\CustomerAppService.cs (line 20)

                                     IMediatorHandler mediator,
                                     IEventStoreRepository eventStoreRepository) : ICustomerAppService
     {
▶        private readonly ICustomerRepository _customerRepository = customerRepository;
         private readonly IEventStoreRepository _eventStoreRepository = eventStoreRepository;
         private readonly IMediatorHandler _mediator = mediator;
 

💬 Disposable field _customerRepository in type CustomerAppService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

📄 src\Equinox.Application\Services\CustomerAppService.cs (line 21)

                                     IEventStoreRepository eventStoreRepository) : ICustomerAppService
     {
         private readonly ICustomerRepository _customerRepository = customerRepository;
▶        private readonly IEventStoreRepository _eventStoreRepository = eventStoreRepository;
         private readonly IMediatorHandler _mediator = mediator;
 
         public async Task<IEnumerable<CustomerViewModel>> GetAll()

💬 Disposable field _eventStoreRepository in type CustomerAppService is not disposed (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS066-DisposableFieldIsNotDisposed.md)

repkg

20 total diagnostics across 5 rules

SS003 Integer divided by integer causing implicit rounding 10 hits

📄 RePKG.Application\Texture\Helpers\DXT.cs (line 79)

             {
                 // Use 5-Alpha Codebook
                 for (var i = 1; i < 5; i++)
▶                    codes[1 + i] = (byte)(((5 - i) * alpha0 + i * alpha1) / 5);
                 codes[6] = 0;
                 codes[7] = 255;
             }

💬 The operands in the divisive expression ((5 - i) * alpha0 + i * alpha1) / 5 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 RePKG.Application\Texture\Helpers\DXT.cs (line 88)

                 // Use 7-Alpha Codebook
                 for (var i = 1; i < 7; i++)
                 {
▶                    codes[i + 1] = (byte)(((7 - i) * alpha0 + i * alpha1) / 7);
                 }
             }
 

💬 The operands in the divisive expression ((7 - i) * alpha0 + i * alpha1) / 7 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS008 GetHashCode() refers to mutable or static member 2 hits

📄 RePKG.Application\Texture\Helpers\RG88.cs (line 164)

         public override string ToString() => $"RG({R}, {G})";
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
▶        public override int GetHashCode() => Rg.GetHashCode();
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private void Pack(ref Vector4 vector)

💬 GetHashCode() refers to mutable property Rg (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

📄 RePKG.Application\Texture\Helpers\RG88.cs (line 164)

         public override string ToString() => $"RG({R}, {G})";
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
▶        public override int GetHashCode() => Rg.GetHashCode();
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private void Pack(ref Vector4 vector)

💬 GetHashCode() refers to mutable property Rg (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS008-GetHashCodeRefersToMutableMember.md)

SS018 Switch does not handle all enum options 2 hits

📄 RePKG.Application\Texture\TexMipmapDecompressor.cs (line 23)

             if (mipmap.Format.IsImage())
                 return;
 
▶            switch (mipmap.Format)
             {
                 case MipmapFormat.CompressedDXT5:
                     mipmap.Bytes = DXT.DecompressImage(mipmap.Width, mipmap.Height, mipmap.Bytes, DXTFlags.DXT5);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

📄 RePKG.Application\Texture\TexMipmapDecompressor.cs (line 23)

             if (mipmap.Format.IsImage())
                 return;
 
▶            switch (mipmap.Format)
             {
                 case MipmapFormat.CompressedDXT5:
                     mipmap.Bytes = DXT.DecompressImage(mipmap.Width, mipmap.Height, mipmap.Bytes, DXTFlags.DXT5);

💬 Missing enum member in switched cases. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS018-SwitchDoesNotHandleAllEnumOptions.md)

SS019 Switch is missing default label 2 hits

📄 RePKG.Application\Texture\TexMipmapDecompressor.cs (line 23)

             if (mipmap.Format.IsImage())
                 return;
 
▶            switch (mipmap.Format)
             {
                 case MipmapFormat.CompressedDXT5:
                     mipmap.Bytes = DXT.DecompressImage(mipmap.Width, mipmap.Height, mipmap.Bytes, DXTFlags.DXT5);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 RePKG.Application\Texture\TexMipmapDecompressor.cs (line 23)

             if (mipmap.Format.IsImage())
                 return;
 
▶            switch (mipmap.Format)
             {
                 case MipmapFormat.CompressedDXT5:
                     mipmap.Bytes = DXT.DecompressImage(mipmap.Width, mipmap.Height, mipmap.Bytes, DXTFlags.DXT5);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS021 Test method without test attribute 4 hits

📄 RePKG.Tests\TexDecompressingTests.cs (line 89)

                 FileShare.Read), Encoding.UTF8);
         }
 
▶        public static void SaveValidatedBytes(byte[] bytes, string name)
         {
             using (var stream = File.Open($"{TestHelper.BasePath}\\{ValidatedDirectoryName}\\{name}.bytes",
                 FileMode.Create,

💬 Method SaveValidatedBytes might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

📄 RePKG.Tests\TexDecompressingTests.cs (line 101)

             }
         }
 
▶        public static void ValidateBytes(byte[] bytes, string name)
         {
             var validatedBytes = File.ReadAllBytes($"{TestHelper.BasePath}\\{ValidatedDirectoryName}\\{name}.bytes");
 

💬 Method ValidateBytes might be missing a test attribute (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS021-TestMethodWithoutTestAttribute.md)

basic-computer-games

18 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 2 hits

📄 00_Common\dotnet\Games.Common\Randomness\RandomNumberGenerator.cs (line 14)

     public RandomNumberGenerator()
     {
         // The BASIC RNG is seeded based on time with a 1 second resolution
▶        _random = new Random((int)(DateTime.UtcNow.Ticks / TimeSpan.TicksPerSecond));
     }
 
     public float NextFloat() => _previous = (float)_random.NextDouble();

💬 The operands in the divisive expression DateTime.UtcNow.Ticks / TimeSpan.TicksPerSecond are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 00_Common\dotnet\Games.Common\Randomness\RandomNumberGenerator.cs (line 14)

     public RandomNumberGenerator()
     {
         // The BASIC RNG is seeded based on time with a 1 second resolution
▶        _random = new Random((int)(DateTime.UtcNow.Ticks / TimeSpan.TicksPerSecond));
     }
 
     public float NextFloat() => _previous = (float)_random.NextDouble();

SS017 Struct without Equals/GetHashCode/ToString overridden 14 hits

📄 00_Common\dotnet\Games.Common\Numbers\Number.cs (line 6)

 /// <summary>
 /// A single-precision floating-point number with string formatting equivalent to the BASIC interpreter.
 /// </summary>
▶public struct Number
 {
     private readonly float _value;
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Number. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 00_Common\dotnet\Games.Common\IO\Tokenizer.cs (line 57)

         (ITokenizerState, Token.Builder) Consume(char character, Token.Builder tokenBuilder);
     }
 
▶    private struct LookForStartOfTokenState : ITokenizerState
     {
         public (ITokenizerState, Token.Builder) Consume(char character, Token.Builder tokenBuilder) =>
             character switch

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LookForStartOfTokenState. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS019 Switch is missing default label 2 hits

📄 00_Common\dotnet\Games.Common\IO\Token.cs (line 17)

         var match = _numberPattern.Match(String);
 
         IsNumber = float.TryParse(match.Value, out var number);
▶        Number = (IsNumber, number) switch
         {
             (false, _) => float.NaN,
             (true, float.PositiveInfinity) => float.MaxValue,

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 00_Common\dotnet\Games.Common\IO\Token.cs (line 17)

         var match = _numberPattern.Match(String);
 
         IsNumber = float.TryParse(match.Value, out var number);
▶        Number = (IsNumber, number) switch
         {
             (false, _) => float.NaN,
             (true, float.PositiveInfinity) => float.MaxValue,

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

PKHeX

16 total diagnostics across 1 rules

SS003 Integer divided by integer causing implicit rounding 16 hits

📄 PKHeX.Drawing\ImageUtil.cs (line 35)

         public Span<byte> GetBitmapData(out BitmapData bmpData, PixelFormat format = PixelFormat.Format32bppArgb)
         {
             bmpData = bmp.LockBits(new Rectangle(0, 0, bmp.Width, bmp.Height), ImageLockMode.ReadWrite, format);
▶            var bpp = Image.GetPixelFormatSize(format) / 8;
             return GetSpan(bmpData.Scan0, bmp.Width * bmp.Height * bpp);
         }
 

💬 The operands in the divisive expression Image.GetPixelFormatSize(format) / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 PKHeX.Drawing\ImageUtil.cs (line 72)

         public byte[] GetBitmapData()
         {
             var format = bmp.PixelFormat;
▶            var bpp = Image.GetPixelFormatSize(format) / 8;
             var result = new byte[bmp.Width * bmp.Height * bpp];
             bmp.GetBitmapData(result, format);
             return result;

MediatR

16 total diagnostics across 4 rules

SS034 Accessing Task.Result without await 4 hits

No source samples extracted

SS044 Attribute must specify [AttributeUsage] 2 hits

No source samples extracted

SS051 Locking on mutable reference 8 hits

No source samples extracted

SS066 Disposable field is not disposed 2 hits

No source samples extracted

carter

12 total diagnostics across 2 rules

SS033 Async overload is available 8 hits

No source samples extracted

SS059 IAsyncDisposable not disposed asynchronously 4 hits

No source samples extracted

Flurl

12 total diagnostics across 2 rules

SS017 Struct without Equals/GetHashCode/ToString overridden 6 hits

No source samples extracted

SS058 String concatenated in a loop 6 hits

No source samples extracted

mongo-csharp-driver

12 total diagnostics across 1 rules

SS017 Struct without Equals/GetHashCode/ToString overridden 12 hits

📄 tests\SmokeTests\MongoDB.Driver.SmokeTests.Sdk\LogEntry.cs (line 20)

 
 namespace MongoDB.Driver.SmokeTests.Sdk
 {
▶    internal struct LogEntry
     {
         public LogEntry(LogLevel logLevel, string category, string message)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LogEntry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 tests\SmokeTests\MongoDB.Driver.SmokeTests.Sdk\LogEntry.cs (line 20)

 
 namespace MongoDB.Driver.SmokeTests.Sdk
 {
▶    internal struct LogEntry
     {
         public LogEntry(LogLevel logLevel, string category, string message)
         {

💬 Implement Equals(), GetHashCode() and ToString() methods on struct LogEntry. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

sample-dotnet-core-cqrs-api

10 total diagnostics across 4 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 src\SampleProject.Domain\SeedWork\DomainEventBase.cs (line 9)

     {
         public DomainEventBase()
         {
▶            this.OccurredOn = DateTime.Now;
         }
 
         public DateTime OccurredOn { get; }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 src\SampleProject.Infrastructure\Domain\ForeignExchanges\ForeignExchange.cs (line 28)

 
             List<ConversionRate> rates = GetConversionRatesFromExternalApi();
 
▶            this._cacheStore.Add(new ConversionRatesCache(rates), new ConversionRatesCacheKey(), DateTime.Now.Date.AddDays(1));
 
             return rates;
         }

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\SampleProject.Application\Configuration\Emails\EmailMessage.cs (line 3)

 namespace SampleProject.Application.Configuration.Emails
 {
▶    public struct EmailMessage
     {
         public string From { get; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EmailMessage. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\SampleProject.Application\Configuration\Emails\EmailMessage.cs (line 3)

 namespace SampleProject.Application.Configuration.Emails
 {
▶    public struct EmailMessage
     {
         public string From { get; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct EmailMessage. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

SS023 Exception thrown from property getter 2 hits

📄 src\SampleProject.API\Configuration\ExecutionContextAccessor.cs (line 26)

                     return Guid.Parse(
                         _httpContextAccessor.HttpContext.Request.Headers[CorrelationMiddleware.CorrelationHeaderKey]);
                 }
▶                throw new ApplicationException("Http context and correlation id is not available");
             }
         }
 

💬 An exception is thrown from the getter of property CorrelationId (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

📄 src\SampleProject.API\Configuration\ExecutionContextAccessor.cs (line 26)

                     return Guid.Parse(
                         _httpContextAccessor.HttpContext.Request.Headers[CorrelationMiddleware.CorrelationHeaderKey]);
                 }
▶                throw new ApplicationException("Http context and correlation id is not available");
             }
         }
 

💬 An exception is thrown from the getter of property CorrelationId (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS023-ExceptionThrownFromPropertyGetter.md)

SS033 Async overload is available 2 hits

📄 src\SampleProject.Infrastructure\Processing\DomainEventsDispatcher.cs (line 74)

                     domainEventNotification.DomainEvent.OccurredOn,
                     type,
                     data);
▶                this._ordersContext.OutboxMessages.Add(outboxMessage);
             }
         }
     }

💬 Async overload available for DbSet.Add (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\SampleProject.Infrastructure\Processing\DomainEventsDispatcher.cs (line 74)

                     domainEventNotification.DomainEvent.OccurredOn,
                     type,
                     data);
▶                this._ordersContext.OutboxMessages.Add(outboxMessage);
             }
         }
     }

💬 Async overload available for DbSet.Add (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

Stateless

10 total diagnostics across 1 rules

SS034 Accessing Task.Result without await 10 hits

No source samples extracted

samples

8 total diagnostics across 2 rules

SS002 Use DateTime.UtcNow instead of DateTime.Now 4 hits

📄 core\extensions\AppWithPlugin\JsonPlugin\JsonPlugin.cs (line 32)

                 JsonLocation = jsonAssembly.Location,
                 Machine = Environment.MachineName,
                 User = Environment.UserName,
▶                Date = DateTime.Now
             };
 
             Console.WriteLine(JsonConvert.SerializeObject(info, Formatting.Indented));

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

📄 core\extensions\AppWithPlugin\OldJsonPlugin\JsonPlugin.cs (line 30)

                 JsonVersion = jsonAssembly.FullName,
                 JsonLocation = jsonAssembly.Location,
                 Machine = Environment.MachineName,
▶                Date = DateTime.Now
             };
 
             Console.WriteLine(JsonConvert.SerializeObject(info, Formatting.Indented));

💬 Use DateTime.UtcNow to get a locale-independent value (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS002-DateTimeNow.md)

SS017 Struct without Equals/GetHashCode/ToString overridden 4 hits

📄 core\extensions\AppWithPlugin\JsonPlugin\JsonPlugin.cs (line 14)

 
         public string Description => "Outputs JSON value.";
 
▶        private struct Info
         {
             public string JsonVersion;
             public string JsonLocation;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Info. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 core\extensions\AppWithPlugin\OldJsonPlugin\JsonPlugin.cs (line 14)

 
         public string Description => "Outputs JSON value.";
 
▶        private struct Info
         {
             public string JsonVersion;
             public string JsonLocation;

💬 Implement Equals(), GetHashCode() and ToString() methods on struct Info. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

Discord.Net

8 total diagnostics across 2 rules

SS034 Accessing Task.Result without await 2 hits

📄 samples\InteractionFramework\InteractionHandler.cs (line 82)

             // If Slash Command execution fails it is most likely that the original interaction acknowledgement will persist. It is a good idea to delete the original
             // response, or at least let the user know that something went wrong during the command execution.
             if (interaction.Type is InteractionType.ApplicationCommand)
▶                await interaction.GetOriginalResponseAsync().ContinueWith(async (msg) => await msg.Result.DeleteAsync());
         }
     }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

📄 samples\InteractionFramework\InteractionHandler.cs (line 82)

             // If Slash Command execution fails it is most likely that the original interaction acknowledgement will persist. It is a good idea to delete the original
             // response, or at least let the user know that something went wrong during the command execution.
             if (interaction.Type is InteractionType.ApplicationCommand)
▶                await interaction.GetOriginalResponseAsync().ContinueWith(async (msg) => await msg.Result.DeleteAsync());
         }
     }
 

💬 Use await to get the result of a Task. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS034-AccessingTaskResultWithoutAwait.md)

SS059 IAsyncDisposable not disposed asynchronously 6 hits

📄 experiment\Discord.Net.BuildOverrides\BuildOverrides.cs (line 268)

                 if (!result.IsSuccessStatusCode)
                     throw new HttpRequestException("Failed to get dependency");
 
▶                using (var ms = new MemoryStream())
                 {
                     var innerStream = await result.Content.ReadAsStreamAsync();
                     await innerStream.CopyToAsync(ms);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

📄 experiment\Discord.Net.BuildOverrides\BuildOverrides.cs (line 268)

                 if (!result.IsSuccessStatusCode)
                     throw new HttpRequestException("Failed to get dependency");
 
▶                using (var ms = new MemoryStream())
                 {
                     var innerStream = await result.Content.ReadAsStreamAsync();
                     await innerStream.CopyToAsync(ms);

💬 MemoryStream can be disposed of asynchronously (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS059-DisposeAsyncDisposable.md)

SteamKit

8 total diagnostics across 1 rules

SS004 Elementary methods of type in collection not overridden 8 hits

📄 Resources\ProtobufDumper\ProtobufDumper\ProtobufDumper.cs (line 228)

                 foreach ( var dep in node.Proto.dependency )
                 {
                     var depend = protobufMap[ dep ];
▶                    set.Add( depend.Proto );
                     RecursiveAddPublicDependencies( set, depend, depth + 1 );
                 }
             }

💬 Type FileDescriptorProto is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 Resources\ProtobufDumper\ProtobufDumper\ProtobufDumper.cs (line 237)

                 foreach ( var idx in node.Proto.public_dependency )
                 {
                     var depend = protobufMap[ node.Proto.dependency[ idx ] ];
▶                    set.Add( depend.Proto );
                     RecursiveAddPublicDependencies( set, depend, depth + 1 );
                 }
             }

AspNetCoreRateLimit

8 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 4 hits

📄 src\AspNetCoreRateLimit\Net\IPAddressRange.cs (line 121)

         internal static byte[] GetBitMask(int sizeOfBuff, int bitLen)
         {
             var maskBytes = new byte[sizeOfBuff];
▶            var bytesLen = bitLen / 8;
             var bitsLen = bitLen % 8;
             for (var i = 0; i < bytesLen; i++)
             {

💬 The operands in the divisive expression bitLen / 8 are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

📄 src\AspNetCoreRateLimit.Redis\RedisProcessingStrategy.cs (line 35)

         public async Task<RateLimitCounter> IncrementAsync(string counterId, TimeSpan interval, Func<double> RateIncrementer = null)
         {
             var now = DateTime.UtcNow;
▶            var numberOfIntervals = now.Ticks / interval.Ticks;
             var intervalStart = new DateTime(numberOfIntervals * interval.Ticks, DateTimeKind.Utc);
 
             _logger.LogDebug("Calling Lua script. {counterId}, {timeout}, {delta}", counterId, interval.TotalSeconds, 1D);

💬 The operands in the divisive expression now.Ticks / interval.Ticks are both integers and result in an implicit rounding. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS003-DivideIntegerByInteger.md)

SS004 Elementary methods of type in collection not overridden 2 hits

📄 src\AspNetCoreRateLimit\Middleware\RateLimitMiddleware.cs (line 110)

                     }
                 }
 
▶                rulesDict.Add(rule, rateLimitCounter);
             }
 
             // set X-Rate-Limit headers for the longest period

💬 Type RateLimitRule is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)

📄 src\AspNetCoreRateLimit\Middleware\RateLimitMiddleware.cs (line 110)

                     }
                 }
 
▶                rulesDict.Add(rule, rateLimitCounter);
             }
 
             // set X-Rate-Limit headers for the longest period

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

📄 src\AspNetCoreRateLimit\Models\RateLimitCounter.cs (line 8)

     /// <summary>
     /// Stores the initial access time and the numbers of calls made from that point
     /// </summary>
▶    public struct RateLimitCounter
     {
         public DateTime Timestamp { get; set; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RateLimitCounter. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

📄 src\AspNetCoreRateLimit\Models\RateLimitCounter.cs (line 8)

     /// <summary>
     /// Stores the initial access time and the numbers of calls made from that point
     /// </summary>
▶    public struct RateLimitCounter
     {
         public DateTime Timestamp { get; set; }
 

💬 Implement Equals(), GetHashCode() and ToString() methods on struct RateLimitCounter. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS017-StructWithoutElementaryMethodsOverridden.md)

jellyfin-plugin-metatube

8 total diagnostics across 2 rules

SS019 Switch is missing default label 6 hits

📄 Jellyfin.Plugin.MetaTube\Providers\ExternalUrlProvider.cs (line 18)

     {
         if (item.TryGetProviderId(Plugin.ProviderId, out var pid))
         {
▶            switch (item)
             {
                 case Movie:
                     yield return string.Format(new MovieExternalId().UrlFormatString, pid);

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 Jellyfin.Plugin.MetaTube\Helpers\ProviderId.cs (line 39)

 
     private static bool? ToBool(string s)
     {
▶        switch (s)
         {
             case "1":
             case "t":

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

SS037 HttpClient instantiated directly 2 hits

📄 Jellyfin.Plugin.MetaTube\ApiClient.cs (line 254)

 
     static ApiClient()
     {
▶        HttpClient = new HttpClient(new SocketsHttpHandler
         {
             // Connect Timeout.
             ConnectTimeout = TimeSpan.FromSeconds(30),

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

📄 Jellyfin.Plugin.MetaTube\ApiClient.cs (line 254)

 
     static ApiClient()
     {
▶        HttpClient = new HttpClient(new SocketsHttpHandler
         {
             // Connect Timeout.
             ConnectTimeout = TimeSpan.FromSeconds(30),

💬 HttpClient was instantiated directly. Use IHttpClientFactory instead (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS037-HttpClientInstantiatedDirectly.md)

GoogleTranslateIpCheck

6 total diagnostics across 1 rules

SS033 Async overload is available 6 hits

📄 src\GoogleTranslateIpCheck\GoogleTranslateIpCheck\Program.cs (line 18)

 {
     try
     {
▶        var json = File.ReadAllText(configFile);
         config = JsonSerializer.Deserialize(json, ConfigJsonContext.Default.Config);
     }
     catch

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\GoogleTranslateIpCheck\GoogleTranslateIpCheck\Program.cs (line 176)

                             Console.WriteLine($"{ip}");
                             _ips.Add(ip.ToString());
                             if (listIp.Count + _ips.Count >= config!.IP扫描限制数量)
▶                                cts.Cancel();
                         }
                         catch
                         {

💬 Async overload available for CancellationTokenSource.Cancel (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

Jellyfin

6 total diagnostics across 3 rules

SS003 Integer divided by integer causing implicit rounding 2 hits

No source samples extracted

SS017 Struct without Equals/GetHashCode/ToString overridden 2 hits

No source samples extracted

SS019 Switch is missing default label 2 hits

No source samples extracted

BenchmarkDotNet

4 total diagnostics across 1 rules

SS044 Attribute must specify [AttributeUsage] 4 hits

No source samples extracted

practical-aspnetcore

2 total diagnostics across 1 rules

SS033 Async overload is available 2 hits

📄 projects\application-environment\Program.cs (line 14)

 
     await context.Response.WriteAsync($"Version: {System.Reflection.Assembly.GetEntryAssembly().GetName().Version}<br/>");
 });
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 projects\application-environment\Program.cs (line 14)

 
     await context.Response.WriteAsync($"Version: {System.Reflection.Assembly.GetEntryAssembly().GetName().Version}<br/>");
 });
▶app.Run();

💬 Async overload available for WebApplication.Run (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

OFGB

2 total diagnostics across 1 rules

SS019 Switch is missing default label 2 hits

📄 MainWindow.xaml.cs (line 123)

 
         private static void ToggleOptions(string checkboxName, bool enable)
         {
▶            switch (checkboxName)
             {
                 case "cb1":
                     Registry.SetValue("HKEY_CURRENT_USER\\" + cur_ver + "Explorer\\Advanced\\", "ShowSyncProviderNotifications", Convert.ToInt32(!enable));

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

📄 MainWindow.xaml.cs (line 123)

 
         private static void ToggleOptions(string checkboxName, bool enable)
         {
▶            switch (checkboxName)
             {
                 case "cb1":
                     Registry.SetValue("HKEY_CURRENT_USER\\" + cur_ver + "Explorer\\Advanced\\", "ShowSyncProviderNotifications", Convert.ToInt32(!enable));

💬 Switch should have default label. (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS019-SwitchIsMissingDefaultLabel.md)

playwright-dotnet

2 total diagnostics across 1 rules

SS033 Async overload is available 2 hits

📄 src\tools\Playwright.Tooling\DriverDownloader.cs (line 75)

             var regex = new Regex("<!-- GEN:(.*?) -->(.*?)<!-- GEN:stop -->", RegexOptions.Compiled);
 
             var basePlaywrightDir = Environment.GetEnvironmentVariable("PW_SRC_DIR") ?? Path.Combine(Environment.CurrentDirectory, "..", "playwright");
▶            var readme = File.ReadAllText(Path.Combine(basePlaywrightDir, "README.md"));
             static string ReplaceBrowserVersion(string content, MatchCollection browserMatches)
             {
                 foreach (Match match in browserMatches)

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

📄 src\tools\Playwright.Tooling\DriverDownloader.cs (line 75)

             var regex = new Regex("<!-- GEN:(.*?) -->(.*?)<!-- GEN:stop -->", RegexOptions.Compiled);
 
             var basePlaywrightDir = Environment.GetEnvironmentVariable("PW_SRC_DIR") ?? Path.Combine(Environment.CurrentDirectory, "..", "playwright");
▶            var readme = File.ReadAllText(Path.Combine(basePlaywrightDir, "README.md"));
             static string ReplaceBrowserVersion(string content, MatchCollection browserMatches)
             {
                 foreach (Match match in browserMatches)

💬 Async overload available for File.ReadAllText (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS033-AsyncOverloadsAvailable.md)

Clean Repos (No Findings)

These repos produced zero SharpSource diagnostics:

✓ sqlite-net ✓ electrino ✓ docfx ✓ OptiKey ✓ WinMemoryCleaner ✓ PushSharp ✓ Open-XML-SDK ✓ shadowsocksr-csharp ✓ Opserver ✓ BetterJoy ✓ carnac ✓ Seatbelt ✓ Fody ✓ Monitorian ✓ naps2 ✓ wpftoolkit ✓ cake ✓ p2p ✓ WinAppDriver ✓ SyncClipboard ✓ Psychson ✓ clean-architecture-manga ✓ SubsCheck-Win-GUI ✓ MagicOnion ✓ RulesEngine ✓ PSReadLine ✓ SuperSocket ✓ Remotely ✓ clashN ✓ Lidarr ✓ protobuf-net ✓ SparkleShare ✓ Sheas-Cealer ✓ Umbraco-CMS ✓ Common.Utility ✓ msbuild ✓ Bloatynosy ✓ tModLoader ✓ Ladon ✓ SkiaSharp ✓ SophiApp ✓ perfview ✓ Text-Grab ✓ winforms ✓ BililiveRecorder ✓ Unity-Design-Pattern ✓ Covenant ✓ GalaxyBudsClient ✓ CliWrap ✓ Tai ✓ Rubeus ✓ mpv.net ✓ tixl ✓ WinDynamicDesktop ✓ NoteHighlight2016 ✓ Swashbuckle.WebApi ✓ TodoApp ✓ ComputeSharp ✓ MaterialSkin ✓ FFXIVQuickLauncher ✓ sdk ✓ SmartSystemMenu ✓ SoundSwitch ✓ Screenbox ✓ murder ✓ Cosmos ✓ extensions ✓ coverlet ✓ GARbro ✓ wincompose ✓ openrpa ✓ Graphics ✓ bloxstrap ✓ NBTExplorer ✓ osharp ✓ OpenDeepWiki ✓ FNA ✓ MyComputerManager ✓ DepotDownloader ✓ USBCopyer ✓ Pomelo.EntityFrameworkCore.MySql ✓ SharpLab ✓ copy-dialog-lunar-lander ✓ command-line-api ✓ elasticsearch-net ✓ SharpIDE ✓ neo ✓ YoutubeExplode ✓ AsyncEx ✓ TUnit ✓ MoreLINQ ✓ ravendb ✓ privatezilla ✓ SteamDesktopAuthenticator ✓ 163MusicLyrics ✓ oxyplot ✓ OneMore ✓ acat ✓ surging ✓ interactive ✓ run-aspnetcore-microservices ✓ FluentEmail ✓ OnTopReplica ✓ cognitive-services-speech-sdk ✓ Thrive ✓ AutoUpdater.NET ✓ Hawk ✓ TickerQ ✓ dafny ✓ win-acme ✓ RevokeMsgPatcher ✓ aspnetcore ✓ PowerShell ✓ semantic-kernel ✓ DevToys ✓ ShareX ✓ shadowsocks-windows ✓ WinUI-Gallery ✓ Verify ✓ Swashbuckle ✓ v2rayN ✓ PowerToys ✓ YARP ✓ maui ✓ YoutubeDownloader ✓ N_m3u8DL-CLI ✓ runtime ✓ Sonarr ✓ EverythingToolbar ✓ FileConverter ✓ ContextMenuManager ✓ roslyn ✓ UniGetUI ✓ QuickLook ✓ CMWTAT_Digital_Edition ✓ ml-agents ✓ PEASS-ng ✓ ILSpy ✓ Humanizer ✓ Hangfire ✓ MailKit ✓ language-ext ✓ ImageSharp ✓ Foundatio ✓ Brighter ✓ Bogus ✓ Avalonia ✓ FluentValidation ✓ EFCore.BulkExtensions ✓ CleanArchitecture ✓ Mapster ✓ Shouldly ✓ Refit ✓ ReactiveUI ✓ StackExchange.Redis ✓ spectre.console ✓ Silk.NET ✓ Prism ✓ MiniProfiler ✓ Mediator ✓ Marten ✓ NSwag ✓ NodaTime ✓ Newtonsoft.Json ✓ MonoGame ✓ downkyicore ✓ FlaxEngine ✓ ViVe ✓ Harmony ✓ ToastFish ✓ ScottPlot ✓ GameFramework ✓ ZyperWinOptimize ✓ HandyControl ✓ PixiEditor ✓ FlyOOBE ✓ sharpkeys ✓ Winhance ✓ openhardwaremonitor ✓ runner ✓ gsudo ✓ azure-sdk-for-net ✓ Everywhere ✓ workflow-core ✓ 1Remote ✓ graphql-dotnet ✓ Prowlarr ✓ dlss-swapper ✓ moq ✓ nvidiaProfileInspector ✓ websocket-sharp ✓ npoi ✓ mRemoteNG ✓ EarTrumpet ✓ Dependencies ✓ Kavita ✓ CefSharp ✓ DiscordChatExporter ✓ mono ✓ AspNetCore.Docs ✓ ArchiSteamFarm ✓ Radarr ✓ LKY_OfficeTools ✓ aspnetboilerplate ✓ PDFPatcher ✓ nopCommerce ✓ StabilityMatrix ✓ ailab ✓ blockchain ✓ stride ✓ Electron.NET ✓ wpf ✓ NETworkManager ✓ MahApps.Metro ✓ uno ✓ Notepads ✓ gitextensions ✓ Unity3DTraining ✓ DriverStoreExplorer

Skipped Repos

These repos could not be built (missing workloads, solution not found, etc.):

— html-agility-pack — Files — WaveFunctionCollapse — SteamTools — awesome-dotnet-core — osu — MaterialDesignInXamlToolkit — efcore — duplicati — abp — QuestPDF — Playnite — csharplang — ImageGlass — garnet — choco — Terminal.Gui — awesome-software-architecture — MudBlazor — ET — machinelearning — wpfui — jynew — BiliBiliToolPro — C-Sharp — EntityComponentSystemSamples — OrchardCore — MarkovJunior — DnsServer — elsa-core — clean-code-dotnet — UIEffect — reactive — AssetRipper — unity-mcp — dotnet-starter-kit — Borderless-Gaming — Mirror — MixedRealityToolkit-Unity — open-project-1 — ParrelSync — STranslate — KurrentDB — ProxySU — graphql-platform — MisakaTranslator — example-voting-app — ParticleEffectForUGUI — usbipd-win — Swashbuckle.AspNetCore — Malware-Patch — Libation — Parabolic — LittleBigMouse — QFramework — LiveCharts2 — markdig — NaughtyAttributes — FPSSample — openiddict-core — Unigram — MicaForEveryone — ZLinq — greenshot — Emby — CefFlashBrowser — one-day-one-language — MathUtilities — fluentui-blazor — sourcegit — qttabbar — azure-powershell — jint — Steamless — xunit — Digital-Logic-Sim — NatTypeTester — BootstrapBlazor — grpc-dotnet — ApplicationInspector — AspNetCore.Diagnostics.HealthChecks — Starward — NuGetForUnity — SSH.NET — UnityLibrary — testcontainers-dotnet — asm-dude — Harden-Windows-Security — AICommand — csharp-sdk — RetroBar — mapperly — MvvmCross — bflat — Magick.NET — scriban — sbox-public — crest — VRTK — XCharts — nuke — xNode — ysoserial.net — kiota — opentelemetry-dotnet — EventSourcing.NetCore — npgsql — dotnet — play-games-plugin-for-unity — Geographical-Adventures — Deform — FusionCache — redis-windows — space-station-14 — Skinner — AutoFixture — Blazorise — X-PostProcessing-Library — Templates — FancyScrollView — FOCA — Steamworks.NET — Pinta — mixbox — arfoundation-samples — LLPlayer — MiniExcel — referencesource — CppSharp — daggerfall-unity — UnrealCLR — Architecture — linq2db — EverythingPowerToys — evolutionary-architecture-by-example — UniVRM — aspnet-api-versioning — YooAsset — UnityGaussianSplatting — nbfc — GitVersion — NavMeshComponents — CommunityServer — tolua — UtinyRipper — BotSharp — obfuscar — behaviac — ZXing.Net — EasyNetQ — ReportGenerator — SharpSCADA — Pixeval — UnitsNet — AttackSurfaceAnalyzer — FairyGUI-unity — AsyncRAT-C-Sharp — Ben.Demystifier — Caliburn.Micro — ProceduralToolkit — graphy — StyleCopAnalyzers — macios